[Wikidata-bugs] [Maniphest] T157673: Don't use PHP serialization to determine revision size for Entities

2020-11-05 Thread thiemowmde
thiemowmde added a subscriber: Lydia_Pintscher. thiemowmde added a comment. It sounds like the only place that uses these numbers is the history. It displays both the page size for each revision (in a tooltip), as well as +/- changes. Touching this code will have these consequences

[Wikidata-bugs] [Maniphest] T221949: Remove uses of Title::moveTo

2020-11-04 Thread thiemowmde
thiemowmde edited projects, added MediaWiki-extensions-WikimediaMaintenance; removed MediaWiki-extensions-Maintenance. TASK DETAIL https://phabricator.wikimedia.org/T221949 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DannyS712, thiemowmde Cc

[Wikidata-bugs] [Maniphest] T236891: AdvancedSearch does not offer nor describe “incoming_links_desc” sort

2020-11-03 Thread thiemowmde
thiemowmde removed a project: MediaWiki-extensions-Maintenance. TASK DETAIL https://phabricator.wikimedia.org/T236891 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Aklapper, Lucas_Werkmeister_WMDE, Alter-paule, Beast1978, Un1tY

[Wikidata-bugs] [Maniphest] T236891: AdvancedSearch does not offer nor describe “incoming_links_desc” sort

2020-11-03 Thread thiemowmde
thiemowmde added a project: MediaWiki-extensions-Maintenance. TASK DETAIL https://phabricator.wikimedia.org/T236891 WORKBOARD https://phabricator.wikimedia.org/project/board/2323/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc

[Wikidata-bugs] [Maniphest] T236891: AdvancedSearch does not offer nor describe “incoming_links_desc” sort

2020-11-02 Thread thiemowmde
thiemowmde removed a project: archived--TCB-Team. TASK DETAIL https://phabricator.wikimedia.org/T236891 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Aklapper, Lucas_Werkmeister_WMDE, Alter-paule, Beast1978, Un1tY, Akuckartz

[Wikidata-bugs] [Maniphest] T236891: AdvancedSearch does not offer nor describe “incoming_links_desc” sort

2020-10-30 Thread thiemowmde
thiemowmde added a project: WMDE-Technical-Wishes-Team. TASK DETAIL https://phabricator.wikimedia.org/T236891 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Aklapper, Lucas_Werkmeister_WMDE, Alter-paule, Beast1978, Un1tY, dueltodeath

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 or v32.1 and retire wikibase-codesniffer

2020-10-29 Thread thiemowmde
thiemowmde added a comment. My suggestion for this migration would be to copy-paste the entire file https://github.com/wmde/WikibaseCodeSniffer/blob/master/Wikibase/ruleset.xml to every codebase that currently uses the WikibaseCodeSniffer, and slowly simplify it, e.g. remove exclusions you

[Wikidata-bugs] [Maniphest] T164653: Review rules in wikibase/wikibase-codesniffer and see which are appropriate for MW-CS

2020-10-29 Thread thiemowmde
thiemowmde added a comment. No, as far as I can see this was everything. I suggest to copy-paste the entire file https://github.com/wmde/WikibaseCodeSniffer/blob/master/Wikibase/ruleset.xml to every codebase that currently uses the WikibaseCodeSniffer, and slowly simplify it, e.g

[Wikidata-bugs] [Maniphest] T265992: Argument 1 passed to ViolationMessageSerializer::serializeEntityId() must be an instance of EntityId, string given

2020-10-29 Thread thiemowmde
thiemowmde moved this task from incoming to Features/bugs for next release on the Wikibase-Quality-Constraints board. thiemowmde added a project: WMDE-QWERTY-Sprint-2020-10-21. TASK DETAIL https://phabricator.wikimedia.org/T265992 WORKBOARD https://phabricator.wikimedia.org/project/board

[Wikidata-bugs] [Maniphest] T265992: Argument 1 passed to ViolationMessageSerializer::serializeEntityId() must be an instance of EntityId, string given

2020-10-27 Thread thiemowmde
thiemowmde claimed this task. thiemowmde added a project: Unplanned-Sprint-Work. thiemowmde set the point value for this task to "2". TASK DETAIL https://phabricator.wikimedia.org/T265992 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thi

[Wikidata-bugs] [Maniphest] T122711: Appending ".json" to an entity url should work (Feature Request)

2020-10-11 Thread thiemowmde
thiemowmde reopened this task as "Open". thiemowmde added a comment. With all the respect, but the task specifically asks to make https://www.wikidata.org/wiki/Q269728.json work. It might be that this is not something the Wikidata team want's to implement and maintain. If this is

[Wikidata-bugs] [Maniphest] T109420: [Story] Make exports formats more visible

2020-10-11 Thread thiemowmde
thiemowmde reopened subtask T122711: Appending .json to an entity url should work (Feature Request) as Open. TASK DETAIL https://phabricator.wikimedia.org/T109420 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Ivanhercaz

[Wikidata-bugs] [Maniphest] T169559: Imageheader Gadget at Wikidata - zoom of image

2020-09-16 Thread thiemowmde
thiemowmde closed this task as "Invalid". thiemowmde added a comment. Given this is 3 years old and not much information was given in the first place (no examples, no screen resolution), I will be a bit bold and close this for now. This doesn't mean the gadget can't be improved. It

[Wikidata-bugs] [Maniphest] T229939: Use wikidata entity selector in OOUI input field

2020-09-15 Thread thiemowmde
thiemowmde added a comment. I might oversimplify this, but exposing the API endpoint should be possible like that: name=In SpecialMathWikibase.php $settings = WikibaseClient::getDefaultInstance()->getSettings(); $url = $settings->getSetting( 'repoUrl' ); $scri

[Wikidata-bugs] [Maniphest] T229939: Use wikidata entity selector in OOUI input field

2020-09-14 Thread thiemowmde
thiemowmde added a comment. @Physikerwelt, sorry for not responding earlier. My advice is: don't use jquery.wikibase.entityselector. Write your own code, ideally based on OOUI, not jQuery. Seriously. It's your code then, and it does exactly what you want, which isn't that much. The existing

[Wikidata-bugs] [Maniphest] T229939: Use wikidata entity selector in OOUI input field

2020-09-10 Thread thiemowmde
thiemowmde added a comment. As far as I understand the issue is that whatever method you choose to load a module, it only works when the module is //known//, i.e. it is registered in the extension registration. The `jquery.wikibase.entityselector` module is part of WikibaseView. I had

[Wikidata-bugs] [Maniphest] T259783: LanguageFallbackChain does not end in 'en'

2020-08-06 Thread thiemowmde
thiemowmde added a comment. I believe this caused both T259744 <https://phabricator.wikimedia.org/T259744> and T259745 <https://phabricator.wikimedia.org/T259745>. I already created T259779 <https://phabricator.wikimedia.org/T259779> where I describe an idea that is a lit

[Wikidata-bugs] [Maniphest] T259779: LanguageFallbackChainFactory returns empty fallback chain when it shouldn't

2020-08-06 Thread thiemowmde
thiemowmde added a comment. T259744#6364309 <https://phabricator.wikimedia.org/T259744#6364309> mentions the patch that changed the behavior of the factory. It's now possible that language chains can be empty when the interface language is not a valid term language. There are a few la

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

2020-08-06 Thread thiemowmde
thiemowmde added a comment. This is actually the exact same root cause as in T259745 <https://phabricator.wikimedia.org/T259745>: The language fallback chain in question is empty, and calling `$languageCode = $languageCodes[0]` on an empty array results in the language code bein

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-06 Thread thiemowmde
thiemowmde added subscribers: Umherirrender, thiemowmde. thiemowmde added a comment. The problematic `...` was added in patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/538388 (T224772 <https://phabricator.wikimedia.org/T224772>) by @Umherirrender 10

[Wikidata-bugs] [Maniphest] T259779: LanguageFallbackChainFactory returns empty fallback chain when it shouldn't

2020-08-06 Thread thiemowmde
thiemowmde created this task. thiemowmde added projects: WikibaseMediaInfo, Wikidata, Wikimedia-production-error. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION While working on a hot-fix for T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag

[Wikidata-bugs] [Maniphest] T239208: Lexemes: Grammatical form can render as `[object Object]`

2020-08-04 Thread thiemowmde
thiemowmde added a comment. I was working on T249167 <https://phabricator.wikimedia.org/T249167> and T258337 <https://phabricator.wikimedia.org/T258337> and found what causes this: Never call `setLabel()` with anything but plain text. When you want a more complex HTML label

[Wikidata-bugs] [Maniphest] [Updated] T253624: Evaluate the future of wikibase-codesniffer

2020-06-26 Thread thiemowmde
thiemowmde added a comment. Related tickets: - In T243296#5820465 <https://phabricator.wikimedia.org/T243296#5820465> we briefly talked about the past and future of the custom Wikibase CodeSniffer already. - Via T164653 <https://phabricator.wikimedia.org/T164

[Wikidata-bugs] [Maniphest] [Updated] T255319: Eventually deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal

2020-06-17 Thread thiemowmde
thiemowmde removed a project: Move-Files-To-Commons. TASK DETAIL https://phabricator.wikimedia.org/T255319 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Aklapper, Krinkle, Ammarpad, Jdlrobson, Blissjay007, Oblanco79, Llanddewi

[Wikidata-bugs] [Maniphest] [Commented On] T252803: AffectedPagesFinder: Call to a member function exists() on null

2020-05-15 Thread thiemowmde
thiemowmde added a comment. This is caused by https://gerrit.wikimedia.org/r/594610, merged 9 days ago. Wikibase had a custom TitleFactory that was introduced very early, in 2014, see https://gerrit.wikimedia.org/r/168579. The duplicate in core was introduced very late, in 2019, see

[Wikidata-bugs] [Maniphest] [Commented On] T214300: Square brackets not allowed in URLs on Wikidata

2020-03-20 Thread thiemowmde
thiemowmde added a comment. Yes, I believe so. Short answer: It's not Wikibase, it's MediaWiki. https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/repo/includes/Validators/UrlSchemeValidators.php$53 https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes

[Wikidata-bugs] [Maniphest] [Commented On] T92009: Support more fine-grained date fields than xsd:dateTime

2020-03-18 Thread thiemowmde
thiemowmde added a comment. The question was: A lot of time values in the Wikidata database name a year only. Does it even make sense to export these as xsd:dateTime? Shouldn't we export these as xsd:gYear? TASK DETAIL https://phabricator.wikimedia.org/T92009 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T247458: PHP Notice: Undefined index: wgKartographerLiveData

2020-03-12 Thread thiemowmde
thiemowmde added a comment. I do not know the involved CachingKartographerEmbeddingHandler class in Wikibase very well. But according to what I see in https://codesearch.wmflabs.org/search/?q=wgKartographerLiveData I suspect that: 1. I believe this is **not** a serious issue. Just

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

2020-03-11 Thread thiemowmde
thiemowmde added a comment. When someone is able and willing to identify the original issue, we can undo code changes that are not needed any more then. As long as this is not the case let us please, please unblock people from working on these codebases. TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

2020-02-28 Thread thiemowmde
thiemowmde added a comment. I dug into the code and indeed found the place that creates constants based on what's said in extension.json: https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/registration/ExtensionRegistry.php$512. But this appears to be more like

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

2020-02-26 Thread thiemowmde
thiemowmde added a comment. I would like to ask another question: How is it a good idea do define a **PHP** constant in a .json file? How is my IDE supposed to find it there? In other words: As far as I'm concerned the duplication is a **must**. TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

2020-02-26 Thread thiemowmde
thiemowmde added a comment. Even if it's true that this started failing when a specific change in core was made. I still believe it is the extension that must be fixed. I might get this wrong, but my idea is: Code should not assume that the "namespaces" section from exte

[Wikidata-bugs] [Maniphest] [Commented On] T246211: Fatal error when trying to load Wikibase extension (master) with MediaWiki master

2020-02-26 Thread thiemowmde
thiemowmde added a comment. I think what you are missing is one of the steps described in Wikibase' README.md: `git submodule update --init` TASK DETAIL https://phabricator.wikimedia.org/T246211 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Commented On] T98035: [Task] Drop support for php-serialized output from Special:EntityData

2020-02-18 Thread thiemowmde
thiemowmde added a comment. Oh dear, I just realized how strange my comment from 2015 sounds by now. I totally support dropping this esoteric format! I believe PHP's internal serialization format should be something that's internal to PHP, and not be part of a public API. Please drop

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-02-18 Thread thiemowmde
thiemowmde added a comment. Thanks a lot for the detailed response! However, I feel my main point got lost. My question really is what the benefit of an isolated unit test for "being compatible with PSR-16" is? It's not like the class SimpleCacheWithBagOStuff is used in isola

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-02-17 Thread thiemowmde
thiemowmde added a comment. Wasn't this what @MaxSem tried already in https://gerrit.wikimedia.org/r/547911? What's the point of this library anyway? As far as I can tell it's used in a single (!) file: SimpleCacheWithBagOStuffTest. What does it do? What do we loose when we get rid

[Wikidata-bugs] [Maniphest] [Commented On] T167788: [Task] Dates written as 9/7/2017 should not always be parsed as American MM/DD/YYYY

2020-01-30 Thread thiemowmde
thiemowmde added a comment. I'm afraid such a comment won't make anybody work on this harder. TASK DETAIL https://phabricator.wikimedia.org/T167788 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Tagishsimon, The_RedBurn, JAnD

[Wikidata-bugs] [Maniphest] [Commented On] T167788: [Task] Dates written as 9/7/2017 should not always be parsed as American MM/DD/YYYY

2020-01-30 Thread thiemowmde
thiemowmde added a comment. As far as I understand the situation, it is not considered "broken". Whatever the user does, they **must** check the preview to see if the date parsers guess is correct. This won't change, no matter how good the parsers guess is. But yes, it's

[Wikidata-bugs] [Maniphest] [Commented On] T243296: Release a new version of WikibaseCodeSniffer

2020-01-23 Thread thiemowmde
thiemowmde added a comment. There is a .phpcs.xml in Wikibase. You can move the exclusions you want to keep to this file, including the comments explaining them. TASK DETAIL https://phabricator.wikimedia.org/T243296 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T243296: Release a new version of WikibaseCodeSniffer

2020-01-21 Thread thiemowmde
thiemowmde added subscribers: Lucas_Werkmeister_WMDE, WMDE-leszek, thiemowmde. thiemowmde added a comment. Note: I was the driving force when we introduced the WikibaseCodeSniffer rule set. The main motivations back then: 1. Being able to experiment with additional, custom sniffs

[Wikidata-bugs] [Maniphest] [Commented On] T167565: Wikidata allows invalid URIs to be entered as units

2019-11-20 Thread thiemowmde
thiemowmde added a comment. > […] we have to maintain list of units, globes, etc inside the code As suggested a while ago <https://phabricator.wikimedia.org/T167565#3359160>, I don't think it is necessary to make the code know what valid units, globes, etc. are. All I

[Wikidata-bugs] [Maniphest] [Unassigned] T118283: move testing things from browser tests to qunit or phpunit tests where possible

2019-10-02 Thread thiemowmde
thiemowmde removed thiemowmde as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T118283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: zeljkofilipin, Lydia_Pintscher, thiemowmde, Ladsgroup, WMDE-leszek

[Wikidata-bugs] [Maniphest] [Unblock] T88541: [DO NOT USE] Wikidata Browsertests (tracking) [superseded by #Browser-Tests]

2019-10-02 Thread thiemowmde
thiemowmde closed subtask T118283: move testing things from browser tests to qunit or phpunit tests where possible as Invalid. TASK DETAIL https://phabricator.wikimedia.org/T88541 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jonas, thiemowmde Cc

[Wikidata-bugs] [Maniphest] [Closed] T118283: move testing things from browser tests to qunit or phpunit tests where possible

2019-10-02 Thread thiemowmde
thiemowmde closed this task as "Invalid". thiemowmde added a comment. Closing, not because what this task asks for shouldn't be done, but because having this ticket does not help actually making it happen. It's old, contains barely any information, and is not on any board that i

[Wikidata-bugs] [Maniphest] [Unblock] T118283: move testing things from browser tests to qunit or phpunit tests where possible

2019-10-02 Thread thiemowmde
thiemowmde closed subtask T95420: [Task] Thin out scenario outlines on data value browsertest as Invalid. TASK DETAIL https://phabricator.wikimedia.org/T118283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: zeljkofilipin

[Wikidata-bugs] [Maniphest] [Unblock] T55845: Browsertests for currently used datavalues (tracking)

2019-10-02 Thread thiemowmde
thiemowmde closed subtask T95420: [Task] Thin out scenario outlines on data value browsertest as Invalid. TASK DETAIL https://phabricator.wikimedia.org/T55845 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Aklapper, WMDE-Fisch

[Wikidata-bugs] [Maniphest] [Closed] T95420: [Task] Thin out scenario outlines on data value browsertest

2019-10-02 Thread thiemowmde
thiemowmde closed this task as "Invalid". TASK DETAIL https://phabricator.wikimedia.org/T95420 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Aklapper, WMDE-Fisch, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSM

[Wikidata-bugs] [Maniphest] [Unassigned] T124784: [Task] Make the JavaScript data model immutable

2019-10-02 Thread thiemowmde
thiemowmde removed thiemowmde as the assignee of this task. thiemowmde edited subscribers, added: Ladsgroup, Jakob_WMDE, WMDE-leszek; removed: adrianheine, Jonas. thiemowmde removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T124784 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Unblock] T101836: [Task] Investigation how the repo edit-summary mechanism can be used on the client

2019-10-02 Thread thiemowmde
thiemowmde closed subtask T108681: [RFC] Create a new Wikibase-Change-Services component as Declined. TASK DETAIL https://phabricator.wikimedia.org/T101836 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, thiemowmde Cc: Addshore, Bene

[Wikidata-bugs] [Maniphest] [Declined] T108681: [RFC] Create a new Wikibase-Change-Services component

2019-10-02 Thread thiemowmde

[Wikidata-bugs] [Maniphest] [Unblock] T108296: [Epic] Remove WikibaseLib

2019-10-02 Thread thiemowmde
thiemowmde closed subtask T108681: [RFC] Create a new Wikibase-Change-Services component as Declined. TASK DETAIL https://phabricator.wikimedia.org/T108296 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: PokestarFan, Liuxinyu970226

[Wikidata-bugs] [Maniphest] [Unassigned] T153854: Warn if localSiteID is not a known site ID

2019-10-01 Thread thiemowmde
thiemowmde removed thiemowmde as the assignee of this task. thiemowmde added subscribers: Lucas_Werkmeister_WMDE, WMDE-leszek. thiemowmde added a project: Regression. TASK DETAIL https://phabricator.wikimedia.org/T153854 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Unassigned] T63958: Use existing $dateFormats to format dates on Wikidata

2019-10-01 Thread thiemowmde
thiemowmde removed thiemowmde as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T63958 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Kwj2772, Jarekt, C933103, Capankajsmilyo, jeblad, PokestarFan, revi

[Wikidata-bugs] [Maniphest] [Commented On] T174504: Coordinates are exported into RDF with excessive precision

2019-09-30 Thread thiemowmde
thiemowmde added a comment. Thanks for the additional analysis. Another thing I realized later is that this might cause //actual// data loss in the Wikidata database. This can happen when a tool uses data it got from the query service to edit the original Wikidata entity. I believe

[Wikidata-bugs] [Maniphest] [Unassigned] T174504: Coordinates are exported into RDF with excessive precision

2019-09-27 Thread thiemowmde
thiemowmde added subscribers: WMDE-leszek, Lydia_Pintscher, Lucas_Werkmeister_WMDE. thiemowmde moved this task from monitoring to needs discussion or investigation on the Wikidata board. thiemowmde added a project: Regression. thiemowmde removed Smalyshev as the assignee of this task. thiemowmde

[Wikidata-bugs] [Maniphest] [Unassigned] T142691: [Bug] wb_terms table truncates labels exceeding 255 bytes, possibly leaving invalid UTF-8

2019-09-11 Thread thiemowmde
thiemowmde removed thiemowmde as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T142691 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, Addshore, Sjoerddebruin, gerritbot, aude, Jonas, daniel

[Wikidata-bugs] [Maniphest] [Updated] T225195: EventBus jobs failing heavily because of CentralNotice and WikibaseRepo

2019-06-06 Thread thiemowmde
thiemowmde added a parent task: T225162: Tracking: flapping tests in gated extensions. TASK DETAIL https://phabricator.wikimedia.org/T225195 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: awight, thiemowmde, Aklapper, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Created] T225195: EventBus jobs failing heavily because of CentralNotice and WikibaseRepo

2019-06-06 Thread thiemowmde
thiemowmde created this task. thiemowmde added projects: Wikimedia-production-error (Shared Build Failure), MediaWiki-extensions-CentralAuth, EventBus, MediaWiki-extensions-WikibaseRepository. Restricted Application added a subscriber: Aklapper. Restricted Application added projects: Wikidata

[Wikidata-bugs] [Maniphest] [Commented On] T203337: Fix wbeditentity API ignoring setting aliases to an empty set

2019-05-10 Thread thiemowmde
thiemowmde added a comment. In case you are referring to the documentation in docs/change-op-serializations.wiki <https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/docs/change-op-serializations.wiki>, note I wrote this very late (in 2017), based on experiments and informa

[Wikidata-bugs] [Maniphest] [Triaged] T203337: Fix wbeditentity API ignoring setting aliases to an empty set

2019-05-10 Thread thiemowmde
thiemowmde triaged this task as "Low" priority. thiemowmde moved this task from incoming to needs discussion or investigation on the Wikidata board. thiemowmde added a project: good first bug. thiemowmde added a comment. Here is the line of code that is responsible for the curren

[Wikidata-bugs] [Maniphest] [Commented On] T221752: Cognate data is not restored (any more) on page undeletion

2019-05-03 Thread thiemowmde
thiemowmde added a comment. FYI, I found a way to fix the broken test. The issue seems to be that the test cases all use the same page. The second last test moves the page and turns it into a redirect. The last test tries to delete and restore the page, but restores the redirect instead

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

2019-04-25 Thread thiemowmde
thiemowmde added a comment. I'm somewhat confused what the relevance of these questions is, why they are asked, and who asks them. Are you a WMF or WMDE employee I'm not aware of? I don't know who "owns" the feature this ticket is about. It's on wikidata.org and falls into the

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

2019-04-25 Thread thiemowmde
thiemowmde added a comment. > you would be able to fix this issue if you were given it as a task by your line manager? It's open source software. People can change it and fix everything. The only question is how many resources people are willing to spend. In a worst-case scena

[Wikidata-bugs] [Maniphest] [Updated] T213704: Wikidata Tours don't load correctly

2019-04-24 Thread thiemowmde
thiemowmde added a comment. I believe we run into a very similar issue in the tour we have in the #two-column-edit-conflict-merge <https://phabricator.wikimedia.org/tag/two-column-edit-conflict-merge/> extension, see T195713: Have an intro tour (No. 2) <https://phabricator.wiki

[Wikidata-bugs] [Maniphest] [Closed] T128710: Create a Lua infobox template for books that use wikidata metadata based on work/edition

2019-04-24 Thread thiemowmde
thiemowmde closed this task as "Invalid". thiemowmde added a comment. - It was the author of this task who closed it. - The task description was not very specific and actionable to begin with. - This is something the Wikisource community can better manage on-wiki. I don't think

[Wikidata-bugs] [Maniphest] [Triaged] T221752: Cognate data is not restored (any more) on page undeletion

2019-04-24 Thread thiemowmde
thiemowmde triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T221752 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Aklapper, Anomie, aaron, Addshore, Lydia_Pintscher, thiemowmde,

[Wikidata-bugs] [Maniphest] [Created] T221752: Cognate data is not restored (any more) on page undeletion

2019-04-24 Thread thiemowmde
thiemowmde created this task. thiemowmde added projects: Cognate, Wikidata, Core Platform Team. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION I did a "git bisect" and tracked the issue down to this change: https://gerrit.wikimedia.org/r/501594 (T1883

[Wikidata-bugs] [Maniphest] [Commented On] T219499: Item pages should split alias entries containing | character to be consistent with Special:SetAliases

2019-04-11 Thread thiemowmde
thiemowmde added a comment. Asking users to provide "legitimate reasons" to be allowed to use one of the (literally) most basic <https://www.fileformat.info/info/unicode/block/basic_latin/list.htm> **characters** is, … how to put this? It scares me. It's like asking u

[Wikidata-bugs] [Maniphest] [Commented On] T219499: Item pages should split alias entries containing | character to be consistent with Special:SetAliases

2019-04-11 Thread thiemowmde
thiemowmde added a comment. Sorry for writing so much, but I feel there is an important lesson to learn here, despite this appearing like it would be a minor thing. I feel this highlights a quite fundamental misunderstanding. See, limiting the use of a character is, in a way

[Wikidata-bugs] [Maniphest] [Commented On] T219499: Item pages should split alias entries containing | character to be consistent with Special:SetAliases

2019-04-11 Thread thiemowmde
thiemowmde added a comment. > Item pages should split alias entries containing | character to be consistent with Special:SetAliases Oh my. I just realized this task was turned around, and the bug should now become a "feature". Why? Don't we have a UI that allows to pres

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T219499: Item pages should split alias entries containing | character to be consistent with Special:SetAliases

2019-04-11 Thread thiemowmde
thiemowmde added a subscriber: Lydia_Pintscher. thiemowmde added a comment. I'm afraid I have to agree with @Addshore here. Sure, it might be that many of the aliases that currently contain pipe characters are mistakes. It might even be the vast majority. But even if this is the case

[Wikidata-bugs] [Maniphest] [Commented On] T219499: Special:SetAliases should not be destructive when editing aliases that include the | character

2019-04-10 Thread thiemowmde
thiemowmde added a comment. I'm sorry for my rude comment at https://gerrit.wikimedia.org/r/502530. I made that in a hurry. The two relevant lines of code are these: - https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/repo/includes/Specials/SpecialSetAliases.php$82

[Wikidata-bugs] [Maniphest] [Unassigned] T143597: Consider using prefix search for Special:Search integration

2019-04-02 Thread thiemowmde
thiemowmde removed Lucie as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T143597 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: PokestarFan, daniel, aude, gerritbot, Lucie, Lydia_Pintscher, Aklapper, hoo

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T214761: Unit test Wikibase\Test\ClientDefaultsTest::testDefaults is flaky on MW Jenkins jobs

2019-01-28 Thread thiemowmde
thiemowmde added subscribers: Addshore, WMDE-leszek, thiemowmde.thiemowmde added a comment. Is there a chance this gets fixed fast? Otherwise we will temporarily disable the test. This should buy you enough time. The only thing you need to take care of then is to not forget to enable it again.TASK

[Wikidata-bugs] [Maniphest] [Updated] T207320: Advanced Search: Create page/item link missing for some users

2018-11-13 Thread thiemowmde
thiemowmde added subscribers: thiemowmde, Lydia_Pintscher.thiemowmde edited projects, added Wikidata, Wikidata.org; removed Advanced-Search.thiemowmde added a comment. There are two messages involved: https://translatewiki.org/wiki/MediaWiki:search-nonefound/en is shown when "there

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T86755: [Bug] Preview gadget no longer working in new sitelinks UI

2018-10-30 Thread thiemowmde
thiemowmde added a subscriber: matej_suchanek.thiemowmde added a comment. I believe the gadget in question is https://www.wikidata.org/wiki/MediaWiki:Gadget-Preview.js. It might be that this edit by @matej_suchanek fixed it: https://www.wikidata.org/wiki/Special:Diff/524430620. @matej_suchanek

[Wikidata-bugs] [Maniphest] [Updated] T206100: Wikibase\Lexeme\Tests\MediaWiki\Search\LexemeCompletionSearchTest fails on PHP 7.1

2018-10-08 Thread thiemowmde
thiemowmde added a project: Elasticsearch.thiemowmde added subscribers: Addshore, WMDE-leszek.Restricted Application added a project: Discovery-Search. TASK DETAILhttps://phabricator.wikimedia.org/T206100EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Updated] T205958: Wikibase\Repo\Search\Elastic\Tests\EntitySearchElasticFulltextTest::testSearchElastic fails on PHP 7.1

2018-10-08 Thread thiemowmde
thiemowmde added a project: Elasticsearch.thiemowmde added subscribers: Smalyshev, WMDE-leszek, Addshore.Restricted Application added a project: Discovery-Search. TASK DETAILhttps://phabricator.wikimedia.org/T205958EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Commented On] T144248: No RDF builder defined for data type time nor for value type bad in DispatchingValueSnakRdfBuilder::getValueBuilder

2018-09-19 Thread thiemowmde
thiemowmde added a comment. the problem does appear to be the precision Indeed. I don't have a programmatic suggestion then, other than somehow fixing these Items manually. Thanks for the hint to use Special:EntityData/….json!TASK DETAILhttps://phabricator.wikimedia.org/T144248EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T144248: No RDF builder defined for data type time nor for value type bad in DispatchingValueSnakRdfBuilder::getValueBuilder

2018-09-19 Thread thiemowmde
thiemowmde added projects: DataValues, Regression.thiemowmde added subscribers: Lucas_Werkmeister_WMDE, Addshore, Lydia_Pintscher.thiemowmde added a comment. There are indeed coordinate values in the database the current code can not deserialize any more: https://www.wikidata.org/wiki/Special:Diff

[Wikidata-bugs] [Maniphest] [Triaged] T204723: Normalize Wikimedia Commons file names via a ValueParser

2018-09-18 Thread thiemowmde
thiemowmde triaged this task as "Low" priority.thiemowmde added projects: Need-volunteer, Easy. TASK DETAILhttps://phabricator.wikimedia.org/T204723EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: hoo, WMDE-leszek, Jonas, Lydia

[Wikidata-bugs] [Maniphest] [Created] T204723: Normalize Wikimedia Commons file names via a ValueParser

2018-09-18 Thread thiemowmde
thiemowmde created this task.thiemowmde added projects: Wikidata, MediaWiki-extensions-WikibaseRepository, DataValues.Restricted Application added a subscriber: Aklapper. TASK DESCRIPTIONcommonsMedia values are stored as strings that contain the file name only, e.g. Example_en.svg refers to https

[Wikidata-bugs] [Maniphest] [Commented On] T99664: [Bug] Diff does not show stored capitalisation of first letter

2018-09-18 Thread thiemowmde
thiemowmde added a comment. In T99664#3848557I suggested to apply normalization to Wikimedia Commons file names before they are stored. This would solve a few related issues. Should I open a new ticket for this?TASK DETAILhttps://phabricator.wikimedia.org/T99664EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Unassigned] T102840: [Story] Disallow wikidata.org URIs to non-Item pages in unit/globe/calendar values

2018-09-04 Thread thiemowmde
thiemowmde removed thiemowmde as the assignee of this task.thiemowmde added a project: Need-volunteer. TASK DETAILhttps://phabricator.wikimedia.org/T102840EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Ricordisamoa, gerritbot, Lydia_Pintscher

[Wikidata-bugs] [Maniphest] [Unassigned] T47925: [Task] Apply normalization to string values in statements

2018-09-04 Thread thiemowmde
thiemowmde raised the priority of this task from "High" to "Needs Triage".thiemowmde removed thiemowmde as the assignee of this task.thiemowmde removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T47925EMAIL PREFERENCEShttps://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] [Closed] T173225: [Task] Tag releases of smaller Wikibase libraries significantly lagging behind

2018-09-04 Thread thiemowmde
thiemowmde closed this task as "Resolved".thiemowmde removed thiemowmde as the assignee of this task.thiemowmde updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[x] [serialization/serialization](https://github.com/wmde/Serialization) → [review code chan

[Wikidata-bugs] [Maniphest] [Triaged] T198179: Month name and year preceded or followed by a dot or comma is parsed as having a day

2018-09-04 Thread thiemowmde
thiemowmde added subscribers: thiemowmde, Addshore.thiemowmde added a project: Need-volunteer.thiemowmde triaged this task as "Low" priority.thiemowmde added a comment. This is an other situation where none of the (currently half a dozen) custom Wikibase parsers is able to understan

[Wikidata-bugs] [Maniphest] [Updated] T198179: Month name and year preceded or followed by a dot or comma is parsed as having a day

2018-09-04 Thread thiemowmde
thiemowmde added a parent task: T87764: Bugs related to time datatype (tracking). TASK DETAILhttps://phabricator.wikimedia.org/T198179EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Aklapper, Nikki, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Updated] T87764: Bugs related to time datatype (tracking)

2018-09-04 Thread thiemowmde
thiemowmde added a subtask: T198179: Month name and year preceded or followed by a dot or comma is parsed as having a day. TASK DETAILhttps://phabricator.wikimedia.org/T87764EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Mike_Peel, PokestarFan

[Wikidata-bugs] [Maniphest] [Commented On] T202676: Support non-Q and non-P items in custom Wikibase installations

2018-08-30 Thread thiemowmde
thiemowmde added a comment. I strongly suggest to go with one of these solutions: keyvalue feature_typeosm:Q123 wikidataQ456 something_elseosm:Q789 keyvalue osm_feature_typeQ123 wikidataQ456 osm_something_elseQ789 keyvalue osmbase_feature_typeQ123 wikidataQ456

[Wikidata-bugs] [Maniphest] [Commented On] T201226: Investigate whether Wikidata.org extension can be merged into other extensions

2018-08-29 Thread thiemowmde
thiemowmde added a comment. The idea of the #wikidata.org extension is to contain bits that are not true for all Wikibase installations but only for wikidata.org, and are not configuration (but code and binary files). This is especially true for the badge graphics, as they depend on particular

[Wikidata-bugs] [Maniphest] [Updated] T202676: Support non-Q and non-P items in custom Wikibase installations

2018-08-27 Thread thiemowmde
thiemowmde added subscribers: Lydia_Pintscher, WMDE-leszek.thiemowmde added a comment. TL;DR: I, personally, believe what appears to be a cosmetic issue in OSM UI should not be solved by changing the Wikibase data model. "Q" does not mean "wikidata.org". It means "

[Wikidata-bugs] [Maniphest] [Updated] T202676: Support non-Q and non-P items in custom Wikibase installations

2018-08-24 Thread thiemowmde
thiemowmde added a comment. I believe this is going the wrong direction, because numeric entity IDs are almost completely phased out already. A big chunk of that was done in 2016 via T56085, and a whole lot of other tickets, most notably the work the team put into migrating the wb_terms table

[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions

2018-08-20 Thread thiemowmde
thiemowmde added a comment. Sorry, I confused two ideas: Yes, we certainly can create a sniff that forbids class_exists( 'string' ). To make a sniff understand if a class_exists can be replaced with an ExtensionRegistry check, the sniff would need to know which class belongs to which extension

[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions

2018-08-19 Thread thiemowmde
thiemowmde added a comment. The Wikibase codebase currently contains about 40 class_exists checks. The vast majority checks for CirrusSearch – I guess because that extension still doesn't have an extension.json. Just making people aware of the issue is not very successful, as the most problematic

[Wikidata-bugs] [Maniphest] [Commented On] T188011: [Task] Use PHPUnit 6 forward compatibility aliases in all Wikibase code bases

2018-08-19 Thread thiemowmde
thiemowmde added a comment. Personally I don't think it makes sense to split this into subtasks. Either update all codebases the same way, or none. I furthermore suggest to close this as "declined" (as this is what the lack of interest by the Wikidata team tells me) and wait till

[Wikidata-bugs] [Maniphest] [Edited] T188011: [Task] Use PHPUnit 6 forward compatibility aliases in all Wikibase code bases

2018-08-19 Thread thiemowmde
thiemowmde updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...The suggestion is to **not** care about any of these, but exclusively focus on replacing `PHPUnit_Framework_TestCase` with `TestCase`. This is the vast majority of replacements we need to do (about 84% when I

[Wikidata-bugs] [Maniphest] [Commented On] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-08-15 Thread thiemowmde
thiemowmde added a comment. I just realized what this error message means: Some test (at the moment I don't know which) creates an Item, but this Item ends in code that expects a Lexeme. One possible improvement is to let FormIdTextFormatter::formatEntityId throw an exception when the Entity

[Wikidata-bugs] [Maniphest] [Commented On] T145932: [Bug] Special:NewItem does not validate maximum label length

2018-07-27 Thread thiemowmde
thiemowmde added a comment. Are we really checking characters? I seem to remember something else but am not entirely sure. The StringLengthValidator responsible for these checks allows to specify if it should count bytes (strlen) or characters (mb_strlen). In the current code it counts bytes

[Wikidata-bugs] [Maniphest] [Commented On] T118498: Rename "DataType" to "PropertyType" across the code base and documentation.

2018-07-12 Thread thiemowmde
thiemowmde added a comment. Personally, I don't think it makes sense to touch the string datatype in any machine-readable output. (In other words: I don't think this is worth a breaking change.) But I think it makes sense to prefer $propertyType as a variable name in code, and "property data

  1   2   3   4   5   6   7   8   9   10   >