[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

santhosh added a comment. Changed related to this ticket caused a bug in the Wikidata linking in #contenttranslation - T249458: ContentTranslation is not adding pages sitelinks to wikidata

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

Ladsgroup moved this task from Backlog to Done on the Wikibase Extension Decoupling and Registration (Sprint 4) board. Ladsgroup closed this task as "Resolved". Ladsgroup claimed this task. Ladsgroup added a comment. @Tarrow approved the idea on the mattermost, so with T259915: Deprecate

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

Lucas_Werkmeister_WMDE added a comment. In T256054#6330723 , @Ladsgroup wrote: > Suggestion: Create tickets for deprecating the configs and call this task done. What do you think @Lucas_Werkmeister_WMDE @Tarrow Sounds good to me.

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

darthmon_wmde edited projects, added Wikibase Extension Decoupling and Registration (Sprint 4); removed Wikibase Extension Decoupling and Registration (Sprint 3). TASK DETAIL https://phabricator.wikimedia.org/T256054 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

Ladsgroup added a comment. Suggestion: Create tickets for deprecating the configs and call this task done. What do you think @Lucas_Werkmeister_WMDE @Tarrow TASK DETAIL https://phabricator.wikimedia.org/T256054 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

Lucas_Werkmeister_WMDE closed subtask T257455: Decouple jquery.wikibase.siteselector RL module from client and repo as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T256054 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

Lucas_Werkmeister_WMDE closed subtask T257476: Decouple jquery.ui.suggester RL module from client and repo as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T256054 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc:

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

Lucas_Werkmeister_WMDE closed subtask T257475: Decouple util.highlightSubstring RL module from client and repo as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T256054 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

Ladsgroup removed Ladsgroup as the assignee of this task. Ladsgroup added a comment. Okay, I don't think we can do much more than this. Three RL modules left out of ~15 and I think we can outline a long-term plan to fix it but not doable in this hike. TASK DETAIL

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

gerritbot added a comment. Change 612671 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Removing dead code in client javascript https://gerrit.wikimedia.org/r/612671 TASK DETAIL https://phabricator.wikimedia.org/T256054 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

gerritbot added a comment. Change 612671 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] Removing dead code in client javascript https://gerrit.wikimedia.org/r/612671 TASK DETAIL https://phabricator.wikimedia.org/T256054

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

Ladsgroup added a comment. Also I found some more dead code (by removing dead code, you uncover more). Deleting them is not easy for a stupid reason: Their tests are convoluted so for example I can't drop getDataValues because the test for hasDataValues uses it...

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

Ladsgroup added a comment. I have some long-term ideas on how to proceed for `mw.config.values.wbSiteDetails` and `mw.config.values.wbRepo`. The problem with these modules is that they are polymorphic (the same config behaves differently in a repo and client, they are pretending to be the

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

gerritbot added a comment. Change 612615 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Migrate 'wikibase' RL module to view https://gerrit.wikimedia.org/r/612615 TASK DETAIL https://phabricator.wikimedia.org/T256054 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

gerritbot added a comment. Change 612597 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Migrate wikibase.api module to repo and use it directly in client https://gerrit.wikimedia.org/r/612597 TASK DETAIL https://phabricator.wikimedia.org/T256054 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

gerritbot added a comment. Change 612615 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] Migrate 'wikibase' RL module to view https://gerrit.wikimedia.org/r/612615 TASK DETAIL https://phabricator.wikimedia.org/T256054 EMAIL

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

gerritbot added a comment. Change 612597 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] Migrate wikibase.api module to repo and use it directly in client https://gerrit.wikimedia.org/r/612597 TASK DETAIL

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

Ladsgroup added a comment. In T256054#6304050 , @ItamarWMDE wrote: > In T256054#6302406 , @Ladsgroup wrote: > >> The above patch is the last thing I can do to make it decoupled

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

ItamarWMDE added a comment. In T256054#6302406 , @Ladsgroup wrote: > The above patch is the last thing I can do to make it decoupled without weird gymnastics, there are five more that I don't know if there's a way to decouple them

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.1; 2020-07-21). TASK DETAIL https://phabricator.wikimedia.org/T256054 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, ReleaseTaggerBot Cc: WMDE-leszek, Ladsgroup, Tarrow,

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

gerritbot added a comment. Change 612401 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Move wikibase.api.ValueCaller RL module from lib to view https://gerrit.wikimedia.org/r/612401 TASK DETAIL https://phabricator.wikimedia.org/T256054 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

Tarrow added a comment. It seems like for the wikibase api stuff we should probably take advantage of the fact it is a pseudo-npm module. I'm trying to think how TASK DETAIL https://phabricator.wikimedia.org/T256054 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

Ladsgroup moved this task from Verification to Peer Review on the Wikibase Extension Decoupling and Registration (Sprint 3) board. Ladsgroup added a comment. The above patch is the last thing I can do to make it decoupled without weird gymnastics, there are five more that I don't know if

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

gerritbot added a comment. Change 612401 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] Move wikibase.api.ValueCaller RL module from lib to view https://gerrit.wikimedia.org/r/612401 TASK DETAIL

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

Lucas_Werkmeister_WMDE reopened this task as "Open". Lucas_Werkmeister_WMDE moved this task from Done to Verification on the Wikibase Extension Decoupling and Registration (Sprint 3) board. Lucas_Werkmeister_WMDE added a comment. Wait, I’m not sure if this task is done, I thought this was one

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

Lucas_Werkmeister_WMDE closed subtask T257452: Decouple jquery.event.special.eachchange RL module from client and repo as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T256054 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup,

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE moved this task from Verification to Done on the Wikibase Extension Decoupling and Registration (Sprint 3) board. TASK DETAIL https://phabricator.wikimedia.org/T256054 WORKBOARD

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

Lucas_Werkmeister_WMDE closed subtask T257457: Decouple wikibase.buildErrorOutput RL module from client and repo as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T256054 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup,

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

Lucas_Werkmeister_WMDE closed subtask T257454: Decouple jquery.wikibase.wbtooltip RL module from client and repo as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T256054 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup,

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

gerritbot added a comment. Change 610898 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Decouple jquery.event.special.eachchange and util.inherit https://gerrit.wikimedia.org/r/610898 TASK DETAIL https://phabricator.wikimedia.org/T256054 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

gerritbot added a comment. Change 611415 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Fix use of wb.sites in PageConnector https://gerrit.wikimedia.org/r/611415 TASK DETAIL https://phabricator.wikimedia.org/T256054 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

gerritbot added a comment. Change 611415 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] Fix use of wb.sites in PageConnector https://gerrit.wikimedia.org/r/611415 TASK DETAIL https://phabricator.wikimedia.org/T256054 EMAIL