[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Arian_Bozorg closed this task as "Resolved". Arian_Bozorg moved this task from Product Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board. Arian_Bozorg added a comment. Thanks so much Lucas, Looks good to me :) TASK DETAIL https://phabricator.wikimedia.org/T219037

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Lucas_Werkmeister_WMDE added a comment. This should be live now, example : F36886577: image.png TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: ChristianKl, Arian_Bozorg, Sarai-WMDE, Michael,

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

gerritbot added a comment. Change 886909 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Show constraint clarifications below violation message https://gerrit.wikimedia.org/r/886909 TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.25; 2023-02-27); removed MW-1.40-notes (1.40.0-wmf.24; 2023-02-20). TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

gerritbot added a comment. Change 886916 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] README: Fix more maintenance calls https://gerrit.wikimedia.org/r/886916 TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

gerritbot added a comment. Change 886384 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Use LanguageFallbackChainFactory for multilingual texts https://gerrit.wikimedia.org/r/886384 TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

karapayneWMDE set the point value for this task to "8". TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, karapayneWMDE Cc: ChristianKl, Arian_Bozorg, Sarai-WMDE, Michael,

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.24; 2023-02-20); removed MW-1.40-notes (1.40.0-wmf.22; 2023-02-06). TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

gerritbot added a comment. Change 886383 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Don’t create new check result in downgradeResultStatus() https://gerrit.wikimedia.org/r/886383 TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

gerritbot added a comment. Change 886382 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add strict types to files about to be touched https://gerrit.wikimedia.org/r/886382 TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board. Lucas_Werkmeister_WMDE added a comment. In T219037#8589795 , @gerritbot wrote: > Change 886909 had a related patch set uploaded

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

gerritbot added a comment. Change 886916 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] README: Fix more maintenance calls https://gerrit.wikimedia.org/r/886916 TASK DETAIL

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

gerritbot added a comment. Change 886909 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Show constraint clarifications below violation message

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.22; 2023-02-06). TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot Cc: ChristianKl, Arian_Bozorg,

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

gerritbot added a comment. Change 886381 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Clean up ConstraintParameterParser doc comments https://gerrit.wikimedia.org/r/886381 TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

gerritbot added a comment. Change 886380 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Remove unused @throws from DelegatingConstraintChecker https://gerrit.wikimedia.org/r/886380 TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Lucas_Werkmeister_WMDE added a comment. These are just preparation patches, I’m not done with the tests for the main part yet. Leaving the task in Doing, though if anyone wants to start reviewing that’s also okay. TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

gerritbot added a comment. Change 886384 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Use LanguageFallbackChainFactory for multilingual texts

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

gerritbot added a comment. Change 886383 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Don’t create new check result in downgradeResultStatus()

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

gerritbot added a comment. Change 886382 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add strict types to files about to be touched https://gerrit.wikimedia.org/r/886382

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: ChristianKl, Arian_Bozorg, Sarai-WMDE, Michael, Naseweis520,

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

gerritbot added a comment. Change 886381 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Clean up ConstraintParameterParser doc comments https://gerrit.wikimedia.org/r/886381

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

gerritbot added a comment. Change 886380 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Remove unused @throws from DelegatingConstraintChecker

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Arian_Bozorg updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: ChristianKl, Arian_Bozorg, Sarai-WMDE, Michael, Naseweis520, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

ChristianKl added a comment. I would prefer wikitext over normal text, so that it would be "Use {{unknown value}} instead of anonymous when the author is unknown." in the example. New users might not know what "unknown value" happens to be and the wikitext template gives the user the link

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Lucas_Werkmeister_WMDE added a comment. Alright, I left a message at https://www.wikidata.org/wiki/Property_talk:P6607#Suggestion:_Write_constraint_clarifications_as_full_sentences. TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Arian_Bozorg added a comment. Thank you so much Sarai and Lucas I think this option showing the clarification under the violation works best: F36524797: Screenshot 2023-01-27 at 11.27.53.png Some may have multiple constraint violations and

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Arian_Bozorg updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Sarai-WMDE, Michael, Naseweis520, Lydia_Pintscher, Lectrician1, Moebeus, Thadguidry,

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Lucas_Werkmeister_WMDE added a comment. > I hope that applying the right capitalization and punctuation is a no-sweat. I don’t think we should do this by default (though it’s technically possible); assuming editors agree, we should just recommend that constraint clarifications are

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Sarai-WMDE, Michael, Naseweis520, Lydia_Pintscher, Lectrician1, Moebeus, Thadguidry,

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Sarai-WMDE removed Sarai-WMDE as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Sarai-WMDE, Michael, Naseweis520, Lydia_Pintscher, Lectrician1, Moebeus,

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Michael, Naseweis520, Lydia_Pintscher, Lectrician1, Moebeus, Thadguidry, Esc3300,

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Sarai-WMDE added a comment. In T219037#8564048 , @Lucas_Werkmeister_WMDE wrote: >> This is actually the first option that came to mind for me too, but then I assumed that we were compelled to link to the property from where the

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Lucas_Werkmeister_WMDE added a comment. > This is actually the first option that came to mind for me too, but then I assumed that we were compelled to link to the property from where the information is proceeding. The constraint type in the heading (“none-of constraint” in the

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Sarai-WMDE added a comment. In T219037#8560695 , @Lucas_Werkmeister_WMDE wrote: > I was thinking of adding the clarification message as a separate paragraph below the main constraint message, but under the same heading: > F36511668:

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Lucas_Werkmeister_WMDE added a comment. I was thinking of adding the clarification message as a separate paragraph below the main constraint message, but under the same heading: F36511668: image.png (Maybe something like “clarification:” could

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Sarai-WMDE added a comment. The UI change to enable the suggested solution is pretty straightforward. Nevertheless, before we decide to follow this route, I'm compelled to share some thoughts for consideration. Following the current structure, constraint clarifications would be added in

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Sarai-WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Naseweis520, Lydia_Pintscher, Lectrician1, Moebeus, Thadguidry, Esc3300, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Arian_Bozorg updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Naseweis520, Lydia_Pintscher, Lectrician1, Moebeus, Thadguidry, Esc3300,

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Arian_Bozorg triaged this task as "High" priority. Arian_Bozorg updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Naseweis520, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Arian_Bozorg added a project: Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Naseweis520, Lydia_Pintscher, Lectrician1, Moebeus, Thadguidry, Esc3300,

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Arian_Bozorg updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Lydia_Pintscher, Lectrician1, Moebeus, Thadguidry, Esc3300, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Lydia_Pintscher added a comment. Example: F35841294: image.png TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc:

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Lydia_Pintscher added a comment. An example for a current constraint clarification statement we can use: https://www.wikidata.org/wiki/Property:P18#P18$2fcb3e0b-4ede-5357-fb07-3d1b4b026b30 TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Esc3300 added a comment. related: T277826 TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Esc3300 Cc: Thadguidry, Esc3300, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T219037: Display constraint clarifications in violation messages

Thadguidry added a comment. I'd like to see this made a bit higher priority? It seems it would be fairly trivial to implement with a good impact. TASK DETAIL https://phabricator.wikimedia.org/T219037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/