[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[santhosh]

santhosh added a comment.


  Changed related to this ticket caused a bug in the Wikidata linking in 
#contenttranslation  
  - T249458: ContentTranslation is not adding pages sitelinks to wikidata 


TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, santhosh
Cc: santhosh, WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Izno, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[Ladsgroup]

Ladsgroup moved this task from Backlog to Done on the Wikibase Extension 
Decoupling and Registration (Sprint 4) board.
Ladsgroup closed this task as "Resolved".
Ladsgroup claimed this task.
Ladsgroup added a comment.


  @Tarrow approved the idea on the mattermost, so with T259915: Deprecate 
mw.config.values.wbSiteDetails  and 
T259914: Deprecate mw.config.values.wbRepo 
, this is done.

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4916/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Izno, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  In T256054#6330723 , 
@Ladsgroup wrote:
  
  > Suggestion: Create tickets for deprecating the configs and call this task 
done. What do you think @Lucas_Werkmeister_WMDE @Tarrow
  
  Sounds good to me.

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Izno, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[darthmon_wmde]

darthmon_wmde edited projects, added Wikibase Extension Decoupling and 
Registration (Sprint 4); removed Wikibase Extension Decoupling and Registration 
(Sprint 3).

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: darthmon_wmde
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Izno, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[Ladsgroup]

Ladsgroup added a comment.


  Suggestion: Create tickets for deprecating the configs and call this task 
done. What do you think @Lucas_Werkmeister_WMDE @Tarrow

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed subtask T257455: Decouple 
jquery.wikibase.siteselector RL module from client and repo as 
Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed subtask T257476: Decouple jquery.ui.suggester RL 
module from client and repo as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed subtask T257475: Decouple util.highlightSubstring 
 RL module from client and repo as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[Ladsgroup]

Ladsgroup removed Ladsgroup as the assignee of this task.
Ladsgroup added a comment.


  Okay, I don't think we can do much more than this. Three RL modules left out 
of ~15 and I think we can outline a long-term plan to fix it but not doable in 
this hike.

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[gerritbot]

gerritbot added a comment.


  Change 612671 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Removing dead code in client javascript
  
  https://gerrit.wikimedia.org/r/612671

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[gerritbot]

gerritbot added a comment.


  Change 612671 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [mediawiki/extensions/Wikibase@master] Removing dead code in client javascript
  
  https://gerrit.wikimedia.org/r/612671

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[Ladsgroup]

Ladsgroup added a comment.


  Also I found some more dead code (by removing dead code, you uncover more). 
Deleting them is not easy for a stupid reason: Their tests are convoluted so 
for example I can't drop getDataValues because the test for hasDataValues uses 
it...
  
amsa@amsa-Latitude-7480:~/workspace$ python unused_js_functions.py 
~/Wikibase
/home/amsa/Wikibase/view/lib/wikibase-data-values/src/dataValues.js 
getDataValues
/home/amsa/Wikibase/view/lib/wikibase-data-values/src/dataValues.js 
hasDataValue
/home/amsa/Wikibase/view/lib/wikibase-data-model/src/Fingerprint.js hasLabel
/home/amsa/Wikibase/view/lib/wikibase-data-model/src/Fingerprint.js 
hasDescription
/home/amsa/Wikibase/view/lib/wikibase-data-model/src/Fingerprint.js 
hasAliases

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[Ladsgroup]

Ladsgroup added a comment.


  I have some long-term ideas on how to proceed for 
`mw.config.values.wbSiteDetails` and `mw.config.values.wbRepo`. The problem 
with these modules is that they are polymorphic (the same config behaves 
differently in a repo and client, they are pretending to be the same thing but 
they are not) and they even too outdated to be useful (which repo? commons or 
wikidata?). I think they need to be deprecated and broken apart. It's way out 
of scope of this hike and not a small size of work either. We can outline this 
and leave it for future devs to pick it up.

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[gerritbot]

gerritbot added a comment.


  Change 612615 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Migrate 'wikibase' RL module to view
  
  https://gerrit.wikimedia.org/r/612615

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[gerritbot]

gerritbot added a comment.


  Change 612597 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Migrate wikibase.api module to repo 
and use it directly in client
  
  https://gerrit.wikimedia.org/r/612597

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[gerritbot]

gerritbot added a comment.


  Change 612615 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [mediawiki/extensions/Wikibase@master] Migrate 'wikibase' RL module to view
  
  https://gerrit.wikimedia.org/r/612615

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[gerritbot]

gerritbot added a comment.


  Change 612597 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [mediawiki/extensions/Wikibase@master] Migrate wikibase.api module to repo 
and use it directly in client
  
  https://gerrit.wikimedia.org/r/612597

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[Ladsgroup]

Ladsgroup added a comment.


  In T256054#6304050 , 
@ItamarWMDE wrote:
  
  > In T256054#6302406 , 
@Ladsgroup wrote:
  >
  >> The above patch is the last thing I can do to make it decoupled without 
weird gymnastics, there are five more that I don't know if there's a way to 
decouple them properly:
  >>
  >> - `mw.config.values.wbSiteDetails`: Build using php code living in lib, 
heavily used in both client and repo: 
https://codesearch.wmflabs.org/search/?q=wbSiteDetails=nope==
  >>   - We might split the php file into two and copy them?
  >> - `mw.config.values.wbRepo`: Same, heavily used everywhere.
  >
  > As they both rely on php code, it seems like the easier option, but there's 
probably more digging around to do here.
  
  I'm not sure it'll be possible for the second one.
  
  >> - `wikibase` basic nonsense code that defines wikibase global object which 
is used everywhere.
  >
  > The fact that it's nonsensical global var bootstrapping means we can 
probably safely duplicate this file to client. as long as the sub-namespaces 
are available:
  >
  > `wikibase.sites` <-- Defined in WikibaseLib
  > `wikibase.api` <-- Defined in WikibaseLib
  
  Yeah, let's do that. I make a patch for this one.
  
  >> - `wikibase.api.RepoApi`: both client and repo depend on it and the 
obvious solution is to copy-paste it in both places but all of the code lives 
in a git submodule.
  >>   - Have two identical submodule?
  >>   - Don't give a damn and define it twice while both pointing to the same 
file, how is it different from status quo?
  >
  > IMHO this is a perfect candidate for a JS module to test the monorepo 
approach with.
  >
  >> - `wikibase.Site` defined dynamically through a hook in lib. Fun.
  >>   - Copy the hook handler and the code?
  >
  > I don't think it is necessary to copy the code, shouldn't we follow ADR 13 
in this case and just define the hook both in `extension-repo.json` and 
`extension-client.json`?
  
  That's the status quo but the code sits in one place for both classes, 
meaning they are shared and coupled.

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[ItamarWMDE]

ItamarWMDE added a comment.


  In T256054#6302406 , 
@Ladsgroup wrote:
  
  > The above patch is the last thing I can do to make it decoupled without 
weird gymnastics, there are five more that I don't know if there's a way to 
decouple them properly:
  >
  > - `mw.config.values.wbSiteDetails`: Build using php code living in lib, 
heavily used in both client and repo: 
https://codesearch.wmflabs.org/search/?q=wbSiteDetails=nope==
  >   - We might split the php file into two and copy them?
  > - `mw.config.values.wbRepo`: Same, heavily used everywhere.
  
  As they both rely on php code, it seems like the easier option, but there's 
probably more digging around to do here.
  
  > - `wikibase` basic nonsense code that defines wikibase global object which 
is used everywhere.
  
  The fact that it's nonsensical global var bootstrapping means we can probably 
safely duplicate this file to client. as long as the sub-namespaces are 
available:
  
  `wikibase.sites` <-- Defined in WikibaseLib
  `wikibase.api` <-- Defined in WikibaseLib
  
  > - `wikibase.api.RepoApi`: both client and repo depend on it and the obvious 
solution is to copy-paste it in both places but all of the code lives in a git 
submodule.
  >   - Have two identical submodule?
  >   - Don't give a damn and define it twice while both pointing to the same 
file, how is it different from status quo?
  
  IMHO this is a perfect candidate for a JS module to test the monorepo 
approach with.
  
  > - `wikibase.Site` defined dynamically through a hook in lib. Fun.
  >   - Copy the hook handler and the code?
  
  I don't think it is necessary to copy the code, shouldn't we follow ADR 13 in 
this case and just define the hook both in `extension-repo.json` and 
`extension-client.json`?

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, ItamarWMDE
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[ReleaseTaggerBot]

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, ReleaseTaggerBot
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[gerritbot]

gerritbot added a comment.


  Change 612401 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Move wikibase.api.ValueCaller RL 
module from lib to view
  
  https://gerrit.wikimedia.org/r/612401

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[Tarrow]

Tarrow added a comment.


  It seems like for the wikibase api stuff we should probably take advantage of 
the fact it is a pseudo-npm module. I'm trying to think how

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Tarrow
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[Ladsgroup]

Ladsgroup moved this task from Verification to Peer Review on the Wikibase 
Extension Decoupling and Registration (Sprint 3) board.
Ladsgroup added a comment.


  The above patch is the last thing I can do to make it decoupled without weird 
gymnastics, there are five more that I don't know if there's a way to decouple 
them properly:
  
  - `mw.config.values.wbSiteDetails`: Build using php code living in lib, 
heavily used in both client and repo: 
https://codesearch.wmflabs.org/search/?q=wbSiteDetails=nope==
- We might split the php file into two and copy them?
  - `mw.config.values.wbRepo`: Same, heavily used everywhere.
  - `wikibase` basic nonsense code that defines wikibase global object which is 
used everywhere.
  - `wikibase.api.RepoApi`: both client and repo depend on it and the obvious 
solution is to copy-paste it in both places but all of the code lives in a git 
submodule.
- Have two identical submodule?
- Don't give a damn and define it twice while both pointing to the same 
file, how is it different from status quo?
  - `wikibase.Site` defined dynamically through a hook in lib. Fun.
- Copy the hook handler and the code?

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4875/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[gerritbot]

gerritbot added a comment.


  Change 612401 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [mediawiki/extensions/Wikibase@master] Move wikibase.api.ValueCaller RL 
module from lib to view
  
  https://gerrit.wikimedia.org/r/612401

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE reopened this task as "Open".
Lucas_Werkmeister_WMDE moved this task from Done to Verification on the 
Wikibase Extension Decoupling and Registration (Sprint 3) board.
Lucas_Werkmeister_WMDE added a comment.


  Wait, I’m not sure if this task is done, I thought this was one of the 
subtasks.

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4875/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed subtask T257452: Decouple 
jquery.event.special.eachchange RL module from client and repo as 
Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE moved this task from Verification to Done on the 
Wikibase Extension Decoupling and Registration (Sprint 3) board.

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4875/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed subtask T257457: Decouple 
wikibase.buildErrorOutput RL module from client and repo as 
Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed subtask T257454: Decouple 
jquery.wikibase.wbtooltip RL module from client and repo as 
Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[gerritbot]

gerritbot added a comment.


  Change 610898 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Decouple 
jquery.event.special.eachchange and util.inherit
  
  https://gerrit.wikimedia.org/r/610898

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[gerritbot]

gerritbot added a comment.


  Change 611415 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Fix use of wb.sites in PageConnector
  
  https://gerrit.wikimedia.org/r/611415

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256054: Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code

[gerritbot]

gerritbot added a comment.


  Change 611415 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [mediawiki/extensions/Wikibase@master] Fix use of wb.sites in PageConnector
  
  https://gerrit.wikimedia.org/r/611415

TASK DETAIL
  https://phabricator.wikimedia.org/T256054

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, 
ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs