[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

[Lydia_Pintscher]

Lydia_Pintscher closed this task as "Resolved".
Lydia_Pintscher moved this task from Test (Verification) to Done on the 
Wikidata Query Builder (Wikidata Query Builder - sprint 5) board.
Lydia_Pintscher added a comment.


  \o/

TASK DETAIL
  https://phabricator.wikimedia.org/T267733

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5090/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Lydia_Pintscher
Cc: Lydia_Pintscher, guergana.tzatchkova, Aklapper, Michael, Manishsamota, 
Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

[Michael]

Michael moved this task from Peer Review to Test (Verification) on the Wikidata 
Query Builder (Wikidata Query Builder - sprint 5) board.
Michael added a comment.


  RTL seems fine in general. The currently existing issue with the "Add 
Condition"-Button is being worked on in T269438 
.
  
  T270111  was created to look into 
an alternative font for arabic script for the headline.

TASK DETAIL
  https://phabricator.wikimedia.org/T267733

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5090/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Michael
Cc: guergana.tzatchkova, Aklapper, Michael, Manishsamota, Hazizibinmahdi, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

[Ladsgroup]

Ladsgroup added a comment.


  In T267733#6662857 , 
@Michael wrote:
  
  > Ok, cool.
  >
  > - Should we create an extra ticket to consider using a different font for 
the heading for languages that use the Arabic script?
  
  Yeah. I think this is bigger than query builder (probably part of wikit?)
  
  > - Does this need any more work now or is it enough to keep occasionally 
checking with RTL languages as we develop the app?
  
  Yup, indeed.

TASK DETAIL
  https://phabricator.wikimedia.org/T267733

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: guergana.tzatchkova, Aklapper, Michael, Manishsamota, Hazizibinmahdi, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

[Michael]

Michael added a comment.


  Ok, cool.
  
  - Should we create an extra ticket to consider using a different font for the 
heading for languages that use the Arabic script?
  - Does this need any more work now or is it enough to keep occasionally 
checking with RTL languages as we develop the app?

TASK DETAIL
  https://phabricator.wikimedia.org/T267733

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Michael
Cc: guergana.tzatchkova, Aklapper, Michael, Manishsamota, Hazizibinmahdi, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

[Ladsgroup]

Ladsgroup moved this task from ❌ Blocked to Peer Review on the Wikidata Query 
Builder (Wikidata Query Builder - sprint 5) board.
Ladsgroup added a comment.


  Looks okay to me so far: https://query-builder-test.toolforge.org/?uselang=fa

TASK DETAIL
  https://phabricator.wikimedia.org/T267733

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5090/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: guergana.tzatchkova, Aklapper, Michael, Hazizibinmahdi, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

[Lydia_Pintscher]

Lydia_Pintscher moved this task from  Wikidata Query Builder - sprint 4 to 
Wikidata Query Builder - sprint 5 on the Wikidata Query Builder board.
Lydia_Pintscher edited projects, added Wikidata Query Builder (Wikidata Query 
Builder - sprint 5); removed Wikidata Query Builder ( Wikidata Query Builder - 
sprint 4).

TASK DETAIL
  https://phabricator.wikimedia.org/T267733

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4990/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Lydia_Pintscher
Cc: guergana.tzatchkova, Aklapper, Michael, Hazizibinmahdi, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

[Michael]

Michael moved this task from Peer Review to ❌ Blocked on the Wikidata Query 
Builder ( Wikidata Query Builder - sprint 4) board.
Michael added a comment.


  I'd say let's have another look at this when T267731 
 is merged. Then we can create the 
Persian translations and reproducibly hone in on the problems

TASK DETAIL
  https://phabricator.wikimedia.org/T267733

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5079/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Michael
Cc: guergana.tzatchkova, Aklapper, Michael, Hazizibinmahdi, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

[Ladsgroup]

Ladsgroup added a comment.


  In T267733#6633196 , 
@guergana.tzatchkova wrote:
  
  > @Ladsgroup 
  > Suggestions from Navigators Summit:
  >
  > - Did we check how Termbox's use of RTL?
  
  It uses RtlDetectLib which is nice but so far I haven't had the need to use 
it in QB. Good to keep it in mind though.
  
  > - Do not use CSS Janus. Let's use CSS logical properties.
  
  We use logical CSS properties so we should not use cssjanus but OTOH, it's 
not supported in IE11 https://caniuse.com/?search=logical%20properties and I'm 
not sure you can just use a transpiler for it. Needs more investigation.

TASK DETAIL
  https://phabricator.wikimedia.org/T267733

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: guergana.tzatchkova, Aklapper, Michael, Hazizibinmahdi, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

[guergana.tzatchkova]

guergana.tzatchkova added a comment.


  @Ladsgroup 
  Suggestions from Navigators Summit:
  
  - Did we check how Termbox's use of RTL?
  - Do not use CSS Janus. Let's use CSS logical properties.

TASK DETAIL
  https://phabricator.wikimedia.org/T267733

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, guergana.tzatchkova
Cc: guergana.tzatchkova, Aklapper, Michael, Hazizibinmahdi, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

[Ladsgroup]

Ladsgroup added a comment.


  In T267733#6629940 , 
@Michael wrote:
  
  >> - The result iframe is all in English and LTR, fixing it wouldn't be easy, 
I don't think we can use non-ASCII characters for variable names.
  >
  > Could you explain a bit more? Which variable names are you thinking about?
  
  I mean `?item` in the query result.

TASK DETAIL
  https://phabricator.wikimedia.org/T267733

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Aklapper, Michael, Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

[Michael]

Michael added a comment.


  In T267733#6627887 , 
@Ladsgroup wrote:
  
  > Mostly it looks good but:
  >
  > - The fallback result when there's no label in Persian is RTL but it should 
be LTR
  
  Fixing that might be tricky. We could wrap all things we language in them in 
``, Otherwise, we may have to do it on a per-case basis which would 
require us getting that info from vue-banana-i18n?
  
  > - The result iframe is all in English and LTR, fixing it wouldn't be easy, 
I don't think we can use non-ASCII characters for variable names.
  
  Could you explain a bit more? Which variable names are you thinking about?
  
  > - RTL support is a continuous work in progress, while currently the RTL 
issues are minor, I think we don't keep tap on them and with the query builder 
getting more complex, we will end up with really large issues at hand.
  
  
  
  > - The font of the title is terrible for Persian, it's so bad for Persian 
that it's hurting my eyes :( If I understood the dev tool correctly, it's 
"Linux Libertine"
  
  That is fortunately easy to change. But let's look at it again when one can 
actually view the Query Builder in Persian

TASK DETAIL
  https://phabricator.wikimedia.org/T267733

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Michael
Cc: Aklapper, Michael, Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

[Ladsgroup]

Ladsgroup added a comment.


  So I changed everything to Persian and even uploaded it as a POC PR: 
https://github.com/wmde/query-builder/pull/64
  
  Here's is my observations (they are not necessarily all RTL issues):
  F33917654: image.png 
  F33917656: image.png 
  F33917658: image.png 
  Mostly it looks good but:
  
  - The fallback result when there's no label in Persian is RTL but it should 
be LTR
  - The result iframe is all in English and LTR, fixing it wouldn't be easy, I 
don't think we can use non-ASCII characters for variable names.
  - RTL support is a continuous work in progress, while currently the RTL 
issues are minor, I think we don't keep tap on them and with the query builder 
getting more complex, we will end up with really large issues at hand.
  - The font of the title is terrible for Persian, it's so bad for Persian that 
it's hurting my eyes :( If I understood the dev tool correctly, it's "Linux 
Libertine"

TASK DETAIL
  https://phabricator.wikimedia.org/T267733

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Aklapper, Michael, Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

[Ladsgroup]

Ladsgroup claimed this task.
Ladsgroup moved this task from To Do to Doing on the Wikidata Query Builder ( 
Wikidata Query Builder - sprint 4) board.
Restricted Application added a project: User-Ladsgroup.

TASK DETAIL
  https://phabricator.wikimedia.org/T267733

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5079/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Aklapper, Michael, Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

[Michael]

Michael created this task.
Michael added projects: Wikidata, Wikidata Query Builder ( Wikidata Query 
Builder - sprint 4).
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  - Does changing the language to an RTL language cause RTL-specific bugs?
  - Do we need to use some css-flipper like CSS-Janus?
  - Would `bdi` work properly? Fallbacks, textinput, ...

TASK DETAIL
  https://phabricator.wikimedia.org/T267733

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs