[Wikidata-bugs] [Maniphest] [Commented On] T132244: Regression: New line after images at fr.wikivoyage

2016-05-04 Thread Omondi
Omondi added a comment. In https://phabricator.wikimedia.org/T132244#2243375, @Jdlrobson wrote: > Fix will be live Wed 4th May. Let me know if this fix is needed more urgently. I could always make that happen on Thursday. TASK DETAIL https://phabricator.wikimedia.org/T132244 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T133470: [Task] Remove outdated message "Wikibase-after-page-move"

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 286213 abandoned by Thiemo Mättig (WMDE): i18n wikibase-after-page-move removed Reason: See https://phabricator.wikimedia.org/T133470. https://gerrit.wikimedia.org/r/286213 TASK DETAIL https://phabricator.wikimedia.org/T133470 EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T133658: [Story] Improve textual representation of query parameters and services

2016-05-04 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T133658 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Aklapper, Jonas, Avner, Lewizho99, Maathavan, debt, Gehel, D3r1ck01,

[Wikidata-bugs] [Maniphest] [Commented On] T119915: Create response time monitoring for WDQS endpoint

2016-05-04 Thread Addshore
Addshore added a comment. Just looking at the other things I am recording right now but it may infact make sense to put a monitor on the Done Rate or the Queries Per Second. A Done Rate of 0 or a QPS of 0 for longer than the normal query timeout should shout at us, as it means no

[Wikidata-bugs] [Maniphest] [Created] T134351: [Bug] HHVM on test.wikidata.org dies with no output when setting an option

2016-05-04 Thread thiemowmde
thiemowmde created this task. Herald added subscribers: Zppix, Aklapper. TASK DESCRIPTION Steps to reproduce: - Go to https://test.wikidata.org/wiki/Special:ApiSandbox#action=options=json=wikibase-entitytermsview-showEntitytermslistview=1=0c5f2f3b92d5d985ed91d4a462727d2c5729b96a%2B\ -

[Wikidata-bugs] [Maniphest] [Updated] T134352: Regression: New line after images at fr.wikivoyage

2016-05-04 Thread Aklapper
Aklapper removed projects: WMF-deploy-2016-04-26_(1.27.0-wmf.22), WMF-deploy-2016-05-01_(1.27.0-wmf.23), Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters. Aklapper added a comment. What is the "the flag problem on the left side" exactly and how to see it? TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T124786: [Task] Widgets should delegate isInitialValue calls as far as possible

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 286668 merged by jenkins-bot: Clean up usage of self and private properties in snaklistview https://gerrit.wikimedia.org/r/286668 TASK DETAIL https://phabricator.wikimedia.org/T124786 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T132549: Don't bind to MediaWiki's PHP message system in WikibaseView for messages

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 283629 merged by jenkins-bot: Fix-ups to LocalizedTextProvider introduction https://gerrit.wikimedia.org/r/283629 TASK DETAIL https://phabricator.wikimedia.org/T132549 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T114995: [Bug] Varnish cache invalidation not working for m.wikidata.org

2016-05-04 Thread Aklapper
Aklapper added a project: Traffic. Herald added a project: Operations. TASK DETAIL https://phabricator.wikimedia.org/T114995 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ori, Aklapper Cc: gerritbot, faidon, Addshore, BBlack, Jdlrobson, daniel,

[Wikidata-bugs] [Maniphest] [Commented On] T134265: [Task] Add EntityDifferStrategy builder to MediaInfo entity type definition

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 286757 merged by jenkins-bot: Register EntityDifferStrategy builder and EntityId builder pair https://gerrit.wikimedia.org/r/286757 TASK DETAIL https://phabricator.wikimedia.org/T134265 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T134264: [Task] Add EntityId builder pair to MediaInfo entity type definition

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 286757 merged by jenkins-bot: Register EntityDifferStrategy builder and EntityId builder pair https://gerrit.wikimedia.org/r/286757 TASK DETAIL https://phabricator.wikimedia.org/T134264 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Created] T134352: Regression: New line after images at fr.wikivoyage

2016-05-04 Thread Omondi
Omondi created this task. Herald added a subscriber: Zppix. Herald removed a project: Patch-For-Review. TASK DESCRIPTION The problem of the labels on the right side of the banner is now fixed but not the flag problem on the left side. Exemple: https://fr.wikivoyage.org/wiki/Zanzibar TASK

[Wikidata-bugs] [Maniphest] [Block] T132244: Regression: New line after images at fr.wikivoyage

2016-05-04 Thread Omondi
Omondi created blocking task T134352: Regression: New line after images at fr.wikivoyage. TASK DETAIL https://phabricator.wikimedia.org/T132244 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson, Omondi Cc: Omondi, phuedx, gerritbot,

[Wikidata-bugs] [Maniphest] [Commented On] T133658: [Story] Improve textual representation of query parameters and services

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 286806 had a related patch set uploaded (by Jonas Kress (WMDE)): Textual representation of LIMIT https://gerrit.wikimedia.org/r/286806 TASK DETAIL https://phabricator.wikimedia.org/T133658 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T122350: Use scap3 to deploy DCAT-AP

2016-05-04 Thread Lokal_Profil
Lokal_Profil added a comment. This would largely be beyond me but I'm happy to help in whatever capacity I can. TASK DETAIL https://phabricator.wikimedia.org/T122350 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lokal_Profil Cc: Lokal_Profil,

[Wikidata-bugs] [Maniphest] [Commented On] T134351: [Bug] HHVM on test.wikidata.org dies with no output when setting an option

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 286805 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Expand term box by default even if option does not exist https://gerrit.wikimedia.org/r/286805 TASK DETAIL https://phabricator.wikimedia.org/T134351 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T134351: [Bug] HHVM on test.wikidata.org dies with no output when setting an option

2016-05-04 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T134351 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Aklapper, Zppix, Tobi_WMDE_SW, aude, hoo, JanZerebecki, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Created] T134371: Suggestion: Identify already-existing properties on an item to avoid duplicate edits

2016-05-04 Thread agray
agray created this task. Herald added subscribers: Zppix, Aklapper. TASK DESCRIPTION When adding a property to Wikidata items using the web interface, it is easy to unintentionally create a duplicate property entry - particularly on large items, where you may not notice that the property

[Wikidata-bugs] [Maniphest] [Updated] T133866: Varnish seems to sometimes mangle uncompressed API results

2016-05-04 Thread Aklapper
Aklapper added a project: Traffic. Herald added a project: Operations. TASK DETAIL https://phabricator.wikimedia.org/T133866 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: BBlack, Aklapper Cc: elukey, ema, Aklapper, hoo, D3r1ck01, Izno,

[Wikidata-bugs] [Maniphest] [Commented On] T133470: [Task] Remove outdated message "Wikibase-after-page-move"

2016-05-04 Thread thiemowmde
thiemowmde added a comment. I believe this tickets description is misleading. One can not simply "remove" a message. It's shown for a reason and will always be needed for installations that do not update the repo automatically when a page on a client is moved. When I look at the code in

[Wikidata-bugs] [Maniphest] [Commented On] T133299: [Task] Replace bogus $ anchor in regular expressions with \z

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 286813 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Fix newline injection vector in MediaInfoId validation https://gerrit.wikimedia.org/r/286813 TASK DETAIL https://phabricator.wikimedia.org/T133299 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T134012: Named Queries

2016-05-04 Thread JanZerebecki
JanZerebecki added a comment. Dedup this ticket with https://phabricator.wikimedia.org/T67626 and https://phabricator.wikimedia.org/T132784. TASK DETAIL https://phabricator.wikimedia.org/T134012 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Updated] T134351: [Bug] HHVM on test.wikidata.org dies with no output when setting an option

2016-05-04 Thread hoo
hoo added a project: Wikimedia-log-errors. hoo added a comment. I tried this twice and got the following fatal: May 4 12:13:56 mw1017: #012Catchable fatal error: Argument 1 passed to Message::setContext() must implement interface IContextSource, null given in

[Wikidata-bugs] [Maniphest] [Commented On] T125980: [Task] Avoid id="coordinates" in HTML ArticlePlaceholder output

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 286664 merged by jenkins-bot: Avoid id="coordinates" in HTML ArticlePlaceholder output https://gerrit.wikimedia.org/r/286664 TASK DETAIL https://phabricator.wikimedia.org/T125980 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T75647: [Story] Log/graph dispatch lag

2016-05-04 Thread Addshore
Addshore added a comment. https://phabricator.wikimedia.org/T125989 TASK DETAIL https://phabricator.wikimedia.org/T75647 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Ricordisamoa, Aklapper, Addshore, JanZerebecki, Liuxinyu970226,

[Wikidata-bugs] [Maniphest] [Triaged] T134351: [Bug] HHVM on test.wikidata.org dies with no output when setting an option

2016-05-04 Thread thiemowmde
thiemowmde triaged this task as "Unbreak Now!" priority. thiemowmde added subscribers: Anomie, Tgr. thiemowmde removed a project: Patch-For-Review. Herald added subscribers: Luke081515, TerraCodes, Urbanecm. TASK DETAIL https://phabricator.wikimedia.org/T134351 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T107595: [RFC] Multi-Content Revisions

2016-05-04 Thread brion
brion added a comment. Regarding transactional nature: Assuming the backing blob storage continues to work on the model of the current `text` table blobs with external storage backing, the "easy way" is to allow extra backend blobs to leak in case of transaction rollback, and let them

[Wikidata-bugs] [Maniphest] [Commented On] T134238: Query service fails with "Too many open files"

2016-05-04 Thread Stashbot
Stashbot added a comment. Mentioned in SAL [2016-05-04T12:34:11Z] restarting blazegraph (https://phabricator.wikimedia.org/T134238) TASK DETAIL https://phabricator.wikimedia.org/T134238 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Gehel,

[Wikidata-bugs] [Maniphest] [Commented On] T123087: [Task] Track use of Create Article and Translate Article buttons

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 286839 had a related patch set uploaded (by Addshore): Track the create-article button https://gerrit.wikimedia.org/r/286839 TASK DETAIL https://phabricator.wikimedia.org/T123087 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Created] T134386: Wikidata build has faling test Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest

2016-05-04 Thread JanZerebecki
JanZerebecki created this task. Herald added subscribers: Zppix, Aklapper. TASK DESCRIPTION 10:06:23 1) Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest::testGetHtml with data set #0 (Wikibase\MediaInfo\DataModel\MediaInfo Object (...)) 10:06:23 getHtml() expects exactly 7

[Wikidata-bugs] [Maniphest] [Triaged] T134386: Wikidata build has faling test Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest

2016-05-04 Thread JanZerebecki
JanZerebecki triaged this task as "Unbreak Now!" priority. JanZerebecki edited the task description. Herald added subscribers: Luke081515, TerraCodes, Urbanecm. TASK DETAIL https://phabricator.wikimedia.org/T134386 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Changed Project Column] T134386: Wikidata build has faling test Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest

2016-05-04 Thread JanZerebecki
JanZerebecki moved this task from Proposed to Backlog on the Wikidata-Sprint-2016-04-26 board. TASK DETAIL https://phabricator.wikimedia.org/T134386 WORKBOARD https://phabricator.wikimedia.org/project/board/1939/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T134351: [Bug] HTMLFormField calls Message::setContext( null )

2016-05-04 Thread JanZerebecki
JanZerebecki added projects: Wikidata, Wikidata-Sprint-2016-04-26. TASK DETAIL https://phabricator.wikimedia.org/T134351 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: Urbanecm, TerraCodes, Tgr, Anomie, Luke081515, gerritbot,

[Wikidata-bugs] [Maniphest] [Commented On] T134351: [Bug] HHVM on test.wikidata.org dies with no output when setting an option

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 286805 merged by jenkins-bot: Expand term box by default even if option does not exist https://gerrit.wikimedia.org/r/286805 TASK DETAIL https://phabricator.wikimedia.org/T134351 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T133044: [Task] Handle cases where assiging a fresh ID to a new entity expects numeric entity IDs

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 277582 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Only use numeric ids on supported entity types https://gerrit.wikimedia.org/r/277582 TASK DETAIL https://phabricator.wikimedia.org/T133044 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T123087: [Task] Track use of Create Article and Translate Article buttons

2016-05-04 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T123087 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Lucie, Addshore, Aklapper, Lewizho99, Maathavan, D3r1ck01, Izno,

[Wikidata-bugs] [Maniphest] [Commented On] T123087: [Task] Track use of Create Article and Translate Article buttons

2016-05-04 Thread Addshore
Addshore added a comment. Also added commenyts to https://gerrit.wikimedia.org/r/#/c/280954/ and https://gerrit.wikimedia.org/r/#/c/280950/ which should both include the tracking TASK DETAIL https://phabricator.wikimedia.org/T123087 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T134432: Missing labels and descriptions in "other languages" box

2016-05-04 Thread Stashbot
Stashbot added a comment. Mentioned in SAL [2016-05-04T23:54:31Z] Synchronized php-1.27.0-wmf.23/extensions/Wikidata: Fix bug in other languages box: https://phabricator.wikimedia.org/T134432 (duration: 02m 18s) TASK DETAIL https://phabricator.wikimedia.org/T134432 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T107595: [RFC] Multi-Content Revisions

2016-05-04 Thread brion
brion added a comment. In https://phabricator.wikimedia.org/T107595#2266131, @GWicke wrote: > The use case for providing metadata is so that we can use stores like RESTBase, which already provide an API keyed on title, revision & render ID. It also already deals with the complexities

[Wikidata-bugs] [Maniphest] [Commented On] T113034: RFC: Overhaul Interwiki map, unify with Sites and WikiMap

2016-05-04 Thread Legoktm
Legoktm added a comment. https://gerrit.wikimedia.org/r/#/c/250150/ is probably the first step in implementing this, and I was planning to merge it by the end of this week. TASK DETAIL https://phabricator.wikimedia.org/T113034 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T107595: [RFC] Multi-Content Revisions

2016-05-04 Thread daniel
daniel added a comment. In https://phabricator.wikimedia.org/T107595#2266131, @GWicke wrote: > Basically, if we don't have a way to provide this key information to the backend store, then we can't access all the multi-content revision data that's already out there through this

[Wikidata-bugs] [Maniphest] [Lowered Priority] T134432: Missing labels and descriptions in "other languages" box

2016-05-04 Thread aude
aude lowered the priority of this task from "Unbreak Now!" to "High". TASK DETAIL https://phabricator.wikimedia.org/T134432 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aude Cc: Stashbot, Urbanecm, TerraCodes, Luke081515, gerritbot, Aklapper,

[Wikidata-bugs] [Maniphest] [Commented On] T134426: Review shared data namespace (tabular data) implementation

2016-05-04 Thread Yurik
Yurik added a comment. My apologies to anyone who is not interested in the implementation review of this feature - please unsubscribe. I am hoping to deploy this fairly soon, as there is clearly a huge demand for this functionality, so any feedback would be great. Thanks! TASK DETAIL

[Wikidata-bugs] [Maniphest] [Unassigned] T133470: [Task] Remove outdated message "Wikibase-after-page-move"

2016-05-04 Thread D3r1ck01
D3r1ck01 removed D3r1ck01 as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T133470 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: D3r1ck01 Cc: D3r1ck01, thiemowmde, Ricordisamoa, Lydia_Pintscher, gerritbot, TerraCodes,

[Wikidata-bugs] [Maniphest] [Commented On] T134432: Missing labels and descriptions in "other languages" box

2016-05-04 Thread aude
aude added a comment. Now fixed on Wikidata, though still want us to split the code that generates the TermListView into a separate class so it can be tested more properly or otherwise make sure it's well tested TASK DETAIL https://phabricator.wikimedia.org/T134432 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T134432: Missing labels and descriptions in "other languages" box

2016-05-04 Thread aude
aude removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T134432 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aude Cc: Stashbot, Urbanecm, TerraCodes, Luke081515, gerritbot, Aklapper, aude, Zppix, D3r1ck01, Izno,

[Wikidata-bugs] [Maniphest] [Commented On] T134432: Missing labels and descriptions in "other languages" box

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 287013 merged by jenkins-bot: Fix issue of missing languages in "other languages" term box https://gerrit.wikimedia.org/r/287013 TASK DETAIL https://phabricator.wikimedia.org/T134432 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T107595: [RFC] Multi-Content Revisions

2016-05-04 Thread GWicke
GWicke added a comment. The use case for providing metadata is so that we can use stores like RESTBase, which already provide an API keyed on title, revision & render ID. It also already deals with the complexities you mention. Basically, if we don't have a way to provide this key

[Wikidata-bugs] [Maniphest] [Commented On] T107595: [RFC] Multi-Content Revisions

2016-05-04 Thread daniel
daniel added a comment. Thanks for moving this forward, Brion! Your code is pretty close to what I had in mind. I have repeated it below with some changes marked `// dk` In https://phabricator.wikimedia.org/T107595#2263968, @brion wrote: > In MediaWiki in general we're pretty

[Wikidata-bugs] [Maniphest] [Commented On] T107595: [RFC] Multi-Content Revisions

2016-05-04 Thread daniel
daniel added a comment. Pseudo-code for `saveRevisionRecord()` // assume we are in a db transaction $this->checkIsCurrentRevision( $this->baseRevision ); // protect against race condition $model = $slots['main']->getModel(); // "main" model must always be there $length

[Wikidata-bugs] [Maniphest] [Assigned] T134351: [Bug] HTMLFormField calls Message::setContext( null )

2016-05-04 Thread thiemowmde
thiemowmde lowered the priority of this task from "Unbreak Now!" to "Normal". thiemowmde assigned this task to Tgr. thiemowmde moved this task from Proposed to Done on the Wikidata-Sprint-2016-04-26 board. TASK DETAIL https://phabricator.wikimedia.org/T134351 WORKBOARD

[Wikidata-bugs] [Maniphest] [Updated] T134386: Wikidata build has faling test Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest

2016-05-04 Thread daniel
daniel added a comment. Can't reproduce with current master of Wikibase (https://phabricator.wikimedia.org/rEWBAe185e960d35430a0d70586450c39517cffadf46c) and MediaInfo (https://phabricator.wikimedia.org/rEWBIbd4bb05d5b859bbedcecedb5ef852a88552eef36). MediaInfoViewTest passes, and

[Wikidata-bugs] [Maniphest] [Commented On] T134386: Wikidata build has faling test Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest

2016-05-04 Thread JanZerebecki
JanZerebecki added a comment. New build: https://gerrit.wikimedia.org/r/#/c/286891/1 TASK DETAIL https://phabricator.wikimedia.org/T134386 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: daniel, Urbanecm, TerraCodes, Luke081515,

[Wikidata-bugs] [Maniphest] [Commented On] T134351: [Bug] HTMLFormField calls Message::setContext( null )

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 286855 merged by jenkins-bot: Fix HTMLFormField calling Message::setContext with null https://gerrit.wikimedia.org/r/286855 TASK DETAIL https://phabricator.wikimedia.org/T134351 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T107595: [RFC] Multi-Content Revisions

2016-05-04 Thread brion
brion added a comment. > The above code would replace much of what is in the Revision class now, in particular insertOn(). We can keep Revision around, but I'm not sure we can provide b/c for insertOn(). b/c here looks relatively straightforward to me; it creates a new revision with an

[Wikidata-bugs] [Maniphest] [Commented On] T107595: [RFC] Multi-Content Revisions

2016-05-04 Thread brion
brion added a comment. (if RevisionBuilder takes a $dbw param via constructor/factory, then the question of the connection is easier) TASK DETAIL https://phabricator.wikimedia.org/T107595 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel,

[Wikidata-bugs] [Maniphest] [Commented On] T107595: [RFC] Multi-Content Revisions

2016-05-04 Thread daniel
daniel added a comment. We could (optionally?) provide a transaction context to the blob store like this: $trx = new Transaction(); $trx->addDBConnection( $dbw ); $trx->start(); try { foreach ( $something as $thing ) { $url = $blobStore->saveBlob( $data, $trx

[Wikidata-bugs] [Maniphest] [Commented On] T133299: [Task] Replace bogus $ anchor in regular expressions with \z

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 286813 merged by jenkins-bot: Fix newline injection vector in MediaInfoId validation https://gerrit.wikimedia.org/r/286813 TASK DETAIL https://phabricator.wikimedia.org/T133299 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T134351: [Bug] HTMLFormField calls Message::setContext( null )

2016-05-04 Thread Tgr
Tgr added a comment. At a glance, the methods which will break if `mParent` is not set are - HTMLFormField::getErrorsAndErrorClass , HTMLFormField::getErrorsRaw

[Wikidata-bugs] [Maniphest] [Commented On] T134351: [Bug] HTMLFormField calls Message::setContext( null )

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 286864 had a related patch set uploaded (by Gergő Tisza): ApiOptions: set form field parent earlier https://gerrit.wikimedia.org/r/286864 TASK DETAIL https://phabricator.wikimedia.org/T134351 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T107595: [RFC] Multi-Content Revisions

2016-05-04 Thread daniel
daniel added a comment. In https://phabricator.wikimedia.org/T107595#2264302, @brion wrote: > The remaining questions are > > - whether we want to pass the $dbw parameter through (do we always go through load balancer in which case it'll be the same connection anyway? or are there

[Wikidata-bugs] [Maniphest] [Commented On] T133660: [Story] Improve editing of textual representation - add and delete

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 286885 had a related patch set uploaded (by Jonas Kress (WMDE)): Deleting of triples in textual representation https://gerrit.wikimedia.org/r/286885 TASK DETAIL https://phabricator.wikimedia.org/T133660 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T107595: [RFC] Multi-Content Revisions

2016-05-04 Thread brion
brion added a comment. In https://phabricator.wikimedia.org/T107595#2264334, @daniel wrote: > We could (optionally?) provide a transaction context to the blob store like this: I kinda like that, yeah. Maybe extend Database with a transactional interface that takes a callback:

[Wikidata-bugs] [Maniphest] [Commented On] T134386: Wikidata build has faling test Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest

2016-05-04 Thread daniel
daniel added a comment. This was apparently fixed in Ic0e7cd97fc23f5e0e0422208ba66fe940f6b4dcc, see https://gerrit.wikimedia.org/r/#/c/286409/2/src/View/MediaInfoView.php TASK DETAIL https://phabricator.wikimedia.org/T134386 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Closed] T134351: [Bug] HTMLFormField calls Message::setContext( null )

2016-05-04 Thread Tgr
Tgr closed this task as "Resolved". Tgr added a comment. Splitting the generic problem to T134401: It is unclear what should happen when HTMLFormField::$mParent is null . TASK DETAIL https://phabricator.wikimedia.org/T134351 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T107595: [RFC] Multi-Content Revisions

2016-05-04 Thread brion
brion added a comment. re this: $bs->deleteBlob( $dataUrl ); // dk: this goes wrong if the URL is content/hash based! I think the return from this: $dataUrl = $bs->saveBlob( $content->serialize() ); needs to signal whether a blob was created or whether an existing blob

[Wikidata-bugs] [Maniphest] [Commented On] T107595: [RFC] Multi-Content Revisions

2016-05-04 Thread daniel
daniel added a comment. In https://phabricator.wikimedia.org/T107595#2264511, @brion wrote: > and internally in the BlobStore's save method, we add the rollback callback straight onto the db object: > > That avoids having transaction state live separately in both the connection and

[Wikidata-bugs] [Maniphest] [Commented On] T134238: Query service fails with "Too many open files"

2016-05-04 Thread Stashbot
Stashbot added a comment. Mentioned in SAL [2016-05-04T16:19:14Z] restarting blazegraph (https://phabricator.wikimedia.org/T134238) TASK DETAIL https://phabricator.wikimedia.org/T134238 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Gehel,

[Wikidata-bugs] [Maniphest] [Commented On] T107595: [RFC] Multi-Content Revisions

2016-05-04 Thread brion
brion added a comment. > This assumes the BlobStore will actually talk to the (same) database. I would like to have Transaction separate from the DB stuff, so it can be used just as well with files, or Cassandra, or Swift, or whatever we come up with to store blobs. We shouldn't assume that

[Wikidata-bugs] [Maniphest] [Updated] T134351: [Bug] HTMLFormField calls Message::setContext( null )

2016-05-04 Thread ReleaseTaggerBot
ReleaseTaggerBot added projects: WMF-deploy-2016-05-08_(1.28.0-wmf.1), MW-1.27-release-notes, WMF-deploy-2016-05-01_(1.27.0-wmf.23). TASK DETAIL https://phabricator.wikimedia.org/T134351 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr,

[Wikidata-bugs] [Maniphest] [Commented On] T134351: [Bug] HTMLFormField calls Message::setContext( null )

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 286864 merged by jenkins-bot: ApiOptions: set form field parent earlier https://gerrit.wikimedia.org/r/286864 TASK DETAIL https://phabricator.wikimedia.org/T134351 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T134371: Suggestion: Identify already-existing properties on an item to avoid duplicate edits

2016-05-04 Thread Nemo_bis
Nemo_bis added a comment. > the existing lines could "snap down" to be displayed alongside the new line for that item This is the best solution (or alternatively, scroll up to the existing box for that property). TASK DETAIL https://phabricator.wikimedia.org/T134371 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T134371: Suggestion: Identify already-existing properties on an item to avoid duplicate edits

2016-05-04 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. Yes highlighting the case but still allowing it where it makes sense sounds good to me too. We'll do that but it'll take time. Thank you for the idea! TASK DETAIL https://phabricator.wikimedia.org/T134371 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T107595: [RFC] Multi-Content Revisions

2016-05-04 Thread daniel
daniel added a comment. In https://phabricator.wikimedia.org/T107595#2264799, @GWicke wrote: > It is not entirely clear to me whether PageUpdater (and RevisionUpdater) are meant to only handle synchronous low-level updates, or whether they are meant to orchestrate asynchronous change

[Wikidata-bugs] [Maniphest] [Commented On] T53051: Set useful and consistent (in client/repo) default namespaces.

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 177526 abandoned by Lucie Kaffee: added Item to wikibase-item Reason: Too old, no discussion, so abandoning it. https://gerrit.wikimedia.org/r/177526 TASK DETAIL https://phabricator.wikimedia.org/T53051 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T123087: [Task] Track use of Create Article and Translate Article buttons

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 286839 merged by jenkins-bot: Track the create-article button https://gerrit.wikimedia.org/r/286839 TASK DETAIL https://phabricator.wikimedia.org/T123087 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Updated] T107595: [RFC] Multi-Content Revisions

2016-05-04 Thread GWicke
GWicke added a comment. > Where do I propose another mechanism for change propagation? The PageUpdater would do exactly what Revision does now: schedule DataUpdates. EventBus & the change propagation service are moving away from scheduling "jobs", and towards an event processing

[Wikidata-bugs] [Maniphest] [Retitled] T134371: [Story] Highlight already-existing properties while adding a new statement on an item to avoid duplicate edits

2016-05-04 Thread Lydia_Pintscher
Lydia_Pintscher changed the title from "Suggestion: Identify already-existing properties on an item to avoid duplicate edits" to "[Story] Highlight already-existing properties while adding a new statement on an item to avoid duplicate edits". Lydia_Pintscher triaged this task as "Normal"

[Wikidata-bugs] [Maniphest] [Commented On] T107595: [RFC] Multi-Content Revisions

2016-05-04 Thread daniel
daniel added a comment. ///me notes that we are getting side tracked here, and this could turn into a separate rfc// I'd rather have the Transaction object know about the database, than the other way around. Why should the database be in charge of transactions (other than transactions

[Wikidata-bugs] [Maniphest] [Edited] T127929: [Story] Add a new datatype for linking to creators of artwork and more (smart URI)

2016-05-04 Thread kaldari
kaldari edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T127929 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kaldari Cc: Sadads, Pokefan95, gerritbot, DannyH, Micru, intracer, mkroetzsch, Aklapper, daniel,

[Wikidata-bugs] [Maniphest] [Updated] T113034: RFC: Overhaul Interwiki map, unify with Sites and WikiMap

2016-05-04 Thread RobLa-WMF
RobLa-WMF added a comment. @Daniel nominated this RFC for discussion at next week's ArchCom-RFC meeting (https://phabricator.wikimedia.org/E171), which seemed like a good idea to everyone at the time. The last RFC meeting we had on this subject was October, and there's now patch 285018

[Wikidata-bugs] [Maniphest] [Commented On] T107595: [RFC] Multi-Content Revisions

2016-05-04 Thread GWicke
GWicke added a comment. > Blobs would typically be shared by different revisions of the same page. This happens every time one primary slot is edited, but another is not changed. E.g. the free wikitext description of a file is edited, but the structured data isn't (or vice versa). Or the

[Wikidata-bugs] [Maniphest] [Commented On] T133044: [Task] Handle cases where assiging a fresh ID to a new entity expects numeric entity IDs

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 277582 merged by jenkins-bot: Only use numeric ids on supported entity types https://gerrit.wikimedia.org/r/277582 TASK DETAIL https://phabricator.wikimedia.org/T133044 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T107595: [RFC] Multi-Content Revisions

2016-05-04 Thread daniel
daniel added a comment. There is no redirection to maintain. The blob url from the old revision In https://phabricator.wikimedia.org/T107595#2265137, @GWicke wrote: > Makes sense, some of these fields won't change between revisions. Depending on the constraints, it might still make

[Wikidata-bugs] [Maniphest] [Commented On] T107595: [RFC] Multi-Content Revisions

2016-05-04 Thread GWicke
GWicke added a comment. > In any case, the PageUpdater / WikiPage code needs to trigger notifications (produce events). I don't care what mechanism it used for that. Or rather: I'm very happy if we get a generalized mechanism. We'll have to agree on some kind of schema for revisions, slots,

[Wikidata-bugs] [Maniphest] [Commented On] T56097: [Story] allow to select globe in the UI

2016-05-04 Thread Smalyshev
Smalyshev added a comment. Since it uses pywikibot, it is limited by what pywikibot's set of globes, which currently seems to have some missing. I'll submit a patch to update it. TASK DETAIL https://phabricator.wikimedia.org/T56097 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T107595: [RFC] Multi-Content Revisions

2016-05-04 Thread daniel
daniel added a comment. @GWicke Perhaps some confusion is caused by us thinking of the storage backend in different terms. For me, RESTBase is a BlobStore. A BlobStore deals with binary data, which it stores and assignes urls to, and which it can retrieve given such a url. That's it.

[Wikidata-bugs] [Maniphest] [Retitled] T53051: Set useful and consistent (in client/repo) default namespaces

2016-05-04 Thread matej_suchanek
matej_suchanek changed the title from "Set useful and consistent (in client/repo) default namespaces." to "Set useful and consistent (in client/repo) default namespaces". matej_suchanek removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T53051 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T107595: [RFC] Multi-Content Revisions

2016-05-04 Thread daniel
daniel added a comment. In https://phabricator.wikimedia.org/T107595#2265186, @GWicke wrote: > >> In addition to title and revision (which I assume remains an integer), we'd need an optional v1 UUID parameter to retrieve specific renders, in both the request & response interfaces. >

[Wikidata-bugs] [Maniphest] [Commented On] T133658: [Story] Improve textual representation of query parameters and services

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 286806 merged by jenkins-bot: Textual representation of LIMIT https://gerrit.wikimedia.org/r/286806 TASK DETAIL https://phabricator.wikimedia.org/T133658 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Edited] T134351: [Bug] HHVM on test.wikidata.org dies with no output when setting an option

2016-05-04 Thread JanZerebecki
JanZerebecki edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T134351 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: gerritbot, Aklapper, Zppix, Tobi_WMDE_SW, aude, hoo, JanZerebecki, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Commented On] T134351: [Bug] HHVM on test.wikidata.org dies with no output when setting an option

2016-05-04 Thread thiemowmde
thiemowmde added a comment. Issue introduced in https://gerrit.wikimedia.org/r/283846, mostly because the local property is not properly documented as `HTMLForm|null`. Please either revert the patch or provide a fix. TASK DETAIL https://phabricator.wikimedia.org/T134351 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Created] T134432: Missing labels and descriptions in "other languages" box

2016-05-04 Thread aude
aude created this task. Herald added subscribers: Zppix, Aklapper. TASK DESCRIPTION Some items that have labels (and descriptions), such as in the user language or other languages, don't have these displayed in the "other languages" box on the page: F3967193: wikidata-nolabels.png

[Wikidata-bugs] [Maniphest] [Updated] T134432: Missing labels and descriptions in "other languages" box

2016-05-04 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T134432 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Aklapper, aude, Zppix, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs,

[Wikidata-bugs] [Maniphest] [Commented On] T134432: Missing labels and descriptions in "other languages" box

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 286961 had a related patch set uploaded (by Aude): Put wikidata back on wmf/1.27.0-wmf.22 https://gerrit.wikimedia.org/r/286961 TASK DETAIL https://phabricator.wikimedia.org/T134432 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Triaged] T134432: Missing labels and descriptions in "other languages" box

2016-05-04 Thread aude
aude triaged this task as "Unbreak Now!" priority. Herald added subscribers: Luke081515, TerraCodes, Urbanecm. TASK DETAIL https://phabricator.wikimedia.org/T134432 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aude Cc: Urbanecm, TerraCodes,

[Wikidata-bugs] [Maniphest] [Updated] T134432: Missing labels and descriptions in "other languages" box

2016-05-04 Thread hashar
hashar added a blocked task: T131557: MW-1.27.0-wmf.23 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T134432 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Urbanecm, TerraCodes, Luke081515, gerritbot, Aklapper, aude,

[Wikidata-bugs] [Maniphest] [Commented On] T134432: Missing labels and descriptions in "other languages" box

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 286961 merged by jenkins-bot: Put wikidata back on wmf/1.27.0-wmf.22 https://gerrit.wikimedia.org/r/286961 TASK DETAIL https://phabricator.wikimedia.org/T134432 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Updated] T134432: Missing labels and descriptions in "other languages" box

2016-05-04 Thread Stashbot
Stashbot added a comment. Mentioned in SAL [2016-05-04T20:28:25Z] rebuilt wikiversions.php and synchronized wikiversions files: Wikidata back to 1.27.0-wmf.22 due to https://phabricator.wikimedia.org/T134432. Poke https://phabricator.wikimedia.org/T131557. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T119915: Create response time monitoring for WDQS endpoint

2016-05-04 Thread gerritbot
gerritbot added a comment. Change 286992 had a related patch set uploaded (by Gehel): Add response time checks to WDQS https://gerrit.wikimedia.org/r/286992 TASK DETAIL https://phabricator.wikimedia.org/T119915 EMAIL PREFERENCES

  1   2   >