gerritbot added a comment.
Change 377983 had a related patch set uploaded (by DCausse; owner: DCausse):
[operations/software/elasticsearch/plugins@master] Bump highlighter version to 5.3.2.1
https://gerrit.wikimedia.org/r/377983TASK DETAILhttps://phabricator.wikimedia.org/T173231EMAIL
WMDE-leszek added a comment.
This component seems a bit confusing. Indeed, there is a part there which clearly is an extension.
So options seem to be like @Legoktm said: either make it an extension or merge it (I believe merge it back) to Wikibase.
So the simplest thing seem to me to be making an
Lydia_Pintscher added a comment.
When I look at the one that is in https://gerrit.wikimedia.org/r/377912 I see a horizontal white line at about 2/3 of the height. Besides that, go ahead.
@Charlie_WMDE can you get us a fixed version?TASK DETAILhttps://phabricator.wikimedia.org/T168041EMAIL
Ladsgroup added a comment.
I was wondering if that could happen completely in frontend, we only need those when someone tries to edit and not when someone searches in wikidata.TASK DETAILhttps://phabricator.wikimedia.org/T140131EMAIL
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION- [x] [Add context for statements](https://gerrit.wikimedia.org/r/#/c/369420) + [tests](https://gerrit.wikimedia.org/r/#/c/369420)
- [ - [x] [Add support for new API format to
gerritbot added a comment.
Change 377962 merged by jenkins-bot:
[search/highlighter@5.3] Add new formatter to output offsets text snippets
https://gerrit.wikimedia.org/r/377962TASK DETAILhttps://phabricator.wikimedia.org/T173231EMAIL
gerritbot added a comment.
Change 373323 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Refactor gadget.js
https://gerrit.wikimedia.org/r/373323TASK DETAILhttps://phabricator.wikimedia.org/T168532EMAIL
dcausse added a comment.
Right now the field name is statements. I'm not sure whether we should add wb there (everything in that index is "wb", since it's on wikidata). What do you mean by "typed" though?
I mean a name that bears the data types it stores, for me "statements" seems too generic, if
gerritbot added a comment.
Change 377962 had a related patch set uploaded (by DCausse; owner: DCausse):
[search/highlighter@5.3] Add new formatter to output offsets text snippets
https://gerrit.wikimedia.org/r/377962TASK DETAILhttps://phabricator.wikimedia.org/T173231EMAIL
gerritbot added a comment.
Change 366533 abandoned by Thiemo Mättig (WMDE):
Simplify Wikibase "unitStorage" configuration
Reason:
I need to redo the patch this depends-on, and will upload a new config patch when this is done.
https://gerrit.wikimedia.org/r/366533TASK
gerritbot added a comment.
Change 202723 abandoned by Thiemo Mättig (WMDE):
Un-deprecate $revisionId = 0 in EntityRevisionLookup
https://gerrit.wikimedia.org/r/202723TASK DETAILhttps://phabricator.wikimedia.org/T90893EMAIL
Krinkle added a parent task: T175897: Audit and improve JobQueue performance (2017).
TASK DETAILhttps://phabricator.wikimedia.org/T124418EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: PokestarFan, Gilles, GWicke, ArielGlenn, Krinkle, Peter,
Krinkle added a parent task: T175897: Audit and improve JobQueue performance (2017).
TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Tbayer, mobrovac, Nikerabbit, Mholloway, Legoktm, ema, Joe,
thiemowmde triaged this task as "High" priority.thiemowmde moved this task from Proposed to Review on the Wikidata-Sprint board.thiemowmde added subscribers: hoo, aude.
TASK DETAILhttps://phabricator.wikimedia.org/T175910WORKBOARDhttps://phabricator.wikimedia.org/project/board/2351/EMAIL
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T175910EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, gerritbotCc: gerritbot, Aklapper, TerraCodes, Lucas_Werkmeister_WMDE, Jakob_WMDE, Aleksey_WMDE,
gerritbot added a comment.
Change 378013 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Require missing namespace for wikibase.experts.getStore module
https://gerrit.wikimedia.org/r/378013TASK
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION... - [ - [x] Update with switch date as soon as that’s decided...- [ ] [Switch to new API format on Wikidata](https://phabricator.wikimedia.org/T175590)TASK
Charlie_WMDE added a comment.
I suggest using the actual favicon in the background as mentioned in a previous comment to keep blurryness to a minimum.
I also think, that it's better visible in white in favicon size.
F9531506: WD_Favicon_color_Query_white_fav.png
F9531261:
chasemp closed this task as "Resolved".chasemp claimed this task.chasemp added a comment.
Great done, I upped RAM to 72500 for good measure. Keep the quota, we'll come back to it if it's ever a real contention.TASK DETAILhttps://phabricator.wikimedia.org/T175196EMAIL
gerritbot added a comment.
Change 377271 abandoned by Thiemo Mättig (WMDE):
Remove red highlighting on all entity selectors
https://gerrit.wikimedia.org/r/377271TASK DETAILhttps://phabricator.wikimedia.org/T175525EMAIL
gerritbot added a comment.
Change 377812 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.30.0-wmf.18] Split page set before constructing InjectRCRecordsJob
https://gerrit.wikimedia.org/r/377812TASK DETAILhttps://phabricator.wikimedia.org/T175316EMAIL
thiemowmde created this task.thiemowmde added projects: Wikidata, MediaWiki-extensions-WikibaseRepository, Patch-For-Review, Regression, Easy, Wikidata-Sprint.Herald added subscribers: TerraCodes, Aklapper.Herald removed a project: Patch-For-Review.
TASK DESCRIPTIONReported at
gerritbot added a comment.
Change 378024 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Update formatterUrlProperty/canonicalUriProperty docs
https://gerrit.wikimedia.org/r/378024TASK
gerritbot added a comment.
Change 375087 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix display for fields which have alias in non-target language
https://gerrit.wikimedia.org/r/375087TASK DETAILhttps://phabricator.wikimedia.org/T173231EMAIL
Tobi_WMDE_SW added a project: WMDE-Design.Herald added a project: Design.
TASK DETAILhttps://phabricator.wikimedia.org/T124758EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tobi_WMDE_SWCc: Lydia_Pintscher, Charlie_WMDE, Sjoerddebruin, C933103,
Gehel created this task.Gehel added projects: Wikidata-Query-Service, Discovery-Wikidata-Query-Service-Sprint.Herald added a subscriber: Aklapper.Herald added projects: Wikidata, Discovery.
TASK DESCRIPTIONA quick look at GC logs on wdqs1004 show that almost 5% of time is spent in GC. That seems
gerritbot added a comment.
Change 378024 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update formatterUrlProperty/canonicalUriProperty docs
https://gerrit.wikimedia.org/r/378024TASK DETAILhttps://phabricator.wikimedia.org/T121274EMAIL
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- [x] Switch to new API format on wikidata-constraints
- [ - [x] Announce new API format (breaking change), including pointer to wikidata-constraints as test system...TASK
thiemowmde updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...This is a #regression. The issue was accidentally introduced with https://gerrit.wikimedia.org/r/#/c/361498/12/repo/resources/experts/resources.php ({T167964}) in June this year.
#patch-for-review:
[] …TASK
gerritbot added a comment.
Change 377272 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix initial state of all Entity experts
https://gerrit.wikimedia.org/r/377272TASK DETAILhttps://phabricator.wikimedia.org/T175525EMAIL
matej_suchanek created this task.matej_suchanek added a project: Wikidata-Gadgets.Herald added a subscriber: Aklapper.Herald added a project: Wikidata.
TASK DESCRIPTIONMediaWiki talk:Gadget-Merge.js has got many reports from users who attempted to merge two distinct items and didn't succeed. It
Pchelolo added a comment.
@Pchelolo actually, can you confirm how many entries there were in the "pages" parameter? With the latest patches deployed, there should be no more than 20. Perhaps this is an old job getting retried, because it failed earlier?
There's definitely more then 20 entries
Smalyshev added a comment.
now if you decide to add P1559 (monolingual text) we should not index it in the "statements" elastic field they'll require totally different analyzers (one is an identifier, the other is written language)
I don't currently plan to analyze values in any way, so for
daniel added a comment.
For now, let's just try to get the size of the jobs below the 4MB mark? :)
If you fix your encoding ;)TASK DETAILhttps://phabricator.wikimedia.org/T175316EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pchelolo, danielCc: mobrovac,
Pchelolo added a comment.
After the patch was deployed the situation improved a lot, but we've got a 5 Mb event today: https://people.wikimedia.org/~ppchelko/event
5 Mb is not critically large, we can increase the limit in Kafka to 8 Mb I think, but maybe we should do some more improvements in
daniel added a comment.
@Pchelolo disabling escaping of non-ascii characters would probably reduce the size to a fourth...
I'm not sure what kind of improvement you mean. We can tweak the chunk size - more jobs, or larger jobs, your pick.TASK DETAILhttps://phabricator.wikimedia.org/T175316EMAIL
daniel added a comment.
@Pchelolo actually, can you confirm how many entries there were in the "pages" parameter? With the latest patches deployed, there should be no more than 20. Perhaps this is an old job getting retried, because it failed earlier?TASK
daniel added a comment.
@mobrovac how about a very large number of very small jobs? e.g. a million jobs to purge a million pages from cdn?TASK DETAILhttps://phabricator.wikimedia.org/T175316EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pchelolo, danielCc:
mobrovac added a comment.
In T175316#3608388, @daniel wrote:
@mobrovac how about a very large number of very small jobs? e.g. a million jobs to purge a million pages from cdn?
Note that we introduced batching only a few weeks ago, at the explicit request of the performance folks. We had one job
mobrovac added a comment.
In T175316#3608364, @daniel wrote:
We can tweak the chunk size - more jobs, or larger jobs, your pick.
Since in the new JQ system all jobrunners will run all jobs, a higher number of smaller jobs are preferred over a smaller number of big jobs.TASK
Yurik created this task.Yurik added projects: Wikidata-Query-Service, Accessibility.Herald added a subscriber: Aklapper.Herald added projects: Wikidata, Discovery.
TASK DESCRIPTIONCtrl+Enter shortcut is very useful from inside the SPARQL edit area, but it breaks the standard browser behavior when
Mattflaschen-WMF added a comment.
In T172832#3559604, @GWicke wrote:
@Mattflaschen-WMF, thank you for the background on echo! Regarding use case #2, can this be fairly summarized as "wait for a limited time before sending out notifications, in order to reduce the volume with batching"?
I was
gerritbot added a comment.
Change 378013 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Require missing namespace for wikibase.experts.getStore module
https://gerrit.wikimedia.org/r/378013TASK
Lydia_Pintscher added a comment.
Thanks a lot, Charlie! Let's go with the black one.TASK DETAILhttps://phabricator.wikimedia.org/T168041EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: gerritbot, Esc3300, PokestarFan, Smalyshev,
Smalyshev added a comment.
What I would suggest doing is maybe putting this as a non-indexed field in the index and returning it together with the response. Of course, it could also be done purely client-side but at the cost of one extra round-trip.TASK
Smalyshev added a comment.
I'm reviewing the patch now and will update by the end of the day.TASK DETAILhttps://phabricator.wikimedia.org/T121274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, SmalyshevCc: Ladsgroup, Lucas_Werkmeister_WMDE, Jonas,
gerritbot added a comment.
Change 378072 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/EventBus@master] Allow unicode in serialized events.
https://gerrit.wikimedia.org/r/378072TASK DETAILhttps://phabricator.wikimedia.org/T175316EMAIL
Pchelolo added a comment.
In T175316#3608922, @GWicke wrote:
Looks like adding the JSON_UNESCAPED_UNICODE flag should do it: http://php.net/manual/en/function.json-encode.php
We use JsonFormatter class to encode JSON, so the solution is a bit different, but the above patch takes care of
GWicke added a comment.
Looks like adding the JSON_UNESCAPED_UNICODE flag should do it: http://php.net/manual/en/function.json-encode.phpTASK DETAILhttps://phabricator.wikimedia.org/T175316EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pchelolo, GWickeCc:
Smalyshev added a comment.
We may also want to store some values as non-indexed data, e.g. see T140131TASK DETAILhttps://phabricator.wikimedia.org/T175199EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: aude, gerritbot, debt, EBernhardson,
daniel added a comment.
@Lucas_Werkmeister_WMDE, @Smalyshev: can you guys agree on something and write it down, so @Ladsgroup can implement it? I don't know which was is actually the easiest to use or the most semantically sound in RDF, and I'm busy with the db schema for MCR.TASK
Ladsgroup added a comment.
I tried to implement the second suggestion made by Daniel as @Lucas_Werkmeister_WMDE said it's better to go at this direction but I'm not sure if I did it correctly, please take a look at the patch.TASK DETAILhttps://phabricator.wikimedia.org/T121274EMAIL
gerritbot added a comment.
Change 378072 merged by jenkins-bot:
[mediawiki/extensions/EventBus@master] Allow unicode in serialized events.
https://gerrit.wikimedia.org/r/378072TASK DETAILhttps://phabricator.wikimedia.org/T175316EMAIL
matej_suchanek created this task.matej_suchanek added a project: Wikidata-Gadgets.Herald added a subscriber: Aklapper.Herald added a project: Wikidata.
TASK DESCRIPTION[Mark as patrolled] links are not shown if you have new filters for edit review enabled.TASK
Smalyshev triaged this task as "Normal" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T175948EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Aklapper, Smalyshev, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, Avner,
Smalyshev created this task.Smalyshev added a project: Wikidata-Query-Service.Herald added a subscriber: Aklapper.Herald added projects: Wikidata, Discovery.
TASK DESCRIPTIONCurrently, Blazegraph vocabulary does not include normalized prefixes (like psn) and quantityNormalized predicate. This
ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)).
TASK DETAILhttps://phabricator.wikimedia.org/T175316EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pchelolo, ReleaseTaggerBotCc: mobrovac, Stashbot, Legoktm,
Smalyshev added a project: User-Smalyshev.
TASK DETAILhttps://phabricator.wikimedia.org/T121274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, SmalyshevCc: Ladsgroup, Lucas_Werkmeister_WMDE, Jonas, Esc3300, abian, gerritbot, Lydia_Pintscher, Aklapper,
Smalyshev moved this task from Up Next to Current work on the Discovery-Search board.Smalyshev edited projects, added Discovery-Search (Current work); removed Discovery-Search.
TASK DETAILhttps://phabricator.wikimedia.org/T175199WORKBOARDhttps://phabricator.wikimedia.org/project/board/1849/EMAIL
59 matches
Mail list logo
