gerritbot added a comment.
Change 324739 merged by jenkins-bot:
Add DispatchingPropertyInfoLookup
https://gerrit.wikimedia.org/r/324739TASK DETAILhttps://phabricator.wikimedia.org/T152103EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc:
daniel added a comment.
Another thing to consider is the caching layer. Do we have a caching PropertyInfoLookup for each repo, or only one cache, on top of the dispatching implementation? I'm tending towards having one cache per repo...TASK DETAILhttps://phabricator.wikimedia.org/T152103EMAIL PREFE
daniel added a comment.
@Jakob_WMDE Good catch!
I agree with @WMDE-leszek that we should switch to full serialized IDs instead of numeric IDs for the array index. That should not be done in the same patch, but perhaps it should be done before the patch introducing the dispatching implementation.
WMDE-leszek added a comment.
@Jakob_WMDE sorry, somehow I've managed to miss your comment.
One concern that I had while working on this was that the keys of the returned arrays of getAllPropertyInfo and getPropertyInfoForDataType of the previous implementations of PropertyInfoStore are numeric IDs
Jakob_WMDE added a comment.
One concern that I had while working on this was that the keys of the returned arrays of getAllPropertyInfo and getPropertyInfoForDataType of the previous implementations of PropertyInfoStore are numeric IDs of properties. Is that something that would need to be addresse
gerritbot added a comment.
Change 324739 had a related patch set uploaded (by Jakob):
Add DispatchingPropertyInfoLookup
https://gerrit.wikimedia.org/r/324739TASK DETAILhttps://phabricator.wikimedia.org/T152103EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ja
