[Wikidata-bugs] [Maniphest] T274283: UX/UI improvements for the Query Builder

Michael merged a task: T273046: Allow buttons to be full width. Michael added subscribers: Sarai-WMDE, Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T274283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Michael Cc: Ladsgroup,

[Wikidata-bugs] [Maniphest] T274283: UX/UI improvements for the Query Builder

Charlie_WMDE closed this task as "Resolved". Charlie_WMDE added a comment. looks good! TASK DETAIL https://phabricator.wikimedia.org/T274283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Charlie_WMDE Cc: Michael, Aklapper,

[Wikidata-bugs] [Maniphest] T274283: UX/UI improvements for the Query Builder

Ladsgroup added a comment. In T274283#6834054 , @Michael wrote: > I'm not sure if this is intentional or not, but that change introduces another layout for a couple of pixels between layout 3 and layout 4. But it doesn't look bad.

[Wikidata-bugs] [Maniphest] T274283: UX/UI improvements for the Query Builder

Charlie_WMDE added a comment. thanks @Ladsgroup and @Michael everything looks good to me. not sure what to do about > the run query button is now always size L, even in layout 1-3 (should only be the case for layout 4) i think this was not happening before, of course i might

[Wikidata-bugs] [Maniphest] T274283: UX/UI improvements for the Query Builder

Michael added a comment. In T274283#6833303 , @Ladsgroup wrote: > In T274283#6833078 , @Charlie_WMDE wrote: > >> Improvement C: >> i forgot to leave specs for the placement of

[Wikidata-bugs] [Maniphest] T274283: UX/UI improvements for the Query Builder

Ladsgroup moved this task from Doing to Peer Review on the Wikidata Query Builder board. Ladsgroup added a comment. In T274283#6833078 , @Charlie_WMDE wrote: > Improvement C: > i forgot to leave specs for the placement of the

[Wikidata-bugs] [Maniphest] T274283: UX/UI improvements for the Query Builder

Charlie_WMDE added a comment. Improvement C: i forgot to leave specs for the placement of the checkboxes inside of the decorator. i added them now in the mobile mock for space reasons, but the same specs apply for desktop

[Wikidata-bugs] [Maniphest] T274283: UX/UI improvements for the Query Builder

Charlie_WMDE added a comment. made an extra ticket for improvement G so we can close A-F: T274754 TASK DETAIL https://phabricator.wikimedia.org/T274283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T274283: UX/UI improvements for the Query Builder

Ladsgroup added a comment. This is A-F: https://github.com/wmde/query-builder/pull/197 For G, there's an issue. Those links are built using vue-banana and it doesn't add anything I can use to make it open in a new tab. Making it use instead of [] would decrease the security of messages

[Wikidata-bugs] [Maniphest] T274283: UX/UI improvements for the Query Builder

Ladsgroup claimed this task. Ladsgroup moved this task from Incoming to Doing on the Wikidata Query Builder board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T274283 WORKBOARD https://phabricator.wikimedia.org/project/board/4990/

[Wikidata-bugs] [Maniphest] T274283: UX/UI improvements for the Query Builder

Charlie_WMDE renamed this task from "UI improvements for the Query Builder" to "UX/UI improvements for the Query Builder". TASK DETAIL https://phabricator.wikimedia.org/T274283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Charlie_WMDE Cc: