[Wikidata-bugs] [Maniphest] T274283: UX/UI improvements for the Query Builder

[Michael]

Michael merged a task: T273046: Allow buttons to be full width.
Michael added subscribers: Sarai-WMDE, Ladsgroup.

TASK DETAIL
  https://phabricator.wikimedia.org/T274283

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Michael
Cc: Ladsgroup, Sarai-WMDE, Michael, Aklapper, Charlie_WMDE, Hazizibinmahdi, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274283: UX/UI improvements for the Query Builder

[Charlie_WMDE]

Charlie_WMDE closed this task as "Resolved".
Charlie_WMDE added a comment.


  looks good!

TASK DETAIL
  https://phabricator.wikimedia.org/T274283

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Charlie_WMDE
Cc: Michael, Aklapper, Charlie_WMDE, Hazizibinmahdi, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274283: UX/UI improvements for the Query Builder

[Ladsgroup]

Ladsgroup added a comment.


  In T274283#6834054 , 
@Michael wrote:
  
  > I'm not sure if this is intentional or not, but that change introduces 
another layout for a couple of pixels between layout 3 and layout 4. But it 
doesn't look bad. @Charlie_WMDE  what do you think?
  
  I basically tried to unify value of tinyviewport size (from 36em or 38em in 
different places to just one value, 38em).

TASK DETAIL
  https://phabricator.wikimedia.org/T274283

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Michael, Aklapper, Charlie_WMDE, Hazizibinmahdi, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274283: UX/UI improvements for the Query Builder

[Charlie_WMDE]

Charlie_WMDE added a comment.


  thanks @Ladsgroup and @Michael
  
  everything looks good to me. not sure what to do about
  
  > the run query button is now always size L, even in layout 1-3 (should only 
be the case for layout 4)
  
  i think this was not happening before, of course i might have missed it.
  
  regarding what michael wrote,
  
  > I'm not sure if this is intentional or not, but that change introduces 
another layout for a couple of pixels between layout 3 and layout 4. But it 
doesn't look bad. @Charlie_WMDE what do you think?
  
  ^^ never intended this to happen, but fine by me!

TASK DETAIL
  https://phabricator.wikimedia.org/T274283

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Charlie_WMDE
Cc: Michael, Aklapper, Charlie_WMDE, Hazizibinmahdi, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274283: UX/UI improvements for the Query Builder

[Michael]

Michael added a comment.


  In T274283#6833303 , 
@Ladsgroup wrote:
  
  > In T274283#6833078 , 
@Charlie_WMDE wrote:
  >
  >> Improvement C: 
  >> i forgot to leave specs for the placement of the checkboxes inside of the 
decorator. i added them now in the mobile mock for space reasons, but the same 
specs apply for desktop 

 and they're all using the same token. let me know if this should be an extra 
ticket or can be done in this one
  >
  > Done: https://github.com/wmde/query-builder/pull/202
  >
  >> Improvement E:
  >>
  >> - The buttons switch to full width a bit later than layout 4 is triggered
  >
  > Done: https://github.com/wmde/query-builder/pull/202
  
  I'm not sure if this is intentional or not, but that change introduces 
another layout for a couple of pixels between layout 3 and layout 4. But it 
doesn't look bad. @Charlie_WMDE  what do you think?
  
  F34107881: image.png 
  
  You can see it there: 
https://602bb7356bcc7715c49fa011--clicky-sparqly.netlify.app/

TASK DETAIL
  https://phabricator.wikimedia.org/T274283

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Michael
Cc: Michael, Aklapper, Charlie_WMDE, Hazizibinmahdi, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274283: UX/UI improvements for the Query Builder

[Ladsgroup]

Ladsgroup moved this task from Doing to Peer Review on the Wikidata Query 
Builder board.
Ladsgroup added a comment.


  In T274283#6833078 , 
@Charlie_WMDE wrote:
  
  > Improvement C: 
  > i forgot to leave specs for the placement of the checkboxes inside of the 
decorator. i added them now in the mobile mock for space reasons, but the same 
specs apply for desktop 

 and they're all using the same token. let me know if this should be an extra 
ticket or can be done in this one
  
  Done: https://github.com/wmde/query-builder/pull/202
  
  > Improvement E:
  >
  > - The buttons switch to full width a bit later than layout 4 is triggered
  
  Done: https://github.com/wmde/query-builder/pull/202
  
  > Not sure if related but:
  >
  > - the run query button is now always size L, even in layout 1-3 (should 
only be the case for layout 4)
  
  This is interesting, we don't have size attribute for buttons in the design 
system. I don't know how this can be tackled.
  
  > Improvement F:
  >
  > - most of the spacing is not correct unfortunately. Except for the spacing 
between the "run query button" and the "link to query", and the spacing between 
the "settings header" and the "decorator" they're all off by a few pixels.
  
  I double checked and it uses the correct token. My assumption is that it uses 
em and given that it changes with different font sizes, it changes? Can you 
check it with em?

TASK DETAIL
  https://phabricator.wikimedia.org/T274283

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4990/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Aklapper, Charlie_WMDE, Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274283: UX/UI improvements for the Query Builder

[Charlie_WMDE]

Charlie_WMDE added a comment.


  Improvement C: 
  i forgot to leave specs for the placement of the checkboxes inside of the 
decorator. i added them now in the mobile mock for space reasons, but the same 
specs apply for desktop 

 and they're all using the same token. let me know if this should be an extra 
ticket or can be done in this one
  
  Improvement E:
  
  - The buttons switch to full width a bit later than layout 4 is triggered
  
  Not sure if related but:
  
  - the run query button is now always size L, even in layout 1-3 (should only 
be the case for layout 4)
  
  Improvement F:
  
  - most of the spacing is not correct unfortunately. Except for the spacing 
between the "run query button" and the "link to query", and the spacing between 
the "settings header" and the "decorator" they're all off by a few pixels.
  
  happy to have a chat about the details if you like!

TASK DETAIL
  https://phabricator.wikimedia.org/T274283

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Charlie_WMDE
Cc: Aklapper, Charlie_WMDE, Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274283: UX/UI improvements for the Query Builder

[Charlie_WMDE]

Charlie_WMDE added a comment.


  made an extra ticket for improvement G so we can close A-F: T274754 


TASK DETAIL
  https://phabricator.wikimedia.org/T274283

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Charlie_WMDE
Cc: Aklapper, Charlie_WMDE, Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274283: UX/UI improvements for the Query Builder

[Ladsgroup]

Ladsgroup added a comment.


  This is A-F: https://github.com/wmde/query-builder/pull/197
  
  For G, there's an issue. Those links are built using vue-banana and it 
doesn't add anything I can use to make it open in a new tab. Making it use  
instead of [] would decrease the security of messages since I have to accept 
raw html.

TASK DETAIL
  https://phabricator.wikimedia.org/T274283

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Aklapper, Charlie_WMDE, Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274283: UX/UI improvements for the Query Builder

[Ladsgroup]

Ladsgroup claimed this task.
Ladsgroup moved this task from Incoming to Doing on the Wikidata Query Builder 
board.
Restricted Application added a project: User-Ladsgroup.

TASK DETAIL
  https://phabricator.wikimedia.org/T274283

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4990/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Aklapper, Charlie_WMDE, Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274283: UX/UI improvements for the Query Builder

[Charlie_WMDE]

Charlie_WMDE renamed this task from "UI improvements for the Query Builder" to 
"UX/UI improvements for the Query Builder".

TASK DETAIL
  https://phabricator.wikimedia.org/T274283

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Charlie_WMDE
Cc: Aklapper, Charlie_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs