[MediaWiki-CodeReview] [MediaWiki r89245]: New comment added

2011-07-05 Thread MediaWiki Mail
User Tim Starling posted a comment on MediaWiki.r89245. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89245#c19182 Commit summary: Fixes for r3, r89197: * Modified WebRequest::findIE6Extension() to fix the performance issue and the hash parsing issue I noted on CR * In

[MediaWiki-CodeReview] [MediaWiki r89248]: New comment added

2011-07-05 Thread MediaWiki Mail
User Tim Starling posted a comment on MediaWiki.r89248. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89248#c19183 Commit summary: * Only blacklist query string extensions which match /^[a-zA-Z0-9_-]+$/. This avoids blacklisting pretty much every api.php URL with a dot in it,

[MediaWiki-CodeReview] [MediaWiki r85249]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r85249. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85249#c0 Commit summary: Followup r85244; Fix a small issue with the case of a variable name. ___

[MediaWiki-CodeReview] [MediaWiki r89249]: New comment added

2011-07-05 Thread MediaWiki Mail
User Tim Starling posted a comment on MediaWiki.r89249. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89249#c19184 Commit summary: Fix for r89248: don't run the regex if findIE6Extension returns false. Only affects performance, the logic is the same. Comment: Untagging

[MediaWiki-CodeReview] [MediaWiki r79398]: New comment added, and revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r79398. Old Status: new New Status: ok User Aaron Schulz also posted a comment on MediaWiki.r79398. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79398#c19185 Commit summary: Implement relevant title and user in the skin system

[MediaWiki-CodeReview] [MediaWiki r79523]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r79523. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79523#c0 Commit summary: Throw an exception if calling parent or self on MWFunction. ___

[MediaWiki-CodeReview] [MediaWiki r79647]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r79647. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79647#c0 Commit summary: Easier method (and to check existence in correct language) ___

[MediaWiki-CodeReview] [MediaWiki r81037]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r81037. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81037#c0 Commit summary: Last $wgArticle junk in Skin(Template). Just pass the article on hand to lastModified(). Nothing outside of here

[MediaWiki-CodeReview] [MediaWiki r91092]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91092. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91092#c0 Commit summary: CR tweak for MobileFrontend: fix a missed var rename ___

[MediaWiki-CodeReview] [MediaWiki r91223]: New comment added

2011-07-05 Thread MediaWiki Mail
User MZMcBride posted a comment on MediaWiki.r91223. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91223#c19186 Commit summary: Move parameter stuff around so we can do the multi cases... Comment: If this is intended for deployment, these revisions shouldn't be marked

[MediaWiki-CodeReview] [MediaWiki r91026]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91026. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91026#c0 Commit summary: - Fixed bug on GadgetHooks::articleSaveComplete() - Implemented getModifiedTime() method on gadget modules and

[MediaWiki-CodeReview] [MediaWiki r90249]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r90249. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90249#c0 Commit summary: StubUser was last in 1.16 No idea when StubTitle was last used Fixup return documentation

[MediaWiki-CodeReview] [MediaWiki r91432]: New comment added

2011-07-05 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r91432. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91432#c19187 Commit summary: (see bug 29712) Removing the defaultUserOptionOverrides in MessagesXx.php because it is broken (and has been for a long time) and secondly, it is

[Wikitech-l] Weird CodeReview notifs

2011-07-05 Thread Leo Koppelkamm
Just got this and 3 similar mails. The thread and the revision number don't match. http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90678 Forwarded message: From: MediaWiki Mail w...@wikimedia.org To: DieBuche diebu...@gmail.com Date: Tuesday, July 5, 2011 1:36:58 AM Subject:

[MediaWiki-CodeReview] [MediaWiki r91439]: New comment added

2011-07-05 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r91439. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91439#c19188 Commit summary: Add PLURAL-support Comment: If you only do plurals when parsing, the mode represents more what MediaWiki calls transform or parsemag.

[MediaWiki-CodeReview] [MediaWiki r91439]: New comment added

2011-07-05 Thread MediaWiki Mail
User Jan Luca posted a comment on MediaWiki.r91439. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91439#c19189 Commit summary: Add PLURAL-support Comment: Changed in r91444 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91450]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91450. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91450#c0 Commit summary: Removed usage of error suppression operator ___ MediaWiki-CodeReview mailing

[Wikitech-l] Unit testing: request for comments commitments

2011-07-05 Thread Sumana Harihareswara
http://www.mediawiki.org/wiki/Requests_for_comment/Unit_testing This document explains: * why MediaWiki needs even better unit testing, * what we're doing now * and what we need to do next. This is also a request for comments commitments to make our testing environment better.

[MediaWiki-CodeReview] [MediaWiki r91459]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91459. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91459#c0 Commit summary: Hashar seems to have missed one occurence of OutputPage::getStatusMessage() in r91425

[MediaWiki-CodeReview] [MediaWiki r91445]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91445. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91445#c0 Commit summary: Removed CategoryViewer::getSkin() and replaced by static calls to Linker; no use in extensions.

[MediaWiki-CodeReview] [MediaWiki r91223]: New comment added

2011-07-05 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r91223. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91223#c19190 Commit summary: Move parameter stuff around so we can do the multi cases... Comment: Intended for deployment is unclear at the moment. There is possibility this will be

[MediaWiki-CodeReview] [MediaWiki r91453]: New comment added

2011-07-05 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r91453. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91453#c19192 Commit summary: (bug 5800) Added $formCallback as a parameter to the hook EditPage::showEditForm:initial Comment: How should this be handled when there's already

[MediaWiki-CodeReview] [MediaWiki r91330]: New comment added

2011-07-05 Thread MediaWiki Mail
User SPQRobin posted a comment on MediaWiki.r91330. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91330#c19193 Commit summary: Move prefs-beta and prefs-labs messages from WikiEditor to core Comment: Maybe we should change these messages or re-organise it a bit, see

[MediaWiki-CodeReview] [MediaWiki r91414]: New comment added

2011-07-05 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r91414. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91414#c19194 Commit summary: (bug 29109) Allow the automatic edit summary for redirect creation show the first bit of the new redirect page. Adds $2 to the autoredircomment

[MediaWiki-CodeReview] [MediaWiki r91460]: New comment added

2011-07-05 Thread MediaWiki Mail
User IAlex posted a comment on MediaWiki.r91460. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91460#c19195 Commit summary: * Don't create a WebRequest obhject in CLI mode but a FauxRequest; avoids some useless notices about headers already sent (I know

[MediaWiki-CodeReview] [MediaWiki r91409]: New comment added, and revision status changed

2011-07-05 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r91409. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r91409. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91409#c19196 Commit summary: * Removed usage of error suppression operator in

[MediaWiki-CodeReview] [MediaWiki r91463]: New comment added, and revision status changed

2011-07-05 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r91463. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r91463. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91463#c19197 Commit summary: Per Brion, fix for r91460: make this a bit more

[MediaWiki-CodeReview] [MediaWiki r91460]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r91460. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91460#c0 Commit summary: * Don't create a WebRequest obhject in CLI mode but a FauxRequest; avoids some useless notices about headers

[MediaWiki-CodeReview] [MediaWiki r91305]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r91305. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91305#c0 Commit summary: Removed ampersand in HTMLFileCache constructor ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r91464]: New comment added

2011-07-05 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r91464. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91464#c19198 Commit summary: Bugfix: Localization wasn't loaded LQT-enabled (inexisting) User_talk-pages. Caused the entire editor to be filled with foobar. This fixes it. Comment:

[MediaWiki-CodeReview] [MediaWiki r79475]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r79475. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79475#c0 Commit summary: * Toggle entire element if no .mw-collapsible-content is found * Bug fixed in which a single customtoggle should

[MediaWiki-CodeReview] [MediaWiki r79642]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r79642. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79642#c0 Commit summary: Allow OutputPage::parse() to parse in any langauge, modified wfMsgExt() and wfMessage() accordingly

[MediaWiki-CodeReview] [MediaWiki r91466]: New comment added

2011-07-05 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r91466. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91466#c19199 Commit summary: adjusting width of ArticleFeedback-tooltip container. - Previously much wider than the actual 5-star-rating-container, which was done as a middle way

[MediaWiki-CodeReview] [MediaWiki r79706]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r79706. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79706#c0 Commit summary: (Bug 25254) cl_timestamp gets updated on null edit where it shouldn't. Caused by two things: *after the new

[MediaWiki-CodeReview] [MediaWiki r80407]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r80407. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80407#c0 Commit summary: (bug 2585) Image pages should send 404 if no image, no shared image and no description page (To be consistant with

[MediaWiki-CodeReview] [MediaWiki r91280]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r91280. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91280#c0 Commit summary: better default styling ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r82895]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r82895. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82895#c0 Commit summary: Return sooner if there's nothing to replace ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r91287]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r91287. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91287#c0 Commit summary: fixing double encoding - bug 29668 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91287]: New comment added

2011-07-05 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r91287. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91287#c19202 Commit summary: fixing double encoding - bug 29668 Comment: The commit looks good, so marking ok. Which bug did you mean though ?- bug 29668 seems a different one.

[MediaWiki-CodeReview] [MediaWiki r82748]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r82748. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82748#c0 Commit summary: Removed white-background from ul.gallery; Updated commonPrint gallery styles Since a while now proper margins and

[MediaWiki-CodeReview] [MediaWiki r82546]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r82546. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82546#c0 Commit summary: revert r82544, and fix similar problem with preceding query ___

[MediaWiki-CodeReview] [MediaWiki r82905]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r82905. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82905#c0 Commit summary: Use a true minus in wikidiff. just like in WikiDiff.php Fixes bug 26038

[MediaWiki-CodeReview] [MediaWiki r91287]: New comment added

2011-07-05 Thread MediaWiki Mail
User Kaldari posted a comment on MediaWiki.r91287. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91287#c19203 Commit summary: fixing double encoding - bug 29668 Comment: Oops, this actually fixed bug 29670. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r91472]: New comment added, and revision status changed

2011-07-05 Thread MediaWiki Mail
User Kaldari changed the status of MediaWiki.r91472. Old Status: new New Status: ok User Kaldari also posted a comment on MediaWiki.r91472. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91472#c19205 Commit summary: using mw.util.wikiGetlink + minors and w/s Comment:

[MediaWiki-CodeReview] [MediaWiki r91287]: New comment added

2011-07-05 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r91287. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91287#c19206 Commit summary: fixing double encoding - bug 29668 Comment: Okay, cool. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91476]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r91476. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91476#c0 Commit summary: 1.17wmf1: Properly alias $ to jQuery in all ext.vector.*.js files. Already done in trunk. Needed to unbreak SimpleSearch

[MediaWiki-CodeReview] [MediaWiki r91478]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r91478. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91478#c0 Commit summary: killing a space invader, I mean character ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r89523]: New comment added

2011-07-05 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r89523. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89523#c19207 Commit summary: * (bug 28002) Internal error in ApiFormatRaw::getMimeType If we just return when no titles, we don't format anything, and everything breaks Might aswell

[MediaWiki-CodeReview] [MediaWiki r91473]: New comment added

2011-07-05 Thread MediaWiki Mail
User Jack Phoenix posted a comment on MediaWiki.r91473. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91473#c19209 Commit summary: More comments Change DumpActiveEditors100Metric to subclass DumpActiveEditors5Metric Comment: pre - return 'Percentage of total

[MediaWiki-CodeReview] [MediaWiki r91326]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r91326. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91326#c0 Commit summary: A style fix for old skins ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91432]: New comment added

2011-07-05 Thread MediaWiki Mail
User Raymond posted a comment on MediaWiki.r91432. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91432#c19211 Commit summary: (see bug 29712) Removing the defaultUserOptionOverrides in MessagesXx.php because it is broken (and has been for a long time) and secondly, it is only

[MediaWiki-CodeReview] [MediaWiki r84320]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r84320. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84320#c0 Commit summary: * Increased file descriptor limit * Wait 1 second for start-stop-daemon to do its thing before checking if the daemon

[MediaWiki-CodeReview] [MediaWiki r84283]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r84283. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84283#c0 Commit summary: Extract bit depth and color type for PNG images ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r91479]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r91479. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91479#c0 Commit summary: Merge r89523 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91481]: New comment added

2011-07-05 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r91481. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91481#c19212 Commit summary: MediaWiki:Viewcount does not need PLURAL in French Comment: I'd prefer just using dummy nowiki{{PLURAL:$1}}/nowiki in the message.

[MediaWiki-CodeReview] [MediaWiki r86047]: New comment added

2011-07-05 Thread MediaWiki Mail
User Helder.wiki posted a comment on MediaWiki.r86047. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86047#c19213 Commit summary: History: Adding JS that converts buttons to links for better UX. Patch based on one by Matthew Flaschen. Fixes Bug 16165 Comment: For the record:

[MediaWiki-CodeReview] [MediaWiki r85242]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r85242. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85242#c0 Commit summary: Followup r85240; Commit the additional file that was part of that change. ;) this wouldn't have happened if we were

[MediaWiki-CodeReview] [MediaWiki r85240]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r85240. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85240#c0 Commit summary: Implement the RequestContext class. Some credit to IAlex, ;) other credit for me and that plethora of bugs and

[MediaWiki-CodeReview] [MediaWiki r91449]: New comment added, and revision status changed

2011-07-05 Thread MediaWiki Mail
User Raymond changed the status of MediaWiki.r91449. Old Status: deferred New Status: fixme User Raymond also posted a comment on MediaWiki.r91449. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91449#c19214 Commit summary: rewritten code related to encoding/storage/retrieval

[MediaWiki-CodeReview] [MediaWiki r91317]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User NeilK changed the status of MediaWiki.r91317. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91317#c0 Commit summary: * rename SpecialModifyBlacklist to SpecialModifyArchiveBlacklist to avoid confusion with other blacklists in mediawiki.

[MediaWiki-CodeReview] [MediaWiki r91487]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r91487. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91487#c0 Commit summary: Needs $IP, to accomodate wikis with different directory structure ___

Re: [Wikitech-l] IRC Triage of “easy” bugs

2011-07-05 Thread Matias
I've been waiting for this but unfortunately I can't be at that time. Would there be a log about the result? On Tue, Jul 5, 2011 at 4:11 PM, Mark A. Hershberger mhershber...@wikimedia.org wrote: Tomorrow (July 6th, Wednesday) at 2100UTC, I will hold a triage on IRC of “easy” bugs. The

[MediaWiki-CodeReview] [MediaWiki r91330]: New comment added, and revision status changed

2011-07-05 Thread MediaWiki Mail
User Raymond changed the status of MediaWiki.r91330. Old Status: fixme New Status: new User Raymond also posted a comment on MediaWiki.r91330. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91330#c19215 Commit summary: Move prefs-beta and prefs-labs messages from WikiEditor to

[MediaWiki-CodeReview] [MediaWiki r91389]: New comment added, and revision status changed

2011-07-05 Thread MediaWiki Mail
User Kaldari changed the status of MediaWiki.r91389. Old Status: new New Status: ok User Kaldari also posted a comment on MediaWiki.r91389. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91389#c19216 Commit summary: WikiLove fixes: * Follow-up r91083 CR: Make sure input like

[MediaWiki-CodeReview] [MediaWiki r91083]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Kaldari changed the status of MediaWiki.r91083. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91083#c0 Commit summary: WikiLove minor fixes: * Trailing comma's in object literals brakes IE (in rememberInputData and

[MediaWiki-CodeReview] [MediaWiki r85252]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r85252. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85252#c0 Commit summary: Followup r85250; Revert a static method back to use of $wgRequest... :/ damnit resourceloader...

[MediaWiki-CodeReview] [MediaWiki r91449]: New comment added, and revision status changed

2011-07-05 Thread MediaWiki Mail
User Raymond changed the status of MediaWiki.r91449. Old Status: fixme New Status: deferred User Raymond also posted a comment on MediaWiki.r91449. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91449#c19217 Commit summary: rewritten code related to encoding/storage/retrieval

[MediaWiki-CodeReview] [MediaWiki r91449]: New comment added

2011-07-05 Thread MediaWiki Mail
User Raymond posted a comment on MediaWiki.r91449. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91449#c19218 Commit summary: rewritten code related to encoding/storage/retrieval of containers using internal objects; internal objects now represented by DIWikiPages, no more

[MediaWiki-CodeReview] [MediaWiki r85438]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r85438. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85438#c0 Commit summary: Make hours smaller! r84782 follow-up. ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r90934]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r90934. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90934#c0 Commit summary: (follow-up to some RequestContext revision) When Special:userlogin creates a new user, not only replace $wgUser, but

[MediaWiki-CodeReview] [MediaWiki r85250]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r85250. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85250#c0 Commit summary: Continue with r85240; Move getSkin from User to RequestContext, do it without globals, strip out the

[MediaWiki-CodeReview] [MediaWiki r78156]: New comment added

2011-07-05 Thread MediaWiki Mail
User Helder.wiki posted a comment on MediaWiki.r78156. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78156#c19219 Commit summary: Ported jsMsg to mw.util; Fixing bugs and modernising mediawiki.action.watch.ajax.js a little more * Using the raw element instead of jQuery object

[MediaWiki-CodeReview] [MediaWiki r85247]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r85247. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85247#c0 Commit summary: Followup r85244; Define all methods as static, implement a DummyLinker to forward calls for passing to hooks

[MediaWiki-CodeReview] [MediaWiki r85244]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r85244. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85244#c0 Commit summary: Drop connetion between Skin and Linker and turn Linker into a staticly usable class.

[MediaWiki-CodeReview] [MediaWiki r87997]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r87997. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87997#c0 Commit summary: * (bug 15461) Make IE8 turn off content sniffing. Everbody else should ignore this Adding X-Content-Type-Options:

[MediaWiki-CodeReview] [MediaWiki r87837]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r87837. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87837#c0 Commit summary: Simplify code by using OutputPage::wrapWikiMsg() ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r88730]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r88730. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88730#c0 Commit summary: JS fixes a little cleanup/modernization on CheckUser Was throwing errors due to trying to use addOnloadHook() from

[MediaWiki-CodeReview] [MediaWiki r78156]: New comment added

2011-07-05 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r78156. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78156#c19220 Commit summary: Ported jsMsg to mw.util; Fixing bugs and modernising mediawiki.action.watch.ajax.js a little more * Using the raw element instead of jQuery object to

[MediaWiki-CodeReview] [MediaWiki r91432]: New comment added

2011-07-05 Thread MediaWiki Mail
User SPQRobin posted a comment on MediaWiki.r91432. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91432#c19221 Commit summary: (see bug 29712) Removing the defaultUserOptionOverrides in MessagesXx.php because it is broken (and has been for a long time) and secondly, it is only

[MediaWiki-CodeReview] [MediaWiki r88555]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r88555. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88555#c0 Commit summary: Report importDump to subclass Maintenance ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r88568]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r88568. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88568#c0 Commit summary: Adding fixme note for bug 29088. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r88392]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r88392. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88392#c0 Commit summary: Changing console.log(e) to a throw. console.log makes it go toString() which is pretty much the same as the e.message

[MediaWiki-CodeReview] [MediaWiki r88595]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r88595. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88595#c0 Commit summary: * (bug 28272) Special:Allmessages should have only one Go button Patch by MZMcBride

Re: [Wikitech-l] A different API problem

2011-07-05 Thread Ryan Kaldari
Tim has fixed the issue on the live wikis. I imagine he just pushed up the fix that was already on trunk, so we probably still need to fix it for the case mentioned by Neil. Ryan Kaldari On 7/3/11 11:41 PM, Neil Kandalgaonkar wrote: On 7/3/11 2:55 PM, Roan Kattouw wrote: Well as I just

[MediaWiki-CodeReview] [MediaWiki r88594]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r88594. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88594#c0 Commit summary: Moved MediaWiki::articleFromTitle() to Article::newFromTitle(), this has nothing to do in the MediaWiki class

[MediaWiki-CodeReview] [MediaWiki r89205]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89205. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89205#c0 Commit summary: Make $wgDebugRawPage=false also ignore load.php, so that debug logs can be readable again.

[MediaWiki-CodeReview] [MediaWiki r88885]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r5. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/5#c0 Commit summary: Remove reset button from Special:Undelete. It does more harm than good

[MediaWiki-CodeReview] [MediaWiki r88886]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r6. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/6#c0 Commit summary: r5: Change message as well ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91500]: New comment added

2011-07-05 Thread MediaWiki Mail
User Helder.wiki posted a comment on MediaWiki.r91500. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91500#c19222 Commit summary: mw.util.wikiGetlink default to wgPageName * (bug 29723) mw.util.wikiGetlink() should default to wgPageName * Solution by mybugs.mail * Adding unit

[MediaWiki-CodeReview] [MediaWiki r89221]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89221. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89221#c0 Commit summary: Follow up r89220. Misleading comment left from r88971 ___

[MediaWiki-CodeReview] [MediaWiki r90585]: New comment added, and revision status changed

2011-07-05 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r90585. Old Status: new New Status: ok User Aaron Schulz also posted a comment on MediaWiki.r90585. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90585#c19223 Commit summary: * removed DEFAULT '' NOT NULL constraints as '' is

[MediaWiki-CodeReview] [MediaWiki r91480]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r91480. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91480#c0 Commit summary: support for reportlanguage, and typo fix ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91482]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r91482. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91482#c0 Commit summary: added takes report language param for comscore reporting ___

[MediaWiki-CodeReview] [MediaWiki r80572]: New comment added

2011-07-05 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r80572. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80572#c19224 Commit summary: Fix bug in mw.Map + fix bug 26801 + wrapper mediawiki.special.upload.js * Map.prototype.exists was checking the type of the wrong variable. Fixed

[MediaWiki-CodeReview] [MediaWiki r80572]: New comment added

2011-07-05 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r80572. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80572#c19225 Commit summary: Fix bug in mw.Map + fix bug 26801 + wrapper mediawiki.special.upload.js * Map.prototype.exists was checking the type of the wrong variable. Fixed now,

[MediaWiki-CodeReview] [MediaWiki r91471]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91471. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91471#c0 Commit summary: Fixing typo in r91468. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91505]: Revision status changed

2011-07-05 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r91505. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91505#c0 Commit summary: Partial backport of r80572 per bug 29726: failure in map.exists in WebKit browsers for multiple keys or if a global

[MediaWiki-CodeReview] [MediaWiki r80572]: New comment added, and revision status changed

2011-07-05 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r80572. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r80572. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80572#c19227 Commit summary: Fix bug in mw.Map + fix bug 26801 + wrapper

[MediaWiki-CodeReview] [MediaWiki r91500]: New comment added

2011-07-05 Thread MediaWiki Mail
User Helder.wiki posted a comment on MediaWiki.r91500. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91500#c19228 Commit summary: mw.util.wikiGetlink default to wgPageName * (bug 29723) mw.util.wikiGetlink() should default to wgPageName * Solution by mybugs.mail * Adding unit

[MediaWiki-CodeReview] [MediaWiki r91518]: New comment added

2011-07-05 Thread MediaWiki Mail
User SPQRobin posted a comment on MediaWiki.r91518. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91518#c19229 Commit summary: (bug 6100; follow-up to r91315) Being bold and removing $wgBetterDirectionality (and dependent wfUILang) in core, as most or all work is finished.

  1   2   >