[MediaWiki-CodeReview] [MediaWiki r91496]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91496. Old Status: fixme New Status: new Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91496#c0 Commit summary: DumpHTML fixes: * Made SkinOffline use getTitle() instead of non-existing mTitle * Made

[MediaWiki-CodeReview] [MediaWiki r91506]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91506. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91506#c0 Commit summary: code readability is everything ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r90585]: New comment added

2011-07-06 Thread MediaWiki Mail
User Freakolowsky posted a comment on MediaWiki.r90585. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90585#c19241 Commit summary: * removed DEFAULT '' NOT NULL constraints as '' is internaly converted to NULL in Oracle and throws an error * fixed tableName handling

[MediaWiki-CodeReview] [MediaWiki r88134]: New comment added

2011-07-06 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r88134. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88134#c19242 Commit summary: Fixed a bug in transformation where previous language could leak into later transformations in UI language. Not sure what do with userlang. Comment:

[MediaWiki-CodeReview] [MediaWiki r91449]: New comment added

2011-07-06 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r91449. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91449#c19243 Commit summary: rewritten code related to encoding/storage/retrieval of containers using internal objects; internal objects now represented by DIWikiPages, no more

[MediaWiki-CodeReview] [MediaWiki r91031]: New comment added

2011-07-06 Thread MediaWiki Mail
User Tim Starling posted a comment on MediaWiki.r91031. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91031#c19244 Commit summary: (bug 29277) MediaWiki:Filepage.css not loaded on foreignwiki itself. Fixup to r68904. Yay Roan finally taught me how to use the resourceloader :D

[MediaWiki-CodeReview] [MediaWiki r88134]: New comment added

2011-07-06 Thread MediaWiki Mail
User Tim Starling posted a comment on MediaWiki.r88134. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88134#c19245 Commit summary: Fixed a bug in transformation where previous language could leak into later transformations in UI language. Not sure what do with userlang.

[MediaWiki-CodeReview] [MediaWiki r91528]: New comment added

2011-07-06 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r91528. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91528#c19246 Commit summary: Make the reply count in the URL (reply_(X)) use $wgContLang-formatNum(), so it uses e.g. Persian numbers when the content language is Persian.

[MediaWiki-CodeReview] [MediaWiki r91528]: New comment added

2011-07-06 Thread MediaWiki Mail
User Werdna posted a comment on MediaWiki.r91528. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91528#c19247 Commit summary: Make the reply count in the URL (reply_(X)) use $wgContLang-formatNum(), so it uses e.g. Persian numbers when the content language is Persian. Reported

[MediaWiki-CodeReview] [MediaWiki r91528]: New comment added

2011-07-06 Thread MediaWiki Mail
User SPQRobin posted a comment on MediaWiki.r91528. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91528#c19248 Commit summary: Make the reply count in the URL (reply_(X)) use $wgContLang-formatNum(), so it uses e.g. Persian numbers when the content language is Persian. Reported

[Wikitech-l] Printing

2011-07-06 Thread Thomas Morton
Quick one for the tech folks: is there a known issue with printing at the moment? OTRS keeps getting comments that printing gets cut off after one page... I searched bugzilla to no avail and am 99% certain this is a local computer issue each time, but I wanted to check no one was aware of an

[MediaWiki-CodeReview] [MediaWiki r86047]: New comment added

2011-07-06 Thread MediaWiki Mail
User DieBuche posted a comment on MediaWiki.r86047. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86047#c19249 Commit summary: History: Adding JS that converts buttons to links for better UX. Patch based on one by Matthew Flaschen. Fixes Bug 16165 Comment: Reverted until we

[MediaWiki-CodeReview] [MediaWiki r86056]: New comment added, and revision status changed

2011-07-06 Thread MediaWiki Mail
User DieBuche changed the status of MediaWiki.r86056. Old Status: fixme New Status: new User DieBuche also posted a comment on MediaWiki.r86056. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86056#c19250 Commit summary: Followup to r86047: Rewrite the radio-button updater

[MediaWiki-CodeReview] [MediaWiki r86305]: New comment added, and revision status changed

2011-07-06 Thread MediaWiki Mail
User DieBuche changed the status of MediaWiki.r86305. Old Status: fixme New Status: new User DieBuche also posted a comment on MediaWiki.r86305. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86305#c19251 Commit summary: Followup r86088 per CR: Move month array builder into

[MediaWiki-CodeReview] [MediaWiki r86108]: New comment added, and revision status changed

2011-07-06 Thread MediaWiki Mail
User DieBuche changed the status of MediaWiki.r86108. Old Status: fixme New Status: new User DieBuche also posted a comment on MediaWiki.r86108. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86108#c19252 Commit summary: Followup ro r86088: Use data-sort-type instead of classes

[MediaWiki-CodeReview] [MediaWiki r91549]: New comment added

2011-07-06 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r91549. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91549#c19253 Commit summary: CodeReview: Resolved is effectively the same as (or very similar to) OK; but the green background makes it standout unnecessarily. Coloring the same as

[MediaWiki-CodeReview] [MediaWiki r91490]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91490. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91490#c0 Commit summary: Moved 'MW_HTML_FOR_DUMP' check before config vars (localsettings may try to access them)

[MediaWiki-CodeReview] [MediaWiki r91500]: New comment added, and revision status changed

2011-07-06 Thread MediaWiki Mail
User DieBuche changed the status of MediaWiki.r91500. Old Status: new New Status: ok User DieBuche also posted a comment on MediaWiki.r91500. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91500#c19254 Commit summary: mw.util.wikiGetlink default to wgPageName * (bug 29723)

[MediaWiki-CodeReview] [MediaWiki r87271]: New comment added

2011-07-06 Thread MediaWiki Mail
User DieBuche posted a comment on MediaWiki.r87271. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87271#c19255 Commit summary: AFT Fixes * Linking page titles in the Dashboard at Special:ArticleFeedback * (bug 28125) Don't load the ext.articleFeedback module, nor initialize it

[MediaWiki-CodeReview] [MediaWiki r87048]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User DieBuche changed the status of MediaWiki.r87048. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87048#c0 Commit summary: Using new jquery.json module in ext.UserBuckets module ___

[MediaWiki-CodeReview] [MediaWiki r87046]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User DieBuche changed the status of MediaWiki.r87046. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87046#c0 Commit summary: AFT/ClickTracking JsPerf + JsLint fixes: * Combining (function($){}(jQuery); and $(document).ready (check [[Conventions]]

[MediaWiki-CodeReview] [MediaWiki r86047]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User DieBuche changed the status of MediaWiki.r86047. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86047#c0 Commit summary: History: Adding JS that converts buttons to links for better UX. Patch based on one by Matthew Flaschen. Fixes Bug

[MediaWiki-CodeReview] [MediaWiki r91549]: New comment added

2011-07-06 Thread MediaWiki Mail
User DieBuche posted a comment on MediaWiki.r91549. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91549#c19256 Commit summary: CodeReview: Resolved is effectively the same as (or very similar to) OK; but the green background makes it standout unnecessarily. Coloring the same as

[MediaWiki-CodeReview] [MediaWiki r91549]: New comment added

2011-07-06 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r91549. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91549#c19257 Commit summary: CodeReview: Resolved is effectively the same as (or very similar to) OK; but the green background makes it standout unnecessarily. Coloring the same as

[MediaWiki-CodeReview] [MediaWiki r82783]: New comment added

2011-07-06 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r82783. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82783#c19258 Commit summary: * (bug 24230) Added JAR detection. ZIP archives containing a .class file will be rejected by default. Malformed ZIP archives will be rejected due to the

[MediaWiki-CodeReview] [MediaWiki r82783]: New comment added

2011-07-06 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r82783. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82783#c19259 Commit summary: * (bug 24230) Added JAR detection. ZIP archives containing a .class file will be rejected by default. Malformed ZIP archives will be rejected due to the

[MediaWiki-CodeReview] [MediaWiki r91426]: New comment added, and revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91426. Old Status: new New Status: fixme User ^demon also posted a comment on MediaWiki.r91426. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91426#c19260 Commit summary: fixing rounding problem, per comment at r82309 Comment:

[MediaWiki-CodeReview] [MediaWiki r91426]: New comment added

2011-07-06 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r91426. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91426#c19261 Commit summary: fixing rounding problem, per comment at r82309 Comment: Stupid CR parsing. Use [[User:^demon/gallery failure 91426|this link]]

[MediaWiki-CodeReview] [MediaWiki r91543]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91543. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91543#c0 Commit summary: lseek and read failures return -1 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91549]: New comment added

2011-07-06 Thread MediaWiki Mail
User DieBuche posted a comment on MediaWiki.r91549. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91549#c19262 Commit summary: CodeReview: Resolved is effectively the same as (or very similar to) OK; but the green background makes it standout unnecessarily. Coloring the same as

[MediaWiki-CodeReview] [MediaWiki r91435]: New comment added, and revision status changed

2011-07-06 Thread MediaWiki Mail
User Bawolff changed the status of MediaWiki.r91435. Old Status: new New Status: fixme User Bawolff also posted a comment on MediaWiki.r91435. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91435#c19263 Commit summary: * Added getFileVersion()/setFileVersion() functions to

[MediaWiki-CodeReview] [MediaWiki r91556]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91556. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91556#c0 Commit summary: Codereview: Fix grammar of one i18n string ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r91549]: New comment added

2011-07-06 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r91549. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91549#c19264 Commit summary: CodeReview: Resolved is effectively the same as (or very similar to) OK; but the green background makes it standout unnecessarily. Coloring the same as

[MediaWiki-CodeReview] [MediaWiki r91491]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91491. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91491#c0 Commit summary: Localisation updates for core and extension messages from translatewiki.net (2011-07-05 21:00:00 UTC)

[MediaWiki-CodeReview] [MediaWiki r91430]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91430. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91430#c0 Commit summary: using proper margin heights: 14 + 68 * 2 = 150 ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r91426]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91426. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91426#c0 Commit summary: fixing rounding problem, per comment at r82309 ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r91419]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91419. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91419#c0 Commit summary: tests for Html::testExpandAttributes() FIXME: seems a code duplication of Xml::expandAttributes() follow up r81571 (skip

[MediaWiki-CodeReview] [MediaWiki r91270]: New comment added

2011-07-06 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r91270. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91270#c19265 Commit summary: Merge ApiTestSetup into ApiTestCase and update all subclasses. The amount of duplication here was nasty, and also lets us get rid of a bunch of useless

[MediaWiki-CodeReview] [MediaWiki r91561]: New comment added

2011-07-06 Thread MediaWiki Mail
User Bawolff posted a comment on MediaWiki.r91561. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91561#c19266 Commit summary: (Bug 19725) Do not include suppressed edits in the View X deleted edits message, and when doing prefix search of special:undelete. I'm not 100% sure

[MediaWiki-CodeReview] [MediaWiki r91565]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r91565. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91565#c0 Commit summary: public static ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91435]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91435. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91435#c0 Commit summary: * Added getFileVersion()/setFileVersion() functions to OutputPage * Removed getDisplayedFile() from FlaggedPage and

[MediaWiki-CodeReview] [MediaWiki r91558]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r91558. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91558#c0 Commit summary: Removed usage of error suppression operator ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r86056]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r86056. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86056#c0 Commit summary: Followup to r86047: Rewrite the radio-button updater move everything to action.history. Also move to fixCompare version

[MediaWiki-CodeReview] [MediaWiki r91547]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r91547. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91547#c0 Commit summary: Revert r86047 for now per CR. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r87271]: New comment added

2011-07-06 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r87271. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87271#c19267 Commit summary: AFT Fixes * Linking page titles in the Dashboard at Special:ArticleFeedback * (bug 28125) Don't load the ext.articleFeedback module, nor initialize it on

[MediaWiki-CodeReview] [MediaWiki r91537]: New comment added, and revision status changed

2011-07-06 Thread MediaWiki Mail
User Raymond changed the status of MediaWiki.r91537. Old Status: new New Status: fixme User Raymond also posted a comment on MediaWiki.r91537. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91537#c19268 Commit summary: v0.8.0a It is possible to interpretate poll results and

[MediaWiki-CodeReview] [Wikimedia r246]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User Awjrichards changed the status of Wikimedia.r246. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/246#c0 Commit summary: Stops logging the payflopro username and password (and the unit tests reflect this) and stops trying to reference a

[MediaWiki-CodeReview] [MediaWiki r91499]: New comment added

2011-07-06 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r91499. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91499#c19269 Commit summary: another fix for old jQuery UI on live Comment: Change (not to self): ''1'': * Prepends selectors: code.ui-button-text-icon-primary

[MediaWiki-CodeReview] [MediaWiki r91499]: New comment added

2011-07-06 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r91499. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91499#c19270 Commit summary: another fix for old jQuery UI on live Comment: Changed (note to self): ''1'': * Prepends selectors: code.ui-button-text-icon-primary

[MediaWiki-CodeReview] [MediaWiki r91444]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r91444. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91444#c0 Commit summary: follow-up r91439: Change option parse to parsemag (MediaWiki option in this context)

[MediaWiki-CodeReview] [MediaWiki r91507]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91507. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91507#c0 Commit summary: Added file wrapper class (tested) and R work for overworked ___

[MediaWiki-CodeReview] [MediaWiki r91578]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91578. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91578#c0 Commit summary: fixing parser test per r91573 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91579]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91579. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91579#c0 Commit summary: Removed unused function param ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91106]: New comment added

2011-07-06 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r91106. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91106#c19272 Commit summary: Add wfUnserialize() wrapper around unserialize to prevent E_NOTICE and use it in ExifBitmap.php. There are probably many more places that could use this.

[MediaWiki-CodeReview] [MediaWiki r91378]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91378. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91378#c0 Commit summary: enhance tests name (for --testdox option) ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91071]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91071. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91071#c0 Commit summary: Make BitmapMetadataHandlerTest incomplete if $wgShowEXIF is not set. It was throwing 'MWException: Internal error:

[MediaWiki-CodeReview] [MediaWiki r90016]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r90016. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90016#c0 Commit summary: Start on test cases for bug 6672 (Exif orientation support), follow up to r79845. Unfortunately seem to be hitting a wall

[MediaWiki-CodeReview] [MediaWiki r90194]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r90194. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90194#c0 Commit summary: Fixes for r90105, r90193: * Actually removed $wgProto. * Per Aryeh's suggestions on the future of $wgServer: made $wgServer

[MediaWiki-CodeReview] [MediaWiki r91106]: New comment added, and revision status changed

2011-07-06 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r91106. Old Status: new New Status: resolved User Brion VIBBER also posted a comment on MediaWiki.r91106. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91106#c19274 Commit summary: Add wfUnserialize() wrapper around unserialize

[MediaWiki-CodeReview] [MediaWiki r91512]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91512. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91512#c0 Commit summary: + _readme.txt ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91348]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91348. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91348#c0 Commit summary: Removed some dead code (useless since r87806) ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r90741]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r90741. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90741#c0 Commit summary: Fixed silly test bug ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91537]: New comment added

2011-07-06 Thread MediaWiki Mail
User QuestPC posted a comment on MediaWiki.r91537. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91537#c19276 Commit summary: v0.8.0a It is possible to interpretate poll results and store user ratings / marks - as educational tool or as psychological tests. Step towards HMVC

[MediaWiki-CodeReview] [MediaWiki r91584]: New comment added

2011-07-06 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r91584. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91584#c19277 Commit summary: * Call viewRedirect() on Article (WikiPage doesn't inherit this anymore) * Fixed bug 29734 - categories on redirect pages don't appear on stable

[MediaWiki-CodeReview] [MediaWiki r91537]: New comment added

2011-07-06 Thread MediaWiki Mail
User QuestPC posted a comment on MediaWiki.r91537. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91537#c19278 Commit summary: v0.8.0a It is possible to interpretate poll results and store user ratings / marks - as educational tool or as psychological tests. Step towards HMVC

[MediaWiki-CodeReview] [MediaWiki r91537]: New comment added, and revision status changed

2011-07-06 Thread MediaWiki Mail
User Raymond changed the status of MediaWiki.r91537. Old Status: fixme New Status: ok User Raymond also posted a comment on MediaWiki.r91537. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91537#c19280 Commit summary: v0.8.0a It is possible to interpretate poll results and

[MediaWiki-CodeReview] [MediaWiki r91439]: New comment added, and revision status changed

2011-07-06 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r91439. Old Status: deferred New Status: fixme User Krinkle also posted a comment on MediaWiki.r91439. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91439#c19281 Commit summary: Add PLURAL-support Comment: The Language.php is

[MediaWiki-CodeReview] [MediaWiki r91439]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r91439. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91439#c0 Commit summary: Add PLURAL-support ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91106]: New comment added

2011-07-06 Thread MediaWiki Mail
User Bawolff posted a comment on MediaWiki.r91106. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91106#c19282 Commit summary: Add wfUnserialize() wrapper around unserialize to prevent E_NOTICE and use it in ExifBitmap.php. There are probably many more places that could use

[MediaWiki-CodeReview] [MediaWiki r91106]: New comment added

2011-07-06 Thread MediaWiki Mail
User Bawolff posted a comment on MediaWiki.r91106. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91106#c19283 Commit summary: Add wfUnserialize() wrapper around unserialize to prevent E_NOTICE and use it in ExifBitmap.php. There are probably many more places that could use

[MediaWiki-CodeReview] [MediaWiki r91589]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91589. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91589#c0 Commit summary: Minor fixes and follow-up to r91439 (Integration of PLURAL / MediaWiki language classes) * Names.php - Deleting

[MediaWiki-CodeReview] [MediaWiki r91106]: New comment added

2011-07-06 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r91106. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91106#c19284 Commit summary: Add wfUnserialize() wrapper around unserialize to prevent E_NOTICE and use it in ExifBitmap.php. There are probably many more places that could use

[MediaWiki-CodeReview] [Wikimedia r198]: New comment added, and revision status changed

2011-07-06 Thread MediaWiki Mail
User Awjrichards changed the status of Wikimedia.r198. Old Status: fixme New Status: resolved User Awjrichards also posted a comment on Wikimedia.r198. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/198#c19286 Commit summary: Fixing my unit test, adding a config.ini-dist, and

[MediaWiki-CodeReview] [Wikimedia r204]: New comment added, and revision status changed

2011-07-06 Thread MediaWiki Mail
User Awjrichards changed the status of Wikimedia.r204. Old Status: fixme New Status: resolved User Awjrichards also posted a comment on Wikimedia.r204. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/204#c19287 Commit summary: Actually started communicating with pfp's test

[MediaWiki-CodeReview] [MediaWiki r85918]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r85918. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c0 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no

[MediaWiki-CodeReview] [MediaWiki r91466]: New comment added, and revision status changed

2011-07-06 Thread MediaWiki Mail
User NeilK changed the status of MediaWiki.r91466. Old Status: new New Status: ok User NeilK also posted a comment on MediaWiki.r91466. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91466#c19288 Commit summary: adjusting width of ArticleFeedback-tooltip container. -

[Wikitech-l] ResourceLoader JavaScript validation on trunk (bug 28626)

2011-07-06 Thread Brion Vibber
Some of you may have found that ResourceLoader's bundled minified JavaScript loads can be a bit frustrating when syntax errors creep into your JavaScript code -- not only are the line numbers reported in your browser of limited help, but a broken file can cause *all* JS modules loaded in the same

Re: [Wikitech-l] ResourceLoader JavaScript validation on trunk (bug 28626)

2011-07-06 Thread K. Peachey
How is JSMin+ different to the plain JSMin that we had and was removed due to licensing conflicts? (See: http://lists.wikimedia.org/pipermail/wikitech-l/2011-January/051308.html https://bugzilla.wikimedia.org/show_bug.cgi?id=26791) ___ Wikitech-l

[MediaWiki-CodeReview] [MediaWiki r91606]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r91606. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91606#c0 Commit summary: Fix trailing whitespace ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91608]: New comment added

2011-07-06 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r91608. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91608#c19289 Commit summary: * (bug 28626) Validate JavaScript files and pages loaded via ResourceLoader before minification, protecting separate modules from interference This

[MediaWiki-CodeReview] [MediaWiki r91613]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91613. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91613#c0 Commit summary: Adding directory and work for vandal_conversion ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r91598]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91598. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91598#c0 Commit summary: * Removed isPatrollable(); unused * Fixed comment ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r91557]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91557. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91557#c0 Commit summary: Revert r91426 and followups r91427, r91430: Breaks Gallery-related parser tests

[MediaWiki-CodeReview] [Wikimedia r259]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User Awjrichards changed the status of Wikimedia.r259. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/259#c0 Commit summary: Command-line wrapper should exit with an error if the processor execute returns false.

Re: [Wikitech-l] ResourceLoader JavaScript validation on trunk (bug 28626)

2011-07-06 Thread Brion Vibber
On Wed, Jul 6, 2011 at 3:18 PM, K. Peachey p858sn...@gmail.com wrote: How is JSMin+ different to the plain JSMin that we had and was removed due to licensing conflicts? It's a different program, written by different people, based on code from another unrelated project, under a different

[MediaWiki-CodeReview] [MediaWiki r91608]: New comment added

2011-07-06 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r91608. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91608#c19290 Commit summary: * (bug 28626) Validate JavaScript files and pages loaded via ResourceLoader before minification, protecting separate modules from interference

[MediaWiki-CodeReview] [MediaWiki r91617]: New comment added

2011-07-06 Thread MediaWiki Mail
User Kaldari posted a comment on MediaWiki.r91617. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91617#c19291 Commit summary: moving DB function into DB class and giving functions more logical names Comment: This rev also added banner assignment and weight logging to the

[MediaWiki-CodeReview] [MediaWiki r91619]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r91619. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91619#c0 Commit summary: (bug 23086) AbuseFilter config diff date and time should use user preference instead of UTC

[MediaWiki-CodeReview] [MediaWiki r91516]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91516. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91516#c0 Commit summary: Don't use an example query that gives a warning ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r91615]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91615. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91615#c0 Commit summary: * (bug 29481) Add German namespace names to LQT ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r91588]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r91588. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91588#c0 Commit summary: Removed stray ; ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r91597]: New comment added, and revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91597. Old Status: new New Status: fixme User ^demon also posted a comment on MediaWiki.r91597. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91597#c19292 Commit summary: Added sourcetracking sql file Comment: * We don't typically

Re: [Wikitech-l] ResourceLoader JavaScript validation on trunk (bug 28626)

2011-07-06 Thread Michael Dale
On 07/06/2011 03:04 PM, Brion Vibber wrote: Some of you may have found that ResourceLoader's bundled minified JavaScript loads can be a bit frustrating when syntax errors creep into your JavaScript code -- not only are the line numbers reported in your browser of limited help, but a broken

[MediaWiki-CodeReview] [MediaWiki r88628]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r88628. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88628#c0 Commit summary: Made $wgFlaggedRevsAutoconfirm a wrapper around $wgAutopromote ___

[MediaWiki-CodeReview] [MediaWiki r91293]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91293. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91293#c0 Commit summary: Better RTL interface support for CodeReview (bug 29658): paths and code diff should be LTR

[MediaWiki-CodeReview] [MediaWiki r91541]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91541. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91541#c0 Commit summary: Follow-up r91293, r91519: use wfUILang() for better backwards compatibility ___

[MediaWiki-CodeReview] [MediaWiki r91519]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91519. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91519#c0 Commit summary: (follow-up r91518; bug 29658 et al.) Improving RTL support for several extensions: AbuseFilter: aligning rules edit box as

[MediaWiki-CodeReview] [MediaWiki r82783]: New comment added

2011-07-06 Thread MediaWiki Mail
User Tim Starling posted a comment on MediaWiki.r82783. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82783#c19293 Commit summary: * (bug 24230) Added JAR detection. ZIP archives containing a .class file will be rejected by default. Malformed ZIP archives will be rejected due

[MediaWiki-CodeReview] [MediaWiki r82125]: Revision status changed

2011-07-06 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r82125. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82125#c0 Commit summary: fixes Bug #27381 Don't (un)expand headings on right click with attached patch

[MediaWiki-CodeReview] [MediaWiki r91618]: New comment added

2011-07-06 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r91618. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91618#c19295 Commit summary: Replace bullet-icon.png with an 8-bit version (became 24-bit due to r78011 which removed the color palette) * Fixes (bug 19514) Unordered list

  1   2   >