[MediaWiki-CodeReview] [Wikimedia r700]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r700. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/700 Commit summary: mingle analytics #236 - Live Results: Allow filtering of campaigns displayed added a small form to live results template

[MediaWiki-CodeReview] [MediaWiki r89405]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r89405. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89405 Commit summary: Deprecated wfGetAgent(), use $wgRequest-getHeader( 'User-Agent' ) instead

[MediaWiki-CodeReview] [Wikimedia r703]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r703. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/703 Commit summary: building the LML table outside of the template (this is a much more flexible approach)

[MediaWiki-CodeReview] [Wikimedia r704]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r704. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/704 Commit summary: fix the campaign index view filter processing ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [Wikimedia r705]: New comment added, and revision status changed

2011-11-03 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r705. Old Status: new New Status: fixme User Pgehres (WMF) also posted a comment on Wikimedia.r705. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/705#c25428 Commit summary: mingle anaytics # 237: Test Generation: capture all

Re: [Wikitech-l] Removed user agent-sniffing client-* classes from html

2011-11-03 Thread Brion Vibber
On Thu, Nov 3, 2011 at 12:23 PM, Brion Vibber br...@wikimedia.org wrote: In r101860 I've removed most of the client-* classes from the html that were added based on user-agent sniffing. Sniffing UA strings is a fragile practice which should be strongly discouraged in favor of checking for the

[MediaWiki-CodeReview] [MediaWiki r101834]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r101834. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101834 Commit summary: Quick ugly fix to avoid duplicate log entries in rc feed. I didn't think that save() would send lines, since there was

[MediaWiki-CodeReview] [MediaWiki r101791]: New comment added

2011-11-03 Thread MediaWiki Mail
User Jsoby posted a comment on MediaWiki.r101791. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101791#c25429 Commit summary: essage=Adding two more messages, from the hub on Meta. Will add the translations we have for them tomorrow. Comment: No, it is a message parameter.

[MediaWiki-CodeReview] [MediaWiki r101833]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r101833. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101833 Commit summary: let us force thumb rendering even if previous file exist The new FORCE_RENDER flag should always be used with

[MediaWiki-CodeReview] [MediaWiki r101835]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r101835. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101835 Commit summary: Force thumb rendering! Since the [[Special:VipsTest]] is used to test the vips scaler, we want to make sure the thumb

[MediaWiki-CodeReview] [MediaWiki r101836]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r101836. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101836 Commit summary: Followup r101834 - this time tested ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101834]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r101834. Old Status: ok New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101834 Commit summary: Quick ugly fix to avoid duplicate log entries in rc feed. I didn't think that save() would send lines, since there

[MediaWiki-CodeReview] [MediaWiki r101829]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r101829. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101829 Commit summary: add \n to a wfDebug() call follow up r48417 ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r92109]: New comment added, and revision status changed

2011-11-03 Thread MediaWiki Mail
User MarkAHershberger changed the status of MediaWiki.r92109. Old Status: fixme New Status: ok User MarkAHershberger also posted a comment on MediaWiki.r92109. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92109#c25430 Commit summary: (bug 29558) Add config var to disable

[MediaWiki-CodeReview] [MediaWiki r101867]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r101867. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101867 Commit summary: *grumble grumble* know it alls think I'm abusing $wgMiserMode. So fine, have a SHINY NEW GLOBAL INSTEAD. bug

[MediaWiki-CodeReview] [MediaWiki r101869]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r101869. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101869 Commit summary: Whoops, need a ! ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101810]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r101810. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101810 Commit summary: SpecialPage permission is now vipsscaler-test By default, everyone is allowed to use Special:VipsTest

[MediaWiki-CodeReview] [MediaWiki r101825]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r101825. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101825 Commit summary: add description for vipsscaler-test user right follow up r101810 ___

[MediaWiki-CodeReview] [MediaWiki r101797]: New comment added, and revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r101797. Old Status: new New Status: ok User Aaron Schulz also posted a comment on MediaWiki.r101797. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101797#c25431 Commit summary: VipsScaler: basic README file Comment: Easy to

[MediaWiki-CodeReview] [MediaWiki r96716]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r96716. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96716 Commit summary: Refactor deferrable updates into classes interfaces, also add helper method for the most common use case:

[MediaWiki-CodeReview] [MediaWiki r96718]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r96718. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96718 Commit summary: Moved global define into class constant, replaced a bunch of $fname with __METHOD__.

[MediaWiki-CodeReview] [MediaWiki r96578]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r96578. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96578 Commit summary: Tweaks to LoggedUpdateMaintenance: * Reduce some duplication * Prefix skipped steps with ... per updater convention *

[MediaWiki-CodeReview] [MediaWiki r96336]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r96336. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96336 Commit summary: Merge ParserTestStaticParserHook into ParserTestParserHook since they practically do the same thing.

Re: [Wikitech-l] Removed user agent-sniffing client-* classes from html

2011-11-03 Thread Krinkle
On Thu, Nov 3, 2011 at 8:42 PM, Brion Vibber br...@wikimedia.org wrote: On Thu, Nov 3, 2011 at 12:23 PM, Brion Vibber br...@wikimedia.org wrote: In r101860 I've removed most of the client-* classes from the html that were added based on user-agent sniffing. Sniffing UA strings is a fragile

[MediaWiki-CodeReview] [MediaWiki r101177]: New comment added, and revision status changed

2011-11-03 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r101177. Old Status: fixme New Status: new User Reedy also posted a comment on MediaWiki.r101177. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101177#c25432 Commit summary: Followup r101161 having array() doesn't work so well with

[MediaWiki-CodeReview] [MediaWiki r101873]: New comment added, and revision status changed

2011-11-03 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101873. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r101873. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101873#c25433 Commit summary: Register special page alias file (r101809) for

[MediaWiki-CodeReview] [MediaWiki r101881]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101881. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101881 Commit summary: Consistency updates. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101833]: New comment added

2011-11-03 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r101833. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101833#c25434 Commit summary: let us force thumb rendering even if previous file exist The new FORCE_RENDER flag should always be used with FORCE_NOW. It let us override the

Re: [Wikitech-l] The sprint to the Tarball begins

2011-11-03 Thread DJ Bauch
I don't have a manifestation of this bug, but somebody working on the installer should look at WebInstaller.php, lines 640 and 641, which both assign to the $html variable. They can't both be right. In effect, 640 does nothing. In older revisions, the line $html = $this-parse( $text, true); was

[MediaWiki-CodeReview] [MediaWiki r101801]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r101801. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101801 Commit summary: Per comments in r101477, changed all (not) null to (NOT) NULL for consistency.

[MediaWiki-CodeReview] [MediaWiki r100126]: New comment added, and revision status changed

2011-11-03 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r100126. Old Status: ok New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r100126. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100126#c25435 Commit summary: Add documentation Fix some unused variables,

Re: [Wikitech-l] The sprint to the Tarball begins

2011-11-03 Thread Brion Vibber
On Thu, Nov 3, 2011 at 2:08 PM, DJ Bauch dj.ba...@gmail.com wrote: I don't have a manifestation of this bug, but somebody working on the installer should look at WebInstaller.php, lines 640 and 641, which both assign to the $html variable. They can't both be right. In effect, 640 does

[MediaWiki-CodeReview] [MediaWiki r86603]: New comment added

2011-11-03 Thread MediaWiki Mail
User DieBuche posted a comment on MediaWiki.r86603. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86603#c25436 Commit summary: Move edit.js stuff to mediawiki.action.edit.js, and remove wikibits dependency. Wrap publicly accessible functions inside mw.toolbar provide legacy

Re: [Wikitech-l] Native HTTPS support live on all projects

2011-11-03 Thread Brion Vibber
On Sat, Oct 8, 2011 at 3:58 AM, Roan Kattouw roan.katt...@gmail.com wrote: On Sat, Oct 8, 2011 at 11:38 AM, William Allen Simpson william.allen.simp...@gmail.com wrote: As a user of HTTPS Everywhere ever since it was announced, I look forward to the improved rulesets. Apparently, my

Re: [Wikitech-l] Native HTTPS support live on all projects

2011-11-03 Thread Daniel Friesen
On Thu, 03 Nov 2011 14:35:47 -0700, Brion Vibber br...@pobox.com wrote: On Sat, Oct 8, 2011 at 3:58 AM, Roan Kattouw roan.katt...@gmail.com wrote: On Sat, Oct 8, 2011 at 11:38 AM, William Allen Simpson william.allen.simp...@gmail.com wrote: As a user of HTTPS Everywhere ever since it was

Re: [Wikitech-l] Native HTTPS support live on all projects

2011-11-03 Thread Brion Vibber
On Thu, Nov 3, 2011 at 2:41 PM, Daniel Friesen li...@nadir-seen-fire.comwrote: On Thu, 03 Nov 2011 14:35:47 -0700, Brion Vibber br...@pobox.com wrote: Any update on this? I just did a fresh install of HTTPS Everywhere and it's still using the https://secure.wikimedia.org/ rules. HTTPS

[MediaWiki-CodeReview] [MediaWiki r101878]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101878. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101878 Commit summary: Fix: The squid log caching and the sessions were fighting eachother. Now, they should play nice long with eachother

[MediaWiki-CodeReview] [Wikimedia r708]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r708. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/708 Commit summary: re: mingle analytics #236 - Allow filtering of campaigns displayed adding sql modification to commit

[MediaWiki-CodeReview] [Wikimedia r710]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r710. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/710 Commit summary: re: fixme on r705 http://www.mediawiki.org/wiki/Special:Code/Wikimedia/705#c25428 escaped campaign parameter

Re: [Wikitech-l] Native HTTPS support live on all projects

2011-11-03 Thread Roan Kattouw
On Thu, Nov 3, 2011 at 10:43 PM, Brion Vibber br...@pobox.com wrote: I can confirm the development version of the ext has the updated https://*. wikipedia.org/ rules (but have the issues with all domains been worked out yet there?) Not really. I've been asking for a list of all

[MediaWiki-CodeReview] [Wikimedia r705]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r705. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/705 Commit summary: mingle anaytics # 237: Test Generation: capture all test results in summary tables Fixed data reporting in the

[MediaWiki-CodeReview] [MediaWiki r101816]: New comment added

2011-11-03 Thread MediaWiki Mail
User Amire80 posted a comment on MediaWiki.r101816. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101816#c25437 Commit summary: Display workflow status in Special:MessageGroupStats if enabled Internationalization/#187 Internationalization/#189 Comment: Why Html::openElement(

[MediaWiki-CodeReview] [MediaWiki r101666]: New comment added

2011-11-03 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r101666. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101666#c25438 Commit summary: * (bug 32126) Fix 1.18 regression in watchlist editor when items already removed from watchlist Overriding validation in HTMLForm bits so the

[MediaWiki-CodeReview] [MediaWiki r96343]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r96343. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96343 Commit summary: Small MonoBook cleanup: * Eliminate the unnecessary -skin and $skin, $this-skin is only used in one spot and we

[MediaWiki-CodeReview] [MediaWiki r101816]: New comment added

2011-11-03 Thread MediaWiki Mail
User Dantman posted a comment on MediaWiki.r101816. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101816#c25439 Commit summary: Display workflow status in Special:MessageGroupStats if enabled Internationalization/#187 Internationalization/#189 Comment: 1.16 compat holdover?

[MediaWiki-CodeReview] [MediaWiki r96250]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r96250. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96250 Commit summary: Split ajaxCategories away from core for now, into an extension: * Move js/css/images from core into extension dir (kept

[MediaWiki-CodeReview] [MediaWiki r101835]: New comment added, and revision status changed

2011-11-03 Thread MediaWiki Mail
User Bryan changed the status of MediaWiki.r101835. Old Status: ok New Status: fixme User Bryan also posted a comment on MediaWiki.r101835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101835#c25440 Commit summary: Force thumb rendering! Since the [[Special:VipsTest]] is

[MediaWiki-CodeReview] [MediaWiki r96281]: New comment added

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r96281. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96281#c25441 Commit summary: Pass the key for the skin being created to the constructor of a skin. This is just something that's been bothering me for awhile, without this it's

[MediaWiki-CodeReview] [MediaWiki r101810]: New comment added

2011-11-03 Thread MediaWiki Mail
User Bryan posted a comment on MediaWiki.r101810. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101810#c25442 Commit summary: SpecialPage permission is now vipsscaler-test By default, everyone is allowed to use Special:VipsTest Comment: Why does this need to be restricted?

[MediaWiki-CodeReview] [MediaWiki r101860]: New comment added

2011-11-03 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r101860. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101860#c25443 Commit summary: bug 32183: remove the client-* classes added from user-agent-sniffing onto the html element. Browser sniffing is bad, and having these here

[MediaWiki-CodeReview] [MediaWiki r101477]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r101477. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101477 Commit summary: Table for message group states Internationalization/#173 ___

[MediaWiki-CodeReview] [MediaWiki r101607]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r101607. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101607 Commit summary: Followup r101477 - we obviously need also language code ___

Re: [Wikitech-l] 1.18beta tarball triage Friday

2011-11-03 Thread Platonides
Mark A. Hershberger wrote: What: 1.18 tarball Triage When: Friday, November 4, 2011, 21:00UTC (17:00PDT) Where: #wikimedia-dev on irc.freenode.net See also: http://www.mediawiki.org/wiki/Bug_management/Triage Since we plan on having a beta tarball out for 1.18 tomorrow

[MediaWiki-CodeReview] [MediaWiki r96280]: New comment added

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r96280. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96280#c25444 Commit summary: Add a new RequestContext::newExtraneousContext() to create a context filled with data not derived from the current session. Also modify setLang to

[MediaWiki-CodeReview] [MediaWiki r101563]: New comment added, and revision status changed

2011-11-03 Thread MediaWiki Mail
User Kaldari changed the status of MediaWiki.r101563. Old Status: ok New Status: fixme User Kaldari also posted a comment on MediaWiki.r101563. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101563#c25445 Commit summary: adding 54 new accepted currencies and 21 more pending

[MediaWiki-CodeReview] [MediaWiki r96015]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r96015. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96015 Commit summary: Pass OutputPage instance to MakeGlobalVariablesScript. Allows extensions to getTitle()-equals( .. ) and add config

[MediaWiki-CodeReview] [MediaWiki r96281]: New comment added

2011-11-03 Thread MediaWiki Mail
User Dantman posted a comment on MediaWiki.r96281. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96281#c25447 Commit summary: Pass the key for the skin being created to the constructor of a skin. This is just something that's been bothering me for awhile, without this it's hard

[MediaWiki-CodeReview] [MediaWiki r96280]: New comment added

2011-11-03 Thread MediaWiki Mail
User Dantman posted a comment on MediaWiki.r96280. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96280#c25448 Commit summary: Add a new RequestContext::newExtraneousContext() to create a context filled with data not derived from the current session. Also modify setLang to

[MediaWiki-CodeReview] [MediaWiki r100366]: New comment added

2011-11-03 Thread MediaWiki Mail
User Peachey88 posted a comment on MediaWiki.r100366. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100366#c25449 Commit summary: Also bundle ConfirmEdit, Gadgets, Nuke, RenameUser and WikiEditor Comment: I know there is a bug open about Nuke and Portegsql, Rename user would

[MediaWiki-CodeReview] [MediaWiki r83909]: New comment added, and revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r83909. Old Status: new New Status: resolved User Aaron Schulz also posted a comment on MediaWiki.r83909. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83909#c25451 Commit summary: Complete the trinity of blocking frontend

[MediaWiki-CodeReview] [MediaWiki r101563]: New comment added

2011-11-03 Thread MediaWiki Mail
User Kaldari posted a comment on MediaWiki.r101563. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101563#c25452 Commit summary: adding 54 new accepted currencies and 21 more pending ones to start translation Comment: UTU is also not a currency, should be UYU.

[MediaWiki-CodeReview] [MediaWiki r84765]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r84765. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84765 Commit summary: (bug 28070) Fix watchlist RSS for databases that store timestamps in a real timestamp field by using

[MediaWiki-CodeReview] [MediaWiki r84534]: New comment added, and revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r84534. Old Status: fixme New Status: resolved User Aaron Schulz also posted a comment on MediaWiki.r84534. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84534#c25454 Commit summary: (hopefully) last bit of heavy lifting in

[MediaWiki-CodeReview] [MediaWiki r101901]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r101901. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101901 Commit summary: Fix casing of Renameuser Add Vector ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101767]: New comment added

2011-11-03 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r101767. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101767#c25455 Commit summary: Address fixme on r101606, should also call from $this Comment: Why would it need to have the $this pointer? (reversing your query) As it isn't

[MediaWiki-CodeReview] [MediaWiki r96280]: New comment added

2011-11-03 Thread MediaWiki Mail
User Dantman posted a comment on MediaWiki.r96280. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96280#c25456 Commit summary: Add a new RequestContext::newExtraneousContext() to create a context filled with data not derived from the current session. Also modify setLang to

[MediaWiki-CodeReview] [MediaWiki r101767]: New comment added

2011-11-03 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r101767. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101767#c25457 Commit summary: Address fixme on r101606, should also call from $this Comment: Six of one, half a dozen of another. We can change it to static if it's bothering

[MediaWiki-CodeReview] [MediaWiki r96280]: New comment added

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r96280. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96280#c25458 Commit summary: Add a new RequestContext::newExtraneousContext() to create a context filled with data not derived from the current session. Also modify setLang to

Re: [Wikitech-l] Upcoming VipsScaler deployment

2011-11-03 Thread Platonides
MZMcBride wrote: For example, we currently disallow PNG images greater than 12.5 MP. Are you sure about this? I recall a configurable 12.5 MP limit on rendering of JPGs, but does that also apply to PNGs? And disallow is a bit ambiguous here. They just won't render / have thumbnails created,

[MediaWiki-CodeReview] [MediaWiki r86786]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r86786. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86786 Commit summary: * Fixes Bug #27860 - Minor edit after clicking 'new section' tab Patch from Jan Paul Posma of which he writes:

[MediaWiki-CodeReview] [MediaWiki r101630]: New comment added, and revision status changed

2011-11-03 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r101630. Old Status: new New Status: fixme User Platonides also posted a comment on MediaWiki.r101630. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101630#c25459 Commit summary: * Made PermissionsError exception accept an

[MediaWiki-CodeReview] [MediaWiki r101791]: New comment added

2011-11-03 Thread MediaWiki Mail
User Awjrichards posted a comment on MediaWiki.r101791. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101791#c25460 Commit summary: essage=Adding two more messages, from the hub on Meta. Will add the translations we have for them tomorrow. Comment: Perfect. That will make

Re: [Wikitech-l] Native HTTPS support live on all projects

2011-11-03 Thread Antoine Musso
On 03/11/11 22:47, Roan Kattouw wrote: Not really. I've been asking for a list of all non-HTTPS-enabled .wm.o domains so I can complete the exemptions list, but it hasn't been produced so far. Maybe it will be 'easier' to convert those domains to HTTPS? :-) -- Antoine hashar Musso

[MediaWiki-CodeReview] [MediaWiki r101907]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r101907. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101907 Commit summary: Add REL1_18_0beta1 tag folder ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101906]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r101906. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101906 Commit summary: space makes things unhappy ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101563]: New comment added, and revision status changed

2011-11-03 Thread MediaWiki Mail
User Kaldari changed the status of MediaWiki.r101563. Old Status: fixme New Status: new User Kaldari also posted a comment on MediaWiki.r101563. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101563#c25461 Commit summary: adding 54 new accepted currencies and 21 more pending

[MediaWiki-CodeReview] [MediaWiki r101308]: New comment added, and revision status changed

2011-11-03 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r101308. Old Status: new New Status: fixme User Krinkle also posted a comment on MediaWiki.r101308. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101308#c25462 Commit summary: Add plural support for messages download-info,

[MediaWiki-CodeReview] [MediaWiki r101308]: New comment added, and revision status changed

2011-11-03 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r101308. Old Status: fixme New Status: ok User Krinkle also posted a comment on MediaWiki.r101308. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101308#c25463 Commit summary: Add plural support for messages download-info,

[MediaWiki-CodeReview] [MediaWiki r100817]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r100817. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100817 Commit summary: distict-monuments message ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100117]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r100117. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100117 Commit summary: Add gallery-header-place and ccaa-heading messages. ___

[MediaWiki-CodeReview] [MediaWiki r100118]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r100118. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100118 Commit summary: Caption link to the new tool ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] FOSDEM 2012

2011-11-03 Thread Alolita Sharma
FOSDEM is an excellent conference for outreach, recruitment and awareness. I plan to submit a talk. Alolita On Thu, Nov 3, 2011 at 3:54 PM, Arthur Richards aricha...@wikimedia.orgwrote: Has there been any consideration about having a WMF booth at FOSDEM this year? Last year it seemed like it

[MediaWiki-CodeReview] [MediaWiki r100250]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r100250. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100250 Commit summary: Added column comarque, joined with province one. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r100384]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r100384. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100384 Commit summary: Messages for the new option=removed ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101852]: New comment added, and revision status changed

2011-11-03 Thread MediaWiki Mail
User Khorn (WMF) changed the status of MediaWiki.r101852. Old Status: new New Status: fixme User Khorn (WMF) also posted a comment on MediaWiki.r101852. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101852#c25465 Commit summary: Refactoring webitects forms to share common css

[MediaWiki-CodeReview] [MediaWiki r96999]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r96999. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96999 Commit summary: Followup r96978, clean up code duplication by factoring out the code building load.php requests into

[MediaWiki-CodeReview] [MediaWiki r101308]: New comment added

2011-11-03 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r101308. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101308#c25466 Commit summary: Add plural support for messages download-info, scaling-width and scaling-height as requested in

[MediaWiki-CodeReview] [MediaWiki r101852]: New comment added

2011-11-03 Thread MediaWiki Mail
User Pgehres (WMF) posted a comment on MediaWiki.r101852. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101852#c25467 Commit summary: Refactoring webitects forms to share common css and js between pfp and gc gateways. Comment: Sorry about that.

[MediaWiki-CodeReview] [MediaWiki r101852]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of MediaWiki.r101852. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101852 Commit summary: Refactoring webitects forms to share common css and js between pfp and gc gateways.

[MediaWiki-CodeReview] [MediaWiki r100234]: New comment added

2011-11-03 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r100234. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100234#c25468 Commit summary: Guess the language from Accept-Language header. Comment: What do you mean by Sandbox? And how do you expect to demo it? When people with no

[MediaWiki-CodeReview] [MediaWiki r101924]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Johnduhart changed the status of MediaWiki.r101924. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101924 Commit summary: Importing nodejs debian package ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] Quick compat check: updates to default xmlns in API XML output

2011-11-03 Thread Daniel Friesen
On Thu, 03 Nov 2011 16:24:39 -0700, Brion Vibber br...@wikimedia.org wrote: r88077 [1] added a default XML namespace (xmlns attribute on the root node) for the API's XML output. In r99135 [2] this was partially backed out to avoid clobbering some modules that specified their own XML

[Wikitech-l] Coding Challenge Final Weekend: please help if you can

2011-11-03 Thread Greg DeKoenigsberg
The last weekend of the October 2011 Code Challenge is upon us. It's going to be a big weekend for those coders who want to do well, and we're encouraging them to visit wikitech-l and the #mediawiki IRC channel, so please take a special interest in helping this weekend. Many of these questions

[MediaWiki-CodeReview] [MediaWiki r101933]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User SPQRobin changed the status of MediaWiki.r101933. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101933 Commit summary: Add Central Dusun language code to RELEASE-NOTES-1.18 ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r101549]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101549. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101549 Commit summary: Splitting CSS out of webitects_2_3step, wrapped with table for IE6, typos, etc

[MediaWiki-CodeReview] [MediaWiki r101929]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101929. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101929 Commit summary: Adding webitects_2_3step-CA for pfp and gc, also FU to r101917 ___

[MediaWiki-CodeReview] [MediaWiki r101917]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101917. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101917 Commit summary: Fixing references to webitects_2_3step.ie6, FU r101852 ___

[MediaWiki-CodeReview] [MediaWiki r101852]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101852. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101852 Commit summary: Refactoring webitects forms to share common css and js between pfp and gc gateways.

[MediaWiki-CodeReview] [MediaWiki r96930]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r96930. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96930 Commit summary: Revert r87992 and followups r87998, r89028 (Support abstraction for 'NOT IN' SQL structure). Per discussion on CR

[MediaWiki-CodeReview] [MediaWiki r96978]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r96978. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96978 Commit summary: Fix the fixme on r88053: dependency handling was broken in debug mode in certain cases. More specifically, if A is

<    1   2   3   >