[Wikitech-l] jenkins: unit test whitelist

2012-12-19 Thread Antoine Musso
Hello, As you surely have noticed, the unit tests for mediawiki/core are no more run when a patch is submitted. I have just enabled a feature that whitelist people to have unit tests run for them on patch submission. The patch still need to be reviewed and approved with a CR+2 though.

Re: [Wikitech-l] jenkins: unit test whitelist

2012-12-19 Thread Denny Vrandečić
Just curious -- I probably missed it in a previous mail -- why are the tests switched off? To preserve processing power? To speed up tests for the whitelisted? Security concerns when running tests with arbitrary code? Other? Cheers, Denny 2012/12/19 Antoine Musso hashar+...@free.fr Hello,

[Wikitech-l] How to speed up the review in gerrit?

2012-12-19 Thread vitalif
Hello! 28 SEPTEMBER I've pushed minor changes to the gerrit, to the Drafts extensions. Since then I've corrected two of them (uploaded patch set 2), but after that, nobody did the review. As I understand, Gerrit will abandon changes after a month of inactivity, and it will come tomorrow...

Re: [Wikitech-l] How to speed up the review in gerrit?

2012-12-19 Thread Matma Rex
You could add people as reviewers, or personally ask someone to review, prefereably someone who worked on the extension in the past. -- Matma Rex ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org

Re: [Wikitech-l] (Roughly) 2 week delay for MediaWiki 1.21wmf7

2012-12-19 Thread Denny Vrandečić
This looks very well for us. Just one thing: Phase 4 of 1.21wmf7 should probably be Monday, January 14, not January 11. Cheers, Denny 2012/12/17 Rob Lanphier ro...@wikimedia.org Hi everyone, Because a number of people are planning to take time off for the holidays, I'd like to postpone the

Re: [Wikitech-l] How to speed up the review in gerrit?

2012-12-19 Thread Antoine Musso
Le 19/12/12 11:57, vita...@yourcmc.ru wrote: Hello! 28 SEPTEMBER I've pushed minor changes to the gerrit, to the Drafts extensions. Since then I've corrected two of them (uploaded patch set 2), but after that, nobody did the review. As I understand, Gerrit will abandon changes after a

Re: [Wikitech-l] How to speed up the review in gerrit?

2012-12-19 Thread vitalif
Matma Rex писал 2012-12-19 15:01: You could add people as reviewers, or personally ask someone to review, prefereably someone who worked on the extension in the past. Okay, I've just done it... So, do you mean all committers just add random reviewers when they see no reaction?

Re: [Wikitech-l] How to speed up the review in gerrit?

2012-12-19 Thread vitalif
Antoine Musso писал 2012-12-19 16:19: Le 19/12/12 11:57, vita...@yourcmc.ru wrote: Hello! 28 SEPTEMBER I've pushed minor changes to the gerrit, to the Drafts extensions. Since then I've corrected two of them (uploaded patch set 2), but after that, nobody did the review. As I understand, Gerrit

[Wikitech-l] jenkins: PHPUnit upgraded to 3.7.10

2012-12-19 Thread Antoine Musso
Hello, I have upgraded PHPUnit 3.7.10 on pour Jenkins installation. It already ran a full test suite of mediawiki/core without any trouble. If you get any trouble with it, please open a bug under Wikimedia Testing Infrastructure. For reference the bug requesting upgrade was:

Re: [Wikitech-l] How to speed up the review in gerrit?

2012-12-19 Thread Sumana Harihareswara
On 12/19/2012 07:24 AM, vita...@yourcmc.ru wrote: Antoine Musso писал 2012-12-19 16:19: Le 19/12/12 11:57, vita...@yourcmc.ru wrote: Hello! 28 SEPTEMBER I've pushed minor changes to the gerrit, to the Drafts extensions. Since then I've corrected two of them (uploaded patch set 2), but

Re: [Wikitech-l] How to speed up the review in gerrit?

2012-12-19 Thread Tyler Romeo
I've had patchsets that I submitted in August and they still haven't been merged. For example, the account creation API, which has actually been approved, but never merged. *--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com |

[Wikitech-l] Clarification on unit tests requiring CR+2

2012-12-19 Thread Krinkle
Hello, We would like to clarify the reason we changed Jenkins to no longer run unit tests on patch submission. We had to defer code execution to after CR+2 for security reasons. If unit tests were ran on submission that meant anyone with a labs account could effectively get shell access on the

Re: [Wikitech-l] Small tweak to Gerrit Verified category - tomorrow

2012-12-19 Thread Krinkle
On Dec 18, 2012, at 6:01 AM, Liangent liang...@gmail.com wrote: On Tue, Dec 18, 2012 at 12:45 PM, Chad innocentkil...@gmail.com wrote: Linting jobs will receive Verified ±1 votes. Unit tests jobs (triggered after someone votes CR+2, as it currently is) will receive Verified ±2 votes.

Re: [Wikitech-l] Clarification on unit tests requiring CR+2

2012-12-19 Thread Tyler Romeo
Sounds good to me. IMHO, if you're submitting a patch and haven't already run unit tests on that patch, you're probably doing something wrong. I've done that a few times myself, and could have avoided unnecessary patchset submissions if I had done so. *--* *Tyler Romeo* Stevens Institute of

Re: [Wikitech-l] Clarification on unit tests requiring CR+2

2012-12-19 Thread Erik Moeller
On Wed, Dec 19, 2012 at 11:48 AM, Krinkle krinklem...@gmail.com wrote: Hello, We would like to clarify the reason we changed Jenkins to no longer run unit tests on patch submission. Thanks for this update. Also, cross-referencing Antoine's post on the interim whitelist solution for

Re: [Wikitech-l] How to speed up the review in gerrit?

2012-12-19 Thread Matthew Flaschen
On 12/19/2012 02:41 PM, Tyler Romeo wrote: I've had patchsets that I submitted in August and they still haven't been merged. For example, the account creation API, which has actually been approved, but never merged. Which one are you referring to, https://gerrit.wikimedia.org/r/#/c/18127/ ?

Re: [Wikitech-l] How to speed up the review in gerrit?

2012-12-19 Thread Matma Rex
On Wed, 19 Dec 2012 22:55:24 +0100, Matthew Flaschen mflasc...@wikimedia.org wrote: On a simpler note, why does it have your name as Parent5446? https://gerrit.wikimedia.org/r/#/dashboard/278 Can someone fix this? There's a bug for that: https://bugzilla.wikimedia.org/show_bug.cgi?id=40061

Re: [Wikitech-l] How to speed up the review in gerrit?

2012-12-19 Thread Tyler Romeo
Yep, that patch. If you notice, patches 8, 16, 18, 20, and 21 have all been approved, i.e., +2 on CR. But it's yet to have been merged. At the very least, its dependency has been merged. I'm not in a humongous rush or anything, I'm just pointing out that sometimes you really just have to wait it

Re: [Wikitech-l] How to speed up the review in gerrit?

2012-12-19 Thread Matthew Flaschen
On 12/19/2012 05:06 PM, Tyler Romeo wrote: Yep, that patch. If you notice, patches 8, 16, 18, 20, and 21 have all been approved, i.e., +2 on CR. But it's yet to have been merged. At the very least, its dependency has been merged. I'm not in a humongous rush or anything, I'm just pointing out

Re: [Wikitech-l] How to speed up the review in gerrit?

2012-12-19 Thread Matthew Flaschen
On 12/19/2012 04:58 PM, Matma Rex wrote: On Wed, 19 Dec 2012 22:55:24 +0100, Matthew Flaschen mflasc...@wikimedia.org wrote: On a simpler note, why does it have your name as Parent5446? https://gerrit.wikimedia.org/r/#/dashboard/278 Can someone fix this? There's a bug for that:

Re: [Wikitech-l] How to speed up the review in gerrit?

2012-12-19 Thread Tyler Romeo
Lol yes. Parent5446 is my actual username, although it is not my name in real life. :P *--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerro...@gmail.com On Wed, Dec 19, 2012 at 5:15 PM, Matthew Flaschen

Re: [Wikitech-l] Clarification on unit tests requiring CR+2

2012-12-19 Thread Platonides
On 19/12/12 20:48, Krinkle wrote: This issue will be definitely solved by isolating tests in dedicated virtual machines for each run. We are investigating Vagrant. A VM seems overkill when it can be solved with standard user permissions + chroot (or even better, a bsd jail)

[Wikitech-l] Follow / like MediaWiki @ social media

2012-12-19 Thread Quim Gil
It's not completely sorted out but there has been a big progress in just a couple of days: https://www.mediawiki.org/wiki/Social_media Summary: follow like MediaWiki in your social networks to read promote MediaWiki Wikimedia tech news. * http://identi.ca/mediawiki *

Re: [Wikitech-l] Clarification on unit tests requiring CR+2

2012-12-19 Thread Tim Landscheidt
(anonymous) wrote: This issue will be definitely solved by isolating tests in dedicated virtual machines for each run. We are investigating Vagrant. A VM seems overkill when it can be solved with standard user permissions + chroot (or even better, a bsd jail) With chroot you also have to

[Wikitech-l] Secure Coding Documentation

2012-12-19 Thread Chris Steipp
Hi Everyone, I'd like to invite anyone interested to join in on a secure coding documentation sprint on Friday of this week (Dec 21st), from 11:30am - 12:30pm PST (19:30-20:30 UTC). If you're interested in joining, but can't make that specific time, let me know and we may hold more of these if

[Wikitech-l] Demo for Concise Wikipedia proposal

2012-12-19 Thread Waldir Pimenta
Hi all, Since the Concise Wikipedia proposal[1] has been mentioned in the last two Signpost editions[2][3] (and after being nudged by Sumana), I figured I'd drop a note here in case anyone will be interested in trying out a demo I set up to explore the idea, espoused by many in the proposal

Re: [Wikitech-l] Demo for Concise Wikipedia proposal

2012-12-19 Thread Antoine Musso
Le 20/12/12 05:15, Waldir Pimenta a écrit : I called my demo Primerpedia (suggestions for better names welcome, see [4]), and it can be accessed here: http://waldir.github.com/primerpedia I love it! I am a [[Special:random]] addict and offering only the first paragraph will let me get more