Re: [Wikitech-l] Automatic gerrit authentication and retrieval of reviews

2016-10-30 Thread Strainu
Hi, After extensive discussions with my fellow organizers, we decided to go with an oauth consumer on wikitech, and I submitted a new consumer. It would be great if Bryan or another Oauth admin could take a look at it (we're waaay overdue with that already). Thank you, Strainu 2016-10-22

Re: [Wikitech-l] Automatic gerrit authentication and retrieval of reviews

2016-10-22 Thread Strainu
Thank you all for your suggestions. I'll discuss with the people who implemented the original application and decide on the best approach given the limited resources and time. Strainu 2016-10-22 3:23 GMT+03:00 Gergo Tisza : > On Fri, Oct 21, 2016 at 3:38 PM, Strainu

Re: [Wikitech-l] Automatic gerrit authentication and retrieval of reviews

2016-10-21 Thread Gergo Tisza
On Fri, Oct 21, 2016 at 3:38 PM, Strainu wrote: > I'm simply trying to make it easy for the users. In the current > version of the tool, they login with the github account and the rest > happens "magically": the tool retrieves their pull requests and scores > them according

Re: [Wikitech-l] Automatic gerrit authentication and retrieval of reviews

2016-10-21 Thread Alex Monk
Me and Bryan have been discussing this. There might be a hacky way to map SUL accounts to LDAP accounts - Phabricator allows users to login via LDAP as you'd expect, but it also allows OAuth against Wikimedia SUL accounts. Therefore the mapping can exist there, where users have set it up. You'd

Re: [Wikitech-l] Automatic gerrit authentication and retrieval of reviews

2016-10-21 Thread Bryan Davis
On Fri, Oct 21, 2016 at 4:38 PM, Strainu wrote: > 2016-10-22 1:16 GMT+03:00 Gergo Tisza : >> Are you worried that the users >> are going to give positive reviews to themselves to bias the scores? > > Authentication is used only to ensure they don't claim

Re: [Wikitech-l] Automatic gerrit authentication and retrieval of reviews

2016-10-21 Thread Strainu
2016-10-22 1:16 GMT+03:00 Gergo Tisza : > Are you worried that the users > are going to give positive reviews to themselves to bias the scores? Authentication is used only to ensure they don't claim somebody else's submissions (say, Gerrit Patch Uploader's :) ). Yes, this

Re: [Wikitech-l] Automatic gerrit authentication and retrieval of reviews

2016-10-21 Thread Gergo Tisza
On Fri, Oct 21, 2016 at 2:13 AM, Strainu wrote: > The real issue is how to match the user in the tool with the reviews > without user intervention. Any ideas or advice are appreciated, but > here are my thoughts on the issue: > Can you better explain what you are after? Are

Re: [Wikitech-l] Automatic gerrit authentication and retrieval of reviews

2016-10-21 Thread Strainu
2016-10-21 19:03 GMT+03:00 Alex Monk : > On 21 October 2016 at 10:13, Strainu wrote: > >> 1. Gerrit does not seem to support oauth authentication. I vaguely >> remember that the gerrit account used to be linked to the mw.org >> account. Is there any way I

Re: [Wikitech-l] Automatic gerrit authentication and retrieval of reviews

2016-10-21 Thread Alex Monk
On 21 October 2016 at 10:13, Strainu wrote: > 1. Gerrit does not seem to support oauth authentication. I vaguely > remember that the gerrit account used to be linked to the mw.org > account. Is there any way I could use the mw.org auth to retrieve the > gerrit account and/or

Re: [Wikitech-l] Automatic gerrit authentication and retrieval of reviews

2016-10-21 Thread Marielle Volz
Yes, that would mean there would be no information from gerrit. including information about unmerged reviews. In that case it is probably less than ideal :). On Fri, Oct 21, 2016 at 3:54 PM, Strainu wrote: > 2016-10-21 16:08 GMT+03:00 Marielle Volz : >

Re: [Wikitech-l] Automatic gerrit authentication and retrieval of reviews

2016-10-21 Thread Strainu
2016-10-21 16:08 GMT+03:00 Marielle Volz : > You can add multiple e-mails both to gerrit [0] and github [1]. As long as > the e-mail address you are making commits with is added to both accounts, > you can likely use your preexisting software directly on the mirrored > github

Re: [Wikitech-l] Automatic gerrit authentication and retrieval of reviews

2016-10-21 Thread Marielle Volz
You can add multiple e-mails both to gerrit [0] and github [1]. As long as the e-mail address you are making commits with is added to both accounts, you can likely use your preexisting software directly on the mirrored github repos[2]. For example, my contributions to the citoid repo, all of which

[Wikitech-l] Automatic gerrit authentication and retrieval of reviews

2016-10-21 Thread Strainu
Hi everyone, I'm organizing a contest for people in Romania willing to contribute to Wikimedia code. [1] In order to automatically grade the contributions, we're using a tool already developed be our partners, ROSEdu, which reviews changes made on github [2][3]. The current (github-based)