Re: [Wikitech-l] Implementation JSON based localisation format for MediaWiki nearly completed

2014-04-03 Thread Justin Folvarcik
Just a question: Are the messages still able to be accessed like they were before, or will new methods be introduced to gather them and decode the JSON? On Wed, Apr 2, 2014 at 6:02 PM, Derk-Jan Hartman d.j.hartman+wmf...@gmail.com wrote: On 2 apr. 2014, at 20:22, Ryan Kaldari

Re: [Wikitech-l] Implementation JSON based localisation format for MediaWiki nearly completed

2014-04-03 Thread Niklas Laxström
2014-04-03 16:53 GMT+03:00 Justin Folvarcik jfolvar...@gmail.com: Just a question: Are the messages still able to be accessed like they were before, or will new methods be introduced to gather them and decode the JSON? There are no visible changes for developers using the messages api:

Re: [Wikitech-l] Implementation JSON based localisation format for MediaWiki nearly completed

2014-04-03 Thread Justin Folvarcik
Good to know, thanks. On Thu, Apr 3, 2014 at 10:07 AM, Niklas Laxström niklas.laxst...@gmail.comwrote: 2014-04-03 16:53 GMT+03:00 Justin Folvarcik jfolvar...@gmail.com: Just a question: Are the messages still able to be accessed like they were before, or will new methods be introduced to

Re: [Wikitech-l] Implementation JSON based localisation format for MediaWiki nearly completed

2014-04-02 Thread Brad Jorsch (Anomie)
On Tue, Apr 1, 2014 at 11:59 PM, Brian Wolff bawo...@gmail.com wrote: use tabs for indentation instead of spaces to be like the rest of mediawiki? I was going to say the same thing. Why wasn't that caught in code review? If these files continue to use spaces, I'd expect people will write

Re: [Wikitech-l] Implementation JSON based localisation format for MediaWiki nearly completed

2014-04-02 Thread Niklas Laxström
use tabs for indentation instead of spaces to be like the rest of mediawiki? I was going to say the same thing. Why wasn't that caught in code review? Spaces were chosen because that is what we get with FormatJson::encode and there is no way to change it except by post-processing. I'm fine

Re: [Wikitech-l] Implementation JSON based localisation format for MediaWiki nearly completed

2014-04-02 Thread Thomas Gries
Am 02.04.2014 15:45, schrieb Brad Jorsch (Anomie): On Tue, Apr 1, 2014 at 11:59 PM, Brian Wolff bawo...@gmail.com wrote: use tabs for indentation instead of spaces to be like the rest of mediawiki? I was going to say the same thing. Why wasn't that caught in code review? If these files

Re: [Wikitech-l] Implementation JSON based localisation format for MediaWiki nearly completed

2014-04-02 Thread Ryan Kaldari
On Wed, Apr 2, 2014 at 6:45 AM, Brad Jorsch (Anomie) bjor...@wikimedia.orgwrote: On Tue, Apr 1, 2014 at 11:59 PM, Brian Wolff bawo...@gmail.com wrote: use tabs for indentation instead of spaces to be like the rest of mediawiki? I was going to say the same thing. Why wasn't that caught

Re: [Wikitech-l] Implementation JSON based localisation format for MediaWiki nearly completed

2014-04-02 Thread Alolita Sharma
Hi Ryan, Is there a bug open on this request (using tabs instead of spaces). Please share when you can :-) Best, Alolita Alolita Sharma आलोलिता शर्मा Director of Engineering Internationalization Localization Wikimedia Foundation On Wed, Apr 2, 2014 at 11:22 AM, Ryan Kaldari

Re: [Wikitech-l] Implementation JSON based localisation format for MediaWiki nearly completed

2014-04-02 Thread Rob Lanphier
On Tue, Apr 1, 2014 at 3:09 PM, Siebrand Mazeland siebr...@kitano.nlwrote: With the merging of https://gerrit.wikimedia.org/r/#/c/122787/ , probably the largest patch set for MediaWiki ever (+548314, -714438), MediaWiki core is now using JSON for localisation of interface messages, per a

Re: [Wikitech-l] Implementation JSON based localisation format for MediaWiki nearly completed

2014-04-02 Thread Siebrand Mazeland
On Wed, Apr 2, 2014 at 8:41 PM, Rob Lanphier ro...@wikimedia.org wrote: On Tue, Apr 1, 2014 at 3:09 PM, Siebrand Mazeland siebr...@kitano.nl wrote: With the merging of https://gerrit.wikimedia.org/r/#/c/122787/ , probably the largest patch set for MediaWiki ever (+548314, -714438),

Re: [Wikitech-l] Implementation JSON based localisation format for MediaWiki nearly completed

2014-04-02 Thread Ryan Kaldari
Opened a bug here for the tabs: https://bugzilla.wikimedia.org/show_bug.cgi?id=63444 Otherwise, I'm glad to hear the migration is nearly complete. This should give us a lot more capabilities on the client-side. Great work on this effort! Ryan Kaldari On Wed, Apr 2, 2014 at 11:32 AM, Alolita

Re: [Wikitech-l] Implementation JSON based localisation format for MediaWiki nearly completed

2014-04-02 Thread Alolita Sharma
Thanks Ryan :-) Best, Alolita Alolita Sharma आलोलिता शर्मा Director of Engineering Internationalization Localization Wikimedia Foundation On Wed, Apr 2, 2014 at 12:44 PM, Ryan Kaldari rkald...@wikimedia.orgwrote: Opened a bug here for the tabs:

Re: [Wikitech-l] Implementation JSON based localisation format for MediaWiki nearly completed

2014-04-02 Thread Derk-Jan Hartman
On 2 apr. 2014, at 20:22, Ryan Kaldari rkald...@wikimedia.org wrote: On Wed, Apr 2, 2014 at 6:45 AM, Brad Jorsch (Anomie) bjor...@wikimedia.orgwrote: On Tue, Apr 1, 2014 at 11:59 PM, Brian Wolff bawo...@gmail.com wrote: use tabs for indentation instead of spaces to be like the rest of

Re: [Wikitech-l] Implementation JSON based localisation format for MediaWiki nearly completed

2014-04-01 Thread Brian Wolff
Cool. Thanks for all the work you put into this. Once all migrations are complete, I'll be doing a full export from translatewiki.net, which will cause a lot of JSON files to be touched, but will mostly update encoding (full UTF-8) and add a newline at enf of file where missing. If the

Re: [Wikitech-l] Implementation JSON based localisation format for MediaWiki nearly completed

2014-04-01 Thread Jon Robson
This is epic. Thanks a bunch Siebrand! On 1 Apr 2014 15:10, Siebrand Mazeland siebr...@kitano.nl wrote: Long! tl;dr is in the first two paragraphs. With the merging of https://gerrit.wikimedia.org/r/#/c/122787/ , probably the largest patch set for MediaWiki ever (+548314, -714438), MediaWiki

Re: [Wikitech-l] Implementation JSON based localisation format for MediaWiki nearly completed

2014-04-01 Thread Erik Moeller
On Tue, Apr 1, 2014 at 9:22 PM, Jon Robson jdlrob...@gmail.com wrote: This is epic. Thanks a bunch Siebrand! Agreed - really exciting to see this come to fruition! :) Kudos to Siebrand everyone involved. I'm sure there will be bumps along the road but it's clearly a bit architectural step