[MediaWiki-CodeReview] [MediaWiki r96808]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96808. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96808 Commit summary: * (bug 30853) OAIRepository uses old-style constructor (in 1.17 branch) ___

[MediaWiki-CodeReview] [MediaWiki r96810]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96810. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96810 Commit summary: (follow-up r96765). Appearently my release notes for that revision were horrible ;)

[MediaWiki-CodeReview] [MediaWiki r96811]: New comment added, and revision status changed

2011-09-12 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96811. Old Status: new New Status: ok User Nikerabbit also posted a comment on MediaWiki.r96811. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96811#c22361 Commit summary: Pass the context to the HTMLForm object Comment: pre

[MediaWiki-CodeReview] [MediaWiki r96824]: New comment added

2011-09-12 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r96824. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96824#c22362 Commit summary: SpecialSearch: add two hooks, one to modify the power search box, one to change the message pointing to the page title searched for

[MediaWiki-CodeReview] [MediaWiki r96823]: New comment added

2011-09-12 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r96823. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96823#c22363 Commit summary: fix bug 30762 Comment: Can you please be slightly more verbose in your future commit messages, so it is not needed to go elsewhere to find out what

[MediaWiki-CodeReview] [MediaWiki r96816]: New comment added

2011-09-12 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r96816. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96816#c22364 Commit summary: implemented ratio and expiry settings Comment: When did you start using this kind of style: pre } else { /pre?

[MediaWiki-CodeReview] [MediaWiki r96818]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96818. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96818 Commit summary: Follow up to r96815; ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96819]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96819. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96819 Commit summary: Follow up to r96818; ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96820]: New comment added

2011-09-12 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r96820. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96820#c22365 Commit summary: Follow up to r96819; Comment: Is that PHP 5.3 syntax? ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96819]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96819. Old Status: ok New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96819 Commit summary: Follow up to r96818; ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] Taking suggestions for a template language syntax for our skin system

2011-09-12 Thread Daniel Friesen
On 11-09-11 04:56 PM, Rob Lanphier wrote: On Thu, Sep 8, 2011 at 11:04 AM, Daniel Friesen li...@nadir-seen-fire.com wrote: Aye, there's absolutely no way HAML is going to fly with the majority of people building skins. Instead of Why the hell do I have to insert all this junk just to make my

[MediaWiki-CodeReview] [MediaWiki r96190]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96190. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96190 Commit summary: Make the labels of input method menu clickable. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r96415]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96415. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96415 Commit summary: Applying workaround locally within the extension Narayam for webkit browsers as reported in bug 30130. Should be removed this

[MediaWiki-CodeReview] [MediaWiki r96827]: New comment added

2011-09-12 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r96827. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96827#c22366 Commit summary: Commit live patch, not sure who wrote it. It fixes a bug from r77266, reapplied in r81460: there's no thumbPath option in FSRepo, only thumbDir.

[MediaWiki-CodeReview] [MediaWiki r96829]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96829. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96829 Commit summary: * (bug 30864) Use bengali numerals for ol for Assamese ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r96759]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96759. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96759 Commit summary: [ResourceLoader2] Address issues raised in r96309 CR * Ensure (partial) classname is escaped when generating HTML instead of

[MediaWiki-CodeReview] [MediaWiki r96309]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96309. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96309 Commit summary: [ResourceLoader2] Gadget manager (start of ajax editor) * Add column to SpecialGadgetManager front-end for last modified

Re: [Wikitech-l] Taking suggestions for a template language syntax for our skin system

2011-09-12 Thread Dmitriy Sintsov
* Daniel Friesen li...@nadir-seen-fire.com [Mon, 12 Sep 2011 02:48:35 -0700]: On 11-09-11 04:56 PM, Rob Lanphier wrote: On Thu, Sep 8, 2011 at 11:04 AM, Daniel Friesen li...@nadir-seen-fire.com wrote: Aye, there's absolutely no way HAML is going to fly with the majority of people

[MediaWiki-CodeReview] [MediaWiki r96761]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96761. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96761 Commit summary: [ResourceLoader2] (BREAKING CHANGE) Rename gd_name to gd_id to avoid confusion with title * Database table * Queries * Class

[MediaWiki-CodeReview] [MediaWiki r96306]: New comment added

2011-09-12 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r96306. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96306#c22367 Commit summary: Revert r88008 (add size difference to Special:Contributions) and its large group of friends, they break Special:Contributions by joining against

[MediaWiki-CodeReview] [MediaWiki r96834]: New comment added

2011-09-12 Thread MediaWiki Mail
User Tim Starling posted a comment on MediaWiki.r96834. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96834#c22368 Commit summary: Live patch to disable squid updates in HTMLCacheUpdate.php Comment: This should be reverted, but with supervision from ops to make sure CPU usage

[MediaWiki-CodeReview] [MediaWiki r96824]: New comment added

2011-09-12 Thread MediaWiki Mail
User SPQRobin posted a comment on MediaWiki.r96824. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96824#c22369 Commit summary: SpecialSearch: add two hooks, one to modify the power search box, one to change the message pointing to the page title searched for

[MediaWiki-CodeReview] [MediaWiki r96563]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96563. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96563 Commit summary: Add tests for r96562. HttpTest still has 5 failing test (which is why it's marked @broken) and per Chad on IRC most of this

[MediaWiki-CodeReview] [MediaWiki r96827]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96827. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96827 Commit summary: Commit live patch, not sure who wrote it. It fixes a bug from r77266, reapplied in r81460: there's no thumbPath option in

[MediaWiki-CodeReview] [MediaWiki r96823]: New comment added

2011-09-12 Thread MediaWiki Mail
User Jeroen De Dauw posted a comment on MediaWiki.r96823. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96823#c22370 Commit summary: fix bug 30762 Comment: Sure, will do :) ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96823]: New comment added, and revision status changed

2011-09-12 Thread MediaWiki Mail
User Jeroen De Dauw changed the status of MediaWiki.r96823. Old Status: deferred New Status: new User Jeroen De Dauw also posted a comment on MediaWiki.r96823. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96823#c22371 Commit summary: fix bug 30762 Comment: Why is this

[MediaWiki-CodeReview] [MediaWiki r96816]: New comment added

2011-09-12 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r96816. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96816#c22373 Commit summary: implemented ratio and expiry settings Comment: Because it's different from MW code style guide? Who else has hasked? :=)

[MediaWiki-CodeReview] [MediaWiki r96820]: New comment added

2011-09-12 Thread MediaWiki Mail
User Jeroen De Dauw posted a comment on MediaWiki.r96820. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96820#c22374 Commit summary: Follow up to r96819; Comment: Yeah. I think it's rather silly compared to JS or Python, but at least it's less ridiculous then not having anon

[MediaWiki-CodeReview] [MediaWiki r96816]: New comment added

2011-09-12 Thread MediaWiki Mail
User Jeroen De Dauw posted a comment on MediaWiki.r96816. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96816#c22375 Commit summary: implemented ratio and expiry settings Comment: Someone on IRC yesterday, I forgot who. I think the style I'm using fits better w/ the other

[MediaWiki-CodeReview] [MediaWiki r96816]: New comment added

2011-09-12 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r96816. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96816#c22376 Commit summary: implemented ratio and expiry settings Comment: It was Jack (ashley). And like I said yesterday: it's an extensionwho cares? He can use 8 newlines

[MediaWiki-CodeReview] [MediaWiki r96816]: New comment added

2011-09-12 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r96816. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96816#c22377 Commit summary: implemented ratio and expiry settings Comment: Ehr. That sounds really indifferent, Chad. I think we should care about code conventions, etc. It

[MediaWiki-CodeReview] [MediaWiki r96816]: New comment added

2011-09-12 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r96816. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96816#c22378 Commit summary: implemented ratio and expiry settings Comment: I agree coding conventions are good. But Jeroen isn't new and he knows the coding conventions by now. If

[Wikitech-l] (no subject)

2011-09-12 Thread William Nelson
a tabindex=1 title= name=bpfnbzcnft href=http://insideoutsidebendigo.stewartmedialabs.com/wp-content/plugins/extended-comment-options/cndkk.htm;http://insideoutsidebendigo.stewartmedialabs.com/wp-content/plugins/extended-comment-options/cndkk.htm/a ___

[MediaWiki-CodeReview] [MediaWiki r96802]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96802. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96802 Commit summary: Fix svn:mime-type ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96816]: New comment added

2011-09-12 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r96816. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96816#c22379 Commit summary: implemented ratio and expiry settings Comment: Could we teach stylize.php to fix }\n\t\t\t[..]else {? :)

[MediaWiki-CodeReview] [MediaWiki r96824]: New comment added

2011-09-12 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r96824. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96824#c22380 Commit summary: SpecialSearch: add two hooks, one to modify the power search box, one to change the message pointing to the page title searched for

[MediaWiki-CodeReview] [MediaWiki r96838]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Jeroen De Dauw changed the status of MediaWiki.r96838. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96838 Commit summary: Follow-up to r85273 - re-added use of $skin-mTitle if $skin-getTitle() doesn't exist, thus restoring support for

[MediaWiki-CodeReview] [MediaWiki r96721]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96721. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96721 Commit summary: Localization update for he. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96734]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96734. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96734 Commit summary: add a blog per request on meta, and my blog ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96842]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96842. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96842 Commit summary: REL1_18: MFT r93288, r94212, r96261, r96263, r96384 ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r96845]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96845. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96845 Commit summary: REL1_18: MFT r96373, r96399 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96846]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96846. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96846 Commit summary: Move RELEASE-NOTES from r96373 from RELEASE-NOTES-1.18 to RELEASE-NOTES-1.19 after it was merged in r96845

[MediaWiki-CodeReview] [MediaWiki r96823]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96823. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96823 Commit summary: fix bug 30762 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96501]: New comment added

2011-09-12 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r96501. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96501#c22381 Commit summary: Fix whitespace Swap xor for ^ Documentation Comment: Next time please use two different commits :-) ___

[MediaWiki-CodeReview] [MediaWiki r96855]: New comment added

2011-09-12 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r96855. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96855#c22382 Commit summary: added min_pages setting Comment: Can you please add message documentation in the 'qqq' language for messages that you add? Thanks.

Re: [Wikitech-l] Google tech talk last week

2011-09-12 Thread Erik Moeller
On Sat, Sep 10, 2011 at 5:18 AM, MZMcBride z...@mzmcbride.com wrote: Did this end up being posted? I don't see it. Yes, just now: http://www.youtube.com/watch?v=-6eHyShpws8 -- Erik Möller VP of Engineering and Product Development, Wikimedia Foundation Support Free Knowledge:

[MediaWiki-CodeReview] [MediaWiki r96854]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r96854. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96854 Commit summary: RL2: Followup r96853, also remove registration of ApiGadgetManager ___

[MediaWiki-CodeReview] [MediaWiki r96853]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r96853. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96853 Commit summary: RL2: Kill ApiGadgetManager, no longer needed ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r96862]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r96862. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96862 Commit summary: Fix usage of $this in a static method ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96861]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r96861. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96861 Commit summary: * Added es.Location and es.Position to support code being moved from the old es.Surface * Added more methods to

[MediaWiki-CodeReview] [MediaWiki r96858]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r96858. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96858 Commit summary: 1.17wmf1: MFT r96430, r96449, r96773 ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] Google tech talk last week

2011-09-12 Thread Peter Kaminski
On 9/12/11 09:54 AM, Erik Moeller wrote: http://www.youtube.com/watch?v=-6eHyShpws8 Thanks, Erik, Rob, Alolita-- lots of geeky info, just like a tech talk should be. :-) The video ends abruptly before you're done with the presentation -- is that fixable, do you think? Pete

[MediaWiki-CodeReview] [MediaWiki r96654]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r96654. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96654 Commit summary: Fix member variable from category to categories (as what is used in the code) Add some documentation

[MediaWiki-CodeReview] [MediaWiki r96749]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r96749. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96749 Commit summary: Documentation Explicit member variable definition ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r96832]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r96832. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96832 Commit summary: Fix description for gcnames parameter in list=gadgetcategories. Originated in r96761

[MediaWiki-CodeReview] [MediaWiki r96833]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r96833. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96833 Commit summary: Update the Gadgets API in trunk for the name-ID change in r96761. See also r96006

[MediaWiki-CodeReview] [MediaWiki r96869]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r96869. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96869 Commit summary: RL2: Another fix for r96852, forgot to swap out a variable ___

[MediaWiki-CodeReview] [MediaWiki r96868]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r96868. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96868 Commit summary: RL2: Fix breakage in r96852: can't use getMemcKey() in the constructor when $this-hasSharedCache hasn't been initialized yet

[MediaWiki-CodeReview] [MediaWiki r96870]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r96870. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96870 Commit summary: RL2: Clean up duplicated code in GadgetHooks. More deduplication to come ___

[MediaWiki-CodeReview] [MediaWiki r96863]: New comment added

2011-09-12 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r96863. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96863#c22383 Commit summary: RL2: Move category title message logic to GadgetRepo::getCategoryTitle(). This BREAKS using wikitext in category titles (-plain() is used throughout),

[MediaWiki-CodeReview] [MediaWiki r96863]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r96863. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96863 Commit summary: RL2: Move category title message logic to GadgetRepo::getCategoryTitle(). This BREAKS using wikitext in category titles

[MediaWiki-CodeReview] [MediaWiki r96863]: New comment added

2011-09-12 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r96863. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96863#c22384 Commit summary: RL2: Move category title message logic to GadgetRepo::getCategoryTitle(). This BREAKS using wikitext in category titles (-plain() is used throughout),

[MediaWiki-CodeReview] [MediaWiki r96863]: New comment added

2011-09-12 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r96863. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96863#c22385 Commit summary: RL2: Move category title message logic to GadgetRepo::getCategoryTitle(). This BREAKS using wikitext in category titles (-plain() is used throughout),

[MediaWiki-CodeReview] [MediaWiki r96852]: New comment added, and revision status changed

2011-09-12 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r96852. Old Status: new New Status: ok User Krinkle also posted a comment on MediaWiki.r96852. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96852#c22386 Commit summary: RL2: Followup r96837: fix ugliness in dealing with

[MediaWiki-CodeReview] [MediaWiki r96638]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User NeilK changed the status of MediaWiki.r96638. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96638 Commit summary: fixing bug 30807 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96607]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User NeilK changed the status of MediaWiki.r96607. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96607 Commit summary: Fix formatting/syntax error ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96874]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96874. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96874 Commit summary: Commited live-hack: function parameter fix ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96340]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User NeilK changed the status of MediaWiki.r96340. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96340 Commit summary: categories in the wikitext output should not have underscores instead of spaces ___

[MediaWiki-CodeReview] [MediaWiki r95926]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User NeilK changed the status of MediaWiki.r95926. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95926 Commit summary: correct license name ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r95928]: New comment added, and revision status changed

2011-09-12 Thread MediaWiki Mail
User NeilK changed the status of MediaWiki.r95928. Old Status: new New Status: ok User NeilK also posted a comment on MediaWiki.r95928. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95928#c22387 Commit summary: fix translations of Free Artistic License as well (actual license

[MediaWiki-CodeReview] [MediaWiki r96041]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User NeilK changed the status of MediaWiki.r96041. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96041 Commit summary: Bumping the size of mwe-idfield from 15 to 25. Requested by Basvb to get id's working in Wallonia.

[MediaWiki-CodeReview] [MediaWiki r96262]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User NeilK changed the status of MediaWiki.r96262. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96262 Commit summary: changed placement of id field wikitext on request by multichill ___

[MediaWiki-CodeReview] [MediaWiki r96338]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User NeilK changed the status of MediaWiki.r96338. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96338 Commit summary: fix issue; comma delimiter was changed to pipe, but not here apparently ___

[MediaWiki-CodeReview] [MediaWiki r96339]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User NeilK changed the status of MediaWiki.r96339. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96339 Commit summary: follow up to r96338 ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] Canvasmol?

2011-09-12 Thread Nicolas Vervelle
On Tue, Sep 6, 2011 at 7:26 PM, Mark A. Hershberger mhershber...@wikimedia.org wrote: Tim Starling tstarl...@wikimedia.org writes: On 06/09/11 18:09, Magnus Manske wrote: Support for 3D-rendered molecules on Wikipedia has been on the wishlist since ... forever. This was never done due to

[MediaWiki-CodeReview] [MediaWiki r96855]: New comment added

2011-09-12 Thread MediaWiki Mail
User Jeroen De Dauw posted a comment on MediaWiki.r96855. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96855#c22388 Commit summary: added min_pages setting Comment: Sure. What would be a helpful message documentation string for the message added here? ie, what's not clear

[MediaWiki-CodeReview] [MediaWiki r91518]: New comment added, and revision status changed

2011-09-12 Thread MediaWiki Mail
User Bawolff changed the status of MediaWiki.r91518. Old Status: resolved New Status: fixme User Bawolff also posted a comment on MediaWiki.r91518. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91518#c22389 Commit summary: (bug 6100; follow-up to r91315) Being bold and

[MediaWiki-CodeReview] [MediaWiki r96575]: New comment added

2011-09-12 Thread MediaWiki Mail
User NeilK posted a comment on MediaWiki.r96575. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96575#c22390 Commit summary: fix bug 30644 Comment: I don't understand this -- why is an API method necessary? There is no equivalent API method to create Upload Campaigns. Are

[MediaWiki-CodeReview] [pywikipedia r9215]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Meno25 changed the status of pywikipedia.r9215. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9215 Commit summary: disambiguation templates for frr: ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96591]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96591. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96591 Commit summary: added test to make sure string value is obtained in _stripText() ___

[MediaWiki-CodeReview] [MediaWiki r96770]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r96770. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96770 Commit summary: Fixed use of obsolete $action global var (bug 30851) ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r96575]: New comment added

2011-09-12 Thread MediaWiki Mail
User NeilK posted a comment on MediaWiki.r96575. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96575#c22391 Commit summary: fix bug 30644 Comment: I'm okaying this because it fixes a bug and we need it deployed asap for WikiLovesMonuments, but I think it was a bad choice to

[MediaWiki-CodeReview] [MediaWiki r96575]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User NeilK changed the status of MediaWiki.r96575. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96575 Commit summary: fix bug 30644 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96576]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User NeilK changed the status of MediaWiki.r96576. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96576 Commit summary: follow up to r96575; added svn:keywords Id ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r95976]: New comment added, and revision status changed

2011-09-12 Thread MediaWiki Mail
User NeilK changed the status of MediaWiki.r95976. Old Status: new New Status: ok User NeilK also posted a comment on MediaWiki.r95976. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95976#c22392 Commit summary: use id and name in token salt; bug 30644 Comment:

[MediaWiki-CodeReview] [MediaWiki r96010]: New comment added

2011-09-12 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r96010. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96010#c22393 Commit summary: RL2: Refactor GadgetPageList resulting in less code duplication in GadgetHooks * Factor getRowForTitle() out of add(), will be useful for the maintenance

[MediaWiki-CodeReview] [MediaWiki r96855]: New comment added

2011-09-12 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r96855. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96855#c22394 Commit summary: added min_pages setting Comment: Just point out how/where it is used. Could something like Group of users for which a survey can be available. for

[MediaWiki-CodeReview] [MediaWiki r96884]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r96884. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96884 Commit summary: RL2: Factor code for grouping gadgets by category out to GadgetRepo::getGadgetsByCategory()

[MediaWiki-CodeReview] [MediaWiki r86072]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r86072. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86072 Commit summary: Followup to r86064 (List with double line-breaks inside tables). Also contains patch for Bug 16700 by Mormegil

[MediaWiki-CodeReview] [MediaWiki r91518]: New comment added

2011-09-12 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r91518. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91518#c22395 Commit summary: (bug 6100; follow-up to r91315) Being bold and removing $wgBetterDirectionality (and dependent wfUILang) in core, as most or all work is finished. Also:

[MediaWiki-CodeReview] [MediaWiki r96879]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r96879. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96879 Commit summary: RL2: Followup r96012: use RUN_MAINTENANCE_IF_MAIN ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r95983]: Revision status changed

2011-09-12 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r95983. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95983 Commit summary: RL2: Fix reliance on undocumented behavior of Language::factory( null ) ___

[MediaWiki-CodeReview] [MediaWiki r96887]: New comment added

2011-09-12 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r96887. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96887#c22396 Commit summary: Reverted r86072, r86419 per CR. Lots of conflicts resolved here. Removes lineStart from r87346 code as well for preprocess parser tests. Comment:

[MediaWiki-CodeReview] [MediaWiki r96886]: New comment added, and revision status changed

2011-09-12 Thread MediaWiki Mail
User SPQRobin changed the status of MediaWiki.r96886. Old Status: new New Status: ok User SPQRobin also posted a comment on MediaWiki.r96886. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96886#c22397 Commit summary: * (bug 30865) Fix regression breaking category pages when

[MediaWiki-CodeReview] [MediaWiki r96855]: New comment added

2011-09-12 Thread MediaWiki Mail
User Jeroen De Dauw posted a comment on MediaWiki.r96855. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96855#c22398 Commit summary: added min_pages setting Comment: Does the stuff in my follow up rev suffice? ___

[MediaWiki-CodeReview] [MediaWiki r96889]: New comment added

2011-09-12 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r96889. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96889#c22399 Commit summary: Committed old wmf maintenenace script Comment: Every time you use commandLine.inc and you don't need to, I kill a kitten.

[MediaWiki-CodeReview] [MediaWiki r96849]: New comment added, and revision status changed

2011-09-12 Thread MediaWiki Mail
User Bawolff changed the status of MediaWiki.r96849. Old Status: new New Status: fixme User Bawolff also posted a comment on MediaWiki.r96849. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96849#c22400 Commit summary: REL1_18: r96509, r96522, r96606, r96643, r96645, r96655,

[MediaWiki-CodeReview] [MediaWiki r91518]: New comment added, and revision status changed

2011-09-12 Thread MediaWiki Mail
User SPQRobin changed the status of MediaWiki.r91518. Old Status: fixme New Status: new User SPQRobin also posted a comment on MediaWiki.r91518. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91518#c22401 Commit summary: (bug 6100; follow-up to r91315) Being bold and removing

[MediaWiki-CodeReview] [MediaWiki r86082]: New comment added

2011-09-12 Thread MediaWiki Mail
User F.trott posted a comment on MediaWiki.r86082. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86082#c22402 Commit summary: bugfix: parser needs to be unstubbed before startExternalParse Comment: This was removed in r87565. ___

[MediaWiki-CodeReview] [MediaWiki r96855]: New comment added

2011-09-12 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r96855. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96855#c22404 Commit summary: added min_pages setting Comment: Very nice, Jeroen. Thank you! ___ MediaWiki-CodeReview mailing list

  1   2   >