Re: [Wikitech-l] not directly related to MediaWiki, but perhaps to our WYSIWYG editor activities: LibreOffice _Online_ Prototype announced (Libre Office in a web browser)

2011-10-17 Thread Neil Kandalgaonkar
Thanks for the heads-up -- it was interesting, but it doesn't seem like a useful strategy for us. I kind of doubt it's all that useful for GTK, actually. This would be equivalent to having every person who is editing a wiki page VNC'ing into some GTK application. I haven't done the math but

[MediaWiki-CodeReview] [MediaWiki r100016]: New comment added

2011-10-17 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r100016. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100016#c24399 Commit summary: Run some filter IDs through formatNum() for better l10n Comment: Iirc there is an open bugzilla for this, and it is assigned to a novice developer.

[MediaWiki-CodeReview] [MediaWiki r100016]: New comment added

2011-10-17 Thread MediaWiki Mail
User Raymond posted a comment on MediaWiki.r100016. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100016#c24400 Commit summary: Run some filter IDs through formatNum() for better l10n Comment: Bug 30729. Sorry, I was not aware of this bug. It was not my intention to steal an

[MediaWiki-CodeReview] [MediaWiki r94171]: New comment added

2011-10-17 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r94171. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94171#c24401 Commit summary: (bug 30219) NoLocalSettings.php broken on Windows servers. Per Tim on r70711, can't use pathinfo() on url's since the slashes don't match. Comment:

[MediaWiki-CodeReview] [MediaWiki r100023]: New comment added, and revision status changed

2011-10-17 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r100023. Old Status: new New Status: ok User Nikerabbit also posted a comment on MediaWiki.r100023. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100023#c24403 Commit summary: Bug 29357: CategoryTree should have built-in

[MediaWiki-CodeReview] [MediaWiki r99351]: New comment added

2011-10-17 Thread MediaWiki Mail
User Werdna posted a comment on MediaWiki.r99351. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99351#c24404 Commit summary: svn add DashboardForms.php Comment: Fixed in r100025. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r99350]: New comment added

2011-10-17 Thread MediaWiki Mail
User Werdna posted a comment on MediaWiki.r99350. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99350#c24405 Commit summary: MoodBar: Implement hiding and restoring of entries on the feedback dashboard. No AJAX for now, but everything is abstracted enough to implement it easily

[MediaWiki-CodeReview] [MediaWiki r99200]: New comment added

2011-10-17 Thread MediaWiki Mail
User Werdna posted a comment on MediaWiki.r99200. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99200#c24406 Commit summary: MoodBar feedback dashboard: Implement a means to hide individual comments. For now, does *not* include actual implementations of the forms to actually

[MediaWiki-CodeReview] [MediaWiki r93720]: New comment added

2011-10-17 Thread MediaWiki Mail
User BotInc posted a comment on MediaWiki.r93720. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93720#c24408 Commit summary: Extend upload api adding an option to upload files in chunks, using UploadStash to track the unfinished upload. Comment: does this need a new database

[MediaWiki-CodeReview] [MediaWiki r100028]: New comment added

2011-10-17 Thread MediaWiki Mail
User SVG posted a comment on MediaWiki.r100028. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100028#c24409 Commit summary: Add new extension to translatewiki (r99887) Comment: Could you add GlobalUserGroups extension, too? Thanks.

[MediaWiki-CodeReview] [MediaWiki r99481]: New comment added

2011-10-17 Thread MediaWiki Mail
User Raymond posted a comment on MediaWiki.r99481. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99481#c24410 Commit summary: message docs++ Comment: Added to translatewiki.net with r100034. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100000]: New comment added

2011-10-17 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r10. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/10#c24411 Commit summary: Puppet fixes Comment: Congratulations! We have now reached to revision #32 ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r99903]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99903. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99903 Commit summary: Localisation updates for core and extension messages from translatewiki.net

[MediaWiki-CodeReview] [MediaWiki r96016]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r96016. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96016 Commit summary: Optimize ucFirst by using charAt ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96016]: New comment added

2011-10-17 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r96016. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96016#c24412 Commit summary: Optimize ucFirst by using charAt Comment: Looks like a valid micro optimization. Since charAt() is in JS 1.0, we can assume this is working correctly

[MediaWiki-CodeReview] [MediaWiki r96150]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r96150. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96150 Commit summary: Separate execution from definition (mediawiki.util.init) * bug 30710 Also makes it easier to do unit testing, this way the

[MediaWiki-CodeReview] [MediaWiki r96151]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r96151. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96151 Commit summary: Whitespace indention fix for r96150 (seperate to make review easier) ___

[MediaWiki-CodeReview] [MediaWiki r96166]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r96166. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96166 Commit summary: Html.php: Move html5-validation blacklist check to *AFTER* the check the might continue (and skip this loop entirely) if we're

[MediaWiki-CodeReview] [MediaWiki r96183]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r96183. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96183 Commit summary: Crack down on arguments inside the Linker that call themselves $text but in reality are unescaped html.

[MediaWiki-CodeReview] [MediaWiki r93519]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r93519. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93519 Commit summary: Increasing coverage of mw.Title with unit tests. * QUnit Completeness Test – Before: Title.prototype.getNamespaceId

[MediaWiki-CodeReview] [MediaWiki r100035]: New comment added

2011-10-17 Thread MediaWiki Mail
User Johnduhart posted a comment on MediaWiki.r100035. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100035#c24413 Commit summary: Adding Tabber extensions Comment: Needs to support RL. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r93702]: New comment added

2011-10-17 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r93702. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93702#c24414 Commit summary: mediawiki.Title: Removing public setter functions. Title object should be immutable. - To avoid repetition, instead of substituting, changed them to

[MediaWiki-CodeReview] [MediaWiki r93702]: New comment added

2011-10-17 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r93702. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93702#c24415 Commit summary: mediawiki.Title: Removing public setter functions. Title object should be immutable. - To avoid repetition, instead of substituting, changed them to

[MediaWiki-CodeReview] [MediaWiki r93702]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r93702. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93702 Commit summary: mediawiki.Title: Removing public setter functions. Title object should be immutable. - To avoid repetition, instead of

[MediaWiki-CodeReview] [MediaWiki r100036]: New comment added

2011-10-17 Thread MediaWiki Mail
User Johnduhart posted a comment on MediaWiki.r100036. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100036#c24416 Commit summary: Fixing access bug and adding new permission and translation message, approved by Adam Comment: '''Stop committing directly to the branch'''. Use

[MediaWiki-CodeReview] [MediaWiki r100036]: New comment added

2011-10-17 Thread MediaWiki Mail
User SVG posted a comment on MediaWiki.r100036. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100036#c24417 Commit summary: Fixing access bug and adding new permission and translation message, approved by Adam Comment: Okay. Where is the difference between svn add and svn

[MediaWiki-CodeReview] [MediaWiki r100036]: New comment added

2011-10-17 Thread MediaWiki Mail
User Johnduhart posted a comment on MediaWiki.r100036. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100036#c24418 Commit summary: Fixing access bug and adding new permission and translation message, approved by Adam Comment:

[MediaWiki-CodeReview] [MediaWiki r95571]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r95571. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95571 Commit summary: mediawiki.util.test: Change portlet name to not conflict with core * When running the tests inside a wiki page, the added

[MediaWiki-CodeReview] [MediaWiki r100042]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Johnduhart changed the status of MediaWiki.r100042. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100042 Commit summary: add useful comments about portlet ids comments comes from r95571 commit log by Krinkle

[MediaWiki-CodeReview] [MediaWiki r100041]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r100041. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100041 Commit summary: Type hinting ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r99950]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Johnduhart changed the status of MediaWiki.r99950. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99950 Commit summary: * Send undisclosed-recipients in To header when sending the mail to more than one user instead of checking

[MediaWiki-CodeReview] [MediaWiki r95609]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r95609. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95609 Commit summary: Manually set the title as not being a redirect. Otherwise, it needed a database from Parser::getFunctionLang() -

[MediaWiki-CodeReview] [MediaWiki r99950]: New comment added, and revision status changed

2011-10-17 Thread MediaWiki Mail
User Johnduhart changed the status of MediaWiki.r99950. Old Status: ok New Status: new User Johnduhart also posted a comment on MediaWiki.r99950. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99950#c24419 Commit summary: * Send undisclosed-recipients in To header when sending

[MediaWiki-CodeReview] [MediaWiki r99951]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Johnduhart changed the status of MediaWiki.r99951. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99951 Commit summary: Per Nikerabbit, fix for r99863: removed copy/paste error in method documentation

[MediaWiki-CodeReview] [MediaWiki r99952]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Johnduhart changed the status of MediaWiki.r99952. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99952 Commit summary: Fixed bug in r99914, also reverted accidental tabs-spaces conversion ___

[MediaWiki-CodeReview] [MediaWiki r99956]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Johnduhart changed the status of MediaWiki.r99956. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99956 Commit summary: junk-- ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r95988]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r95988. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95988 Commit summary: Shut up build script about not having LocalSettings. You dont actually need it for this

[MediaWiki-CodeReview] [MediaWiki r99957]: New comment added

2011-10-17 Thread MediaWiki Mail
User Johnduhart posted a comment on MediaWiki.r99957. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99957#c24420 Commit summary: Extension for checking the enviroment to find possible problems This is an alpha version as an example The statuscheck does not work at the moment

[MediaWiki-CodeReview] [MediaWiki r97308]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r97308. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97308 Commit summary: Refactor variables to give somewhat useful names ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r97301]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r97301. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97301 Commit summary: Moar documentations ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r99966]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Johnduhart changed the status of MediaWiki.r99966. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99966 Commit summary: Localisation updates for core and extension messages from translatewiki.net

[MediaWiki-CodeReview] [MediaWiki r97178]: New comment added, and revision status changed

2011-10-17 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r97178. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r97178. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97178#c24421 Commit summary: throw exception if rename of output file fails Comment: Maybe

[MediaWiki-CodeReview] [MediaWiki r97178]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r97178. Old Status: ok New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97178 Commit summary: throw exception if rename of output file fails ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r99967]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Johnduhart changed the status of MediaWiki.r99967. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99967 Commit summary: Remove duplicate setting of From ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r97042]: New comment added

2011-10-17 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r97042. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97042#c24422 Commit summary: Chrome seems to already support dir=auto, and I see no downsides using it for user comments. Amir said that it is good. Comment: auto is only supported

[MediaWiki-CodeReview] [MediaWiki r97042]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r97042. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97042 Commit summary: Chrome seems to already support dir=auto, and I see no downsides using it for user comments. Amir said that it is good.

[MediaWiki-CodeReview] [MediaWiki r99973]: New comment added, and revision status changed

2011-10-17 Thread MediaWiki Mail
User Johnduhart changed the status of MediaWiki.r99973. Old Status: new New Status: ok User Johnduhart also posted a comment on MediaWiki.r99973. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99973#c24423 Commit summary: Moar documentation Comment: pre+ +

[MediaWiki-CodeReview] [MediaWiki r99973]: New comment added

2011-10-17 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r99973. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99973#c24424 Commit summary: Moar documentation Comment: Doesn't overly matter, it's just giving type hinting to $contestant ___

[MediaWiki-CodeReview] [MediaWiki r97028]: New comment added, and revision status changed

2011-10-17 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r97028. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r97028. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97028#c24425 Commit summary: Merged in mime-type from Wikia (for Sawfish Window Manager).

[MediaWiki-CodeReview] [MediaWiki r97042]: New comment added

2011-10-17 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r97042. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97042#c24426 Commit summary: Chrome seems to already support dir=auto, and I see no downsides using it for user comments. Amir said that it is good. Comment: As far as I know

[MediaWiki-CodeReview] [MediaWiki r96713]: New comment added

2011-10-17 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r96713. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96713#c24427 Commit summary: Add some basic tests to compare output of native json support and the Services_Json implementation, as I promised on wikitech-l. Could use plenty more

[MediaWiki-CodeReview] [MediaWiki r96713]: New comment added, and revision status changed

2011-10-17 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r96713. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r96713. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96713#c24428 Commit summary: Add some basic tests to compare output of native json support

[MediaWiki-CodeReview] [MediaWiki r98013]: New comment added, and revision status changed

2011-10-17 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r98013. Old Status: new New Status: fixme User Hashar also posted a comment on MediaWiki.r98013. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98013#c24429 Commit summary: Minor cleanup and line breaking to formatTimePeriod()

[MediaWiki-CodeReview] [MediaWiki r97815]: New comment added

2011-10-17 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r97815. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97815#c24430 Commit summary: Don't load all languages just to check whether message is known. I'm pretty sure I already fixed this once in the past. Comment: This one probably need

[MediaWiki-CodeReview] [MediaWiki r97626]: New comment added

2011-10-17 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r97626. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97626#c24431 Commit summary: No need to check isset before unset, shortens the code a bit, and added some whitespace Comment: Maybe it was needed by an older PHP Version? We would

[MediaWiki-CodeReview] [MediaWiki r100035]: New comment added

2011-10-17 Thread MediaWiki Mail
User Jack Phoenix posted a comment on MediaWiki.r100035. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100035#c24432 Commit summary: Adding Tabber extensions Comment: Coding style is '''ugly'''. You could've stylized it before committing IMHO. Also, what's the use case for

[MediaWiki-CodeReview] [MediaWiki r98299]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Khorn (WMF) changed the status of MediaWiki.r98299. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98299 Commit summary: Rebuilding the payflowpro gateway and adapter, Part 1 of Several! ...sending transactions should work now, in the

[MediaWiki-CodeReview] [MediaWiki r98202]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Khorn (WMF) changed the status of MediaWiki.r98202. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98202 Commit summary: More refactoring work for the gateway adapters, mostly surrounding the special page itself.

[MediaWiki-CodeReview] [MediaWiki r97780]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Khorn (WMF) changed the status of MediaWiki.r97780. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97780 Commit summary: Card #282, and a significant redefinition of what it means to stage gateway data (we get to do it backwards now! Yes!)

[MediaWiki-CodeReview] [MediaWiki r97341]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Khorn (WMF) changed the status of MediaWiki.r97341. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97341 Commit summary: Adds a processor-type page for the iframe to come back from, and a way to handle error code translation in a gateway's

[MediaWiki-CodeReview] [MediaWiki r97120]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Khorn (WMF) changed the status of MediaWiki.r97120. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97120 Commit summary: Edits to the stageData function to honor defaults ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r97115]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Khorn (WMF) changed the status of MediaWiki.r97115. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97115 Commit summary: Removing GC's ability to send credit card info ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r97106]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Khorn (WMF) changed the status of MediaWiki.r97106. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97106 Commit summary: DonationInterface's GlobalCollect gateway can now post server-side through existing forms. (Though doing so would

[MediaWiki-CodeReview] [MediaWiki r96927]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Khorn (WMF) changed the status of MediaWiki.r96927. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96927 Commit summary: Mods to make the DonationInterface tests accurate again.Fundraiser Card #285 Modifications to DonationInterface so

[MediaWiki-CodeReview] [MediaWiki r96644]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Khorn (WMF) changed the status of MediaWiki.r96644. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96644 Commit summary: Added more unit tests to DonationInterface. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r95923]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Khorn (WMF) changed the status of MediaWiki.r95923. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95923 Commit summary: More refactoring. The new globalcollect gateway is now inheriting from the common gateway abstract class. (Also

[MediaWiki-CodeReview] [MediaWiki r99803]: New comment added, and revision status changed

2011-10-17 Thread MediaWiki Mail
User Khorn (WMF) changed the status of MediaWiki.r99803. Old Status: new New Status: fixme User Khorn (WMF) also posted a comment on MediaWiki.r99803. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99803#c24433 Commit summary: Put in a check to make sure the key (STATUSID) in

[MediaWiki-CodeReview] [MediaWiki r99803]: New comment added

2011-10-17 Thread MediaWiki Mail
User Khorn (WMF) posted a comment on MediaWiki.r99803. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99803#c24434 Commit summary: Put in a check to make sure the key (STATUSID) in the $response array exists to prevent PHP notices on the site. Comment: ...but I fixed it.

[MediaWiki-CodeReview] [MediaWiki r99803]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Khorn (WMF) changed the status of MediaWiki.r99803. Old Status: fixme New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99803 Commit summary: Put in a check to make sure the key (STATUSID) in the $response array exists to prevent PHP notices on the site.

[MediaWiki-CodeReview] [MediaWiki r98566]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Preilly changed the status of MediaWiki.r98566. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98566 Commit summary: fix for bug 31214 - ipad apps - mobile article does not fit if webview width 768

[MediaWiki-CodeReview] [MediaWiki r100054]: New comment added

2011-10-17 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r100054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100054#c24435 Commit summary: Checks to see if the array key exists, so it won't explode badly if the response was completely malformed. r99803 Comment: Both lines should be

[MediaWiki-CodeReview] [MediaWiki r93702]: New comment added

2011-10-17 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r93702. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93702#c24436 Commit summary: mediawiki.Title: Removing public setter functions. Title object should be immutable. - To avoid repetition, instead of substituting, changed them to

[MediaWiki-CodeReview] [MediaWiki r93702]: New comment added

2011-10-17 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r93702. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93702#c24437 Commit summary: mediawiki.Title: Removing public setter functions. Title object should be immutable. - To avoid repetition, instead of substituting, changed them to

[MediaWiki-CodeReview] [MediaWiki r100054]: New comment added

2011-10-17 Thread MediaWiki Mail
User Khorn (WMF) posted a comment on MediaWiki.r100054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100054#c24438 Commit summary: Checks to see if the array key exists, so it won't explode badly if the response was completely malformed. r99803 Comment: Aw geeze: My bad.

[MediaWiki-CodeReview] [MediaWiki r100041]: New comment added

2011-10-17 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100041. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100041#c24439 Commit summary: Type hinting Comment: So we started using foo[] syntax now? ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [Wikimedia r617]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r617. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/617 Commit summary: fixing folder paths storing static and media data ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [Wikimedia r623]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r623. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/623 Commit summary: fixed issue in DataMapper.py - formatting insert statement ___

[MediaWiki-CodeReview] [Wikimedia r624]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r624. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/624 Commit summary: minor fix to landing page request mining, handle bad landing_urls differently

[MediaWiki-CodeReview] [Wikimedia r628]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r628. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/628 Commit summary: updating mining scripts to execute without args on commandline (look at latest log)

[MediaWiki-CodeReview] [Wikimedia r627]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r627. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/627 Commit summary: fixed issues with country allocation for log mining ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [Wikimedia r626]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r626. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/626 Commit summary: query fix - no longer filter on views ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [Wikimedia r625]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r625. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/625 Commit summary: fix for issue arising from escaping input to impressions loader ___

[MediaWiki-CodeReview] [MediaWiki r100053]: New comment added

2011-10-17 Thread MediaWiki Mail
User Raymond posted a comment on MediaWiki.r100053. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100053#c24440 Commit summary: all tabs improved PHP check Comment: This looks over-tabbed now. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [Wikimedia r563]: New comment added

2011-10-17 Thread MediaWiki Mail
User Pgehres (WMF) posted a comment on Wikimedia.r563. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/563#c24441 Commit summary: merging with http://svn.wikimedia.org/svnroot/wikimedia/trunk/fundraiser-analysis/ r562 - v0.0.1 Comment: Are the following files from your IDE?

[MediaWiki-CodeReview] [MediaWiki r99803]: New comment added

2011-10-17 Thread MediaWiki Mail
User Khorn (WMF) posted a comment on MediaWiki.r99803. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99803#c24442 Commit summary: Put in a check to make sure the key (STATUSID) in the $response array exists to prevent PHP notices on the site. Comment: Actually, I'm dumb. This

[MediaWiki-CodeReview] [Wikimedia r563]: New comment added

2011-10-17 Thread MediaWiki Mail
User Renklauf posted a comment on Wikimedia.r563. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/563#c24443 Commit summary: merging with http://svn.wikimedia.org/svnroot/wikimedia/trunk/fundraiser-analysis/ r562 - v0.0.1 Comment: yep you;re right those definitely do not need

[MediaWiki-CodeReview] [Wikimedia r621]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r621. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/621 Commit summary: mingle analytic #224 - added exception handling to relevant views upon failure

[MediaWiki-CodeReview] [MediaWiki r100054]: New comment added

2011-10-17 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r100054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100054#c24445 Commit summary: Checks to see if the array key exists, so it won't explode badly if the response was completely malformed. r99803 Comment: Then I think you

[MediaWiki-CodeReview] [MediaWiki r100054]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Khorn (WMF) changed the status of MediaWiki.r100054. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100054 Commit summary: Checks to see if the array key exists, so it won't explode badly if the response was completely malformed. r99803

[MediaWiki-CodeReview] [MediaWiki r100054]: New comment added

2011-10-17 Thread MediaWiki Mail
User Khorn (WMF) posted a comment on MediaWiki.r100054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100054#c24446 Commit summary: Checks to see if the array key exists, so it won't explode badly if the response was completely malformed. r99803 Comment: Will do.

[MediaWiki-CodeReview] [MediaWiki r100041]: New comment added

2011-10-17 Thread MediaWiki Mail
User Happy-melon posted a comment on MediaWiki.r100041. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100041#c24447 Commit summary: Type hinting Comment: ttHTMLFormField[]/tt 'works' (ie after calling ttforeach( $array as $foo = $bar ){ ... }/tt, $bar is recognised as being

[MediaWiki-CodeReview] [MediaWiki r100054]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Khorn (WMF) changed the status of MediaWiki.r100054. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100054 Commit summary: Checks to see if the array key exists, so it won't explode badly if the response was completely malformed.

[MediaWiki-CodeReview] [MediaWiki r99958]: New comment added, and revision status changed

2011-10-17 Thread MediaWiki Mail
User Jeroen De Dauw changed the status of MediaWiki.r99958. Old Status: new New Status: resolved User Jeroen De Dauw also posted a comment on MediaWiki.r99958. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99958#c24449 Commit summary: * Actually implement contest expiry. When

Re: [Wikitech-l] CruiseControl IRC publish status

2011-10-17 Thread Chad
On Sun, Oct 16, 2011 at 4:15 AM, Chad innocentkil...@gmail.com wrote: CruiseControl is dead. I'll be sending an email about this soon. -Chad Please see the thread Production CI box now in service. I apologize for not communicating this better in advance since you run codurr. Any further

[MediaWiki-CodeReview] [MediaWiki r100074]: New comment added

2011-10-17 Thread MediaWiki Mail
User Jpostlethwaite posted a comment on MediaWiki.r100074. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100074#c24450 Commit summary: Preventing notices from unset indices in arrays. Comment: Sometimes the fields did not exist in the $this-var_map or in

[MediaWiki-CodeReview] [MediaWiki r100067]: New comment added

2011-10-17 Thread MediaWiki Mail
User Amire80 posted a comment on MediaWiki.r100067. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100067#c24452 Commit summary: Starting refactoring on the way to fixing bug 4030. No functional changes are supposed to be introduced in this version and according to my tests this

[MediaWiki-CodeReview] [MediaWiki r99562]: New comment added, and revision status changed

2011-10-17 Thread MediaWiki Mail
User OverlordQ changed the status of MediaWiki.r99562. Old Status: new New Status: fixme User OverlordQ also posted a comment on MediaWiki.r99562. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99562#c24453 Commit summary: Avoid warnings from PG about improper escaping. See

Re: [Wikitech-l] Production CI box now in service

2011-10-17 Thread OQ
On Mon, Oct 17, 2011 at 2:31 PM, Chad innocentkil...@gmail.com wrote: Hi, With a lot of help from the folks in ops (special thanks to Rob, Daniel and Ryan), we've gotten the new continuous integration server up and running! Can we please also test the other DB backends, since I know there's

[MediaWiki-CodeReview] [MediaWiki r100004]: Revision status changed

2011-10-17 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r14. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/14 Commit summary: MFT r99673: possible fix for bug 31653: Translation page updates might not happen when there is replication lag MFT

[MediaWiki-CodeReview] [MediaWiki r99097]: New comment added, and revision status changed

2011-10-17 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r99097. Old Status: fixme New Status: ok User Krinkle also posted a comment on MediaWiki.r99097. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99097#c24454 Commit summary: (bug 31411) Remove stray comma introduced in r86853, broke

  1   2   >