Re: [Wikitech-l] MediaWiki unit testing and non-MySQL databases

2011-10-26 Thread Jeremy Baron
On Wed, Oct 26, 2011 at 01:33, Dmitriy Sintsov ques...@rambler.ru wrote: * Jeremy Baron jer...@tuxmachine.com [Wed, 26 Oct 2011 01:09:07 -0400]: Should I do not use table aliases at all? Aliases should be fine. (at least per the docs I found and reedy's example) If they are fine, why my

[MediaWiki-CodeReview] [MediaWiki r100718]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r100718. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100718 Commit summary: throw out bc code ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100734]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r100734. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100734 Commit summary: throw out bc code ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100690]: New comment added

2011-10-26 Thread MediaWiki Mail
User QuestPC posted a comment on MediaWiki.r100690. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100690#c24869 Commit summary: Fixed regression in question type text when prefilled text inputs were not displayed. Added textarea and select multiple view modes for question type

[MediaWiki-CodeReview] [MediaWiki r93581]: New comment added

2011-10-26 Thread MediaWiki Mail
User Fomafix posted a comment on MediaWiki.r93581. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93581#c24870 Commit summary: Fixing Bug 27540 : width of gallery always 100%, by setting display to inline-block. Comment: Yes, this is an other disadvantage of codeul.gallery {

[MediaWiki-CodeReview] [MediaWiki r100794]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r100794. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100794 Commit summary: svn:eol-style=native ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] MediaWiki unit testing and non-MySQL databases

2011-10-26 Thread Platonides
Jeremy Baron wrote: Seems pretty clearly broken; we should fix the way we quote. (and maybe not break anyone because anyone using the syntax that triggers this would already be broken because of this) Maybe we need backticks instead of quotes? I can test when I'm less sleepy but maybe someone

Re: [Wikitech-l] MediaWiki unit testing and non-MySQL databases

2011-10-26 Thread Platonides
Platonides wrote: Jeremy Baron wrote: Seems pretty clearly broken; we should fix the way we quote. (and maybe not break anyone because anyone using the syntax that triggers this would already be broken because of this) Maybe we need backticks instead of quotes? I can test when I'm less sleepy

Re: [Wikitech-l] etherpad-lite

2011-10-26 Thread Antoine Musso
On 26/10/11 00:07, Jeremy Baron wrote: On Oct 25, 2011 5:40 PM, Sumana Harihareswara wrote: And I have submitted a request to Wikimedia's ops team to upgrade our etherpad.wikimedia.org installation to Etherpad Lite. RT #? The ops ticket is #1720 :

Re: [Wikitech-l] Welcome, Antoine Musso! (hashar)

2011-10-26 Thread Antoine Musso
On 22/10/11 00:24, Platonides wrote: snip That was my first concern, wasn't that supposed to be secretly kept?? I did confirm to Rob it was fine to reveal my identity. It already leaked everywhere on the internet anyway :-) Moreover, people tended to confuse me with Asher Feldman since Asher

[MediaWiki-CodeReview] [MediaWiki r100663]: New comment added

2011-10-26 Thread MediaWiki Mail
User G.Hagedorn posted a comment on MediaWiki.r100663. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100663#c24871 Commit summary: search suggestions and interwiki links Comment: please consider tagging for 1.18 ___

[MediaWiki-CodeReview] [MediaWiki r100765]: New comment added

2011-10-26 Thread MediaWiki Mail
User G.Hagedorn posted a comment on MediaWiki.r100765. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100765#c24872 Commit summary: search suggestions and interwiki links Comment: please consider tagging for 1.18 ___

[MediaWiki-CodeReview] [MediaWiki r100686]: New comment added

2011-10-26 Thread MediaWiki Mail
User G.Hagedorn posted a comment on MediaWiki.r100686. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100686#c24873 Commit summary: fixed bug 31821 (Special:Book not allowing saving) Comment: please consider tagging for 1.18 ___

Re: [Wikitech-l] etherpad-lite

2011-10-26 Thread Niklas Laxström
Does etherpad-lite also fix the annoying problems with current etherpad: last chat line half visible, scrolling jumps directly to very top or very bottom, cannot resize chat pane? -- Niklas Laxström ___ Wikitech-l mailing list

[MediaWiki-CodeReview] [MediaWiki r100797]: New comment added

2011-10-26 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r100797. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100797#c24874 Commit summary: Commit ReferenceTooltips extension. It gives the content of a reference as a tooltip Comment: pre +/** + * MoodBar extension + * Allows specified

[Wikitech-l] Temporary password too short

2011-10-26 Thread William Allen Simpson
I've been around a long time (2003) and have old accounts that I never use, usually explicitly setup to prevent folks from creating accounts with different capitalization for misleading user names in comments. After SUL, that case variance problem should be handled correctly. But those existing

Re: [Wikitech-l] Temporary password too short

2011-10-26 Thread Steve Summit
William Allen Simpson wrote: This replacement password is much more easily guessed. The account could have been stolen within minutes or hours. Is this true? (Yes, I know that a fast machine can try zillions of passwords per hour in theory, but for a reasonably designed system, certainly not

[MediaWiki-CodeReview] [MediaWiki r100758]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Jack Phoenix changed the status of MediaWiki.r100758. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100758 Commit summary: Set $messages at the beginning. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100793]: New comment added, and revision status changed

2011-10-26 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r100793. Old Status: new New Status: fixme User Catrope also posted a comment on MediaWiki.r100793. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100793#c24875 Commit summary: FeedbackDashboard: Rearrange to allow showing/hiding by

[MediaWiki-CodeReview] [MediaWiki r100803]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r100803. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100803 Commit summary: Improve error handling ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100793]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r100793. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100793 Commit summary: FeedbackDashboard: Rearrange to allow showing/hiding by AJAX. Also make sure that we test everything correctly in

[MediaWiki-CodeReview] [MediaWiki r100761]: New comment added

2011-10-26 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100761. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100761#c24876 Commit summary: Followup to r97033 - removed wgWhatlinksherelimit and started the conversion to wgQueryPageDefaultLimit, but didn't see too many places using a

Re: [Wikitech-l] Temporary password too short

2011-10-26 Thread Andre Engels
On Wed, Oct 26, 2011 at 1:55 PM, William Allen Simpson william.allen.simp...@gmail.com wrote: # Temporary password: YH2MnDD # # This temporary password will expire in 7 days. # You should log in and choose a new password now. If someone else made this # request, or if you have remembered

[MediaWiki-CodeReview] [MediaWiki r100776]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r100776. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100776 Commit summary: some eol w/s ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] Temporary password too short

2011-10-26 Thread Daniel Friesen
On Wed, 26 Oct 2011 04:55:11 -0700, William Allen Simpson william.allen.simp...@gmail.com wrote: I've been around a long time (2003) and have old accounts that I never use, usually explicitly setup to prevent folks from creating accounts with different capitalization for misleading user

Re: [Wikitech-l] Temporary password too short

2011-10-26 Thread Neil Harris
On 26/10/11 13:03, Steve Summit wrote: William Allen Simpson wrote: This replacement password is much more easily guessed. The account could have been stolen within minutes or hours. Is this true? (Yes, I know that a fast machine can try zillions of passwords per hour in theory, but for a

Re: [Wikitech-l] Temporary password too short

2011-10-26 Thread Helder
On Wed, Oct 26, 2011 at 11:13, Neil Harris n...@tonal.clara.co.uk wrote: If there's one measure I'd like to see that isn't (as far as I know) yet implemented, it would be to require admins and other privileged users to set strong passwords, perhaps initially by Javascript-based warnings, and

[MediaWiki-CodeReview] [MediaWiki r100795]: New comment added

2011-10-26 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100795. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100795#c24877 Commit summary: Split out checkExecutePermissions() function from userCanExecute() in FormSpecialPage. The former handles actual execute() calls and throws

[MediaWiki-CodeReview] [MediaWiki r100797]: New comment added, and revision status changed

2011-10-26 Thread MediaWiki Mail
User MaxSem changed the status of MediaWiki.r100797. Old Status: new New Status: fixme User MaxSem also posted a comment on MediaWiki.r100797. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100797#c24878 Commit summary: Commit ReferenceTooltips extension. It gives the content

Re: [Wikitech-l] Temporary password too short

2011-10-26 Thread Olivier Beaton
Admins should be required (At least at wmf) to use an authenticator, no? On Wed, Oct 26, 2011 at 9:24 AM, Helder helder.w...@gmail.com wrote: On Wed, Oct 26, 2011 at 11:13, Neil Harris n...@tonal.clara.co.uk wrote: If there's one measure I'd like to see that isn't (as far as I know) yet

Re: [Wikitech-l] Temporary password too short

2011-10-26 Thread John Du Hart
No, maybe stewards but not admins. On Oct 26, 2011 9:40 AM, Olivier Beaton olivier.bea...@gmail.com wrote: Admins should be required (At least at wmf) to use an authenticator, no? On Wed, Oct 26, 2011 at 9:24 AM, Helder helder.w...@gmail.com wrote: On Wed, Oct 26, 2011 at 11:13, Neil Harris

Re: [Wikitech-l] Temporary password too short

2011-10-26 Thread Neil Harris
On 26/10/11 14:24, Helder wrote: On Wed, Oct 26, 2011 at 11:13, Neil Harrisn...@tonal.clara.co.uk wrote: If there's one measure I'd like to see that isn't (as far as I know) yet implemented, it would be to require admins and other privileged users to set strong passwords, perhaps initially by

Re: [Wikitech-l] Temporary password too short

2011-10-26 Thread OQ
On Wed, Oct 26, 2011 at 7:59 AM, Andre Engels andreeng...@gmail.com wrote: I do seriously wonder whether it is possible to steal such a password 'within minutes or hours'. My calculation says that to do it within 24 hours, one needs to test 40 million passwords per second. And remember that

Re: [Wikitech-l] Please review: MediaWiki architecture document

2011-10-26 Thread Sumana Harihareswara
I encourage anybody who's spent any time developing for MediaWiki to go and read https://www.mediawiki.org/wiki/MediaWiki_architecture_document/text -- it's thorough! There are some FIXMEs in there where Guillaume requests more details about performance, caching, and skins, so if you can add some

[MediaWiki-CodeReview] [MediaWiki r100805]: New comment added

2011-10-26 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r100805. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100805#c24879 Commit summary: script to parse wikitext from CLI Wikitext can be given by stdin or using a file. The wikitext will be parsed using 'CLIParser' as a title. This

[MediaWiki-CodeReview] [MediaWiki r100804]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User MaxSem changed the status of MediaWiki.r100804. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100804 Commit summary: Update header from r100797 :) ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100813]: New comment added

2011-10-26 Thread MediaWiki Mail
User Dantman posted a comment on MediaWiki.r100813. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100813#c24880 Commit summary: Bug 31609 - Option to change reCAPTCHA theme Patch by Nx.devnull Comment: Too good for codeXml::encodeJsVar( array( 'theme' = $wgReCaptchaTheme,

[MediaWiki-CodeReview] [MediaWiki r100805]: New comment added

2011-10-26 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r100805. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100805#c24881 Commit summary: script to parse wikitext from CLI Wikitext can be given by stdin or using a file. The wikitext will be parsed using 'CLIParser' as a title. This can be

[MediaWiki-CodeReview] [MediaWiki r100807]: New comment added

2011-10-26 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100807. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100807#c24882 Commit summary: Tool to verify the correctness of php message files. Ensures that the given files adhere to a safe subset of php. The provided update-msgs.sh can

[MediaWiki-CodeReview] [MediaWiki r100770]: New comment added

2011-10-26 Thread MediaWiki Mail
User MarkAHershberger posted a comment on MediaWiki.r100770. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100770#c24883 Commit summary: From Bug #31794 - [Users.php] HTML5 \o/ Patch from p858snake. Comment: Email with your comment had the \t in it

[MediaWiki-CodeReview] [MediaWiki r100770]: New comment added

2011-10-26 Thread MediaWiki Mail
User Reach Out to the Truth posted a comment on MediaWiki.r100770. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100770#c24884 Commit summary: From Bug #31794 - [Users.php] HTML5 \o/ Patch from p858snake. Comment: And it's still in the page source, if anyone wants to take a

[MediaWiki-CodeReview] [MediaWiki r100723]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r100723. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100723 Commit summary: Port Special:Lockdb and Special:Unlockdb to HTMLForm using FormSpecialPage

Re: [Wikitech-l] Announcing Fabrice Florin and Oliver Keyes

2011-10-26 Thread Sumana Harihareswara
Welcome, Fabrice and Oliver! You can read an interview with Oliver in the newest Wikipedia Signpost -- http://en.wikipedia.org/wiki/Wikipedia:Wikipedia_Signpost/2011-10-24/Interview -- and Oliver and Fabrice will be participating in an IRC office hours session (in #wikimedia-office) tomorrow, on

[MediaWiki-CodeReview] [MediaWiki r100807]: New comment added

2011-10-26 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r100807. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100807#c24885 Commit summary: Tool to verify the correctness of php message files. Ensures that the given files adhere to a safe subset of php. The provided update-msgs.sh can

[MediaWiki-CodeReview] [MediaWiki r100807]: New comment added

2011-10-26 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100807. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100807#c24886 Commit summary: Tool to verify the correctness of php message files. Ensures that the given files adhere to a safe subset of php. The provided update-msgs.sh can

[MediaWiki-CodeReview] [MediaWiki r100696]: New comment added

2011-10-26 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r100696. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100696#c24887 Commit summary: maint script dumping email message This script format the 4 different type of email notification and show them to the user with parameters filled up.

[MediaWiki-CodeReview] [MediaWiki r100807]: New comment added

2011-10-26 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r100807. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100807#c24888 Commit summary: Tool to verify the correctness of php message files. Ensures that the given files adhere to a safe subset of php. The provided update-msgs.sh can

Re: [Wikitech-l] Please review: MediaWiki architecture document

2011-10-26 Thread Rob Lanphier
On Wed, Oct 26, 2011 at 7:18 AM, Sumana Harihareswara suma...@wikimedia.org wrote: I encourage anybody who's spent any time developing for MediaWiki to go and read https://www.mediawiki.org/wiki/MediaWiki_architecture_document/text -- it's thorough!  There are some FIXMEs in there where

[MediaWiki-CodeReview] [MediaWiki r100807]: New comment added

2011-10-26 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100807. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100807#c24889 Commit summary: Tool to verify the correctness of php message files. Ensures that the given files adhere to a safe subset of php. The provided update-msgs.sh can

[MediaWiki-CodeReview] [MediaWiki r97033]: New comment added, and revision status changed

2011-10-26 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r97033. Old Status: fixme New Status: new User Krinkle also posted a comment on MediaWiki.r97033. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97033#c24890 Commit summary: Merged wgWhatlinkshereLimit from Wikia. It defaults to the

[MediaWiki-CodeReview] [Wikimedia r657]: New comment added

2011-10-26 Thread MediaWiki Mail
User Pgehres (WMF) posted a comment on Wikimedia.r657. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/657#c24891 Commit summary: reporting fix on winning artifacts. Resolved issue regarding incorrect test winner being reported. Issue stemmed from inconsistent indexing of

[MediaWiki-CodeReview] [Wikimedia r657]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r657. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/657 Commit summary: reporting fix on winning artifacts. Resolved issue regarding incorrect test winner being reported. Issue stemmed from

[MediaWiki-CodeReview] [Wikimedia r658]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r658. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/658 Commit summary: fix to log miner wrapper script. Check arg type of str not int. ___

[MediaWiki-CodeReview] [Wikimedia r659]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r659. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/659 Commit summary: added delete to log mining after logs have been processed ___

[MediaWiki-CodeReview] [Wikimedia r660]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r660. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/660 Commit summary: UI mod: added UTC to specify times in live results dashboard template ___

[MediaWiki-CodeReview] [Wikimedia r661]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r661. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/661 Commit summary: fix, removed logic from DataMapper.py method for log mining that filtered execution based on time. renamed method.

[MediaWiki-CodeReview] [Wikimedia r662]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r662. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/662 Commit summary: minor fix: replaced regexp function with equality ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [Wikimedia r663]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r663. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/663 Commit summary: fix - removed impression counts from LP tests. There were two options here (1) add complexity to the query in order to

[MediaWiki-CodeReview] [Wikimedia r664]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r664. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/664 Commit summary: minor fix: removed regexp from queries in favour of '=' ___

[MediaWiki-CodeReview] [Wikimedia r665]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r665. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/665 Commit summary: mingle analytics #231 - add a skewness measure (amount normal) to replace amount amount50 modified capture of civi data in

[MediaWiki-CodeReview] [Wikimedia r666]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r666. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/666 Commit summary: fix: handling of logs timestamped with *12AM* ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [Wikimedia r669]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r669. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/669 Commit summary: (re: mingle analytics #231) removed amount50 from summary results ___

[MediaWiki-CodeReview] [Wikimedia r672]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r672. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/672 Commit summary: fixed typos ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [Wikimedia r673]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r673. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/673 Commit summary: mingle analytics #212 - Change headers for summary statistics (show a legend) Added methods in data reporting that 1) map

[MediaWiki-CodeReview] [Wikimedia r674]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r674. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/674 Commit summary: mingle analytics #212 - Change headers for summary statistics (show a legend) see r673

[MediaWiki-CodeReview] [Wikimedia r657]: New comment added

2011-10-26 Thread MediaWiki Mail
User Renklauf posted a comment on Wikimedia.r657. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/657#c24892 Commit summary: reporting fix on winning artifacts. Resolved issue regarding incorrect test winner being reported. Issue stemmed from inconsistent indexing of lists.

[MediaWiki-CodeReview] [Wikimedia r657]: New comment added

2011-10-26 Thread MediaWiki Mail
User Pgehres (WMF) posted a comment on Wikimedia.r657. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/657#c24893 Commit summary: reporting fix on winning artifacts. Resolved issue regarding incorrect test winner being reported. Issue stemmed from inconsistent indexing of

[MediaWiki-CodeReview] [MediaWiki r100802]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r100802. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100802 Commit summary: rename variable to avoid confusion ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100837]: New comment added

2011-10-26 Thread MediaWiki Mail
User Jpostlethwaite posted a comment on MediaWiki.r100837. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100837#c24894 Commit summary: Adding modules directory for GlobalCollect. Comment: Added direct debit to GlobalCollect. Simplified switch statement in

[MediaWiki-CodeReview] [MediaWiki r100805]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r100805. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100805 Commit summary: script to parse wikitext from CLI Wikitext can be given by stdin or using a file. The wikitext will be parsed using

[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added, and revision status changed

2011-10-26 Thread MediaWiki Mail
User Raymond changed the status of MediaWiki.r100835. Old Status: new New Status: fixme User Raymond also posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24895 Commit summary: user configuration fixed db Comment: This is a dupe

[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added

2011-10-26 Thread MediaWiki Mail
User Petrb posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24896 Commit summary: user configuration fixed db Comment: renamed ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added

2011-10-26 Thread MediaWiki Mail
User TheDJ posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24897 Commit summary: user configuration fixed db Comment: in r100848 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100848]: New comment added

2011-10-26 Thread MediaWiki Mail
User TheDJ posted a comment on MediaWiki.r100848. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100848#c24898 Commit summary: several fixes including collision fix with gadgets Comment: Conflict issue: r100848 ___

[MediaWiki-CodeReview] [MediaWiki r100835]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Raymond changed the status of MediaWiki.r100835. Old Status: fixme New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835 Commit summary: user configuration fixed db ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added, and revision status changed

2011-10-26 Thread MediaWiki Mail
User Petrb changed the status of MediaWiki.r100835. Old Status: deferred New Status: fixme User Petrb also posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24899 Commit summary: user configuration fixed db Comment: could you tell

[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added

2011-10-26 Thread MediaWiki Mail
User TheDJ posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24900 Commit summary: user configuration fixed db Comment: See

[MediaWiki-CodeReview] [MediaWiki r100857]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r100857. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100857 Commit summary: improved messages ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100795]: New comment added

2011-10-26 Thread MediaWiki Mail
User IAlex posted a comment on MediaWiki.r100795. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100795#c24901 Commit summary: Split out checkExecutePermissions() function from userCanExecute() in FormSpecialPage. The former handles actual execute() calls and throws exceptions,

[Wikitech-l] Visual Editor / parser status update meeting notes 2011-10-26

2011-10-26 Thread Brion Vibber
I've copied the live etherpad notes from today's Visual Editor / New Parser update meeting onto wikitext-l for those who may be interested: http://lists.wikimedia.org/pipermail/wikitext-l/2011-October/000463.html -- brion ___ Wikitech-l mailing list

[MediaWiki-CodeReview] [MediaWiki r100858]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r100858. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100858 Commit summary: Followup r100847, ApiMain now respects $wgShowHostnames ___

[MediaWiki-CodeReview] [MediaWiki r100847]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r100847. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100847 Commit summary: Small todo note about ApiMain ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100778]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r100778. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100778 Commit summary: Add, update, tweak documentation Fix document comment blocks Tweak some returns

[MediaWiki-CodeReview] [MediaWiki r100779]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r100779. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100779 Commit summary: Add, update, tweak documentation Fix document comment blocks Tweak some returns

[MediaWiki-CodeReview] [MediaWiki r100780]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r100780. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100780 Commit summary: Swap /* * for /** * ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100783]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r100783. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100783 Commit summary: More documentation! ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100790]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Jpostlethwaite changed the status of MediaWiki.r100790. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100790 Commit summary: Killing a couple error_log statements I missed in r100133 and r100777

[MediaWiki-CodeReview] [MediaWiki r100787]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Jpostlethwaite changed the status of MediaWiki.r100787. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100787 Commit summary: More appropriate default form classes, and allowed rapidHtml forms, for donationinterface.

[MediaWiki-CodeReview] [MediaWiki r100785]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Jpostlethwaite changed the status of MediaWiki.r100785. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100785 Commit summary: adding globalcollect lightbox ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r99941]: New comment added

2011-10-26 Thread MediaWiki Mail
User NeilK posted a comment on MediaWiki.r99941. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99941#c24902 Commit summary: Applied modified patch by Ben Hartshorne bhartshorne at wikimedia dot org: Leverage MW 1.18's improved image metadata extraction to automatically extract

[MediaWiki-CodeReview] [MediaWiki r100781]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Jpostlethwaite changed the status of MediaWiki.r100781. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100781 Commit summary: Constructed a couple forms a little too aggressively (Oops). r100777 ___

[MediaWiki-CodeReview] [MediaWiki r100777]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Jpostlethwaite changed the status of MediaWiki.r100777. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100777 Commit summary: This commit addresses a couple issues in DonationInterface that turned out to be more or less the same issue. First:

[MediaWiki-CodeReview] [MediaWiki r100775]: New comment added, and revision status changed

2011-10-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r100775. Old Status: new New Status: ok User Aaron Schulz also posted a comment on MediaWiki.r100775. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100775#c24903 Commit summary: Bug 31948 - Special:Contributions doesn't

[MediaWiki-CodeReview] [MediaWiki r100769]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Jpostlethwaite changed the status of MediaWiki.r100769. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100769 Commit summary: better error handling for globalcollect - localize error messages ___

[MediaWiki-CodeReview] [MediaWiki r100754]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Jpostlethwaite changed the status of MediaWiki.r100754. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100754 Commit summary: adding missing i18n file ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100838]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Jpostlethwaite changed the status of MediaWiki.r100838. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100838 Commit summary: Moved resources that get loaded in TwoStepTwoColumn forms out of the constructors into their own function for

[MediaWiki-CodeReview] [MediaWiki r100843]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Jpostlethwaite changed the status of MediaWiki.r100843. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100843 Commit summary: Revert r100839. I misunderstood what exactly loadPlaceholders was already doing in TwoStepTwoColumnLetter3

[MediaWiki-CodeReview] [MediaWiki r100839]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Jpostlethwaite changed the status of MediaWiki.r100839. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100839 Commit summary: Fixing redundat loadResources() call in TwoStepTwoColumnLetter3 form because the parent will already load the

[MediaWiki-CodeReview] [MediaWiki r100749]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Jpostlethwaite changed the status of MediaWiki.r100749. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100749 Commit summary: last of the i18n message key changes for DonationInterface ___

[MediaWiki-CodeReview] [MediaWiki r100748]: Revision status changed

2011-10-26 Thread MediaWiki Mail
User Jpostlethwaite changed the status of MediaWiki.r100748. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100748 Commit summary: more message migration ___ MediaWiki-CodeReview mailing list

  1   2   3   >