[MediaWiki-CodeReview] [MediaWiki r106837]: New comment added, and revision status changed

2011-12-21 Thread MediaWiki Mail
GWicke changed the status of MediaWiki.r106837 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106837#c28195 Old Status: new New Status: ok Commit summary for MediaWiki.r106837: Fix svn:mime-type property from application/octet-stream to something better

[MediaWiki-CodeReview] [MediaWiki r106857]: New comment added, and revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106857 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106857#c28196 Old Status: new New Status: fixme Commit summary for MediaWiki.r106857: Also handle URLs like index.php?title=Page. Fallback to main page if no

Re: [Wikitech-l] Missing wiki redirect script

2011-12-21 Thread Roan Kattouw
On Tue, Dec 20, 2011 at 9:51 PM, Robin Pepermans robinp.1...@gmail.com wrote: Thank you. I thought $language and $project wouldn't need escaping because their values are known: $project can only be one of wikipedia, wikisource, ... and $language only one of

Re: [Wikitech-l] CLDR support added to XML::languageSelector()

2011-12-21 Thread Roan Kattouw
On Wed, Dec 21, 2011 at 2:34 AM, Ryan Kaldari rkald...@wikimedia.org wrote: Unfortunately, we only have 1 available deployment day left before the holidays, so if there's any chance someone could review the revision before 2pm tomorrow, it would be greatly appreciated.

Re: [Wikitech-l] Code review thoughts: module reviewers

2011-12-21 Thread Roan Kattouw
On Wed, Dec 21, 2011 at 12:01 AM, Brion Vibber bvib...@wikimedia.org wrote: Often, little things are suitable for many people to look at, but major subsystem refactorings -- like the landing of Aaron's file backend changes -- really are specialized and need to be looked over by somebody who's a

[MediaWiki-CodeReview] [MediaWiki r106883]: New comment added

2011-12-21 Thread MediaWiki Mail
GWicke posted a comment on MediaWiki.r106883. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106883#c28197 Commit summary for MediaWiki.r106883: partial revert of r106872 after discussion with Brion on #mediawiki irc GWicke's comment: s/usefull/useful/ in DefaultSettings.php comment

[MediaWiki-CodeReview] [MediaWiki r106883]: New comment added

2011-12-21 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r106883. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106883#c28198 Commit summary for MediaWiki.r106883: partial revert of r106872 after discussion with Brion on #mediawiki irc Hashar's comment: Why mark the function as deprecated in first

[MediaWiki-CodeReview] [MediaWiki r106883]: New comment added

2011-12-21 Thread MediaWiki Mail
Aaron Schulz posted a comment on MediaWiki.r106883. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106883#c28199 Commit summary for MediaWiki.r106883: partial revert of r106872 after discussion with Brion on #mediawiki irc Aaron Schulz's comment: I'd tend to agree.

[MediaWiki-CodeReview] [MediaWiki r101133]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r101133 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101133 Old status: new New status: ok Commit summary for MediaWiki.r101133: Give optional messages a bit more visibility ___

[MediaWiki-CodeReview] [MediaWiki r105995]: New comment added

2011-12-21 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r105995. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105995#c28200 Commit summary for MediaWiki.r105995: back to display:block; for galleries Display inline-block show weird behaviour when the gallery has text before and after. Fomafix on cr of

[MediaWiki-CodeReview] [MediaWiki r106920]: New comment added

2011-12-21 Thread MediaWiki Mail
Santhosh.thottingal posted a comment on MediaWiki.r106920. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106920#c28201 Commit summary for MediaWiki.r106920: fix duplicate global variable problem in MarkAsHelpful.php, attempt to resolve a relative image problem in css

[MediaWiki-CodeReview] [MediaWiki r106914]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r106914 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106914 Old status: new New status: ok Commit summary for MediaWiki.r106914: now with CLDR! This rev depends on r106912 ___

[MediaWiki-CodeReview] [MediaWiki r103197]: New comment added, and revision status changed

2011-12-21 Thread MediaWiki Mail
GWicke changed the status of MediaWiki.r103197 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103197#c28202 Old Status: new New Status: ok Commit summary for MediaWiki.r103197: missing TEX_FUN1nb in html_render_deep() The new TEX_FUN1nb introduced by r99741

[MediaWiki-CodeReview] [MediaWiki r106884]: New comment added

2011-12-21 Thread MediaWiki Mail
Darkoneko posted a comment on MediaWiki.r106884. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106884#c28203 Commit summary for MediaWiki.r106884: Followup r105280 For bug 33139 Swapping colors in new diff color scheme * Modified diff colorscheme to yellow[orange]/blue[blue] -

[MediaWiki-CodeReview] [MediaWiki r106884]: New comment added

2011-12-21 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r106884. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106884#c28204 Commit summary for MediaWiki.r106884: Followup r105280 For bug 33139 Swapping colors in new diff color scheme * Modified diff colorscheme to yellow[orange]/blue[blue] -

[MediaWiki-CodeReview] [MediaWiki r106920]: New comment added

2011-12-21 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r106920. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106920#c28205 Commit summary for MediaWiki.r106920: fix duplicate global variable problem in MarkAsHelpful.php, attempt to resolve a relative image problem in css Nikerabbit's comment:

[MediaWiki-CodeReview] [MediaWiki r106798]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r106798 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106798 Old status: new New status: ok Commit summary for MediaWiki.r106798: Css fix ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r105280]: New comment added

2011-12-21 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r105280. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105280#c28206 Commit summary for MediaWiki.r105280: Diff colors now use the french Wikipedia scheme The french community has been using a specific set of colors for diff, it is believed to be

[MediaWiki-CodeReview] [MediaWiki r105280]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r105280 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105280 Old status: fixme New status: new Commit summary for MediaWiki.r105280: Diff colors now use the french Wikipedia scheme The french community has been using a specific set of

[MediaWiki-CodeReview] [MediaWiki r105280]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r105280 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105280 Old status: new New status: resolved Commit summary for MediaWiki.r105280: Diff colors now use the french Wikipedia scheme The french community has been using a

Re: [Wikitech-l] Missing wiki redirect script

2011-12-21 Thread Liangent
On Wed, Dec 21, 2011 at 4:36 PM, Roan Kattouw roan.katt...@gmail.com wrote: I tried to address URLs like /w/index.php?title= in r106857 but I'm not sure it is the correct way. It's difficult to test. If no /wiki/Page or $_GET['title'] defined, it will default to the Main Page. That logic

[MediaWiki-CodeReview] [MediaWiki r106920]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r106920 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106920 Old status: new New status: ok Commit summary for MediaWiki.r106920: fix duplicate global variable problem in MarkAsHelpful.php, attempt to resolve a relative

[MediaWiki-CodeReview] [MediaWiki r106884]: New comment added

2011-12-21 Thread MediaWiki Mail
Darkoneko posted a comment on MediaWiki.r106884. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106884#c28207 Commit summary for MediaWiki.r106884: Followup r105280 For bug 33139 Swapping colors in new diff color scheme * Modified diff colorscheme to yellow[orange]/blue[blue] -

[Wikitech-l] Nagios parser

2011-12-21 Thread Petr Bena
Hi, I wrote a nagios parser for wmflabs, it downloads instance list from labsconsole and using simple application it parses it and generate nagios configs, it's currently running periodicaly on nagios.wmflabs.org and thanks to that nagios is updated when you create a new instance, it parses the

[MediaWiki-CodeReview] [MediaWiki r106939]: New comment added

2011-12-21 Thread MediaWiki Mail
Siebrand posted a comment on MediaWiki.r106939. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106939#c28208 Commit summary for MediaWiki.r106939: Rename variable and don't use skin Siebrand's comment: Really? :) pre+        if ( rand( 1, 100 ) 50 ) { +            return

[MediaWiki-CodeReview] [MediaWiki r106939]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r106939 to fixme URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106939 Old status: new New status: fixme Commit summary for MediaWiki.r106939: Rename variable and don't use skin ___

[MediaWiki-CodeReview] [MediaWiki r106789]: New comment added

2011-12-21 Thread MediaWiki Mail
Santhosh.thottingal posted a comment on MediaWiki.r106789. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106789#c28209 Commit summary for MediaWiki.r106789: Split Special:PageTranslation styles into different module Santhosh.thottingal's comment: + padding-bottom: 3ex; Is

[MediaWiki-CodeReview] [MediaWiki r106941]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r106941 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106941 Old status: new New status: ok Commit summary for MediaWiki.r106941: And I started wondering why I still see random behaviour even though I reverted local

[MediaWiki-CodeReview] [MediaWiki r106940]: Revision status changed

2011-12-21 Thread MediaWiki Mail
GWicke changed the status of MediaWiki.r106940 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106940 Old status: new New status: deferred Commit summary for MediaWiki.r106940: Handle noinclude and includeonly at start of line, so that syntax after it still matches as if

[MediaWiki-CodeReview] [MediaWiki r106939]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r106939 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106939 Old status: fixme New status: resolved Commit summary for MediaWiki.r106939: Rename variable and don't use skin

[MediaWiki-CodeReview] [MediaWiki r106884]: New comment added

2011-12-21 Thread MediaWiki Mail
Edokter posted a comment on MediaWiki.r106884. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106884#c28210 Commit summary for MediaWiki.r106884: Followup r105280 For bug 33139 Swapping colors in new diff color scheme * Modified diff colorscheme to yellow[orange]/blue[blue] - These

[MediaWiki-CodeReview] [MediaWiki r106789]: New comment added

2011-12-21 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r106789. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106789#c28211 Commit summary for MediaWiki.r106789: Split Special:PageTranslation styles into different module Nikerabbit's comment: Well, one ex is supposed to be height of x. But I

[MediaWiki-CodeReview] [MediaWiki r106789]: New comment added

2011-12-21 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r106789. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106789#c28212 Commit summary for MediaWiki.r106789: Split Special:PageTranslation styles into different module Nikerabbit's comment: I made a screenshot of the page at

[MediaWiki-CodeReview] [MediaWiki r106883]: New comment added

2011-12-21 Thread MediaWiki Mail
Jeroen De Dauw posted a comment on MediaWiki.r106883. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106883#c28213 Commit summary for MediaWiki.r106883: partial revert of r106872 after discussion with Brion on #mediawiki irc Jeroen De Dauw's comment: Having the deprecation notice

[MediaWiki-CodeReview] [MediaWiki r106929]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r106929 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106929 Old status: new New status: ok Commit summary for MediaWiki.r106929: Release notes for r105645. ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r105645]: New comment added, and revision status changed

2011-12-21 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r105645 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105645#c28214 Old Status: new New Status: ok Commit summary for MediaWiki.r105645: Add a configuration variable to work around the issue that has been reported at

[MediaWiki-CodeReview] [MediaWiki r100325]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r100325 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100325 Old status: new New status: ok Commit summary for MediaWiki.r100325: Moved contribs rev parent ID batch query into doBatchLookups()

[MediaWiki-CodeReview] [MediaWiki r100305]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r100305 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100305 Old status: new New status: ok Commit summary for MediaWiki.r100305: * Added a proper Pager::doBatchLookups() function * Made HistoryPager use a link batch via

[MediaWiki-CodeReview] [MediaWiki r106943]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Jack Phoenix changed the status of MediaWiki.r106943 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106943 Old status: deferred New status: ok Commit summary for MediaWiki.r106943: Fix indentation ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r94421]: New comment added

2011-12-21 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r94421. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94421#c28215 Commit summary for MediaWiki.r94421: (bug 26283) Previewing user JS/CSS pages doesn't load other user JS/CSS pages Hashar's comment: When loading the user CSS content you

[MediaWiki-CodeReview] [MediaWiki r94421]: New comment added

2011-12-21 Thread MediaWiki Mail
Catrope posted a comment on MediaWiki.r94421. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94421#c28216 Commit summary for MediaWiki.r94421: (bug 26283) Previewing user JS/CSS pages doesn't load other user JS/CSS pages Catrope's comment: We're dealing with site/user JS, though,

[MediaWiki-CodeReview] [MediaWiki r106946]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Raymond changed the status of MediaWiki.r106946 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106946 Old status: new New status: ok Commit summary for MediaWiki.r106946: follow up to r106883, typo fixes ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r106947]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Raymond changed the status of MediaWiki.r106947 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106947 Old status: new New status: ok Commit summary for MediaWiki.r106947: Adding USERINFO for grafzahl ___ MediaWiki-CodeReview

[Wikitech-l] Tag extension detecting its tag name?

2011-12-21 Thread Daniel Barrett
If I create a tag extension like this: $parser-setHook('foobar', 'myCallback'); function myCallback($input, $args, $parser, $frame) { return 'hello world'; } can the callback myCallback efficiently detect the name of the parser tag, foobar, that invoked it? The business problem is this: I

[MediaWiki-CodeReview] [MediaWiki r94881]: New comment added, and revision status changed

2011-12-21 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r94881 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94881#c28217 Old Status: new New Status: ok Commit summary for MediaWiki.r94881: Relative values of the Location header are incorrect as stated in RFC, however they

[MediaWiki-CodeReview] [MediaWiki r100386]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r100386 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100386 Old status: new New status: ok Commit summary for MediaWiki.r100386: [JSTesting] Fix dependencies. Of course jquery.qunit.completenessTest needs jquery.qunit

[MediaWiki-CodeReview] [MediaWiki r101293]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r101293 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101293 Old status: new New status: ok Commit summary for MediaWiki.r101293: rc_cur_time is obsolete; added comment ___

Re: [Wikitech-l] Tag extension detecting its tag name?

2011-12-21 Thread Happy Melon
I don't know if you can access that data directly from the extension callback, but you can certainly wire it in without *too* bad a hack: foreach( array( 'foo', 'bar', 'baz', quok' ) as $var ){ $parser-setHook( $var, WrapperClass::myCallback_$var ); } class WrapperClass { function

Re: [Wikitech-l] Tag extension detecting its tag name?

2011-12-21 Thread Chad
On Wed, Dec 21, 2011 at 10:47 AM, Happy Melon happy.melon.w...@gmail.com wrote: I don't know if you can access that data directly from the extension callback, but you can certainly wire it in without *too* bad a hack: foreach( array( 'foo', 'bar', 'baz', quok' ) as $var ){  $parser-setHook(

[MediaWiki-CodeReview] [MediaWiki r106952]: New comment added

2011-12-21 Thread MediaWiki Mail
Raymond posted a comment on MediaWiki.r106952. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106952#c28218 Commit summary for MediaWiki.r106952: r106944: Adding extension to translatewiki.net Raymond's comment: No Bogus Userpages was not intended but it's ok. Consistency tweaks

[MediaWiki-CodeReview] [MediaWiki r106952]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Jeroen De Dauw changed the status of MediaWiki.r106952 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106952 Old status: new New status: ok Commit summary for MediaWiki.r106952: r106944: Adding extension to translatewiki.net ___

[MediaWiki-CodeReview] [MediaWiki r106951]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Jeroen De Dauw changed the status of MediaWiki.r106951 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106951 Old status: new New status: ok Commit summary for MediaWiki.r106951: r106944: Consistency tweaks in preparation for adding extension to translatewiki.net

[MediaWiki-CodeReview] [MediaWiki r106928]: New comment added

2011-12-21 Thread MediaWiki Mail
Raymond posted a comment on MediaWiki.r106928. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106928#c28219 Commit summary for MediaWiki.r106928: Initial checkin of extension Offline, v0.6.1 Raymond's comment: {{messagedocumentation}} ___

[MediaWiki-CodeReview] [MediaWiki r106905]: New comment added

2011-12-21 Thread MediaWiki Mail
Jpostlethwaite posted a comment on MediaWiki.r106905. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106905#c28220 Commit summary for MediaWiki.r106905: Keeping form class names consistent. See r106903. Jpostlethwaite's comment: Doh! It is r106902. Thanks!

[MediaWiki-CodeReview] [MediaWiki r100165]: New comment added, and revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r100165 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100165#c28221 Old Status: new New Status: fixme Commit summary for MediaWiki.r100165: Adds API Module by cryptocoryne Bug 31723 Catrope's comment: pre +

[MediaWiki-CodeReview] [MediaWiki r100306]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r100306 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100306 Old status: new New status: ok Commit summary for MediaWiki.r100306: Followup r100165, fix SQL injections and conditions ___

[MediaWiki-CodeReview] [MediaWiki r100187]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r100187 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100187 Old status: new New status: ok Commit summary for MediaWiki.r100187: Followup r100165 and r100186: Formatting, requirement change, and removing mistakenly placed comma

[MediaWiki-CodeReview] [MediaWiki r100186]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r100186 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100186 Old status: new New status: ok Commit summary for MediaWiki.r100186: Followup r100165, fixing formatting per CR ___

[MediaWiki-CodeReview] [MediaWiki r100310]: New comment added, and revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r100310 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100310#c28222 Old Status: new New Status: fixme Commit summary for MediaWiki.r100310: Clean up some odd looping Catrope's comment: pre +

[MediaWiki-CodeReview] [MediaWiki r101329]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r101329 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101329 Old status: new New status: resolved Commit summary for MediaWiki.r101329: Fixing and improvement code of CheckUser API module

Re: [Wikitech-l] Tag extension detecting its tag name?

2011-12-21 Thread Daniel Barrett
Happy Melon suggests: foreach( array( 'foo', 'bar', 'baz', quok' ) as $var ){ $parser-setHook( $var, WrapperClass::myCallback_$var ); } ... Thanks for the suggestion. I am already doing something similar (see my original note about dynamically creating 20 callbacks today), but it's

[MediaWiki-CodeReview] [MediaWiki r106921]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106921 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106921 Old status: new New status: ok Commit summary for MediaWiki.r106921: Copy in mediawiki.debug.js/css added to Resources.php in r106062

[MediaWiki-CodeReview] [MediaWiki r106876]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106876 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106876 Old status: new New status: ok Commit summary for MediaWiki.r106876: FU r106514: Sanity check for empty sha1 values in the DB ___

[MediaWiki-CodeReview] [MediaWiki r106514]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106514 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106514 Old status: fixme New status: resolved Commit summary for MediaWiki.r106514: Expose rev_sha1/ar_sha1 to API (bug 21860) ___

[MediaWiki-CodeReview] [MediaWiki r93247]: New comment added, and revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r93247 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93247#c28223 Old Status: new New Status: ok Commit summary for MediaWiki.r93247: [ResourceLoader 2]: Add support for multiple loadScript sources Front-end: * New

[MediaWiki-CodeReview] [MediaWiki r94907]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r94907 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94907 Old status: new New status: resolved Commit summary for MediaWiki.r94907: Attempt to fix Bug 30216 - Improve language fallback loop detection. Made fallbacks a list per

[MediaWiki-CodeReview] [MediaWiki r106857]: New comment added, and revision status changed

2011-12-21 Thread MediaWiki Mail
SPQRobin changed the status of MediaWiki.r106857 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106857#c28224 Old Status: fixme New Status: new Commit summary for MediaWiki.r106857: Also handle URLs like index.php?title=Page. Fallback to main page if no

Re: [Wikitech-l] Tag extension detecting its tag name?

2011-12-21 Thread Brion Vibber
How inefficient is it, exactly? Is there a measurable performance impact? My recommendation under ideal circumstances would be to use closures (needs PHP 5.3) to wrap a parameter to your real callback; on older versions you could use create_function which is ugly, but probably not much worse for

[MediaWiki-CodeReview] [MediaWiki r106852]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106852 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106852 Old status: new New status: ok Commit summary for MediaWiki.r106852: Bug fix: missing vertical margins associated with top-level class

Re: [Wikitech-l] Missing wiki redirect script

2011-12-21 Thread Robin Pepermans
Fixed in r106957. I apparently made the commit too quickly, I also forgot a } with elseif. For the /variant/ instead of /wiki/, I think it will work for the old secure server but for the normal URLs there is a preg_replace '/^\/wiki\//' so it won't recognise a variant there (it would default to

[MediaWiki-CodeReview] [MediaWiki r106895]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106895 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106895 Old status: new New status: ok Commit summary for MediaWiki.r106895: follow-up to r106754 - using strict comparison, adding logic for editing existing pages, changing

[MediaWiki-CodeReview] [MediaWiki r106754]: New comment added, and revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106754 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106754#c28225 Old Status: new New Status: resolved Commit summary for MediaWiki.r106754: adding sectiontitle/wgSectionTitle as a new parameter for page

[MediaWiki-CodeReview] [MediaWiki r106884]: New comment added

2011-12-21 Thread MediaWiki Mail
Aaron Schulz posted a comment on MediaWiki.r106884. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106884#c28226 Commit summary for MediaWiki.r106884: Followup r105280 For bug 33139 Swapping colors in new diff color scheme * Modified diff colorscheme to yellow[orange]/blue[blue] -

Re: [Wikitech-l] Nagios parser

2011-12-21 Thread Ryan Lane
I wrote a nagios parser for wmflabs, it downloads instance list from labsconsole and using simple application it parses it and generate nagios configs, it's currently running periodicaly on nagios.wmflabs.org and thanks to that nagios is updated when you create a new instance, it parses the

Re: [Wikitech-l] Code review thoughts: module reviewers

2011-12-21 Thread Jeremy Postlethwaite
It might be helpful to list a primary and a few secondaries on some areas. On Wed, Dec 21, 2011 at 12:44 AM, Roan Kattouw roan.katt...@gmail.comwrote: On Wed, Dec 21, 2011 at 12:01 AM, Brion Vibber bvib...@wikimedia.org wrote: Often, little things are suitable for many people to look at, but

[MediaWiki-CodeReview] [MediaWiki r106957]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106957 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106957 Old status: new New status: ok Commit summary for MediaWiki.r106957: Follow-up r106857: forgot variables in html, fix {} with elseif, and avoid some undefined indexes. I

[MediaWiki-CodeReview] [MediaWiki r106857]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106857 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106857 Old status: new New status: resolved Commit summary for MediaWiki.r106857: Also handle URLs like index.php?title=Page. Fallback to main page if no title found. Also do

[MediaWiki-CodeReview] [MediaWiki r97778]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r97778 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97778 Old status: new New status: resolved Commit summary for MediaWiki.r97778: * Changing static page to dynamic result according to the given URL. ** Non-existing language

[MediaWiki-CodeReview] [MediaWiki r97834]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r97834 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97834 Old status: new New status: resolved Commit summary for MediaWiki.r97834: * fixing the sliced part of the array ___

[MediaWiki-CodeReview] [MediaWiki r106562]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106562 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106562 Old status: new New status: resolved Commit summary for MediaWiki.r106562: * Remove unneeded whitespace * Fix redirect where the slash in xyz.project.org/ is seen as a

[MediaWiki-CodeReview] [MediaWiki r106567]: New comment added

2011-12-21 Thread MediaWiki Mail
IAlex posted a comment on MediaWiki.r106567. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106567#c28227 Commit summary for MediaWiki.r106567: * Merged WikiPage::updateRestrictions() and Title::updateTitleProtection() into WikiPage::doUpdateRestrictions(); older methods still work

[MediaWiki-CodeReview] [MediaWiki r106960]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r106960 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106960 Old status: new New status: ok Commit summary for MediaWiki.r106960: Use accessor instead of the member variable directly and factorise the calls to it

[MediaWiki-CodeReview] [MediaWiki r106782]: New comment added, and revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106782 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106782#c28228 Old Status: new New Status: fixme Commit summary for MediaWiki.r106782: Resourceloader-ify CSS/JS from CentralAuth Kill $wgCentralAuthStyleVersion

[MediaWiki-CodeReview] [MediaWiki r106783]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106783 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106783 Old status: new New status: ok Commit summary for MediaWiki.r106783: Correct the error dialog display. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r106795]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106795 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106795 Old status: new New status: ok Commit summary for MediaWiki.r106795: Fix boolean fail from r106784 ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r106785]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106785 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106785 Old status: new New status: ok Commit summary for MediaWiki.r106785: Remove # from r106784 and fix @throws to list the correct exception which could be thrown

[MediaWiki-CodeReview] [MediaWiki r106962]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r106962 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106962 Old status: new New status: ok Commit summary for MediaWiki.r106962: Use LinkCache::singleton()-clear() instead of using a local variable so that I can see what

[MediaWiki-CodeReview] [MediaWiki r106784]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106784 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106784 Old status: new New status: resolved Commit summary for MediaWiki.r106784: * (bug 31170) centralauth needs a read-only db flag that allows queries to go to lagged

[MediaWiki-CodeReview] [MediaWiki r106787]: New comment added, and revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106787 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106787#c28229 Old Status: new New Status: fixme Commit summary for MediaWiki.r106787: Move maintenance scripts into new maintenance dir Catrope's comment: pre

[MediaWiki-CodeReview] [MediaWiki r106788]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106788 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106788 Old status: new New status: ok Commit summary for MediaWiki.r106788: Don't manually replace ' ' with '_', use User::getTitleKey

[MediaWiki-CodeReview] [MediaWiki r106963]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r106963 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106963 Old status: new New status: ok Commit summary for MediaWiki.r106963: Declare constant default values directly in the class definition and removed the constructor since

[MediaWiki-CodeReview] [MediaWiki r106964]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r106964 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106964 Old status: new New status: ok Commit summary for MediaWiki.r106964: (bug 33246) News icon shown for news:// URLs but not for news: URLs. Patch by Erwin Dokter

[MediaWiki-CodeReview] [MediaWiki r102992]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r102992 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102992 Old status: new New status: resolved Commit summary for MediaWiki.r102992: MFT r101940 ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r106578]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106578 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106578 Old status: new New status: ok Commit summary for MediaWiki.r106578: For bug 33240, svn copy in sort_down.gif and sort_up.gif from REL1_17 References in shared.css

[MediaWiki-CodeReview] [MediaWiki r106579]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106579 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106579 Old status: new New status: ok Commit summary for MediaWiki.r106579: * (bug 33240) Sort images are missing but references in css.

[MediaWiki-CodeReview] [MediaWiki r106616]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106616 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106616 Old status: new New status: ok Commit summary for MediaWiki.r106616: SFH_OBJECT_ARGS was added pre 1.12... Kill ancient back compat, and code where unused

[MediaWiki-CodeReview] [MediaWiki r106618]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106618 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106618 Old status: new New status: ok Commit summary for MediaWiki.r106618: Flesh out documentation Remove some more 1.12 back compat code

[MediaWiki-CodeReview] [MediaWiki r106717]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106717 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106717 Old status: new New status: ok Commit summary for MediaWiki.r106717: cmdir=desc so we can run it at the same time as rotatebot without stopping it :D

[MediaWiki-CodeReview] [MediaWiki r106961]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Brion VIBBER changed the status of MediaWiki.r106961 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106961 Old status: new New status: ok Commit summary for MediaWiki.r106961: * Use local context to get messages * Use Language::userTimeAndDate() and related instead of

[MediaWiki-CodeReview] [MediaWiki r106967]: Revision status changed

2011-12-21 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r106967 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106967 Old status: new New status: ok Commit summary for MediaWiki.r106967: Code style: move a couple htmlspecialchars() down to usage so it's clear where escaping happens

  1   2   3   >