Re: [Wikitech-l] I'd prefer that you didn't submit this

2012-03-30 Thread Trevor Parscal
No offense to those who have chimed in, but seriously, this is a silly discussion. Do we really have the bandwidth to be 15 messages deep on this thread? - Trevor On Thu, Mar 29, 2012 at 5:24 PM, Tim Starling tstarl...@wikimedia.orgwrote: On 29/03/12 00:10, Chad wrote: Hi everyone,

Re: [Wikitech-l] Email addresses for wikimedians

2012-03-30 Thread Antoine Musso
Petr Bena wrote: Lot of volunteers are using email to communicate when they discuss wikimedia related issues. Even if it's not a big problem to use personal email there, lot of people, especially administrators do not want to uncover their personal email. On way easy way is to set up another

Re: [Wikitech-l] Email addresses for wikimedians

2012-03-30 Thread K. Peachey
On Fri, Mar 30, 2012 at 7:38 AM, Krinkle krinklem...@gmail.com wrote: Also, when we do find a good hostname to use, I think it should be universal and tied to a SUL username (not per-wiki or per-project), so it shouldn't contain the name of a project (wikipedia, wiktionary, commons, ..) and

[MediaWiki-CodeReview] [MediaWiki r114628]: Revision status changed

2012-03-30 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r114628 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114628 Old status: new New status: ok Commit summary for MediaWiki.r114628: [[Gerrit:3928]]: Add new special page for translation ___

[Wikitech-l] jQuery update policy

2012-03-30 Thread Amir E. Aharoni
Hi, I made a little localization fix to the jQuery.ui datepicker, which is used by the Upload Wizard. I submitted it upstream through GitHub and it was merged there. Krinkle says that jQuery is supposed to be only modified upstream, and that is a Good Thing. What is our policy for actually

Re: [Wikitech-l] Changeset differ (was Re: Committing followups: please no --amend)

2012-03-30 Thread Antoine Musso
Le 29/03/12 13:33, Marcin Cieslak a écrit : Side note: I have a small tool (https://github.com/saper/gerrit-fetch-all) to fetch all changesets from gerrit and branch the as change/3841/4. Then you can diff your changesets locally, in the git repository. You could have created a gist to

[MediaWiki-CodeReview] [pywikipedia r10049]: Revision status changed

2012-03-30 Thread MediaWiki Mail
Xqt changed the status of pywikipedia.r10049 to ok URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10049 Old status: new New status: ok Commit summary for pywikipedia.r10049: Update noreferences.py for zh.wikipedia Patch by YFdyh000 yfdyh...@users.sourceforge.net Reference:

[MediaWiki-CodeReview] [pywikipedia r10050]: Revision status changed

2012-03-30 Thread MediaWiki Mail
Xqt changed the status of pywikipedia.r10050 to ok URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10050 Old status: new New status: ok Commit summary for pywikipedia.r10050: Adding new :lez: language ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [pywikipedia r10051]: New comment added, and revision status changed

2012-03-30 Thread MediaWiki Mail
Xqt changed the status of pywikipedia.r10051 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10051#c32577 Old Status: new New Status: fixme Commit summary for pywikipedia.r10051: Update namespaces for kv (see bug#3512044) Xqt's comment: old namespace

[MediaWiki-CodeReview] [pywikipedia r10052]: Revision status changed

2012-03-30 Thread MediaWiki Mail
Xqt changed the status of pywikipedia.r10052 to ok URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10052 Old status: new New status: ok Commit summary for pywikipedia.r10052: Adding namespaces for lezwiki (equal to Russian at the moment)

[MediaWiki-CodeReview] [pywikipedia r10053]: Revision status changed

2012-03-30 Thread MediaWiki Mail
Xqt changed the status of pywikipedia.r10053 to ok URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10053 Old status: new New status: ok Commit summary for pywikipedia.r10053: Adding sl.wikiversity namespaces ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [pywikipedia r10054]: Revision status changed

2012-03-30 Thread MediaWiki Mail
Xqt changed the status of pywikipedia.r10054 to ok URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10054 Old status: new New status: ok Commit summary for pywikipedia.r10054: Adding two new Russian namespaces ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [pywikipedia r10040]: Revision status changed

2012-03-30 Thread MediaWiki Mail
Xqt changed the status of pywikipedia.r10040 to ok URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10040 Old status: new New status: ok Commit summary for pywikipedia.r10040: Removed unused getDefaultTextColorInWindows function. ___

[MediaWiki-CodeReview] [pywikipedia r10044]: Revision status changed

2012-03-30 Thread MediaWiki Mail
Xqt changed the status of pywikipedia.r10044 to ok URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10044 Old status: new New status: ok Commit summary for pywikipedia.r10044: Fixes to breakers terminal_interface_unix in r10043. Note to self: when fixing bugs, don't forget to

[MediaWiki-CodeReview] [pywikipedia r10045]: Revision status changed

2012-03-30 Thread MediaWiki Mail
Xqt changed the status of pywikipedia.r10045 to ok URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10045 Old status: new New status: ok Commit summary for pywikipedia.r10045: Updated keyword substitution for userinterfaces\ ___

[MediaWiki-CodeReview] [pywikipedia r10046]: Revision status changed

2012-03-30 Thread MediaWiki Mail
Xqt changed the status of pywikipedia.r10046 to ok URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10046 Old status: new New status: ok Commit summary for pywikipedia.r10046: - Consistent use of self.encoding fixes output on unix (without colors) and input on windows (when

[MediaWiki-CodeReview] [pywikipedia r10047]: Revision status changed

2012-03-30 Thread MediaWiki Mail
Xqt changed the status of pywikipedia.r10047 to ok URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10047 Old status: new New status: ok Commit summary for pywikipedia.r10047: 1. Use the configuration value of the encoding for transliteration purposes, even if it is overwritten in

[MediaWiki-CodeReview] [pywikipedia r10048]: Revision status changed

2012-03-30 Thread MediaWiki Mail
Xqt changed the status of pywikipedia.r10048 to ok URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10048 Old status: new New status: ok Commit summary for pywikipedia.r10048: Reverted my own change in usage of encodings - we should put that advise of using a different font for the

[MediaWiki-CodeReview] [pywikipedia r10055]: Revision status changed

2012-03-30 Thread MediaWiki Mail
Xqt changed the status of pywikipedia.r10055 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10055 Old status: new New status: deferred Commit summary for pywikipedia.r10055: update language_by_size ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [pywikipedia r10056]: Revision status changed

2012-03-30 Thread MediaWiki Mail
Xqt changed the status of pywikipedia.r10056 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10056 Old status: new New status: deferred Commit summary for pywikipedia.r10056: update language_by_size from trunk r10055 ___

[MediaWiki-CodeReview] [MediaWiki r114626]: Revision status changed

2012-03-30 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r114626 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114626 Old status: new New status: ok Commit summary for MediaWiki.r114626: r114622: Extension not longer enabled on WMF cluster ___

[MediaWiki-CodeReview] [pywikipedia r10051]: New comment added

2012-03-30 Thread MediaWiki Mail
Bináris posted a comment on pywikipedia.r10051. URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10051#c32578 Commit summary for pywikipedia.r10051: Update namespaces for kv (see bug#3512044) Bináris's comment: Fixed in r10057, thanks.

[MediaWiki-CodeReview] [pywikipedia r10057]: Revision status changed

2012-03-30 Thread MediaWiki Mail
Xqt changed the status of pywikipedia.r10057 to ok URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10057 Old status: new New status: ok Commit summary for pywikipedia.r10057: Follow-up to r10051 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [pywikipedia r10051]: Revision status changed

2012-03-30 Thread MediaWiki Mail
Xqt changed the status of pywikipedia.r10051 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10051 Old status: fixme New status: resolved Commit summary for pywikipedia.r10051: Update namespaces for kv (see bug#3512044) ___

[MediaWiki-CodeReview] [pywikipedia r10058]: Revision status changed

2012-03-30 Thread MediaWiki Mail
Xqt changed the status of pywikipedia.r10058 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10058 Old status: new New status: deferred Commit summary for pywikipedia.r10058: update namespace aliases for lez-wiki ___

Re: [Wikitech-l] I'd prefer that you didn't submit this

2012-03-30 Thread Tim Starling
The doctrine of toleration requires a positive as well as a negative statement. It is not only wrong to burn a man on account of his creed, but it is right to encourage the open avowal and defence of every opinion sincerely maintained. Every man who says frankly and fully what he thinks is so far

Re: [Wikitech-l] I'd prefer that you didn't submit this

2012-03-30 Thread Petr Bena
I disagree, the previous message would sound really bit offensive to people who submitted the patch, and is nothing motivating for the volunteers who spend their time trying to help with the project. Imagine you send a code to open source project in a good faith and get the reply: I'd be more

Re: [Wikitech-l] I'd prefer that you didn't submit this

2012-03-30 Thread Chad
On Fri, Mar 30, 2012 at 2:10 AM, Trevor Parscal tpars...@wikimedia.org wrote: No offense to those who have chimed in, but seriously, this is a silly discussion. I personally don't care what it says (the development version currently says THIS IS THE WORST PATCH EVER!!!). I was fine with I'd

Re: [Wikitech-l] I'd prefer that you didn't submit this

2012-03-30 Thread Chad
On Thu, Mar 29, 2012 at 8:24 PM, Tim Starling tstarl...@wikimedia.org wrote: I don't really want Gerrit putting words into my mouth regardless of how nice they sound. There will always be cases where the phrase is inappropriate and offputting, regardless of which one you choose. How about Set

Re: [Wikitech-l] Email addresses for wikimedians

2012-03-30 Thread Chad
On Fri, Mar 30, 2012 at 12:49 AM, Mono monom...@gmail.com wrote: This is mostly a solution looking for a problem. I agree, except for Labs/Git/etc users where there's actually a demonstrable need for this. -Chad ___ Wikitech-l mailing list

Re: [Wikitech-l] Email addresses for wikimedians

2012-03-30 Thread Thomas Morton
However that means that after you reply, your original e-mailaddress is visible. In which case there is no advantage to using an alias over simply using [[Special:EmailUser]], which is effectively also an alias for the first mail. Not at all. You can send mail from any address you choose;

Re: [Wikitech-l] I'd prefer that you didn't submit this

2012-03-30 Thread Antoine Musso
Le 30/03/12 13:18, Chad a wrote : THIS IS THE WORST PATCH EVER!!! Does it automatically abandon the previous nominee? That would great to have since we will be guaranteed to only have one bad patch at any time. -- Antoine hashar Musso ___

Re: [Wikitech-l] I'd prefer that you didn't submit this

2012-03-30 Thread Antoine Musso
Le 30/03/12 08:10, Trevor Parscal a écrit : No offense to those who have chimed in, but seriously, this is a silly discussion. I guess that is how our community has always ran. That is very much alike the diff colors drama we had when deploying 1.19 on enwiki. Do we really have the bandwidth

Re: [Wikitech-l] I'd prefer that you didn't submit this

2012-03-30 Thread Chad
On Fri, Mar 30, 2012 at 7:58 AM, Antoine Musso hashar+...@free.fr wrote: Le 30/03/12 08:10, Trevor Parscal a écrit : No offense to those who have chimed in, but seriously, this is a silly discussion. I guess that is how our community has always ran. That is very much alike the diff colors

Re: [Wikitech-l] I'd prefer that you didn't submit this

2012-03-30 Thread Krinkle
On Mar 30, 2012, at 2:24 AM, Tim Starling wrote: On 29/03/12 00:10, Chad wrote: Hi everyone, There's been some comments that the phrasing for a -1 vote in Gerrit (I'd prefer that you didn't submit this) is kind of personal and we can do better. I did some testing and this is totally

Re: [Wikitech-l] I'd prefer that you didn't submit this

2012-03-30 Thread Chad
On Fri, Mar 30, 2012 at 8:49 AM, Krinkle krinklem...@gmail.com wrote: Can we just set it to an empty string and let the numbers and hand-written comment speak for themselves? I think this will be more confusing. You need some text for the radio field. In any case these summaries are not meant

Re: [Wikitech-l] I'd prefer that you didn't submit this

2012-03-30 Thread Chad
On Fri, Mar 30, 2012 at 8:49 AM, Krinkle krinklem...@gmail.com wrote: I couldn't agree more. So far all proposal make implications that sometimes simply aren't appropriate. Either they leave no room for fixing it (Don't submit it), or are too much foccused on fixing something small, but

[Wikitech-l] 17 hours to submit a talk to Open Source Bridge, get WMF subsidy

2012-03-30 Thread Sumana Harihareswara
http://opensourcebridge.org/blog/2012/03/cfp-deadline-extended-until-march-30th/ You (yes you, no matter where you live or who you work/don't work for) have less than a day to submit a talk about Wikimedia stuff to Open Source Bridge, a great open source conference. If your talk gets accepted,

Re: [Wikitech-l] I'd prefer that you didn't submit this

2012-03-30 Thread Krinkle
On Mar 30, 2012, at 3:07 PM, Chad wrote: On Fri, Mar 30, 2012 at 8:49 AM, Krinkle krinklem...@gmail.com wrote: Can we just set it to an empty string and let the numbers and hand-written comment speak for themselves? I think this will be more confusing. You need some text for the radio

Re: [Wikitech-l] jQuery update policy

2012-03-30 Thread Krinkle
On Mar 30, 2012, at 10:14 AM, Amir E. Aharoni wrote: Hi, I made a little localization fix to the jQuery.ui datepicker, which is used by the Upload Wizard. I submitted it upstream through GitHub and it was merged there. Krinkle says that jQuery is supposed to be only modified upstream,

Re: [Wikitech-l] I'd prefer that you didn't submit this

2012-03-30 Thread Chad
On Fri, Mar 30, 2012 at 9:27 AM, Krinkle krinklem...@gmail.com wrote: On Mar 30, 2012, at 3:07 PM, Chad wrote: On Fri, Mar 30, 2012 at 8:49 AM, Krinkle krinklem...@gmail.com wrote: Can we just set it to an empty string and let the numbers and hand-written comment speak for themselves? I

[MediaWiki-CodeReview] [MediaWiki r114622]: New comment added

2012-03-30 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r114622. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114622#c32579 Commit summary for MediaWiki.r114622: Remove PrefSwitch/PrefStats Add some other revisions to merge Krinkle's comment: pre+ array( 'rev' = r112080, 'base' =

[Wikitech-l] The confusion around QA, nice article

2012-03-30 Thread Chris McMahon
This article was making its way around the testosphere this morning to much approval. Although I question some of the numbers cited, I like the overall description a lot, and since I have been having so many discussions about QA on various projects, I thought it would be of interest to wikitech:

Re: [Wikitech-l] The confusion around QA, nice article (wican: cmcma...@wikimedia.org exclusive)

2012-03-30 Thread Jim Laurino
On 03/30/2012 10:08:00 AM, Chris McMahon - cmcma...@wikimedia.org wrote: This article was making its way around the testosphere this morning to much approval. Although I question some of the numbers cited, I like the overall description a lot, and since I have been having so many discussions

[Wikitech-l] Please register for the Berlin hackathon - June 1-3, 2012

2012-03-30 Thread Sumana Harihareswara
I invite you to the yearly Berlin hackathon. It's 1-3 June and registration is now open. If you need financial assistance or help with hotel/hostel, just mention it in the registration form. https://wmberlin.eventbrite.com/ This is the premier event for the MediaWiki and Wikimedia technical

Re: [Wikitech-l] jQuery update policy

2012-03-30 Thread Ryan Kaldari
Oops, I just backported a bugfix from jQuery's development trunk to MW a few weeks ago. It involved an obvious bug in a core jQuery function that was causing a bug in MW 1.19. The only alternatives were to locally patch some jQuery plug-ins or live with the weird behavior, so either way we were

Re: [Wikitech-l] I'd prefer that you didn't submit this

2012-03-30 Thread Platonides
Tim Starling wrote: I don't really want Gerrit putting words into my mouth regardless of how nice they sound. There will always be cases where the phrase is inappropriate and offputting, regardless of which one you choose. I agree with Tim here, I was thinking the same on this thread. Gerrit

[MediaWiki-CodeReview] [MediaWiki r114632]: Revision status changed

2012-03-30 Thread MediaWiki Mail
Raymond changed the status of MediaWiki.r114632 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114632 Old status: new New status: ok Commit summary for MediaWiki.r114632: Remove r from r114622 ___ MediaWiki-CodeReview mailing list

[Wikitech-l] Gerrit slowness (was: Open git issues)

2012-03-30 Thread Platonides
On 28/03/12 18:10, Antoine Musso wrote: Gerrit slowness: I do not have that much an issues. Possible root causes could be: - you have a slow computer - your network connection is bad - Gerrit client interface is badly programmed - Gerrit server is overloaded Or that might just be

Re: [Wikitech-l] Open git issues

2012-03-30 Thread Platonides
On 28/03/12 18:10, Antoine Musso wrote: scan for i18n: Can this be somehow scripted / made more automatic? We should probably eastablish a list of recurrent issues then have a script to automatically analyse files to find possible culprit. Two possibles examples comes to mind: - messages

[MediaWiki-CodeReview] [Wikimedia r1571]: New comment added, and revision status changed

2012-03-30 Thread MediaWiki Mail
Jpostlethwaite changed the status of Wikimedia.r1571 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1571#c32580 Old Status: new New Status: fixme Commit summary for Wikimedia.r1571: Applying civicrm-recurring.patch from CRM-9459. Jpostlethwaite's comment:

[MediaWiki-CodeReview] [Wikimedia r1572]: New comment added

2012-03-30 Thread MediaWiki Mail
Jpostlethwaite posted a comment on Wikimedia.r1572. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1572#c32581 Commit summary for Wikimedia.r1572: Fixed logic in a template. See r1571. Jpostlethwaite's comment: This was attached to the issue at CiviCRM:

[MediaWiki-CodeReview] [Wikimedia r1573]: New comment added

2012-03-30 Thread MediaWiki Mail
Jpostlethwaite posted a comment on Wikimedia.r1573. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1573#c32582 Commit summary for Wikimedia.r1573: Adds missing failure_count and failure_retry_date for rendering data.. See r1571. Jpostlethwaite's comment: This was attached to the

[MediaWiki-CodeReview] [MediaWiki r114620]: New comment added

2012-03-30 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r114620. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114620#c32583 Commit summary for MediaWiki.r114620: Add JavasScript and API code for stats navigation Nikerabbit's comment: pre + return __CLASS__ . ': $Id:

[MediaWiki-CodeReview] [MediaWiki r114616]: New comment added

2012-03-30 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r114616. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114616#c32584 Commit summary for MediaWiki.r114616: added the filter form, not hooked up to anything yet. forgot to checkin the parts of the gradient in SpecialPageTriage... oops.

Re: [Wikitech-l] The confusion around QA, nice article (wican: cmcma...@wikimedia.org exclusive)

2012-03-30 Thread Platonides
On 30/03/12 17:17, Jim Laurino wrote: I also remember Dijkstra, who wrote, long ago now, no amount of testing can prove the absence of defects, and made the unassailable case, at least for me, that defects had to be prevented by design. This is essentially the discovery that the author of the

[Wikitech-l] Run batch actions on gerrit changesets from the command line with DippyBird

2012-03-30 Thread Arthur Richards
I whipped together a php script this afternoon that allows you to make arbitrary queries for Gerrit change sets, and then perform bulk actions on the resulting change sets from the command line. Currently it only supports doing a bulk 'submit' (with approve +2 and verify +1), but it won't take

Re: [Wikitech-l] Run batch actions on gerrit changesets from the command line with DippyBird

2012-03-30 Thread Arthur Richards
ps thanks to dave and patrick for the name! On Fri, Mar 30, 2012 at 4:49 PM, Arthur Richards aricha...@wikimedia.orgwrote: I whipped together a php script this afternoon that allows you to make arbitrary queries for Gerrit change sets, and then perform bulk actions on the resulting change

Re: [Wikitech-l] The confusion around QA, nice article (wican: cmcma...@wikimedia.org exclusive)

2012-03-30 Thread wican . x . jimlaur
On 03/30/2012 05:58:49 PM, Platonides - platoni...@gmail.com wrote: On 30/03/12 17:17, Jim Laurino wrote: I also remember Dijkstra, who wrote, long ago now, no amount of testing can prove the absence of defects, and made the unassailable case, at least for me, that defects had to be prevented

Re: [Wikitech-l] The confusion around QA, (wican: to exclusive) nice article (wican: cmcma...@wikimedia.org exclusive)

2012-03-30 Thread Jim Laurino
On 03/30/2012 05:58:49 PM, Platonides - platoni...@gmail.com wrote: On 30/03/12 17:17, Jim Laurino wrote: I also remember Dijkstra, who wrote, long ago now, no amount of testing can prove the absence of defects, and made the unassailable case, at least for me, that defects had to be prevented