Re: [Wikitech-l] UploadWizard changes live on Commons

2012-05-25 Thread Strainu
2012/5/25 Brion Vibber br...@wikimedia.org: * files now start uploading immediately when selected (this can be disabled server-side if there are problems with it) Yeeey... less wasted time. * improved category input fields What does that mean, exactly? Is there a bug associated with that?

[MediaWiki-CodeReview] [MediaWiki r115429]: New comment added, and revision status changed

2012-05-25 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r115429 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115429#c32821 Old Status: new New Status: fixme Commit summary for MediaWiki.r115429: style of code Nikerabbit's comment: I think style guideline says to

Re: [Wikitech-l] UploadWizard changes live on Commons

2012-05-25 Thread Sumana Harihareswara
On 05/25/2012 03:06 AM, Strainu wrote: 2012/5/25 Brion Vibber br...@wikimedia.org: * files now start uploading immediately when selected (this can be disabled server-side if there are problems with it) Yeeey... less wasted time. Yes! Yay! * improved category input fields What does that

[MediaWiki-CodeReview] [MediaWiki r115429]: New comment added

2012-05-25 Thread MediaWiki Mail
Petrb posted a comment on MediaWiki.r115429. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115429#c32822 Commit summary for MediaWiki.r115429: style of code Petrb's comment: line? ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r115429]: New comment added

2012-05-25 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r115429. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115429#c32823 Commit summary for MediaWiki.r115429: style of code Krinkle's comment: Nearly every line, actually. I think the problem is that it appears you start counting the extra tab

[MediaWiki-CodeReview] [MediaWiki r115429]: New comment added

2012-05-25 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r115429. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115429#c32824 Commit summary for MediaWiki.r115429: style of code Krinkle's comment: [[CC|.. and the closing bracket should align]] with the opening statement.

Re: [Wikitech-l] Notes from the Gerrit Hackathon

2012-05-25 Thread Chad
On Thu, May 24, 2012 at 9:24 PM, Rob Lanphier ro...@wikimedia.org wrote: Hi folks, Chad alerted me to the notes of the Gerrit Hackathon, which happened May 7-11: https://groups.google.com/forum/#!msg/repo-discuss/kEL3FPT2rLo/w39qjsmnrwwJ No one from WMF was there, but I thought you all might

[MediaWiki-CodeReview] [MediaWiki r115429]: New comment added

2012-05-25 Thread MediaWiki Mail
Petrb posted a comment on MediaWiki.r115429. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115429#c32825 Commit summary for MediaWiki.r115429: style of code Petrb's comment: ah, I see, from guideline this isn't clear, the example there has lines so short that it actually seems to

[MediaWiki-CodeReview] [MediaWiki r102566]: New comment added

2012-05-25 Thread MediaWiki Mail
Mormegil posted a comment on MediaWiki.r102566. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102566#c32826 Commit summary for MediaWiki.r102566: Adding bt-button and rt-button to interface messages. Mormegil's comment: The more interesting thing is that the

[Wikitech-l] Desktop upload tool

2012-05-25 Thread Platonides
As some of you are already aware, I'm doing for this GSoC a Desktop tool for conveniently uploading images to commons. http://thread.gmane.org/gmane.org.wikimedia.wikilovesmonuments/2641 How can you help with this? a) Propose a cool name for this tool b) Suggest new functionalities/requisites

Re: [Wikitech-l] Desktop upload tool

2012-05-25 Thread John
One thing I have done quite a bit of was Image modification. Everything from watermark removal to coping to rotating. When Im on a spur of watermark removal, it would be awesome if I could just point the program to a directory of fixed files, set a upload summary and have the bot upload those

Re: [Wikitech-l] HTMLMultiSelectField as select multiple=multiple/

2012-05-25 Thread Daniel Werner
Message: 8 Date: Wed, 23 May 2012 21:49:57 +0200 From: Platonides platoni...@gmail.com To: wikitech-l@lists.wikimedia.org Subject: Re: [Wikitech-l] HTMLMultiSelectField as select multiple=multiple/ Message-ID: jpjf1s$b23$1...@dough.gmane.org Content-Type: text/plain; charset=ISO-8859-1

[Wikitech-l] about bots

2012-05-25 Thread Fabian Kaelin
Hi, Sorry about the length of this mail, it reads faster than it looks. I am working with the recentchanges and the cu_changes (checkuser) mediawiki SQL tables. I would like to be able to filter bot activity, unfortunately I am increasingly confused. Things that I think I know: - In the

Re: [Wikitech-l] about bots

2012-05-25 Thread Bartosz Dziewoński
2012/5/25 Fabian Kaelin fkae...@wikimedia.org: 1. *What is the meaning/purpose of the rc_bot flag on recentchanges? *There are entries in the recentchanges table from editors that are flagged as bots in the user_groups and the other bot tables but still have the rc_bot flag set to 0. I don't

Re: [Wikitech-l] about bots

2012-05-25 Thread Ryan Kaldari
The bot flag is rather confusing since edits can be marked as bot edits or non-bot edits regardless of whether they are actually coming from a bot. The edit API accepts a 'bot' or 'notbot' parameter and I believe this is what actually gets recorded in the recentchanges table. Obviously this

[Wikitech-l] ResourceManager and Javascript in Mediawiki

2012-05-25 Thread Derric Atzrott
I've been doing some reading recently on the MediaWiki wiki about ResourceManager and how to use it to use JavaScript in MediaWiki extensions. Perhaps because it is new the documentation is not complete, or perhaps I just didn't quite understand the examples, but either way, I've been left quite

Re: [Wikitech-l] about bots

2012-05-25 Thread Roan Kattouw
On Fri, May 25, 2012 at 11:40 AM, Ryan Kaldari rkald...@wikimedia.org wrote: The bot flag is rather confusing since edits can be marked as bot edits or non-bot edits regardless of whether they are actually coming from a bot. The edit API accepts a 'bot' or 'notbot' parameter and I believe this

Re: [Wikitech-l] ResourceManager and Javascript in Mediawiki

2012-05-25 Thread Roan Kattouw
On Fri, May 25, 2012 at 12:32 PM, Derric Atzrott datzr...@alizeepathology.com wrote: I've been doing some reading recently on the MediaWiki wiki about ResourceManager and how to use it to use JavaScript in MediaWiki extensions. Perhaps because it is new the documentation is not complete, or

Re: [Wikitech-l] ResourceManager and Javascript in Mediawiki

2012-05-25 Thread Derric Atzrott
Could you tell us what you're confused about specifically? Just saying I don't understand, please explain everything is not very helpful. Also, if you've been searching for ResourceManager, you may not have found the docs you were looking for, because the subsystem is called ResourceLoader.

Re: [Wikitech-l] ResourceManager and Javascript in Mediawiki

2012-05-25 Thread Roan Kattouw
On Fri, May 25, 2012 at 12:47 PM, Derric Atzrott datzr...@alizeepathology.com wrote: I have read the Migration Guide for Extension Developers; I actually still have it open right now.  It lead me to believe that if I were to do the following, I could expect to see some sort of result. Add the

Re: [Wikitech-l] ResourceManager and Javascript in Mediawiki

2012-05-25 Thread Derric Atzrott
Ah. That would do it. I had forgotten to mention this, but in SpecialMasterPlanForm.php I have a line $wgOut-addModules( 'ext.MasterPlanForm.core'); but if I need put that in a BeforePageDisplay hook, that would explain it. If I understand correctly then, removing the aforementioned line from

Re: [Wikitech-l] ResourceManager and Javascript in Mediawiki

2012-05-25 Thread Roan Kattouw
On May 25, 2012 10:11 PM, Derric Atzrott datzr...@alizeepathology.com wrote: Ah. That would do it. I had forgotten to mention this, but in SpecialMasterPlanForm.php I have a line $wgOut-addModules( 'ext.MasterPlanForm.core'); but if I need put that in a BeforePageDisplay hook, that would

Re: [Wikitech-l] ResourceManager and Javascript in Mediawiki

2012-05-25 Thread Derric Atzrott
Hmmm does not appear to work for me. I added window.alert(Test); to the JavaScript file to make sure. The relevant sections of each file are listed out below. All of these sections are in sections of their respective files that are being executed. SpecialMasterPlanForm.php:

Re: [Wikitech-l] Desktop upload tool

2012-05-25 Thread Platonides
On 25/05/12 17:55, John wrote: One thing I have done quite a bit of was Image modification. Everything from watermark removal to coping to rotating. When Im on a spur of watermark removal, it would be awesome if I could just point the program to a directory of fixed files, set a upload summary

[MediaWiki-CodeReview] [MediaWiki r115434]: Revision status changed

2012-05-25 Thread MediaWiki Mail
Krinkle changed the status of MediaWiki.r115434 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115434 Old status: new New status: ok Commit summary for MediaWiki.r115434: Update indentation and some other coding style related thingies. No functional changes. Ping r115429.

[MediaWiki-CodeReview] [MediaWiki r115433]: Revision status changed

2012-05-25 Thread MediaWiki Mail
Krinkle changed the status of MediaWiki.r115433 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115433 Old status: new New status: ok Commit summary for MediaWiki.r115433: stylize.php. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r115428]: Revision status changed

2012-05-25 Thread MediaWiki Mail
Krinkle changed the status of MediaWiki.r115428 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115428 Old status: new New status: ok Commit summary for MediaWiki.r115428: removed old function we don't use ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r115429]: Revision status changed

2012-05-25 Thread MediaWiki Mail
Krinkle changed the status of MediaWiki.r115429 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115429 Old status: fixme New status: new Commit summary for MediaWiki.r115429: style of code ___ MediaWiki-CodeReview mailing list

[Wikitech-l] Adding a table in a test class

2012-05-25 Thread Jeroen De Dauw
Hey, I have some test class in which I need to (temporary) add a table. I did some stuff that works locally for my (just constructing some SQL and passing it to wfGetDb()-safeQuery) but it fails on Jenkins, presumably because it's using SQLLite or whatever there. Is there a better way to add such

Re: [Wikitech-l] about bots

2012-05-25 Thread Platonides
The cu_changes table is not at http://www.mediawiki.org/wiki/Manual:Database_layout because it's provided by an extension. The rc_bot marks if it's an edit marked as bot. As you have discovered, a bot can make edits not marked as bot (furthermore, as it is only stored in recentchanges table,

Re: [Wikitech-l] Adding a table in a test class

2012-05-25 Thread Chris McMahon
Use a stub instead? http://www.phpunit.de/manual/3.0/en/mock-objects.html (at the bottom of the page) On Fri, May 25, 2012 at 3:47 PM, Jeroen De Dauw jeroended...@gmail.comwrote: Hey, I have some test class in which I need to (temporary) add a table. I did some stuff that works locally for

Re: [Wikitech-l] Adding a table in a test class

2012-05-25 Thread Platonides
On 25/05/12 23:47, Jeroen De Dauw wrote: Hey, I have some test class in which I need to (temporary) add a table. I did some stuff that works locally for my (just constructing some SQL and passing it to wfGetDb()-safeQuery) but it fails on Jenkins, presumably because it's using SQLLite or

Re: [Wikitech-l] about bots

2012-05-25 Thread Alchimista
There are some bots without flag, but usergroups is a good starting point. As far as i know, only a few counter vandalisms or notifications bots aren't marked as bots. Like Matma said, bots can have the flag and edit wothout having the edits marked has bot edits. For example, my counter vandalism

Re: [Wikitech-l] UploadWizard changes live on Commons

2012-05-25 Thread Erik Moeller
On Fri, May 25, 2012 at 1:31 AM, Sumana Harihareswara suma...@wikimedia.org wrote: What does that mean, exactly? Is there a bug associated with that? Maybe it's https://bugzilla.wikimedia.org/show_bug.cgi?id=28850 or https://bugzilla.wikimedia.org/show_bug.cgi?id=32353 but I'm not sure. I

Re: [Wikitech-l] UploadWizard changes live on Commons

2012-05-25 Thread aude
On Fri, May 25, 2012 at 12:03 AM, Brion Vibber br...@wikimedia.org wrote: We've pushed some updates to UploadWizard, most notably: * disabled multiple-file selection in browsers where it didn't work * files now start uploading immediately when selected (this can be disabled server-side if

Re: [Wikitech-l] UploadWizard changes live on Commons

2012-05-25 Thread Erik Moeller
On Fri, May 25, 2012 at 4:36 PM, aude aude.w...@gmail.com wrote: I don't know if anything changed with the license selector part of the code and interface, but I tried uploading some maps (from OpenStreetMap) with the upload wizard.  More than once, I completely missed the license selection

Re: [Wikitech-l] UploadWizard changes live on Commons

2012-05-25 Thread aude
On Sat, May 26, 2012 at 1:45 AM, Erik Moeller e...@wikimedia.org wrote: On Fri, May 25, 2012 at 4:36 PM, aude aude.w...@gmail.com wrote: I don't know if anything changed with the license selector part of the code and interface, but I tried uploading some maps (from OpenStreetMap) with the

Re: [Wikitech-l] UploadWizard changes live on Commons

2012-05-25 Thread Thehelpfulone
A question about upload speed - can you show what the current upload speed is in the progress bar? And also, what would be the maximum upload speed that I could expect to achieve with chunked uploading? Technically I've got an upload speed of up to 10MB/s, but my upload speed is considerably

Re: [Wikitech-l] UploadWizard changes live on Commons

2012-05-25 Thread Thehelpfulone
On 26 May 2012 02:11, Thehelpfulone thehelpfulonew...@gmail.com wrote: A question about upload speed - can you show what the current upload speed is in the progress bar? And also, what would be the maximum upload speed that I could expect to achieve with chunked uploading? Technically I've got

Re: [Wikitech-l] ResourceManager and Javascript in Mediawiki

2012-05-25 Thread Krinkle
On May 25, 2012, at 10:37 PM, Derric Atzrott wrote: Hmmm does not appear to work for me. I added window.alert(Test); to the JavaScript file to make sure. The relevant sections of each file are listed out below. All of these sections are in sections of their respective files that are

Re: [Wikitech-l] UploadWizard changes live on Commons

2012-05-25 Thread Thehelpfulone
On 26 May 2012 02:17, Thehelpfulone thehelpfulonew...@gmail.com wrote: I was uploading a 317MB file and I hit an error, Internal error: Server failed to store temporary file. Not sure how to troubleshoot this one, the file is an .ogv downloaded from archive.org. And re-trying gives me

Re: [Wikitech-l] UploadWizard changes live on Commons

2012-05-25 Thread Erik Moeller
On Fri, May 25, 2012 at 6:21 PM, Thehelpfulone thehelpfulonew...@gmail.com wrote: And re-trying gives me  Unknown error: internal_api_error_UploadStashFileNotFoundException. CCing Brion in as he seems to be working on the Upload Wizard at present. Yes, this is the biggest remaining issue we

Re: [Wikitech-l] about bots

2012-05-25 Thread Bináris
Fabian, you have found one of my old problems. There is a request on Bugzilla to store bot edits in a table other than recent changes in order to be able to sort them out of page histories. As the others wrote, this is a very complicated question with few hope to get exact results, but please let