[MediaWiki-CodeReview] [MediaWiki r113775]: New comment added, and revision status changed

2012-03-19 Thread MediaWiki Mail
Krinkle changed the status of MediaWiki.r113775 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113775#c32304 Old Status: ok New Status: fixme Commit summary for MediaWiki.r113775: * (bug 35201) Edit buttons no longer cause jump in IE 9 Changed order of

[MediaWiki-CodeReview] [MediaWiki r113775]: New comment added

2012-03-19 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r113775. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113775#c32305 Commit summary for MediaWiki.r113775: * (bug 35201) Edit buttons no longer cause jump in IE 9 Changed order of feature-detection checks so we prefer the IE method over the

[MediaWiki-CodeReview] [MediaWiki r113775]: New comment added

2012-03-19 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r113775. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113775#c32306 Commit summary for MediaWiki.r113775: * (bug 35201) Edit buttons no longer cause jump in IE 9 Changed order of feature-detection checks so we prefer the IE method over the

[MediaWiki-CodeReview] [MediaWiki r114024]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r114024 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114024 Old status: deferred New status: ok Commit summary for MediaWiki.r114024: Crush images from r114023 Drops from 165KB to 58.5KB (200KB to 116KB as size on disk) Also fix

[MediaWiki-CodeReview] [MediaWiki r114026]: New comment added, and revision status changed

2012-03-19 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r114026 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114026#c32307 Old Status: deferred New Status: fixme Commit summary for MediaWiki.r114026: follow up r114023 add missing plural Nikerabbit's comment: Typo

[MediaWiki-CodeReview] [MediaWiki r114028]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r114028 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114028 Old status: deferred New status: ok Commit summary for MediaWiki.r114028: adding abstract page to not have to duplicate caching code to much

[MediaWiki-CodeReview] [MediaWiki r114122]: Revision status changed

2012-03-19 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r114122 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114122 Old status: new New status: ok Commit summary for MediaWiki.r114122: Follow-up to r114004 - Use tabs instead of spaces ___

[MediaWiki-CodeReview] [MediaWiki r114121]: Revision status changed

2012-03-19 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r114121 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114121 Old status: new New status: ok Commit summary for MediaWiki.r114121: follow-up r114116: move release-notes ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r114046]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r114046 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114046 Old status: new New status: ok Commit summary for MediaWiki.r114046: Follow up to r114045; cleanup + docs ___

[MediaWiki-CodeReview] [MediaWiki r114113]: Revision status changed

2012-03-19 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r114113 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114113 Old status: new New status: ok Commit summary for MediaWiki.r114113: Cleanup extra ; and break statements Remove a wrong comment

[MediaWiki-CodeReview] [MediaWiki r114057]: New comment added, and revision status changed

2012-03-19 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r114057 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114057#c32308 Old Status: new New Status: fixme Commit summary for MediaWiki.r114057: Use more normal $dir code, remove duplicate loading of same file as it's

[MediaWiki-CodeReview] [MediaWiki r114058]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r114058 to fixme URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114058 Old status: new New status: fixme Commit summary for MediaWiki.r114058: MFT x2 r114057 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r114021]: Revision status changed

2012-03-19 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r114021 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114021 Old status: new New status: ok Commit summary for MediaWiki.r114021: MFT r114020 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r114059]: New comment added

2012-03-19 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r114059. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114059#c32309 Commit summary for MediaWiki.r114059: work on special:studentactivity Nikerabbit's comment: Cannot review without message documentation.

[MediaWiki-CodeReview] [MediaWiki r113989]: Revision status changed

2012-03-19 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r113989 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113989 Old status: new New status: ok Commit summary for MediaWiki.r113989: MFT r113988 x3 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r114060]: New comment added

2012-03-19 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r114060. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114060#c32310 Commit summary for MediaWiki.r114060: work on special:studentactivity Nikerabbit's comment: Cannot review without message documentation.

[MediaWiki-CodeReview] [MediaWiki r114061]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r114061 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114061 Old status: new New status: ok Commit summary for MediaWiki.r114061: Removed a stray comma causing maintenance/update.php to break

[MediaWiki-CodeReview] [MediaWiki r114062]: New comment added

2012-03-19 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r114062. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114062#c32311 Commit summary for MediaWiki.r114062: Bug: Sometimes $text is not a string but an object of message class, it causes an exception. Fixed. Nikerabbit's comment: What does

[MediaWiki-CodeReview] [MediaWiki r114052]: Revision status changed

2012-03-19 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r114052 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114052 Old status: new New status: deferred Commit summary for MediaWiki.r114052: save up some old hacks. Need to be redone properly though

[MediaWiki-CodeReview] [MediaWiki r114048]: Revision status changed

2012-03-19 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r114048 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114048 Old status: new New status: deferred Commit summary for MediaWiki.r114048: Sync with trunk ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r114068]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r114068 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114068 Old status: deferred New status: ok Commit summary for MediaWiki.r114068: SemanticTitle: README updated. ___

[MediaWiki-CodeReview] [MediaWiki r113862]: Revision status changed

2012-03-19 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r113862 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113862 Old status: fixme New status: resolved Commit summary for MediaWiki.r113862: follow up r113836 added public function extensionTableExists.

[MediaWiki-CodeReview] [MediaWiki r114050]: Revision status changed

2012-03-19 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r114050 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114050 Old status: new New status: ok Commit summary for MediaWiki.r114050: follow up r113862 . changed public function name extensionTableExists to tableExists

Re: [Wikitech-l] Using prototypical inheritance in dynamically loaded ResourceLoader modules

2012-03-19 Thread Dmitriy Sintsov
Hi! I've tweaked my code few times, trying to make it simpler: got rid of some closure calls and left only one dynamic module load at client-side. http://pastebin.com/UxyifLmx http://pastebin.com/q3Tm6Ajd http://pastebin.com/4emMDBS6 Still, it gives me headaches, because mw.loader.using(

[MediaWiki-CodeReview] [MediaWiki r114106]: Revision status changed

2012-03-19 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r114106 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114106 Old status: new New status: ok Commit summary for MediaWiki.r114106: Disable callgraphs for the time being Per Yuvi, most people don't need them, and are a PITA on a slow

[MediaWiki-CodeReview] [MediaWiki r114071]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r114071 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114071 Old status: new New status: ok Commit summary for MediaWiki.r114071: Follow up to r114067; ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r114079]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r114079 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114079 Old status: ok New status: resolved Commit summary for MediaWiki.r114079: Followup r114067 Add centuries because the messages were already there but not used Add

[MediaWiki-CodeReview] [MediaWiki r114085]: New comment added, and revision status changed

2012-03-19 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r114085 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114085#c32312 Old Status: new New Status: fixme Commit summary for MediaWiki.r114085: Add a temporary disclaimer text making it clear that this is a

Re: [Wikitech-l] Using prototypical inheritance in dynamically loaded ResourceLoader modules

2012-03-19 Thread Daniel Friesen
On Mon, 19 Mar 2012 00:40:54 -0700, Dmitriy Sintsov ques...@rambler.ru wrote: Hi! I've tweaked my code few times, trying to make it simpler: got rid of some closure calls and left only one dynamic module load at client-side. http://pastebin.com/UxyifLmx http://pastebin.com/q3Tm6Ajd

[MediaWiki-CodeReview] [MediaWiki r114069]: New comment added

2012-03-19 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r114069. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114069#c32313 Commit summary for MediaWiki.r114069: SemanticTitle: New hook implemented to eliminate need in DEFAULTSORT, but not enabled due to issue (unknown parser). Nikerabbit's

[MediaWiki-CodeReview] [MediaWiki r114087]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r114087 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114087 Old status: new New status: ok Commit summary for MediaWiki.r114087: 1.19wmf1: MFT r114085 ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r114077]: New comment added

2012-03-19 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r114077. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114077#c32314 Commit summary for MediaWiki.r114077: identify students by user name rather then id Nikerabbit's comment: Cannot review without message documentation.

[MediaWiki-CodeReview] [MediaWiki r114081]: New comment added

2012-03-19 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r114081. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114081#c32315 Commit summary for MediaWiki.r114081: adding special page with scaffolding for caching chunks of HTML Nikerabbit's comment: $_GET ? Use WebRequest.

[MediaWiki-CodeReview] [MediaWiki r114096]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r114096 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114096 Old status: new New status: ok Commit summary for MediaWiki.r114096: Removed redundant , moved up $wgExtensionCredits and gave descriptions for classes,

Re: [Wikitech-l] Using prototypical inheritance in dynamically loaded ResourceLoader modules

2012-03-19 Thread Dmitriy Sintsov
* Daniel Friesen li...@nadir-seen-fire.com [Mon, 19 Mar 2012 01:35:21 -0700]: Autoloading classes is not possible. Even if every browser supported getters and we could use them to dynamically load classes, this would require synchronous http calls. Which are absolutely HORRIBLE because they

[MediaWiki-CodeReview] [MediaWiki r114103]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r114103 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114103 Old status: new New status: ok Commit summary for MediaWiki.r114103: kill flag images as well be using commons anyway ___

[MediaWiki-CodeReview] [MediaWiki r114105]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r114105 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114105 Old status: new New status: ok Commit summary for MediaWiki.r114105: Specific message to be able to customise the link target

[MediaWiki-CodeReview] [MediaWiki r114106]: New comment added

2012-03-19 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r114106. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114106#c32316 Commit summary for MediaWiki.r114106: Disable callgraphs for the time being Per Yuvi, most people don't need them, and are a PITA on a slow connection I'd be happy to

[MediaWiki-CodeReview] [MediaWiki r114110]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r114110 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114110 Old status: new New status: ok Commit summary for MediaWiki.r114110: Foolow-up to r114108: https protocol is used instead of http.

[MediaWiki-CodeReview] [MediaWiki r114114]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r114114 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114114 Old status: new New status: ok Commit summary for MediaWiki.r114114: [jquery.byteLimit.test] clean up * js conventions * whitespace indention

[MediaWiki-CodeReview] [MediaWiki r114117]: New comment added

2012-03-19 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r114117. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114117#c32317 Commit summary for MediaWiki.r114117: * (bug 35303) Make proxy and DNS blacklist blocking work again Nikerabbit's comment: It's not immediately obvious why this fixes the

[MediaWiki-CodeReview] [MediaWiki r114123]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r114123 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114123 Old status: new New status: ok Commit summary for MediaWiki.r114123: Update tags. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r114124]: Revision status changed

2012-03-19 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r114124 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114124 Old status: new New status: ok Commit summary for MediaWiki.r114124: During update, defer creation of the AbuseFilter user until after the core updates have run, so that you

[MediaWiki-CodeReview] [MediaWiki r47919]: New comment added

2012-03-19 Thread MediaWiki Mail
Tim Starling posted a comment on MediaWiki.r47919. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/47919#c32318 Commit summary for MediaWiki.r47919: Partial redesign with refactoring of CentralAuth admin interface. Merged lock/hide/unlock/unhide/lockandhide forms into a single 'change

[MediaWiki-CodeReview] [MediaWiki r47919]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Tim Starling changed the status of MediaWiki.r47919 to fixme URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/47919 Old status: ok New status: fixme Commit summary for MediaWiki.r47919: Partial redesign with refactoring of CentralAuth admin interface. Merged

Re: [Wikitech-l] Using prototypical inheritance in dynamically loaded ResourceLoader modules

2012-03-19 Thread Dmitriy Sintsov
* Daniel Friesen li...@nadir-seen-fire.com [Mon, 19 Mar 2012 01:35:21 -0700]: ( function( $, mw ) { } )( jQuery, mediaWiki ); I modified all of three modules: main, view and edit module to the recommended pattern. http://pastebin.com/1kS6EyUu http://pastebin.com/WQzBTw6W

Re: [Wikitech-l] Using PHP's assert in MediaWiki code

2012-03-19 Thread Christian Aistleitner
Hi Tim, on Mon, Mar 19, 2012 at 09:09:58AM +1100, Tim Starling wrote: On 18/03/12 20:37, Christian Aistleitner wrote: Dear all, should we allow using PHP's assert [1] in MediaWiki code? It would allow us to formulate and automatically verify conditions about code, while at the same

Re: [Wikitech-l] Using PHP's assert in MediaWiki code

2012-03-19 Thread Christian Aistleitner
Hi Chad, on Sun, Mar 18, 2012 at 07:18:01PM -0400, Chad wrote: I'd also add that the behavior of assertions vary based on configuration, which is confusing at best. Being able to vary based on configuration actually is a feature. An essential one. It lowers assert's impact on performance. But

Re: [Wikitech-l] Using prototypical inheritance in dynamically loaded ResourceLoader modules

2012-03-19 Thread Daniel Friesen
On Mon, 19 Mar 2012 02:07:54 -0700, Dmitriy Sintsov ques...@rambler.ru wrote: * Daniel Friesen li...@nadir-seen-fire.com [Mon, 19 Mar 2012 01:35:21 -0700]: Autoloading classes is not possible. Even if every browser supported getters and we could use them to dynamically load classes, this

[MediaWiki-CodeReview] [MediaWiki r114125]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r114125 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114125 Old status: new New status: ok Commit summary for MediaWiki.r114125: This line was supposed to be removed in r109030 /me bangs head

[MediaWiki-CodeReview] [MediaWiki r113908]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r113908 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113908 Old status: new New status: resolved Commit summary for MediaWiki.r113908: Better message documentation ___

[MediaWiki-CodeReview] [MediaWiki r114002]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r114002 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114002 Old status: new New status: ok Commit summary for MediaWiki.r114002: Minor white space fix prefix ag- for aggregrate group Ids. If the name contains comma, make it

[MediaWiki-CodeReview] [MediaWiki r113715]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r113715 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113715 Old status: new New status: resolved Commit summary for MediaWiki.r113715: Fix the broken 'add new aggregate group' in r113631 Get the list of groups that can be

[MediaWiki-CodeReview] [MediaWiki r113225]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r113225 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113225 Old status: new New status: resolved Commit summary for MediaWiki.r113225: Clear the associated metadata when a translatable page is deleted. Move the associated

[MediaWiki-CodeReview] [MediaWiki r113141]: New comment added

2012-03-19 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r113141. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113141#c32319 Commit summary for MediaWiki.r113141: Correct the filtering of languages for MessageGroup stats. It should only list prioriy langs and languages with more than 0%

[MediaWiki-CodeReview] [MediaWiki r114126]: New comment added

2012-03-19 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r114126. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114126#c32320 Commit summary for MediaWiki.r114126: Sanitizing already existing use of PHP's assert Nikerabbit's comment: BTW, does HipHop support assert?

[MediaWiki-CodeReview] [MediaWiki r114096]: New comment added, and revision status changed

2012-03-19 Thread MediaWiki Mail
Van de Bugger changed the status of MediaWiki.r114096 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114096#c32321 Old Status: ok New Status: fixme Commit summary for MediaWiki.r114096: Removed redundant , moved up $wgExtensionCredits and gave descriptions

[MediaWiki-CodeReview] [MediaWiki r114062]: New comment added

2012-03-19 Thread MediaWiki Mail
Van de Bugger posted a comment on MediaWiki.r114062. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114062#c32322 Commit summary for MediaWiki.r114062: Bug: Sometimes $text is not a string but an object of message class, it causes an exception. Fixed. Van de Bugger's comment: It

[MediaWiki-CodeReview] [MediaWiki r114096]: New comment added

2012-03-19 Thread MediaWiki Mail
MaxSem posted a comment on MediaWiki.r114096. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114096#c32323 Commit summary for MediaWiki.r114096: Removed redundant , moved up $wgExtensionCredits and gave descriptions for classes, internationlization and default values MaxSem's

[MediaWiki-CodeReview] [MediaWiki r114128]: New comment added

2012-03-19 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r114128. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114128#c32324 Commit summary for MediaWiki.r114128: Added TranslationNotificationsHooks and a callback for logging. Added very basic logging. Renamed form fields variables and function

[MediaWiki-CodeReview] [MediaWiki r114108]: New comment added

2012-03-19 Thread MediaWiki Mail
Van de Bugger posted a comment on MediaWiki.r114108. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114108#c32325 Commit summary for MediaWiki.r114108: WhiteSpace: Initial revision. Van de Bugger's comment: But how? this wasn't really something that anyone wanted. See

[MediaWiki-CodeReview] [MediaWiki r112924]: New comment added

2012-03-19 Thread MediaWiki Mail
Van de Bugger posted a comment on MediaWiki.r112924. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112924#c32326 Commit summary for MediaWiki.r112924: Initial revision of Genderize extension. Van de Bugger's comment: Reading global variables before they are set opens doors to

Re: [Wikitech-l] Using PHP's assert in MediaWiki code

2012-03-19 Thread Tim Starling
On 19/03/12 21:43, Christian Aistleitner wrote: Being able to vary based on configuration actually is a feature. An essential one. It lowers assert's impact on performance. But there is no need to mess with configuration. asserts work out of the box. You are only given the possibility to turn

[MediaWiki-CodeReview] [MediaWiki r114128]: New comment added, and revision status changed

2012-03-19 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r114128 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114128#c32327 Old Status: new New Status: fixme Commit summary for MediaWiki.r114128: Added TranslationNotificationsHooks and a callback for logging.

[MediaWiki-CodeReview] [MediaWiki r113825]: New comment added

2012-03-19 Thread MediaWiki Mail
IAlex posted a comment on MediaWiki.r113825. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113825#c32328 Commit summary for MediaWiki.r113825: Reverted r113803: makes already messy class messier (a bit to much) IAlex's comment: I'm sorry but I don't see what was more messy there.

Re: [Wikitech-l] Using PHP's assert in MediaWiki code

2012-03-19 Thread Christian Aistleitner
Hi Tim, On Mon, Mar 19, 2012 at 11:20:53PM +1100, Tim Starling wrote: assert_options( ASSERT_ACTIVE, 0 ); [ unmotivated ranting ] I was talking about performance on production servers. Obviously. Where else would performance matter? And yes. On production servers, one typically turns

Re: [Wikitech-l] Using prototypical inheritance in dynamically loaded ResourceLoader modules

2012-03-19 Thread Krinkle
offtopic On Mon, Mar 19, 2012 at 9:35 AM, Daniel Friesen li...@nadir-seen-fire.comwrote: On Mon, 19 Mar 2012 00:40:54 -0700, Dmitriy Sintsov ques...@rambler.ru wrote: var jqgmap = []; for ( var mapIndex in jqgmap ) { This is VERY bad JavaScript coding practice. Please use $.each().

Re: [Wikitech-l] Using prototypical inheritance in dynamically loaded ResourceLoader modules

2012-03-19 Thread Krinkle
offtopic On Mon, Mar 19, 2012 at 2:23 PM, Krinkle krinklem...@gmail.com wrote: On Mon, Mar 19, 2012 at 9:35 AM, Daniel Friesen li...@nadir-seen-fire.com wrote: On Mon, 19 Mar 2012 00:40:54 -0700, Dmitriy Sintsov ques...@rambler.ru wrote: var jqgmap = []; for ( var mapIndex in jqgmap ) {

[MediaWiki-CodeReview] [MediaWiki r114081]: New comment added

2012-03-19 Thread MediaWiki Mail
Jeroen De Dauw posted a comment on MediaWiki.r114081. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114081#c32329 Commit summary for MediaWiki.r114081: adding special page with scaffolding for caching chunks of HTML Jeroen De Dauw's comment: r114137 :)

[MediaWiki-CodeReview] [MediaWiki r114026]: New comment added

2012-03-19 Thread MediaWiki Mail
Jeroen De Dauw posted a comment on MediaWiki.r114026. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114026#c32330 Commit summary for MediaWiki.r114026: follow up r114023 add missing plural Jeroen De Dauw's comment: Sorry, I don't know how to correct this - can you do it?

Re: [Wikitech-l] Using prototypical inheritance in dynamically loaded ResourceLoader modules

2012-03-19 Thread Dmitriy Sintsov
On 19.03.2012 17:23, Krinkle wrote: offtopic On Mon, Mar 19, 2012 at 9:35 AM, Daniel Friesen li...@nadir-seen-fire.comwrote: On Mon, 19 Mar 2012 00:40:54 -0700, Dmitriy Sintsovques...@rambler.ru wrote: var jqgmap = []; for ( var mapIndex in jqgmap ) { This is VERY bad JavaScript coding

[MediaWiki-CodeReview] [MediaWiki r114058]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r114058 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114058 Old status: fixme New status: new Commit summary for MediaWiki.r114058: MFT x2 r114057 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r114081]: New comment added, and revision status changed

2012-03-19 Thread MediaWiki Mail
Krinkle changed the status of MediaWiki.r114081 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114081#c32331 Old Status: new New Status: fixme Commit summary for MediaWiki.r114081: adding special page with scaffolding for caching chunks of HTML Krinkle's

[MediaWiki-CodeReview] [MediaWiki r114057]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r114057 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114057 Old status: fixme New status: new Commit summary for MediaWiki.r114057: Use more normal $dir code, remove duplicate loading of same file as it's going to give errors

[MediaWiki-CodeReview] [MediaWiki r114131]: New comment added, and revision status changed

2012-03-19 Thread MediaWiki Mail
Krinkle changed the status of MediaWiki.r114131 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114131#c32332 Old Status: new New Status: fixme Commit summary for MediaWiki.r114131: Change calls from Xml::namespaceSelector() to Html::namespaceSelector()

[MediaWiki-CodeReview] [MediaWiki r114131]: New comment added, and revision status changed

2012-03-19 Thread MediaWiki Mail
Krinkle changed the status of MediaWiki.r114131 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114131#c32333 Old Status: fixme New Status: resolved Commit summary for MediaWiki.r114131: Change calls from Xml::namespaceSelector() to

[MediaWiki-CodeReview] [MediaWiki r114117]: New comment added

2012-03-19 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r114117. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114117#c32334 Commit summary for MediaWiki.r114117: * (bug 35303) Make proxy and DNS blacklist blocking work again Krinkle's comment: Could you please stop committing to trunk and REL1_19

[MediaWiki-CodeReview] [MediaWiki r114116]: New comment added

2012-03-19 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r114116. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114116#c32335 Commit summary for MediaWiki.r114116: [jquery.byteLimit] Set vars in return this.each loop * Set vars in return this.each loop. This is the defacto standard plugin structure

[MediaWiki-CodeReview] [MediaWiki r114117]: New comment added

2012-03-19 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r114117. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114117#c32336 Commit summary for MediaWiki.r114117: * (bug 35303) Make proxy and DNS blacklist blocking work again Krinkle's comment: It also makes it less obvious to merge to 1.19wmf1.

[MediaWiki-CodeReview] [MediaWiki r114106]: New comment added

2012-03-19 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r114106. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114106#c32337 Commit summary for MediaWiki.r114106: Disable callgraphs for the time being Per Yuvi, most people don't need them, and are a PITA on a slow connection I'd be happy to

[MediaWiki-CodeReview] [MediaWiki r114101]: New comment added

2012-03-19 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r114101. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114101#c32338 Commit summary for MediaWiki.r114101: follow up to r114081: qqq, and to r114082: match rename Krinkle's comment: pre +'cachedspecial-viewing-cached-ts' = 'Message notifying

[MediaWiki-CodeReview] [MediaWiki r113886]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Krinkle changed the status of MediaWiki.r113886 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113886 Old status: new New status: resolved Commit summary for MediaWiki.r113886: Add error css to errors like the other file operation pages and actions

[MediaWiki-CodeReview] [MediaWiki r114051]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Krinkle changed the status of MediaWiki.r114051 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114051 Old status: new New status: ok Commit summary for MediaWiki.r114051: making corresponding change as a follow up r114050 ___

[MediaWiki-CodeReview] [MediaWiki r114106]: New comment added

2012-03-19 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r114106. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114106#c32339 Commit summary for MediaWiki.r114106: Disable callgraphs for the time being Per Yuvi, most people don't need them, and are a PITA on a slow connection I'd be happy to re-enable

Re: [Wikitech-l] JS Iteration (was: Using prototypical inheritance in dynamically loaded ResourceLoader modules)

2012-03-19 Thread Krinkle
ontopic :) On Mon, Mar 19, 2012 at 3:03 PM, Dmitriy Sintsov ques...@rambler.ru wrote: On 19.03.2012 17:23, Krinkle wrote: On Mon, Mar 19, 2012 at 9:35 AM, Daniel Friesen li...@nadir-seen-fire.com**wrote: On Mon, 19 Mar 2012 00:40:54 -0700, Dmitriy Sintsovques...@rambler.ru wrote: var

[Wikitech-l] QA/testing project page exists

2012-03-19 Thread Chris McMahon
After doing a lot of research and visiting WMF for a week, I created a QA/testing project page here: http://www.mediawiki.org/wiki/QA/testing tl;dr: it is early days yet and lots of details to be worked out, but I have a picture in place of an integrated, valuable QA/testing structure and process

[Wikitech-l] What is the procedure to change the owner of a WM mailing list?

2012-03-19 Thread Strainu
Hi, The Romanian mailing lists are managed by a wikipedian that has left the project some years ago and now he doesn't have time to moderate the lists. What is the normal procedure to be followed to have somebody else take over the lists? Thanks, Strainu

Re: [Wikitech-l] What is the procedure to change the owner of a WM mailing list?

2012-03-19 Thread Petr Bena
Hi It's just about transfering the password from him to someone else, or in case he doesn't remember it, you can request a new password. On Mon, Mar 19, 2012 at 4:33 PM, Strainu strain...@gmail.com wrote: Hi, The Romanian mailing lists are managed by a wikipedian that has left the project

Re: [Wikitech-l] QA/testing project page exists

2012-03-19 Thread Bergi
Chris McMahon schrieb: After doing a lot of research and visiting WMF for a week, I created a QA/testing project page here: http://www.mediawiki.org/wiki/QA/testing Ah, QA means quality assurance. Other meanings were: * qualtity articles * question answer * ...

Re: [Wikitech-l] What is the procedure to change the owner of a WM mailing list?

2012-03-19 Thread Jeremy Baron
On Mon, Mar 19, 2012 at 11:41, Petr Bena benap...@gmail.com wrote: It's just about transfering the password from him to someone else, or in case he doesn't remember it, you can request a new password. Also, once you have the password you should update the email addresses for owner and

Re: [Wikitech-l] What is the procedure to change the owner of a WM mailing list?

2012-03-19 Thread Casey Brown
On Mon, Mar 19, 2012 at 11:41 AM, Petr Bena benap...@gmail.com wrote: It's just about transfering the password from him to someone else, or in case he doesn't remember it, you can request a new password. Yes. Create a bug in the Mailing lists component requesting that the list administrator be

[Wikitech-l] New Plugin for Extension:ConfirmEdit - RFC

2012-03-19 Thread nischay nahata
Hi, I have made a Captcha plugin for ConfirmEdit called MCQ (Multiple Choice Questions) Below is the usage of it sample Captcha: Pick the correct Option Number We pray to 1.Time 1.God 3.Lion 4.Tomato ? Answer 2 Why Beneficial ? * Bots don't have common sense * No Images so loads faster * Most

Re: [Wikitech-l] API - Edit by IP not by user

2012-03-19 Thread nischay nahata
I'm not sure what version the dutch one has. You can check version using Special:Version -- With Regards Nischay Nahata B.tech 3rd year Department of Information Technology NITK,Surathkal ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org

[MediaWiki-CodeReview] [MediaWiki r114005]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Preilly changed the status of MediaWiki.r114005 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114005 Old status: new New status: ok Commit summary for MediaWiki.r114005: make form rule more specific this will break rendering of forms outside the header e.g. feedback form

[MediaWiki-CodeReview] [MediaWiki r114025]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Preilly changed the status of MediaWiki.r114025 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114025 Old status: new New status: ok Commit summary for MediaWiki.r114025: use top for absolute positioning not bottom using bottom doesn't work on certain mobile devices crucially

[MediaWiki-CodeReview] [MediaWiki r114129]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Preilly changed the status of MediaWiki.r114129 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114129 Old status: new New status: ok Commit summary for MediaWiki.r114129: Text extraction rewrite: * Renamed prop=excerpts -- prop=extracts * Made it optionally return whole page

[MediaWiki-CodeReview] [MediaWiki r114130]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Preilly changed the status of MediaWiki.r114130 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114130 Old status: new New status: ok Commit summary for MediaWiki.r114130: Follow-up r114129: rename file ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r114134]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Preilly changed the status of MediaWiki.r114134 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114134 Old status: new New status: ok Commit summary for MediaWiki.r114134: make references close on a second click following erik's suggestion clicking on a reference a second

[MediaWiki-CodeReview] [MediaWiki r114136]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Preilly changed the status of MediaWiki.r114136 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114136 Old status: new New status: ok Commit summary for MediaWiki.r114136: allow experimentation with animation speed as requested by tfinc we can now pass speed values via the

[MediaWiki-CodeReview] [MediaWiki r114145]: Revision status changed

2012-03-19 Thread MediaWiki Mail
Preilly changed the status of MediaWiki.r114145 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114145 Old status: new New status: ok Commit summary for MediaWiki.r114145: remove languageselection div there are currently 2 elements with id languageselection. This one appears

  1   2   3   >