Re: shell32: Fix SHFileOperation on empty destination (FO_COPY)

2009-01-27 Thread James Hawkins
On Tue, Jan 27, 2009 at 3:20 AM, Nikolay Sivov bungleh...@gmail.com wrote: http://bugs.winehq.org/show_bug.cgi?id=13394 Changelog: - on FO_COPY and empty destination SHFileOperation should use current directory From 1684fd3c0d47fce3fcff31d316ec7b18291cd5af Mon Sep 17 00:00:00 2001

Could someone test this wineinet:http fix on an XP or 2003 box without IE7

2009-01-27 Thread Reece Dunn
Hopefully, we will then get a clean test run on some XP boxes and have several more 2003 boxes with 1 test failure :). Thanks, - Reece diff --git a/dlls/wininet/tests/http.c b/dlls/wininet/tests/http.c index c5321b4..b810494 100644 --- a/dlls/wininet/tests/http.c +++ b/dlls/wininet/tests/http.c

Re: Could someone test this wineinet:http fix on an XP or 2003 box without IE7

2009-01-27 Thread Nikolay Sivov
Reece Dunn wrote: Hopefully, we will then get a clean test run on some XP boxes and have several more 2003 boxes with 1 test failure :). Thanks, - Reece Got this on XP SP2 with IE6 http.c:1837: Test failed: got

Re: Could someone test this wineinet:http fix on an XP or 2003 box without IE7

2009-01-27 Thread Nikolay Sivov
Reece Dunn wrote: Hopefully, we will then get a clean test run on some XP boxes and have several more 2003 boxes with 1 test failure :). Thanks, - Reece Got this on XP SP2 with IE6 http.c:1837: Test failed: got

Re: Could someone test this wineinet:http fix on an XP or 2003 box without IE7

2009-01-27 Thread Paul Vriens
Reece Dunn wrote: Hopefully, we will then get a clean test run on some XP boxes and have several more 2003 boxes with 1 test failure :). Thanks, - Reece Hi Reece, Tested on W2K3 with IE6: http.c:1837: Test

Re: Could someone test this wineinet:http fix on an XP or 2003 box without IE7

2009-01-27 Thread Hans Leidekker
On Tuesday 27 January 2009 10:59:13 Nikolay Sivov wrote: Hopefully, we will then get a clean test run on some XP boxes and have several more 2003 boxes with 1 test failure :). Thanks, - Reece Got this

Re: advapi32: Fix potential NULL pointer dereference in RegSetValueExA [with test] (Saturn)

2009-01-27 Thread Rob Shearman
2009/1/26 Aurimas Fišeras auri...@gmail.com: Saturn's error report: (INCONSISTENT USE) Possible null dereference of variable data+(count-1). This variable is checked for Null at lines: registry.c:1051 Tested on Windows XP Changelog: advapi32: Fix potential NULL pointer dereference in

Re: advapi32: Fix potential NULL pointer dereference in RegSetValueExA [with test] (Saturn)

2009-01-27 Thread Alexandre Julliard
Rob Shearman robertshear...@gmail.com writes: 2009/1/26 Aurimas Fišeras auri...@gmail.com: Saturn's error report: (INCONSISTENT USE) Possible null dereference of variable data+(count-1). This variable is checked for Null at lines: registry.c:1051 Tested on Windows XP Changelog:

Re: comctl32[1/2]: toolbar: Str_SetPtr* assumes the destination pointer points to allocated memory or is NULL

2009-01-27 Thread Alexandre Julliard
Mikołaj Zalewski miko...@zalewski.pl writes: @@ -2924,6 +2925,7 @@ TOOLBAR_AddStringW (HWND hwnd, WPARAM wParam, LPARAM lParam) } infoPtr-strings = ReAlloc(infoPtr-strings, sizeof(LPWSTR)*(infoPtr-nNumStrings+1)); +

Re: [PATCH] d3d9: initialize hr (coverity)

2009-01-27 Thread Alexandre Julliard
Marcus Meissner mar...@jet.franken.de writes: Spotted in CID 864 that hr is used uninitialized in a codepath. Using S_OK as default return. Is S_OK really appropriate here? A test case is probably in order. -- Alexandre Julliard julli...@winehq.org

Re: comctl32: Fix propsheet size calculation

2009-01-27 Thread Vitaliy Margolen
Vitaliy Margolen wrote: Size of tabs has nothing to do with the size of a window title. Fixes bug 8522. --- dlls/comctl32/propsheet.c | 17 ++--- 1 files changed, 14 insertions(+), 3 deletions(-) Was there anything wrong with this patch? Adding tests for this won't work all

Re: advapi32: Fix potential NULL pointer dereference in RegSetValueExA [with test] (Saturn)

2009-01-27 Thread Aurimas Fišeras
Alexandre Julliard wrote: Rob Shearman robertshear...@gmail.com writes: 2009/1/26 Aurimas Fišeras auri...@gmail.com: Saturn's error report: (INCONSISTENT USE) Possible null dereference of variable data+(count-1). This variable is checked for Null at lines: registry.c:1051 Tested on

Re: advapi32: Fix potential NULL pointer dereference in RegSetValueExA [with test] (Saturn)

2009-01-27 Thread Alexandre Julliard
Aurimas Fišeras auri...@gmail.com writes: Alexandre Julliard wrote: Of course Windows has exception handlers all over the place, but that doesn't mean we want to replicate that behavior. But we want to have a bug-for-bug compatibility with Windows? Without this patch windows just returns an

Re: gdi32: Remove unneeded check. (Coverity)

2009-01-27 Thread Rob Shearman
2009/1/27 Kai Blin kai.b...@gmail.com: lcdfilter = FT_LCD_FILTER_DEFAULT is hardcoded, so the check is always true. This fixes Coverity CID 816 diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index 1ca6953..dfbcf2f 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c

Re: Wine menu creation questions

2009-01-27 Thread Frank Richter
On 27.01.2009 05:00, Scott Ritchie wrote: One open question: what to do with Windows apps that don't put themselves in Program Files, but rather put themselves at the top of the start menu? Desktop menu building could put both 'Program Files' and 'real top-level' entries under the same Wine

Re: advapi32: Fix potential NULL pointer dereference in RegSetValueExA [with test] (Saturn)

2009-01-27 Thread Aurimas Fišeras
Alexandre Julliard wrote: Aurimas Fišeras auri...@gmail.com writes: Alexandre Julliard wrote: Of course Windows has exception handlers all over the place, but that doesn't mean we want to replicate that behavior. But we want to have a bug-for-bug compatibility with Windows? Without this

Re: advapi32: Fix potential NULL pointer dereference in RegSetValueExA [with test] (Saturn)

2009-01-27 Thread Alexandre Julliard
Aurimas Fišeras auri...@gmail.com writes: Alexandre Julliard wrote: We only want it when an actual app depends on it, otherwise we'd have to add exception handlers in all functions. Note that the Windows behavior often varies across versions too. So why are we fixing various Possible NULL

Re: include(1/1): Define flags used by CryptUIWizExport

2009-01-27 Thread Alexandre Julliard
Juan Lang juan.l...@gmail.com writes: @@ -297,6 +297,12 @@ typedef struct _CRYPTUI_WIZ_EXPORT_CERTCONTEXT_INFO typedef const CRYPTUI_WIZ_EXPORT_CERTCONTEXT_INFO * PCCRYPTUI_WIZ_EXPORT_CERTCONTEXT_INFO; +/* Values for CryptUIWizExport's dwFlags */ +#define

Re: Updated DIB Engine

2009-01-27 Thread Massimo Del Fedele
Any opinion about this one ? Could it be a good candidate for inclusion in wine tree ? Ciao Max

Re: include(1/1): Define flags used by CryptUIWizExport

2009-01-27 Thread Juan Lang
MSDN explicitly states that these are not defined in a public header. Whoops. By all means ignore it, none of the subsequent patches depends on it. Thanks, --Juan

Re: Updated DIB Engine

2009-01-27 Thread Reece Dunn
2009/1/27 Massimo Del Fedele m...@veneto.com: Any opinion about this one ? Could it be a good candidate for inclusion in wine tree ? Hi, I have used this with StarCraft, running it with and without the DIB engine enabled. I find the environment variable makes it very easy to switch between

Re: Updated DIB Engine

2009-01-27 Thread Massimo Del Fedele
Reece Dunn ha scritto: 2009/1/27 Massimo Del Fedele m...@veneto.com: Any opinion about this one ? Could it be a good candidate for inclusion in wine tree ? Hi, I have used this with StarCraft, running it with and without the DIB engine enabled. I find the environment variable makes it

Re: Updated DIB Engine

2009-01-27 Thread Austin English
On Tue, Jan 27, 2009 at 1:51 PM, Massimo Del Fedele m...@veneto.com wrote: Reece Dunn ha scritto: 2009/1/27 Massimo Del Fedele m...@veneto.com: Any opinion about this one ? Could it be a good candidate for inclusion in wine tree ? Hi, I have used this with StarCraft, running it with and

Re: advapi32: Fix potential NULL pointer dereference in RegSetValueExA [with test] (Saturn)

2009-01-27 Thread Aurimas Fišeras
Alexandre Julliard wrote: Aurimas Fišeras auri...@gmail.com writes: Alexandre Julliard wrote: We only want it when an actual app depends on it, otherwise we'd have to add exception handlers in all functions. Note that the Windows behavior often varies across versions too. So why are we

Re: advapi32: Fix potential NULL pointer dereference in RegSetValueExA [with test] (Saturn)

2009-01-27 Thread Alexandre Julliard
Aurimas Fišeras auri...@gmail.com writes: If FunctionA calls FunctionW with (possibly) NULL pointer and FunctionW dereferences it we should fix FunctionA? If FunctionW requires a valid pointer, then yes of course the caller should be fixed. Just making FunctionW return NOACCESS instead of

Re: Updated DIB Engine

2009-01-27 Thread Roderick Colenbrander
2009/1/27 Massimo Del Fedele m...@veneto.com: Any opinion about this one ? Could it be a good candidate for inclusion in wine tree ? Hi, I have used this with StarCraft, running it with and without the DIB engine enabled. I find the environment variable makes it very easy to switch

DNS10 goes 12 minutes rather than 10 before crashing.

2009-01-27 Thread Susan Cragin
As you may know, Dragon NaturallySpeaking 10 crashes on use with predictable regularity. Used to be every 10 minutes. However, yesterday (and today) that creeped up to 12 minutes. It could be due to anything, but I thought one of you might say EUREKA!! it's the foobar.c part of oleacc!! or

Re: Updated DIB Engine

2009-01-27 Thread Reece Dunn
2009/1/27 Roderick Colenbrander thunderbir...@gmx.net: 2009/1/27 Massimo Del Fedele m...@veneto.com: Any opinion about this one ? Could it be a good candidate for inclusion in wine tree ? I have used this with StarCraft, running it with and without the DIB engine enabled. I find the

Re: DNS10 goes 12 minutes rather than 10 before crashing.

2009-01-27 Thread Reece Dunn
2009/1/27 Susan Cragin susancra...@earthlink.net: As you may know, Dragon NaturallySpeaking 10 crashes on use with predictable regularity. Used to be every 10 minutes. However, yesterday (and today) that creeped up to 12 minutes. It could be due to anything, but I thought one of you might

Re: DNS10 goes 12 minutes rather than 10 before crashing.

2009-01-27 Thread Susan Cragin
As you may know, Dragon NaturallySpeaking 10 crashes on use with predictable regularity. Used to be every 10 minutes. However, yesterday (and today) that creeped up to 12 minutes. It could be due to anything, but I thought one of you might say EUREKA!! it's the foobar.c part of oleacc!! or

Re: Updated DIB Engine

2009-01-27 Thread Jesse Allen
On Tue, Jan 27, 2009 at 12:29 PM, Reece Dunn mscl...@googlemail.com wrote: 2009/1/27 Massimo Del Fedele m...@veneto.com: Any opinion about this one ? Could it be a good candidate for inclusion in wine tree ? Hi, I have used this with StarCraft, running it with and without the DIB engine

Re: D3D: Implement vertex blending in drawStridedSlow

2009-01-27 Thread Paul TBBle Hampson
On Mon, Jan 26, 2009 at 12:19:32PM +0100, Henri Verbeet wrote: 2009/1/26 Paul TBBle Hampson paul.hamp...@pobox.com: On Mon, Jan 26, 2009 at 09:16:12AM +0100, Henri Verbeet wrote: 2009/1/25 Claudio Ciccani k...@users.sf.net: +WORD vertexBlendSW : 1; /* vertexBlend software