On 08/22/2011 07:25 AM, Francois Gouget wrote:
msgid DirectX Diagnostic Tool
-msgstr
+msgstr DirectX Diagnostic Tool
This is sort of a product name os it's always a bit dicey. Still,
wouldn't it be better if 'Diagnostic Tool' was translated? At
non-English speakers would understand
On 06/14/2011 12:18 PM, Dan Kegel wrote:
Isn't Wine was supposed to avoid non-static struct initializers?
I think it'll get warning: initializer element is not computable at
load time with --std=c89 --pedantic.
I believe you're right, and I've sent a patch that avoids the construct.
On 06/15/2011 07:30 AM, Marvin wrote:
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
On 06/06/2011 11:03 AM, Adam Martinson wrote:
+/* Only check this once */
+if (!cache_lastchecked)
+{
+HMODULE hadvapi32 = LoadLibraryA(advapi32.dll);
+#define ADVAPI32_GET_PROC(func) typeof(func) * p ## func =
(void*)GetProcAddress(hadvapi32, #func)
+
On 06/01/2011 11:09 AM, Alexandre Julliard wrote:
Andrew Nguyen angu...@codeweavers.com writes:
On 06/01/2011 07:39 AM, Marvin wrote:
=== WXPPROSP3 (32 bit sock) ===
sock.c:501: Test failed: oob_server (218): unexpectedly at the OOB mark: 0
sock.c:511: Test failed: oob_server (218
On 06/01/2011 07:39 AM, Marvin wrote:
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
a revised version and allow a winner to be
picked?
From 7bdccf239e3accc598eaf9b372a70e28b18f77df Mon Sep 17 00:00:00 2001
From: Andrew Nguyen angu...@codeweavers.com
Date: Tue, 31 May 2011 01:05:15 -0500
Subject: advapi32: Fix last error value of GetUserNameA/W and output buffer
handling
count?
From 8f10b990eac571f10dc376e07096cfc5368dd0e9 Mon Sep 17 00:00:00 2001
From: Andrew Nguyen angu...@codeweavers.com
Date: Thu, 26 May 2011 22:27:26 -0500
Subject: d3d8: Increment the reference count of the IDirect3D8 instance when
creating a device.
To: wine-patches wine-patc...@winehq.org
On 05/31/2011 08:17 AM, Hans Leidekker wrote:
On Tue, 2011-05-31 at 06:32 -0500, Andrew Nguyen wrote:
-DWORD sizeW = *lpSize * 2;
+DWORD sizeW = 0;
+
+GetUserNameW( NULL, sizeW );
Can we avoid the extra call?
I was trying to avoid making the assumption that a Unicode buffer
On 05/31/2011 10:47 AM, Stefan Dösinger wrote:
Does the enum_device_entry structure have to be in ddraw_private.h? I
think you can just declare it in ddraw.c because it is used only there.
No, I simply defined the structure there to be consistent with the role
of the unused structure
On 05/17/2011 09:01 AM, Alexandre Julliard wrote:
Andrew Nguyen angu...@codeweavers.com writes:
---
programs/taskmgr/Da.rc | 11 --
programs/taskmgr/De.rc | 11 --
programs/taskmgr/En.rc | 11 --
programs/taskmgr/Fr.rc | 11 --
programs/taskmgr/He.rc
On 05/17/2011 11:07 AM, Juan Lang wrote:
Hi Andrew,
+GetComputerNameW(name, size);
+hostname_printfW(fmtW, name);
I'm pretty sure that's not what you want. GetComputerName returns the
NetBIOS name of the computer, which is set in the registry.
hostname prints the IP hostname of
On 04/11/2011 12:41 AM, Austin English wrote:
This ignores the side effects of the dwarf2_parse_u2 function.
signature.asc
Description: OpenPGP digital signature
On 03/27/2011 04:52 PM, Joshua Beck wrote:
On a side note, you could rearrange this loop to use less multiplications:
+for(i = 0; i 24; i++)
+{
+int sixi = 6 * i;
+vertices[sixi] *= width;
+vertices[sixi + 1] *= height;
+vertices[sixi + 2] *=
On 03/12/2011 01:10 PM, André Hentschel wrote:
Yeah i know the fixme has good reasons, but still it shouldn't mess on
console.
---
dlls/winex11.drv/xrender.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/dlls/winex11.drv/xrender.c b/dlls/winex11.drv/xrender.c
On 02/21/2011 04:43 AM, Michael Stefaniuc wrote:
Hello Andrew!
Andrew Nguyen wrote:
This lets Wine compile successfully on CentOS 3.
CentOS 3? Alexandre was bitching about RHEL 5 being prediluvian ...
RHEL 3 has a 2.4.21 based kernel, is over 7 years old and EOL. I'm not
sure it is worth
On 01/15/2011 02:53 AM, Marcus Meissner wrote:
On Sat, Jan 15, 2011 at 02:27:49AM -0600, Andrew Nguyen wrote:
---
dlls/msvcr90/tests/msvcr90.c | 27 +--
1 files changed, 21 insertions(+), 6 deletions(-)
diff --git a/dlls/msvcr90/tests/msvcr90.c b/dlls/msvcr90
On 01/11/2011 05:39 AM, Eric Pouech wrote:
Hi Andrew,
I think the test should be enhanced by checking the information about
mouse position
it seems that windows coalesce two mouse messages, but does it also
occur when the position is different (a cursory look seems to indicate
that you
On 01/11/2011 05:32 AM, Marvin wrote:
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
On 01/02/2011 09:32 PM, Marvin wrote:
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
On 01/03/2011 09:37 PM, Marvin wrote:
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
On 01/03/2011 09:25 PM, Rafael Ávila de Espíndola wrote:
I couldn't find any documentation saying that this must be supported,
but running google code search on VerQueryValue.*NULL found some uses.
Cheers,
Rafael
You should write some tests to examine the behavior of VerQueryValue
On 12/31/2010 08:41 AM, Nowres wrote:
Hello,
here's a basic support for Arabic language in user32.dll
work in progress in other programs to complete support for this language.
Nowres Rafid.
Changes should be sent as a patch in unified diff format, preferably
generated with Git.
On 12/20/2010 11:29 AM, Damian Dixon wrote:
+if (!lpservicestatus)
+{
+OSVERSIONINFOW osVi;
+/* Get windows version emulating */
+osVi.dwOSVersionInfoSize = sizeof(osVi);
+GetVersionExW(osVi);
+if (osVi.dwPlatformId == VER_PLATFORM_WIN32_NT)
On Fri, Dec 3, 2010 at 11:21 AM, Mike Gibson
mike.gib...@storagecraft.com wrote:
Had a typo in the first try.
---
dlls/msvcr100/msvcr100.spec | 2 +-
dlls/msvcr70/msvcr70.spec | 2 +-
dlls/msvcr80/msvcr80.spec | 2 +-
dlls/msvcr90/msvcr90.spec | 2 +-
On 10/11/2010 09:52 AM, (Marvin) wrote:
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
On Fri, Sep 24, 2010 at 2:30 AM, Travis Athougies iamm...@gmail.com wrote:
Hi,
I was trying to run my HLSL test suite patch through wine test bot and
the build failed. However, it's not a compilation failure. Instead it
complains about not being able to copy some executable file. Also, the
On Fri, Sep 24, 2010 at 3:25 AM, Travis Athougies iamm...@gmail.com wrote:
Still, I would like for it to be able to be buillt..
While the build failure is concerning, it's somewhat moot given that
the tests don't run anyway:
http://testbot.winehq.org/JobDetails.pl?Key=5450
An XP machine with
2010/9/19 Łukasz Wojniłowicz lukasz.wojnilow...@gmail.com:
+/*
+ * IP configuration utility
+ * English language support
+ *
Pedantically, that should probably be Polish language support.
On Sun, Sep 19, 2010 at 4:05 PM, James McKenzie
jjmckenzi...@earthlink.net wrote:
On 9/19/10 12:03 PM, Andrew Nguyen wrote:
2010/9/19 Łukasz Wojniłowiczlukasz.wojnilow...@gmail.com:
+/*
+ * IP configuration utility
+ * English language support
+ *
Pedantically, that should probably
On Sat, Sep 18, 2010 at 11:37 AM, M Hack mh2...@hotmail.com wrote:
I have Ubuntu 10.04 and the repository ppa:ubuntu-wine/ppa installed. When
following your instructions (http://wiki.winehq.org/winetricks) to run
winetricks I encountered a problem
Entering sh winetricks in a terminal window
On Sun, Aug 22, 2010 at 3:09 AM, wy...@volny.cz wrote:
Thanks for hints, Austin. Unfortunately looking at it and comparing
GOOD vs BAD log did not move me any further. So if anyone would see
there a bug, please let me know. Logs attached.
W.
From the bad configure log:
configure:8817:
On 08/16/2010 01:24 PM, Juan Lang wrote:
Hi Andrew,
+static const WCHAR ethernetW[] = {'E','t','h','e','r','n','e','t',0};
+static const WCHAR unknownW[] = {'U','n','k','n','o','w','n',0};
shouldn't these be resources instead?
--Juan
Hmm, I suppose they probably should be. I was being
On Tue, Aug 3, 2010 at 9:57 PM, Austin English austinengl...@gmail.com wrote:
--
-Austin
The colons aren't decorative separators, but rather determine which
short arguments expect a parameter as per the requirements of
getopt/getopt_long. With your patch applied:
$
On 07/29/2010 10:48 AM, Alexandre Julliard wrote:
Andrew Nguyenangu...@codeweavers.com writes:
@@ -1092,7 +1092,7 @@ static BOOL INT21_CreateFile( CONTEXT86 *context,
winMode, winAttributes, 0 );
/* DOS allows to open files on a CDROM R/W */
On Wed, Jul 28, 2010 at 12:46 PM, Matt 'Murph' Finnicum
mattf...@gmail.com wrote:
This was causing console spam when I played Starcraft 2 (since
dwPlatformId was used uninitialized and thus was invalid).
Hi Matt,
Your patch causes declarations and code in the ImmGetVirtualKey
function to
On Tue, Jul 27, 2010 at 12:59 AM, Austin English
austinengl...@gmail.com wrote:
--
-Austin
The source file seems to use tabs for indentation, so your patch
should do the same.
On Tue, Jul 27, 2010 at 12:53 AM, Austin English
austinengl...@gmail.com wrote:
Addressing Nikolay and Dmitry's comments.
Passed wtb:
https://testbot.winehq.org/JobDetails.pl?Key=3947
--
-Austin
You forgot to attach the patch.
On Sun, Jul 25, 2010 at 2:09 PM, Louis Lenders
xerox_xerox2...@yahoo.co.uk wrote:
fixes http://bugs.winehq.org/show_bug.cgi?id=23528
I don't mean to step on this patch, but I've sent a fuller
implementation of PSPropertyKeyFromString which, if accepted, should
take precedence over this stub.
On 07/25/2010 10:46 PM, (Marvin) wrote:
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
On 07/22/2010 04:32 AM, Paul Vriens wrote:
On 07/20/2010 06:14 AM, Andrew Nguyen wrote:
---
dlls/shlwapi/tests/string.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
This patchset introduces crashes in these tests on W2K, XP and W2K3:
http://test.winehq.org/data/tests
On 07/22/2010 06:03 AM, Paul Vriens wrote:
On 07/22/2010 12:31 PM, Andrew Nguyen wrote:
On 07/22/2010 04:32 AM, Paul Vriens wrote:
On 07/20/2010 06:14 AM, Andrew Nguyen wrote:
---
dlls/shlwapi/tests/string.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
This patchset introduces
On 07/22/2010 07:21 AM, Paul Vriens wrote:
On 07/22/2010 02:03 PM, Andrew Nguyen wrote:
There are a few things I'm wondering about:
When the winetest shlwapi binary was built, what made the compiler
decide to import shell32 for the problematic string functions? Neither
my local cross-compile
On 07/22/2010 09:12 PM, (Marvin) wrote:
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
On 07/19/2010 11:01 AM, Detlef Riekenberg wrote:
Hi Andrew.
While reading your Patches, i stumble over deadbeef.
We use the value 0xdeadbeef almost everywhere in the tests
to initialize a variable to an unusual value.
Using deadbeef as a variable name looks strange and make the
code harder to
I just wanted to note that the test bot failures for the patch series
are pre-existing, and aren't due to the changes in the series.
On 07/09/2010 04:19 AM, (Marvin) wrote:
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at
On Mon, Jun 28, 2010 at 8:16 PM, Austin English austinengl...@gmail.com wrote:
See http://bugs.winehq.org/show_bug.cgi?id=23431
--
-Austin
The NtSystemDebugControl spec types don't match the prototype arguments.
2010/6/28 Austin English austinengl...@gmail.com:
with correct spec file this time
--
-Austin
The spec argument that corresponds to the PULONG prototype argument
should also be ptr.
On Tue, Jun 22, 2010 at 6:13 AM, Nikolay Sivov nsi...@codeweavers.com wrote:
On 6/22/2010 15:09, Andrew Nguyen wrote:
On Tue, Jun 22, 2010 at 5:56 AM, Jaroslav Šmídjardas...@gmail.com
wrote:
- info-WinType.pszCaption=strdupW(info-pCHMInfo-defTitle);
+ info-WinType.pszCaption
On Fri, Jun 18, 2010 at 6:58 PM, Vincent Povirk madewokh...@gmail.com wrote:
Andrew Nguyen
Add windowscodecs
Um, I'm planning to break this soon. We need additional decoders for
d3dx dlls, and I've been told not to make a new dll for them. That
means they either have to go into windowscodecs
On Sun, Jun 6, 2010 at 4:03 PM, Maarten Lankhorst
m.b.lankho...@gmail.com wrote:
Is snd_pcm_recover the only function missing? If so change it to dlsym, and
add a copy of snd_pcm_recover to wine if it cannot find the libalsa one..
Is it a problem to eschew the use of dlsym? It feels like
On Fri, Jun 11, 2010 at 3:34 AM, Maarten Lankhorst
m.b.lankho...@gmail.com wrote:
Hello Andrew,
On 11-06-10 10:18, Andrew Nguyen wrote:
On Sun, Jun 6, 2010 at 4:03 PM, Maarten Lankhorst
m.b.lankho...@gmail.com wrote:
Is snd_pcm_recover the only function missing? If so change it to dlsym
On Sun, Jun 6, 2010 at 2:50 AM, Austin English austinengl...@gmail.com wrote:
See http://bugs.winehq.org/show_bug.cgi?id=23003
--
-Austin
You should probably drop the snd_pcm_hw_params_get_access argument
check, both because it's not the function that's being tested, and
because, as far
I hate to nitpick once more, but there are a few things I noticed. My
alsa-lib tells me:
include/pcm.h:int snd_pcm_recover(snd_pcm_t *pcm, int err, int silent);
Therefore, the statement int ret = snd_pcm_recover(NULL, NULL,
NULL); is somewhat incorrect.
Secondly, I think it should be sufficient
On Fri, Jun 4, 2010 at 3:35 PM, John Voltz john.vo...@gmail.com wrote:
Is there are way around it without having to change them all to //?
For private, ad-hoc use, you could possibly use a preprocessor #if 0
block to achieve the desired comment effect.
On 06/03/2010 03:15 AM, Hans Leidekker wrote:
On Thu, 2010-06-03 at 03:01 -0500, Andrew Nguyen wrote:
This pleases the Actel Libero IDE installer.
---
dlls/msi/version.rc |8
1 files changed, 4 insertions(+), 4 deletions(-)
I think we should delay this until 1.2 is released
On Sun, May 30, 2010 at 11:48 PM, David Adam david.adam.c...@gmail.com wrote:
Hello,
I tried these tests with my Vista box. All they passed.
Can anyone test on a real Windows XP box or a real Windows box?
Thanks in advance
David
You can submit tests to the WineTestBot service for
On Mon, May 31, 2010 at 5:33 AM, Henri Verbeet hverb...@gmail.com wrote:
On 31 May 2010 12:29, Andrew Nguyen arethus...@gmail.com wrote:
I have taken the liberty of submitting your patch for you, and found
no test failures:
https://testbot.winehq.org/JobDetails.pl?Key=2397
Yeah, but that's
On Sat, May 22, 2010 at 2:06 AM, Austin English austinengl...@gmail.com wrote:
Also fix a typo.
Passes WTB:
https://testbot.winehq.org/JobDetails.pl?Key=2242
--
-Austin
While you're at it, you might as well fix the change typo.
On Sat, May 22, 2010 at 5:02 AM, Austin English austinengl...@gmail.com wrote:
Changes from try 1:
Fix another typo.
Set LastError before checking it
Print LastError as a decimal
Don't check for INVALID_HANDLE_VALUE as a return value of
CreateThread, instead make sure serverThread is not
On 05/03/2010 10:19 AM, Alexandre Julliard wrote:
Andrew Nguyenangu...@codeweavers.com writes:
---
programs/rundll32/rundll32.c | 16 +---
1 files changed, 13 insertions(+), 3 deletions(-)
This will prevent initializing the prefix without an X display. Why do
you need
On Thu, Apr 8, 2010 at 3:09 AM, Nikolay Sivov bungleh...@gmail.com wrote:
On 4/7/2010 17:12, Troy Wolbrink wrote:
I’ve found the winetricks script invaluable in trying to get my app running
on Wine. But I found that when installing msxml6, I needed to change the
overrides for msi.dll and
On Tue, Mar 23, 2010 at 5:47 AM, Alexandre Julliard julli...@winehq.org wrote:
Andrew Nguyen arethus...@gmail.com writes:
@@ -221,9 +221,17 @@ static HRESULT WINAPI
IDxDiagContainerImpl_GetProp(PDXDIAGCONTAINER iface, LPCWS
p = This-properties;
while (NULL != p) {
- if (0
On Sun, Mar 14, 2010 at 3:05 PM, Vitaliy Margolen
wine-de...@kievinfo.com wrote:
On 03/14/2010 11:03 AM, Andrew Nguyen wrote:
---
dlls/dxdiagn/container.c | 15 +--
dlls/dxdiagn/tests/container.c | 49
2 files changed, 56
On Sun, Mar 14, 2010 at 3:08 PM, Vitaliy Margolen
wine-de...@kievinfo.com wrote:
On 03/14/2010 11:04 AM, Andrew Nguyen wrote:
--- a/dlls/dxdiagn/container.c
+++ b/dlls/dxdiagn/container.c
@@ -97,12 +97,10 @@ static HRESULT WINAPI
IDxDiagContainerImpl_EnumChildContainerNames(PDXDIAGCONTAI
On Sat, Mar 13, 2010 at 12:27 PM, Paul Vriens
paul.vriens.w...@gmail.com wrote:
On 03/13/2010 05:19 PM, Andrew Nguyen wrote:
+ /* Test the conditions in which the output buffer can be modified. */
+ lstrcpyW(container, testW);
+ hr = IDxDiagContainer_EnumChildContainerNames(pddc, 0
On Thu, Feb 18, 2010 at 8:51 PM, Erich Hoover ehoo...@mines.edu wrote:
Real Name:
Erich Hoover
Description:
The attached patch adds a test for
SetThreadAffinityMask(thread,-1), which succeeds on Windows Vista and
newer. This all processors flag is not documented, but was
discovered
On Tue, Feb 2, 2010 at 4:58 AM, Alexandre Julliard julli...@winehq.org wrote:
Andrew Nguyen arethus...@gmail.com writes:
Invalid pointers appear to be handled by getpeername in all versions
of Windows, so adding an exception handler seems to be justified.
It's only justified
On Mon, Jan 18, 2010 at 8:46 AM, Alexandre Julliard julli...@winehq.org wrote:
Andrew Nguyen arethus...@gmail.com writes:
This seemed to be the easiest and most trivial way to allow
MAPIInitialize to succeed in the tests, which will be added in the
next several patches.
That doesn't seem
On Tue, Jan 12, 2010 at 6:09 PM, Austin English austinengl...@gmail.com wrote:
Is there any chance of a different license? Wine is currently LGPL
2.1, it'd be nice to have the same license, if possible...
I thought the AppDB code was under the GPLv2, judging from the LICENSE file.
On Sun, Apr 19, 2009 at 5:04 PM, Kai Blin kai.b...@gmail.com wrote:
On Sunday 19 April 2009 23:55:14 Kai Blin wrote:
As mentioned by the authors of Publish or Perish in their FAQ
(http://www.harzing.com/pop_faq.htm#Q309), Wine exporting sxs.dll and not
providing a real CreateAssemblyCache
On Sat, Jan 24, 2009 at 12:42 AM, Vincent Povirk
madewokherd+8...@gmail.com wrote:
In several cases we call delete_element(x) after x has been set to
NULL or after an unsuccessful clone_element(y, x) call. clone_element
always gives a NULL element pointer when it fails.
delete_element(NULL)
On Sun, Jan 11, 2009 at 12:52 PM, Erich Hoover ehoo...@mines.edu wrote:
Real Name:
Erich Hoover
Description:
Fix a problem with Wine's cmd.exe that causes redirecting a pipe to
another pipe to fail. Can be tested by executing 'echo test 21'
in cmd.exe. Without the patch the redirect
Hello,
I've written a few patches against dlls/msi/action.c in an effort to
rectify a difference in behavior with an MSI-based installer between
Windows and Wine with regard to environment variable processing.
Behavior not explicitly enumerated by MSDN is noted when a combination
of the
On Tue, Jan 6, 2009 at 8:21 AM, Andrey Turkin andrey.tur...@gmail.com wrote:
.NET 1.1 uses this dll during installation
---
configure.ac |1 +
dlls/loadperf/Makefile.in | 13 +
dlls/loadperf/loadperf.spec | 14 ++
On Sun, Oct 19, 2008 at 3:53 AM, Roderick Colenbrander
[EMAIL PROTECTED] wrote:
Hi,
Since you mentioned in your first patch that this fix is inspired by behavior
on Windows, please add a test to our test suite to prove it.
Roderick
Where would the conformance tests for winex11.drv be
76 matches
Mail list logo
