[Wireshark-commits] master-2.6 9ac3b9f: [Automatic update for 2020-08-23]

2020-08-23 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9ac3b9ff81e107fb3da733c4899eb61063056f64
Submitter: "Gerald Combs "
Changed: branch: master-2.6
Repository: wireshark

Commits:

9ac3b9f by Gerald Combs (ger...@wireshark.org):

[Automatic update for 2020-08-23]

Update manuf, services enterprise numbers, translations, and other items.

Change-Id: Iaffa821af44b8cecdd29d0ed08c53d472373f751
Reviewed-on: https://code.wireshark.org/review/38235
Reviewed-by: Gerald Combs 


Actions performed:

from  20c1740   [Automatic update for 2020-08-16]
 add  9ac3b9f   [Automatic update for 2020-08-23]


Summary of changes:
 NEWS|   2 +-
 enterprises.tsv |  40 +-
 manuf   | 102 
 3 files changed, 128 insertions(+), 16 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-3.0 00c2221: [Automatic update for 2020-08-23]

2020-08-23 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=00c222139c0b56ffb0f5bf3dc9514ea4fc0ebfcd
Submitter: "Gerald Combs "
Changed: branch: master-3.0
Repository: wireshark

Commits:

00c2221 by Gerald Combs (ger...@wireshark.org):

[Automatic update for 2020-08-23]

Update manuf, services enterprise numbers, translations, and other items.

Change-Id: Iab2b567e97796a3e2aacb6f6e9a6225a20234d47
Reviewed-on: https://code.wireshark.org/review/38234
Reviewed-by: Gerald Combs 


Actions performed:

from  437d919   PROFINET: DHCP suboption undefined bytes
 add  00c2221   [Automatic update for 2020-08-23]


Summary of changes:
 NEWS|   2 +-
 enterprises.tsv |  40 +-
 manuf   | 102 
 3 files changed, 128 insertions(+), 16 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-3.2 f7fe8b7: [Automatic update for 2020-08-23]

2020-08-23 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f7fe8b73d618115cbb9c6c303bf4521d28fe2ea6
Submitter: "Gerald Combs "
Changed: branch: master-3.2
Repository: wireshark

Commits:

f7fe8b7 by Gerald Combs (ger...@wireshark.org):

[Automatic update for 2020-08-23]

Update manuf, services enterprise numbers, translations, and other items.

Change-Id: Ib6a0a4113cdfa5388482f175bf0d2bb478a3cace
Reviewed-on: https://code.wireshark.org/review/38233
Reviewed-by: Gerald Combs 


Actions performed:

from  f4db9ac   dicom: Handle frames with segments from different 
reassemblies
 add  f7fe8b7   [Automatic update for 2020-08-23]


Summary of changes:
 AUTHORS |   2 ++
 NEWS|   2 +-
 enterprises.tsv |  40 +-
 manuf   | 102 
 4 files changed, 130 insertions(+), 16 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 69ab0b0: [Automatic update for 2020-08-23]

2020-08-23 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=69ab0b00afd1a5ded9d86214bd1c2c134e028d3b
Submitter: "Gerald Combs "
Changed: branch: master
Repository: wireshark

Commits:

69ab0b0 by Gerald Combs (ger...@wireshark.org):

[Automatic update for 2020-08-23]

Update manuf, services enterprise numbers, translations, and other items.

Change-Id: Id646b743f1634e9deb29f05186eb1ff87b3bc73a
Reviewed-on: https://code.wireshark.org/review/38232
Reviewed-by: Gerald Combs 


Actions performed:

from  a422865   Only do trailing stray character checks on FT_STRING fields.
 add  69ab0b0   [Automatic update for 2020-08-23]


Summary of changes:
 NEWS |  19 -
 enterprises.tsv  |  40 ++-
 manuf| 102 ---
 ui/qt/wireshark_de.ts|  28 ++---
 ui/qt/wireshark_es.ts|   2 +-
 ui/qt/wireshark_it.ts|  28 ++---
 ui/qt/wireshark_ja_JP.ts |   2 +-
 ui/qt/wireshark_pl.ts|   2 +-
 ui/qt/wireshark_ru.ts|   2 +-
 ui/qt/wireshark_sv.ts|   2 +-
 ui/qt/wireshark_zh_CN.ts |   2 +-
 11 files changed, 171 insertions(+), 58 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master a422865: Only do trailing stray character checks on FT_STRING fields.

2020-08-22 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a42286524a0e23f5944e988e672a07a5fb395c69
Submitter: "Guy Harris "
Changed: branch: master
Repository: wireshark

Commits:

a422865 by Guy Harris (ghar...@sonic.net):

Only do trailing stray character checks on FT_STRING fields.

FT_STRINGZ means "terminated by a null character", so there can't be
non-null characters following the terminating null.

FT_STRINGZPAD doesn't only mean "padded with nulls"; there are protocols
where a string that's not the full length of the part of the packet for
the string has a null terminator but isn't guaranteed to be fully padded
with nulls.  We can later add a separate type for fields where we really
*should* check that the padding is all nulls.

Change-Id: I5964817b4b847cb4db73f8ac673141052e8ef92c
Reviewed-on: https://code.wireshark.org/review/38230
Petri-Dish: Guy Harris 
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris 


Actions performed:

from  b228b5a   Add Arinc 615A dissector
 add  a422865   Only do trailing stray character checks on FT_STRING fields.


Summary of changes:
 epan/proto.c | 38 +-
 1 file changed, 29 insertions(+), 9 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master b228b5a: Add Arinc 615A dissector

2020-08-22 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b228b5a1b19bb70868abe6ecf1415ea723b2ff25
Submitter: "Pascal Quantin "
Changed: branch: master
Repository: wireshark

Commits:

b228b5a by Roman-Koshelev (roman.koshe...@bk.ru):

Add Arinc 615A dissector

Bug: 16767
Change-Id: I70a6672d46ac1ea6e495759a47a13b0b8b0c9f33
Signed-off-by: Roman-Koshelev 
Reviewed-on: https://code.wireshark.org/review/38112
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin 


Actions performed:

from  f91e653   lldp: show the Protocol Identity as bytes, not a text 
string.
 add  b228b5a   Add Arinc 615A dissector


Summary of changes:
 docbook/release-notes.adoc |   1 +
 epan/dissectors/CMakeLists.txt |   1 +
 epan/dissectors/packet-arinc615a.c | 399 +
 3 files changed, 401 insertions(+)
 create mode 100644 epan/dissectors/packet-arinc615a.c
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master f91e653: lldp: show the Protocol Identity as bytes, not a text string.

2020-08-21 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f91e6535c2aa17466a06bcaf62f4019df5b2ee68
Submitter: "Guy Harris "
Changed: branch: master
Repository: wireshark

Commits:

f91e653 by Guy Harris (ghar...@sonic.net):

lldp: show the Protocol Identity as bytes, not a text string.

Section D.2.4.3 "protocol identity" of IEEE 802.1Q-2018 says:

The protocol identity field shall contain the first n octets of the
protocol after the layer 2 addresses (i.e., for example, starting
with the EtherType field) that the sender would like to advertise.

Show it as FT_BYTES, not FT_STRINGZ.

Add a comment explaining that, and expand a comment to indicate what
specifications there are for LLDP and some Organizationally Specific
TLVs.

Change-Id: I8c41026379731d1c05134d6e7ad563227f9fbfde
Reviewed-on: https://code.wireshark.org/review/38229
Petri-Dish: Guy Harris 
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris 


Actions performed:

from  82a4968   plugin_if: add plugin_if_get_frame_data() and 
plugin_if_get_capture_file()
 add  f91e653   lldp: show the Protocol Identity as bytes, not a text 
string.


Summary of changes:
 epan/dissectors/packet-lldp.c | 34 --
 1 file changed, 32 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 82a4968: plugin_if: add plugin_if_get_frame_data() and plugin_if_get_capture_file()

2020-08-21 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=82a4968bc31b8fa85a3f45a583d8f7f71bd6737f
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

82a4968 by Tomas Kukosa (kuk...@herman.cz):

plugin_if: add plugin_if_get_frame_data() and plugin_if_get_capture_file()

Change-Id: I7505d4185f18d13d6836c9c9bb8f400d12f2a524
Reviewed-on: https://code.wireshark.org/review/38217
Petri-Dish: Tomáš Kukosa 
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall 


Actions performed:

from  7e46db8   gnutella: add a comment about the character encoding.
 add  82a4968   plugin_if: add plugin_if_get_frame_data() and 
plugin_if_get_capture_file()


Summary of changes:
 debian/libwireshark0.symbols |  2 ++
 epan/plugin_if.c | 34 +++
 epan/plugin_if.h | 14 ++
 plugins/epan/pluginifdemo/pluginifdemo.c | 23 ++--
 ui/qt/main_window.cpp| 46 
 5 files changed, 117 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 7e46db8: gnutella: add a comment about the character encoding.

2020-08-21 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7e46db8f866abae189f0d4cf616d4c4f733f2239
Submitter: "Guy Harris "
Changed: branch: master
Repository: wireshark

Commits:

7e46db8 by Guy Harris (ghar...@sonic.net):

gnutella: add a comment about the character encoding.

Change-Id: I9daf9a5de2e49c5d6e16780254db045b673999f5
Reviewed-on: https://code.wireshark.org/review/38228
Reviewed-by: Guy Harris 


Actions performed:

from  ae9f431   wmem_strbuf: add comments asking whether some checks are 
necessary.
 add  7e46db8   gnutella: add a comment about the character encoding.


Summary of changes:
 epan/dissectors/packet-gnutella.c | 16 
 1 file changed, 16 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master ae9f431: wmem_strbuf: add comments asking whether some checks are necessary.

2020-08-21 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ae9f431c0973b106012bdce483bc59970d85877a
Submitter: "Guy Harris "
Changed: branch: master
Repository: wireshark

Commits:

ae9f431 by Guy Harris (ghar...@sonic.net):

wmem_strbuf: add comments asking whether some checks are necessary.

Change-Id: I5a918eba4301aea64c58a8ada89b4daa49fb8c87
Reviewed-on: https://code.wireshark.org/review/38226
Reviewed-by: Guy Harris 


Actions performed:

from  c542e24   tds: update URLs.
 add  ae9f431   wmem_strbuf: add comments asking whether some checks are 
necessary.


Summary of changes:
 epan/wmem/wmem_strbuf.c | 7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master c542e24: tds: update URLs.

2020-08-21 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c542e2476c19142a5e50dcdb006bfd64084fef02
Submitter: "Guy Harris "
Changed: branch: master
Repository: wireshark

Commits:

c542e24 by Guy Harris (ghar...@sonic.net):

tds: update URLs.

Fix some Wayback Machine URLs that no longer work because the
wayback.archive.org domain name no longer works.

Update some Microsoft URLs that used to go through the Wayback Machine
to point to the current versions at docs.microsoft.com.

Update a comment to reflect the disappearance of a Network Associates
document and its absence from the Wayback Machine.

Change-Id: I27a5b19fa7747a8f601fd9e6c0bf75aba0a3528e
Reviewed-on: https://code.wireshark.org/review/38225
Reviewed-by: Guy Harris 


Actions performed:

from  cc84e6a   mysql: add more URLs.
 add  c542e24   tds: update URLs.


Summary of changes:
 epan/dissectors/packet-tds.c | 11 ++-
 1 file changed, 6 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master cc84e6a: mysql: add more URLs.

2020-08-21 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cc84e6a4e59eaf1c436c4ffc022c979226aa96e3
Submitter: "Guy Harris "
Changed: branch: master
Repository: wireshark

Commits:

cc84e6a by Guy Harris (ghar...@sonic.net):

mysql: add more URLs.

Add URLs from newer versions of the protocol documentation.

Change-Id: I03d6b4d34ce7f7b831a4eda3075b65b026f96526
Reviewed-on: https://code.wireshark.org/review/38224
Reviewed-by: Guy Harris 


Actions performed:

from  0815888   hiqnet: update URL, use HTTPS One More Place.
 add  cc84e6a   mysql: add more URLs.


Summary of changes:
 epan/dissectors/packet-mysql.c | 3 +++
 1 file changed, 3 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 0815888: hiqnet: update URL, use HTTPS One More Place.

2020-08-21 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=08158882afa2b4d2befc66eedb8c33aea741f483
Submitter: "Guy Harris "
Changed: branch: master
Repository: wireshark

Commits:

0815888 by Guy Harris (ghar...@sonic.net):

hiqnet: update URL, use HTTPS One More Place.

Update one URL to a newer location and newer version of the document;
change the other one to use HTTPS.

Change-Id: I18bb2a14722c4e340a3e5f1afe0198def9d4fceb
Reviewed-on: https://code.wireshark.org/review/38223
Reviewed-by: Guy Harris 


Actions performed:

from  0580dc7   dmp: add the Wayback Machine version of a URL.
 add  0815888   hiqnet: update URL, use HTTPS One More Place.


Summary of changes:
 epan/dissectors/packet-hiqnet.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 0580dc7: dmp: add the Wayback Machine version of a URL.

2020-08-21 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0580dc7677db9c2f9564182286c11f202f90debe
Submitter: "Guy Harris "
Changed: branch: master
Repository: wireshark

Commits:

0580dc7 by Guy Harris (ghar...@sonic.net):

dmp: add the Wayback Machine version of a URL.

The original document no longer appears to be available; point to the
Wayback Machine version.

Change-Id: I9f0b0742339cc7a982e638cbae5155e9ac6c1d20
Reviewed-on: https://code.wireshark.org/review/38222
Reviewed-by: Guy Harris 


Actions performed:

from  be8315e   GBCS: Add alert clock not adjusted outside tolerance
 add  0580dc7   dmp: add the Wayback Machine version of a URL.


Summary of changes:
 epan/dissectors/packet-dmp.c | 1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master be8315e: GBCS: Add alert clock not adjusted outside tolerance

2020-08-21 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=be8315eeac7e6def5191bb75232d21f8a908eff7
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

be8315e by Kenneth Soerensen (knnthsr...@gmail.com):

GBCS: Add alert clock not adjusted outside tolerance

Change-Id: Id41647e359c582aa287b605dba077ef9cfd4d7fc
Reviewed-on: https://code.wireshark.org/review/38219
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  f436253   indigocare-netrix: use a string encoding for all 
tvb_get_string_enc() calls.
 add  be8315e   GBCS: Add alert clock not adjusted outside tolerance


Summary of changes:
 epan/dissectors/packet-gbcs.c | 1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master f436253: indigocare-netrix: use a string encoding for all tvb_get_string_enc() calls.

2020-08-21 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f43625386a7a58d47f0dc313f9980962cd8444bc
Submitter: "Guy Harris "
Changed: branch: master
Repository: wireshark

Commits:

f436253 by Guy Harris (ghar...@sonic.net):

indigocare-netrix: use a string encoding for all tvb_get_string_enc() calls.

Don't just pass ENC_NA, pass ENC_ASCII|ENC_NA, to mark all string
fetches with the encoding to use.

Change-Id: Icbe533b8e36d6df25841049950512cecd4c247a1
Reviewed-on: https://code.wireshark.org/review/38221
Reviewed-by: Guy Harris 


Actions performed:

from  5dec9f9   indigocare-icall: use a string encoding for all 
tvb_get_string_enc() calls.
 add  f436253   indigocare-netrix: use a string encoding for all 
tvb_get_string_enc() calls.


Summary of changes:
 epan/dissectors/packet-indigocare-netrix.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 5dec9f9: indigocare-icall: use a string encoding for all tvb_get_string_enc() calls.

2020-08-21 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5dec9f91fcd3ab246cf54d9bc26b91c88a3913ea
Submitter: "Guy Harris "
Changed: branch: master
Repository: wireshark

Commits:

5dec9f9 by Guy Harris (ghar...@sonic.net):

indigocare-icall: use a string encoding for all tvb_get_string_enc() calls.

Don't just pass ENC_NA, pass ENC_ASCII|ENC_NA, to mark all string
fetches with the encoding to use.

Change-Id: If834f216a49787ff09b3b714d755d9467848e5a5
Reviewed-on: https://code.wireshark.org/review/38220
Reviewed-by: Guy Harris 


Actions performed:

from  421db8b   proxy: add AWS TLV (VPCE)
 add  5dec9f9   indigocare-icall: use a string encoding for all 
tvb_get_string_enc() calls.


Summary of changes:
 epan/dissectors/packet-indigocare-icall.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 421db8b: proxy: add AWS TLV (VPCE)

2020-08-21 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=421db8b0198e8b81565dfed57ef3a0ae848902d8
Submitter: "Jaap Keuter "
Changed: branch: master
Repository: wireshark

Commits:

421db8b by Alexis La Goutte (alexis.lagou...@gmail.com):

proxy: add AWS TLV (VPCE)

Change-Id: I1a0d8fd3dd9c5a0fc3b414c1dff40340df0afc73
Reviewed-on: https://code.wireshark.org/review/29709
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot
Reviewed-by: Jaap Keuter 


Actions performed:

from  6dc6d26   SMB2: Add TC reserved flags field
 add  421db8b   proxy: add AWS TLV (VPCE)


Summary of changes:
 epan/dissectors/packet-proxy.c | 2 ++
 1 file changed, 2 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 6dc6d26: SMB2: Add TC reserved flags field

2020-08-21 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6dc6d26768a08a9ad23970782a242219dd911e97
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

6dc6d26 by Alexis La Goutte (alexis.lagou...@gmail.com):

SMB2: Add TC reserved flags field

Change-Id: Idc23fcc876f3e5e8bd83118ff6c5708c55e422f0
Reviewed-on: https://code.wireshark.org/review/38216
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot
Reviewed-by: ronnie sahlberg 


Actions performed:

from  81651fa   SMB2: use tfs set_notset
 add  6dc6d26   SMB2: Add TC reserved flags field


Summary of changes:
 epan/dissectors/packet-smb2.c | 7 +++
 1 file changed, 7 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 81651fa: SMB2: use tfs set_notset

2020-08-21 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=81651fa34fefcd35b191d94966c1efc0098653d5
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

81651fa by Alexis La Goutte (alexis.lagou...@gmail.com):

SMB2: use tfs set_notset

Change-Id: I1287d449b1f20a4da625d2629226573cc5497db3
Reviewed-on: https://code.wireshark.org/review/38215
Reviewed-by: ronnie sahlberg 


Actions performed:

from  fa6f268   gearman: expand a comment.
 add  81651fa   SMB2: use tfs set_notset


Summary of changes:
 epan/dissectors/packet-smb2.c | 21 +++--
 1 file changed, 3 insertions(+), 18 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master fa6f268: gearman: expand a comment.

2020-08-21 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fa6f2681e38378685e75c2fc7fe15ad8226e68ad
Submitter: "Guy Harris "
Changed: branch: master
Repository: wireshark

Commits:

fa6f268 by Guy Harris (ghar...@sonic.net):

gearman: expand a comment.

Change-Id: I886f8a6b55e908f2c55f2a45f90dc7e6411467e5
Reviewed-on: https://code.wireshark.org/review/38218
Reviewed-by: Guy Harris 


Actions performed:

from  132d6ec   gsmtap: Add support for E1/T1 traces
 add  fa6f268   gearman: expand a comment.


Summary of changes:
 epan/dissectors/packet-gearman.c | 4 
 1 file changed, 4 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-3.2 f4db9ac: dicom: Handle frames with segments from different reassemblies

2020-08-21 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f4db9acd5f4df2bdad43401b1df9f3c259598519
Submitter: "Anders Broman "
Changed: branch: master-3.2
Repository: wireshark

Commits:

f4db9ac by John Thacker (johnthac...@gmail.com):

dicom: Handle frames with segments from different reassemblies

There can be multiple PDV segments in the same frame that belong to
different reassemblies. Change the reassembly_id used for the
reassembly tables so that it is not identical for all segments in
the same presentation context (but still unique for a given reassembly),
so that that case can be handled properly. Otherwise fragment_add_seq_next
will retrieve the wrong reassembly for one of the segments (especially
on the second pass.)

Bug: 13110
Change-Id: Ib967fc7f6b7b591b9e3494d81d3b5d4ecc43cac1
Reviewed-on: https://code.wireshark.org/review/38200
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 
(cherry picked from commit df69e61cb6bc3910975d864175a1f64476fcd25c)
Reviewed-on: https://code.wireshark.org/review/38207
Reviewed-by: Jaap Keuter 
Petri-Dish: Jaap Keuter 


Actions performed:

from  f404b09   PROFINET: DHCP suboption undefined bytes
 add  f4db9ac   dicom: Handle frames with segments from different 
reassemblies


Summary of changes:
 epan/dissectors/packet-dcm.c | 16 +++-
 1 file changed, 15 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 132d6ec: gsmtap: Add support for E1/T1 traces

2020-08-20 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=132d6ec70bd9e17e124e4f94537c903bd4b286d7
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

132d6ec by Harald Welte (lafo...@osmocom.org):

gsmtap: Add support for E1/T1 traces

GSMTAP has recently gained support for wrapping E1/T1 protocol traces.
This is very useful as contrary to pcap/wtap file based protocol traces,
GSMTAP can be streamed in real-time.

The GSMTAP pseudo-header encodes information such as
* the E1/T1 timeslot number
* the E1/T1 subeslot number (if I.460 is used)
* the E1/T1 line/span number (somewhat awkwardly as 'antenna number')
* the payload (LAPD, Frame Relay, TRAU, ...)

In this first implementation in wireshark, only FR and LAPD
sub-dissectors are added. The other payloads (TRAU) do not have any
wireshark dissectors so far.

Change-Id: Ib699e9231ef7b9e6c5053e6b920954b3e7b0a4a4
Reviewed-on: https://code.wireshark.org/review/38213
Reviewed-by: Vadim Yanitskiy 
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  4dac9c2   packet-q933: Decode LINK INTEGRITY + PVC STATUS IEs without 
codeset
 add  132d6ec   gsmtap: Add support for E1/T1 traces


Summary of changes:
 epan/dissectors/packet-gsmtap.c | 33 +
 epan/dissectors/packet-gsmtap.h |  9 +
 2 files changed, 42 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 217a929: FSSO: Fix when additionnal data is not coming from TSAgent

2020-08-20 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=217a92981b04de74051b243ac6c8eea32f44b848
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

217a929 by Alexis La Goutte (alexis.lagou...@gmail.com):

FSSO: Fix when additionnal data is not coming from TSAgent

There is IPv4 Address/ 6 null bytes / IPv4 Address

IPv4 Address is client ? DC ?

Bug: 16657
Change-Id: Ie09f4598e18e26c95d297e3c622c80d3395d25d4
Reviewed-on: https://code.wireshark.org/review/38196
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  e59b3c2   tvb: add tvb_get_bits_array
 add  217a929   FSSO: Fix when additionnal data is not coming from TSAgent


Summary of changes:
 epan/dissectors/packet-fortinet-sso.c | 52 +--
 1 file changed, 38 insertions(+), 14 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 4dac9c2: packet-q933: Decode LINK INTEGRITY + PVC STATUS IEs without codeset

2020-08-20 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4dac9c2c53d4fd1e3ea2c4a5018ad8f2c9d90410
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

4dac9c2 by Harald Welte (lafo...@osmocom.org):

packet-q933: Decode LINK INTEGRITY + PVC STATUS IEs without codeset

I cannot find any mention in Q.933 that those two information elements
should not be present in CS0.  In fact, multiple real-world traces
I just recently took from Cisco and Ericsson equipment encodes
those IEs in normal codset 0.

This appears to have been broken since commit
bafebc7b806e800741f8e982dd20e57ff69b1d28 in 2005, when the code was
first introduced.

Change-Id: I4c0ad080447d492b541cf7abd1e3f24a0e85084a
Reviewed-on: https://code.wireshark.org/review/38212
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  e7116cc   packet-fr: Treat DLCI=0 as Q.933 LMI if GPRS-NS is selected
 add  4dac9c2   packet-q933: Decode LINK INTEGRITY + PVC STATUS IEs without 
codeset


Summary of changes:
 epan/dissectors/packet-q933.c | 2 ++
 1 file changed, 2 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e7116cc: packet-fr: Treat DLCI=0 as Q.933 LMI if GPRS-NS is selected

2020-08-20 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e7116cca75937d96d5795340388a519ee8e6f882
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

e7116cc by Harald Welte (lafo...@osmocom.org):

packet-fr: Treat DLCI=0 as Q.933 LMI if GPRS-NS is selected

3GPP TS 48.016 specifies GPRS-NS over Frame Reley. In Section
6.1.1 it explicitly states that ITU-T Q.933 Annex A for FR PVC
must be supported.  In real-world Gb-over-FR protocol traces I also
see related LMI messages on DLCI=0.

Hence, let's not dispatch DLCI=0 messages to the GPRS-NS dissector,
where they are all detected wrongly.  Only non-zero DLCI are NS-VC.

Change-Id: I6ce3557cda0da31323a851008bf648047ba1f926
Reviewed-on: https://code.wireshark.org/review/38211
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  217a929   FSSO: Fix when additionnal data is not coming from TSAgent
 add  e7116cc   packet-fr: Treat DLCI=0 as Q.933 LMI if GPRS-NS is selected


Summary of changes:
 epan/dissectors/packet-fr.c | 14 --
 1 file changed, 12 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master bd7d074: couchbase: fix conflict

2020-08-20 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bd7d0742db79d5db84cdabe412484e65ed98c1d7
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

bd7d074 by Tomas Kukosa (kuk...@herman.cz):

couchbase: fix conflict

'couchbase.flex_frame_extras' exists multiple times with incompatible 
types: FT_STRING and FT_UINT8

Change-Id: Ide607ca786e19015f4aae3cfbe85675581968267
Reviewed-on: https://code.wireshark.org/review/38011
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  77b67c73  dcerpc: add more URLs.
 add  bd7d074   couchbase: fix conflict


Summary of changes:
 epan/dissectors/packet-couchbase.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e59b3c2: tvb: add tvb_get_bits_array

2020-08-20 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e59b3c23381f8f79a3d950e8509b6f84b2956ce7
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

e59b3c2 by Filipe Laíns (la...@archlinux.org):

tvb: add tvb_get_bits_array

Change-Id: I2fad824ca417dcd089fabfdf06f28529c7ee9e87
Signed-off-by: Filipe Laíns 
Reviewed-on: https://code.wireshark.org/review/37949
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  bd7d074   couchbase: fix conflict
 add  e59b3c2   tvb: add tvb_get_bits_array


Summary of changes:
 debian/libwireshark0.symbols |  2 ++
 epan/tvbuff.c| 13 +
 epan/tvbuff.h|  4 
 3 files changed, 19 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 77b67c73: dcerpc: add more URLs.

2020-08-20 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=77b67c735787071f2ce586a947ccb46f149ac686
Submitter: "Guy Harris "
Changed: branch: master
Repository: wireshark

Commits:

77b67c73 by Guy Harris (ghar...@sonic.net):

dcerpc: add more URLs.

https://pubs.opengroup.org/onlinepubs/009629399/ dumps you into a
directory; give URLs that take you to the table of contents for the HTML
and PDF versions.

Change-Id: I45da12025f27a0c101087fd12d2de75a0720baa6
Reviewed-on: https://code.wireshark.org/review/38214
Reviewed-by: Guy Harris 


Actions performed:

from  4707c16   X2AP: upgrade dissector to v16.2.0
 add  77b67c73  dcerpc: add more URLs.


Summary of changes:
 epan/dissectors/packet-dcerpc.c | 2 ++
 1 file changed, 2 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 4707c16: X2AP: upgrade dissector to v16.2.0

2020-08-20 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4707c16adde2e002b82d54202117b1df58a5c215
Submitter: "Pascal Quantin "
Changed: branch: master
Repository: wireshark

Commits:

4707c16 by Pascal Quantin (pas...@wireshark.org):

X2AP: upgrade dissector to v16.2.0

Change-Id: I6fc049e0ce07d3938e486c4e6075d70340b3e3e2
Reviewed-on: https://code.wireshark.org/review/38208
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin 


Actions performed:

from  df69e61   dicom: Handle frames with segments from different 
reassemblies
 add  4707c16   X2AP: upgrade dissector to v16.2.0


Summary of changes:
 epan/dissectors/asn1/lte-rrc/lte-rrc.cnf   |   18 +
 .../asn1/lte-rrc/packet-lte-rrc-template.c |5 +-
 epan/dissectors/asn1/ngap/ngap.cnf |2 +
 epan/dissectors/asn1/nr-rrc/nr-rrc.cnf |2 +
 epan/dissectors/asn1/x2ap/X2AP-CommonDataTypes.asn |2 +-
 epan/dissectors/asn1/x2ap/X2AP-Constants.asn   |  101 +-
 epan/dissectors/asn1/x2ap/X2AP-Containers.asn  |2 +-
 epan/dissectors/asn1/x2ap/X2AP-IEs.asn |  644 ++-
 epan/dissectors/asn1/x2ap/X2AP-PDU-Contents.asn|  543 +-
 .../dissectors/asn1/x2ap/X2AP-PDU-Descriptions.asn |   80 +-
 epan/dissectors/asn1/x2ap/packet-x2ap-template.c   |   78 +-
 epan/dissectors/asn1/x2ap/x2ap.cnf |  332 +-
 epan/dissectors/packet-lte-rrc.c   |  155 +-
 epan/dissectors/packet-lte-rrc.h   |   10 +
 epan/dissectors/packet-ngap.c  |  266 +-
 epan/dissectors/packet-ngap.h  |1 +
 epan/dissectors/packet-nr-rrc.c|   15 +
 epan/dissectors/packet-nr-rrc.h|1 +
 epan/dissectors/packet-x2ap.c  | 5975 
 19 files changed, 6912 insertions(+), 1320 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-3.2 f404b09: PROFINET: DHCP suboption undefined bytes

2020-08-20 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f404b094375343f0fab145df23663998bf4fc698
Submitter: "Anders Broman "
Changed: branch: master-3.2
Repository: wireshark

Commits:

f404b09 by Basak Kalfa (basakka...@gmail.com):

PROFINET: DHCP suboption undefined bytes

There are undefined bytes which must be included in DHCP
suboption block according to DCP Block Length. In other
words, there are still bytes after dissection of defined
parameters finish but DCP block length does not finish.
In order to solve the problem, these bytes are included in
DHCP suboption block and marked Undefined. The byte number
can be 1, so bytes word in pn_user_data is changed to byte.

Change-Id: I2be23b41a9827f9c2159b97a05658ddf557865cf
Reviewed-on: https://code.wireshark.org/review/38203
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Jaap Keuter 
(cherry picked from commit 4e595577f3dc2cd673ae6a06cec6ecc086ba8975)
Reviewed-on: https://code.wireshark.org/review/38205
Petri-Dish: Jaap Keuter 
Reviewed-by: Anders Broman 


Actions performed:

from  a2606dc   TDS: Fix If COLMETADATA is present, all row data display is 
unusable.
 add  f404b09   PROFINET: DHCP suboption undefined bytes


Summary of changes:
 plugins/epan/profinet/packet-pn-dcp.c | 7 +++
 plugins/epan/profinet/packet-pn.c | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-3.0 437d919: PROFINET: DHCP suboption undefined bytes

2020-08-20 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=437d9193666c78876670e6dee1271dd8b36098d6
Submitter: "Anders Broman "
Changed: branch: master-3.0
Repository: wireshark

Commits:

437d919 by Basak Kalfa (basakka...@gmail.com):

PROFINET: DHCP suboption undefined bytes

There are undefined bytes which must be included in DHCP
suboption block according to DCP Block Length. In other
words, there are still bytes after dissection of defined
parameters finish but DCP block length does not finish.
In order to solve the problem, these bytes are included in
DHCP suboption block and marked Undefined. The byte number
can be 1, so bytes word in pn_user_data is changed to byte.

Change-Id: I2be23b41a9827f9c2159b97a05658ddf557865cf
Reviewed-on: https://code.wireshark.org/review/38203
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Jaap Keuter 
(cherry picked from commit 4e595577f3dc2cd673ae6a06cec6ecc086ba8975)
Reviewed-on: https://code.wireshark.org/review/38206
Petri-Dish: Jaap Keuter 
Reviewed-by: Anders Broman 


Actions performed:

from  c520293   [Automatic update for 2020-08-16]
 add  437d919   PROFINET: DHCP suboption undefined bytes


Summary of changes:
 plugins/epan/profinet/packet-pn-dcp.c | 7 +++
 plugins/epan/profinet/packet-pn.c | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master df69e61: dicom: Handle frames with segments from different reassemblies

2020-08-20 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=df69e61cb6bc3910975d864175a1f64476fcd25c
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

df69e61 by John Thacker (johnthac...@gmail.com):

dicom: Handle frames with segments from different reassemblies

There can be multiple PDV segments in the same frame that belong to
different reassemblies. Change the reassembly_id used for the
reassembly tables so that it is not identical for all segments in
the same presentation context (but still unique for a given reassembly),
so that that case can be handled properly. Otherwise fragment_add_seq_next
will retrieve the wrong reassembly for one of the segments (especially
on the second pass.)

Bug: 13110
Change-Id: Ib967fc7f6b7b591b9e3494d81d3b5d4ecc43cac1
Reviewed-on: https://code.wireshark.org/review/38200
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  abd6f14   S1AP: upgrade dissector to v16.2.0
 add  df69e61   dicom: Handle frames with segments from different 
reassemblies


Summary of changes:
 epan/dissectors/packet-dcm.c | 16 +++-
 1 file changed, 15 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master abd6f14: S1AP: upgrade dissector to v16.2.0

2020-08-20 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=abd6f143c71cdf8d19918dc1ddb99bea6b92f062
Submitter: "Pascal Quantin "
Changed: branch: master
Repository: wireshark

Commits:

abd6f14 by Pascal Quantin (pas...@wireshark.org):

S1AP: upgrade dissector to v16.2.0

Change-Id: Ifa71f952f5aca11f99ae751d1c1404a2af95e3a5
Reviewed-on: https://code.wireshark.org/review/38204
Petri-Dish: Pascal Quantin 
Reviewed-by: Tomáš Kukosa 
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin 


Actions performed:

from  4e59557   PROFINET: DHCP suboption undefined bytes
 add  abd6f14   S1AP: upgrade dissector to v16.2.0


Summary of changes:
 epan/dissectors/asn1/lte-rrc/lte-rrc.cnf   |   14 +
 epan/dissectors/asn1/s1ap/S1AP-CommonDataTypes.asn |2 +-
 epan/dissectors/asn1/s1ap/S1AP-Constants.asn   |   37 +-
 epan/dissectors/asn1/s1ap/S1AP-Containers.asn  |2 +-
 epan/dissectors/asn1/s1ap/S1AP-IEs.asn |  297 +-
 epan/dissectors/asn1/s1ap/S1AP-PDU-Contents.asn|  265 +-
 .../dissectors/asn1/s1ap/S1AP-PDU-Descriptions.asn |   47 +-
 epan/dissectors/asn1/s1ap/S1AP-SonTransfer-IEs.asn |2 +-
 epan/dissectors/asn1/s1ap/packet-s1ap-template.c   |   38 +-
 epan/dissectors/asn1/s1ap/s1ap.cnf |  248 +-
 epan/dissectors/packet-lte-rrc.c   |  105 +
 epan/dissectors/packet-lte-rrc.h   |7 +
 epan/dissectors/packet-s1ap.c  | 2901 
 13 files changed, 3258 insertions(+), 707 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 4e59557: PROFINET: DHCP suboption undefined bytes

2020-08-20 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4e595577f3dc2cd673ae6a06cec6ecc086ba8975
Submitter: "Jaap Keuter "
Changed: branch: master
Repository: wireshark

Commits:

4e59557 by Basak Kalfa (basakka...@gmail.com):

PROFINET: DHCP suboption undefined bytes

There are undefined bytes which must be included in DHCP
suboption block according to DCP Block Length. In other
words, there are still bytes after dissection of defined
parameters finish but DCP block length does not finish.
In order to solve the problem, these bytes are included in
DHCP suboption block and marked Undefined. The byte number
can be 1, so bytes word in pn_user_data is changed to byte.

Change-Id: I2be23b41a9827f9c2159b97a05658ddf557865cf
Reviewed-on: https://code.wireshark.org/review/38203
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Jaap Keuter 


Actions performed:

from  c8e24f5   RTPS: DomainId incorrectly dissected when using TCP
 add  4e59557   PROFINET: DHCP suboption undefined bytes


Summary of changes:
 plugins/epan/profinet/packet-pn-dcp.c | 7 +++
 plugins/epan/profinet/packet-pn.c | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master c8e24f5: RTPS: DomainId incorrectly dissected when using TCP

2020-08-20 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c8e24f5c55cb37b9a311e5226923d291892de892
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

c8e24f5 by Ismael Mendez Matamoros (ism...@rti.com):

RTPS: DomainId incorrectly dissected when using TCP

Domain ID in non participant discovery packets is deduced from the port.
This is valid only when using UDP. If using TCP that values must be
taken from the discovery or otherwise mark it as unknown.

Change-Id: I8fe64f5f67d86412edefdccdca8ded63193f6e14
Reviewed-on: https://code.wireshark.org/review/38003
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  fd9923c   USB HID: fail to parse the rdesc if it has mismatched 
report ID usage
 add  c8e24f5   RTPS: DomainId incorrectly dissected when using TCP


Summary of changes:
 epan/dissectors/packet-rtps.c | 82 +--
 1 file changed, 72 insertions(+), 10 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master fd9923c: USB HID: fail to parse the rdesc if it has mismatched report ID usage

2020-08-20 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fd9923cb764eaca65caaef82672069823e757825
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

fd9923c by Filipe Laíns (la...@archlinux.org):

USB HID: fail to parse the rdesc if it has mismatched report ID usage

If one field uses a report ID, all other should too. Otherwise we don't
know if the first byte is a report ID or a data value.

Change-Id: I84f5cde3f08c26d904d7c5f66e8d622b820b3f6c
Signed-off-by: Filipe Laíns 
Reviewed-on: https://code.wireshark.org/review/37781
Petri-Dish: Tomasz Moń 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  bef04c2   USB HID: separate HID items into input and output
 add  fd9923c   USB HID: fail to parse the rdesc if it has mismatched 
report ID usage


Summary of changes:
 epan/dissectors/packet-usb-hid.c | 6 ++
 1 file changed, 6 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master bef04c2: USB HID: separate HID items into input and output

2020-08-20 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bef04c21b4664f4318705ec3ccb48919407f0484
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

bef04c2 by Filipe Laíns (la...@archlinux.org):

USB HID: separate HID items into input and output

Change-Id: I36c2eddb8ae227b28a26c86c87120e393d9a62b0
Signed-off-by: Filipe Laíns 
Reviewed-on: https://code.wireshark.org/review/37828
Reviewed-by: Anders Broman 


Actions performed:

from  4215a55   wmem_array: make wmem_array_grow public
 add  bef04c2   USB HID: separate HID items into input and output


Summary of changes:
 epan/dissectors/packet-usb-hid.c | 133 +--
 1 file changed, 87 insertions(+), 46 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 4215a55: wmem_array: make wmem_array_grow public

2020-08-20 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4215a55c7d601393a90e6f271158cee80ac797e6
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

4215a55 by Filipe Laíns (la...@archlinux.org):

wmem_array: make wmem_array_grow public

There cases where we may want to pre-allocate some memory before
appending all the fields.

Change-Id: Ic46e83733d4338dbda45b2ca3ff2d533c5b44026
Signed-off-by: Filipe Laíns 
Reviewed-on: https://code.wireshark.org/review/38122
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  d88cf27   EPL: additional dissection of flags
 add  4215a55   wmem_array: make wmem_array_grow public


Summary of changes:
 debian/libwireshark0.symbols | 1 +
 epan/wmem/wmem_array.c   | 2 +-
 epan/wmem/wmem_array.h   | 4 
 3 files changed, 6 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d88cf27: EPL: additional dissection of flags

2020-08-20 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d88cf2780c8c0ff2c25fa8f961d5a73c89af1ae3
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

d88cf27 by Christian Krump (christian.kr...@br-automation.com):

EPL: additional dissection of flags

Bug: 16776
Change-Id: I7b78dd3dd2d67f257cb67e79583a83e11068fc79
Reviewed-on: https://code.wireshark.org/review/38152
Reviewed-by: Christian Krump 
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  35418a7   Add format_text_string(), which gets the length with 
strlen().
 add  d88cf27   EPL: additional dissection of flags


Summary of changes:
 epan/dissectors/packet-epl.c | 66 +++-
 1 file changed, 65 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 35418a7: Add format_text_string(), which gets the length with strlen().

2020-08-20 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=35418a73f7c9cefebe392b1ea0f012fccaf89801
Submitter: "Guy Harris "
Changed: branch: master
Repository: wireshark

Commits:

35418a7 by Guy Harris (ghar...@sonic.net):

Add format_text_string(), which gets the length with strlen().

format_text(alloc, string, strlen(string)) is a common idiom; provide
format_text_string(), which does the strlen(string) for you.  (Any
string used in a %s to set the text of a protocol tree item, if it was
directly extracted from the packet, should be run through a format_text
routine, to ensure that it's valid UTF-8 and that control characters are
handled correctly.)

Update comments while we're at it.

Change-Id: Ia8549efa1c96510ffce97178ed4ff7be4b02eb6e
Reviewed-on: https://code.wireshark.org/review/38202
Petri-Dish: Guy Harris 
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris 


Actions performed:

from  06ff18f   EPL: adaptations of SDO dissector
 add  35418a7   Add format_text_string(), which gets the length with 
strlen().


Summary of changes:
 debian/libwireshark0.symbols |  1 +
 epan/strutil.c   | 33 
 epan/strutil.h   | 51 
 3 files changed, 77 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-3.2 a2606dc: TDS: Fix If COLMETADATA is present, all row data display is unusable.

2020-08-19 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a2606dc89ad7f218ff5a282bd2129700409fd2c6
Submitter: "Anders Broman "
Changed: branch: master-3.2
Repository: wireshark

Commits:

a2606dc by eckart haug (wiresh...@syntacs.com):

TDS: Fix If COLMETADATA is present, all row data display is unusable.

Bug: 16682
Change-Id: I56e784784c6e8affae19d8911d573134ec89924d
Reviewed-on: https://code.wireshark.org/review/37778
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 
(cherry picked from commit 45e9da9b6710db6442bbd9fd23aa93c229cc3e9e)
Reviewed-on: https://code.wireshark.org/review/38197
Reviewed-by: Jaap Keuter 
Petri-Dish: Jaap Keuter 


Actions performed:

from  99cf1a2   wiretap: Adjust the pcapng systemd Journal length check.
 add  a2606dc   TDS: Fix If COLMETADATA is present, all row data display is 
unusable.


Summary of changes:
 epan/dissectors/packet-tds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-3.2 99cf1a2: wiretap: Adjust the pcapng systemd Journal length check.

2020-08-19 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=99cf1a23bbd7677bb2a6962851e4dc68720a154b
Submitter: "Anders Broman "
Changed: branch: master-3.2
Repository: wireshark

Commits:

99cf1a2 by Gerald Combs (ger...@wireshark.org):

wiretap: Adjust the pcapng systemd Journal length check.

Reduce the minimum systemd journal block size from 212 to 35. The larger
minimum was based on the Journal Export Format file reader, but we don't
need to be as strict here.

Update some comments.

Bug: 16734
Change-Id: Iad7227f29ff22f908e2fd49be0f11c9ad03fa7b9
Reviewed-on: https://code.wireshark.org/review/38035
Reviewed-by: Gerald Combs 
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 
(cherry picked from commit e387a4752c42e1a4286929e1ca356e14c6ce0283)
Reviewed-on: https://code.wireshark.org/review/38198
Reviewed-by: Jaap Keuter 
Petri-Dish: Jaap Keuter 


Actions performed:

from  0af38c8   packet_xml: detect and handle UTF-16 BOM
 add  99cf1a2   wiretap: Adjust the pcapng systemd Journal length check.


Summary of changes:
 wiretap/pcapng.c  | 8 
 wiretap/systemd_journal.c | 5 +
 2 files changed, 9 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 06ff18f: EPL: adaptations of SDO dissector

2020-08-19 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=06ff18fbb45fbf37feb3a3fcf0e22eebfa979079
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

06ff18f by Christian Krump (christian.kr...@br-automation.com):

EPL: adaptations of SDO dissector

- use segment size during sdo (write by index) payload decoding process
- set mapping-sections of sdo objects one level lower

Bug: 16792
Change-Id: Iae3f2095142ad076f7cde6266493e7308c65a51f
Reviewed-on: https://code.wireshark.org/review/38199
Reviewed-by: Christian Krump 
Petri-Dish: Roland Knall 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  f5f0105   logcat: fix indentation.
 add  06ff18f   EPL: adaptations of SDO dissector


Summary of changes:
 epan/dissectors/packet-epl.c | 19 +++
 1 file changed, 15 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-3.2 0af38c8: packet_xml: detect and handle UTF-16 BOM

2020-08-19 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0af38c86d270d9d4b16397f5c716577a2a448f4d
Submitter: "Anders Broman "
Changed: branch: master-3.2
Repository: wireshark

Commits:

0af38c8 by David Perry (boolean...@protonmail.com):

packet_xml: detect and handle UTF-16 BOM

In the main dissector, check the first 2/3 bytes for recognized
Byte-Order Marks (BOM) and decode if detected.

In the heuristic check, when unicode heuristics are enabled, check the
first 2 bytes for a recognized BOM instead of assuming UCS-2LE. (Still
falls back on that if no BOM detected.)

Bug: 9069
Change-Id: I7c6510221ef9257a9c3030715906e07b88af6aa7
Reviewed-on: https://code.wireshark.org/review/38076
Reviewed-by: Michael Mann 
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 
(cherry picked from commit 2ce378f8ab92e6c8d87b9472033a641ea98d3e80)
Reviewed-on: https://code.wireshark.org/review/38190
Reviewed-by: Jaap Keuter 
Petri-Dish: Jaap Keuter 


Actions performed:

from  09c8971   editcap: fix time adjustment for ERF
 add  0af38c8   packet_xml: detect and handle UTF-16 BOM


Summary of changes:
 epan/dissectors/packet-xml.c | 55 
 1 file changed, 50 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-3.2 09c8971: editcap: fix time adjustment for ERF

2020-08-19 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=09c89716ed88359a64c42272efc8da2f31b933b1
Submitter: "Anders Broman "
Changed: branch: master-3.2
Repository: wireshark

Commits:

09c8971 by Minh Phan (phanducnhatm...@gmail.com):

editcap: fix time adjustment for ERF

The erf_dump function in erf.c keeps the header intact and
ignores the adjusted time.
This adds a section for checking if the timestamp is changed
and updating the header accordingly.

Bug: 16578
Change-Id: I14468a302e746c7a84cf5619b73b94850142d930
Reviewed-on: https://code.wireshark.org/review/37301
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 
(cherry picked from commit 88aec0ecd92a27625c213720afcef62f596538c6)
Reviewed-on: https://code.wireshark.org/review/38195
Reviewed-by: Jaap Keuter 
Petri-Dish: Jaap Keuter 


Actions performed:

from  8b869ac   C12.22: Fix Calling-authentication-value-c1221 CHOICE
 add  09c8971   editcap: fix time adjustment for ERF


Summary of changes:
 wiretap/erf.c | 20 
 1 file changed, 20 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master f5f0105: logcat: fix indentation.

2020-08-18 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f5f010568a886f526bc27e573d8ac525028bc165
Submitter: "Guy Harris "
Changed: branch: master
Repository: wireshark

Commits:

f5f0105 by Guy Harris (ghar...@sonic.net):

logcat: fix indentation.

Change-Id: Ia23acfdaf78af20760f18169c57ae770b399e0d2
Reviewed-on: https://code.wireshark.org/review/38193
Reviewed-by: Guy Harris 


Actions performed:

from  f915bc7   FSSO: Add support of multiple Range Port
 add  f5f0105   logcat: fix indentation.


Summary of changes:
 epan/dissectors/packet-logcat.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master f915bc7: FSSO: Add support of multiple Range Port

2020-08-18 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f915bc7523f0c238612b8e9ae800f6b36c6d3d35
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

f915bc7 by Alexis La Goutte (alexis.lagou...@gmail.com):

FSSO: Add support of multiple Range Port

it is possible to have multiple range port for TSAgent

Change-Id: I7b45f30a1d1cf974ffcf62d2f19dbc30b621ec4e
Reviewed-on: https://code.wireshark.org/review/38186
Reviewed-by: Jaap Keuter 
Petri-Dish: Jaap Keuter 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  95176cc   E212: Update MCC / MNC code interpretations
 add  f915bc7   FSSO: Add support of multiple Range Port


Summary of changes:
 epan/dissectors/packet-fortinet-sso.c | 28 ++--
 1 file changed, 22 insertions(+), 6 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-3.2 8b869ac: C12.22: Fix Calling-authentication-value-c1221 CHOICE

2020-08-18 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8b869ac40aa8df5f424e065dcaf572fecd060661
Submitter: "Jaap Keuter "
Changed: branch: master-3.2
Repository: wireshark

Commits:

8b869ac by Jaap Keuter (jaap.keu...@xs4all.nl):

C12.22: Fix Calling-authentication-value-c1221 CHOICE

This ASN.1 CHOICE has three items with the same tag. Without access
to the spec, assuming these are sequentially numbered change the tags
on the subsequent elements.
This is detected by conflict check.

Change-Id: I0d7e6ace53426ba2661b133f7e825c1a305338ef
Reviewed-on: https://code.wireshark.org/review/37697
Reviewed-by: Jaap Keuter 
Reviewed-by: Ed Beroset 
Petri-Dish: Jaap Keuter 
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte 
(cherry picked from commit 7db43f0b8900af8db821d78c6d3c93fd144edb56)
Reviewed-on: https://code.wireshark.org/review/38189


Actions performed:

from  464ac0a   E212: Update MCC / MNC code interpretations
 add  8b869ac   C12.22: Fix Calling-authentication-value-c1221 CHOICE


Summary of changes:
 epan/dissectors/asn1/c1222/c1222.asn | 16 
 epan/dissectors/packet-c1222.c   |  8 
 2 files changed, 12 insertions(+), 12 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-3.2 464ac0a: E212: Update MCC / MNC code interpretations

2020-08-18 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=464ac0a73a7f3e15ecaeb2ea2cb90b2abceb040a
Submitter: "Jaap Keuter "
Changed: branch: master-3.2
Repository: wireshark

Commits:

464ac0a by Jaap Keuter (jaap.keu...@xs4all.nl):

E212: Update MCC / MNC code interpretations

Update the data related to ITU-T E.212 with the latest released information
as found in the ITU-T Operational Bulletins, amended with some other online
resources where the ITU-T seem not be informed yet.

Also retain the UTF-8 encoding of the registered data.

Bug: 16755
Change-Id: I13ba306558c0768379fa0e82db84e30f57af8259
Reviewed-on: https://code.wireshark.org/review/38159
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin 
Reviewed-by: Jaap Keuter 
(cherry picked from commit 95176cc52e94f7855c080ca59ab7dd5dcf82e4c5)
Reviewed-on: https://code.wireshark.org/review/38188
Petri-Dish: Jaap Keuter 


Actions performed:

from  0aa488d   RTCP: Fix wrong value in rtcp_mcpt_field_id_vals (Queued 
User ID)
 add  464ac0a   E212: Update MCC / MNC code interpretations


Summary of changes:
 epan/dissectors/packet-e212.c | 1201 +++--
 1 file changed, 673 insertions(+), 528 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-3.2 0aa488d: RTCP: Fix wrong value in rtcp_mcpt_field_id_vals (Queued User ID)

2020-08-18 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0aa488d3bf7408a787b0e6fe6dbe5f137ba9b4c8
Submitter: "Martin Mathieson "
Changed: branch: master-3.2
Repository: wireshark

Commits:

0aa488d by Martin Mathieson (martin.mathie...@keysight.com):

RTCP: Fix wrong value in rtcp_mcpt_field_id_vals (Queued User ID)

Change-Id: Ia076582c30a1763a531f8fc3bc13ebd88d7aa728
Reviewed-on: https://code.wireshark.org/review/3
Petri-Dish: Martin Mathieson 
Reviewed-by: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Mathieson 
(cherry picked from commit acc6a61ddb2c4db2885def1b0fe43cc74cba206b)
Reviewed-on: https://code.wireshark.org/review/38187


Actions performed:

from  f406a9c   Q.708: Fix Unassigned values
 add  0aa488d   RTCP: Fix wrong value in rtcp_mcpt_field_id_vals (Queued 
User ID)


Summary of changes:
 epan/dissectors/packet-rtcp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 95176cc: E212: Update MCC / MNC code interpretations

2020-08-18 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=95176cc52e94f7855c080ca59ab7dd5dcf82e4c5
Submitter: "Jaap Keuter "
Changed: branch: master
Repository: wireshark

Commits:

95176cc by Jaap Keuter (jaap.keu...@xs4all.nl):

E212: Update MCC / MNC code interpretations

Update the data related to ITU-T E.212 with the latest released information
as found in the ITU-T Operational Bulletins, amended with some other online
resources where the ITU-T seem not be informed yet.

Also retain the UTF-8 encoding of the registered data.

Bug: 16755
Change-Id: I13ba306558c0768379fa0e82db84e30f57af8259
Reviewed-on: https://code.wireshark.org/review/38159
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin 
Reviewed-by: Jaap Keuter 


Actions performed:

from  952e46f   TDS7: Make sure to populate pre-login message tree for all 
tokens
 add  95176cc   E212: Update MCC / MNC code interpretations


Summary of changes:
 epan/dissectors/packet-e212.c | 1201 +++--
 1 file changed, 673 insertions(+), 528 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-3.2 f406a9c: Q.708: Fix Unassigned values

2020-08-18 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f406a9c30444832fd9a31cab495b0483b8ce6b60
Submitter: "Jaap Keuter "
Changed: branch: master-3.2
Repository: wireshark

Commits:

f406a9c by Jaap Keuter (jaap.keu...@xs4all.nl):

Q.708: Fix Unassigned values

With commit f8a394022b82c0531b4685a4b83063727e399dab the Unassigned
entries were put in with off-by-one values. This changes puts them
in their right place.

Change-Id: I77c6eb4c47f17b8fba2dd662d3589ff63855e55f
Reviewed-on: https://code.wireshark.org/review/38179
Petri-Dish: Martin Mathieson 
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Mathieson 
Reviewed-by: Anders Broman 
(cherry picked from commit 389b81daeb11423f1bcbb7c9201e2c3add7d3596)
Reviewed-on: https://code.wireshark.org/review/38185
Petri-Dish: Jaap Keuter 
Reviewed-by: Jaap Keuter 


Actions performed:

from  94c6506   TDS7: Make sure to populate pre-login message tree for all 
tokens
 add  f406a9c   Q.708: Fix Unassigned values


Summary of changes:
 epan/dissectors/packet-q708.c | 260 +-
 1 file changed, 130 insertions(+), 130 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-3.2 94c6506: TDS7: Make sure to populate pre-login message tree for all tokens

2020-08-18 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=94c65069061f9cb5e0005263a537ef29d1c63197
Submitter: "Anders Broman "
Changed: branch: master-3.2
Repository: wireshark

Commits:

94c6506 by Jaap Keuter (jaap.keu...@xs4all.nl):

TDS7: Make sure to populate pre-login message tree for all tokens

Change-Id: I07bc540efe94ad8f93bd460f4dd23310285fb4e0
Reviewed-on: https://code.wireshark.org/review/38181
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 
(cherry picked from commit 952e46fb567c23f07fff1bb5e379fcaad2e24f48)
Reviewed-on: https://code.wireshark.org/review/38183
Reviewed-by: Craig Jackson 
Petri-Dish: Jaap Keuter 


Actions performed:

from  498796f   Q.708: Update ITU-T ISPC registery
 add  94c6506   TDS7: Make sure to populate pre-login message tree for all 
tokens


Summary of changes:
 epan/dissectors/packet-tds.c | 101 ++-
 1 file changed, 51 insertions(+), 50 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-3.2 498796f: Q.708: Update ITU-T ISPC registery

2020-08-18 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=498796f8ac2c095eb51ed6237f94eae999ba0af7
Submitter: "Anders Broman "
Changed: branch: master-3.2
Repository: wireshark

Commits:

498796f by Jaap Keuter (jaap.keu...@xs4all.nl):

Q.708: Update ITU-T ISPC registery

Implement updates of the following lists:

List of Signalling Area/Network Codes (SANC), based on
Annex to the ITU Operational Bulletin No. 1125 - 1.VI.2017

List of International Signalling Point Codes (ISPC), based on
Annex to ITU Operational Bulletin No. 1199 - 1.VII.2020

Also retain the UTF-8 encoding of the registered data.

Change-Id: I8c0ff7107a9489d7ec6ed1cc272717f06e2e7599
Reviewed-on: https://code.wireshark.org/review/38073
Reviewed-by: Jaap Keuter 
Petri-Dish: Jaap Keuter 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 
(cherry picked from commit f8a394022b82c0531b4685a4b83063727e399dab)
Reviewed-on: https://code.wireshark.org/review/38184


Actions performed:

from  cf1613c   [Automatic update for 2020-08-16]
 add  498796f   Q.708: Update ITU-T ISPC registery


Summary of changes:
 epan/dissectors/packet-q708.c | 19103 ++--
 1 file changed, 10325 insertions(+), 8778 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 952e46f: TDS7: Make sure to populate pre-login message tree for all tokens

2020-08-17 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=952e46fb567c23f07fff1bb5e379fcaad2e24f48
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

952e46f by Jaap Keuter (jaap.keu...@xs4all.nl):

TDS7: Make sure to populate pre-login message tree for all tokens

Change-Id: I07bc540efe94ad8f93bd460f4dd23310285fb4e0
Reviewed-on: https://code.wireshark.org/review/38181
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  1b88c72   NR RRC: upgrade dissector to v16.1.0
 add  952e46f   TDS7: Make sure to populate pre-login message tree for all 
tokens


Summary of changes:
 epan/dissectors/packet-tds.c | 101 ++-
 1 file changed, 51 insertions(+), 50 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 1b88c72: NR RRC: upgrade dissector to v16.1.0

2020-08-17 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1b88c727764b50e6f99b302e085a6ba7aa1df403
Submitter: "Pascal Quantin "
Changed: branch: master
Repository: wireshark

Commits:

1b88c72 by Pascal Quantin (pas...@wireshark.org):

NR RRC: upgrade dissector to v16.1.0

Change-Id: I961820125dca0f6b72dc84658d3010ca94a563ac
Reviewed-on: https://code.wireshark.org/review/38180
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin 


Actions performed:

from  389b81d   Q.708: Fix Unassigned values
 add  1b88c72   NR RRC: upgrade dissector to v16.1.0


Summary of changes:
 epan/dissectors/asn1/lpp/lpp.cnf   |64 +-
 epan/dissectors/asn1/lte-rrc/lte-rrc.cnf   |89 +-
 .../asn1/lte-rrc/packet-lte-rrc-template.c |14 +-
 epan/dissectors/asn1/nr-rrc/CMakeLists.txt | 2 +
 .../asn1/nr-rrc/NR-InterNodeDefinitions.asn|   125 +-
 epan/dissectors/asn1/nr-rrc/NR-RRC-Definitions.asn |  6360 +-
 .../dissectors/asn1/nr-rrc/NR-Sidelink-Preconf.asn |69 +
 epan/dissectors/asn1/nr-rrc/NR-UE-Variables.asn|   178 +-
 .../dissectors/asn1/nr-rrc/PC5-RRC-Definitions.asn |   273 +
 epan/dissectors/asn1/nr-rrc/nr-rrc.cnf |   498 +-
 .../asn1/nr-rrc/packet-nr-rrc-template.c   |   163 +-
 epan/dissectors/packet-lpp.c   |   223 +-
 epan/dissectors/packet-lpp.h   | 7 +
 epan/dissectors/packet-lte-rrc.c   |   369 +-
 epan/dissectors/packet-lte-rrc.h   | 9 +
 epan/dissectors/packet-nr-rrc.c| 97606 ++-
 epan/dissectors/packet-nr-rrc.h| 7 +-
 17 files changed, 80127 insertions(+), 25929 deletions(-)
 create mode 100644 epan/dissectors/asn1/nr-rrc/NR-Sidelink-Preconf.asn
 create mode 100644 epan/dissectors/asn1/nr-rrc/PC5-RRC-Definitions.asn
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 389b81d: Q.708: Fix Unassigned values

2020-08-17 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=389b81daeb11423f1bcbb7c9201e2c3add7d3596
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

389b81d by Jaap Keuter (jaap.keu...@xs4all.nl):

Q.708: Fix Unassigned values

With commit f8a394022b82c0531b4685a4b83063727e399dab the Unassigned
entries were put in with off-by-one values. This changes puts them
in their right place.

Change-Id: I77c6eb4c47f17b8fba2dd662d3589ff63855e55f
Reviewed-on: https://code.wireshark.org/review/38179
Petri-Dish: Martin Mathieson 
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Mathieson 
Reviewed-by: Anders Broman 


Actions performed:

from  f8a3940   Q.708: Update ITU-T ISPC registery
 add  389b81d   Q.708: Fix Unassigned values


Summary of changes:
 epan/dissectors/packet-q708.c | 260 +-
 1 file changed, 130 insertions(+), 130 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master f8a3940: Q.708: Update ITU-T ISPC registery

2020-08-17 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f8a394022b82c0531b4685a4b83063727e399dab
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

f8a3940 by Jaap Keuter (jaap.keu...@xs4all.nl):

Q.708: Update ITU-T ISPC registery

Implement updates of the following lists:

List of Signalling Area/Network Codes (SANC), based on
Annex to the ITU Operational Bulletin No. 1125 - 1.VI.2017

List of International Signalling Point Codes (ISPC), based on
Annex to ITU Operational Bulletin No. 1199 - 1.VII.2020

Also retain the UTF-8 encoding of the registered data.

Change-Id: I8c0ff7107a9489d7ec6ed1cc272717f06e2e7599
Reviewed-on: https://code.wireshark.org/review/38073
Reviewed-by: Jaap Keuter 
Petri-Dish: Jaap Keuter 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  2fe820c   GBCS: Dissect user interface alerts.
 add  f8a3940   Q.708: Update ITU-T ISPC registery


Summary of changes:
 epan/dissectors/packet-q708.c | 19103 ++--
 1 file changed, 10325 insertions(+), 8778 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 2fe820c: GBCS: Dissect user interface alerts.

2020-08-17 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2fe820c57208038f1871407301e21da5b8364e7e
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

2fe820c by Martin Boye Petersen (martinboyepeter...@gmail.com):

GBCS: Dissect user interface alerts.

The hf field was already created, but it was just not used anywhere.

Change-Id: I7af885911093d6a7a57a408c6d4d11bda155e6f6
Reviewed-on: https://code.wireshark.org/review/38178
Reviewed-by: Kenneth Soerensen 
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  293af3c   Release notes: Add FTDI MPSSE protocol
 add  2fe820c   GBCS: Dissect user interface alerts.


Summary of changes:
 epan/dissectors/packet-gbcs.c | 5 +
 1 file changed, 5 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 293af3c: Release notes: Add FTDI MPSSE protocol

2020-08-17 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=293af3c32b2ee7b308fdacda896bea47b3a38c3d
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

293af3c by Tomasz Moń (deso...@gmail.com):

Release notes: Add FTDI MPSSE protocol

Change-Id: I2589f79f01d4cb82bb6a95d9c4b0f6e408256d59
Reviewed-on: https://code.wireshark.org/review/38169
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  5be3de0   FTDI MPSSE: Display kilohertz using SI symbol
 add  293af3c   Release notes: Add FTDI MPSSE protocol


Summary of changes:
 docbook/release-notes.adoc | 1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 5be3de0: FTDI MPSSE: Display kilohertz using SI symbol

2020-08-17 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5be3de0029c9caa8b02cc555c37579e646862a87
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

5be3de0 by Tomasz Moń (deso...@gmail.com):

FTDI MPSSE: Display kilohertz using SI symbol

SI symbol for kilohertz is kHz, not KHz.

Ping-Bug: 11743
Change-Id: Ie6cafd242b2e479783ecd8ab8a04c08effe23413
Reviewed-on: https://code.wireshark.org/review/38168
Reviewed-by: Anders Broman 


Actions performed:

from  b858626   FTDI MPSSE: Dissect Open-Drain enable parameters
 add  5be3de0   FTDI MPSSE: Display kilohertz using SI symbol


Summary of changes:
 epan/dissectors/packet-ftdi-mpsse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master b858626: FTDI MPSSE: Dissect Open-Drain enable parameters

2020-08-17 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b85862654b3b92344ca0e084c4f38b0fa7d8a84e
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

b858626 by Tomasz Moń (deso...@gmail.com):

FTDI MPSSE: Dissect Open-Drain enable parameters

Set I/O to only drive on a '0' and tristate on a '1' command essentially
sets each I/O output type to either Open-Drain or Push-Pull.

Ping-Bug: 11743
Change-Id: I580d63c80114ad8f4a7cb1fc82a3c40720cc71e6
Reviewed-on: https://code.wireshark.org/review/38167
Petri-Dish: Tomasz Moń 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  3b67c5b   TFS: Add some commonly-defined string pairs to tfs.c
 add  b858626   FTDI MPSSE: Dissect Open-Drain enable parameters


Summary of changes:
 epan/dissectors/packet-ftdi-mpsse.c | 181 +++-
 1 file changed, 180 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3b67c5b: TFS: Add some commonly-defined string pairs to tfs.c

2020-08-16 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3b67c5b3084cd74986115e06eab954b4f8332a3f
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

3b67c5b by Martin Mathieson (martin.mathie...@keysight.com):

TFS: Add some commonly-defined string pairs to tfs.c

'check_tfs.py --common'can look for tfs values that appear multiple 
times.
Current output prior to these dssector changes was:

('No Extension', 'Extension') appears 3 times in:  
['epan/dissectors/packet-bssap.c', 'epan/dissectors/packet-camel.c', 
'epan/dissectors/packet-gsm_map.c']
('Optimised for signalling traffic', 'Not optimised for signalling 
traffic') appears 3 times in:  ['epan/dissectors/packet-gsm_a_gm.c', 
'epan/dissectors/packet-gsm_map.c', 'epan/dissectors/packet-gtp.c']
('Data PDU', 'Control PDU') appears 3 times in:  
['epan/dissectors/packet-pdcp-lte.c', 'epan/dissectors/packet-pdcp-nr.c', 
'epan/dissectors/packet-rlc-nr.c']
('Message sent to originating side', 'Message sent from originating side') 
appears 3 times in:  ['epan/dissectors/packet-q2931.c', 
'epan/dissectors/packet-q931.c', 'epan/dissectors/packet-q933.c']
('User', 'Provider') appears 3 times in:  
['epan/dissectors/packet-q2931.c', 'epan/dissectors/packet-q931.c', 
'epan/dissectors/packet-q933.c']

The first and last ones were made common, the others seem a little too 
specialised.

Checking some of the existing items in tfs.c (using QtCreator's 'Find 
Usages'),
some of the common items are used a lot, but many of them are not 
referenced.

Change-Id: Ia4006d2c4fa7cafbc3b004dc7a367a986dbeb0c4
Reviewed-on: https://code.wireshark.org/review/38177
Petri-Dish: Martin Mathieson 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  e48ab21   BER: Fix order of loop tests to avoid overrunning array.
 add  3b67c5b   TFS: Add some commonly-defined string pairs to tfs.c


Summary of changes:
 debian/libwireshark0.symbols   |  2 +
 epan/dissectors/asn1/camel/packet-camel-template.c |  6 ---
 .../asn1/gsm_map/packet-gsm_map-template.c |  7 +---
 epan/dissectors/packet-bssap.c |  7 +---
 epan/dissectors/packet-camel.c | 20 --
 epan/dissectors/packet-gsm_map.c   | 13 +++
 epan/dissectors/packet-q2931.c |  1 -
 epan/dissectors/packet-q931.c  |  1 -
 epan/dissectors/packet-q933.c  |  1 -
 epan/tfs.c |  2 +
 epan/tfs.h |  2 +
 tools/check_tfs.py | 43 +++---
 12 files changed, 58 insertions(+), 47 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e48ab21: BER: Fix order of loop tests to avoid overrunning array.

2020-08-16 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e48ab21267c90bf5f870003299e00ea1656e2d7e
Submitter: "Martin Mathieson "
Changed: branch: master
Repository: wireshark

Commits:

e48ab21 by Martin Mathieson (martin.mathie...@keysight.com):

BER: Fix order of loop tests to avoid overrunning array.

Reported by cppcheck:

epan/dissectors/packet-ber.c:2603:35: warning: Array index 'set_idx' is 
used before limits check. [arrayIndexThenCheck]
for (set_idx = 0; (cset = [set_idx])->func && (set_idx < 
MAX_SET_ELEMENTS); set_idx++) {
  ^
epan/dissectors/packet-ber.c:2759:40: warning: Array index 'set_idx' is 
used before limits check. [arrayIndexThenCheck]
for (set_idx = 0;  (cset = [set_idx])->func && (set_idx < 
MAX_SET_ELEMENTS); set_idx++) {
   ^

Change-Id: Ifbb9f1d2e9062a5c55190ea68df2226f3af8f21a
Reviewed-on: https://code.wireshark.org/review/38166
Petri-Dish: Martin Mathieson 
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin 
Reviewed-by: Martin Mathieson 


Actions performed:

from  521180d   [Automatic update for 2020-08-16]
 add  e48ab21   BER: Fix order of loop tests to avoid overrunning array.


Summary of changes:
 epan/dissectors/packet-ber.c | 9 -
 1 file changed, 4 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.6 20c1740: [Automatic update for 2020-08-16]

2020-08-16 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=20c1740d29775c0fe3ad74aa18664b00ea46d158
Submitter: "Gerald Combs "
Changed: branch: master-2.6
Repository: wireshark

Commits:

20c1740 by Gerald Combs (ger...@wireshark.org):

[Automatic update for 2020-08-16]

Update manuf, services enterprise numbers, translations, and other items.

Change-Id: Iae7457c45aa10491f5da3e5c0e850fff136676ac
Reviewed-on: https://code.wireshark.org/review/38176
Reviewed-by: Gerald Combs 


Actions performed:

from  502b65c   GTPv2: fix S103PDF and S1UDF IE dissection
 add  20c1740   [Automatic update for 2020-08-16]


Summary of changes:
 NEWS  | 74 ++---
 docbook/wsug_src/capinfos-h.txt   |  2 +-
 docbook/wsug_src/dumpcap-h.txt|  2 +-
 docbook/wsug_src/editcap-h.txt|  2 +-
 docbook/wsug_src/mergecap-h.txt   |  2 +-
 docbook/wsug_src/rawshark-h.txt   |  2 +-
 docbook/wsug_src/reordercap-h.txt |  2 +-
 docbook/wsug_src/text2pcap-h.txt  |  2 +-
 docbook/wsug_src/tshark-h.txt |  2 +-
 enterprises.tsv   | 44 ++--
 manuf | 86 +++
 ui/qt/wireshark_it.ts |  8 ++--
 12 files changed, 151 insertions(+), 77 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-3.0 c520293: [Automatic update for 2020-08-16]

2020-08-16 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c5202932097e907de69c80751d509ef66406027e
Submitter: "Gerald Combs "
Changed: branch: master-3.0
Repository: wireshark

Commits:

c520293 by Gerald Combs (ger...@wireshark.org):

[Automatic update for 2020-08-16]

Update manuf, services enterprise numbers, translations, and other items.

Change-Id: I44dd0a6a332426025b911e2927a48494b1b485f6
Reviewed-on: https://code.wireshark.org/review/38175
Reviewed-by: Gerald Combs 


Actions performed:

from  c3c06e5   GTPv2: fix S103PDF and S1UDF IE dissection
 add  c520293   [Automatic update for 2020-08-16]


Summary of changes:
 NEWS  | 63 ++--
 docbook/wsug_src/capinfos-h.txt   |  2 +-
 docbook/wsug_src/dumpcap-h.txt|  2 +-
 docbook/wsug_src/editcap-h.txt|  2 +-
 docbook/wsug_src/mergecap-h.txt   |  2 +-
 docbook/wsug_src/rawshark-h.txt   |  2 +-
 docbook/wsug_src/reordercap-h.txt |  2 +-
 docbook/wsug_src/text2pcap-h.txt  |  2 +-
 docbook/wsug_src/tshark-h.txt |  2 +-
 enterprises.tsv   | 44 ++--
 manuf | 86 +++
 ui/qt/wireshark_it.ts |  6 +--
 12 files changed, 141 insertions(+), 74 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-3.2 cf1613c: [Automatic update for 2020-08-16]

2020-08-16 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cf1613ccb6b160db9d94392b0f05725149879986
Submitter: "Gerald Combs "
Changed: branch: master-3.2
Repository: wireshark

Commits:

cf1613c by Gerald Combs (ger...@wireshark.org):

[Automatic update for 2020-08-16]

Update manuf, services enterprise numbers, translations, and other items.

Change-Id: I82d420ded5bcc18c2ea0ee8eb86f7cf366eb6ea0
Reviewed-on: https://code.wireshark.org/review/38174
Reviewed-by: Gerald Combs 


Actions performed:

from  172b25f   dicom: fix exporting objects with tshark
 add  cf1613c   [Automatic update for 2020-08-16]


Summary of changes:
 NEWS  | 80 ++--
 docbook/wsug_src/capinfos-h.txt   |  2 +-
 docbook/wsug_src/dumpcap-h.txt|  2 +-
 docbook/wsug_src/editcap-h.txt|  2 +-
 docbook/wsug_src/mergecap-h.txt   |  2 +-
 docbook/wsug_src/rawshark-h.txt   |  2 +-
 docbook/wsug_src/reordercap-h.txt |  2 +-
 docbook/wsug_src/text2pcap-h.txt  |  2 +-
 docbook/wsug_src/tshark-h.txt |  2 +-
 enterprises.tsv   | 44 ++--
 manuf | 86 +++
 ui/qt/wireshark_it.ts |  6 +--
 12 files changed, 141 insertions(+), 91 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 521180d: [Automatic update for 2020-08-16]

2020-08-16 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=521180d8d7eed5a78841b938b8570bff6cca6d80
Submitter: "Gerald Combs "
Changed: branch: master
Repository: wireshark

Commits:

521180d by Gerald Combs (ger...@wireshark.org):

[Automatic update for 2020-08-16]

Update manuf, services enterprise numbers, translations, and other items.

Change-Id: I8e16e1176b00ca16dd051ec5f86a7bf7cf4f2405
Reviewed-on: https://code.wireshark.org/review/38173
Reviewed-by: Gerald Combs 


Actions performed:

from  4e8dae3   wifi-dpp: Add support for version 1.2.9 of the protocol.
 add  521180d   [Automatic update for 2020-08-16]


Summary of changes:
 AUTHORS  |  3 ++
 NEWS | 21 +++-
 enterprises.tsv  | 44 ++---
 manuf| 86 +++-
 ui/qt/wireshark_de.ts| 57 +++-
 ui/qt/wireshark_en.ts| 55 +++
 ui/qt/wireshark_es.ts| 57 +++-
 ui/qt/wireshark_fr.ts| 55 +++
 ui/qt/wireshark_it.ts| 63 ---
 ui/qt/wireshark_ja_JP.ts | 57 +++-
 ui/qt/wireshark_pl.ts| 57 +++-
 ui/qt/wireshark_ru.ts| 81 +
 ui/qt/wireshark_sv.ts| 57 +++-
 ui/qt/wireshark_uk.ts| 55 +++
 ui/qt/wireshark_zh_CN.ts | 57 +++-
 15 files changed, 760 insertions(+), 45 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 4e8dae3: wifi-dpp: Add support for version 1.2.9 of the protocol.

2020-08-15 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4e8dae37ebefd048d77147df3b62a3a1f4404bb4
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

4e8dae3 by Richard Sharpe (realrichardsha...@gmail.com):

wifi-dpp: Add support for version 1.2.9 of the protocol.

Also fix packet-ieee1905.c to include packet-wifi-dpp.h for the definition
it needs.

Change-Id: Iebb290ffb3112161605d6065123cfc54b921f2eb
Reviewed-on: https://code.wireshark.org/review/38163
Petri-Dish: Richard Sharpe 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  ce81473   check_tfs.py:  Import subprocess module (needed for 
querying git)
 add  4e8dae3   wifi-dpp: Add support for version 1.2.9 of the protocol.


Summary of changes:
 epan/dissectors/packet-ieee1905.c |   5 +-
 epan/dissectors/packet-wifi-dpp.c | 475 +-
 epan/dissectors/packet-wifi-dpp.h |  10 +
 3 files changed, 426 insertions(+), 64 deletions(-)
 create mode 100644 epan/dissectors/packet-wifi-dpp.h
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master ce81473: check_tfs.py: Import subprocess module (needed for querying git)

2020-08-15 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ce81473b7f05eb33adf7f5fc6acb9cc4162909c8
Submitter: "Martin Mathieson "
Changed: branch: master
Repository: wireshark

Commits:

ce81473 by Martin Mathieson (martin.mathie...@keysight.com):

check_tfs.py:  Import subprocess module (needed for querying git)

Change-Id: I177000fb05bb9323ddbb280eb0b79c30cd60a3f3
Reviewed-on: https://code.wireshark.org/review/38170
Reviewed-by: Martin Mathieson 


Actions performed:

from  ba4066f   dicom: fix exporting objects with tshark
 add  ce81473   check_tfs.py:  Import subprocess module (needed for 
querying git)


Summary of changes:
 tools/check_tfs.py | 1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-3.2 172b25f: dicom: fix exporting objects with tshark

2020-08-15 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=172b25fa448512479a836687a311060fa3b4c12e
Submitter: "Jaap Keuter "
Changed: branch: master-3.2
Repository: wireshark

Commits:

172b25f by John Thacker (johnthac...@gmail.com):

dicom: fix exporting objects with tshark

The names for files extracted from data PDVs depend on information in the 
tags.
Need to read the tags for data PDVs if the Export Objects tap has a listener
even if there isn't a tree (so that tshark works) and need to send data to
Export Objects only after reading the tags (so that it works on the first 
pass).
This makes the tshark single pass behavior match wireshark GUI behavior.

Bug: 16771
Change-Id: I6cfa792e7b86f205290ff92c9f5e09fd94a25f9f
Reviewed-on: https://code.wireshark.org/review/38164
Reviewed-by: Jaap Keuter 
Petri-Dish: Jaap Keuter 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 
Reviewed-on: https://code.wireshark.org/review/38165
Petri-Dish: Pascal Quantin 
Reviewed-by: John Thacker 


Actions performed:

from  1b74b64   Check that at least one token exists to consider the JSON 
as valid
 add  172b25f   dicom: fix exporting objects with tshark


Summary of changes:
 epan/dissectors/packet-dcm.c | 40 
 1 file changed, 20 insertions(+), 20 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master ba4066f: dicom: fix exporting objects with tshark

2020-08-15 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ba4066f470d6a55c13493c3b4b70a8df7ef1533d
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

ba4066f by John Thacker (johnthac...@gmail.com):

dicom: fix exporting objects with tshark

The names for files extracted from data PDVs depend on information in the 
tags.
Need to read the tags for data PDVs if the Export Objects tap has a listener
even if there isn't a tree (so that tshark works) and need to send data to
Export Objects only after reading the tags (so that it works on the first 
pass).
This makes the tshark single pass behavior match wireshark GUI behavior.

Bug: 16771
Change-Id: I6cfa792e7b86f205290ff92c9f5e09fd94a25f9f
Reviewed-on: https://code.wireshark.org/review/38164
Reviewed-by: Jaap Keuter 
Petri-Dish: Jaap Keuter 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  42cac8d   check_typed_item_calls.py:  add optional checks for labels 
and bitmask.
 add  ba4066f   dicom: fix exporting objects with tshark


Summary of changes:
 epan/dissectors/packet-dcm.c | 40 
 1 file changed, 20 insertions(+), 20 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 42cac8d: check_typed_item_calls.py: add optional checks for labels and bitmask.

2020-08-14 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=42cac8dcfd9d98791e0aecfc69fc609478e5f79b
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

42cac8d by Martin Mathieson (martin.mathie...@keysight.com):

check_typed_item_calls.py:  add optional checks for labels and bitmask.

Most of the detected non-contiguous mask bitmasks seem to be valid - they 
often
represent multiple unassigned/reserved bits that have been conflated into
one hf item.

A set of exceptions has been added to the script - a couple of genuine
buts will be addressed presently in a separate commit.

Change-Id: I87fcf6ee532819097c2daf20b4b1338abb4402d8
Reviewed-on: https://code.wireshark.org/review/38103
Reviewed-by: Martin Mathieson 
Petri-Dish: Martin Mathieson 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  d97aedb   Fix a couple of item bitmasks where bit positions were 
ommitted in error.
 add  42cac8d   check_typed_item_calls.py:  add optional checks for labels 
and bitmask.


Summary of changes:
 tools/check_typed_item_calls.py | 135 +---
 1 file changed, 125 insertions(+), 10 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d97aedb: Fix a couple of item bitmasks where bit positions were ommitted in error.

2020-08-14 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d97aedb64fc72a4d17b01105a57362f815f32e98
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

d97aedb by Martin Mathieson (martin.mathie...@keysight.com):

Fix a couple of item bitmasks where bit positions were ommitted in error.

Detected by check_typed_item_calls.py.

Change-Id: I08081c6619f3e1cd1b6733c8a2864bf9ac2a16aa
Reviewed-on: https://code.wireshark.org/review/38162
Petri-Dish: Martin Mathieson 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  e2c3320   bthci: Correct endianess and fields related to LE 
isochronous streams
 add  d97aedb   Fix a couple of item bitmasks where bit positions were 
ommitted in error.


Summary of changes:
 epan/dissectors/packet-icmpv6.c   | 2 +-
 epan/dissectors/packet-zbee-zcl-general.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e2c3320: bthci: Correct endianess and fields related to LE isochronous streams

2020-08-14 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e2c332032be7749e0a55ab33445b99ce0763efd6
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

e2c3320 by Allan Møller Madsen (almom...@gmail.com):

bthci: Correct endianess and fields related to LE isochronous streams

Correct endianess for Max PDU field in LE Set CIG Parameters and LE
Create BIG Test Command. Correct endianes for BIS handle and remove
PHY field from LE Create BIG Sync Established Event.
Add SDU interval field to LE BIGInfo Advertising Report Event.

Change-Id: Ic276aceb5a2e1cd6e1c08ae20303bfbe6bdc1286
Signed-off-by: Allan Møller Madsen 
Reviewed-on: https://code.wireshark.org/review/38157
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  62c4e25   Check that at least one token exists to consider the JSON 
as valid
 add  e2c3320   bthci: Correct endianess and fields related to LE 
isochronous streams


Summary of changes:
 epan/dissectors/packet-bthci_cmd.c |  6 +++---
 epan/dissectors/packet-bthci_evt.c | 14 ++
 2 files changed, 13 insertions(+), 7 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 62c4e25: Check that at least one token exists to consider the JSON as valid

2020-08-14 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=62c4e2525f23d200b39caa7ac14080d943024728
Submitter: "Pascal Quantin "
Changed: branch: master
Repository: wireshark

Commits:

62c4e25 by Pascal Quantin (pas...@wireshark.org):

Check that at least one token exists to consider the JSON as valid

Bug: 16780
Change-Id: I07ca12675fc79a7c524719d18b85e5d3dada6652
Reviewed-on: https://code.wireshark.org/review/38160
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin 


Actions performed:

from  ee42cb7   bluetooth.gaen: Adding Google/Apple Exposure Notification 
to bluetooth.
 add  62c4e25   Check that at least one token exists to consider the JSON 
as valid


Summary of changes:
 epan/dissectors/asn1/ngap/packet-ngap-template.c | 4 ++--
 epan/dissectors/packet-nas_5gs.c | 4 ++--
 epan/dissectors/packet-ngap.c| 4 ++--
 sharkd_session.c | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-3.2 1b74b64: Check that at least one token exists to consider the JSON as valid

2020-08-14 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1b74b64b8dd2a0884239e812b84c132010c70485
Submitter: "Pascal Quantin "
Changed: branch: master-3.2
Repository: wireshark

Commits:

1b74b64 by Pascal Quantin (pas...@wireshark.org):

Check that at least one token exists to consider the JSON as valid

Bug: 16780
Change-Id: I07ca12675fc79a7c524719d18b85e5d3dada6652
Reviewed-on: https://code.wireshark.org/review/38160
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin 
(cherry picked from commit 62c4e2525f23d200b39caa7ac14080d943024728)
Reviewed-on: https://code.wireshark.org/review/38161


Actions performed:

from  5bff521   GTPv2: fix S103PDF and S1UDF IE dissection
 add  1b74b64   Check that at least one token exists to consider the JSON 
as valid


Summary of changes:
 epan/dissectors/asn1/ngap/packet-ngap-template.c | 4 ++--
 epan/dissectors/packet-nas_5gs.c | 4 ++--
 epan/dissectors/packet-ngap.c| 4 ++--
 sharkd_session.c | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master ee42cb7: bluetooth.gaen: Adding Google/Apple Exposure Notification to bluetooth.

2020-08-14 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ee42cb79243f69f35a24639ba3f092a6d44a83ec
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

ee42cb7 by Brendan O'Connor (bren...@leviathansecurity.com):

bluetooth.gaen: Adding Google/Apple Exposure Notification to bluetooth.

The Google/Apple Exposure Notification protocol is designed to aid
contact tracing efforts by allowing users to broadcast changing
identifiers, derived from longer-term (24 hour) keys; in the event that
a user receives a positive diagnosis, they upload their longer-term keys
to a key server, and all other users can use those long-term keys to
generate all the potential changing identifiers, and compare those to
their logs to determine if they were in contact with the infected user.
This protocol was developed in response to SARS-CoV-2, but is not
inherently limited to it.

This patch adds a "bluetooth.gaen" filter, with two data fields in the
periodic (changing identifier) broadcast:
 - bluetooth.gaen.rpi: The Rolling Proximity Identifier
 - bluetooth.gaen.aemd: The Associated Encrypted Metadata

Links to Protocol Documents:
 - Google: https://www.google.com/covid19/exposurenotifications/
 - Apple: https://www.apple.com/covid19/contacttracing

This change also adds the Bluetooth SIG-assigned 16-bit UUID for GAEN,
0xFD6F, to the list of Wireshark-recognizable 16-bit UUIDs.

These changes are licensed under the same license as Wireshark itself.

Change-Id: I3af14b225a35d0670433a9a89901d4d37895b3bd
Reviewed-on: https://code.wireshark.org/review/38064
Reviewed-by: Anders Broman 


Actions performed:

from  b921c28   EPL: append info-column with additional flag infos
 add  ee42cb7   bluetooth.gaen: Adding Google/Apple Exposure Notification 
to bluetooth.


Summary of changes:
 epan/dissectors/packet-bluetooth.c | 77 ++
 epan/dissectors/packet-bthci_cmd.c | 16 +++-
 2 files changed, 92 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master b921c28: EPL: append info-column with additional flag infos

2020-08-13 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b921c28603a4163cc4564dcc165695895de30f39
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

b921c28 by Christian Krump (christian.kr...@br-automation.com):

EPL: append info-column with additional flag infos

Bug: 16775
Change-Id: I31dfda69c2a7fe02ec4c37b298b76bda482d188d
Reviewed-on: https://code.wireshark.org/review/38151
Petri-Dish: Roland Knall 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  563a270   BMP: Add Route Policy 
(draft-xu-grow-bmp-route-policy-attr-trace-04)
 add  b921c28   EPL: append info-column with additional flag infos


Summary of changes:
 epan/dissectors/packet-epl.c | 60 +++-
 1 file changed, 43 insertions(+), 17 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 563a270: BMP: Add Route Policy (draft-xu-grow-bmp-route-policy-attr-trace-04)

2020-08-13 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=563a270019e7d5de2603953d8da7d2a64afb4eaa
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

563a270 by Alexis La Goutte (alexis.lagou...@gmail.com):

BMP: Add Route Policy (draft-xu-grow-bmp-route-policy-attr-trace-04)

new BMP Message type (Section 2.1).
  o  Type = TBD: Route Policy and Attribute Trace Message. (100)

new TLV types for the Route  Policy and Attribute Trace Message (Section 
2.3).
   o  Type = TBD1 (2 Byte): VRF/Table TLV. (0)
   o  Type = TBD2 (2 Byte): Policy TLV. (1)
   o  Type = TBD3 (2 Byte): Pre Policy Attribute TLV. (2)
   o  Type = TBD4 (2 Byte): Post Policy Attribute TLV. (3)
   o  Type = TBD5 (2 Byte): String TLV. (4)

Bug: 16749
Change-Id: I9858c94fb8fe5a9f3341204646030e59e13509bf
Reviewed-on: https://code.wireshark.org/review/37911
Reviewed-by: Alexis La Goutte 
Tested-by: Petri Dish Buildbot
Reviewed-by: Uli Heilmeier 
Petri-Dish: Alexis La Goutte 
Reviewed-by: Anders Broman 


Actions performed:

from  4569772   eap: fix which tokens we think contain mncNNN and mccNNN.
 add  563a270   BMP: Add Route Policy 
(draft-xu-grow-bmp-route-policy-attr-trace-04)


Summary of changes:
 epan/dissectors/packet-bgp.c |   2 +-
 epan/dissectors/packet-bgp.h |   3 +
 epan/dissectors/packet-bmp.c | 509 ++-
 3 files changed, 511 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 4569772: eap: fix which tokens we think contain mncNNN and mccNNN.

2020-08-13 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4569772457b92c4b25c8c2e7bd4bac5256038e41
Submitter: "Guy Harris "
Changed: branch: master
Repository: wireshark

Commits:

4569772 by Guy Harris (ghar...@sonic.net):

eap: fix which tokens we think contain mncNNN and mccNNN.

tokens[] contains two tokens - the part of the identity before @ and the
part of the identity after @.

realm_tokens[] contain five tokens - the "."-separated parts of the part
of the identity after @.

The latter include "mncNNN" and "mncNNN".

This fixes a crash.

Change-Id: I4b13dd90977a626a823cb53958412301abf8addb
Reviewed-on: https://code.wireshark.org/review/38158
Petri-Dish: Guy Harris 
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris 


Actions performed:

from  c3066b6   make-version.pl: Update sample output in comments to more 
modern git version 2.24.3 (Apple Git-128)
 add  4569772   eap: fix which tokens we think contain mncNNN and mccNNN.


Summary of changes:
 epan/dissectors/packet-eap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master c3066b6: make-version.pl: Update sample output in comments to more modern git version 2.24.3 (Apple Git-128)

2020-08-13 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c3066b647e4482516c8498db23f0d30ef9f867ff
Submitter: "Jörg Mayer "
Changed: branch: master
Repository: wireshark

Commits:

c3066b6 by Joerg Mayer (jma...@loplof.de):

make-version.pl: Update sample output in comments to more modern git 
version 2.24.3 (Apple Git-128)

Change-Id: I2c204d315fd2648953b536a825f6c7d9c9b04827
Reviewed-on: https://code.wireshark.org/review/38138
Reviewed-by: Jörg Mayer 


Actions performed:

from  30beb5a   STUN: att_pw_alg and alg_param_len items are unsigned ints.
 add  c3066b6   make-version.pl: Update sample output in comments to more 
modern git version 2.24.3 (Apple Git-128)


Summary of changes:
 tools/make-version.pl | 18 ++
 1 file changed, 10 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 30beb5a: STUN: att_pw_alg and alg_param_len items are unsigned ints.

2020-08-13 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=30beb5ae22aea1998260c795608361ee4a49b288
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

30beb5a by Martin Mathieson (martin.mathie...@keysight.com):

STUN: att_pw_alg and alg_param_len items are unsigned ints.

Change-Id: I3652fb9b2a98617a2657d01c753efdd30851a512
Reviewed-on: https://code.wireshark.org/review/38150
Petri-Dish: Martin Mathieson 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  f59262b   GTPv2: fix S103PDF and S1UDF IE dissection
 add  30beb5a   STUN: att_pw_alg and alg_param_len items are unsigned ints.


Summary of changes:
 epan/dissectors/packet-stun.c | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.6 502b65c: GTPv2: fix S103PDF and S1UDF IE dissection

2020-08-13 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=502b65cb0959c987e1470685075ec40333ec52ea
Submitter: "Anders Broman "
Changed: branch: master-2.6
Repository: wireshark

Commits:

502b65c by Pascal Quantin (pas...@wireshark.org):

GTPv2: fix S103PDF and S1UDF IE dissection

The IPv4 or IPv6 address was not added properly to the tree

Bug: 16777
Change-Id: Ic28138cc1d4c2dc350fb5ff95aa3a5496a293c91
Reviewed-on: https://code.wireshark.org/review/38153
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin 
(cherry picked from commit f59262b94c10cb3e2c5655274698899dc41d43cf)
Reviewed-on: https://code.wireshark.org/review/38156


Actions performed:

from  8cda1eb   2.6.19 → 2.6.20.
 add  502b65c   GTPv2: fix S103PDF and S1UDF IE dissection


Summary of changes:
 epan/dissectors/packet-gtpv2.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-3.0 c3c06e5: GTPv2: fix S103PDF and S1UDF IE dissection

2020-08-13 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c3c06ee1c148724d466fa58a239a49f59ed2
Submitter: "Pascal Quantin "
Changed: branch: master-3.0
Repository: wireshark

Commits:

c3c06e5 by Pascal Quantin (pas...@wireshark.org):

GTPv2: fix S103PDF and S1UDF IE dissection

The IPv4 or IPv6 address was not added properly to the tree

Bug: 16777
Change-Id: Ic28138cc1d4c2dc350fb5ff95aa3a5496a293c91
Reviewed-on: https://code.wireshark.org/review/38153
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin 
(cherry picked from commit f59262b94c10cb3e2c5655274698899dc41d43cf)
Reviewed-on: https://code.wireshark.org/review/38155


Actions performed:

from  49c7731   3.0.13 → 3.0.14.
 add  c3c06e5   GTPv2: fix S103PDF and S1UDF IE dissection


Summary of changes:
 epan/dissectors/packet-gtpv2.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-3.2 5bff521: GTPv2: fix S103PDF and S1UDF IE dissection

2020-08-13 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5bff52109e42bc29fc4ceac7b59f10460037ea7b
Submitter: "Pascal Quantin "
Changed: branch: master-3.2
Repository: wireshark

Commits:

5bff521 by Pascal Quantin (pas...@wireshark.org):

GTPv2: fix S103PDF and S1UDF IE dissection

The IPv4 or IPv6 address was not added properly to the tree

Bug: 16777
Change-Id: Ic28138cc1d4c2dc350fb5ff95aa3a5496a293c91
Reviewed-on: https://code.wireshark.org/review/38153
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin 
(cherry picked from commit f59262b94c10cb3e2c5655274698899dc41d43cf)
Reviewed-on: https://code.wireshark.org/review/38154


Actions performed:

from  99a41f7   3.2.6 → 3.2.7.
 add  5bff521   GTPv2: fix S103PDF and S1UDF IE dissection


Summary of changes:
 epan/dissectors/packet-gtpv2.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master f59262b: GTPv2: fix S103PDF and S1UDF IE dissection

2020-08-13 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f59262b94c10cb3e2c5655274698899dc41d43cf
Submitter: "Pascal Quantin "
Changed: branch: master
Repository: wireshark

Commits:

f59262b by Pascal Quantin (pas...@wireshark.org):

GTPv2: fix S103PDF and S1UDF IE dissection

The IPv4 or IPv6 address was not added properly to the tree

Bug: 16777
Change-Id: Ic28138cc1d4c2dc350fb5ff95aa3a5496a293c91
Reviewed-on: https://code.wireshark.org/review/38153
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin 


Actions performed:

from  6ee65f8   Radius: include newly added dictionary files
 add  f59262b   GTPv2: fix S103PDF and S1UDF IE dissection


Summary of changes:
 epan/dissectors/packet-gtpv2.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 6ee65f8: Radius: include newly added dictionary files

2020-08-12 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6ee65f8af9a2f4d5ea7477ab3daaa9d1cc301a8e
Submitter: "Anders Broman "
Changed: branch: master
Repository: wireshark

Commits:

6ee65f8 by Pascal Quantin (pas...@wireshark.org):

Radius: include newly added dictionary files

Follow-up of g9fc4ac6cae

Change-Id: I7c7fb388d4aac0f126a20d20230f837985a2846f
Reviewed-on: https://code.wireshark.org/review/38143
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  395ac51   Fix some cases where item mask was wider than item type.
 add  6ee65f8   Radius: include newly added dictionary files


Summary of changes:
 packaging/nsis/wireshark.nsi | 2 ++
 radius/dictionary| 2 ++
 2 files changed, 4 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] [wireshark] annotated tag v2.6.20rc0 created (now 018efed)

2020-08-12 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=018efed4e67bea1a028355a16cf6d4b142c34e8c
Submitter: "Gerald Combs "
Changed: annotated tag: v2.6.20rc0
Repository: wireshark

Commits:

[ log message not found ]


Actions performed:

  at  018efed   (tag)
 tagging  8cda1eb09a58aed4edffb49096856eb21b35aba4 (commit)
 replaces wireshark-2.6.19
  by Gerald Combs
  on Wed Aug 12 13:08:21 2020 -0700

- Log -
2.6.19 → 2.6.20.
-BEGIN PGP SIGNATURE-

iQIzBAABCgAdFiEEWlrbp9vqbD+HIk8ZgiRKeOb+ruoFAl80TD4ACgkQgiRKeOb+
ruoz4hAAwcnIyIm6Nh6wGvc9ReTckCVkjYqlO4pX43WSZU3Tq3q77jIPIO5yipdq
eMgw6opX1VFrvEBV/+bIw7O52aa/BZtw2PgdGpEU5X1vX9STwfBH4tWqX/08n9F2
TelV3nt0t3wO/qs1gS7sHTFwfmDYiK8Pf8y4r0BkKrOx0tJCjBQcUMzBBgNGDDH1
FT1ZDKIeFLVbyX7fUAcysAqqK3PNijy/moUQ3pVUScpMidKXc5BBdhoaSDaw86v6
z9pv9l1iehKThdpf4TPY6sxtKW8oPo2ZSjgjRh/WmqZ/DsxDj+j2DnOxZiqC2Esm
D6+FfsRQ8ljm1lzzedF+u2vZTzFV/cB/tLwTPpsuROFZHimuX+3xkDIGLdGw6+Am
ynlJn28cgCqSrdxuWkX+iBHOYy2F7ozFHXDuTmo3051FBc8hjAJEhDfNilke0MjS
KadY+lAh+8g6tkzDH1L6LRC36n3mhTJnPvwNRXl2oO8wN3KKTPYA7bkKTEPH+Lcb
HZOpC6SUC+5Su/16yfMViMnELsyDgA2rDbHn4ZUPTAf05k9Mmpv2r6lWhkrKL5eO
G6sVFzJyjHgSTyJy3pNPsx0ZLNH+uhqcwRDpGAlfCaWDsCGbVXoqIncssUfowD2b
v/rYHmBdexM2KR3xsFZrd73K2CVCCH432QfNX5aLEXdB8wdtfII=
=yZYx
-END PGP SIGNATURE-
---

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.6 8cda1eb: 2.6.19 → 2.6.20.

2020-08-12 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8cda1eb09a58aed4edffb49096856eb21b35aba4
Submitter: "Gerald Combs "
Changed: branch: master-2.6
Repository: wireshark

Commits:

8cda1eb by Gerald Combs (ger...@wireshark.org):

2.6.19 → 2.6.20.

Change-Id: I63626b7f2acb80097c69724c08e067be55189144
Reviewed-on: https://code.wireshark.org/review/38149
Reviewed-by: Gerald Combs 


Actions performed:

from  bc3a093   Build 2.6.19.
 add  8cda1eb   2.6.19 → 2.6.20.


Summary of changes:
 CMakeLists.txt |   2 +-
 ChangeLog  | 572 -
 configure.ac   |   2 +-
 debian/changelog   |   2 +-
 docbook/attributes.asciidoc|   2 +-
 docbook/release-notes.asciidoc |  34 +--
 epan/CMakeLists.txt|   2 +-
 epan/Makefile.am   |   2 +-
 make-version.pl|   2 +-
 version.conf   |  12 +-
 wiretap/CMakeLists.txt |   2 +-
 wiretap/Makefile.am|   2 +-
 12 files changed, 16 insertions(+), 620 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] [wireshark] annotated tag v3.2.7rc0 created (now 32f80cc)

2020-08-12 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=32f80cc40e8995375e5299248e34e536385af4ab
Submitter: "Gerald Combs "
Changed: annotated tag: v3.2.7rc0
Repository: wireshark

Commits:

[ log message not found ]


Actions performed:

  at  32f80cc   (tag)
 tagging  99a41f78439f819724d4f43009a2ff1bbffc3352 (commit)
 replaces wireshark-3.2.6
  by Gerald Combs
  on Wed Aug 12 13:05:58 2020 -0700

- Log -
3.2.6 → 3.2.7.
-BEGIN PGP SIGNATURE-

iQIzBAABCgAdFiEEWlrbp9vqbD+HIk8ZgiRKeOb+ruoFAl80S64ACgkQgiRKeOb+
ruozdxAAvyAqOCT3+ARs6kJMvRKDzF/lCRDXzeLae2gCKm/qcEFIduO+FRCblL2F
TJnRlXS4eMxsSMZ0kKkhiOLpyXr4dpcJUMKS6IfODidCp9vcb1OiGTiv60BcEhKV
oTbGzgoek3T+AAcFYRUoA7rIUw+Druw/Pkgc1ECnUwEUKqLkHUuuNII14ESitbyq
Zdj1IT4UPDh4w+2+RxX4/KV7+VF5vYMOK+E5nfdQUcMqBp5YLPbMrlw59qR4kjTU
rirWChGXL7VGT7HYeBg/zRnStq2FMojmhsj2qRhpPZZppisCt5ZqjeCkIvij3WQr
2Yzv6W0zVidtnMGlPnGCALYkDXzonrscfvPoqSgCVc6Qe4cEHEx0RYHgf9FkEE+j
sazF4PhQoKSLcroerBZ5rYnWzaLR/eoY/KyMnQ0NkV1bGd9fGsd31fVKEW/aBT3w
+yMimEEWkvt5rvo26joUTwR7jtqXD9UeP3Ey8evtqYNqPOeBdxEXFN/ZT6VscFPc
KWWneqDnWKYEeVpJHeu+1DmX83F1UqEWs82YRDd3VjnqGna9KdxZ04WyaDmLcqFv
wlSqG2MbKNn2kPYFjlfAf1V1OV9KxkP1RUJO18ZXFSalzXis7GkB3ao3sQGd2A5h
yxwHOXKNOBsiX8mnI9oQlsAVzjSOLlzR89eCT0BkGwFWY4FYS4o=
=+TVS
-END PGP SIGNATURE-
---

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] [wireshark] annotated tag v3.0.14rc0 created (now ff83ae3)

2020-08-12 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ff83ae3b8e7f4e341512c5c6fe59c8c56c2cb9af
Submitter: "Gerald Combs "
Changed: annotated tag: v3.0.14rc0
Repository: wireshark

Commits:

[ log message not found ]


Actions performed:

  at  ff83ae3   (tag)
 tagging  49c7731cbd92815011c7133efe52859401885b52 (commit)
 replaces wireshark-3.0.13
  by Gerald Combs
  on Wed Aug 12 13:06:48 2020 -0700

- Log -
3.0.13 → 3.0.14.
-BEGIN PGP SIGNATURE-

iQIzBAABCgAdFiEEWlrbp9vqbD+HIk8ZgiRKeOb+ruoFAl80S+IACgkQgiRKeOb+
ruq5xg//bys72+ZhC7a4dkAJcovmgdm/NTpU0Zw2wxpbFcApsTxfIIC4gtSKuM5O
YquwoivtkvXJRAXIre4RfSktfqy/VtxSImfvBbbQW82lDp7lU9XwrvwTKdIR4lS/
fodwE0B79eNNSHIgaiKqHFwLW2QRtcMOVezBTEMsR6YMAfC0+yp21Y0YQLdQqQ7O
h9oid5l0/5fbqCtDH1opZPEV/MMhV6LEZLxiEhGUEktFBZH909vI79WKIOymT3Oy
/Cwso8dM1e8Lavbv4irtu0W/8xM0vYQA+TfGycJgUK2tFp5FojgnunclyXfh9gKx
vdDuI4WBChnKw1k59mVrY99sy+AipQN41dhbad1i5p7fYRw+DtZ9i+JRL8DM9EER
mY21v8F/WqyHDHa8WchgG0qf22EX7ZbwqlL6f8zkY7tfX9Z6SnjWTyymW9d09wo8
aguxgONjizw0AYoYek48l4VA+NYJXFbhMal+rz8RT11N+GudQnPp9qrUAm7tZoy6
jN3/fJeUmJDQmRO4c+3/jpKMK0aQ0VIVFcww+4n/I+at71bFv3/tZsuVP+2Y8Ymt
XSqOrsaD7GEMm1uckZgnBpRBLVn5s4t+JEXMxhYNkY+Y22DB53bkwioKpmRgEs5Y
NWbZhBNyX3mE1OsXCYKTDuB5Hwpa/EHW7SUVQDvcu/LtNcgaNKo=
=dt3l
-END PGP SIGNATURE-
---

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-3.0 49c7731: 3.0.13 → 3.0.14.

2020-08-12 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=49c7731cbd92815011c7133efe52859401885b52
Submitter: "Gerald Combs "
Changed: branch: master-3.0
Repository: wireshark

Commits:

49c7731 by Gerald Combs (ger...@wireshark.org):

3.0.13 → 3.0.14.

Change-Id: I9f2714e050ca5a93b747b39893ce8a13e084e979
Reviewed-on: https://code.wireshark.org/review/38148
Reviewed-by: Gerald Combs 


Actions performed:

from  643e3b0   Build 3.0.13.
 add  49c7731   3.0.13 → 3.0.14.


Summary of changes:
 CMakeLists.txt |   2 +-
 ChangeLog  | 663 -
 debian/changelog   |   2 +-
 docbook/attributes.asciidoc|   2 +-
 docbook/release-notes.asciidoc |  49 +--
 epan/CMakeLists.txt|   2 +-
 wiretap/CMakeLists.txt |   2 +-
 7 files changed, 11 insertions(+), 711 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-3.2 99a41f7: 3.2.6 → 3.2.7.

2020-08-12 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=99a41f78439f819724d4f43009a2ff1bbffc3352
Submitter: "Gerald Combs "
Changed: branch: master-3.2
Repository: wireshark

Commits:

99a41f7 by Gerald Combs (ger...@wireshark.org):

3.2.6 → 3.2.7.

Change-Id: Ic4b23494b26cf129531bfd6dc77271700c488377
Reviewed-on: https://code.wireshark.org/review/38147
Reviewed-by: Gerald Combs 


Actions performed:

from  4f9257f   Build 3.2.6.
 add  99a41f7   3.2.6 → 3.2.7.


Summary of changes:
 CMakeLists.txt |   2 +-
 ChangeLog  | 924 -
 debian/changelog   |   2 +-
 docbook/attributes.adoc|   2 +-
 docbook/release-notes.adoc |  77 +---
 epan/CMakeLists.txt|   2 +-
 wiretap/CMakeLists.txt |   2 +-
 7 files changed, 18 insertions(+), 993 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] [wireshark] annotated tag wireshark-2.6.19 created (now f39a63b)

2020-08-12 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f39a63bd24772c5b5db1f9c7a7ca43a69ee72c0e
Submitter: "Gerald Combs "
Changed: annotated tag: wireshark-2.6.19
Repository: wireshark

Commits:

[ log message not found ]


Actions performed:

  at  f39a63b   (tag)
 tagging  bc3a09326a25cbd77c183ea74e2d462615ab2868 (commit)
 replaces v2.6.19rc0
  by Gerald Combs
  on Wed Aug 12 10:57:58 2020 -0700

- Log -
Build 2.6.19.
-BEGIN PGP SIGNATURE-

iQIzBAABCgAdFiEEWlrbp9vqbD+HIk8ZgiRKeOb+ruoFAl80La4ACgkQgiRKeOb+
ruot/g/+MICmttCQaKT+wueVVvpgwT5qs2l+U0lRB5px8pixDcOh3BNMgKPRiLFA
52NRkk3HpuLG9EmWR+fyEz9pK03EWciWbyUhuStkCuDpeKh/CzLbPFHuLeBvcr/v
O7nLFlRE0A+CKATC6RBRxmFd3LLva2rqr+KjvSWmjvbpoPi/ILJGcXUK0BLocRgQ
hkFE65SxuM2wVGmsdCPWkxEHtmHkkHjYLI75C36/BL0qIXejyZAVoPpPWsxOhsOW
SMB+Q3X0glTTy4KSQXDtfb27PTIMV9XSiILLgRXDPp9M6sBqeMUOaYp3QN9s+any
/YVWN8QSc6rEUDepQo1I3EsRrKvq1661hsKQSTMVDsq/W6xub2Ri5i/rIqtjNGQK
C5W4tclxqJn1Rs8EpszkPQDorpKmlXg36mj6g8FLpUMH5g/6crQwKPSAG7A0FaWq
Dp7cVnvrddEQkLLmTOwOBPS8j+x9qJagbWTDIjobqEgltTCGKQ4ke29W4My9RZNk
v+SiI2xs0msWwEFbXzkt1j+PQrX3ZGSlHOl7lQN04aUktLHWvwnkKdwc3fHY3/av
lQ+s3zsOuZEfNTRh3LZ3ZPmKL7kfy7FXfYKkbK3uyFYvj7U6rfILzaOX4AIy8Zj6
+zEEwjo3Z79zKv8vqTwwOjvRXSEu/WVGGpKy1qYwep8uYDpzu/I=
=Saum
-END PGP SIGNATURE-
---

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] [wireshark] annotated tag v2.6.19 created (now a948ced)

2020-08-12 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a948cedec3d4d61ecc3a8d36bdaa9f02e4649923
Submitter: "Gerald Combs "
Changed: annotated tag: v2.6.19
Repository: wireshark

Commits:

[ log message not found ]


Actions performed:

  at  a948ced   (tag)
 tagging  bc3a09326a25cbd77c183ea74e2d462615ab2868 (commit)
 replaces v2.6.19rc0
  by Gerald Combs
  on Wed Aug 12 10:57:45 2020 -0700

- Log -
Build 2.6.19.
-BEGIN PGP SIGNATURE-

iQIzBAABCgAdFiEEWlrbp9vqbD+HIk8ZgiRKeOb+ruoFAl80LaAACgkQgiRKeOb+
rupSqw/9Fy+AtyvU7cwUh+Lt/EFNvsCCUNOobdUtDjzY9zAEOylsqAQsxiz+Plsn
oF8iy8GEx3+yBAN/3UTfgEYq6rkDUPEaGmysLIYM2Utf6b1zqlOS3jSRwMWUuvRy
1OoLL7OW8l6AMLDGwmc+hxSQObruDWW5j0JanW9JXb6BlupfEbxGf7W1ZGvyvoIT
jt/LKjcsfibkRLnWqGvwbEUIAcXxV0CeQTbYbVqsrjFlv1DNkzFhE0QCe4w5fZVz
1UK+79TMMehrfANcWMvg49tnqImw9mv/cVmxg2CQ2Mn5nNVpeRIKbIycRatyW2fg
UJWIbErbNRBqhS/ApWx306rkbpeBQmrqnrtqyrslyClcxI43RLehFKJaRi9cM056
w3DoYMvTyoroIVmEgH9Nwj9zpRQvFhz+x3Ss5cakATheilUWY5Smeicl3xPHbRYu
dd0wlvocX3avz8REESChW7q4beUEA9GafA2q9UQIQ1CoLGOmz2FzE2jbLizEcR22
PhECFM2JIp/ICy22fGBWyZh01AZ1Jfw6T/yzYZj32Cc3Q1sMtkwcdNt6nJqxEBi/
4oLcHJUM7CsL1J/tGhFIl47Is+HwOhCOfN2iQw5ATiMoOmwsd4tmACmPBgAhpYbX
Nuqkoz39Tc2fW7PdrVpGDgdMPi9AgjaBGSElG3H4KZwUXgP/fo0=
=PXEH
-END PGP SIGNATURE-
---

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.6 bc3a093: Build 2.6.19.

2020-08-12 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bc3a09326a25cbd77c183ea74e2d462615ab2868
Submitter: "Gerald Combs "
Changed: branch: master-2.6
Repository: wireshark

Commits:

bc3a093 by Gerald Combs (ger...@wireshark.org):

Build 2.6.19.

Change-Id: Ic99fba21cd074b602624af1c20ac85e9feb2a975
Reviewed-on: https://code.wireshark.org/review/38146
Reviewed-by: Gerald Combs 


Actions performed:

from  1caf550   Prep for 2.6.19.
 add  bc3a093   Build 2.6.19.


Summary of changes:
 ChangeLog| 572 +++
 NEWS |  72 +---
 version.conf |  12 +-
 3 files changed, 629 insertions(+), 27 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] [wireshark] annotated tag v3.0.13 created (now 77b7ea0)

2020-08-12 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=77b7ea08070b130ab7218f2466adaf401bf4a909
Submitter: "Gerald Combs "
Changed: annotated tag: v3.0.13
Repository: wireshark

Commits:

[ log message not found ]


Actions performed:

  at  77b7ea0   (tag)
 tagging  643e3b0f718685b3fa7008a0c5c4707daf63ca99 (commit)
 replaces v3.0.13rc0
  by Gerald Combs
  on Wed Aug 12 10:56:13 2020 -0700

- Log -
Build 3.0.13.
-BEGIN PGP SIGNATURE-

iQIzBAABCgAdFiEEWlrbp9vqbD+HIk8ZgiRKeOb+ruoFAl80LUQACgkQgiRKeOb+
ruowzg/+Jy9Akx4SRYPB7ups6P4/45UJRn6kwO03pQffi3fCCcfzL1DoxcI+JWni
fw4InNz636TdlRFztlsMhyDqjBH75K+cWUKPmNjtqyTV6XH8oqwDcW24UaLrmy6G
nDZhITaQyCOZwGW0lGd334A2dm/7akXOx4sXGOJn038QtR5suTXQ7/CG+NB4PUZO
oBwYd+TnKdksyAOLNmEw51Z/EeDV76Lu2D5pPmmItHP0hRVcSquND+hQpUkxRz4T
TIM3JmjKvpVhpCfr7HWNtn4LcchcDKEhJVXoxiEctNxRS40gQ4YfD4aDC+HJvxln
DVzEq/+CL7DO705diZxi+hI1xqKXItEOClvcXMCS7o6ujj9FH/UQ7puCrDlrbRE9
lnbmTvlKVuDad7ccNuwmKJ+A10qaG6h9rKVvGPBbSnWr71FAXSn4acdyKBExDjWH
anG6mWhdlM7KhxEwoCd2YFxDzj883aJwPNIH82tCw/IBuShYN1l5mV1zIdQDUZmF
8D+LTg/HBDHUuDGp6EowCWGiPFgODF5XgMEaV2CDNU2kVlPpjae81aPpk4aCWvkb
/6Aq87LqX/NZ+JjKnFV02m+kXbuzF5d+OYqc3MDHTgUDkbL/XWtatmTRE1gTXspF
BshFP4pLB/N/NTPGQu5i52K+GqK2AuL+hyjKbsSQZETGcIKj2TE=
=Lgm+
-END PGP SIGNATURE-
---

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] [wireshark] annotated tag wireshark-3.0.13 created (now cfc6391)

2020-08-12 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cfc6391c4c6ec0690fe2d3d80e75ef23371ac90b
Submitter: "Gerald Combs "
Changed: annotated tag: wireshark-3.0.13
Repository: wireshark

Commits:

[ log message not found ]


Actions performed:

  at  cfc6391   (tag)
 tagging  643e3b0f718685b3fa7008a0c5c4707daf63ca99 (commit)
 replaces v3.0.13rc0
  by Gerald Combs
  on Wed Aug 12 10:56:28 2020 -0700

- Log -
Build 3.0.13.
-BEGIN PGP SIGNATURE-

iQIzBAABCgAdFiEEWlrbp9vqbD+HIk8ZgiRKeOb+ruoFAl80LVcACgkQgiRKeOb+
ruqUGQ//UI046DeDq2Hj+dSwU9CPtdhWZQ9/YAZA3Es4akgVyCrX6CKdqpuREpHv
qpkvO71o/8wjQ608/R9KAEDsqL78tEidlwXiz4nm7GHgS03docLwwjO+3A2Hr+UV
8iGhKDWuYsTRQS+sn1TxYvMGDHwQWr7SByeenEKPGGnCZKazmpFMhFM2MPXJ8pp2
kfmgQDyI455WP1xAWqcbzCJPbX2BPKflDFEWRoLtLUScEpNpgJRpbNjev+whmRSH
uLJDsXw48M0auajxy86Y+hHH2CGQPgKFp1PPOB1diAYpct43lMve3J8yx8zsJQob
43W93/os41QbWIG2MBmOIElG+jhlhYORnWWYpiB3qvXTBa0/SaHZz4D86/oVirqR
DLczGfvp6lEuZEoIlpIDf6v8LSdYC2rdlL7YRRq3Lo/8WjGegANCITbL4nTvh90y
V+3S4H5NzDevkk+mS7v73Jd8NqvacUCBUiy4fhFFDxRJDgp/+BGEksFbu4RmHxsa
cC6Tv1i0Rr/CTBoyxg7JOxzw8neKO/9FN6GWzIhK6+9VJCrJoDWsFGl4jWJkxKZ7
OemQee+q5IlstVpidxQMIL9zZO13f/sK6dXxFp7f+Gi+rRDdvRFFFJ5jqeaBTyUw
1sei43wtZ77ViBPw/vladXNfIfUk8CJv5SoF2QiZfKXrTxs0Ki4=
=BQ84
-END PGP SIGNATURE-
---

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

  1   2   3   4   5   6   7   8   9   10   >