Re: [Wireshark-dev] Join wireshark to fix bugs

2024-02-26 Thread Dario Lombardo
Hi Charlie, and welcome to the community. Are you able to compile wireshark? If not, that's where to start. You can find anything in the wireshark developer's guide. https://www.wireshark.org/docs/wsdg_html_chunked/ Once you have compiled it, I guess you would add a dissector. Read chap 9.2 to

Re: [Wireshark-dev] Extcap program based on extcap_example.py

2023-05-22 Thread Dario Lombardo
Hi Timo. Yes, not compiled extcaps are to be placed in the extcap folder. Since you're not integrating into the wireshark building system, you don't have to handle cmake. From a working wireshark installation, just point out where the extcap folder is (have a look at the about dialog, in case you

[Wireshark-dev] capture_file rewind

2022-11-05 Thread Dario Lombardo
Hi, I have an open capture_file that hasn't been processed yet. I want to move to the end of the file at a negative position: -100 is 100 from the end. But I don't have the number or packets in the capture_file. I tried to use get_stats_for_preview, that worked pretty well, but it turned out it

Re: [Wireshark-dev] CARES to old for CentOS8?

2022-09-30 Thread Dario Lombardo
Hi Anders, unfortunately this is a hairy issue. Redhat's policy about security is a bit puzzling. They patch (as told before) old versions to make them not vulnerable, maintaining the same version number. This is weird since being vulnerable or not is something everyone in the world points out by

Re: [Wireshark-dev] WinDump Web site

2022-09-06 Thread Dario Lombardo
Hi, thanks for the report. The best place to file it is wireshark's gitlab. https://gitlab.com/wireshark/wireshark/-/issues On Tue, Sep 6, 2022 at 5:35 PM AreThree wrote: > Hello! > > > > I hope this is the correct place to send this, wasn’t sure since it deals > with the documentation… > > >

Re: [Wireshark-dev] PCAP-over-IP in Wireshark?

2022-01-31 Thread Dario Lombardo
You can have a look at udpdump, which doesn't use TCP but UDP, but it may fit your purpose. On Mon, Jan 31, 2022 at 1:57 PM Erik Hjelmvik wrote: > Hello folks, > > Is there some way to read PCAP-over-IP in Wireshark? I.e. read a PCAP > stream over a TCP socket. > > Currently, the best solution

[Wireshark-dev] Unable to manually create a MR

2021-12-27 Thread Dario Lombardo
Hi list, my regular workflow is to push on a branch on my fork, then go to the main merge requests page, where I am proposed for creating a new merge request. This works as expected. However if I click on "new merge request" I land on a page where the source and destination branch can be selected.

Re: [Wireshark-dev] Windows build fails

2021-12-17 Thread Dario Lombardo
itch the GitHub builders to a newer Windows SDK? > > On 12/16/21 3:31 AM, Dario Lombardo wrote: > > Hi > > The github windows builder is failing > > > > > https://github.com/wireshark/wireshark/runs/4546222143?check_suite_focus=true > < > https://git

Re: [Wireshark-dev] Windows build fails

2021-12-16 Thread Dario Lombardo
n't support C11. Please make sure you're >using 10.0.20348.0 or later. > > Is there any way to switch the GitHub builders to a newer Windows SDK? > > On 12/16/21 3:31 AM, Dario Lombardo wrote: > > Hi > > The github windows builder is failing > > > > &g

[Wireshark-dev] Windows build fails

2021-12-16 Thread Dario Lombardo
Hi The github windows builder is failing https://github.com/wireshark/wireshark/runs/4546222143?check_suite_focus=true It started to show up around a couple of days ago, around commit 77b6bca3870d5ef63303e637cc39e2cf83f49ddc, as seen on

Re: [Wireshark-dev] How to troubleshoot extcap applications?

2021-12-01 Thread Dario Lombardo
I'm ok with this change. I can give you direct support for the extcaps I wrote (sshdump/ciscodump, udpdump, randpktdump), and do my best with the others. On Wed, Dec 1, 2021 at 2:18 PM Jirka Novak wrote: > Hi, > > I noticed issue below and I propose a solution for it. Can I ask for >

Re: [Wireshark-dev] Triggering "Windows Build" job

2021-09-14 Thread Dario Lombardo
On Mon, Sep 13, 2021 at 7:39 PM Gerald Combs wrote: > How long does the GitHub action take to run? According to the jobs history, it takes 25 to 30 minutes, which looks comparable to the wireshark's builds for windows on gitlab. It usually gets scheduled very quickly, which does not happen in

Re: [Wireshark-dev] Triggering "Windows Build" job

2021-09-13 Thread Dario Lombardo
You can also leverage github actions: it has a windows build. Just push on a github fork of yours and you'll trigger a windows build. https://github.com/wireshark/wireshark/actions/workflows/windows.yml On Mon, Sep 13, 2021 at 2:48 PM Ivan Nardi wrote: > Hi Roland > I thought that the present

[Wireshark-dev] Builders & decryption on ubuntu 20.04

2021-09-02 Thread Dario Lombardo
Hi I've set up a builder on github workflows using their ubuntu-latest (20.04) image. The builds regularly fail because of a missing decryption. Example: https://github.com/crondaemon/wireshark/runs/3491926537?check_suite_focus=true However my local Ubuntu 20.04 works fine. I've compared the

Re: [Wireshark-dev] Siemens S7Comm-Plus protocol support

2021-08-19 Thread Dario Lombardo
> > > You could: > > go to the code tab at > https://sourceforge.net/p/s7commwireshark/code/HEAD/tree/; > > clone the repository; > > download the Wireshark 3.4.7 source, so the Wireshark header files > are available, if you haven't done so already; > > run the

[Wireshark-dev] I'm broken on the inside, please somebody fix me...

2021-07-02 Thread Dario Lombardo
(Not talking about me... ;)). That's the message I'm getting by Wireshark Gitlab Utilily in https://gitlab.com/wireshark/wireshark/-/merge_requests/3544 I have approved the MR and assigned it to the bot, and would have expected the change to be rebased and merged. Am I missing something or is the

Re: [Wireshark-dev] Qt link errors (Q_INIT_RESOURCE)

2021-03-30 Thread Dario Lombardo
Hi, Martin Did you try to bisect? On Tue, Mar 30, 2021 at 11:16 AM Martin Mathieson via Wireshark-dev < wireshark-dev@wireshark.org> wrote: > I started getting this link error a day or 2 back: > > [ 98%] Linking CXX executable run/wireshark >

Re: [Wireshark-dev] Improvments for NVMeOF dissector

2021-03-29 Thread Dario Lombardo
Hi Constantine I know that sometimes working on a change without getting it merged soon can be frustrating. Unfortunately it is as you just described: this is a voluntary-based project where people donate their own time just for the love of the project itself. And it is not "don't bother me, I

Re: [Wireshark-dev] tvb_get_nstringz0

2021-03-29 Thread Dario Lombardo
:57 PM Dario Lombardo wrote: > >> Hi John, >> thanks, your explanation helped a lot. However I still don't get why the >> code crashes. Please let me use the actual buffer sizes since the ones I >> told before were examples. The packet is 49, the local buffer is 15. >

Re: [Wireshark-dev] tvb_get_nstringz0

2021-03-27 Thread Dario Lombardo
Hi John, thanks, your explanation helped a lot. However I still don't get why the code crashes. Please let me use the actual buffer sizes since the ones I told before were examples. The packet is 49, the local buffer is 15. When you call tvb_get_nstringz0() you pass in bufsize = 15. >

[Wireshark-dev] tvb_get_nstringz0

2021-03-26 Thread Dario Lombardo
Hi, I am a bit puzzled by the use of tvb_get_nstringz0. Let's say I have a packet 100 bytes long, that does NOT contain NUL. I call tvb_get_nstringz0 with a buffer 10 bytes long. For what I can see, the function will seek the packet for NUL, stopping at the end of the packet, copying the result

Re: [Wireshark-dev] Revive the happy-shark repository?

2021-01-22 Thread Dario Lombardo
Talking about your options: 1) my concern here is that we would have 2 repos, with parallel lifecycles, that are not enforced to stay aligned. A change in a dissector would benefit from a test case, but such a testcase in happy-shark would be proposed after the code merge in the main repo. That

Re: [Wireshark-dev] git doesn't like me anymore

2021-01-18 Thread Dario Lombardo
Hi Fulko Git can look really confusing at the beginning especially for people with long time experience on other code revision systems such as SVN (as it was for me). There are 2 things to take into account. The first one is git itself. That includes commands such as commit, push, pull, remote

Re: [Wireshark-dev] Setcap in ubuntu 20.04

2021-01-06 Thread Dario Lombardo
Another user on SO suggested a fix https://stackoverflow.com/questions/58255970/wireshark-dumpcap-with-setcap-set-to-no-root-capture-failes-to-start-in-ubuntu-1 However I'm pretty sure I've run wireshark from the build dir before with setcap. On Wed, Jan 6, 2021 at 9:20 PM Dario Lombardo wrote

[Wireshark-dev] Setcap in ubuntu 20.04

2021-01-06 Thread Dario Lombardo
Hi I got a new laptop and I took the chance to upgrade my OS. Now I have Ubuntu 20.04. Today I had an unexpected behavior. After compilation, I issued the setcap command, but then I got: $ sudo setcap cap_net_raw,cap_net_admin=eip run/dumpcap $ ./run/dumpcap -D ./run/dumpcap: error while loading

Re: [Wireshark-dev] Assigned reviewers

2021-01-06 Thread Dario Lombardo
> > >> Do you mean assignee? I guess so, but I'd like to clear it, since the >> reviewer and assignee were separate in Gerrit. >> > > No I really meant reviewer as I was considering the assignee as the person > that will ultimately schedule the merge. You can have more than one > reviewer. But I'm

Re: [Wireshark-dev] Assigned reviewers

2021-01-06 Thread Dario Lombardo
On Wed, Jan 6, 2021 at 9:38 AM Pascal Quantin wrote: > Hi Jonathan, > > Le mer. 6 janv. 2021 à 05:39, Jonathan Nieder a > écrit : > >> Hi wiresharks, >> >> Context: >> https://gitlab.com/wireshark/wireshark/-/merge_requests/1313#note_478706594 >> >> In Gerrit times, a person could add someone

Re: [Wireshark-dev] tpdu_data missing in gtp packet

2020-12-24 Thread Dario Lombardo
On Thu, Dec 24, 2020 at 9:29 AM Pascal Quantin wrote: > > > Le jeu. 24 déc. 2020 à 09:16, Dario Lombardo a écrit : > >> Can you please tell a version in which is present and a version in which >> is not? >> > > And please clarify your GTP setting regardin

Re: [Wireshark-dev] tpdu_data missing in gtp packet

2020-12-24 Thread Dario Lombardo
Can you please tell a version in which is present and a version in which is not? On Thu, Dec 24, 2020 at 8:54 AM Ranjeet kumar singh wrote: > Hi > > Gtp packets used to have a tpdu_data field. > > I don't see it in the latest wireshark. > > This is causing my lua plugins to break. > > Can

Re: [Wireshark-dev] How to properly finalize capture in a Wireshark extcap plugin?

2020-11-23 Thread Dario Lombardo
Indeed the used signal to terminate the extcap is SIGTERM. Is your signal handler called? Did you run a debugger to see which signal is interrupting your code? Did you try your code on unix? On Mon, Nov 23, 2020 at 10:31 AM Timmy Brolin wrote: > I am writing a extcap plugin for Wireshark

[Wireshark-dev] Windows update on development version

2020-11-20 Thread Dario Lombardo
Hi, I'm not that used to builds on windows, then maybe what happened is perfectly normal. I fired up a dev version of wireshark and suddenly wireshark asked me if I wanted to update to a newer version. I have no idea of what would have happened if I accepted. Shouldn't updates be disabled on

Re: [Wireshark-dev] Introduction - An Outreachy 2020 Applicant

2020-10-16 Thread Dario Lombardo
I'd suggest moving forward with the sequence a/c/b. IMO this gives a growing difficulty that allows a soft approach with the code base. If I'm not missing anything, (a) involves adding expert infos, that is one of the easiest tasks in wireshark. On the other hand (c) involves pytest, which I found

Re: [Wireshark-dev] How to remove uploaded file on wiki page?

2020-10-15 Thread Dario Lombardo
No, as far as I know. When you upload a file, you're given a link with some sort of hash that points to the file. The link you create is [myfile](blablahash1). If you upload a newer version of that file, and replace the link with [myfile](blablahash2), the effect is to have a new version of the

Re: [Wireshark-dev] Apple VM for Gui testing

2020-10-08 Thread Dario Lombardo
On Thu, Oct 8, 2020 at 4:34 AM chuck c wrote: > Looking to build a Mac dev environment without paying the Apple hardware > tax. > > Are there technical, moral, legal issues where this is a bad idea? > > All of the above but moral, that is up to you. AFAIK macOS uses some kind of signature to see

[Wireshark-dev] fuzzshark friends missing

2020-09-16 Thread Dario Lombardo
Hi I've started from scratch a build dir for oss-fuzz tests. I've run ninja all-fuzzers, but the only fuzz target that gets compiled is fuzzshark, while I would have expected to also get fuzzshark_ip and friends. Looking at the git log I don't see anything obvious about changes in the build

Re: [Wireshark-dev] pipeline failed at the Restore Cache step

2020-09-10 Thread Dario Lombardo
Your CI failed for trailing whitespaces. $ bash ./tools/pre-commit 'HEAD^1' epan/dissectors/packet-tcp.c:1351: trailing whitespace. + epan/dissectors/packet-tcp.c:1356: trailing whitespace. + epan/dissectors/packet-tcp.c:1362: trailing whitespace. + epan/dissectors/packet-tcp.c:1369: trailing

Re: [Wireshark-dev] Managing Gitlab Issues

2020-09-04 Thread Dario Lombardo
On Fri, Sep 4, 2020 at 1:12 PM Uli Heilmeier wrote: > Hi list, > > I’ve tried to update the instructions to report an issue (fka bug) in the > wiki [1]. > > There are some things we need to sort out. (Maybe this has already been > done on the core list.) > > * Do we want to have labels to mark

Re: [Wireshark-dev] Winflexbison update in choco

2020-09-04 Thread Dario Lombardo
unless you install from scratch (that's what CIs do). On Wed, Sep 2, 2020 at 3:00 PM Dario Lombardo wrote: > The build is actually done by the github actions builder. A brand new dir > gets created every time. > > > https://github.com/crondaemon/wireshark/actions?query=workflow%3A%

Re: [Wireshark-dev] Winflexbison update in choco

2020-09-02 Thread Dario Lombardo
The build is actually done by the github actions builder. A brand new dir gets created every time. https://github.com/crondaemon/wireshark/actions?query=workflow%3A%22Build+Windows%22+branch%3Amaster On Wed, Sep 2, 2020 at 2:53 PM Graham Bloice wrote: > > On Wed, 2 Sep 2020 at 13:43,

[Wireshark-dev] Winflexbison update in choco

2020-09-02 Thread Dario Lombardo
Hi Some days ago (30th aug), the choco package winflexbison3 was updated. Since then, my cmake can't find the LEX_EXECUTABLE as well as the YACC_EXECUTABLE. Any idea on what happened? I've fixed the builds by setting LEX_ and YACC_EXECUTABLE in cmake, but I don't know whether this is the correct

Re: [Wireshark-dev] Add plugin timing statistics

2020-08-31 Thread Dario Lombardo
You could start by reading stats_tree documentation that tells you how handle statistic using the stats_tree subsystem (based on tap, but more evolved), by reading packet_info structure that stores info about lower layer protocols, and by reading the DNS dissector (above others), that creates

Re: [Wireshark-dev] Build error with packet-cipmotion.c ?

2020-08-30 Thread Dario Lombardo
I'm seeing the same thing on several builders. It definitely needs fixing. On Sat, Aug 29, 2020, 21:53 Martin Mathieson via Wireshark-dev < wireshark-dev@wireshark.org> wrote: > I am seeing this error with current master: > > /home/martin/wireshark_gl/epan/dissectors/packet-cipmotion.c: In

Re: [Wireshark-dev] Pro tip, at least for Safari users - do not keep GitLab windows open and un-minimized any longer than necessary

2020-08-26 Thread Dario Lombardo
Gitlab runs a background javascript jobs that pulls the server for new comments on a issue. This way they appear to your window as soon as they have been created by a concurrent user. This gives a good user experience and is easily seen in the browser debugger/network window. This could be the

Re: [Wireshark-dev] GitLab migration update

2020-08-25 Thread Dario Lombardo
On Tue, Aug 25, 2020 at 12:56 PM Peter Wu wrote: > > It looks like you have to delete the old stale fork relationship first, > otherwise you will end up with a 409 Conflict error ("Project already > forked"). > > To automate fixing the fork status without requiring creation of an > access token,

Re: [Wireshark-dev] wiredifff: a diff tool for pcaps

2020-07-14 Thread Dario Lombardo
Good job, very interesting presentation! On Mon, Jul 13, 2020 at 5:09 PM Aurélien Aptel wrote: > Hi, > > I've been working on and off on a tool that leverages wireshark (tshark) > to do side-by-side diff of network captures. > > I've presented the tool at LCA 2020 and I have written an article

Re: [Wireshark-dev] Intermittent Builder Windows Petri Dish x64 failed (failed ctest) failures seriously annoying.

2020-07-02 Thread Dario Lombardo
You're right, it's not the test I pointed out. However it worked fine before, then I would check the host to see if it's suffering. On Thu, Jul 2, 2020 at 4:51 PM Graham Bloice wrote: > The decryption test might need a bigger timeout, currently at 600 seconds: > > 9/34 Test #3:

Re: [Wireshark-dev] Intermittent Builder Windows Petri Dish x64 failed (failed ctest) failures seriously annoying.

2020-07-02 Thread Dario Lombardo
This looks to be the failing test 9: test_s_lt_2 (suite_dfilter.group_integer.case_integer) ... ok 9/34 Test #3: suite_decryption ...***Timeout 630.47 sec test 12 Start 12: suite_dfilter.group_membership It fails for timeout. Looking at the code of the test itself it

Re: [Wireshark-dev] WSDG - errors in message reassembly documentation

2020-06-25 Thread Dario Lombardo
Hi Brett You could 1) file a bug on bugzilla 2) push the change yourself on gerrit, since the wsdg is versioned as the rest of the code. (or both of course). On Thu, Jun 25, 2020 at 4:04 PM Brett Hallen wrote: > Hello! > > I've got my first dissector up and running using the excellent >

Re: [Wireshark-dev] Code discussion - Extcap help files on Windows

2020-06-18 Thread Dario Lombardo
Hi Chuck There are no written rules for that, but basically the discussions take place on gerrit when they are related to the code review itself. They are moved or are started on -dev when they need more thoughts, more people or simply when they become too long. Unless you have a working solution

Re: [Wireshark-dev] git clone does not include latest commits

2020-06-08 Thread Dario Lombardo
On Sat, Jun 6, 2020 at 12:40 PM Pascal Quantin wrote: > > The patch you are referring to is still under review and not merged yet. > If you want to test it you need to apply it by yourself. > > To do that, gerrit gives you some useful commands for copy Click on the "download" item in the upper

Re: [Wireshark-dev] First patch submission (extcap install flags for silent mode)

2020-05-12 Thread Dario Lombardo
On Tue, May 12, 2020 at 10:10 AM Graham Bloice wrote: > 3. The extcap help files on Windows are not found: >> https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15592 >> Moving them to the same directory as the binaries would fix this. >> Do in this patch or since it's a different bug make a

Re: [Wireshark-dev] macOS build broken

2020-04-24 Thread Dario Lombardo
rberos.c >> > In file included from >> ./asn1/kerberos/packet-kerberos-template.c:321: >> > >> >> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/Kerberos.framework/Headers/k

Re: [Wireshark-dev] macOS build broken

2020-04-24 Thread Dario Lombardo
Hi, I was aware of such a problem. The travis macOS builder got that while ago. https://travis-ci.org/github/crondaemon/wireshark I didn't bisect, but going back in build history, I looks something between 2acbaf584984828855a36105258033020f338c5c and d30a0a2ce7c17f5d695e9ee7647e92d3cc1156bb. On

Re: [Wireshark-dev] tshark: -e field output limitation

2020-04-13 Thread Dario Lombardo
Hi Martin Unless anyone objects, I'd go with --preserve-layers. I suggested you this way because tshark has so many short options that we've almost run out of alphabet letters. I'd be very careful and conservative when eating up more letters. Moreover -k is an option used by wireshark to run

Re: [Wireshark-dev] GitLab migration update

2020-04-06 Thread Dario Lombardo
On Sun, Apr 5, 2020 at 11:57 PM Peter Wu wrote: > On Sun, Apr 05, 2020 at 01:10:37AM +0200, Dario Lombardo wrote: > > However, I logged in in via github and then connected my google account, > > but no projects show up. Maybe the project has been set up as "private"

Re: [Wireshark-dev] GitLab migration update

2020-04-04 Thread Dario Lombardo
google account, but no projects show up. Maybe the project has been set up as "private" (explicit allowance) instead of "internal" (implicit for logged users). On Sun, Apr 5, 2020 at 12:43 AM Gerald Combs wrote: > On 4/4/20 9:16 AM, Dario Lombardo wrote: > > Hi Gerald

Re: [Wireshark-dev] GitLab migration update

2020-04-04 Thread Dario Lombardo
On Sat, Apr 4, 2020, 01:47 Gerald Combs wrote: > > We also have a self-hosted test server up and running at > https://gitlab-test.wireshark.org. Feel free to create an account, create > merge requests, etc. If you'd like to try out a feature that requires a > configuration change, let me know. >

[Wireshark-dev] Regenerating moc files

2020-03-27 Thread Dario Lombardo
Hi, is there a cmake target to unconditionally regenerate Qt moc files? If I change something in the cmake defines, the target qtui_autogen doesn't actually regenerate the moc files, giving me a compilation error. Otherwise if I manually remove the moc dir ui/qt/qtui_autogen/ and recompile, goes

Re: [Wireshark-dev] Build without LUA fails

2020-03-27 Thread Dario Lombardo
It worked. I'm pushing the fix. Thanks you made my day ;). On Fri, Mar 27, 2020 at 6:16 PM Pascal Quantin wrote: > Hi Dario, > Le ven. 27 mars 2020 à 18:10, Dario Lombardo a écrit : > >> On Thu, Mar 19, 2020 at 9:09 AM Pascal Quantin >> wrote: >> >>&

Re: [Wireshark-dev] Build without LUA fails

2020-03-27 Thread Dario Lombardo
On Thu, Mar 19, 2020 at 9:09 AM Pascal Quantin wrote: > > Note that the previous patch was incomplete. Lines 103 and 108 must be > changed also. See https://code.wireshark.org/review/#/c/36494/ > > Should have it fixed the compilation when lua is installed but disabled through ENABLE_LUA=0? I am

Re: [Wireshark-dev] Build failure (kerberos)

2020-03-23 Thread Dario Lombardo
Ok, this seems to work. I'm pushing the fix. On Mon, Mar 23, 2020 at 9:29 AM Pascal Quantin wrote: > > > Le lun. 23 mars 2020 à 09:17, Dario Lombardo a écrit : > >> >> >> On Sun, Mar 22, 2020 at 6:15 PM Dario Lombardo wrote: >> >>> Ok, thanks. &

Re: [Wireshark-dev] Build failure (kerberos)

2020-03-23 Thread Dario Lombardo
On Sun, Mar 22, 2020 at 6:15 PM Dario Lombardo wrote: > Ok, thanks. > > On Sun, Mar 22, 2020 at 9:48 AM Martin Mathieson < > martin.r.mathie...@googlemail.com> wrote: > >> >>>> ./asn1/kerberos/packet-kerberos-template.c: In function >>>> ‘diss

Re: [Wireshark-dev] Build failure (kerberos)

2020-03-22 Thread Dario Lombardo
Ok, thanks. On Sun, Mar 22, 2020 at 9:48 AM Martin Mathieson < martin.r.mathie...@googlemail.com> wrote: > >>> ./asn1/kerberos/packet-kerberos-template.c: In function >>> ‘dissect_krb5_PAC_CREDENTIAL_INFO’: >>> ./asn1/kerberos/packet-kerberos-template.c:2187:2: error: implicit >>> declaration of

Re: [Wireshark-dev] Build failure (kerberos)

2020-03-21 Thread Dario Lombardo
Hi, Martin There are indeed some issues with conditional compilation with kerberos. However I cannot reproduce this exact problem. Which is your build environment? On Sat, Mar 21, 2020 at 9:41 PM Martin Mathieson via Wireshark-dev < wireshark-dev@wireshark.org> wrote: > I am seeing this: > >

Re: [Wireshark-dev] Clarifications regarding building wireshark

2020-03-16 Thread Dario Lombardo
On Mon, Mar 16, 2020 at 7:37 AM Ankish Shah wrote: > I've downloaded and built wireshark on Ubuntu machine and I was going > through the documentation of building new dissectors. > I have a couple of doubts. > 1. When I write code for a new dissector, do I have to build the entire > wireshark

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo
Looks like I made it. https://github.com/crondaemon/wireshark/runs/490547471?check_suite_focus=true The artifact can be found in the upper right area of the screen. On Fri, Mar 6, 2020 at 3:29 PM Dario Lombardo wrote: > > > On Fri, Mar 6, 2020 at 3:21 PM João Valverde <

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo
On Fri, Mar 6, 2020 at 3:21 PM João Valverde < joao.valve...@tecnico.ulisboa.pt> wrote: > If you want to spare some CPU cycles I believe only the user_guide_chm > target is mandatory for NSIS. > > Seems you are missing some dependencies too, asciidoctor and maybe others > as well. > > Yes to

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo
> > Si it seems like it is not running the MSVC 2019 command prompt that takes > care of setting the various environment variables. > Well... this is a point. I added the proper action and it made it a bit further. https://github.com/crondaemon/wireshark/runs/490228280?check_suite_focus=true

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo
On Fri, Mar 6, 2020 at 12:44 PM Pascal Quantin wrote: > > > Le ven. 6 mars 2020 à 12:28, Dario Lombardo a écrit : > >> I am sorry, I still don't understand, I beg your pardon. >> You said >> >> > your machine does not have the MSVC redistributable

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo
ere it is explained that the MSVC redistributable has to be copied somewhere, nor I know how to do it myself without a more detailed explanation. On Fri, Mar 6, 2020 at 12:20 PM Pascal Quantin wrote: > Hi Dario, > > Le ven. 6 mars 2020 à 12:16, Dario Lombardo a écrit : > >> Hi P

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo
Hi Pascal I'm not sure I got the point. I try to explain what I understand. I have one single build, that may have multiple problems, some trivial, some not. The error I see in cmake could be ignored, while the one that counts is the fact I need the MSVC redistributable in the wireshark-lib

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo
No, it's the same. Have a look at the cmake section and you will see the error messages below. On Fri, Mar 6, 2020 at 10:54 AM João Valverde < joao.valve...@tecnico.ulisboa.pt> wrote: > > > On 06/03/20 08:23, Dario Lombardo wrote: > > Example of failing build > > >

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo
Example of failing build https://github.com/crondaemon/wireshark/runs/489648430?check_suite_focus=true On Fri, Mar 6, 2020 at 9:07 AM Dario Lombardo wrote: > Are you saying "set v"? It doesn't print anything. > The installation of VS is pre-made by the github builder itself, no

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo
H. What do you think? On Thu, Mar 5, 2020 at 9:36 PM Gerald Combs wrote: > On 3/5/20 7:27 AM, Dario Lombardo wrote: > > Hi, > > I'm getting this output from a windows build > > > > -- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND > > -- Using MERGE_MODULE_DIR-NOTFOUN

[Wireshark-dev] Cmake on windows

2020-03-05 Thread Dario Lombardo
Hi, I'm getting this output from a windows build -- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND -- Using MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm for the WiX installer -- Configuring done -- Generating done -- Build files have been written to: D:/a/wireshark/wireshark/build What's

Re: [Wireshark-dev] Build mac binaries

2020-03-03 Thread Dario Lombardo
It looks it was the point. Now my builder succeeds in building a dmg. On Tue, Mar 3, 2020 at 8:17 AM Dario Lombardo wrote: > I do, but I have installed it after cmake (it's a builder actually that's > making the binary). Is the target conditionally created? > > On Mon, Mar 2, 2020,

Re: [Wireshark-dev] Build mac binaries

2020-03-02 Thread Dario Lombardo
dmg.sh, which in turn creates the .dmg > using dmgbuild. > > On 3/2/20 7:54 AM, Dario Lombardo wrote: > > Hi > > I'm trying to build a mac binary package. The instructions I found here > > > > https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcBinary.html > >

[Wireshark-dev] Build mac binaries

2020-03-02 Thread Dario Lombardo
Hi I'm trying to build a mac binary package. The instructions I found here https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcBinary.html look a bit incomplete. If understand what the instructions say, I should run make (ninja) dmg_package, but this isn't enough. Am I doing something wrong?

Re: [Wireshark-dev] LUA on freebsd

2020-02-04 Thread Dario Lombardo
I can confirm it works properly on my builders (11.3, 12.0 and 13.0). Thanks. On Sat, Feb 1, 2020 at 2:20 AM Guy Harris wrote: > On Jan 31, 2020, at 3:56 PM, Guy Harris wrote: > > > Or perhaps we're looking for "lua5.2" but not for "lua-5.2" as well. > > > > Which we are. > > > > I'll fix

Re: [Wireshark-dev] LUA on freebsd

2020-01-30 Thread Dario Lombardo
On Thu, Jan 30, 2020 at 12:44 PM Peter Wu wrote: > > a lua-5.2 pkg-config file is installed and headers are available under > include/lua52, so it should work. > > I installed lua52, and got this: https://cirrus-ci.com/task/4716205919436800 The library is not properly detected, but then tried

[Wireshark-dev] LUA on freebsd

2020-01-30 Thread Dario Lombardo
Hi, I tried to install all the dependencies on freebsd, but LUA is missing. Does anyone knows which packages are to be installed to be found by cmake? -- Naima is online. ___ Sent via:Wireshark-dev mailing list

Re: [Wireshark-dev] Bug in extcap?

2020-01-26 Thread Dario Lombardo
There is at least one bug open for that. Can you push a change on gerrit so we can start the review/discussion? On Sat, Jan 25, 2020, 22:54 Anders Esbensen wrote: >  > > Hi, > > > > I’m seeing some issues with extcap on linux and osx. If I run udpdump and > stop it again the udp process is not

Re: [Wireshark-dev] retrigger petri dish buildbot

2020-01-25 Thread Dario Lombardo
It's something only the core-developers can do, as Pascal did. On Sat, Jan 25, 2020, 10:45 Erwin Rol wrote: > Hey all, > > one of my patches failed to be verified (due to some build problem that > did not have anything to do with my patch) now I rebased it but that > doesn't seem to trigger a

Re: [Wireshark-dev] Bypassing the first layer

2020-01-15 Thread Dario Lombardo
. On Wed, Jan 15, 2020 at 2:37 PM Juanjo Martin Carrascosa wrote: > https://sharkfestus.wireshark.org/assets/presentations18/17.pptx > > On Wed, Jan 15, 2020 at 2:36 PM Dario Lombardo wrote: > >> Can you share the link, for future reference? >> >> On Wed, Jan 15,

Re: [Wireshark-dev] Bypassing the first layer

2020-01-15 Thread Dario Lombardo
>> *From:* Wireshark-dev *On Behalf >> Of *Juanjo Martin Carrascosa >> *Sent:* den 15 januari 2020 12:24 >> *To:* Developer support list for Wireshark >> *Subject:* Re: [Wireshark-dev] Bypassing the first layer >> >> >> >> Hi Dario, >>

Re: [Wireshark-dev] Bypassing the first layer

2020-01-14 Thread Dario Lombardo
You can use export_pdu. This is a layer with multiple attributes (see epan/exported_pdu.h), but the only really needed is the proto_name, that allows you to directly call a dissector by its name. You will have frames with this stack: FRAME/EXPORT PDU/RTPS, that is properly dissected by wireshark.

Re: [Wireshark-dev] Standard defined field names in Wireshark dissectors

2020-01-05 Thread Dario Lombardo
I agree that scripts should not rely on such an output. However sometimes there isn't another option or people just do it anyway. We must consider that as well. Talking about Tomasz proposal, I agree that we should follow the standards as closely as possible. But if that breaks backward

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2019-12-28 Thread Dario Lombardo
Hi For Ubuntu there is tools/debian-setup.sh that installs optional packages (as this). I suggest you to test your change at least on this platform since it's the most common. Did you make your change compilable without that library? You need some preprocessor ifdefs for that. If you push your

Re: [Wireshark-dev] Extcap binaries on OSX

2019-12-20 Thread Dario Lombardo
Ok, thanks. And what does the python command "sys.platform" return? On Fri, Dec 20, 2019 at 11:46 AM Roland Knall wrote: > run/Wireshark.app/Contents/MacOS/extcap > > cheers > Roland > > Am Fr., 20. Dez. 2019 um 10:31 Uhr schrieb Dario Lombardo < > lom...@

[Wireshark-dev] Extcap binaries on OSX

2019-12-20 Thread Dario Lombardo
Hi, I'm trying to debug some CI jobs on OSX but I don't have a OSX machine. I'm trying to find where the extcap binaries are put on OSX using cmake. Linux: run\extcap Windows: run\RelWithDebInfo\extcap OSX: ? Any help? Thanks. Dario. -- Naima is online.

Re: [Wireshark-dev] Adding a new packet to Wireshark

2019-12-06 Thread Dario Lombardo
On Fri, Dec 6, 2019 at 9:58 PM Richard Sharpe wrote: > > As Dario has already said, there should not be any problems. You will > have to release the changes under the GPL, though. Or any compatible licence. We have BSD licensed dissectors as well as GPL.

Re: [Wireshark-dev] Adding a new packet to Wireshark

2019-12-06 Thread Dario Lombardo
I can't see any blocker in what you're proposing. Feel free to push your proposals and follow the review process. Thanks for the contribution. On Fri, Dec 6, 2019 at 9:50 PM Bruni, Michelle wrote: > Hello, > > I am Michelle and I work at Spirent Communications. We have been building > Wireshark

Re: [Wireshark-dev] Missing dumpcap when building 3.1.1

2019-11-29 Thread Dario Lombardo
Have a look at cmake's output. It will say something about libpcap (whether is found or not). If it's found, you can compile dumpcap with ninja/make dumpcap, just to be sure it's compiled. However a straight compilation command should do its job. On Fri, Nov 29, 2019 at 3:04 PM Tom Bentley

Re: [Wireshark-dev] Visual studio 2019 from choco

2019-11-27 Thread Dario Lombardo
On Tue, Nov 26, 2019 at 5:49 PM Graham Bloice wrote: > Oh. A very old and unsupported (by MS) version of Win 10. See here for > lifecycle info: > https://support.microsoft.com/en-gb/help/13853/windows-lifecycle-fact-sheet > > And 1511 came with .Net 4.6.1, hence the issue with installing VS

Re: [Wireshark-dev] Visual studio 2019 from choco

2019-11-27 Thread Dario Lombardo
Agreed. I didn't think about it. I just took the first ISO I found. I don't install windows very often. On Tue, Nov 26, 2019 at 6:34 PM Jasper Bongertz wrote: > > > > > > > Oh. A very old and unsupported (by MS) version of Win 10. See here for > lifecycle info: >

Re: [Wireshark-dev] Visual studio 2019 from choco

2019-11-26 Thread Dario Lombardo
> > > Oh. A very old and unsupported (by MS) version of Win 10. See here for > lifecycle info: > https://support.microsoft.com/en-gb/help/13853/windows-lifecycle-fact-sheet > > Indeed. It was a fresh install with no updates (due to network issues). I'm updating the system now: let's see if it

Re: [Wireshark-dev] Visual studio 2019 from choco

2019-11-26 Thread Dario Lombardo
On Tue, Nov 26, 2019 at 3:50 PM Graham Bloice wrote: > > > On Tue, 26 Nov 2019 at 14:29, Dario Lombardo wrote: > >> I'm chatting with choco maintainers right now. They say it sounds like a >> fresh win10 install will fail with dotnetfx because M$ now requires >>

Re: [Wireshark-dev] Visual studio 2019 from choco

2019-11-26 Thread Dario Lombardo
I'm trying to make my system up2date and then install dotnet. if I succeed, I'll drop a line in the documentation about installing on an updated windows version, or a more detailed description of the issue. On Tue, Nov 26, 2019 at 3:20 PM Graham Bloice wrote: > > On Tue, 26 Nov 2019 at 11:55

[Wireshark-dev] Visual studio 2019 from choco

2019-11-26 Thread Dario Lombardo
Hi I'm following the win32/64 guide from the very beginning on a fresh win10 VM. I'm basically at the top, but I hit an error. In chap 2.2.2 I'm issuing the choco command to install visualstudio. The installation fails because dotnetfx fails. I've found this error message: The .NET Framework 4.8

Re: [Wireshark-dev] Wireshark Developer's Guide bad URL

2019-11-20 Thread Dario Lombardo
Thanks. On Wed, Nov 20, 2019 at 2:27 AM Moshe Kaplan wrote: > Thanks for reporting; I submitted > https://code.wireshark.org/review/#/c/35146/ to fix this issue. > > Moshe > > On Tue, Nov 19, 2019 at 7:21 PM Gavin Higham > wrote: > >> I noticed on this page of the Wireshark Developer's Guide

  1   2   3   4   5   >