Re: [Wireshark-dev] Tracking branches, GitHub and Launchpad

2024-01-25 Thread Peter Wu via Wireshark-dev
not appear to get mirrored. I just deleted 216 branches manually with: git ls-remote https://github.com/wireshark/wireshark 'cherry-pick*' | awk '{print $2}' | xargs git push --delete g...@github.com:wireshark/wireshark.git I will install a branch protection rule on Gi

Re: [Wireshark-dev] 4.2.0 release schedule

2023-08-24 Thread Peter Wu via Wireshark-dev
Hi, In the last weeks I started using Wireshark more and noticed some crashes. I hope to be able to look into it over the next two weeks, and also address some QUIC issues. Not sure if I will be able to review the HTTP/3 changes in time. Do you think it is better to branch, and then cherry-pick,

Re: [Wireshark-dev] Email archive download

2021-06-13 Thread Peter Wu
Hi Chuck, There are a couple of external archives, see https://www.wireshark.org/lists/ In the past GMANE offered a web interface (HTTP) as well as a "news" (NNTP) interface, you could try that as well. See https://gmane.io/ and the gmane.network.wireshark.devel list over NNTP. I have not

Re: [Wireshark-dev] [Season of Docs] Congratulations on successfully completing your project

2021-03-31 Thread Peter Wu
regards, Peter Wu https://lekensteyn.nl On Mon, Mar 15, 2021 at 07:03:12PM +0100, Alex Nik wrote: > Thanks Graham. > > I actually have a topic to present now! <3 > > And I forgot to share some topic related art I was inspired by Wireshark :D > > > Regards, > Alex &

Re: [Wireshark-dev] Revive the happy-shark repository?

2021-02-02 Thread Peter Wu
not maintained, but if someone would pick it up, we can reconsider moving it to GitLab. -- Kind regards, Peter Wu https://lekensteyn.nl On Fri, Jan 22, 2021 at 10:49:51PM +0100, Jaap Keuter wrote: > Hi, > > As for the options proposed by Dario, > 1) git submodules basically pin

Re: [Wireshark-dev] GSoD approved technical writer - community bonding phase

2020-08-28 Thread Peter Wu
Hi Alex, Feel free to reach out in private to me and Tomasz, or the wireshark-dev list. We should probably set up an initial call using Jitsi or similar to discuss the initial planning and answer any questions you may have. For communication, we have just moved to GitLab for issue tracking and

Re: [Wireshark-dev] GitLab migration update

2020-08-25 Thread Peter Wu
atus without requiring creation of an access token, I wrote a small script that can be executed from your web browser. See https://gitlab.com/wireshark/wireshark/-/issues/16806 -- Kind regards, Peter Wu https://lekensteyn.nl

Re: [Wireshark-dev] Support for TLS1.2 decryption using derived keys

2020-06-18 Thread Peter Wu
, I was not able to see where the session_hash is available. Would you mind elaborating on the (reverse engineered?) details? There are already a couple of formats, so ideally those can be reused. If not, then hopefully t

Re: [Wireshark-dev] Gaining access to ff_pa_action_codes_ext from other protocols

2020-06-04 Thread Peter Wu
On Wed, Jun 03, 2020 at 11:17:01AM -0700, Richard Sharpe wrote: > Hi folks, > > Some protocols define status values etc in terms of 802.11. > > I am trying to get the latest changes for IEEE1905 into Wireshark and > have an issue where one or more dissector functions needs access to >

Re: [Wireshark-dev] Bugzilla and Gerrit timezone settings

2020-05-22 Thread Peter Wu
tps://bugs.wireshark.org/bugzilla/userprefs.cgi -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wiresh

Re: [Wireshark-dev] asn2wrs.py no longer seems to generate the same code ...

2020-05-15 Thread Peter Wu
r build cd build cmake -GNinja .. ninja generate_dissector-pkcs1 Kind regards, Peter https://lekensteyn.nl (pardon my brevity, top-posting and formatting, sent from my phone) On May 15, 2020 11:29:26 PM GMT+02:00, Richard Sharpe wrote: >On Fri, May 15, 2020 at 2:30 PM Peter Wu

Re: [Wireshark-dev] asn2wrs.py no longer seems to generate the same code ...

2020-05-15 Thread Peter Wu
Hi Richard, On Fri, May 08, 2020 at 08:54:58AM -0700, Richard Sharpe wrote: [..] > It doesn't look like it was manually modified. The last person who > touched that file was Peter Wu, it seems, so maybe he can shed some > light on it. How did you invoke asn2wrs.py? If I run the asn1 n

Re: [Wireshark-dev] Dissecting http2 traffic

2020-05-15 Thread Peter Wu
On Fri, May 15, 2020 at 06:50:18AM +, Anders Broman via Wireshark-dev wrote: > Hi, > > I think there is a demand to dissect http2 traffic where all packets in a > session is not captured. This is currently not possible. > > As the http2 protocol creates dynamic data for

Re: [Wireshark-dev] [Wireshark-users] Proposed changes to make tcp.ack and tcp.seq relative

2020-05-07 Thread Peter Wu
On Tue, May 05, 2020 at 08:59:45AM -0400, Lee wrote: > On 5/4/20, Peter Wu wrote: > > Hi all, > > > > A request was filed earlier to add a new "tcp.ack_rel" field to ensure > > that color filters can be created that always work on the relative > > se

Re: [Wireshark-dev] Trying to decode a TLS 1.3 with null cipher

2020-05-07 Thread Peter Wu
hould not be an argument for choosing one over the other. Kind regards, Peter > Regards, > Ahmed > > On Mon, May 4, 2020 at 4:38 PM Peter Wu wrote: > > > Hi Ahmed, > > > > On Mon, May 04, 2020 at 03:12:50PM -0700, Ahmed Elsherbiny wrote: > > >

Re: [Wireshark-dev] Proposed changes to make tcp.ack and tcp.seq relative

2020-05-07 Thread Peter Wu
s reported as suspected retransmission. Technically that is true, but it could be misleading the analyst into believing that packet loss has occurred. What do you think? -- Kind regards, Peter Wu https://lekensteyn.nl ___

Re: [Wireshark-dev] Proposed changes to make tcp.ack and tcp.seq relative

2020-05-04 Thread Peter Wu
> here, > I guess). And I hadn't even noticed the new way of displaying > the relative sequence numbers in 3.2 yet :-) Cool, thanks for your reply, I was already hoping for your feedback! If there are no further objections I'll submit a patch for this. On a related note, to address one

Re: [Wireshark-dev] Trying to decode a TLS 1.3 with null cipher

2020-05-04 Thread Peter Wu
f the draft: https://github.com/wolfSSL/wolfssl/issues/2945 Is your implementation actually going to be used in production? What are the reasons behind choosing this draft proposal for TLS 1.3 null ciphers if I may ask? -- Kind regards, Peter Wu htt

[Wireshark-dev] Proposed changes to make tcp.ack and tcp.seq relative

2020-05-04 Thread Peter Wu
disabled. This field was added in Wireshark 3.2. - Document these changes clearly in the release notes and corresponding user guides if needed. Are there any objections to this change? -- Kind regards, Peter Wu https://lekensteyn.nl _

Re: [Wireshark-dev] Trying to decode a TLS 1.3 with null cipher

2020-05-02 Thread Peter Wu
more answers, this patch will not be merged. Kind regards, Peter On Sat, May 02, 2020 at 10:55:07AM -0700, Ahmed Elsherbiny wrote: > Wow this is great news, thank you Peter! > > Regards, > Ahmed > > On Sat, May 2, 2020 at 10:21 AM Peter Wu wrote: > > > Hi Ahmed, &

Re: [Wireshark-dev] Trying to decode a TLS 1.3 with null cipher

2020-05-02 Thread Peter Wu
ges are needed to ensure that existing TLS 1.3 ciphers do not break while adding support for this new cipher. I've created a test samples for the two ciphers and posted these at https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16543 I hope to have a p

Re: [Wireshark-dev] Support for TLS1.2 decryption using derived keys

2020-05-01 Thread Peter Wu
change, Change Cipher Spec, Encrypted Handshake Message Change Cipher Spec, Encrypted Handshake Message Example info column for the case where decryption succeeds: Client Key Exchange, Change Cipher Spec, Finished Change Cipher Spec, Finished Hope it helps! -- Kind regards, Peter Wu

Re: [Wireshark-dev] Support for TLS1.2 decryption using derived keys

2020-05-01 Thread Peter Wu
On Fri, May 01, 2020 at 02:39:28PM +0300, webpentest wrote: > Hello Peter, > On 01.05.2020 01:23, Peter Wu wrote: > > > >> 1. A generic way to export schannel key material in SSLKEYLOG-like > >> format using elevated privilege and lsass.exe debugging / memo

Re: [Wireshark-dev] Support for TLS1.2 decryption using derived keys

2020-04-30 Thread Peter Wu
e key block from https://tools.ietf.org/html/rfc5246#section-6.3 An advantage of this format is that you automatically get the MAC key for non-AEAD ciphers. Suggested label: "KEY_BLOCK". - Keep the four sep

Re: [Wireshark-dev] Support for TLS1.2 decryption using derived keys

2020-04-30 Thread Peter Wu
umber of hashtables required as well. For non-AEAD ciphers there is also a client/server MAC key for verifying the decryption result. In theory these could also be added to ensure full functionality. Not sure how important it is. -- Kind regards, Peter Wu https://lekensteyn.nl > Regards, &g

Re: [Wireshark-dev] Display Filter Folders - a question to vote

2020-04-21 Thread Peter Wu
Hi Roland, I vote for not limiting the characters within a group name and not using a separator. Instead use two separate fields. I outlined a potential approach that maintains backwards compatibility and has a better user experience for the editor:

Re: [Wireshark-dev] Cant update preferred emaill after logined by GitHub oauth2

2020-04-15 Thread Peter Wu
w/#/settings/contact > > but no any email sent to me. Can you try "Profile" as opposed to the "Contact Information" section? https://code.wireshark.org/review/#/settings/ -- Kind regards, Peter Wu https://lekensteyn.nl __

Re: [Wireshark-dev] Remote Developer Den

2020-04-15 Thread Peter Wu
(well, 499 of you at least) is > welcome to drop in at any time. Meeting > details can be found below or in the attached invitation. For Europeans: 10:00 AM Pacific is 17:00 UTC / 19:00 CEST. -- Kind regards, Peter Wu https://lekensteyn.nl ___

Re: [Wireshark-dev] HTTP2 headers not dissected

2020-04-15 Thread Peter Wu
ding > works. Can you file a bug with an example capture file for the first problematic case? -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wireshark-dev mailing list Archives:https://www.wire

Re: [Wireshark-dev] GitLab migration update

2020-04-05 Thread Peter Wu
igration/-/wikis/SaaS-or-Self-Managed%3F -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/

[Wireshark-dev] GSoC 2020 student application window is open

2020-03-21 Thread Peter Wu
Tomasz Moń and Peter Wu. You can reach out to us directly or post to the wireshark-dev mailing list. If you are not sure what to put in your proposal, see https://google.github.io/gsocguides/student/writing-a-proposal We will expect you to submit a patch through the code review system before

Re: [Wireshark-dev] Clarifications regarding building wireshark

2020-03-16 Thread Peter Wu
rate a trace to test TCP reassembly: https://git.lekensteyn.nl/peter/wireshark-notes/tree/crafted-pkt/make-tcp.py But at minimum you can use something like: from scapy.all import * pkt = IP()/TCP(sport=54321, dport=12345)/b'your payload here' wrpcap('test.pcap', pkt) -- Kind regards,

Re: [Wireshark-dev] bug 11723

2020-03-11 Thread Peter Wu
he RTP player passed through it. That could also explain the 11 -> 22 -> 33 -> ... Packets bug. And yes, it is an open bug, feel free to investigate it and submit a patch for it. :-) [1]: https://gitlab.com/wireshark/wireshark/-/blob/master/doc/README.tapping -- Kind regards, Peter

Re: [Wireshark-dev] Distributing Linux binaries

2020-03-09 Thread Peter Wu
ev/+archive/ubuntu/stable As long as Debian unstable is updated, it should automatically find its way to Kali Linux. The same packaging recipe has to be manually copied to the PPA. -- Kind regards, Peter Wu https://lekensteyn.nl _

Re: [Wireshark-dev] [GSOC 2020] - Álvaro Berdote - "SSH Decryption Support"

2020-03-01 Thread Peter Wu
? -- Kind regards, Peter Wu https://lekensteyn.nl On Sat, Feb 29, 2020 at 01:31:08PM +0100, Marc Marc wrote: > Good morning to everyone, my name is *Álvaro** Berdote **Jiménez*, I am > from Madrid (Spain) and I would like to introduce myself in this Community. > > > > I am a Co

Re: [Wireshark-dev] Regarding GSoC 2020 - User interface accessibility improvements Project

2020-03-01 Thread Peter Wu
e aware of accessibility issues? Further in the stage, I would recommend reading https://google.github.io/gsocguides/student/writing-a-proposal -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wireshark-dev mailing

Re: [Wireshark-dev] Regarding GSoC 2020

2020-02-26 Thread Peter Wu
d to your private mail. About the SSH decryption project, and writing a good proposal, see also my reply here: https://www.wireshark.org/lists/wireshark-dev/202002/msg00044.html -- Kind regards, Peter Wu https://lekensteyn.nl ___

Re: [Wireshark-dev] Regarding GSoC 2020 - SSH Decryption Support Project

2020-02-26 Thread Peter Wu
ng that process, you can potentially learn a lot about the build environment, the code structure, and working with other developers. Do not worry if you get stuck, we are here to help. Feel free to reach out if you have more questions! -- Kind regards, Peter Wu https:

Re: [Wireshark-dev] Best linux platform for development; Buildbot slave configs

2020-02-22 Thread Peter Wu
ration based on the buildbot config back then can be found here: https://github.com/Lekensteyn/wireshark-ansible -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wireshark-dev mailing list Archives:https://www.wiresha

Re: [Wireshark-dev] Feedback on Developer's Guide 3.3.0

2020-02-22 Thread Peter Wu
ave some documentation generated from the source tree by Doxygen. It was a bit challenging to find it, it does not appear to be linked from the website or source tree. Anyway, here it is: https://www.wireshark.org/docs/wsar_html/modules.html -- Kind regards, Peter Wu https://lekensteyn.nl

[Wireshark-dev] Wireshark in Google Summer of Code (GSoC) 2020

2020-01-30 Thread Peter Wu
Right now Tomasz Moń and me (Peter Wu) are volunteering to mentor. If you are a core developer and have time to mentor a project, raise a hand and suggest a project :-) I plan to submit an application next week, probably on the evening of Tuesday February 4th (UTC). -- Kind regards, Peter Wu https

Re: [Wireshark-dev] LUA on freebsd

2020-01-30 Thread Peter Wu
ang/lua52/ a lua-5.2 pkg-config file is installed and headers are available under include/lua52, so it should work. There is more docs here, not sure if it helps? https://www.freebsd.org/doc/en/books/porters-handbook/using-lua.html -- Kind regards, Peter Wu https://leke

Re: [Wireshark-dev] packet-hislip & tls

2020-01-30 Thread Peter Wu
Hi, On Thu, Jan 30, 2020 at 05:56:27AM +0100, Jaap Keuter wrote: > Hi Guido, > > I’m not sure we have another protocol which supports switching back to > plain text after going TLS. Therefore I’m not sure if there is > intrinsic support for it. > My first instinct would be to setup a new

Re: [Wireshark-dev] Qt availability changes

2020-01-27 Thread Peter Wu
On Mon, Jan 27, 2020 at 09:53:11PM +0100, Roland Knall wrote: > Well it took me a while to read through all the comments. Indeed, some highlights: * A Qt community contributor suggests potential adverse effects for the Qt Company such as forking and less contributions.

Re: [Wireshark-dev] Support Opus in WireShark

2020-01-20 Thread Peter Wu
re. Somewhat related is this bug for improved WebRTC support where Opus is quite common, but encrypted in DTLS-SRTP: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13193 -- Kind regards, Peter Wu https://lekensteyn.nl ___

Re: [Wireshark-dev] Brotli decompression

2020-01-03 Thread Peter Wu
Hi Jasper, Do you still have an issue? If so, can you check whether TCP reassembly is enabled? Kind regards, Peter On Thu, Dec 19, 2019 at 01:51:14PM +0100, Jasper Bongertz wrote: > Hi Anders, > > you're right, it shows it's included... that means I have a different problem, > but good to

Re: [Wireshark-dev] LUA chained dissector drops data parameter

2019-12-03 Thread Peter Wu
The 'private_table' API is not very well specified in terms of lifetime and scope, and only accepts strings at the moment. I am not sure if we want to make it a fixed part of the public API. Kind regards, Peter > /Mikael > > ____ > Från: Wireshark-dev för P

Re: [Wireshark-dev] LUA chained dissector drops data parameter

2019-11-25 Thread Peter Wu
31 - Add Lua support for arbitrary data parameter in dissector calls. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15931 (+cc Huang) Discussion about another mechanism to pass data between dissectors: https://code.wireshark.org/review/35159 Discussion about another (abandoned) new mechanism to pass data betwe

Re: [Wireshark-dev] TCP Reassembly seems not to be working for me

2019-11-05 Thread Peter Wu
> Does anyone have any hints? Does your get_pdu_len function return the length including the minimum header size? Are there any out-of-order TCP segments? You should always receive the length indicated by get_pdu_len unless there is a bug. -- Kind

Re: [Wireshark-dev] Quickly determine where your duplicate ett_definition is ...

2019-11-05 Thread Peter Wu
ure it out, but life would have been > easier if the error message told me. Use of a debugger seems an appropriate approach since you can easily obtain a backtrace from it, and print the address of the ett item to learn which dissector registered the ett.

Re: [Wireshark-dev] Migrate to GitLab?

2019-10-12 Thread Peter Wu
On Sat, Oct 12, 2019 at 12:33:48PM +0100, João Valverde wrote: > > On 12/10/19 11:48, Roland Knall wrote: > > tl;dr - I am also -2 on merge commits, not entirely sure about ff > > either, they tend to be work, cherry-pick would be preferable. > > > > Long version: > > > > Currently we do have a

Re: [Wireshark-dev] payload_proto_id in SCPT dissector

2019-08-17 Thread Peter Wu
On Fri, Aug 16, 2019 at 10:09:43AM +0100, João Valverde wrote: > > > On 15/08/19 23:48, Peter Wu wrote: > > The problem was introduced with v3.1.1rc0-144-gede7be3440 ("TLS: allow > > dissectors to set the appdata protocol via the data param"). Since that > >

Re: [Wireshark-dev] payload_proto_id in SCPT dissector

2019-08-15 Thread Peter Wu
The problem was introduced with v3.1.1rc0-144-gede7be3440 ("TLS: allow dissectors to set the appdata protocol via the data param"). Since that commit, the "data" parameter of TCP is interpreted as a string. The problem is that the SCTP dissector can also call the TLS dissector with a non-NULL

Re: [Wireshark-dev] ssl decryption in a dissector

2019-07-31 Thread Peter Wu
de As. > > > > So this means that both should work right? No, you must use register_dissector as create_dissector_handle fails to set the name. -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wiresh

Re: [Wireshark-dev] ssl decryption in a dissector

2019-07-30 Thread Peter Wu
ssector_add_string("tls.alpn", "coap", coap_handle); [1]: https://www.iana.org/assignments/tls-extensiontype-values/tls-extensiontype-values.xhtml#alpn-protocol-ids As for why create_dissector_handle did not work, it does not add a name. register_dissector

Re: [Wireshark-dev] GQUIC dissector

2019-07-02 Thread Peter Wu
o and the Google QUICHE implementation (not to be confused with quiche from Cloudflare): https://github.com/Lekensteyn/chromium-quic https://quiche.googlesource.com/quiche -- Kind regards, Peter Wu https://lekensteyn.nl

Re: [Wireshark-dev] Certificate Request not being displayed by Wireshark even when that info is in the packet

2019-06-29 Thread Peter Wu
07:04:04PM -0500, Jaime Hablutzel wrote: > Hi Peter, I'm sorry for the delay. > > I've just found the "Certificate Request" in a subsequent "TCP > Out-Of-Order" packet (see https://filebin.ca/4kArOrO9xTaL). > > Thank you. > > On Mon, Jun 3, 2019 at 9:

Re: [Wireshark-dev] Ubuntu 16.04 Debian build fails missing symbols - crypto_scalarmult_curve25519@Base 2.9.0

2019-06-29 Thread Peter Wu
slight preference for not adding dummy versions, but if you think it is better to have it, it could be done anyway? -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wireshark-dev mailing list Archives:

Re: [Wireshark-dev] Building Wireshark 2.6.2 with Lua gives me an error ...

2019-06-08 Thread Peter Wu
script: https://git.archlinux.org/svntogit/packages.git/tree/trunk/liblua.so.patch?h=packages/lua52 https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/lua52 However if you are using Fedora, install the compat-lua and compat-lua-devel scripts. See also tools/rpm-setup.sh or

Re: [Wireshark-dev] Certificate Request not being displayed by Wireshark even when that info is in the packet

2019-06-03 Thread Peter Wu
of 3577 (0xdf9) bytes and fits a handshake message (Certificate Request) of 3569 (0xdf1) bytes. If TCP reassembly is enabled, it should have been reconstructed in the next TCP segment. -- Kind regards, Peter Wu https://lekensteyn.nl ___

Re: [Wireshark-dev] DNS over HTTPS Dissector / Traces

2019-05-23 Thread Peter Wu
Hi Nalini, I have worked on it before, Wireshark implements dissection of DNS messages in a HTTP POST request and in HTTP responses. HTTP GET requests where the DNS message is embedded in a GET parameter is not yet supported. For details and capture samples, see

Re: [Wireshark-dev] Should Qt SimpleDialog messages be posted to event queue?

2019-05-08 Thread Peter Wu
On Wed, May 01, 2019 at 12:23:16PM +0200, Tomasz Moń wrote: > Hello, > > While investigating the "extcap terminates without connecting to > pipes" issue [1], I have noticed that the "interrupt-like" behavior is > induced by the simple_dialog() call. The simple_dialog() calls exec() > on

Re: [Wireshark-dev] Extending time before 2nd analysis pass

2019-04-27 Thread Peter Wu
rs when a packet record is processed in epan/epan.c. Delaying the second pass implies hiding packets from the GUI. In theory it could be done, but it will probably not be easy. And you are trading off latency for accuracy. Perhaps the reassembly routines could be improved to handle this mixed 1-p

Re: [Wireshark-dev] Bug 15709: Segfault on MacOS; help wanted

2019-04-24 Thread Peter Wu
if you have not already, build with cmake -DENABLE_ASAN=1. I suspect that it might blow up with a use-after-free warning before the NULL pointer dereference. -- Kind regards, Peter Wu https://lekensteyn.nl ___ Se

Re: [Wireshark-dev] [Wireshark-users] termshark: a terminal UI for tshark

2019-04-23 Thread Peter Wu
(+cc wireshark-dev since some may find this interesting.) Hi Graham, This looks neat, I have added it to the wiki: https://wiki.wireshark.org/Tools Are you aware of sharkd? For interactive use it might be a more suitable backend than tshark. sharkd is part of Wireshark and was developed by

Re: [Wireshark-dev] Not seeing FOO Dissector in wireshark after successful build

2019-04-22 Thread Peter Wu
0.0.6 dissector /tmp/wsbuild/run/plugins/3.1/epan/irda.so mate.so 1.0.1 dissector /tmp/wsbuild/run/plugins/3.1/epan/mate.so ... To avoid sudo, fix the capabilities on dumpcap, see https://wiki.wireshark.org/Development/Tips#Running_dumpcap_on_

Re: [Wireshark-dev] Script extcap on macOS

2019-04-18 Thread Peter Wu
program directory is the name resolution test, that test writes the 'hosts' file to the program directory which is unfortunate if you want to run tests as a different user than the one who built it. -- Kind regards, Peter Wu https://lekensteyn.nl

Re: [Wireshark-dev] Dissector for a custom protocol which starts as HTTP

2019-04-17 Thread Peter Wu
Does your protocol use an Upgrade header? If so, you can register with the http.upgrade dissector table. Search also for "upgrade" in https://github.com/wireshark/wireshark/blob/master/epan/dissectors/packet-http.c Once control is handed to http, I don't think you can change it. Protocols like

Re: [Wireshark-dev] Option to get a Windows installer from a Petri dish build?

2019-04-15 Thread Peter Wu
For time time being you can create an AppVeyor account and push to GitHub. Pushing to any branch except for master will create an Installer in the artifacts tab. Example: https://ci.appveyor.com/project/Lekensteyn/wireshark Kind regards, Peter https://lekensteyn.nl (pardon my brevity,

Re: [Wireshark-dev] Cannot find krb5.h

2019-02-11 Thread Peter Wu
Hi, Since today, the master-3.0 and master branches should no longer have this issue due to this patch: https://code.wireshark.org/review/31960 When CMake is run, it should now automatically clear outdated library and include paths and locate the updated versions. This will be faster than

Re: [Wireshark-dev] Wireshark on Kali linux

2019-02-06 Thread Peter Wu
k. Finally, note that "started_with_special_privs()" also returns TRUE even if the current user has no more privileges. Even if the Wireshark or tshark executables were setuid root, these root privileges have already been dropped via "relinquish_special_privs_perm()", lo

Re: [Wireshark-dev] Lua error while running Wireshark as root (was: Re: Wireshark on Kali linux)

2019-02-06 Thread Peter Wu
On Tue, Feb 05, 2019 at 03:47:47PM -0800, Guy Harris wrote: > > On Feb 5, 2019, at 2:38 PM, Peter Wu wrote: > > > On Tue, Feb 05, 2019 at 02:25:58PM -0800, Guy Harris wrote: > >> On Feb 5, 2019, at 2:07 PM, Peter Wu wrote: > >> > >>> The last op

Re: [Wireshark-dev] Lua error while running Wireshark as root (was: Re: Wireshark on Kali linux)

2019-02-05 Thread Peter Wu
On Tue, Feb 05, 2019 at 02:25:58PM -0800, Guy Harris wrote: > On Feb 5, 2019, at 2:07 PM, Peter Wu wrote: > > > The last option would permit *users* to invoke arbitrary commands as > > root if they run Wireshark with sudo or as root user. I think that might > > not

[Wireshark-dev] Lua error while running Wireshark as root (was: Re: Wireshark on Kali linux)

2019-02-05 Thread Peter Wu
pts via the "-Xlua_script" option. Those who would like to limit Lua support when running as root could change this variable anyway. -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wireshark-dev m

Re: [Wireshark-dev] master: link fails on Ubuntu 14.04

2019-01-31 Thread Peter Wu
available. As for installing GnuTLS 3.2, have you tried: sudo apt-get install libgnutls28-dev You might have to remove CMakeCache.txt (specifically the values related to GNUTLS) in order to find the new version. -- Kind regards, Peter Wu https://leke

Re: [Wireshark-dev] master: link fails on Ubuntu 14.04

2019-01-31 Thread Peter Wu
sion is missing, this should fix the build issue without GnuTLS: https://code.wireshark.org/review/31837 -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.

Re: [Wireshark-dev] Memory leak debugging - current master passes all tests!

2019-01-30 Thread Peter Wu
place for it here: https://wiki.wireshark.org/Development/Tips#Debugging_using_AddressSanitizer https://wiki.wireshark.org/Development/Tips#Running_dumpcap_on_Linux_as_unprivileged_user Feel free to make more edits as needed :) -- Kind regards, Peter Wu https://lekensteyn.nl ___

[Wireshark-dev] Memory leak debugging - current master passes all tests!

2019-01-28 Thread Peter Wu
ers/wiki/AddressSanitizerFlags -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman

Re: [Wireshark-dev] dfilter functions

2019-01-07 Thread Peter Wu
The online manual reflects 2.6.5, but the manual was updated in master, https://code.wireshark.org/review/27146 Perhaps size should be removed (as argued in that commit message)? Kind regards, Peter On Sun, Jan 06, 2019 at 02:20:22PM +, Michael Mann via Wireshark-dev wrote: > len - Checks

Re: [Wireshark-dev] USB documentation missing setup steps for Linux

2018-12-22 Thread Peter Wu
EADME.Debian;hb=HEAD These instructions might not apply to all distros. Fedora for example seems to require one to add themselves to the "usbmon" group instead of "wireshark". I have updated the page, feel free to edit it if you feel it needs more cla

Re: [Wireshark-dev] Lua minimum version

2018-12-19 Thread Peter Wu
fix is already incomplete.) -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://ww

Re: [Wireshark-dev] Unit tests for dissectors

2018-12-19 Thread Peter Wu
mework was proposed before, but that has not gained much traction so far: https://github.com/wireshark/happy-shark -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wireshark-dev mailing list Archives:https://

Re: [Wireshark-dev] Builds without PCAP fail the unit tests

2018-12-19 Thread Peter Wu
b.py:38: This doesn't work yet in Wireshark Note that Dario (crondaemon) periodically sync with Github and thereby triggers regular travis builds. This made it easy to quickly identify the commit that broke the tests: https://travis-ci.org/crondaemon/wireshark/builds/467781922 -- Kind regards, Peter W

Re: [Wireshark-dev] 2.9.0 and 3.0.0 release schedule

2018-12-12 Thread Peter Wu
his done. Would it be possible to push this after the holidays instead (next year)? -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-

[Wireshark-dev] Changing the JSON library and making it required

2018-11-14 Thread Peter Wu
a transition? -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/

Re: [Wireshark-dev] GDB / Fuzz test ?

2018-11-12 Thread Peter Wu
On Mon, Nov 12, 2018 at 11:26:54AM +0100, Peter Wu wrote: > On Mon, Nov 12, 2018 at 10:27:32AM +0100, Dario Lombardo wrote: > > > 1. I'm not familiar with GDB and could not set a breakpoint in my > > > functions. Is there a trick to it? How do you run it? > > > >

Re: [Wireshark-dev] GDB / Fuzz test ?

2018-11-12 Thread Peter Wu
SAN_OPTIONS is a colon-separated list of options, more can be shown with the option ASAN_OPTIONS=help=1. abort_on_error=1 is optional, but recommended if you run with GDB since you can examine the call stack on errors (e.g. using the "bt" command for a stack trace). -- Kind regards,

Re: [Wireshark-dev] Wireshark seems to require Python 3.4 or better now ...

2018-11-10 Thread Peter Wu
pment, see https://www.wireshark.org/lists/wireshark-dev/201810/msg00067.html -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-

Re: [Wireshark-dev] Wireshark seems to require Python 3.4 or better now ...

2018-11-10 Thread Peter Wu
activate >cmake3 /path/to/wireshark/source > > seems to work. Like Pascal said, clearing PYTHON_EXECUTABLE from your CMakeCache.txt was sufficient (you do not have to wipe the full build directory). The default /usr/bin/python interpreter is Python 2.7, but CMake will now search f

Re: [Wireshark-dev] Anyone working on a Syncthing dissector?

2018-11-08 Thread Peter Wu
Hi Antoine! Based on the specifications for Syncthing, it appears that it uses Protobuf for defining its messages: https://docs.syncthing.net/specs/ I am not sure how well protobuf is currently supported on Wireshark, you could scan the issue tracker and code review site to see if there is any

Re: [Wireshark-dev] Why are ett[] arrays static?

2018-10-19 Thread Peter Wu
) as the array itself remains unmodified. -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wir

Re: [Wireshark-dev] New linker warnings compiling Wireshark on Windows

2018-10-17 Thread Peter Wu
und I can think of is to filter out the /INCREMENTAL and /INCREMENTAL:YES flags from _. -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wires

[Wireshark-dev] Dropping support for Python 2, requiring Python 3

2018-10-15 Thread Peter Wu
on converting the whole suite to using it. One possible issue is that older Linux distributions might not have a recent enough pytest version, effectively requiring them to install a newer one via pip or not running tests. -- Kind regards, Peter Wu https://lekensteyn.nl

Re: [Wireshark-dev] Expired Certificates - Apple Dev - Wireshark

2018-10-13 Thread Peter Wu
ug.cgi?id=15200 -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wir

Re: [Wireshark-dev] Broken links to visual studio

2018-10-13 Thread Peter Wu
Hi Basil, On Wed, Oct 10, 2018 at 11:04:51AM +0100, basil tungekar wrote: > There are broken links in the dev guide to Visual studio. In particular the > VS 2010 links VS 2010 is no longer supported, VS 2015 or newer is recommended. In meantime the WSDG has been updated. -- Kind regards,

Re: [Wireshark-dev] Does lua provide something like range strings?

2018-10-10 Thread Peter Wu
On Tue, Oct 09, 2018 at 11:38:29AM -0700, Richard Sharpe wrote: > On Tue, Oct 9, 2018 at 7:14 AM Peter Wu wrote: > > > > Hi Richard, > > > > On Mon, Oct 08, 2018 at 10:59:35AM -0700, Richard Sharpe wrote: > > > I am wondering if the Lua interp in Wireshark pr

Re: [Wireshark-dev] Does lua provide something like range strings?

2018-10-09 Thread Peter Wu
{ 0, 24, "First quarter" }, { 25, 54, "Second quarter" }, }; -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.o

Re: [Wireshark-dev] Do Lua dissectors work with tshark?

2018-10-09 Thread Peter Wu
On Tue, Oct 09, 2018 at 05:19:47AM -0700, Richard Sharpe wrote: > Hi folks, > > If I write a Lua dissector does it also work with tshark? Yes it does. In fact, an easy way (without copying files into your profile) is: tshark -Xlua_script:your.lua -r some.pcap -- Kind regards,

Re: [Wireshark-dev] [pcap-ng-format] Proposal for storing decryption secrets in a pcapng block

2018-10-06 Thread Peter Wu
On Thu, Oct 04, 2018 at 03:12:19PM -0700, Ben Higgins wrote: > On Sun, Sep 30, 2018 at 10:47 AM Peter Wu wrote: > > > Hi all, > > > > Earlier this year, Ben Higgins proposed a new pcapng block to store > > SSL/TLS session secrets that would allow users to enable d

Re: [Wireshark-dev] tools/check[hf|APIs|filtername].pl need updating?

2018-09-26 Thread Peter Wu
tools/checkhf.pl still needs an update. Its current logic only matches "g?int hf_ = -1;" (find_remove_hf_defs) and then looks for missing entries in the hf array (using find_remove_hf_array_entries). To make it work for the new API, some code must be added to: 1. Detect the

  1   2   3   4   >