Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo
Looks like I made it. https://github.com/crondaemon/wireshark/runs/490547471?check_suite_focus=true The artifact can be found in the upper right area of the screen. On Fri, Mar 6, 2020 at 3:29 PM Dario Lombardo wrote: > > > On Fri, Mar 6, 2020 at 3:21 PM João Valverde < >

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo
On Fri, Mar 6, 2020 at 3:21 PM João Valverde < joao.valve...@tecnico.ulisboa.pt> wrote: > If you want to spare some CPU cycles I believe only the user_guide_chm > target is mandatory for NSIS. > > Seems you are missing some dependencies too, asciidoctor and maybe others > as well. > > Yes to

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread João Valverde
On 06/03/20 13:55, Dario Lombardo wrote: Si it seems like it is not running the MSVC 2019 command prompt that takes care of setting the various environment variables. Well... this is a point. I added the proper action and it made it a bit further.

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo
> > Si it seems like it is not running the MSVC 2019 command prompt that takes > care of setting the various environment variables. > Well... this is a point. I added the proper action and it made it a bit further. https://github.com/crondaemon/wireshark/runs/490228280?check_suite_focus=true

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Pascal Quantin
Le ven. 6 mars 2020 à 14:02, Dario Lombardo a écrit : > > > On Fri, Mar 6, 2020 at 12:44 PM Pascal Quantin > wrote: > >> >> >> Le ven. 6 mars 2020 à 12:28, Dario Lombardo a écrit : >> >>> I am sorry, I still don't understand, I beg your pardon. >>> You said >>> >>> > your machine does not have

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Graham Bloice
For the WiX installer merge module, IIRC CMake will print the "not found" path if WiX isn't installed. That's been on my cleanup list for some time. On Fri, 6 Mar 2020 at 06:44, Pascal Quantin wrote: > > > Le ven. 6 mars 2020 à 12:28, Dario Lombardo a écrit : > >> I am sorry, I still don't

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo
On Fri, Mar 6, 2020 at 12:44 PM Pascal Quantin wrote: > > > Le ven. 6 mars 2020 à 12:28, Dario Lombardo a écrit : > >> I am sorry, I still don't understand, I beg your pardon. >> You said >> >> > your machine does not have the MSVC redistributable copied in the >> wireshark-libs folder (as

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Pascal Quantin
Le ven. 6 mars 2020 à 12:28, Dario Lombardo a écrit : > I am sorry, I still don't understand, I beg your pardon. > You said > > > your machine does not have the MSVC redistributable copied in the > wireshark-libs folder (as explained in the developer guide) while it is > required for the NSIS

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo
I am sorry, I still don't understand, I beg your pardon. You said > your machine does not have the MSVC redistributable copied in the wireshark-libs folder (as explained in the developer guide) while it is required for the NSIS installer. But I cannot find any point in the developer guide where

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Pascal Quantin
Hi Dario, Le ven. 6 mars 2020 à 12:16, Dario Lombardo a écrit : > Hi Pascal > I'm not sure I got the point. I try to explain what I understand. I have > one single build, that may have multiple problems, some trivial, some not. > The error I see in cmake could be ignored, while the one that

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo
Hi Pascal I'm not sure I got the point. I try to explain what I understand. I have one single build, that may have multiple problems, some trivial, some not. The error I see in cmake could be ignored, while the one that counts is the fact I need the MSVC redistributable in the wireshark-lib

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Pascal Quantin
Hi Dario, Le ven. 6 mars 2020 à 11:30, Dario Lombardo a écrit : > No, it's the same. Have a look at the cmake section and you will see the > error messages below. > Joao is correct: on one side you have a non fatal error in CMake that only impacts the WiX installer, and in the other side your

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo
No, it's the same. Have a look at the cmake section and you will see the error messages below. On Fri, Mar 6, 2020 at 10:54 AM João Valverde < joao.valve...@tecnico.ulisboa.pt> wrote: > > > On 06/03/20 08:23, Dario Lombardo wrote: > > Example of failing build > > >

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread João Valverde
On 06/03/20 08:23, Dario Lombardo wrote: Example of failing build https://github.com/crondaemon/wireshark/runs/489648430?check_suite_focus=true A quick look suggests this is a different build than you indicated before, for an NSIS package, and the problem seems to be that the VC_REDIST

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread João Valverde
Maybe this helps? https://github.com/actions/virtual-environments/issues/195 On 06/03/20 08:07, Dario Lombardo wrote: Are you saying "set v"? It doesn't print anything. The installation of VS is pre-made by the github builder itself, not by me, hence I don't have any control over the

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo
Example of failing build https://github.com/crondaemon/wireshark/runs/489648430?check_suite_focus=true On Fri, Mar 6, 2020 at 9:07 AM Dario Lombardo wrote: > Are you saying "set v"? It doesn't print anything. > The installation of VS is pre-made by the github builder itself, not by > me, hence

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo
Are you saying "set v"? It doesn't print anything. The installation of VS is pre-made by the github builder itself, not by me, hence I don't have any control over the installation options. However I guess every component is in place, and maybe I just need to add the proper dir to the PATH. What do

Re: [Wireshark-dev] Cmake on windows

2020-03-05 Thread Gerald Combs
On 3/5/20 2:36 PM, João Valverde wrote: > > > On 05/03/20 15:27, Dario Lombardo wrote: >> Hi, >> I'm getting this output from a windows build >> >> -- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND >> -- Using MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm for the WiX >> installer >> --

Re: [Wireshark-dev] Cmake on windows

2020-03-05 Thread João Valverde
On 05/03/20 15:27, Dario Lombardo wrote: Hi, I'm getting this output from a windows build -- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND -- Using MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm for the WiX installer -- Configuring done -- Generating done -- Build files have been written

Re: [Wireshark-dev] Cmake on windows

2020-03-05 Thread Gerald Combs
On 3/5/20 7:27 AM, Dario Lombardo wrote: > Hi, > I'm getting this output from a windows build > > -- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND > -- Using MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm for the WiX > installer > -- Configuring done > -- Generating done > -- Build files have

[Wireshark-dev] Cmake on windows

2020-03-05 Thread Dario Lombardo
Hi, I'm getting this output from a windows build -- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND -- Using MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm for the WiX installer -- Configuring done -- Generating done -- Build files have been written to: D:/a/wireshark/wireshark/build What's

Re: [Wireshark-dev] CMake on Windows - Can build, but not run executable

2015-03-26 Thread Graham Bloice
I seem to remember earlier issues with other folks using VS2012 and wanting a 64 bit build, due to qt support problems. VS2013 CE is available for free, you might want to consider that. As for CMake build instructions did you look at README.cmake in the top level sources? When we get CMake

Re: [Wireshark-dev] CMake on Windows - Can build, but not run executable

2015-03-26 Thread Roland Knall
Hi The 32bit is not working either. I am not trying to upgrade my Qt version (although I really can't figure out what the issue should be here for tshark and wireshark-gtk, and if this is not working, I'll try your debug scenario. VS2013 is unfortunately not allowed in our company, not even the

[Wireshark-dev] CMake on Windows - Can build, but not run executable

2015-03-25 Thread Roland Knall
Hi I can build wireshark successfully (gtk and qt interfaces) on Windows, but If I want to execute it, he complains that the side-by-side configuration is not correct. If I trace the launch with sxstrace, he complains, that the ProcessorArchitecture is wrong for the target (amd64). The build is

Re: [Wireshark-dev] CMake on Windows - Can build, but not run executable

2015-03-25 Thread Graham Bloice
On 25 March 2015 at 08:17, Roland Knall rkn...@gmail.com wrote: Hi I can build wireshark successfully (gtk and qt interfaces) on Windows, but If I want to execute it, he complains that the side-by-side configuration is not correct. If I trace the launch with sxstrace, he complains, that

Re: [Wireshark-dev] CMake for Windows

2013-06-26 Thread Roland Knall
Hi As I am somewhat converse in cmake, I can give you a few pointers, if you like. In general for each package a cmake system should look for, a FindPackageName.cmake file should exist in either one of two places: - The local directory (in wireshark underneath src/cmake/modules/Find - Or

Re: [Wireshark-dev] CMake for Windows

2013-06-26 Thread Graham Bloice
On 26 June 2013 10:10, Roland Knall rkn...@gmail.com wrote: Hi As I am somewhat converse in cmake, I can give you a few pointers, if you like. In general for each package a cmake system should look for, a FindPackageName.cmake file should exist in either one of two places: - The local

Re: [Wireshark-dev] CMake for Windows

2013-06-26 Thread Roland Knall
Hi GLOB and GLOB_RECURSE should normally only catch files, not directories. (As noted on http://www.cmake.org/cmake/help/v2.8.11/cmake.html#command:file) You should look for ares.h. From the returned path you could deduct the directory path with STRING. Alternativly you could look on google for

Re: [Wireshark-dev] CMake for Windows

2013-06-26 Thread Graham Bloice
On 26 June 2013 11:07, Roland Knall rkn...@gmail.com wrote: Hi GLOB and GLOB_RECURSE should normally only catch files, not directories. (As noted on http://www.cmake.org/cmake/help/v2.8.11/cmake.html#command:file) Several references found on Google imply that it did return directories as

Re: [Wireshark-dev] CMake for Windows

2013-06-26 Thread Graham Bloice
On 26 June 2013 11:29, Graham Bloice graham.blo...@trihedral.com wrote: On 26 June 2013 11:07, Roland Knall rkn...@gmail.com wrote: Hi GLOB and GLOB_RECURSE should normally only catch files, not directories. (As noted on http://www.cmake.org/cmake/help/v2.8.11/cmake.html#command:file)

Re: [Wireshark-dev] CMake for Windows

2013-06-25 Thread Joerg Mayer
Hello Graham, On Thu, Jun 20, 2013 at 04:55:01PM -0700, Graham Bloice wrote: As the starter for some planned major improvements|changes to the win32 build, I'd like to get CMake working for building Wireshark on Windows. I know what I'm doing with the nmake builds, and have once built

[Wireshark-dev] CMake for Windows

2013-06-20 Thread Graham Bloice
As the starter for some planned major improvements|changes to the win32 build, I'd like to get CMake working for building Wireshark on Windows. I know what I'm doing with the nmake builds, and have once built successfully on Ubuntu with CMake, but that's about it for my CMake knowledge, so I'm