Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-11 Thread Sultan, Hassan via Wireshark-dev
> -Original Message- > From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf > Of Pascal Quantin > Sent: Thursday, August 10, 2017 2:19 AM > To: Developer support list for Wireshark > Cc: Sake Blok > Subject: Re: [Wireshark-dev] Hierarchy of f

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-10 Thread Pascal Quantin
Le 10 août 2017 10:56, "Stig Bjørlykke" a écrit : On Wed, Aug 9, 2017 at 7:05 PM, Pascal Quantin wrote: > What about marking it as PROTO_ITEM_SET_GENERATED() as a first step? Tis > value is inferred from the tvb length and not a real field. It's not a generated field (the bytes are fetched dire

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-10 Thread Stig Bjørlykke
On Wed, Aug 9, 2017 at 7:05 PM, Pascal Quantin wrote: > What about marking it as PROTO_ITEM_SET_GENERATED() as a first step? Tis > value is inferred from the tvb length and not a real field. It's not a generated field (the bytes are fetched directly from the packet without any modifications) so t

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-09 Thread Pascal Quantin
Le 10 août 2017 00:03, "Alexis La Goutte" a écrit : On Wed, Aug 9, 2017 at 7:05 PM, Pascal Quantin wrote: > Hi Stig (and Sake), > > 2017-08-02 22:24 GMT+02:00 Stig Bjørlykke : > >> On Wed, Aug 2, 2017 at 10:03 PM, Sultan, Hassan via Wireshark-dev >> wrote: >> > Regarding tcp.payload, I don't

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-09 Thread Alexis La Goutte
On Wed, Aug 9, 2017 at 7:05 PM, Pascal Quantin wrote: > Hi Stig (and Sake), > > 2017-08-02 22:24 GMT+02:00 Stig Bjørlykke : > >> On Wed, Aug 2, 2017 at 10:03 PM, Sultan, Hassan via Wireshark-dev >> wrote: >> > Regarding tcp.payload, I don't think tcp.payload in itself has any >> problems. I thin

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-09 Thread Pascal Quantin
Hi Stig (and Sake), 2017-08-02 22:24 GMT+02:00 Stig Bjørlykke : > On Wed, Aug 2, 2017 at 10:03 PM, Sultan, Hassan via Wireshark-dev > wrote: > > Regarding tcp.payload, I don't think tcp.payload in itself has any > problems. I think the issue lies in tcp showing a length of 32 only, even > though

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-08 Thread Sultan, Hassan via Wireshark-dev
shark.org > <mailto:wireshark-dev-boun...@wireshark.org> ] On Behalf Of Sultan, Hassan > via Wireshark-dev > Sent: Wednesday, August 02, 2017 2:09 PM > To: Developer support list for Wireshark <mailto:wireshark-dev@wireshark.org> > > > Cc: Sultan, Hassan <

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-08 Thread Alexis La Goutte
half Of Sultan, Hassan via Wireshark-dev > Sent: Wednesday, August 02, 2017 2:09 PM > To: Developer support list for Wireshark > Cc: Sultan, Hassan > Subject: Re: [Wireshark-dev] Hierarchy of fields & offsets again, more > potential offenders > > So if this needs to be fix

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-07 Thread Sultan, Hassan via Wireshark-dev
Of Sultan, Hassan via Wireshark-dev Sent: Wednesday, August 02, 2017 2:09 PM To: Developer support list for Wireshark Cc: Sultan, Hassan Subject: Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders So if this needs to be fixed, but we can't change the tcp p

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-03 Thread Sultan, Hassan via Wireshark-dev
> -Original Message- > From: Pascal Quantin [mailto:pascal.quan...@gmail.com] > Sent: Wednesday, August 02, 2017 12:41 PM > To: Developer support list for Wireshark > Cc: Sultan, Hassan > Subject: Re: [Wireshark-dev] Hierarchy of fields & offsets again, more &

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-02 Thread Sultan, Hassan via Wireshark-dev
y, but I'm not sure what the options are here. > -Original Message- > From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf > Of Stig Bjørlykke > Sent: Wednesday, August 02, 2017 1:24 PM > To: Developer support list for Wireshark > Subject: Re: [W

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-02 Thread Stig Bjørlykke
On Wed, Aug 2, 2017 at 10:03 PM, Sultan, Hassan via Wireshark-dev wrote: > Regarding tcp.payload, I don't think tcp.payload in itself has any problems. > I think the issue lies in tcp showing a length of 32 only, even though it has > tcp.payload as its child. The tcp.payload field was recently

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-02 Thread Pascal Quantin
12:41 PM > > To: Developer support list for Wireshark > > Cc: Sultan, Hassan > > Subject: Re: [Wireshark-dev] Hierarchy of fields & offsets again, more > potential > > offenders > > > > > > > > 2017-08-02 21:24 GMT+02:00 Pascal Quantin > <mai

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-02 Thread Sultan, Hassan via Wireshark-dev
nt: Wednesday, August 02, 2017 12:41 PM > To: Developer support list for Wireshark > Cc: Sultan, Hassan > Subject: Re: [Wireshark-dev] Hierarchy of fields & offsets again, more > potential > offenders > > > > 2017-08-02 21:24 GMT+02:00 Pascal Quantin <m

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-02 Thread Pascal Quantin
2017-08-02 21:24 GMT+02:00 Pascal Quantin : > Hi Hassan, > > 2017-08-02 1:05 GMT+02:00 Sultan, Hassan via Wireshark-dev < > wireshark-dev@wireshark.org>: > >> Hi all, >> >> So I've started adding checks to my wrapper and am finding some >> interesting cases (they all look like issues that need to

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-02 Thread Pascal Quantin
Hi Hassan, 2017-08-02 1:05 GMT+02:00 Sultan, Hassan via Wireshark-dev < wireshark-dev@wireshark.org>: > Hi all, > > So I've started adding checks to my wrapper and am finding some > interesting cases (they all look like issues that need to be fixed to me, > but again, I might be missing something

[Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-01 Thread Sultan, Hassan via Wireshark-dev
Hi all, So I've started adding checks to my wrapper and am finding some interesting cases (they all look like issues that need to be fixed to me, but again, I might be missing something), would someone please take a look and tell me which you think are ok / bugs so I can start sending patches t