Re: [Wireshark-dev] Extcap

2015-10-19 Thread Dario Lombardo
On Mon, Oct 19, 2015 at 4:03 PM, Michal Labedzki wrote: > Try to do: > $ export WIRESHARK_RUN_FROM_BUILD_DIRECTORY=1 > $ ./run/wireshark > > Yes, it's what I usually do. > Check also your config.h (build directory): grep EXTCAP config.h > > I have something like

Re: [Wireshark-dev] CMake: Disable building with QT ?

2015-11-14 Thread Dario Lombardo
Harris <g...@alum.mit.edu> wrote: > > On Nov 13, 2015, at 12:26 AM, Dario Lombardo <dario.lombardo...@gmail.com> > wrote: > > > A useful feature of cmake that works at least on ubuntu is the tab > completion. So you can run > > > > cmake -DBUILD > &g

[Wireshark-dev] size_t vs int

2015-09-04 Thread Dario Lombardo
Hi list I'm playing with afl and clang and I've found some points in the code where afl/clang complains, and I'd like to discuss how to change them with you. A warning message got is ../codecs/sbc/sbc.c:111:16: warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long')

Re: [Wireshark-dev] Add support for remote capture in linux

2015-10-02 Thread Dario Lombardo
h > interfaces can be configured with a separate options dialog and are quite > versatile, and most of all, it does not need you to change dumpcap in a way > that it is still working across multiple systems. > > regards, > Roland > > On Fri, Oct 2, 2015 at 12:35 PM, Dario Lomba

Re: [Wireshark-dev] Add support for remote capture in linux

2015-10-02 Thread Dario Lombardo
satile, and most of all, it does not need you to change dumpcap in a way >> that it is still working across multiple systems. >> >> regards, >> Roland >> >> On Fri, Oct 2, 2015 at 12:35 PM, Dario Lombardo < >> dario.lombardo...@gmail.com> wrote:

Re: [Wireshark-dev] Add support for remote capture in linux

2015-10-02 Thread Dario Lombardo
remote capture without using additional software and without opening additional ports if 22 is already open. On Fri, Oct 2, 2015 at 1:32 PM, Dario Lombardo <dario.lombardo...@gmail.com> wrote: > Do you mean to reimplement rpcapd on linux? > > On Fri, Oct 2, 2015 at 1:26 PM

Re: [Wireshark-dev] Compiling a plugin

2015-09-23 Thread Dario Lombardo
Hi Martin Did you take a look at this ? https://ask.wireshark.org/questions/42914/build-a-plugin-on-linux It should answer to your question. Dario. On Wed, Sep 23, 2015 at 3:52 PM, Juan Jose Martin Carrascosa wrote: > Hi all, > > I am looking for documentation regarding how

Re: [Wireshark-dev] Setting up git for gerrit

2015-11-30 Thread Dario Lombardo
On Mon, Nov 30, 2015 at 12:11 PM, Graham Bloice wrote: > Unfortunately I've never run git over http(s), so have no advice to > offer. I suggest you continue without the luxury of git-review for the > moment. > > A quick hack for pushing to gerrit without git-review

Re: [Wireshark-dev] wiretap - using as a library rather than coupled with Wireshark?

2015-11-26 Thread Dario Lombardo
On Thu, Nov 26, 2015 at 9:41 AM, Guy Harris wrote: > > It can't be, and probably will never be able to be, built independently of > the "Wireshark utilities" library, the source to which is in the wsutil > directory. > Provided that this is not a published lib, that has an

Re: [Wireshark-dev] wiretap - using as a library rather than coupled with Wireshark?

2015-11-27 Thread Dario Lombardo
-automated. This couldn't apply to a released software, whose requiremets include wiretap, but could apply to scenarios of task-oriented softwares (I mean not general purpose ones). On Thu, Nov 26, 2015 at 7:54 PM, Guy Harris <g...@alum.mit.edu> wrote: > > On Nov 26, 2015, at 1:18 AM, Da

Re: [Wireshark-dev] Release process: Transifex Sync

2015-11-19 Thread Dario Lombardo
> > > I agree with you. There is need to sync with Transifex as one of > latest step of releasing. > I was conviced that Alexis put the sync in place. Doesn't it work? https://www.wireshark.org/lists/wireshark-dev/201502/msg00162.html

Re: [Wireshark-dev] Review of Gerrit patch for RTPS

2015-11-19 Thread Dario Lombardo
I think that attaching some samples would help a lot. On Wed, Nov 18, 2015 at 7:21 PM, Juan Jose Martin Carrascosa wrote: > I assumed that you were busy. Thanks for the answer. > > Is there anything I can help with? I may be able to spend some hours this > weekend. > > Thanks,

Re: [Wireshark-dev] Buildbots

2015-11-20 Thread Dario Lombardo
On Thu, Nov 19, 2015 at 5:59 PM, Graham Bloice wrote: > There's also the: > > 2.0 buildbot - https://buildbot.wireshark.org/wireshark-2.0/waterfall > 1.12 buildbot - https://buildbot.wireshark.org/wireshark-1.12/waterfall > Debian LTS buildbot - >

[Wireshark-dev] Extcap DLTs

2015-11-24 Thread Dario Lombardo
I'm working on a new extcap that will leverage randpkt-core to give wireshark a local random packet generator through randpktdump (the new extcap). I'm stucking with the DLTs part. The extcap must answer to the external call about which DLTs it can generate. Randpkt-core can generate 5 different

Re: [Wireshark-dev] Extcap DLTs

2015-11-24 Thread Dario Lombardo
On Tue, Nov 24, 2015 at 2:03 PM, Roland Knall wrote: > > Which bug are you referring to? > > Sorry... https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11733 ___ Sent via:Wireshark-dev mailing list

Re: [Wireshark-dev] Extcap DLTs

2015-11-24 Thread Dario Lombardo
set more generic options via a gui hook-up (using the plugin_if > functionality). But you could also use a more generic preference in > Wireshark itself and read from there. > > regards, > Roland > > > On Tue, Nov 24, 2015 at 12:29 PM, Dario Lombardo < > dario.lombardo

Re: [Wireshark-dev] Extcap DLTs

2015-11-24 Thread Dario Lombardo
On Tue, Nov 24, 2015 at 2:00 PM, Dario Lombardo <dario.lombardo...@gmail.com > wrote: > > > I don't like it very much... Having too many interfaces is not likeable. > Expecially when related to this bug > > https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11733 &g

[Wireshark-dev] Buildbots

2015-11-19 Thread Dario Lombardo
I've found 2 different buildbot projects for wireshark https://buildbot.wireshark.org/petri-dish/ and https://buildbot.wireshark.org/wireshark-master/ Can anyone explain me the difference? I've understood that petri-dish is manually triggered by core-devs from gerrit. Who triggers the

Re: [Wireshark-dev] Windows dev, gerrit, git-review, etc.

2016-05-26 Thread Dario Lombardo
Hi Gordon Did you take a look at this? https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html On Thu, May 26, 2016 at 2:50 AM, Gordon Ross wrote: > I'm an experienced unix developer, familiar with git, but I'm having > trouble getting all the git+gerrit

[Wireshark-dev] Buildslaves

2016-01-15 Thread Dario Lombardo
The petri-dish buildslaves seem to be down https://buildbot.wireshark.org/petri-dish/buildslaves is there some maintenance in place? ___ Sent via:Wireshark-dev mailing list Archives:

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

2016-06-27 Thread Dario Lombardo
On Mon, Jun 27, 2016 at 3:16 AM, Jim Young wrote: > > Time for a Petri Dish for OS X? > > Jim Y. > Giant +1 for this. ___ Sent via:Wireshark-dev mailing list Archives:

[Wireshark-dev] Console output from dissectors

2016-06-29 Thread Dario Lombardo
Hello Running checkAPI against the dissectors, I get warnings like Warning: Found termoutput APIs in packet-wtp.c: printf Are the dissector expected to produce console output? If yes, which function should they use? g_log()? Thanks Dario.

[Wireshark-dev] Portable sockets

2016-02-10 Thread Dario Lombardo
Hello everybody I'm working on a new extcap that listens on a port for incoming packets produced by capture devices. I have to create a small, standard udp server. I was wandering which functions I am supposed to use to be portable. Are POSIX sockets ok on Windows (I suppose they're fine on OSX)?

Re: [Wireshark-dev] Missing protocols and wishlist

2016-03-10 Thread Dario Lombardo
On Thu, Mar 10, 2016 at 2:08 PM, Alexis La Goutte wrote: > You can search on bugtracker all bug with "Enhancement" > > Thanks. Is there a way to filter all the tickets and get only the enhancements?

[Wireshark-dev] Missing protocols and wishlist

2016-03-10 Thread Dario Lombardo
Hello list Is there a list of currently missing protocols in wireshark or some kind of wishlist? As far as I recall there is a wiki page but I can't find it. Thanks Dario. ___ Sent via:Wireshark-dev mailing list

Re: [Wireshark-dev] Building with current GIT clone fails

2016-03-04 Thread Dario Lombardo
On Fri, Mar 4, 2016 at 1:59 PM, Graham Bloice wrote: > Currently they are green, although I'm getting a build error on Windows > about generation of the AUTHORS file. The binaries are all still good > though. > > There is an outstading issue I'm working on

Re: [Wireshark-dev] Building with current GIT clone fails

2016-03-04 Thread Dario Lombardo
Link to the change about AUTHORS re-generation. https://code.wireshark.org/review/#/c/14339/ On Fri, Mar 4, 2016 at 2:01 PM, Dario Lombardo <dario.lombardo...@gmail.com> wrote: > > > On Fri, Mar 4, 2016 at 1:59 PM, Graham Bloice <graham.blo...@trihedral.com > &g

[Wireshark-dev] Current master not compiling

2016-04-04 Thread Dario Lombardo
Today I'm not able to compile the current master 6f98a0fac33db70b3ceb71d939b0a9d0d47747cc. Using git bisect I've found that the culprit seems to be this commit commit 59816ef00c6dd09532d80b393ba03f8194aba236 Author: Guy Harris Date: Wed Mar 30 18:44:01 2016 -0700 Make

Re: [Wireshark-dev] Current master not compiling

2016-04-04 Thread Dario Lombardo
On Mon, Apr 4, 2016 at 12:24 PM, Guy Harris <g...@alum.mit.edu> wrote: > On Apr 4, 2016, at 1:51 AM, Dario Lombardo <dario.lombardo...@gmail.com> > wrote: > > > But how did the buildbot let it pass? > > Because it has a newer version of Flex than you do? &g

Re: [Wireshark-dev] #ifdef mess

2016-03-29 Thread Dario Lombardo
On Tue, Mar 29, 2016 at 3:48 AM, Guy Harris wrote: > > which is a bit of a greasy hack - appending an empty string to str, just > so it's marked as used - but I suspect the extra CPU time spent doing that, > on platforms unlucky enough not to have zlib, will be lost in the

[Wireshark-dev] wmem in gtk

2016-05-02 Thread Dario Lombardo
Hi all In this change https://code.wireshark.org/review/#/c/15051/ I'm getting an error from ubuntu buildbot https://buildbot.wireshark.org/petri-dish/builders/Ubuntu%20x86-64%20Petri%20Dish/builds/6330/steps/compile/logs/stdio The error is addr_resolution_dlg.c:32:23: fatal error:

Re: [Wireshark-dev] wmem in gtk

2016-05-02 Thread Dario Lombardo
Oh sure, it was trivial! Any idea on why it compiles on my ubuntu? I can't find any conditional compilation. On Mon, May 2, 2016 at 2:58 PM, Pascal Quantin <pascal.quan...@gmail.com> wrote: > Hi Dario, > > 2016-05-02 14:56 GMT+02:00 Dario Lombardo <dario.lombardo...@gmail

Re: [Wireshark-dev] Connection slow and got interrupted when cloning the Wireshark repo

2016-04-19 Thread Dario Lombardo
Hi Yang You can clone from github, then add whatever git remote you want. But you don't need to do that, since the command to push a change to gerrit can be issued to point directly to wireshark repo. As stated here https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcContribute.html you can push

Re: [Wireshark-dev] Connection slow and got interrupted when cloning the Wireshark repo

2016-04-19 Thread Dario Lombardo
enied (publickey). > fatal: Could not read from remote repository. > > Please make sure you have the correct access rights > and the repository exists. > > > On Tue, Apr 19, 2016 at 6:35 PM, Dario Lombardo < > dario.lombardo...@gmail.com> wrote: > >> Hi Yang >

Re: [Wireshark-dev] Connection slow and got interrupted when cloning the Wireshark repo

2016-04-19 Thread Dario Lombardo
On Tue, Apr 19, 2016 at 1:44 PM, Yang Luo wrote: > > I found I can push using https, but the reminds me it lacks change-id. > > I'm not sure I got your point, but you can get rid of all change-id issues using the tools/pre-commit hook. Read here

Re: [Wireshark-dev] extcap.c does not build on SUSE 11.3. g_spawn_check_exit_status requires glib 2.34

2016-08-01 Thread Dario Lombardo
This call exists from glib 2.34. We should add this version as minimum requirement to build extcap. On Mon, Aug 1, 2016 at 10:34 AM, Anders Broman wrote: > Hi, > > I get > > extcap.c:842: undefined reference to `g_spawn_check_exit_status' on SUSe > 11.3 with top of

Re: [Wireshark-dev] Considering ignoring Coverity 'tainted' checks

2016-07-11 Thread Dario Lombardo
I can't answer for all the "tainted" checks on coverity, but the ones I'm patching seem reasonable. Quick example num = tvb_get_ntohl(...) for (i = 0; i < num; i++) { } Nothing is going to crash in wireshark, but if a tainted packet contains 0x, why should we loop with this value, until

Re: [Wireshark-dev] Windows compilation fails

2016-08-05 Thread Dario Lombardo
On Fri, Aug 5, 2016 at 4:19 PM, Graham Bloice <graham.blo...@trihedral.com> wrote: > On 5 August 2016 at 14:56, Dario Lombardo <dario.lombardo...@gmail.com> > wrote: > >> What Qt version? I think I've seen that one before. >>>> >>> >>>

[Wireshark-dev] Windows compilation fails

2016-08-05 Thread Dario Lombardo
I'm trying to compile wireshark on windows, but it fails. I have low skills on windows, so maybe I'm missing something very basic. Any hint? Thank you. "c:\Development\wsbuild64\Wireshark.sln" (default target) (1) ->

Re: [Wireshark-dev] Windows compilation fails

2016-08-05 Thread Dario Lombardo
an...@gmail.com> wrote: > > Le 5 août 2016 14:34, "Graham Bloice" <graham.blo...@trihedral.com> a > écrit : > > > > On 5 August 2016 at 13:29, Dario Lombardo <dario.lombardo...@gmail.com> > wrote: > >> > >> I'm trying to compi

Re: [Wireshark-dev] Windows compilation fails

2016-08-05 Thread Dario Lombardo
> > What Qt version? I think I've seen that one before. >> > > 5.3.2. ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe:

Re: [Wireshark-dev] Registering protocol details

2016-08-07 Thread Dario Lombardo
On Sun, Aug 7, 2016 at 1:10 PM, Paul Offord wrote: > Hi Anders, > > > > Thanks for the prompt reply. I’ve read through exported_pdu.h and I don’t > understand how this helps me. Is there somewhere I can read more about > using exported_pdu functions? > > > > Thanks

Re: [Wireshark-dev] Checking address in WMEM

2017-01-26 Thread Dario Lombardo
On Thu, Jan 26, 2017 at 3:41 PM, Jeff Morriss wrote: > > Or are you looking for a way to make the crash easier to debug? > > Yes. Basically I'd like the idea to give the user a very useful error message. The wmem is pretty hard to debug, since a wrong scope basically

Re: [Wireshark-dev] Checking address in WMEM

2017-01-26 Thread Dario Lombardo
On Thu, Jan 26, 2017 at 2:11 PM, Evan Huus wrote: > > Each block can consist of multiple chunks, so you need a second, inner > loop. You can do this with WMEM_CHUNK_NEXT. > > Do note, however, that: > - you'll be iterating over every piece of memory allocated in this > scope,

[Wireshark-dev] Checking address in WMEM

2017-01-25 Thread Dario Lombardo
I want to check if an address belongs to a wmem scope. Basically I want to do func(allocator, address) { ... wmem_realloc(allocator, address) ... } that fails if address doesn't belong to allocator scope. Any idea on how can I check if address belongs to it? Thanks. Dario.

Re: [Wireshark-dev] Checking address in WMEM

2017-01-26 Thread Dario Lombardo
On Wed, Jan 25, 2017 at 6:50 PM, Evan Huus wrote: > On my phone, but the short version is that there's no way to check this, > and no efficient way to build it. > > Evan > > Looking into the code it seems to me that the routine of free_all should traverse all the allocated

Re: [Wireshark-dev] Default enabled dissectors

2017-02-22 Thread Dario Lombardo
Hi Andy Do you mean others are not to be compiled or compiled but disabled? If the former, you have to patch the dissectors list (which file depends on your build subsystem, cmake or autotools) to disable the unwanted ones. If the latter, you can't AFAIK. If 2 dissectors clash, they can't be

Re: [Wireshark-dev] Default enabled dissectors

2017-02-22 Thread Dario Lombardo
If the don't clash, you can then customize the list of the disabled protos. In Linux it is in .config/wireshark/disabled_protos I don't know where it is on windows but it won't be hard to find out. You can ship your version with this custom file. On Wed, Feb 22, 2017 at 12:49 PM, Andy Ling

Re: [Wireshark-dev] Default enabled dissectors

2017-02-22 Thread Dario Lombardo
Actually there _is_ a global disabled_protos file. Have a look here https://www.wireshark.org/docs/wsug_html_chunked/ChAppFilesConfigurationSection.html Hope it helps. On Wed, Feb 22, 2017 at 1:59 PM, Dario Lombardo <dario.lombardo...@gmail.com > wrote: > At the moment I can't figur

Re: [Wireshark-dev] Default enabled dissectors

2017-02-22 Thread Dario Lombardo
At the moment I can't figure out how. Ideally a sistem-wide disabled_protos file would solve the issues. Any thoughts from the list about this feature? On Wed, Feb 22, 2017 at 1:49 PM, Andy Ling wrote: > If the don't clash, you can then customize the list of the disabled >

Re: [Wireshark-dev] Crash in epan/geoip_db.c

2017-02-22 Thread Dario Lombardo
On Tue, Feb 21, 2017 at 11:38 PM, João Valverde < joao.valve...@tecnico.ulisboa.pt> wrote: > > Fixes 850393b57bdd7011780f4cf897d4a2467f58a673. Please push to Gerrit. > Bonus points for fixing the cast too. > I pushed a patch that replaces g_free with free. Now the problem is that checkAPI

Re: [Wireshark-dev] Crash in epan/geoip_db.c

2017-02-22 Thread Dario Lombardo
On Wed, Feb 22, 2017 at 3:55 PM, Evan Huus wrote: > > checkAPI doesn't allow free because it also doesn't allow malloc; if the > malloced memory is coming from library internals somewhere, does the > library itself have a cleanup method we could call instead? > > Unfortunately

Re: [Wireshark-dev] Conditional compiles

2017-02-14 Thread Dario Lombardo
Agree. What was the original idea behind having pcap optional? I'm with Guy: is that important to have a non-pcap version of wireshark? If someone is able to clarify a scenario for that, can they share that? On Tue, Feb 14, 2017 at 10:01 AM, Roland Knall wrote: > There is some

Re: [Wireshark-dev] Submitting a fix to 2.2.4

2017-02-10 Thread Dario Lombardo
If the bug was in branch master-2.2 only, what would be the correct way to push a fix in this branch only? On Fri, Feb 10, 2017 at 6:37 PM, Paul Offord wrote: > Hi Guy and Pascal, > > I'm 99% sure it's in the master branch as well but I'll check. If so, > I'll do as

Re: [Wireshark-dev] Conditional compiles

2017-02-14 Thread Dario Lombardo
On Tue, Feb 14, 2017 at 3:22 PM, Jeff Morriss wrote: > I remember getting (infrequent) questions/requests for building Wireshark > without the ability to capture. Usually the desire seems to come from > corporate IT policies which don't want people capturing corporate

Re: [Wireshark-dev] Packet sample repository/library?

2017-01-14 Thread Dario Lombardo
You have to issue a pull request against the upstream of happy-shark, using the button in github's website. We will start to review it as soon as you do that. Dario. On Sat, Jan 14, 2017 at 3:14 PM, Jirka Novak wrote: > Hello, > > did anyone reviewed my proposed changes

[Wireshark-dev] Extcap version

2017-02-27 Thread Dario Lombardo
Hi In extcap structs I've found 2 entries for "version". In typedef struct _extcap_interface { gchar * call; gchar * display; gchar * version; gchar * help; gchar * extcap_path; extcap_sentence_type if_type; } extcap_interface; and typedef struct _extcap_info {

Re: [Wireshark-dev] Extcap version

2017-02-27 Thread Dario Lombardo
ss I clean up a bit more. In the > meantime, when in doubt, extcap_info->version is the one read by the > overall system. > > regards > Roland > > On Mon, Feb 27, 2017 at 11:19 AM, Dario Lombardo < > dario.lombardo...@gmail.com> wrote: > >> Hi >> In extcap str

Re: [Wireshark-dev] Remove of GTK interface

2016-09-05 Thread Dario Lombardo
During the last Sharkfest, I heard from many users and power-users still some affection to GTK interface. It surprised me a bit, since when I switched to Qt, it was a matter of will. Resistance to change? Maybe. Something not to care about? Surely not. The switch-off of GTK will happen, but...

[Wireshark-dev] Compiling on Centos7

2016-09-01 Thread Dario Lombardo
I' trying to compile the current master on Centos7. Some of the code in caputils doesn't compile, so I patched it. Now the compilation stops with Linking C executable run/dumpcap /usr/bin/ld: run/libcaputils.a(ws80211_utils.c.o): undefined reference to symbol 'nl_socket_free' /usr/bin/ld: note:

Re: [Wireshark-dev] Compiling on Centos7

2016-09-01 Thread Dario Lombardo
... Which lib is cmake looking for? Libnl or libnl3? Anyway, without libnl3-devel compilation goes to the end. On Thu, Sep 1, 2016 at 11:01 AM, Dario Lombardo <dario.lombardo...@gmail.com > wrote: > I' trying to compile the current master on Centos7. Some of the code in > caputils doe

Re: [Wireshark-dev] ./configure failing on Ubuntu 14.04

2016-09-01 Thread Dario Lombardo
On Thu, Sep 1, 2016 at 1:42 PM, Guy Harris wrote: > > Would something for Red Hat/Fedora/Centos(?) be useful as well? > There is tools/install_rpms_for_devel.sh. I used it a bit but I think it needs improvement. To have the whole dev environment (almost all optional packages)

Re: [Wireshark-dev] ./configure failing on Ubuntu 14.04

2016-08-31 Thread Dario Lombardo
Hi Anders If I recall correctly it's something related to the thread "CMAKE and RPM". Can you check the archives and look if it's related to your problem? On Wed, Aug 31, 2016 at 3:05 PM, Anders Broman wrote: > Hi, > > I’m getting > > checking for Qt5Core - version

Re: [Wireshark-dev] Enable extcap by default or not

2016-09-09 Thread Dario Lombardo
Even if I am not strong on that, I'd vote for enable by default. I admin that some of them are specific (like ciscodump or androiddump), but I consider others like sshdump and randpktdump pretty general. Having them hidden by default would limit their use. New users will never notice this new

[Wireshark-dev] g_print & co on Windows

2016-09-13 Thread Dario Lombardo
Hi I'm debugging sshdump on windows and I found an unexpected behavior with glib logging functions. g_error: seems to work. A popup appears and program stops g_warning: nothing, with or without G_MESSAGES_DEBUG=all g_debug: same as above g_print: nothing printed I recall something about those

Re: [Wireshark-dev] g_print & co on Windows

2016-09-15 Thread Dario Lombardo
> > >> > I seem to remember that when starting Wireshark on Windows from the > command line that I had to redirect stdout and stderr to files to see the > output. > Good catch! It works for extcaps as well. ___ Sent via:

[Wireshark-dev] Exported PUD proto_name

2016-08-26 Thread Dario Lombardo
Hi, I'm looking into the code of exported_pdu.c and specifically into export_pdu_create_tags(). The first tag it creates is the tag with proto_name. The piece of code that I don't understand is /* Start by computing size of protocol name as a tag */ proto_str_len =

Re: [Wireshark-dev] Exported PUD proto_name

2016-08-26 Thread Dario Lombardo
Ok, we'll wait for some clarifications from Alexis. On Fri, Aug 26, 2016 at 10:25 AM, Pascal Quantin <pascal.quan...@gmail.com> wrote: > > > 2016-08-26 10:14 GMT+02:00 Dario Lombardo <dario.lombardo...@gmail.com>: > >> It seems that it prevents the d

Re: [Wireshark-dev] Exported PUD proto_name

2016-08-26 Thread Dario Lombardo
into "aruba_erm\x00\x00\x00" that is not matched by the dissectors table. Alexis, did I get the point? On Fri, Aug 26, 2016 at 10:05 AM, Pascal Quantin <pascal.quan...@gmail.com> wrote: > Hi Dario, > > 2016-08-26 10:02 GMT+02:00 Dario Lombardo <dario.lombardo...@gmail.c

Re: [Wireshark-dev] Exported PUD proto_name

2016-08-29 Thread Dario Lombardo
10:44 AM, Dario Lombardo < dario.lombardo...@gmail.com> wrote: > Ok, we'll wait for some clarifications from Alexis. > > ___ Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark

Re: [Wireshark-dev] Exported PUD proto_name

2016-08-29 Thread Dario Lombardo
On Mon, Aug 29, 2016 at 5:30 PM, Pascal Quantin <pascal.quan...@gmail.com> wrote: > Hi Dario, > > 2016-08-29 17:03 GMT+02:00 Dario Lombardo <dario.lombardo...@gmail.com>: > >> I tried again with udpdump using >> - http (4 bytes long), aligned ==> works corre

[Wireshark-dev] Identities on gerrit

2016-10-31 Thread Dario Lombardo
I tried to link 2 identities on gerrit (google and github) but I got "forbidden" from the gerrit server. Is that intentional? Shouldn't that be allowed without admin work? Dario. ___ Sent via:Wireshark-dev mailing list

Re: [Wireshark-dev] IP src/dst from Qt

2016-10-31 Thread Dario Lombardo
on. I do a similar > thing with a 3rd-party plugin of mine. > > regards > Roland > > On Mon, Oct 31, 2016 at 2:44 PM, Dario Lombardo < > dario.lombardo...@gmail.com> wrote: > >> Hi >> I'd like to read the ip src/dst of the current open file from the Qt UI. >

Re: [Wireshark-dev] IP src/dst from Qt

2016-10-31 Thread Dario Lombardo
On Mon, Oct 31, 2016 at 3:16 PM, Roland Knall wrote: > I would implement a listener for the tap interface of the ip dissector. > Which point in the code should I read for this? ___ Sent via:

Re: [Wireshark-dev] IP src/dst from Qt

2016-10-31 Thread Dario Lombardo
IP or not. The tap device of the IP dissector is called > "ip", just search for register_tap in the dissectors to find all > > regards, Roland > > On Mon, Oct 31, 2016 at 3:23 PM, Dario Lombardo < > dario.lombardo...@gmail.com> wrote: > >> >> >&

Re: [Wireshark-dev] New statistics panel for RTPS

2016-11-03 Thread Dario Lombardo
Take a look at b845e29 and 38d08e0. They're 2 examples of stats_tree for DNS and HPFEEDS that do exactly what Roland said. Use them as examples. On Thu, Nov 3, 2016 at 11:56 AM, Juan Jose Martin Carrascosa wrote: > Thanks Roland. Exactly what I needed. > > Also thanks for the

Re: [Wireshark-dev] New statistics panel for RTPS

2016-11-03 Thread Dario Lombardo
Sorry I meant 9bbc337 and 696fcdb. On Thu, Nov 3, 2016 at 12:54 PM, Dario Lombardo <dario.lombardo...@gmail.com > wrote: > Take a look at b845e29 and 38d08e0. They're 2 examples of stats_tree for > DNS and HPFEEDS that do exactly what Roland said. Use them as examples. > > O

[Wireshark-dev] RPCAP module for hydra

2016-10-13 Thread Dario Lombardo
I'd like to share with you that a new module has been added to thc-hydra, the password cracker. This is a module to crack a RPCAP access. I didn't have tested it so far, but it's on my todo list. Have fun! Dario. https://github.com/vanhauser-thc/thc-hydra/pull/165

Re: [Wireshark-dev] Redhat binaries

2016-12-16 Thread Dario Lombardo
Fedora ships wireshark in distribution repos. On my fedora 25, 'dnf info wireshark' gives me version 2.2.2. Is that what you need? On Thu, Dec 15, 2016 at 4:52 PM, wrote: > > > I can’t locate the binaries for the Redhat distribution of wireshark. I > tried getting it

Re: [Wireshark-dev] Lintian fails on PD

2017-01-03 Thread Dario Lombardo
to fix also build https://code.wireshark.org/ > review/#/q/status:open+project:wireshark+branch:master-2.0+topic:fix_ > checklicense_pd_master-2.0 > > Cheers > > On Tue, Dec 27, 2016 at 12:41 PM, Dario Lombardo < > dario.lombardo...@gmail.com> wrote: > >&

Re: [Wireshark-dev] Packet sample repository/library?

2017-01-05 Thread Dario Lombardo
Feel free to open a pull request against the main repo, so we can start the review process. On Wed, Jan 4, 2017 at 9:36 PM, Jirka Novak wrote: > Hello, > > > Collaborators are people with write access to the repo. You don't need > > it to fork/PR. The repo is forked in

Re: [Wireshark-dev] Packet sample repository/library?

2017-01-05 Thread Dario Lombardo
. If cloned through github button, you can create a PR against the upstream repo https://github.com/wireshark/happy-shark/compare/master...crondaemon:master Hope it helps. On Thu, Jan 5, 2017 at 11:04 AM, Dario Lombardo <dario.lombardo...@gmail.com > wrote: > Feel free to open a pull requ

Re: [Wireshark-dev] Remote Control Plugin - Can I submit to the Wireshark project

2017-01-07 Thread Dario Lombardo
Is the remote control protected in some way? If not, it would open a new set of exploitations in wireshark. With this feature unprotected, not only is an attacker able to send arbitrary data into the network, but they're also able to control wireshark as they were the user. I'm really concerned

Re: [Wireshark-dev] Packet sample repository/library?

2017-01-04 Thread Dario Lombardo
On Tue, Jan 3, 2017 at 11:14 PM, Jirka Novak wrote: > Hi Alexis, > > > You can "fork" the happy shark repo on Github and make a Pull Request > > (PR) and the code will be review directly on Github > > I can't. Probably I'm not collaborator on happy-shark repository. Can >

Re: [Wireshark-dev] RPM Build fails on SUSE 11.3

2016-12-19 Thread Dario Lombardo
Hi Anders I don't see any reference to extcap in packaging/rpm/SPECS/wireshark.spec.in to disable it. I guess you need to change something around line 265. On Mon, Dec 19, 2016 at 5:07 PM, Anders Broman wrote: > Hi, > > > > Even though configured with: > > /configure

Re: [Wireshark-dev] RPM Build fails on SUSE 11.3

2016-12-20 Thread Dario Lombardo
I'm pushing a change for that. On Mon, Dec 19, 2016 at 9:40 PM, Guy Harris wrote: > On Dec 19, 2016, at 12:38 PM, Guy Harris wrote: > > > On Dec 19, 2016, at 9:40 AM, Jeff Morriss > wrote: > > > >> BTW, it appears extcap

[Wireshark-dev] Lintian fails on PD

2016-12-27 Thread Dario Lombardo
Hi, I'm backporting this change to master-2.2 https://code.wireshark.org/review/#/c/19433/ but the ubuntu PD buildbot fails because of some lintian checks that seem not to be related to my change

Re: [Wireshark-dev] Lintian fails on PD

2016-12-27 Thread Dario Lombardo
why i search to disable some steps for some branch) > > Cheers > > On Tue, Dec 27, 2016 at 10:49 AM, Dario Lombardo < > dario.lombardo...@gmail.com> wrote: > >> Hi, >> I'm backporting this change to master-2.2 >> >> https://code.wireshark.org/review/#

[Wireshark-dev] Wireshark from PPA

2016-12-22 Thread Dario Lombardo
Hi Balint I have installed the latest version of wireshark (2.2.3) from ppa, that, if I'm not mistalen, is managed by you. I still get Wireshark 2.2.3 (Git Rev Unknown from unknown) while I thought I had fixed it. Can you give me the detailed procedure you follow to generate those packages, so I

Re: [Wireshark-dev] Wiki editing privileges

2016-12-20 Thread Dario Lombardo
Can I be added as well (crondaemon)? On Tue, Dec 20, 2016 at 9:09 AM, Alexis La Goutte wrote: > > > On Mon, Dec 19, 2016 at 10:54 PM, John Thacker > wrote: > >> Hi, >> >> I would like for my user account JohnThacker to become a memory of the

Re: [Wireshark-dev] Why does the extcap stuff take so long to start up?

2017-03-27 Thread Dario Lombardo
The problem is only when compiling with autotools. With cmake the bin extcap dir is clean and it doesn't affect startup time. Btw the check you added is wise and should be done anyway in case unwanted artifacts are there. The problem with extcaps is that androiddump is the only tool that

Re: [Wireshark-dev] attribution/copyright

2017-04-07 Thread Dario Lombardo
If I'm not mistaken, the authors list is generated by the commit log. On Fri, Apr 7, 2017 at 12:12 AM, Simon Barber wrote: > I'd like to add my name to the authors list - should I do this in the > commit where I add the feature? What files should I add myself to? > >

Re: [Wireshark-dev] Conditional compilation (debug)

2017-07-29 Thread Dario Lombardo
f it is a dev-build or release build > > cheers > Roland > > On Thu, Jul 27, 2017 at 10:11 PM, Dario Lombardo < > dario.lombardo...@gmail.com > <javascript:_e(%7B%7D,'cvml','dario.lombardo...@gmail.com');>> wrote: > >> I was thinking to something like CMAKE_B

Re: [Wireshark-dev] Setting to disable all expert info

2017-08-04 Thread Dario Lombardo
On Wed, Aug 2, 2017 at 10:21 PM, Guy Harris wrote: > > Let's wait until the generation of the expert info results in a measurably > significant CPU or memory use increase before we add a knob to turn it > off. There are probably other places to look at to reduce memory usage

Re: [Wireshark-dev] unable to caputre TCP packets

2017-07-24 Thread Dario Lombardo
Can you list the interfaces (dumpcap -D) ? On Mon, Jul 24, 2017 at 8:50 AM, Farhan Masood wrote: > Sir Am unable to capture TCP packets on my network . am not new to > wireshark i have used it for more than 2 years and first time am > experiencing this issue . > OS - Parrot

[Wireshark-dev] Conditional compilation (debug)

2017-07-27 Thread Dario Lombardo
Hi I'd like to add some code that appears only in development builds of wireshark. Is there some define that helps me understand if I am in such a case, both in autotools and cmake? Thanks. Dario. ___ Sent via:

Re: [Wireshark-dev] Conditional compilation (debug)

2017-07-27 Thread Dario Lombardo
<jeff.morriss...@gmail.com> wrote: > > > On Thu, Jul 27, 2017 at 12:34 PM, Dario Lombardo < > dario.lombardo...@gmail.com> wrote: > >> Hi >> I'd like to add some code that appears only in development builds of >> wireshark. Is there some define that

[Wireshark-dev] G729

2017-08-05 Thread Dario Lombardo
I've noticed that cmake shows me -- The following OPTIONAL packages have not been found: * BCG729 , G.729 decoder , < https://www.linphone.org/technical-corner/bcg729/overview> Support for G.729 codec in RTP player Does anyone know which package in ubuntu/debian contains it?

Re: [Wireshark-dev] Conditional compilation (debug)

2017-07-30 Thread Dario Lombardo
I mean preferences. On Saturday, July 29, 2017, Michael Mann via Wireshark-dev < wireshark-dev@wireshark.org> wrote: > Define "config". Do you mean preferences (which I thought we already > had)? Or build configuration? (or "other") > > > -Original

[Wireshark-dev] checkapi prefs

2017-08-08 Thread Dario Lombardo
I've got this error from checkAPI_epan target: prefs.c: error: found these preference variables used in more than one prefs_register_*_preference: guint *var, const char **var, , range_t **var I can't figure out what does it mean. Can anyone help?

<    1   2   3   4   5   >