/u/171647/Wireshark-Wireframes/1.%20Input%20v2.jpg
[2]
https://dl.dropbox.com/u/171647/Wireshark-Wireframes/4.%20Add%20Interface.jpg
On Sat, Dec 8, 2012 at 11:06 AM, Michael Tuexen
michael.tue...@lurchi.franken.de wrote:
On Dec 8, 2012, at 4:17 PM, Evan Huus wrote:
On Sat, Dec 8, 2012 at 10:02
On Sat, Dec 22, 2012 at 4:37 PM, Michael Tuexen
michael.tue...@lurchi.franken.de wrote:
On Dec 22, 2012, at 8:31 PM, Evan Huus wrote:
So I finally got back to this and played with some of the
platform-specific features as well as some of the features that have
landed in trunk since 1.8
On Fri, Dec 21, 2012 at 3:05 PM, Jeff Morriss jeff.morriss...@gmail.com wrote:
Evan Huus wrote:
On Fri, Dec 21, 2012 at 10:41 AM, Jeff Morriss
jeff.morriss...@gmail.com wrote:
Evan Huus wrote:
They've been on my to-do list for a while, as emem provides them.
However, I've never
They've been on my to-do list for a while, as emem provides them.
However, I've never personally used emem's canaries, and I've never
actually heard of or seen anyone else using them. Are they actually
useful anymore, or has Moore's law made valgrind the better tool in
all situations?
If we do
I have been getting a link error for dumpcap since this revision that
doesn't appear to be showing up in the buildbots.
Output as follows:
/usr/bin/ld.bfd.real: dumpcap-capture-pcap-util-unix.o: relocation
R_X86_64_32 against `.rodata.str1.8' can not be used when making a
shared object; recompile
they can be linked into dumpcap).
Evan Huus wrote:
I have been getting a link error for dumpcap since this revision that
doesn't appear to be showing up in the buildbots.
Output as follows:
/usr/bin/ld.bfd.real: dumpcap-capture-pcap-util-unix.o: relocation
R_X86_64_32 against `.rodata.str1.8
Hi John,
If you don't need the entire payload of every packet (for example, if
the signalling you care about is always within the first n bytes of
the header of a packet), then you can use the -s option to write only
the first n bytes of each packet to disk.
Otherwise, you've listed all of the
Presumably goto packet should be moved to -G so that -g is
consistent across all the tools.
On Tue, Dec 11, 2012 at 9:17 PM, Maynard, Chris
christopher.mayn...@gtech.com wrote:
-G for Wireshark?
- Chris
From: wireshark-commits-boun...@wireshark.org
On Sat, Dec 8, 2012 at 7:57 AM, Michael Tuexen
michael.tue...@lurchi.franken.de wrote:
On Dec 8, 2012, at 3:49 AM, Evan Huus wrote:
I have drawn and scanned three mock-up sketches (linked at the
bottom), one for each of the three tabs I proposed in my previous
email. Apologies in advance
On Sat, Dec 8, 2012 at 10:02 AM, Michael Tuexen
michael.tue...@lurchi.franken.de wrote:
On Dec 8, 2012, at 3:15 PM, Evan Huus wrote:
On Sat, Dec 8, 2012 at 7:57 AM, Michael Tuexen
michael.tue...@lurchi.franken.de wrote:
On Dec 8, 2012, at 3:49 AM, Evan Huus wrote:
I have drawn and scanned
On Fri, Dec 7, 2012 at 1:47 PM, Gerald Combs ger...@wireshark.org wrote:
For the Qt toolbar I created start and stop capture icons based on the
media player/recorder record (circle) and stop (square)
conventions[1][2]. Record makes more sense to me; we are recording
packets to disk after all.
On Fri, Dec 7, 2012 at 2:41 PM, Michael Tuexen
michael.tue...@lurchi.franken.de wrote:
On Dec 7, 2012, at 8:01 PM, Evan Huus wrote:
On Fri, Dec 7, 2012 at 1:47 PM, Gerald Combs ger...@wireshark.org wrote:
For the Qt toolbar I created start and stop capture icons based on the
media player
On Fri, Dec 7, 2012 at 3:46 PM, Michael Tuexen
michael.tue...@lurchi.franken.de wrote:
On Dec 7, 2012, at 9:06 PM, Evan Huus wrote:
On Fri, Dec 7, 2012 at 2:41 PM, Michael Tuexen
michael.tue...@lurchi.franken.de wrote:
On Dec 7, 2012, at 8:01 PM, Evan Huus wrote:
On Fri, Dec 7, 2012 at 1:47
condition checkboxes.
Cheers,
Evan
[1] https://dl.dropbox.com/u/171647/Wireshark-Wireframes/1.%20Input.jpg
[2] https://dl.dropbox.com/u/171647/Wireshark-Wireframes/2.%20Output.jpg
[3] https://dl.dropbox.com/u/171647/Wireshark-Wireframes/3.%20Options.jpg
On Fri, Dec 7, 2012 at 9:15 PM, Evan Huus
In cases like bug 8045 [1], it would have been handy for it to say in
the report somewhere which build-bot (version and OS) had found the
error... is that reasonably easy to do?
Thanks,
Evan
[1] https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8045
This sounds like something wmem could solve - if there is an intermediate
scope between ep and se in duration then it should be possible to create
another wmem scope for use here.
Is the needed scope for these addresses well defined?
On Sat, Dec 1, 2012 at 9:46 PM, morr...@wireshark.org wrote:
On Sat 01 Dec 2012 10:47:47 PM EST, Jeff Morriss wrote:
On 12/01/2012 10:23 PM, Evan Huus wrote:
This sounds like something wmem could solve - if there is an
intermediate scope between ep and se in duration then it should be
possible to create another wmem scope for use here.
Yeah, I thought
On Fri, Nov 30, 2012 at 12:17 PM, Jeff Morriss jeff.morriss...@gmail.comwrote:
Hi Gerald,
The fuzz-bot seems to be generating fuzz failures but they're not showing
up as bugs. For example the latest fuzz failure
http://buildbot.wireshark.org/**trunk/builders/Clang-Code-**
On Fri, Nov 30, 2012 at 1:19 PM, Austin Albright
chuckbubba...@hotmail.comwrote:
-- Alex --
It has only one library dependency, that isn't a fundamental part of
Wireshark... sort of... which is the wimax plugin library (wimax.so)
When I run ldd on the customPlugin.so on my development
On Fri, Nov 30, 2012 at 3:50 PM, Gerald Combs ger...@wireshark.org wrote:
On 11/30/12 12:01 PM, Bill Meier wrote:
Assuming that the conversion script mentioned in
https://bugzillaupdate.wordpress.com/2010/07/06/bugzilla-4-0-has-a-new-default-status-workflow/
will be run, it appears
On Fri, Nov 30, 2012 at 4:34 PM, Bill Meier wme...@newsguy.com wrote:
On 11/30/2012 4:08 PM, Evan Huus wrote:
Would UNCONFIRMED be less confusing than CONFIRMED?
I would think so. It's bothered me for a while that we didn't have a way
to distinguish between brand new, nobody has looked
On Fri, Nov 30, 2012 at 4:35 PM, Guy Harris g...@alum.mit.edu wrote:
On Nov 30, 2012, at 1:08 PM, Evan Huus eapa...@gmail.com wrote:
I would think so. It's bothered me for a while that we didn't have a way
to distinguish between brand new, nobody has looked at it yet bugs and
solution
On Mon, Nov 19, 2012 at 4:00 PM, morr...@wireshark.org wrote:
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=46087
User: morriss
Date: 2012/11/19 01:00 PM
Log:
I'm pretty confident the string length will fit in 32 bits; cast away the
possible loss of data warning on the
While wmem is still nowhere near complete (it doesn't have an mmap block
allocator, it doesn't have a red-black tree implementation), as of
revision 45989 it should be able to replace emem in many cases.
I've put some documentation in doc/README.wmem which should explain its
design and usage in
On Tue, Nov 6, 2012 at 12:47 PM, Alex Bennée kernel-hac...@bennee.comwrote:
On 6 November 2012 10:13, Alex Bennée kernel-hac...@bennee.com wrote:
On 5 November 2012 18:53, Guy Harris g...@alum.mit.edu wrote:
On Nov 5, 2012, at 4:14 AM, Alex Bennee kernel-hac...@bennee.com
wrote:
No, you
On Sun, Nov 4, 2012 at 3:34 AM, Jakub Zawadzki darkjames...@darkjames.plwrote:
On Sat, Nov 03, 2012 at 07:55:51PM -0400, Evan Huus wrote:
On Mon, Oct 8, 2012 at 7:12 AM, Jakub Zawadzki
darkjames...@darkjames.pl wrote:
+ if (cf-count frames_count framenum = cf-count) {
+/* XXX
On Sun, Oct 28, 2012 at 10:12 AM, Evan Huus eapa...@gmail.com wrote:
On Sat, Oct 27, 2012 at 3:09 PM, Evan Huus eapa...@gmail.com wrote:
On Sat, Oct 27, 2012 at 2:17 PM, Dirk Jagdmann d...@cubic.org wrote:
General thoughts from the list on whether or not this would be a good idea?
some
On Mon, Oct 29, 2012 at 5:56 PM, Jakub Zawadzki
darkjames...@darkjames.pl wrote:
Hi Evan,
On Sun, Oct 28, 2012 at 07:45:10PM -0400, Evan Huus wrote:
Tangentially, I haven't noticed if you've checked in a pinfo memory
scope yet or not. Is there anything else wmem needs to be able to do
On Sat, Oct 27, 2012 at 3:09 PM, Evan Huus eapa...@gmail.com wrote:
On Sat, Oct 27, 2012 at 2:17 PM, Dirk Jagdmann d...@cubic.org wrote:
General thoughts from the list on whether or not this would be a good idea?
some general comments on the whole wmem idea:
memory allocation is done almost
On Sun, Oct 28, 2012 at 7:26 PM, Jakub Zawadzki
darkjames...@darkjames.pl wrote:
On Sun, Oct 28, 2012 at 10:12:41AM -0400, Evan Huus wrote:
We might be able to fake the proper scoping using thread-local globals
if we wrap everything in functions that assert the state of a
dissection. Something
On Fri, Oct 26, 2012 at 12:14 PM, Sébastien Tandel
sebastien.tan...@gmail.com wrote:
On Fri, Oct 26, 2012 at 1:58 PM, Evan Huus eapa...@gmail.com wrote:
On Fri, Oct 26, 2012 at 11:40 AM, Graham Bloice
graham.blo...@trihedral.com wrote:
On 26 October 2012 14:44, Evan Huus eapa
On Wed, Oct 24, 2012 at 8:10 AM, Sébastien Tandel
sebastien.tan...@gmail.com wrote:
On Wed, Oct 24, 2012 at 1:10 AM, Guy Harris g...@alum.mit.edu wrote:
On Oct 18, 2012, at 6:01 PM, Evan Huus eapa...@gmail.com wrote:
I have linked a tarball [2] containing the following files
On Wed, Oct 24, 2012 at 8:08 AM, Pascal Quantin
pascal.quan...@gmail.com wrote:
Hi all,
wmem_glib_free_all() makes use of g_slist_free_full that was introduced in
GLIB 2.28 while our minimum requirement is GLIB 2.14.0. Could we manually
free list elements containing dynamically-allocated
On Tue, Oct 23, 2012 at 11:10 PM, Guy Harris g...@alum.mit.edu wrote:
On Oct 18, 2012, at 6:01 PM, Evan Huus eapa...@gmail.com wrote:
I have linked a tarball [2] containing the following files:
- wmem_allocator.h - the definition of the allocator interface
- wmem_allocator_glib.* - a simple
On Mon, Oct 22, 2012 at 12:21 PM, Anders Broman
anders.bro...@ericsson.com wrote:
-Original Message-
From: wireshark-dev-boun...@wireshark.org
[mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Jakub Zawadzki
Sent: den 22 oktober 2012 09:11
To: Developer support list for
On Mon, Oct 22, 2012 at 5:36 PM, Jakub Zawadzki
darkjames...@darkjames.pl wrote:
On Mon, Oct 22, 2012 at 12:43:49PM -0400, Evan Huus wrote:
Perhaps pinfo should have its own scope that is between ep and
se? This would be much easier given the changes suggested in [1].
[1] https
TL;DR - Jakub recently proposed a few changes to emem [1]. While I
think they are a very good idea, I believe that in the long term the
current emem design has too many fundamental limitations to make it
worth adapting for our future needs. I propose that it should be
gradually deprecated in
I recently wanted to find out when a specific point release was made
available, and I didn't have it installed to check the build time, so
I went to the release notes online [1], but that doesn't actually give
a date. I ended up having to dig through the wireshark-announce
archives to find out. It
On Sun, Oct 14, 2012 at 1:36 PM, Martin Kaiser li...@kaiser.cx wrote:
Hi,
doc/README.developer says
Don't initialize variables in their declaration with non-constant
values. Not all compilers support this. E.g. don't use
guint32 i = somearray[2];
...
In file.c, read_packet(), we do
Like the subject says, as of revision 45519 QtShark (meaning the
/ui/qt/ directory) produces no warnings at all under the latest stable
CppCheck.
Going forward I'll try to keep it that way :)
___
Sent via:Wireshark-dev
On Thu, Oct 11, 2012 at 4:41 PM, Jakub Zawadzki
darkjames...@darkjames.pl wrote:
Hi,
Right now ep_ memory is freed at the begining of epan_dissect_run(),
which means that pointers allocated by ep_ can be safety accessed only before
dissecting next packet.
When using GUI epan_dissect_run()
On Wed, Oct 10, 2012 at 7:13 AM, Martin Mathieson
martin.r.mathie...@googlemail.com wrote:
On Wed, Oct 10, 2012 at 5:19 AM, Jakub Zawadzki darkjames...@darkjames.pl
wrote:
On Tue, Oct 09, 2012 at 10:53:41PM -0400, Martin Mathieson wrote:
I am getting the same assertion, for every file that
On Wed, Oct 10, 2012 at 8:24 AM, darkja...@wireshark.org wrote:
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=45445
User: darkjames
Date: 2012/10/10 05:24 AM
Log:
Fix bug #7814
We need to pass original pointer and length to munmap().
Directory: /trunk/epan/
On Wed, Oct 10, 2012 at 8:32 AM, Evan Huus eapa...@gmail.com wrote:
On Wed, Oct 10, 2012 at 8:24 AM, darkja...@wireshark.org wrote:
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=45445
User: darkjames
Date: 2012/10/10 05:24 AM
Log:
Fix bug #7814
We need to pass
On Wed, Oct 10, 2012 at 8:53 AM, Jakub Zawadzki
darkjames...@darkjames.pl wrote:
On Wed, Oct 10, 2012 at 08:32:00AM -0400, Evan Huus wrote:
On Wed, Oct 10, 2012 at 8:24 AM, darkja...@wireshark.org wrote:
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=45445
User: darkjames
On Wed, Oct 10, 2012 at 9:50 AM, Jakub Zawadzki
darkjames...@darkjames.pl wrote:
On Wed, Oct 10, 2012 at 09:32:07AM -0400, Evan Huus wrote:
The fix is needed regardless of what else happens - even with the old
old allocator this was still a bug
(in the sl_ allocator, if not the ep_ one)
Nah
On Wed, Oct 10, 2012 at 10:51 AM, Martin Mathieson
martin.r.mathie...@googlemail.com wrote:
I have discovered one problem since the change, but it may have been a bug
all along.
In tcp_graph.c, it was referencing the tap (struct tcpheader) after the tap
had run. The struct is allocated in
On Wed, Oct 10, 2012 at 3:18 PM, Jakub Zawadzki
darkjames...@darkjames.pl wrote:
On Wed, Oct 10, 2012 at 12:19:42PM -0400, Evan Huus wrote:
At this point I want to just revert the whole recent set of emem
changes *and* the ref-counting. (...)
I don't have access to a commit-capable machine
Sent that last one too fast...
On Wed, Oct 10, 2012 at 3:19 PM, Evan Huus eapa...@gmail.com wrote:
On Wed, Oct 10, 2012 at 3:18 PM, Jakub Zawadzki
darkjames...@darkjames.pl wrote:
On Wed, Oct 10, 2012 at 12:19:42PM -0400, Evan Huus wrote:
At this point I want to just revert the whole recent
On Wed, Oct 10, 2012 at 5:32 PM, Maynard, Chris
christopher.mayn...@gtech.com wrote:
Hi Evan,
I finally got around to applying/testing your patch on Windows XP SP3 32-bit.
As expected, Wireshark continues to capture just fine.
The relevant code in gui_utils and tshark are very similar
According to bug #7775 [1], our current GTK bundle (2.24) has a fairly
severe memory leak on Windows XP. It doesn't seem to occur in 2.22, so
it may be worth reverting to that version for future 1.8 releases?
Thoughts?
Evan
[1] https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7775
This looks like it came from revision 45388. I'm not too familiar with
Solaris, but I didn't think I changed anything that would require
linker changes as well?
On Mon, Oct 8, 2012 at 11:36 AM, buildbot-no-re...@wireshark.org wrote:
The Buildbot has detected a new failure on builder
On Mon, Oct 8, 2012 at 2:37 PM, Pascal Quantin pascal.quan...@gmail.com wrote:
Hi Evan,
2012/10/8 bugzilla-dae...@wireshark.org
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5284
Evan Huus eapa...@gmail.com changed:
What|Removed |Added
On Mon, Oct 8, 2012 at 2:58 PM, bugzilla-dae...@wireshark.org wrote:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7775
--- Comment #10 from Anatoly aries@gmail.com 2012-10-08 14:58:26 EDT ---
I've tried r45395, nothin is changed except wireshark has crashed:)
But I got one more
On Mon, Oct 8, 2012 at 3:31 PM, Jakub Zawadzki
darkjames...@darkjames.pl wrote:
Hi Evan,
On Mon, Oct 08, 2012 at 03:06:29PM -0400, Evan Huus wrote:
On Mon, Oct 8, 2012 at 2:58 PM, bugzilla-dae...@wireshark.org wrote:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7775
--- Comment
On Mon, Oct 8, 2012 at 5:17 PM, Jakub Zawadzki
darkjames...@darkjames.pl wrote:
On Mon, Oct 08, 2012 at 04:29:15PM -0400, Evan Huus wrote:
On Mon, Oct 8, 2012 at 3:31 PM, Jakub Zawadzki
darkjames...@darkjames.pl wrote:
Hi Evan,
On Mon, Oct 08, 2012 at 03:06:29PM -0400, Evan Huus wrote
This was caused by my removing the qm files in revision 45351. I
believe the buildbot needs to be calling `lrelease QtShark.pro` to
generate them before it calls `qmake QtShark.pro`?
Evan
On Sat, Oct 6, 2012 at 4:52 PM, buildbot-no-re...@wireshark.org wrote:
The Buildbot has detected a new
On Thu, Oct 4, 2012 at 4:43 PM, Martin Kaiser li...@kaiser.cx wrote:
Hi,
should the order in which we include files make any difference?
#include epan/packet.h
#include epan/expert.h
- ok
#include epan/expert.h
#include epan/packet.h
- failure
expert.h needs packet_info.h, which is
On Sun, Sep 30, 2012 at 8:09 PM, Maynard, Chris
christopher.mayn...@gtech.com wrote:
Should similar changes be made here as well?
capture_sync.c:1948:if (GetExitCodeProcess((HANDLE)
capture_opts-fork_child, childstatus)
tshark.c:1962:result1 =
On Sat, Sep 29, 2012 at 10:13 PM, Maynard, Chris
christopher.mayn...@gtech.com wrote:
Apologies, I meant to write:
if (!result || avail 0 || !result1 || childstatus != STILL_ACTIVE) {
I think I am too accustomed to *nix return values where 0 typically means
success, and so I read the
On Sat, Sep 29, 2012 at 2:20 PM, Maynard, Chris
christopher.mayn...@gtech.com wrote:
Good point Bill. I hadn't actually looked too deeply here; I just wanted to
appease the buildbot. See:
http://buildbot.wireshark.org/trunk/builders/Windows-XP-x86/builds/2646/steps/nmake%20all/logs/stdio
On Sat, Sep 29, 2012 at 4:05 PM, Bill Meier wme...@newsguy.com wrote:
On 8/21/2012 2:19 AM, Guy Harris wrote:
On Aug 20, 2012, at 12:49 PM, Kaul wrote:
If it were git, I'm sure I could easily use 'git bisect' and find the
issue.
As Evan Huus indicated, what you probably need to bisect
On Tue, Sep 25, 2012 at 4:26 PM, Jeff Morriss jeff.morriss...@gmail.com wrote:
Hi folks,
I'm doing a lot of live capturing these days (quite unusual for me).
I have a (customized) 1.8.2 build on Linux and I've been noticing that
while doing a live capture with a display filter I can see the
Hi Saso,
You probably need to install the development headers for some of those
libraries. The package gtk2 only contains the runtime libraries, you
need the gtk2-devel package with the source headers to build against
it.
Try:
yum install gtk2-devel gtk3-devel qt-devel
(I'm not on a
CMake Error at CMakeLists.txt:59 (string):
string sub-command REGEX, mode REPLACE needs at least 6 arguments total to
command.
And similar errors for lines 64 and 69. Not sure what's going on here
- the calls conform to the convention specified by all the CMake docs
I've found, and none of
This topic came up off-list and someone asked for a brief cheat-sheet
/ tutorial / explanation of what I currently use, so here it is. This
email is more about the various version-control systems (SVN, Git,
etc.) that manage Wireshark's source than it is about Wireshark
itself, so if you're
Variadic macros are forbidden in doc/README.developer since apparently
not all compilers support them.
However, I just stumbled across a variadic macro that has apparently
been part of the regular build since around 2009
(packet-dcerpc-netlogon.c:65).
Since nobody (to my knowledge) has
On Sun, Sep 23, 2012 at 6:10 PM, Guy Harris g...@alum.mit.edu wrote:
On Sep 23, 2012, at 1:59 PM, Evan Huus eapa...@gmail.com wrote:
Variadic macros are forbidden in doc/README.developer since apparently
not all compilers support them.
However, I just stumbled across a variadic macro
On Thu, Sep 20, 2012 at 5:02 PM, Jeff Morriss jeff.morriss...@gmail.com wrote:
Joerg Mayer wrote:
On Thu, Sep 20, 2012 at 02:55:22AM +, eapa...@wireshark.org wrote:
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=45019
User: eapache
Date: 2012/09/19 07:55 PM
Log:
On Tue, Sep 18, 2012 at 3:35 PM, Jeff Morriss jeff.morriss...@gmail.com wrote:
darkja...@wireshark.org wrote:
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=44860
User: darkjames
Date: 2012/09/10 02:40 PM
Log:
Initial commit to support yet another method of passing data
On Sat, Sep 15, 2012 at 2:06 PM, Christopher Maynard
christopher.mayn...@gtech.com wrote:
Evan Huus eapache@... writes:
There is already a (commented-out) function called
dissector_add_uint_sanity_check which does warn on duplicate port
registrations and on registrations to port 0
On Fri, Sep 7, 2012 at 6:09 PM, Evan Huus eapa...@gmail.com wrote:
On Fri, Sep 7, 2012 at 5:47 PM, Maynard, Chris
christopher.mayn...@gtech.com wrote:
Recently another old proprietary protocol (I’ll call it FOO) was brought to
my attention, and I was asked to write a dissector
On Fri, Sep 7, 2012 at 5:47 PM, Maynard, Chris
christopher.mayn...@gtech.com wrote:
Recently another old proprietary protocol (I’ll call it FOO) was brought to
my attention, and I was asked to write a dissector for it. In doing so, I
discovered a conflict with another dissector, namely SNA.
On Wed, Sep 5, 2012 at 12:54 AM, Jeff Klingler jkling...@gmail.com wrote:
Hi,
Kudos to all you developers for such a great tool! I did a brief
search and couldn't find any discussion of a feature I would like to
see added:
Sync the capture time in a file relative to the time settings found
Hi all,
I've noticed in several places the pattern of adding a message to
assertions in the form of a string constant:
g_assert(condition explanation);
This seems dangerous to me, primarily because if anyone ever mistypes
the as a || then the assertion becomes dead code - it will always
pass.
On Tue, Sep 4, 2012 at 4:53 PM, Guy Harris g...@alum.mit.edu wrote:
On Sep 4, 2012, at 1:39 PM, Evan Huus wrote:
I've noticed in several places the pattern of adding a message to
assertions in the form of a string constant:
g_assert(condition explanation);
This seems dangerous to me
On Thu, Aug 30, 2012 at 3:14 AM, Anders Broman a.bro...@bredband.net wrote:
Evan Huus skrev 2012-08-30 04:31:
On Wed, Aug 29, 2012 at 7:28 PM, Anders Broman a.bro...@bredband.net
wrote:
Jeff Morriss skrev 2012-08-30 00:29:
Evan Huus wrote:
I'm not 100% convinced either way, but I have
On Thu, Aug 30, 2012 at 9:23 AM, Roland Knall rkn...@gmail.com wrote:
Hi
Would you like to enforce a value for the minimum number of subsequent
files in the subdirectories?
I would assume you'd need 5 or 6 files at least to make a folder
worthwhile, but I don't think that's a hard rule. None
On Thu, Aug 30, 2012 at 9:45 AM, Graham Bloice
graham.blo...@trihedral.com wrote:
-Original Message-
From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-
boun...@wireshark.org] On Behalf Of Evan Huus
Sent: 30 August 2012 14:31
To: Developer support list for Wireshark
On Thu, Aug 30, 2012 at 1:46 PM, Jeff Morriss jeff.morriss...@gmail.com wrote:
Evan Huus wrote:
On Thu, Aug 30, 2012 at 9:45 AM, Graham Bloice
graham.blo...@trihedral.com wrote:
-Original Message-
From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-
boun
On Thu, Aug 30, 2012 at 6:21 PM, Jaap Keuter jaap.keu...@xs4all.nl wrote:
On 08/30/2012 04:31 AM, Evan Huus wrote:
On Wed, Aug 29, 2012 at 7:28 PM, Anders Bromana.bro...@bredband.net
wrote:
Jeff Morriss skrev 2012-08-30 00:29:
Evan Huus wrote:
I'm not 100% convinced either way, but I
On Thu, Aug 30, 2012 at 8:29 PM, Ed Beroset bero...@mindspring.com wrote:
Evan Huus wrote:
On Thu, Aug 30, 2012 at 1:46 PM, Jeff Morriss jeff.morriss...@gmail.com
wrote:
Unwieldy how? Except for having to know not to do vi
epan/dissectors/tabtab (for fear of too many pages of output) I
Having re-read the entire thread, I've gathered the following list of
objections. I think it covers all of the concerns mentioned so far (in
no particular order):
1 potential for file-name collisions
2 increased difficulty in using tab-completion
3 potential for less parallel make
4 more
On Wed, Aug 29, 2012 at 11:47 AM, Jeff Morriss
jeff.morriss...@gmail.com wrote:
Joerg Mayer wrote:
What I'd like to do is put these dissectors that belong *to a single
protocol*
into a subdirectory of that name, i.e. move them to
xmpp/packet-conference.c
xmpp/packet-conference.h
On Wed, Aug 29, 2012 at 12:15 PM, cmayn...@wireshark.org wrote:
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=44694
User: cmaynard
Date: 2012/08/29 09:15 AM
Log:
Allow wpa-psk decryption keys to be successfully entered.
Problems reported on ask.wireshark.org here:
1)
On Wed, Aug 29, 2012 at 7:28 PM, Anders Broman a.bro...@bredband.net wrote:
Jeff Morriss skrev 2012-08-30 00:29:
Evan Huus wrote:
I'm not 100% convinced either way, but I have to admit I do like having
all
the dissectors in the same directory. make -j 40 (on my 32-vCPU
SPARC)
works
On Fri, Aug 24, 2012 at 10:43 PM, Evan Huus eapa...@gmail.com wrote:
On Fri, Aug 24, 2012 at 6:52 PM, Tony Trinh ton...@gmail.com wrote:
It's possible that ${wireshark-src}/cmake/modules/FindLUA.cmake is not
properly detecting Lua 5.2 on your system. Check the path defined by
LUA_LIBRARY
Hi all,
I recently attempted to switch from autotools to cmake for building
wireshark, but for some reason cmake won't link liblua properly:
lib/libwireshark.so: undefined reference to `lua_tonumber'
lib/libwireshark.so: undefined reference to `lua_call'
lib/libwireshark.so: undefined reference
On Fri, Aug 24, 2012 at 6:52 PM, Tony Trinh ton...@gmail.com wrote:
It's possible that ${wireshark-src}/cmake/modules/FindLUA.cmake is not
properly detecting Lua 5.2 on your system. Check the path defined by
LUA_LIBRARY (and check LUA_INCLUDE_DIR while you're at it), using these
commands:
On Thu, Aug 23, 2012 at 5:23 PM, Lori Jakab lja...@ac.upc.edu wrote:
On 08/23/12 05:52, Pascal Quantin wrote:
2012/8/19 Lori Jakab l...@lispmob.org mailto:l...@lispmob.org
On 08/19/12 06:56, Pascal Quantin wrote:
Having a RSS link (or something similar) to the subversion file log
On Mon, Aug 20, 2012 at 3:49 PM, Kaul myk...@gmail.com wrote:
Recently (~2 days or so ago?), I've failed to compile wireshark, on F17/x64:
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I./.. -DINET6
-DG_DISABLE_DEPRECATED -DG_DISABLE_SINGLE_INCLUDES -DGSEAL_ENABLE
-DGTK_DISABLE_DEPRECATED
On Fri, Aug 17, 2012 at 10:02 AM, Jakub Zawadzki
darkjames...@darkjames.pl wrote:
On Thu, Aug 16, 2012 at 08:54:54PM -0400, Evan Huus wrote:
On Wed, Aug 15, 2012 at 11:36 AM, Jakub Zawadzki darkjames...@darkjames.pl
wrote:
From r43188 sequence of selecting new packet (cf_select_packet
On Sun, Aug 19, 2012 at 7:03 AM, Harald Welte lafo...@gnumonks.org wrote:
Hi all,
I understand that different FOSS projects have different cultures,
norms, rules, etc. However, my experience with wireshark it has reached
a point where I think a post like this is requierd.
I don't want to
The XP-x86 buildbot has been failing sporadically for over a week now.
It seems to have started around revision 44359, but the actual cause
could be any number of revisions on either side (I don't have an XP
box to bisect with).
Anyone have an idea what's happening?
On Sun, Aug 19, 2012 at 11:22
On Wed, Aug 15, 2012 at 11:36 AM, Jakub Zawadzki
darkjames...@darkjames.pl wrote:
On Wed, Aug 15, 2012 at 10:22:13AM -0400, Evan Huus wrote:
On Wed, Aug 15, 2012 at 9:53 AM, Jakub Zawadzki
darkjames...@darkjames.pl wrote:
From commit r42254 (reference counting of edt)
we have problem
On Thu, Aug 16, 2012 at 1:16 PM, Gerald Combs ger...@wireshark.org wrote:
On 8/15/12 8:12 AM, Evan Huus wrote:
On Wed, Aug 15, 2012 at 10:15 AM, Jeff Morriss
jeff.morriss...@gmail.com wrote:
Evan Huus wrote:
On Linux and most other operating systems I know of, passing a NULL to
a %s format
On Wed, Aug 15, 2012 at 9:53 AM, Jakub Zawadzki
darkjames...@darkjames.pl wrote:
From commit r42254 (reference counting of edt)
we have problem with ep_ memory not being returned to pool after dissecting
packet.
Wireshark after initial opening file, always keep edt for currently selected
On Wed, Aug 15, 2012 at 10:15 AM, Jeff Morriss
jeff.morriss...@gmail.com wrote:
Evan Huus wrote:
On Linux and most other operating systems I know of, passing a NULL to
a %s format specifier is safe. On Solaris, as it turns out, it isn't
[1].
The case in the filed bug is fairly trivial
On Linux and most other operating systems I know of, passing a NULL to
a %s format specifier is safe. On Solaris, as it turns out, it isn't
[1].
The case in the filed bug is fairly trivial to fix, but I'm wondering
if this is something that should be added to the Code Style /
Portability section
On Wed, Aug 1, 2012 at 9:55 AM, Kurt Knochner
ws.dev.l...@nospam.knochner.com wrote:
would it make sense to add version sections to the preferences file? Parsing
the
preference file would a bit more work, but one could separate the modified
preferences
in a proper way from each other.
Extra
701 - 800 of 824 matches
Mail list logo
