Re: [Wireshark-dev] [PATCH] New plugin for Homeplug

2006-12-04 Thread Sebastien Tandel
rid of all the plugin wiring. 3. Add the ether type to etypes.h i.s.o. defining it yourself BTW: It's such a simple protocol you could consider using ptvcursor. Thanks, Jaap On Mon, 4 Dec 2006, Sebastien Tandel wrote: Hi, Here is a patch for the plugin supporting

Re: [Wireshark-dev] [PATCH] New plugin for Homeplug (ptvcursor)

2006-12-04 Thread Sebastien Tandel
Finally, ptvcursor was simple enough to do it right away :) Sebastien Sebastien Tandel wrote: I've done the necessary changes for the regular dissector. Concerning the ptvcursor, I will first see how it works ;) Sebastien Jaap Keuter wrote: Hi, I've looked at the code. Some things

[Wireshark-dev] ptvcursor : one step further?

2006-12-05 Thread Sebastien Tandel
I am seeing ptvcursor as an encapsulation allowing to forget about proto_* structures/functions and helps to simplify the code generated (in general). But for now, it is not possible to write all without knowing any proto_* functions. I will present here a way to get rid of some code and forget a

[Wireshark-dev] [PATCH] ptvcursor and subtrees

2006-12-08 Thread Sebastien Tandel
Hi, It is a re-post. Can you consider it, please? Thx, Sebastien -- Hi, here is a patch which adds the support to ptvcursor to create one level of subtree which helps to reduce/simplify the code written with ptvcursor. - instead of writing : gint current_offset; current_offset =

[Wireshark-dev] [PATCH] New Type : ISIS LSPID

2006-12-09 Thread Sebastien Tandel
of print_system_id (which does not take an additional length parameter) I will send the patch with all the changes in dissectors/packet-isis-* tomorrow. thanx, Sebastien Tandel Index: doc/README.developer === --- doc/README.developer

Re: [Wireshark-dev] Roofnet Dissector

2006-12-09 Thread Sebastien Tandel
? Is this header used for the purpose of an improved source routing? Can you send me a sample capture file? thanx, Sebastien Tandel Nicola Arnoldi wrote: Here you will find informations for designing a dissector for the Roofnet Layer 2.5 routing protocol for wireless mesh network of http

Re: [Wireshark-dev] Roofnet Dissector

2006-12-11 Thread Sebastien Tandel
./autogen.sh ./configure options = ./configure --help or the manual on the website make make install (optional) Nicola Arnoldi wrote: Excuse me. Maybe my question is a bit ridiculous... I am quite a newbie, so don't blame me. After having applied the patch you provided me, how do I

Re: [Wireshark-dev] Roofnet Dissector

2006-12-11 Thread Sebastien Tandel
, Sebastien Tandel Nicola Arnoldi wrote: Ok guys. I am a newbie of wireshark, but not of UN*X in general... I have already tried those... But I encounter several errors. I have libtool, automake, autoconf installed and updated running on an Ubuntu linux 6.10

[Wireshark-dev] [PATCH] stats_tree.c fixup preventing segfault

2006-12-11 Thread Sebastien Tandel
G_MININT (G_MAXINT) if the number is not defined to the left (right). Sebastien Tandel Index: epan/stats_tree.c === --- epan/stats_tree.c (révision 20122) +++ epan/stats_tree.c (copie de travail) @@ -530,12 +530,16

[Wireshark-dev] [PATCH] bugfix : ICMP unreachable and tcp seq not shown

2006-12-12 Thread Sebastien Tandel
number will be added to the tree. One solution is to check whether the packet has been treated by the ICMP dissector in which case TCP seq number should be added directly to the tree. We can find this information in pinfo-layer_names. It is related to the bug 595. Sebastien Tandel Index: epan

Re: [Wireshark-dev] [PATCH] stats_tree.c fixup preventing segfault

2006-12-13 Thread Sebastien Tandel
20060630 (prerelease) (Debian 4.0.3-5). --- I did not test the patch on the glib/gtk+2 ... not yet :) Regards, Sebastien Tandel Stephen Fisher wrote: On Tue, Dec 12, 2006 at 04:41:19AM +0100, Sebastien Tandel wrote: here is a patch against svn rev20122 which prevents

Re: [Wireshark-dev] [PATCH] bugfix : ICMP unreachable and tcp seq not shown

2006-12-13 Thread Sebastien Tandel
Here is a little trace created with hping3 :) Stephen Fisher wrote: On Tue, Dec 12, 2006 at 05:06:49PM +0100, Sebastien Tandel wrote: This patch should resolve the problem of the TCP seq number which is not shown when dissecting an ICMP Unreachable packet. It is related

Re: [Wireshark-dev] [PATCH][Update] stats_tree.c fixup preventing segfault

2006-12-13 Thread Sebastien Tandel
to take this into account. Regards, Sebastien Tandel Sebastien Tandel wrote: Hi Stephen, it's just after ... I leave the filter empty and click create stats :) see in the code plugins/pinfo_stats_tree.c line 97 : st_node_plen = stats_tree_create_range_node(st, st_str_plen, 0, 0-19,20

[Wireshark-dev] [PATCH] fixup memory leak

2006-12-13 Thread Sebastien Tandel
Hi, here is patch for a memory leak in packet-k12.c which allocates a hash table and may return without destroying it. Regards, Sebastien Tandel Index: epan/dissectors/packet-k12.c === --- epan/dissectors/packet-k12.c

Re: [Wireshark-dev] [PATCH][Update] stats_tree.c fixup preventing segfault

2006-12-13 Thread Sebastien Tandel
Hi, reviewing the potential problems g_strsplit could cause in others parts of wireshark. I noticed that my patch was not completely safe. here is a patch which should be safe. (please also review) Regards, Sebastien Tandel Index: epan/stats_tree.c

Re: [Wireshark-dev] [PATCH] bugfix : ICMP unreachable and tcp seq not shown

2006-12-14 Thread Sebastien Tandel
is not added directly to the tree. I don't know if it has a real interest ... it will probably mess a little bit more the code of the TCP dissector. Do someone have an ICMPv6 unreachable pcap ? (with different IPv6 MTU ... hum! yes ok, one should already be good :)) Regards, Sebastien Tandel Jeff

[Wireshark-dev] g_strsplit : glib1.2 vs glib2.0

2006-12-14 Thread Sebastien Tandel
I'm not doing everyday :)) Regards, Sebastien Tandel ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

[Wireshark-dev] guint8* and gchar* ... and Vim ?! :)

2006-12-14 Thread Sebastien Tandel
and not cast to every call of a function ? Regards, Sebastien Tandel ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] guint8* and gchar* ... and Vim ?! :)

2006-12-14 Thread Sebastien Tandel
by wireshark) ... why then using guint8*? Regards, Sebastien Tandel Guy Harris wrote: Sebastien Tandel wrote: is there any reason to use guint8* instead of gchar*? For what purpose? If you're dealing with an array of 8-bit bytes, or a pointer to a sequence of those, guint8

Re: [Wireshark-dev] [PATCH] bugfix : ICMP unreachable and tcp seq not shown

2006-12-15 Thread Sebastien Tandel
Hi Jeff, Jeff Morriss wrote: Sebastien Tandel wrote: I am not sure it's broken ... ICMP and ICMPv6 are rather different ... - ICMP states that you have to put the IP header + 64 bits of data - ICMPv6 RFC states, and I quote, you have to put As much of invoking packet as will fit

Re: [Wireshark-dev] [PATCH] New Type : ISIS LSPID

2006-12-17 Thread Sebastien Tandel
I am afraid no ... :) I was also hoping being able to do a search like isis.lsp.lspid==...XX-XX which could be useful. Unfortunately, it is not sufficient. Any hint? Sebastien Tandel Stephen Fisher wrote: On Sun, Dec 10, 2006 at 04:02:51AM +0100, Sebastien Tandel wrote: I

[Wireshark-dev] [PATCH] New Dissector : Roofnet

2006-12-19 Thread Sebastien Tandel
Hi all, Here is a patch (against svn rev 20149) for the dissector of the new Roofnet protocol. Regards, Sebastien Tandel Index: epan/dissectors/Makefile.common === --- epan/dissectors/Makefile.common (révision 20149

Re: [Wireshark-dev] [PATCH] New Dissector : Roofnet

2006-12-19 Thread Sebastien Tandel
... no. Now, yes! :) 525 passes on 7250 frames for each pass (with the modifications I did now). Is it sufficient? Or have you stronger requisites? Regards, Sebastien Tandel ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org

Re: [Wireshark-dev] [PATCH] New Dissector : Roofnet

2006-12-19 Thread Sebastien Tandel
) +return; + + /* dissect ip payload */ + call_dissector(ip_handle, tvb_new_subset(tvb, offset, -1, -1), pinfo, tree); Regards, Sebastien Tandel Nicola Arnoldi wrote: Dear Sebastien, still the dissector does not decode the inner IPv4 datagram inside roofnet packet. Can you provide

[Wireshark-dev] [PATCH][Update] New dissector : Roofnet

2006-12-19 Thread Sebastien Tandel
Update of the patch for the roofnet dissector. It takes into account the comments of Jaap. Sebastien Tandel Index: epan/dissectors/Makefile.common === --- epan/dissectors/Makefile.common (révision 20151) +++ epan/dissectors

Re: [Wireshark-dev] [Wireshark-commits] rev 20209: /trunk/epan/ftypes/ /trunk/epan/ftypes/: ftype-pcre.c

2006-12-24 Thread Sebastien Tandel
sizeof() ... and ep_malloc does not exist ;) Sebastien Tandel Stephen Fisher wrote: Revision 20209 introduced the following build errors on my FreeBSD Unix machine. I'm using pcre 6.7. ftype-pcre.c: In function `pcre_tuple_new': ftype-pcre.c:52: warning: implicit declaration of function

[Wireshark-dev] [PATCH] ctype functions review

2006-12-26 Thread Sebastien Tandel
Hi all, patch which changes input parameter type of a ctype function from (g)char to guchar avoiding undefined results. Regards, Sebastien Tandel Index: epan/dissectors/packet-sip.c === --- epan/dissectors/packet-sip.c

[Wireshark-dev] [PATCH][UPDATE] ptvcursor : one step further?

2007-01-08 Thread Sebastien Tandel
an undefined length (SUBTREE_UNDEFINED_LENGTH). The length of the item is set once the subtree is pop'ed. 1) ptvcursor_add_with_subtree 2) ptvcursor_add_text_with_subtree If it sounds good I'll do a section for the README.developer. Regards, Sebastien Tandel What is done hereabove

Re: [Wireshark-dev] [PATCH] ISIS Checksum

2007-01-09 Thread Sebastien Tandel
. Furthermore, you clearly won't if there are others vendors routers in your network. Last but not least, CDP does not seem to support IPv6. Do you really think it's the best option? Regards, Sebastien Tandel Jaap Keuter wrote: Hi, It dropped the more common CDP part of the rule for the less

Re: [Wireshark-dev] [PATCH] ISIS Checksum

2007-01-09 Thread Sebastien Tandel
expectations. CDP may be partially implemented by a few others vendors than Cisco. The only case I knew was riverstone which implements a CDP but I think it's not even able to interoperate with the Cisco one. Regards, Sebastien Tandel Jaap Keuter wrote: Hi, On Tue, 9 Jan 2007, Sebastien Tandel wrote

Re: [Wireshark-dev] gentoo section addition to user guide

2007-01-09 Thread Sebastien Tandel
I just received the confirmation from the debian package maintainer that xorg packages had been renamed/reworked and now the dependencies for gtk2-dev should be correct ... Regards, Sebastien Tandel Stephen Fisher wrote: On Mon, Dec 18, 2006 at 12:44:01AM +0100, Sebastien Tandel wrote

Re: [Wireshark-dev] proto_tree_add_item() with range_string

2007-01-12 Thread Sebastien Tandel
structure it encapsulates. = need changes then in the macros VALS, TFS and even in the dissectors using VALS, TFS Regards, Sebastien Tandel Jaap Keuter wrote: Hi, My first impression is that the RS() macro (refer to code sample below) needs to be implemented to work with the range_string type

Re: [Wireshark-dev] roofnet v1

2007-01-12 Thread Sebastien Tandel
Hi, I will try to do it this WE. Regards, Sebastien Tandel Nicola Arnoldi wrote: Hi all. I noticed that the version 1 of the roofnet header has got additional fields, as one might understand from the srpacket.hh file i posted some email ago. In particular, there are 6 and a half more

[Wireshark-dev] airpdcap.c with gtk1.2 does not compile anymore

2007-01-14 Thread Sebastien Tandel
. :)) Regards, Sebastien Tandel ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

[Wireshark-dev] [PATCH] mem leak in dissect_ip_tcp_options

2007-01-14 Thread Sebastien Tandel
that, would be useful to write a comment in the file.) Regards, Sebastien Tandel Index: epan/dissectors/packet-ip.c === --- epan/dissectors/packet-ip.c (révision 20426) +++ epan/dissectors/packet-ip.c (copie de travail) @@ -691,12 +691,11

Re: [Wireshark-dev] [PATCH] mem leak in dissect_ip_tcp_options

2007-01-14 Thread Sebastien Tandel
. (If there is a reason to do that, would be useful to write a comment in the file.) Regards, Sebastien Tandel Index: epan/dissectors/packet-ip.c === --- epan/dissectors/packet-ip.c (révision 20426) +++ epan/dissectors/packet

Re: [Wireshark-dev] [Patch] airpcap.c

2007-01-16 Thread Sebastien Tandel
Ouch, I don't have this one on the latest svn version ... :-/ Gisle Vanem wrote: --- SVN-Latest\epan\crypt\airpdcap.cFri Jan 12 17:23:52 2007 +++ epan\crypt\airpdcap.c Tue Jan 16 11:59:58 2007 @@ -1663,7 +1663,7 @@ else output_string =

Re: [Wireshark-dev] [Patch] airpcap.c

2007-01-16 Thread Sebastien Tandel
sorry you're right, part of code not compiled on my computer. Sebastien Tandel wrote: Ouch, I don't have this one on the latest svn version ... :-/ Gisle Vanem wrote: --- SVN-Latest\epan\crypt\airpdcap.cFri Jan 12 17:23:52 2007 +++ epan\crypt\airpdcap.c Tue Jan 16 11:59:58

Re: [Wireshark-dev] [Patch] packet-kerberos.c

2007-01-16 Thread Sebastien Tandel
PS. What's up with the mailing-list software? Every message looks like crap; all line-endings are missing. Is the ML-software running on a Mac? Everything's fine here ... maybe a new feature of Outlook Express? :-p Regards, Sebastien Tandel

Re: [Wireshark-dev] [Patch] packet-kerberos.c

2007-01-16 Thread Sebastien Tandel
just kidding about OE ... but as said it's all right here for me. Regards, Sebastien Tandel Gisle Vanem wrote: Sebastien Tandel [EMAIL PROTECTED] wrote: PS. What's up with the mailing-list software? Every message looks like crap; all line-endings are missing. Is the ML-software running

[Wireshark-dev] [PATCH] strptime implicit declaration warning

2007-01-16 Thread Sebastien Tandel
Hi, a patch to avoid the warning implicit declaration of function 'strptime' in editcap.c glib.h is included just after the define __USE_XOPEN and include time.h Regards, Sebastien Tandel Index: editcap.c === --- editcap.c

Re: [Wireshark-dev] [PATCH] BACnet bacapp additions

2007-01-16 Thread Sebastien Tandel
Many thanks :) Regards, Sebastien Tandel Steve Karg wrote: Hi Sebastien, Can you share a pcap trace of BACnet? There is a directory of unorganized BACnet captures in a directory on my website: http://kargs.net/captures/ You can use them for whatever you want

[Wireshark-dev] [PATCH] new dissector : Homeplug

2007-01-16 Thread Sebastien Tandel
Hi all, a re-post for the Homeplug dissector. (fuzz-tested) Regards, Sebastien Tandel Index: epan/etypes.h === --- epan/etypes.h (revision 20454) +++ epan/etypes.h (working copy) @@ -246,6 +246,10 @@ #define

Re: [Wireshark-dev] write plugin following README.plugins

2007-01-17 Thread Sebastien Tandel
It is not the purpose of README.plugin to describe how to compile wireshark from svn. In fact, there is a good developer manual on the web which is a 'HowTo develop in wireshark' and even how to compile wireshark from the svn. (automake 1.6.3 is working perfectly) Regards, Sebastien Tandel

Re: [Wireshark-dev] RUDP Plugin functional ?

2007-01-17 Thread Sebastien Tandel
Hi, You have to change the port while wireshark is running and not in the code of the RUDP dissector. You may do it in the protocol preferences (Edit-Preferences-protocol RUDP). Regards, Sebastien Tandel Jan Kokott wrote: Hi, and thanks for the info. I tried to build a packet out

Re: [Wireshark-dev] write plugin following README.plugins

2007-01-17 Thread Sebastien Tandel
on howto code into specific parts of wireshark (dissector, plugin, use of emem, wiretap, ...), it would be a mess and impossible to manage. A pointer to the doc on the web could be more useful ... Regards, Sebastien Tandel ___ Wireshark-dev mailing list

Re: [Wireshark-dev] [PATCH] new dissector : Homeplug

2007-01-17 Thread Sebastien Tandel
to the wiki (if possible) It has already been done on the first submission. ;) P.S. : Is not the wiki read-only now? (at least for most of us) Regards, Sebastien Tandel ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org

Re: [Wireshark-dev] [PATCH] new dissector : Homeplug

2007-01-17 Thread Sebastien Tandel
ok ... did not notice that was only the front page. thx, Sebastien Tandel Ulf Lamping wrote: P.S. : Is not the wiki read-only now? (at least for most of us) No, AFAIK. I was able to edit a page without a logon. Only the FrontPage was locked due to spam... Regards, ULFL

[Wireshark-dev] [PATCH] Fixup for a segfault with gtk1.2

2007-01-17 Thread Sebastien Tandel
details and a review of the dissectors using this function) Regards, Sebastien Tandel Index: epan/stats_tree.c === --- epan/stats_tree.c (révision 20466) +++ epan/stats_tree.c (copie de travail) @@ -524,18 +524,63

Re: [Wireshark-dev] Win32: The best way to solve dependencies for user-guide.chm / HHC_DIR?

2007-01-17 Thread Sebastien Tandel
if there was already a discussion about that) Regards, Sebastien Tandel Ulf Lamping wrote: Hi List! Unfortunately, the online help feature is only *almost* ready, but I would like to add it to 0.99.5 as it's stable in my eyes - but I was busy the last days to do the final step. So here's my current problem

Re: [Wireshark-dev] Win32: The best way to solve dependencies for user-guide.chm / HHC_DIR?

2007-01-18 Thread Sebastien Tandel
thx for the explanation*s* ;) Ulf Lamping wrote: Sebastien Tandel wrote: hmmm ... IMHO, if you want to keep things simple as much as possible for newbie developer, it's better to let people download the html user guide and they won't need an internet connection either

Re: [Wireshark-dev] [Wireshark-commits] rev 20491: /trunk/docbook/ /trunk/docbook/: Makefile

2007-01-19 Thread Sebastien Tandel
for dos2unix ... :) Regards, Sebastien Tandel Sake Blok wrote: On Thu, Jan 18, 2007 at 04:20:40PM -0800, Guy Harris wrote: On Jan 18, 2007, at 4:08 PM, Sebastien Tandel wrote: Is it safe to assume that dos2unix is available on a common UNIX developer machine?!? Nope

Re: [Wireshark-dev] Problems while displaying the digits in the packet

2007-01-19 Thread Sebastien Tandel
Hi, It seems that hf_xyz_imsi that you have defined in your hf_register_info struct is not a FT_STRING or a FT_STRINGZ type. Regards, Sebastien Tandel [EMAIL PROTECTED] wrote: Hi , We have a parameter IMSI in our protocol . It has the following format : 7 6

Re: [Wireshark-dev] [PATCH] Fixup for a segfault with gtk1.2

2007-01-22 Thread Sebastien Tandel
Tandel Stephen Fisher wrote: On Thu, Jan 18, 2007 at 01:55:05AM +0100, Sebastien Tandel wrote: just a remember for this patch against a crash of wireshark with gtk1.2 when using packet length statistics window. The crash was due to a difference of implementation of g_strsplit between

Re: [Wireshark-dev] [PATCH] Fixup for a segfault with gtk1.2

2007-02-03 Thread Sebastien Tandel
code to gtk1.2 in epan/stats_tree.c Regards, Sebastien Tandel Index: epan/ws_strsplit.c === --- epan/ws_strsplit.c (révision 0) +++ epan/ws_strsplit.c (révision 0) @@ -0,0 +1,81 @@ +/* ws_strsplit.c + * String Split utility

[Wireshark-dev] [PATCH] hex_str_to_bytes and NULL tests

2007-02-04 Thread Sebastien Tandel
). Here is a light patch to follow the logic of the conditional tests done in the function. Regards, Sebastien Tandel Index: epan/strutil.c === --- epan/strutil.c (révision 20702) +++ epan/strutil.c (copie de travail) @@ -443,7

[Wireshark-dev] [PATCH] range_string in proto_tree_add_item

2007-02-04 Thread Sebastien Tandel
these changes. I've already made fake tests but not with these specific dissectors. Regards, Sebastien Tandel Index: epan/proto.c === --- epan/proto.c(révision 20712) +++ epan/proto.c(copie de travail) @@ -4026,9 +4026,15

Re: [Wireshark-dev] [PATCH] range_string in proto_tree_add_item

2007-02-05 Thread Sebastien Tandel
Hi Steve, It was discussed in the thread with Guy (http://www.wireshark.org/lists/wireshark-dev/200701/msg02454.html) ... Regards, Sebastien Tandel re-post of a patch described here ... http://www.wireshark.org/lists/wireshark-dev/200701/msg00321.html Is there any way to avoid

Re: [Wireshark-dev] [PATCH] Fixup for a segfault with gtk1.2

2007-02-05 Thread Sebastien Tandel
Yes, it is a cut and paste from glib. Regards, Sebastien Tandel Stephen Fisher wrote: On Sun, Feb 04, 2007 at 02:23:11AM +0100, Sebastien Tandel wrote: Here are two patches to resolve conflicts for g_strsplit with glib2 and glib1.2. The first one (ws_strsplit.diff) creates

Re: [Wireshark-dev] [PATCH] range_string in proto_tree_add_item

2007-02-13 Thread Sebastien Tandel
Here it is. Regards, Sebastien Tandel Stephen Fisher wrote: Thanks, I hadn't fully read that thread. Could you write up a little section for README.developer that describes how this functionality is used and then I'll commit these. Thanks. On Mon, Feb 05, 2007 at 09:59:13PM +0100

Re: [Wireshark-dev] sample dissector

2007-02-16 Thread Sebastien Tandel
changes will be lost if you run again ./autogen.sh or ./configure which is desired if the update of your working tree affects some Makefile.am. but I guess it does not tackle his problem as README.developer states that DISSECTOR_SRC is in epan/dissectors/Makefile.common ... :-/ Regards, Sebastien

Re: [Wireshark-dev] Cross-compile wireshark, without using gnutls

2007-02-22 Thread Sebastien Tandel
Hi, It should work with this patch. After applying, pleaser run ./autogen.sh then ./configure --disable-gnutls Hope this helps, Sebastien Tandel Luis Ontanon wrote: fixing automake scripts that takes a long long time... what you can try is renaming gnutls/gnutls.h in your system

Re: [Wireshark-dev] Wireshark development API

2007-02-27 Thread Sebastien Tandel
at the deprecated functions : http://wiki.wireshark.org/Development/DeprecatedFunctions Regards, Sebastien Tandel MKS {} wrote: Hi, I wanted to know where I could get the complete API for developing dissectors. The developers guide has an example but the API list is not exhaustive. Thanks

Re: [Wireshark-dev] [PATCH] Dissector hooks: Small and Simple additions

2007-03-01 Thread Sebastien Tandel
Hi, Couldn't we pass one of the fields in the private data? Regards, Sebastien Tandel Guy Harris wrote: On Feb 21, 2007, at 6:53 PM, Shehjar Tikoo wrote: It brings in the dissector hooks feature discussed here a few weeks back. Its a small patch that includes basic infra

Re: [Wireshark-dev] Ronnie's SVN 20251 looks quite strange to me - is there a reason?

2007-03-06 Thread Sebastien Tandel
coming for the main branch but, IMHO, it would be cleaner. What do you think? Regards, Sebastien Tandel ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Compile error on FC4 (since rev 20951)

2007-03-08 Thread Sebastien Tandel
Hi, the following should help : http://www.wireshark.org/lists/wireshark-dev/200703/msg00028.html Regards, Sebastien Tandel Sake Blok wrote: Hi All, Does anyone else have problems compiling Wireshark on FC4? Since revision 20951 I get the following errors: rm -f .libs/wiresharkS.c .libs

Re: [Wireshark-dev] [PATCH][UPDATE] ptvcursor : one step further?

2007-03-11 Thread Sebastien Tandel
to implement one either ... Regards, Sebastien Tandel Jeff Morriss wrote: Sebastien Tandel wrote: Hi, I've updated the patch for ptvcursor taking into account the ideas of Guy. Features supported by ptvcursor : - multiple levels (256 max.), allocation per 8 levels. - Two new functions

Re: [Wireshark-dev] [PATCH][UPDATE] ptvcursor : one step further?

2007-03-11 Thread Sebastien Tandel
I've taking a look at emem.c and it clearly doesn't attach information about the chunk of memory being allocated. Then ep_realloc may only be the allocate new, copy solution. Without that information, how do you know how much to copy (if you don't pass the old size explicitly, which

Re: [Wireshark-dev] Query regarding raw socket sending and receiving

2007-03-12 Thread Sebastien Tandel
Hi, I fear you're not on the accurate mailing-list for these questions ... google these keywords 'unix network programming' or buy 'Unix network programming' by Stevens, Prentice-Hall Regards, Sebastien Tandel sara vanan wrote: Dear Sir, I am doing raw socket programming in Linux. I want

Re: [Wireshark-dev] Re : nmake -distclean failing

2007-03-12 Thread Sebastien Tandel
... Is there something else to notice before this fatal rm command? Regards, Sebastien Tandel Thibault Cogoluenhès wrote: Hi, I had the same problem. The problem is the cmd.exe from windows 2000. The length of the command in the cmd.exe from XP can be longer thant the command line

[Wireshark-dev] crypt-sha1

2007-03-16 Thread Sebastien Tandel
instead of guint32? Regards, Sebastien Tandel ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] crypt-sha1

2007-03-16 Thread Sebastien Tandel
Thanks for the answer. And here is the patch to change guint - guint32 in the hmac function. Regards, Sebastien Tandel Luis Ontanon wrote: If they are in the hmac code that's probably my fault when I put it back in the repo. I don't think it will be causing any problems, as we do not run

Re: [Wireshark-dev] crypt-sha1

2007-03-16 Thread Sebastien Tandel
Tandel Luis Ontanon wrote: This I can change by hand... but as a rule of thumb you should compress patches you send to the list, that's because some MUAs mangle text files (e.g. mine does). Luis On 3/16/07, Sebastien Tandel [EMAIL PROTECTED] wrote: Thanks for the answer. And here

Re: [Wireshark-dev] crypt-sha1

2007-03-16 Thread Sebastien Tandel
The wiki page has been updated. Maybe we should have a svn diff | gzip | send-the-patch-to-bugzilla pipeline. :) What a great idea! :-D Regards, Sebastien Tandel ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http

Re: [Wireshark-dev] Prevent compiler warnings by using stop on warnings/treat warnings as errors compiler option?

2007-03-19 Thread Sebastien Tandel
only the set of changes induced by the patch. (available in the last version). We could extend it easily for wireshark purposes (like inspecting if the patch is using classic memory allocation functions or deprecated wireshark functions). Regards, Sebastien Tandel Luis Ontanon wrote: the point

Re: [Wireshark-dev] [PATCH] analyzing SHIM6 protocol

2007-03-20 Thread Sebastien Tandel
I think most the proto_tree_add_text could be replaced by proto_tree_add_item which could allow (i.e. at least Sébastien Barré ;)) to perform an easy search on specific items. ;) Regards, Sebastien Tandel Matthijs Mekking wrote: Hello, The last two months I have been working on a SHIM6

[Wireshark-dev] [PATCH]fix warnings II

2007-03-21 Thread Sebastien Tandel
some more fixes packet-ncp.c ncpiph.signature initialized and the following test changed and ncpiph.length = 0 packet-sip in_quoted_string unused variable packet-smb-common.c string_len initialized to 0 packet-smb-pipe.c ent_count initialized to 0 packet-smb.c subcmd

Re: [Wireshark-dev] [PATCH]fix warnings

2007-03-21 Thread Sebastien Tandel
one version gzipped ;) Sebastien Tandel wrote: some warning fixes packet-http.c set headers.content_length = 0 before the first potential use of it. packet-kink.c ifdef kerberos around one function declaration packet-nbns.c set headers.{dgm_length|pkt_offset|error_code} = 0

[Wireshark-dev] [PATCH] ipv6 dissector update

2007-03-21 Thread Sebastien Tandel
an expert info for invalid jumbo value and invalid router alert length. - correction of invalid jumbo payload length - get rid of variable declaration in a block Regards, Sebastien Tandel dissector-ipv6.diff.gz Description: application/gzip ___ Wireshark

Re: [Wireshark-dev] [PATCH]fix warnings

2007-03-22 Thread Sebastien Tandel
As it's not a simple unused variable and I had no idea if these functions could ever be used again, I preferred to let them in the code. But if it's sure that they will never be used. I can delete them. Regards, Sebastien Tandel Joerg Mayer wrote: On Thu, Mar 22, 2007 at 01:54:19AM +0100

[Wireshark-dev] [PATCH] strict aliasing warning fix

2007-03-22 Thread Sebastien Tandel
patch for (void**) castings generating strict aliasing warning. Simply cast with (void*) Regards, Sebastien Tandel type-punned.diff.gz Description: application/gzip ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org

Re: [Wireshark-dev] [PATCH]fix warnings

2007-03-22 Thread Sebastien Tandel
same patch except that capture_*_pflog are stripped Joerg Mayer wrote: On Thu, Mar 22, 2007 at 12:58:47PM +0100, Sebastien Tandel wrote: As it's not a simple unused variable and I had no idea if these functions could ever be used again, I preferred to let them in the code. But if it's

[Wireshark-dev] [PATCH] unused variables

2007-03-22 Thread Sebastien Tandel
stripped away some unused variables/parameters + in prefs.c suggestion of parentheses makes gcc happy Regards, Sebastien Tandel unused-variables.diff.gz Description: application/gzip ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http

[Wireshark-dev] [PATCH] bad RVALS declaration

2007-03-22 Thread Sebastien Tandel
copy paste hit again, here is a patch with the accurate declaration of RVALS in proto.h Thx gcc-4.1.2 for finding new ways of generating strict aliasing warnings :) Regards, Sebastien Tandel rvals-strict-aliasing.diff.gz Description: application/gzip

Re: [Wireshark-dev] [PATCH] bad RVALS declaration

2007-03-22 Thread Sebastien Tandel
what a shame, even the comment was copy pasted :-p patch with accurate comment and declaration. Regards, Sebastien Tandel Sebastien Tandel wrote: copy paste hit again, here is a patch with the accurate declaration of RVALS in proto.h Thx gcc-4.1.2 for finding new ways of generating strict

Re: [Wireshark-dev] My postings are getting lost

2007-03-22 Thread Sebastien Tandel
Hi, You may post it on the bugzilla. http://bugs.wireshark.org/bugzilla/ Regards, Sebastien Tandel Bill Fassler wrote: I have repeatedly tried to post a response to Joerg Mayer regarding decoding traffic thru OpenVPN. Although I provided a one packet sample, Joerg requested a small

Re: [Wireshark-dev] [PATCH][UPDATE] analyzing SHIM6 protocol

2007-03-22 Thread Sebastien Tandel
Hi, your patch is malformed line 63. You've probably deleted some hf_items or some comments directly in the patch but that must be reflected in the accounting numbers of the patch format ;) Regards, Sebastien Tandel Matthijs Mekking wrote: Thanks for the advice. I have attached a new patch

[Wireshark-dev] [PATCH] ./configure --with-warnings-as-errors

2007-03-23 Thread Sebastien Tandel
by HAVE_WARNINGS_AS_ERRORS. With this switch, people won't suffer from unexpected warnings when downloading svn sources during the transition time ;) Regards, Sebastien Tandel configure-warnings-as-errors.diff.gz Description: application/gzip ___ Wireshark

[Wireshark-dev] [PATCH] Plugins Warnings

2007-03-23 Thread Sebastien Tandel
it be changed to guint in the structure _ASN1_SCK and in the aforementioned functions? Regards, Sebastien Tandel profinet-megaco.diff.gz Description: application/gzip ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org

Re: [Wireshark-dev] [PATCH] ./configure --with-warnings-as-errors

2007-03-23 Thread Sebastien Tandel
I've posted a patch (subject : Plugins Warnings) for fixing warnings in profinet and megaco. If you won't integrate it, please say it that I stop loosing my time. Regards, Sebastien Tandel Stephen Fisher wrote: On Fri, Mar 23, 2007 at 05:32:12PM +0100, Sebastien Tandel wrote: Patch

Re: [Wireshark-dev] [PATCH] Plugins Warnings

2007-03-23 Thread Sebastien Tandel
Stephen Fisher wrote: On Fri, Mar 23, 2007 at 05:33:41PM +0100, Sebastien Tandel wrote: First patch fixes warning of profinet and megaco plugins to compile again with gcc-4.1.2. Committed as SVN revision 21155. Thanks for your help! asn1 plugin is generating warnings. I'm

Re: [Wireshark-dev] [PATCH] ./configure --with-warnings-as-errors

2007-03-23 Thread Sebastien Tandel
Then there are others in the list : bad RVALS declaration unused variables strict aliasing warning fix Regards, Sebastien Tandel Stephen Fisher wrote: On Fri, Mar 23, 2007 at 07:04:38PM +0100, Sebastien Tandel wrote: I've posted a patch (subject : Plugins Warnings) for fixing

[Wireshark-dev] ASN1 warning question

2007-03-23 Thread Sebastien Tandel
) of proto_tree_add_string_format is the guchar array we have converted with showoctets. Is it correct? Don't we have to put it to strlen(octets)? (it appears that octets has to be NULL-teminated). Regards, Sebastien Tandel ___ Wireshark-dev mailing list Wireshark-dev

[Wireshark-dev] [PATCH] ASN1 plugins warnings fixes

2007-03-23 Thread Sebastien Tandel
Hi, fixes gcc warnings and get rid of declaration after statements Regards, Sebastien Tandel plugin-asn1.diff.gz Description: application/gzip ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo

[Wireshark-dev] [PATCH] dissectors warnings fix

2007-03-23 Thread Sebastien Tandel
patch fixing warnings for the following dissectors : packet-3ga11.c packet-aim-buddylist.c packet-aim-chat.c packet-aim-messaging.c packet-aim-signon.c packet-ajp13.c 3ga11-aim-ajp13-warnings-fix.diff.gz Description: application/gzip

Re: [Wireshark-dev] [Wireshark-commits] rev 21195: /trunk/ /trunk/: configure.in

2007-03-26 Thread Sebastien Tandel
Me and automake/configure are not on friendly terms. Is there someone who is on friendly terms with them? ;) ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] [Wireshark-commits] rev 21195: /trunk/ /trunk/: configure.in

2007-03-26 Thread Sebastien Tandel
Note that '==' is not portable on BSD unix. Jeff Morriss wrote: Thanks sorry for the trouble. Unfortunately something was stripping the []'s out of the test in configure.in so the resulting configure just had if $? == 0 ; which didn't work. I just checked in a new version which should

[Wireshark-dev] [PATCH] bunch of warnings fixes

2007-03-26 Thread Sebastien Tandel
packet-who packet-x11 packet-x25 packet-xdmcp packet-xml packet-yhoo Regards, Sebastien Tandel rev21208-dissectors-warnings-fixes.diff.gz Description: application/gzip patch-per-file.tar.gz Description: application/gzip ___ Wireshark-dev mailing list

[Wireshark-dev] packet-amqp.c

2007-03-28 Thread Sebastien Tandel
Permissions have not been correctly set on packet-amqp.c Regards, Sebastien Tandel ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] [Patch] pragma warning

2007-03-28 Thread Sebastien Tandel
: libwireshark-asn.dll Wouldn't be the register_all_protocols() function problematic? Regards, Sebastien Tandel ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

  1   2   >