Re: [Wireshark-dev] Join wireshark to fix bugs

[Dario Lombardo]

Hi Charlie, and welcome to the community.
Are you able to compile wireshark? If not, that's where to start. You can
find anything in the wireshark developer's guide.

https://www.wireshark.org/docs/wsdg_html_chunked/

Once you have compiled it, I guess you would add a dissector. Read chap 9.2
to know how.
You will be added to this ML asap.
Feel free to ask for help.
Have fun with compiling :-).
Dario.

On Mon, Feb 26, 2024 at 4:49 PM Charlie Cilia  wrote:

> Hi
>
> Can i be added to the developers mailing list?
> Can you also point me in the right direction as to how i get started?
> Email for contact is
> pegasus...@gmail.com
>
> BRS
> Charlie Cilia
> M 0407 96 4211
> H 02 8677 5957
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
>


-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Extcap program based on extcap_example.py

[Dario Lombardo]

Hi Timo.
Yes, not compiled extcaps are to be placed in the extcap folder.
Since you're not integrating into the wireshark building system, you don't
have to handle cmake. From a working wireshark installation, just point out
where the extcap folder is (have a look at the about dialog, in case you
don't know it) and put your executable inside it. Be sure it fulfils all
the requirements for the excap interface (starting from the python
interpreter, executable bit, etc). The extcap interface is intentionally
loose and what doesn't fit it, it's just silently discarded.

On Sun, May 21, 2023 at 10:44 PM Timo Warns <
timow+git...@diningphilosopher.de> wrote:

> I am writing an extcap program building upon doc/extcap_example.py.
>
> - Shall extcap programs that do not need compilation also be placed in
>   extcap/?
>
> - I am not very familiar with CMake and am struggling with getting the
>   extcap program copied over to run/extcap/ by the build system. (For
>   example, simply adding "install(PROGRAMS [...]" to
>   extcap/CMakeLists.txt does not seem to be sufficient.) Could someone
>   please provide some guidance on how to manage non-compiled extcap
>   programs?
>
> Thanks, Timo
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
>


-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] capture_file rewind

[Dario Lombardo]

Hi,
I have an open capture_file that hasn't been processed yet. I want to move
to the end of the file at a negative position: -100 is 100 from the end.
But I don't have the number or packets in the capture_file.
I tried to use get_stats_for_preview, that worked pretty well, but it
turned out it leaves the packet pointer to the end, then any
subsequent reads don't return anything.
My options:
- rewind the capture_file (but how?)
- use cfile_read (to count), cfile_close, cfile_open (overkill?)
- use a better technique to extract how many packet the capture_file has
(I'm all ears)

Any advice?
Dario.
-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] CARES to old for CentOS8?

[Dario Lombardo]

Hi Anders,
unfortunately this is a hairy issue. Redhat's policy about security is a
bit puzzling. They patch (as told before) old versions to make them not
vulnerable, maintaining the same version number. This is weird since being
vulnerable or not is something everyone in the world points out by looking
at the version number. XX is vulnerable, XX+1 is not... but for redhat XX
is not vulnerable also. This is something I hit personally (think how many
times RH has patched vulnerable kernels), that basically makes vulnerable
systems untrackable. I don't know the rationale behind their policy, but
for regular people, this is something hard to manage.
So I get your point and I would really like another solution, but I agree
that we should not solve an issue they created.
Since they patched libcares, they keep track of what is vulnerable and what
is not: they should patch wireshark accordingly to make it compile with the
older one... if they shipped a recent wireshark, and we know they don't.
Ciao.
Dario.

On Thu, Sep 29, 2022 at 10:27 PM Anders Broman  wrote:

> Hi,
> No problem. Just so we are aware we dropp support for rhel8 and similiar
> due to a minor technicality in my opinion.
> Best regards
> Anders
>
>
> Den tors 29 sep. 2022 16:32Roland Knall  skrev:
>
>> That library was not the only consideration. The main consideration was
>> to cut-off at a certain point for 4.0 so that we can avoid having too many
>> things to consider going forward. There was a message about this on the
>> list a while back as well as a discussion at SF.
>>
>> Now, I get the argument to have compatibility for self-built versions,
>> and I could see a point, where we make a switch for a certain library to
>> have a compatibility mode. But I am not sure if this should be the way
>> forward in this case. Much rather have the nuisance to compile a more
>> recent version together with Wireshark, than have one more thing to support
>>
>> regards
>> Roland
>>
>> Am Do., 29. Sept. 2022 um 15:03 Uhr schrieb Jeff Morriss <
>> jeff.morriss...@gmail.com>:
>>
>>> Also keep in mind that if RHEL decides to fix the CVE(s) in question in
>>> version 8 of their OS, they would likely apply the fix for the CVE to the
>>> version of CARES that they are already shipping (i.e., they'd create a
>>> version like 1.13.0. rather than upgrading to 1.14.x).  They work
>>> hard to avoid changing version numbers for compatibility reasons.
>>>
>>> On Thu, Sep 29, 2022 at 6:59 AM Anders Broman 
>>> wrote:
>>>
 Hi,
 Well a choice to make if we want to support CentOS8/RHEL8 or not. One
 could argue that CVE:s in support libraries might not be for us to
 decide on but rather the OS maintainers.
 Best regards
 Anders

 Den tors 29 sep. 2022 kl 08:19 skrev Roland Knall :

> The reason for 1.14 was a CVE that was fixed. I would vote strongly
> against reducing the Version just to support an older version.
>
> Regards, Roland
>
> Am 28.09.2022 um 18:48 schrieb John Thacker :
>
> 
> On Wed, Sep 28, 2022, 10:47 AM Anders Broman 
> wrote:
>
>> Hi,
>> Is there a workaround for
>> CMake Error at
>> /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 
>> (message):
>>   Could NOT find CARES: Found unsuitable version "1.13.0", but
>> required is at
>>   least "1.14.0" (found /usr/lib64/libcares.so)?
>> I would like to build for CentOS8...
>>
>
> It doesn't actually need anything from 1.14.0, so changing the line in
> CMakeLists.txt that sets the minimum version should be fine. Look at the
> commit below and change one line to 1.13.0
>
>
> https://gitlab.com/wireshark/wireshark/-/commit/5991a75d78a31ba61de6c162c79c2928da19c302
>
> John
>
>>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
>
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
>

 ___
 Sent via:Wireshark-dev mailing list 
 Archives:https://www.wireshark.org/lists/wireshark-dev
 Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org
 ?subject=unsubscribe

>>>
>>> ___

Re: [Wireshark-dev] WinDump Web site

[Dario Lombardo]

Hi,
thanks for the report. The best place to file it is wireshark's gitlab.

https://gitlab.com/wireshark/wireshark/-/issues

On Tue, Sep 6, 2022 at 5:35 PM AreThree  wrote:

> Hello!
>
>
>
> I hope this is the correct place to send this, wasn’t sure since it deals
> with the documentation…
>
>
>
> So I was reading the FAQ and got to about here
>  and tried to follow the
> link to the WinDump website which returned an
> error message: “…can’t connect to the server at www.windump.org...”.  It
> appears that website isn’t around or available anymore, so I wanted to
> suggest altering the FAQ to point to the archive.org version
>  of
> that site.  It looks like nothing has happened with it since 2013!
>
>
>
> I do hope that this was helpful, and please keep up the great work!  It’s
> an amazing product!!!
>
>
>
>-AT
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
>


-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] PCAP-over-IP in Wireshark?

[Dario Lombardo]

You can have a look at udpdump, which doesn't use TCP but UDP, but it may
fit your purpose.

On Mon, Jan 31, 2022 at 1:57 PM Erik Hjelmvik 
wrote:

> Hello folks,
>
> Is there some way to read PCAP-over-IP in Wireshark? I.e. read a PCAP
> stream over a TCP socket.
>
> Currently, the best solution to read PCAP-over-IP in Wireshark is by using
> netcat to read the PCAP stream and forward it to Wireshark's STDIN like
> this:
> nc localhost 57012 | wireshark -k -i -
>
> But it would be much nicer if this data could be read directly without
> having to use netcat. Maybe as an extcap interface?
>
> Best regards,
> Erik
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
>


-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Unable to manually create a MR

[Dario Lombardo]

Hi list,
my regular workflow is to push on a branch on my fork, then go to the main
merge requests page, where I am proposed for creating a new merge request.
This works as expected.
However if I click on "new merge request" I land on a page where the source
and destination branch can be selected. The weird thing is that I expected
to be able to select a branch from my fork, while I can only choose the
main repo. Is something wrong happening on gitlab.com or is it happening to
my memory?
Dario.

-- 

Naima is on holidays.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Windows build fails

[Dario Lombardo]

I've forced sdk 10.0.20348.0, and indeed it looks like cmake is using it.

https://github.com/crondaemon/wireshark/runs/4558028604?check_suite_focus=true

However the error still persists. Any other hint?

On Thu, Dec 16, 2021 at 5:50 PM Gerald Combs  wrote:

> We recently added a requirement for C11, which requires a relatively
> recent Windows SDK. The build is failing with
>
> CMake Error at CMakeLists.txt:589 (message):
>Windows SDK 10.0.17763.0 doesn't support C11.  Please make sure you're
>using 10.0.20348.0 or later.
>
> Is there any way to switch the GitHub builders to a newer Windows SDK?
>
> On 12/16/21 3:31 AM, Dario Lombardo wrote:
> > Hi
> > The github windows builder is failing
> >
> >
> https://github.com/wireshark/wireshark/runs/4546222143?check_suite_focus=true
> <
> https://github.com/wireshark/wireshark/runs/4546222143?check_suite_focus=true
> >
> >
> > It started to show up around a couple of days ago, around commit
> 77b6bca3870d5ef63303e637cc39e2cf83f49ddc, as seen on
> >
> >
> https://github.com/wireshark/wireshark/actions/workflows/windows.yml?query=branch%3Amaster
> <
> https://github.com/wireshark/wireshark/actions/workflows/windows.yml?query=branch%3Amaster
> >
> >
> > --
> >
> > Naima is online.
> >
> >
> >
> ___
> > Sent via:Wireshark-dev mailing list 
> > Archives:https://www.wireshark.org/lists/wireshark-dev
> > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> >   mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
>
>

-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Windows build fails

[Dario Lombardo]

I'll look into this.

On Thu, Dec 16, 2021 at 5:50 PM Gerald Combs  wrote:

> We recently added a requirement for C11, which requires a relatively
> recent Windows SDK. The build is failing with
>
> CMake Error at CMakeLists.txt:589 (message):
>Windows SDK 10.0.17763.0 doesn't support C11.  Please make sure you're
>using 10.0.20348.0 or later.
>
> Is there any way to switch the GitHub builders to a newer Windows SDK?
>
> On 12/16/21 3:31 AM, Dario Lombardo wrote:
> > Hi
> > The github windows builder is failing
> >
> >
> https://github.com/wireshark/wireshark/runs/4546222143?check_suite_focus=true
> <
> https://github.com/wireshark/wireshark/runs/4546222143?check_suite_focus=true
> >
> >
> > It started to show up around a couple of days ago, around commit
> 77b6bca3870d5ef63303e637cc39e2cf83f49ddc, as seen on
> >
> >
> https://github.com/wireshark/wireshark/actions/workflows/windows.yml?query=branch%3Amaster
> <
> https://github.com/wireshark/wireshark/actions/workflows/windows.yml?query=branch%3Amaster
> >
> >
> > --
> >
> > Naima is online.
> >
> >
> >
> ___
> > Sent via:Wireshark-dev mailing list 
> > Archives:https://www.wireshark.org/lists/wireshark-dev
> > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> >   mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
>
>

-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Windows build fails

[Dario Lombardo]

Hi
The github windows builder is failing

https://github.com/wireshark/wireshark/runs/4546222143?check_suite_focus=true

It started to show up around a couple of days ago, around commit
77b6bca3870d5ef63303e637cc39e2cf83f49ddc, as seen on

https://github.com/wireshark/wireshark/actions/workflows/windows.yml?query=branch%3Amaster

-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] How to troubleshoot extcap applications?

[Dario Lombardo]

I'm ok with this change. I can give you direct support for the extcaps I
wrote (sshdump/ciscodump, udpdump, randpktdump), and do my best with the
others.

On Wed, Dec 1, 2021 at 2:18 PM Jirka Novak  wrote:

> Hi,
>
>   I noticed issue below and I propose a solution for it. Can I ask for
> comments?
>
>   Every extcap tool has --debug and --debug-file options, but when they
> are used, it do "nothing". File is created, but it is empty.
>   Later I found that it must be used with --log-level=debug to really
> log messages.
>   The issue is that when you increase --log-level, it logs to console
> (STDERR). So when extcap is started from Wireshark, it mixes log output
> with packet data and wireshark gets confused and I found no way how to
> make it operational.
>   In other words you can't use debug of extcap from Wireshark.
>
>   In code I found that the reason is that wsutils/wscode.c writes every
> message to STDERR. If application registers additional file, it is
> copied to it too, but output to STDERR is made in every case.
>   Applications can replace default writer to STDERR, but no extcap do it.
>
>   My proposal is to modify extcap/extcap-base.c:
> 1) When --debug is used, set log level to debug so you don't have to add
> --log-level
> 2) If --log-file used, register custom log writer with
> ws_log_init_with_writer() which will discard all messages so just write
> to file will be made.
> 3) Update log init in every extcap
>
>   Change is quite simple, but involves all extcaps. I already tested it
> and it works. I'm just not sure every extcap.
>   I'm ready to prepare patch.
>
> Best regards,
>
> Jirka
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
>


-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Triggering "Windows Build" job

[Dario Lombardo]

On Mon, Sep 13, 2021 at 7:39 PM Gerald Combs  wrote:

> How long does the GitHub action take to run?


According to the jobs history, it takes 25 to 30 minutes, which looks
comparable to the wireshark's builds for windows on gitlab.
It usually gets scheduled very quickly, which does not happen in all CI
free platforms.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Triggering "Windows Build" job

[Dario Lombardo]

You can also leverage github actions: it has a windows build. Just push on
a github fork of yours and you'll trigger a windows build.

https://github.com/wireshark/wireshark/actions/workflows/windows.yml

On Mon, Sep 13, 2021 at 2:48 PM Ivan Nardi  wrote:

> Hi Roland
> I thought that the present configuration was a trade-off between
> flexibility and resource constraints.
> Thank you very much for the suggestions, very appreciated! I will
> definitely compile Wireshark with both gcc and clang from now on.
>
> Thanks for your reply
> Kind regards
>
>
> Ivan
>
> On Mon, 13 Sept 2021 at 11:24, Roland Knall  wrote:
> >
> > Hi Ivan
> >
> > We have a limited number of machines for our build-jobs. Therefore only
> when we set the merge-request to a semi-done level, buildjobs are
> triggered. What you can do though, is run your own pipeline, and use our
> .gitlab-ci.yml file as a template.
> >
> > At this point we do not plan on making the builders available to
> everyone. But if you submit your changes, we can trigger it for you.
> >
> > Btw, as a Mac & Linux user myself, I keep a virtualbox around just for
> that purpose. To be able to build Wireshark. It is not required, but
> certainly helps. Also, building Wireshark on your local Linux machine with
> a clang compiler instead of gcc, will also identify most issues with the
> Microsoft VS compilers (as was my experience in the past)
> >
> > kind regards
> > Roland
> >
> > Am Mo., 13. Sept. 2021 um 11:17 Uhr schrieb Ivan Nardi <
> nardi.i...@gmail.com>:
> >>
> >> Hi
> >>
> >> If I am not wrong, the "Windows Build" job is triggered only after a
> >> maintainer picks up the MR and assigns it to the "Wireshark GitLab
> >> Utility".
> >> Is there any way I can trigger it myself?
> >>
> >> Some background.
> >> I don't have a Windows machine to build Wireshark myself.
> >> My last MR (
> https://gitlab.com/wireshark/wireshark/-/merge_requests/3628)
> >> triggers a warning only in the Windows build.
> >> I **think** to have a fix for it. I could push it, wait for a
> >> maintainer to pick it up again and cross my fingers...
> >> But if I could trigger the Windows test myself it should be less a
> >> bother to anyone.
> >> Can I do that somehow?
> >>
> >> I hope I made myself clear
> >> Thanks
> >>
> >> Ivan
> >>
> ___
> >> Sent via:Wireshark-dev mailing list 
> >> Archives:https://www.wireshark.org/lists/wireshark-dev
> >> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> >>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
> >
> >
> ___
> > Sent via:Wireshark-dev mailing list 
> > Archives:https://www.wireshark.org/lists/wireshark-dev
> > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> >  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
>


-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Builders & decryption on ubuntu 20.04

[Dario Lombardo]

Hi
I've set up a builder on github workflows using their ubuntu-latest (20.04)
image.
The builds regularly fail because of a missing decryption. Example:

https://github.com/crondaemon/wireshark/runs/3491926537?check_suite_focus=true

However my local Ubuntu 20.04 works fine. I've compared the crypto libs and
basically they look to use the same versions.
Any idea on what's going on?
Dario.

-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Siemens S7Comm-Plus protocol support

[Dario Lombardo]

>
>
> You could:
>
> go to the code tab at
> https://sourceforge.net/p/s7commwireshark/code/HEAD/tree/;
>
> clone the repository;
>
> download the Wireshark 3.4.7 source, so the Wireshark header files
> are available, if you haven't done so already;
>
> run the tools/macos-setup.sh script in the Wireshark source tree,
> so the header files for the support libraries are available, if you haven't
> done so already;
>
> make sure you have Xcode installed;
>
> build it;
>
> install it in the appropriate directory;
>
> but we don't have a tutorial on doing that, so you'd have to figure it out
> yourself or keep asking questions.
>
>
Another semi-automated way, without setting up a local build system is:
- fork the github wireshark repo (github.com/wireshark/wireshark)
- clone locally, create a new branch, manually incorporate the dissector,
push the new branch
- the github workflow for macos compiles the branch including the dissector
and creates binary distribution for it.
IT *should* give you a working mac bin package, despite I've never tested
it. However if it works, it gives you a dmg without the hassle of a local
build env.
Examples: https://github.com/wireshark/wireshark/actions/workflows/macos.yml
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] I'm broken on the inside, please somebody fix me...

[Dario Lombardo]

(Not talking about me... ;)).
That's the message I'm getting by Wireshark Gitlab Utilily in
https://gitlab.com/wireshark/wireshark/-/merge_requests/3544
I have approved the MR and assigned it to the bot, and would have expected
the change to be rebased and merged. Am I missing something or is the bot
true when it says it's broken on the inside?

-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Qt link errors (Q_INIT_RESOURCE)

[Dario Lombardo]

Hi, Martin
Did you try to bisect?

On Tue, Mar 30, 2021 at 11:16 AM Martin Mathieson via Wireshark-dev <
wireshark-dev@wireshark.org> wrote:

> I started getting this link error a day or 2 back:
>
> [ 98%] Linking CXX executable run/wireshark
> /usr/lib64/gcc/x86_64-suse-linux/8/../../../../x86_64-suse-linux/bin/ld:
> ui/qt/CMakeFiles/qtui.dir/wireshark_application.cpp.o: in function
> `WiresharkApplication::WiresharkApplication(int&, char**)':
> /home/martin/wireshark_gl/ui/qt/wireshark_application.cpp:639: undefined
> reference to `qInitResources_about()'
> /usr/lib64/gcc/x86_64-suse-linux/8/../../../../x86_64-suse-linux/bin/ld:
> /home/martin/wireshark_gl/ui/qt/wireshark_application.cpp:640: undefined
> reference to `qInitResources_i18n()'
> /usr/lib64/gcc/x86_64-suse-linux/8/../../../../x86_64-suse-linux/bin/ld:
> /home/martin/wireshark_gl/ui/qt/wireshark_application.cpp:641: undefined
> reference to `qInitResources_layout()'
> /usr/lib64/gcc/x86_64-suse-linux/8/../../../../x86_64-suse-linux/bin/ld:
> /home/martin/wireshark_gl/ui/qt/wireshark_application.cpp:642: undefined
> reference to `qInitResources_stock_icons()'
> /usr/lib64/gcc/x86_64-suse-linux/8/../../../../x86_64-suse-linux/bin/ld:
> /home/martin/wireshark_gl/ui/qt/wireshark_application.cpp:643: undefined
> reference to `qInitResources_wsicon()'
> /usr/lib64/gcc/x86_64-suse-linux/8/../../../../x86_64-suse-linux/bin/ld:
> /home/martin/wireshark_gl/ui/qt/wireshark_application.cpp:644: undefined
> reference to `qInitResources_languages()'
> collect2: error: ld returned 1 exit status
>
> Haven't worked out exactly why this is happening (or at which commit it
> started to fail).  If I do need to update Qt, the minimum version check in
> CMake isn't catching it.
>
> Martin
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Improvments for NVMeOF dissector

[Dario Lombardo]

Hi Constantine
I know that sometimes working on a change without getting it merged soon
can be frustrating. Unfortunately it is as you just described: this is a
voluntary-based project where people donate their own time just for the
love of the project itself. And it is not "don't bother me, I just don't
have time", but instead "I am sorry I would like to have more time to spend
on it, but, you know, my employer asks me to work... :)". Straight to the
point: sometimes it took me MONTHS to have a single commit merged, despite
I am a core developer. Don't think that write access gives you a highway to
the codebase. With great powers come great responsibilities: in the core
team we also ask for other's consensus. That means that also with write
access, we need to discuss with others which changes are required on a MR.
And that could imply that weeks and sometimes months are required for the
review if the change is complex or the interest is low. Your only option
here is gently push and maybe someone will jump on it and move it forward.
Consider that the Wireshark community is pretty active and is rare that you
don't get feedback (maybe general, as in this case). Other open source
projects simply ignore any contribution. Then, please, hold on: every
contribution is valuable, but it may require time to be reviewed.

On Mon, Mar 29, 2021 at 5:38 PM Constantine Gavrilov 
wrote:

> I have waited for another week and nothing happens.
>
> This merge request (!2405) was created more than two weeks ago, and the
> people who have looked into it either lost interest or do not have time.
>
> I appreciate that everyone is so busy, but the same claim goes for
> contributors as well as developers.
>
> I am more busy than most people, and I have found time to contribute. I
> equally expect that someone finds time to look into this work. This is a
> reasonable expectation as long as the projects states that contributions
> are welcome. If every developer is so busy and there is no formal process
> to assign the contribution for review, or a measure of how many
> contributions were evaluated by people holding core developer status, while
> there is also a taste of coldness in communication -- "do not bother us, we
> are busy and  owe you  nothing", why shall I bother?
>
> I feel I have wasted my time. I have already explained that I have nothing
>  to gain from this. It was an act of gratitude to the project. But I do not
> want to feel that I have to push it down the project throat. As I have said
> there are many changes to improve NVMEoF dissector, and if there is no
> interest nor cooperation, I can easily continue in my local tree and it
> will serve my work just fine. This also means that these changes will never
> see public access.
>
> The same goes for MR 2522 and 2324. Regarding the last one, I simply fail
> to grasp what is the problem there. Typically, build problems are solved
> within minutes (like a recent problem building on MAC). Since the change is
> so trivial, and beta builds of Fedora with gcc-11 are out, while the
> release is imminent, I do not understand why it has not been merged.
> Perhaps the problem is that I have provided the patch and should have just
> opened the bug report like people did reporting the MAC build issue?
>
> So, I want to know what to do. Shall I close the merge requests and leave
> busy people alone with their busy affairs or perhaps we can work in the
> spirit of cooperation?
>
> Until this point, I have contributed above 3k lines of code, where 800
> lines are in the tree, and 2.2K lines are stuck in the review.  If this is
> not a significant contribution, I do not know what is. I understand
> responsibility and would not whine about lack of time (despite being very
> busy) if I had core developer access. Your call, core developers. Can we
> collaborate, or you are so busy that collaboration is not possible?
>
>
> --
> 
> Constantine Gavrilov
> Storage Architect
> Master Inventor
> Tel-Aviv Storage Lab IDT Lead
> Tel-Aviv IBM Storage Lab
> 1 Azrieli Center, Tel-Aviv
> 
>
>
>
> From:Constantine Gavrilov/Israel/IBM
> To:Developer support list for Wireshark <
> wireshark-dev@wireshark.org>
> Date:03/21/2021 05:37 PM
> Subject:Re: [EXTERNAL] Re: [Wireshark-dev] Improvments for NVMeOF
> dissector
> --
>
>
> Pascal, thank you.
>
> > You should accommodate the project, and not the other way around.
>
> I have never assumed otherwise, just tried to reach out...
>
> I will wait until the end of the week and see what happens...
>
>
> --
> 
> Constantine Gavrilov
> Storage Architect
> Master Inventor
> Tel-Aviv Storage Lab IDT Lead
> Tel-Aviv IBM Storage Lab
> 1 Azrieli Center, Tel-Aviv
> 
>
>
>
> 

Re: [Wireshark-dev] tvb_get_nstringz0

[Dario Lombardo]

Hi, John, thanks for the follow-up. I have used gdb but I didn't hit any
failed assertion. I will file a bug with the test sample and reference you
in it so you can have a clearer view of what's going on.

On Sun, Mar 28, 2021 at 1:33 AM John Thacker  wrote:

>
> On Sat, Mar 27, 2021 at 2:57 PM Dario Lombardo  wrote:
>
>> Hi John,
>> thanks, your explanation helped a lot. However I still don't get why the
>> code crashes. Please let me use the actual buffer sizes since the ones I
>> told before were examples. The packet is 49, the local buffer is 15.
>>
>> When you call tvb_get_nstringz0() you pass in bufsize = 15.
>>> tvb_get_nstringz0() calls _tvb_get_nstringz()
>>> check_offset_len() runs to the end of the packet, setting len to 49.
>>> Since len >= bufsize, it sets limit = bufsize.
>>> stringlen = tvb_strnlen(tvb, abs_offset, limit - 1) looks at the first 9
>>> bytes, doesn't find a NUL, returns -1
>>>
>>
>> That's a point I don't get. This piece of code (stringlen =
>> tvb_strnlen(tvb, 0, 14)) actually returns 49. Despite the fact that NULL is
>> present or not, shouldn't this function fulfill the (limit - 1)? Shouldn't
>> that return 14 at most?
>>
>>
>>> stringlen is -1, tvb_memcpy copies over limit (10) bytes into buffer
>>> from tvb, bytes_copies is set to 10, _tvb_get_nstringz() returns -1.
>>>
>>
>> That's where things start to get hairy: stringlen is 49, then the actual
>> copy starts against buffer, that is only 15 bytes long. Crash.
>>
>
> Huh, that's odd. I just added some lines to packet-http.c near the top of
> dissect_http_tcp() like so:
>
> guint bufsize = 19;
> guint8 buffer[19];
> tvb_get_nstringz0(tvb, 0, bufsize, buffer);
>
> And stepped through with gdb after setting a breakpoint and opening a file
> with a ~480 byte HTTP packet with no nulls in the HTTP layer:
>
> 3578 stringlen = tvb_strnlen(tvb, abs_offset, limit - 1);
> (gdb) print limit -1
> $12 = 18
> (gdb) n
> 3580 if (stringlen == -1) {
> (gdb) print stringlen
> $14 = -1
> (gdb) print tvb->length
> $15 = 479
>
> And all proceeds as expected.
>
> tvb_strnlen(tvb, offset, maxlength) is supposed to return -1 if
> 'maxlength' (here, 14) is reached before a NULL.
>
> Let's see, tvb_strnlen calls tvb_find_guint8(tvb, abs_offset,
> maxlength=14, 0), and returns -1 if and only if tvb_find_guint8(...)
> returns -1. That looks right, so let's look at tvb_find_guint8():
>
> DISSECTOR_ASSERT(tvb && tvb->initialized);
>
> exception = compute_offset_and_remaining(tvb, offset, _offset,
> );
> if (exception)
> THROW(exception);
>
> /* Only search to end of tvbuff, w/o throwing exception. */
> if (maxlength >= 0 && limit > (guint) maxlength) {
> /* Maximum length doesn't go past end of tvbuff; search
>to that value. */
> limit = (guint) maxlength;
> }
>
> Have you tried stepping through it with a debugger? The code looks right
> to me and runs correctly over here. Are you perhaps somehow hitting an
> exception or a failed assertion?
>
> John
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] tvb_get_nstringz0

[Dario Lombardo]

Hi John,
thanks, your explanation helped a lot. However I still don't get why the
code crashes. Please let me use the actual buffer sizes since the ones I
told before were examples. The packet is 49, the local buffer is 15.

When you call tvb_get_nstringz0() you pass in bufsize = 15.
> tvb_get_nstringz0() calls _tvb_get_nstringz()
> check_offset_len() runs to the end of the packet, setting len to 49.
> Since len >= bufsize, it sets limit = bufsize.
> stringlen = tvb_strnlen(tvb, abs_offset, limit - 1) looks at the first 9
> bytes, doesn't find a NUL, returns -1
>

That's a point I don't get. This piece of code (stringlen =
tvb_strnlen(tvb, 0, 14)) actually returns 49. Despite the fact that NULL is
present or not, shouldn't this function fulfill the (limit - 1)? Shouldn't
that return 14 at most?


> stringlen is -1, tvb_memcpy copies over limit (10) bytes into buffer from
> tvb, bytes_copies is set to 10, _tvb_get_nstringz() returns -1.
>

That's where things start to get hairy: stringlen is 49, then the actual
copy starts against buffer, that is only 15 bytes long. Crash.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] tvb_get_nstringz0

[Dario Lombardo]

Hi,
I am a bit puzzled by the use of tvb_get_nstringz0. Let's say I have a
packet 100 bytes long, that does NOT contain NUL. I call tvb_get_nstringz0
with a buffer 10 bytes long.
For what I can see, the function will seek the packet for NUL, stopping at
the end of the packet, copying the result into the buffer. But the buffer
is too short, resulting in a crash.
What's the error here? How is the caller sure their call won't be invalid?
Should they always pass a long-enough buffer? Was the call to this function
wrong in the first place?
Thanks.
Dario.

-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Revive the happy-shark repository?

[Dario Lombardo]

Talking about your options:
1) my concern here is that we would have 2 repos, with parallel lifecycles,
that are not enforced to stay aligned. A change in a dissector would
benefit from a test case, but such a testcase in happy-shark would be
proposed after the code merge in the main repo. That would slow down the
process, wouldn't it?
2) this is the current situation. Ideal in the sense that a change carries
the code and the testcase. Suboptimal because as soon as the
testcases grow, the repo gets too heavy, as you said.

If the concern is not to make the repo too heavy we may investigate other
options as well.
1) use git submodules
2) use git lfs
Option 2 sounds promising: "Git Large File Storage (LFS) replaces large
files such as audio samples, videos, datasets, and graphics with text
pointers inside Git". We do have a dataset. Moreover gitlab.com supports
LFS.
Unfortunately I don't have direct experience with either submodules and
lfs, hence I cannot provide more than just raw ideas.

On Fri, Jan 22, 2021 at 6:25 PM Gerald Combs  wrote:

> Hi all,
>
> Years ago we added a repository for dissector regression tests at
> https://github.com/wireshark/happy-shark. Unfortunately it hasn't
> received much attention, and instead we've been adding dissector tests in
> the main repository. Should we
>
> - Import happy-shark into GitLab and move our current dissector tests
> there?
>
> - Retire happy-shark and do all of our testing in the main repository?
>
> - Something else?
>
> I'm leaning toward the first option for the simple reason that it will
> minimize the number of files we accrue in test/captures.
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] git doesn't like me anymore

[Dario Lombardo]

Hi Fulko
Git can look really confusing at the beginning especially for people with
long time experience on other code revision systems such as SVN (as it was
for me).
There are 2 things to take into account.
The first one is git itself. That includes commands such as commit, push,
pull, remote etc. That's the most technical part. There are a bunch of
online crash courses you can find. I'd suggest code school's. It is short
and has 2 parts: basic and advanced. You should watch the videos from both,
since advanced is not really out-of-scope.
The second one is the so-called "fork workflow". This is the workflow that
is used on github, gitlab, bitbucket and so on that is the popular model in
which people fork (aka create a copy) of a public repo, make changes on
their repo (so-called downstream) and then request a merge (merge request
or pull request) on the original repo (so-called upstream). You can find a
bunch of tutorials on this workflow, like
https://www.atlassian.com/git/tutorials/comparing-workflows/forking-workflow.
This is less technical than the above point but is much more logical: if
you don't understand the workflow, you will get lost. If you read a manual
of "straight git" you will get lost.
My personal experience: steep learning curve, then a lot satisfactory.
I Hope it helps.
Dario.


On Mon, Jan 18, 2021 at 12:44 AM Fulko Hew  wrote:

>
> The subject line says it all, but it doesn't say why.
> git and I just don't seem to understand one another.
>
> I've made a new dissector, and I went through the whole process
> to clone the repo, add/change my stuff, resync it, and submit
> my merge request.  Now the approver(s) asked for some changes,
> and although I disagreed with the need for the last one, I've
> now made that enhancement too, and want to commit it and have
> it merged.
>
> But now after doing the 'git commit -a', the instructions say
> I need to do 'git push downstream HEAD', but that returns the
> error messages:
>
> fatal: 'downstream' does not appear to be a git repository
> fatal: Could not read from remote repository.
>
> Please make sure you have the correct access rights
> and the repository exists.
>
>
> I'll admit, I don't understand git, let alone how to use it,
> so I need help on what I need to do to get past this issue.
>
> Thanks
> Fulko
>
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Setcap in ubuntu 20.04

[Dario Lombardo]

Another user on SO suggested a fix

https://stackoverflow.com/questions/58255970/wireshark-dumpcap-with-setcap-set-to-no-root-capture-failes-to-start-in-ubuntu-1

However I'm pretty sure I've run wireshark from the build dir before with
setcap.

On Wed, Jan 6, 2021 at 9:20 PM Dario Lombardo  wrote:

> Hi
> I got a new laptop and I took the chance to upgrade my OS. Now I have
> Ubuntu 20.04. Today I had an unexpected behavior. After compilation, I
> issued the setcap command, but then I got:
>
> $ sudo setcap cap_net_raw,cap_net_admin=eip run/dumpcap
> $ ./run/dumpcap -D
> ./run/dumpcap: error while loading shared libraries: libwsutil.so.0:
> cannot open shared object file: No such file or directory
>
> Removing the capabilities gave my dumpcap back.
>
> $ sudo setcap -r run/dumpcap
> $ ./run/dumpcap -D
> 1. wlp59s0
> 2. nlmon0
> 3. lo (Loopback)
> [...]
>
> Another user from ask, hit the same problem, like 1 year ago, on ubuntu
> 18:
> https://ask.wireshark.org/question/12115/wireshark-dumpcap-with-setcap-set-to-no-root-capture-failes-to-start-in-ubuntu-1810/
> I'm still trying to figure out if I made other configurations before, but
> I can't recall anything useful.
> Any ideas?
> Thanks.
> Dario.
> --
>
> Naima is on the broom.
>
>

-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Setcap in ubuntu 20.04

[Dario Lombardo]

Hi
I got a new laptop and I took the chance to upgrade my OS. Now I have
Ubuntu 20.04. Today I had an unexpected behavior. After compilation, I
issued the setcap command, but then I got:

$ sudo setcap cap_net_raw,cap_net_admin=eip run/dumpcap
$ ./run/dumpcap -D
./run/dumpcap: error while loading shared libraries: libwsutil.so.0: cannot
open shared object file: No such file or directory

Removing the capabilities gave my dumpcap back.

$ sudo setcap -r run/dumpcap
$ ./run/dumpcap -D
1. wlp59s0
2. nlmon0
3. lo (Loopback)
[...]

Another user from ask, hit the same problem, like 1 year ago, on ubuntu 18:
https://ask.wireshark.org/question/12115/wireshark-dumpcap-with-setcap-set-to-no-root-capture-failes-to-start-in-ubuntu-1810/
I'm still trying to figure out if I made other configurations before, but I
can't recall anything useful.
Any ideas?
Thanks.
Dario.
-- 

Naima is on the broom.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Assigned reviewers

[Dario Lombardo]

>
>
>> Do you mean assignee? I guess so, but I'd like to clear it, since the
>> reviewer and assignee were separate in Gerrit.
>>
>
> No I really meant reviewer as I was considering the assignee as the person
> that will ultimately schedule the merge. You can have more than one
> reviewer. But I'm open to any workflow we might define.
>
> Oh, I missed it. I always forget that gitlab.com runs gitlab EE, while I
am more used to gitlab CE, which sometimes has less features.
It was introduced in 13.5, enabled by default in 13.7:
https://docs.gitlab.com/ee/user/project/merge_requests/getting_started#reviewer
Good to know, I'll use it to ask for reviews, thanks.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Assigned reviewers

[Dario Lombardo]

On Wed, Jan 6, 2021 at 9:38 AM Pascal Quantin  wrote:

> Hi Jonathan,
>
> Le mer. 6 janv. 2021 à 05:39, Jonathan Nieder  a
> écrit :
>
>> Hi wiresharks,
>>
>> Context:
>> https://gitlab.com/wireshark/wireshark/-/merge_requests/1313#note_478706594
>>
>> In Gerrit times, a person could add someone as a reviewer to a change
>> to request review, the reviewer could remove themselves if they were
>> unavailable, and so on.  What is the equivalent in the GitLab world?
>> More concretely:
>>
>> - when a change is ready to review, how do I say so?
>>
>
> All opened threads are resolved and the submitter can add a comment to
> ping us. A reviewer can be explicitly added in the right column of the
> Gitlab GUI
>

Do you mean assignee? I guess so, but I'd like to clear it, since the
reviewer and assignee were separate in Gerrit.


>
> - if a review seems to be stalled, what's the best place to poke?
>>
>
> Writing a comment in the MR; we are almost all volunteers doing this on
> our spare time so sometimes real life collides and a given change can get
> out of the radar
>
> - if I would like to review a change, how should I signal interest?
>>
>
> Everybody is free to put comments in a MR
>
> - what happens when a change has been approved and it is time to merge
>>   it?  Where can I read about the bot that does that?
>>
>
> One of the core developer approves the change and schedules it for merge
>
>
The Core devels are able to rebase and merge a MR. However the race for
merge with other MRs could make the merge harder. That's why we can assign
the MR to the bot that automatically rebases the change until the merge
actually happens. But it's not a must.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] tpdu_data missing in gtp packet

[Dario Lombardo]

On Thu, Dec 24, 2020 at 9:29 AM Pascal Quantin  wrote:

>
>
> Le jeu. 24 déc. 2020 à 09:16, Dario Lombardo  a écrit :
>
>> Can you please tell a version in which is present and a version in which
>> is not?
>>
>
> And please clarify your GTP setting regarding the T-PDU dissection.
>
> Actually a full bug report on gitlab would work better. Please add as many
infos as you have.

https://gitlab.com/wireshark/wireshark/-/issues
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] tpdu_data missing in gtp packet

[Dario Lombardo]

Can you please tell a version in which is present and a version in which is
not?

On Thu, Dec 24, 2020 at 8:54 AM Ranjeet kumar singh 
wrote:

> Hi
>
> Gtp packets used to have a tpdu_data field.
>
> I don't see it in the latest wireshark.
>
> This is causing my lua plugins to break.
>
> Can someone please fix it.
>
> Regards
> Ranjeet S
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] How to properly finalize capture in a Wireshark extcap plugin?

[Dario Lombardo]

Indeed the used signal to terminate the extcap is SIGTERM.
Is your signal handler called? Did you run a debugger to see which signal
is interrupting your code?
Did you try your code on unix?

On Mon, Nov 23, 2020 at 10:31 AM Timmy Brolin  wrote:

> I am writing a extcap plugin for Wireshark (Windows version). The
> documentation on how Wireshark stops a extcap capture is a bit sketchy, but
> it seems it simply terminates the extcap plugin.
>
> If I run the extcap binary standalone, and stops it with Ctrl+C,
> everything works as expected. The written pcapng file contains all blocks.
> But when Wireshark runs the extcap binary, the last block, the "interface
> statistics block", never shows up in the Wireshark capture.
>
> Is this a bug in Wireshark? Does Wireshark ignore any additional blocks in
> the pcapng fifo after it has sent the signal to kill the extcap binary?
>
> The essential parts of the extcap plugin looks like this:
>
>
>
> static volatile int keepRunning = 1;
>
> void intHandler(int dummy) {
>
> keepRunning = 0;
>
> }
>
>
>
> int main(int argc, char *argv[])
>
> {
>
>... Parse arguments ...
>
>
>
>fp = fopen (pcOutputFilename, "wb");
>
>fwrite( , sizeof(sSHB), 1, fp ); // write section header block to 
> pcapng file.
>
>fwrite( , sizeof(sIDB), 1, fp ); // write interface description block 
> to pcapng file.
>
>
>
>signal(SIGINT, intHandler);
>
>signal(SIGTERM, intHandler);
>
>
>
>do{
>
>   ... Capture frames and write to fp ...
>
>}
>
>while( keepRunning );
>
>
>
>fwrite( , sizeof(sISB), 1, fp ); // write interface statistics block 
> to pcapng file.
>
>
>
>fclose(fp);
>
> }
>
>
>
>
>
>
>
> Regards,
>
> Timmy Brolin
>
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Windows update on development version

[Dario Lombardo]

Hi,
I'm not that used to builds on windows, then maybe what happened is
perfectly normal.
I fired up a dev version of wireshark and suddenly wireshark asked me if I
wanted to update to a newer version. I have no idea of what would have
happened if I accepted.
Shouldn't updates be disabled on builded versions? That is what I would
expect. Or is it normal?
Thanks.
Dario.

-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Introduction - An Outreachy 2020 Applicant

[Dario Lombardo]

I'd suggest moving forward with the sequence a/c/b. IMO this gives a
growing difficulty that allows a soft approach with the code base. If I'm
not missing anything, (a) involves adding expert infos, that is one of the
easiest tasks in wireshark. On the other hand (c) involves pytest, which I
found a bit tricky to develop myself.

On Fri, Oct 16, 2020 at 5:05 AM Jonathan Nieder  wrote:

> Hi Amanda,
>
> Amanda Shafack wrote:
>
> > Also, regarding my initial starter contribution, I chose the
> > "micro-project" titled "Avoid pipes in git related commands in test
> > scripts" (source https://bit.ly/3iZQcT2).
>
> Thanks, sounds good.
>
> > I plan to complete the micro-project and then move on to more research
> > on Git's HTTP protocol and other resources you've pointed out.
> >
> > Let me know your thoughts on this, thanks.
>
> I think that a good next step after the Git micro-project is to get to
> know wireshark --- this would involve building wireshark, finding
> something to change, and then changing it.
>
> https://gitlab.com/wireshark/wireshark/-/wikis/Development/ describes
> how to download and build wireshark.  Then for something to change, I
> have a few different ideas:
>
> a. tighten the error handling in epan/dissectors/packet-git.c
>(for example, what happens when there are not exactly 4 hexdigits
>at the beginning of a pkt-line?).  Git's
>Documentation/technical/protocol-common.txt describes the pkt-line
>format and Documentation/technical/pack-protocol.txt describes the
>Git transport dissected by packet-git.
>
> b. add tests for the Git dissector.  test/README.test and the page it
>links to describe how wireshark's tests work
>
> c. try to parse out the service name and protocol version in
>epan/dissectors/packet-git.c.  Git's
>Documentation/technical/protocol-v2.txt describes where we can find
>that information
>
> That would get us more comfortable with the wireshark codebase and
> would help prepare for fleshing out a plan for the internship.
>
> Thoughts?
>
> Sincerely,
> Jonathan
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] How to remove uploaded file on wiki page?

[Dario Lombardo]

No, as far as I know. When you upload a file, you're given a link with some
sort of hash that points to the file. The link you create is
[myfile](blablahash1). If you upload a newer version of that file, and
replace the link with [myfile](blablahash2), the effect is to have a new
version of the file, but actually the old one is still there... forgotten.
If you google around you'll find many concerns about it, and I found it
annoying myself. What people usually do is to forget the old files until
they run out of space, then delete them from the disk.
If you find any different solution, please share.

On Thu, Oct 15, 2020 at 3:37 PM qiangxiong.huang 
wrote:

> Hi,
>
> I uploaded some captures on wiki page, such as
> (uploads/f41df2a5b4c029020ed83beb8b298644/protobuf_udp_addressbook.pcapng).
> But later, I found that there was something wrong with the capture and
> wanted to upload a new one. Is there any way to delete the uploaded capture
> file, or to override it with a new one?
>
> Regards
> Huang
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Apple VM for Gui testing

[Dario Lombardo]

On Thu, Oct 8, 2020 at 4:34 AM chuck c  wrote:

> Looking to build a Mac dev environment without paying the Apple hardware
> tax.
>
> Are there technical, moral, legal issues where this is a bad idea?
>
>
All of the above but moral, that is up to you. AFAIK macOS uses some kind
of signature to see if it's running on apple hardware. It has been cracked
in the past and you should be able to find some images (vmware/virtualbox)
out there. They're illegal, of course. I'm not an expert in the field:
anyone with better/more infos, please integrate.
There are a bunch of (paid) services that give you access to macOS VMs,
with graphics. It's an alternative to buy an actual pc, but they're not
cheap.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] fuzzshark friends missing

[Dario Lombardo]

Hi
I've started from scratch a build dir for oss-fuzz tests. I've run ninja
all-fuzzers, but the only fuzz target that gets compiled is fuzzshark,
while I would have expected to also get fuzzshark_ip and friends.
Looking at the git log I don't see anything obvious about changes in the
build process for those targets. What am I missing?

-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] pipeline failed at the Restore Cache step

[Dario Lombardo]

Your CI failed for trailing whitespaces.

$ bash ./tools/pre-commit 'HEAD^1'
epan/dissectors/packet-tcp.c:1351: trailing whitespace.
+
epan/dissectors/packet-tcp.c:1356: trailing whitespace.
+
epan/dissectors/packet-tcp.c:1362: trailing whitespace.
+
epan/dissectors/packet-tcp.c:1369: trailing whitespace.
+
epan/dissectors/packet-tcp.c:1388: trailing whitespace.
+
epan/dissectors/packet-tcp.c:1404: trailing whitespace.

Fix them, amend your commit, rebase on master, push force and the CI will
start again.

On Thu, Sep 10, 2020 at 9:57 AM Eugène Adell  wrote:

> Hi guys,
>
> My pipeline is in error ( branch 16716 Pipeline #188182176 ) and I
> don't know what to do.
>
> My branch which was first on Gerrit, I followed what is said in the
> doc to move it as a Merge Request and finally it asked for a Rebase,
> which I ran this morning and ended with this error.
>
> The error details :
> Restoring cache
> Checking cache for merge-request:ubuntu-dpkg-master...
> FATAL: file does not exist
> Failed to extract cache
>
> Did I miss anything ?
> Thanks for helping.
>
> Eugene
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Managing Gitlab Issues

[Dario Lombardo]

On Fri, Sep 4, 2020 at 1:12 PM Uli Heilmeier  wrote:

> Hi list,
>
> I’ve tried to update the instructions to report an issue (fka bug) in the
> wiki [1].
>
> There are some things we need to sort out. (Maybe this has already been
> done on the core list.)
>
> * Do we want to have labels to mark the status of an issue? With Bugzilla
> we had Confirmed, Incomplete, In Progress etc. I would like to have labels
> for status additionally to the existing labels.
>

Personally I don't like this. Labels are best to mark the issues as
belonging to a component, a version and so on. I don't see the need to
stick with gerrit's model, unless we really like it. Again, personally I
liked gerrit's labels, but I won't miss it, and I think that model can be
left behind.


>
> * Who should be able to edit issues (e.g. adding labels)? According to
> Gitlab documentation [2] the Reporter role can do it. However the Reporter
> role also allows to see issues which are marked as confidentially.
>

I'm not sure I got your point. Just a few people (not including the whole
core-dev group) have internal access to the project. Just Gerald and a few
have. Other code-devs are in a group allowed to merge, but they're not
project members. How would you leverage the confidentiality feature?


>
> * It would make sense to have templates for issues [3]. Has anyone already
> prepared this? Otherwise I will create one and submit a MR?
>

This would help for sure. Please submit a MR for that.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Winflexbison update in choco

[Dario Lombardo]

Other users are reporting an issue in the new version of the choco package.
Read the discussion on

https://chocolatey.org/packages/winflexbison3

I will try to downgrade the package version, until the package gets fixed.
It looks like the new version basically doesn't install. This isn't spotted
unless you install from scratch (that's what CIs do).

On Wed, Sep 2, 2020 at 3:00 PM Dario Lombardo  wrote:

> The build is actually done by the github actions builder. A brand new dir
> gets created every time.
>
>
> https://github.com/crondaemon/wireshark/actions?query=workflow%3A%22Build+Windows%22+branch%3Amaster
>
> On Wed, Sep 2, 2020 at 2:53 PM Graham Bloice 
> wrote:
>
>>
>> On Wed, 2 Sep 2020 at 13:43, Dario Lombardo  wrote:
>>
>>> Hi
>>> Some days ago (30th aug), the choco package winflexbison3 was updated.
>>> Since then, my cmake can't find the LEX_EXECUTABLE as well as the
>>> YACC_EXECUTABLE.
>>> Any idea on what happened?
>>> I've fixed the builds by setting LEX_ and YACC_EXECUTABLE in cmake, but
>>> I don't know whether this is the correct fix or not.
>>> Dario.
>>>
>>>
>> Either delete CMakeCache.txt (to discover all required libs etc. again),
>> or edit it to remove the invalid path references and then CMake will search
>> and find them again.
>>
>> --
>> Graham Bloice
>>
>> ___
>> Sent via:Wireshark-dev mailing list 
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>  mailto:wireshark-dev-requ...@wireshark.org
>> ?subject=unsubscribe
>
>
>
> --
>
> Naima is online.
>
>

-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Winflexbison update in choco

[Dario Lombardo]

The build is actually done by the github actions builder. A brand new dir
gets created every time.

https://github.com/crondaemon/wireshark/actions?query=workflow%3A%22Build+Windows%22+branch%3Amaster

On Wed, Sep 2, 2020 at 2:53 PM Graham Bloice 
wrote:

>
> On Wed, 2 Sep 2020 at 13:43, Dario Lombardo  wrote:
>
>> Hi
>> Some days ago (30th aug), the choco package winflexbison3 was updated.
>> Since then, my cmake can't find the LEX_EXECUTABLE as well as the
>> YACC_EXECUTABLE.
>> Any idea on what happened?
>> I've fixed the builds by setting LEX_ and YACC_EXECUTABLE in cmake, but I
>> don't know whether this is the correct fix or not.
>> Dario.
>>
>>
> Either delete CMakeCache.txt (to discover all required libs etc. again),
> or edit it to remove the invalid path references and then CMake will search
> and find them again.
>
> --
> Graham Bloice
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Winflexbison update in choco

[Dario Lombardo]

Hi
Some days ago (30th aug), the choco package winflexbison3 was updated.
Since then, my cmake can't find the LEX_EXECUTABLE as well as the
YACC_EXECUTABLE.
Any idea on what happened?
I've fixed the builds by setting LEX_ and YACC_EXECUTABLE in cmake, but I
don't know whether this is the correct fix or not.
Dario.

-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Add plugin timing statistics

[Dario Lombardo]

You could start by reading stats_tree documentation that tells you how
handle statistic using the stats_tree subsystem (based on tap, but more
evolved), by reading packet_info structure that stores info about lower
layer protocols, and by reading the DNS dissector (above others), that
creates stats that sound like the ones you need.

On Mon, Aug 31, 2020 at 5:21 PM  wrote:

> I would like advice on adding timing statistics to a Wireshark plugin. I
> have implemented a plugin for my company’s proprietary protocol, which sits
> on top of TCP/IP. I have added tap statistics to count various interesting
> pieces of data. I would now like to calculate the time it takes for the
> server to process commands.
>
>
>
> Looking at a general flow in my protocol, a command is sent (PSH, ACK) and
> an ACK occurs. Then later a (PSH, ACK) and an ACK occur for the response.
>
> If I take the response (PSH, ACK) timestamp and subtract the command ACK
> timestamp, I think this would be the best “how long did the server take to
> process” time.
>
> Do you have an idea of any better timing data I should consider?
>
>
>
> With a dissector, I can look at my protocol. How would I look at my
> packet’s TCP/IP protocol and get the timestamp?
>
>
>
> Then I would need to associate my command’s timestamp with a response
> timestamp. How might I do this? Using a tap? If so, how might I do this? I
> know that my activity flow is - command (PSH, ACK), command ACK, response
> (PSH, ACK), response ACK - so I know that if I’m in a command packet that
> the response timestamp I need is two packets ahead, sequentially, in its
> conversation. Are there calls to peek ahead?
>
>
>
> So, if you have suggestions on places within the documentation or code
> that I can study, please let me know.
>
>
>
> Thank you,
>
> Jay Turner
>
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Build error with packet-cipmotion.c ?

[Dario Lombardo]

I'm seeing the same thing on several builders. It definitely needs fixing.

On Sat, Aug 29, 2020, 21:53 Martin Mathieson via Wireshark-dev <
wireshark-dev@wireshark.org> wrote:

> I am seeing this error with current master:
>
> /home/martin/wireshark_gl/epan/dissectors/packet-cipmotion.c: In function
> ‘dissect_cipmotion3’:
> /home/martin/wireshark_gl/epan/dissectors/packet-cipmotion.c:2173:4:
> error: missing initializer for field ‘TransportClass_trigger’ of
> ‘cip_conn_info_t’ [-Werror=missing-field-initializers]
> cip_conn_info_t conn_info = {0};
> ^
> In file included from
> /home/martin/wireshark_gl/epan/dissectors/packet-cipmotion.h:15:0,
>  from
> /home/martin/wireshark_gl/epan/dissectors/packet-cipmotion.c:23:
> /home/martin/wireshark_gl/epan/dissectors/packet-cip.h:503:28: note:
> ‘TransportClass_trigger’ declared here
> guint8  TransportClass_trigger;
>
>
> cip_conn_info_t has 13 fields though (compiler above is complaining about
> the 2nd field).
> Am I missing something?
>
> Martin
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Pro tip, at least for Safari users - do not keep GitLab windows open and un-minimized any longer than necessary

[Dario Lombardo]

Gitlab runs a background javascript jobs that pulls the server for new
comments on a issue. This way they appear to your window as soon as they
have been created by a concurrent user. This gives a good user experience
and is easily seen in the browser debugger/network window. This could be
the reason why it eats up some memory/CPU, despite from your description it
seems too much.

On Wed, Aug 26, 2020, 08:43 Guy Harris  wrote:

> I have *NO* idea what the hell GitLab is doing, but, in Safari, if I have
> a GitLab window open and not minimized to the Dock, the Safari Networking
> process chews up about 1/3 of a core (~33% CPU) doing a ton of crap with
> cookies).  Minimizing the window to the Dock reduces the Safari Networking
> CPU usage to a low level, as does closing the window; de-minimizing the
> window causes it to fire up again.
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] GitLab migration update

[Dario Lombardo]

On Tue, Aug 25, 2020 at 12:56 PM Peter Wu  wrote:

>
> It looks like you have to delete the old stale fork relationship first,
> otherwise you will end up with a 409 Conflict error ("Project already
> forked").
>
> To automate fixing the fork status without requiring creation of an
> access token, I wrote a small script that can be executed from your web
> browser. See https://gitlab.com/wireshark/wireshark/-/issues/16806
>
>
My wireshark repo on gitlab is not a fork of the main one (I've created it
much earlier). Do you think the fork status can be forced on it as well?
Just out of curiosity, I've already re-forked.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] wiredifff: a diff tool for pcaps

[Dario Lombardo]

Good job, very interesting presentation!

On Mon, Jul 13, 2020 at 5:09 PM Aurélien Aptel  wrote:

> Hi,
>
> I've been working on and off on a tool that leverages wireshark (tshark)
> to do side-by-side diff of network captures.
>
> I've presented the tool at LCA 2020 and I have written an article for
> APNIC about it but I somehow didn't think of mentionning it here until
> today.
>
> LCA talk: https://www.youtube.com/watch?v=6yhKWq3-sr4
> APNIC article:
> https://blog.apnic.net/2020/07/01/wirediff-a-new-tool-to-diff-network-captures/
>
> wirediff repo: https://github.com/aaptel/qtwirediff
> smbcmp website: https://smbcmp.github.io/
>
> Cheers,
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Intermittent Builder Windows Petri Dish x64 failed (failed ctest) failures seriously annoying.

[Dario Lombardo]

You're right, it's not the test I pointed out. However it worked fine
before, then I would check the host to see if it's suffering.

On Thu, Jul 2, 2020 at 4:51 PM Graham Bloice 
wrote:

> The decryption test might need a bigger timeout, currently at 600 seconds:
>
> 9/34 Test  #3: suite_decryption ...***Timeout 630.47 sec
>
>
> On Thu, 2 Jul 2020 at 15:39, Anders Broman via Wireshark-dev <
> wireshark-dev@wireshark.org> wrote:
>
>> Hi,
>>
>> We have intermittent false petri dish failures. Can someone with insight
>> into the tests have a look?
>>
>> Best regards
>>
>> Anders
>>
>> Example Builder Windows Petri Dish x64 failed (failed ctest) -
>> http://buildbot.wireshark.org/petri-dish/builders/Windows%20Petri%20Dish%20x64/builds/11913
>>
>
> --
> Graham Bloice
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Intermittent Builder Windows Petri Dish x64 failed (failed ctest) failures seriously annoying.

[Dario Lombardo]

This looks to be the failing test

9: test_s_lt_2 (suite_dfilter.group_integer.case_integer) ... ok
 9/34 Test  #3: suite_decryption ...***Timeout 630.47 sec
test 12
  Start 12: suite_dfilter.group_membership

It fails for timeout. Looking at the code of the test itself it looks
very straight forward:

def test_s_lt_2(self, checkDFilterCount):
dfilter = "ntp.precision < 245"
checkDFilterCount(dfilter, 0)

Basically this test opens a file and checks that the number of
filtered packets is 0. Not a really hard test. Since the test fails
for timeout, and moreover intermittently, I would say that the builder
host is suffering. Can someone with shell access check if the host is
running fine?


On Thu, Jul 2, 2020 at 4:39 PM Anders Broman via Wireshark-dev <
wireshark-dev@wireshark.org> wrote:

> Hi,
>
> We have intermittent false petri dish failures. Can someone with insight
> into the tests have a look?
>
> Best regards
>
> Anders
>
> Example Builder Windows Petri Dish x64 failed (failed ctest) -
> http://buildbot.wireshark.org/petri-dish/builders/Windows%20Petri%20Dish%20x64/builds/11913
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] WSDG - errors in message reassembly documentation

[Dario Lombardo]

Hi Brett
You could
1) file a bug on bugzilla
2) push the change yourself on gerrit, since the wsdg is versioned as the
rest of the code.
(or both of course).

On Thu, Jun 25, 2020 at 4:04 PM Brett Hallen  wrote:

> Hello!
>
> I've got my first dissector up and running using the excellent
> documentation and help from the community. I'm now going to (try to) get
> re-assembly working on messages that our protocol fragments.
>
> However the documentation seems to have some small errors that could
> confuse the easily confused like me:
>
> https://www.wireshark.org/docs/wsdg_html_chunked/ChDissectReassemble.html
>
> The code fragment examples use a variable called msg_reassembly_table, but
> then later on it is initialised as reassembly_table (same as the datatype
> name), and then registered as msg_reassemble_table:
>
> static reassembly_table reassembly_table;
> static void
> proto_register_msg(void){
> reassembly_table_register(_reassemble_table,
> _ports_reassembly_table_functions);}
>
> Obviously (I think) it should be use the variable name
> msg_reassembly_table instead of assembly_table and msg_assemble_table?
>
> static reassembly_table *msg_*reassembly_table;
> static void
> proto_register_msg(void){
> reassembly_table_register(_reassembly_table,
> _ports_reassembly_table_functions);}
>
> Brett.
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Code discussion - Extcap help files on Windows

[Dario Lombardo]

Hi Chuck
There are no written rules for that, but basically the discussions take
place on gerrit when they are related to the code review itself. They are
moved or are started on -dev when they need more thoughts, more people or
simply when they become too long. Unless you have a working solution for
the issue, that you want to propose, I guess you are in the right place.

On Thu, Jun 18, 2020, 18:16 chuck c  wrote:

> I'm looking to answer two questions:
>  - where do these type discussions typically take place? Email? Code
> review comments?
>  - suggestions on how to fix the Extcap help on Windows.
>
> thanks
> chuck
>
> +++
> https://www.wireshark.org/docs/wsdg_html_chunked/ChCaptureExtcap.html
> -
> "There should only be extcap programs (executable, python scripts, …) in
> the extcap folder to reduce the startup time and not have Wireshark trying
> to execute other file types."
>
> There are two file locations for Extcap programs.
>
> https://code.wireshark.org/review/gitweb?p=wireshark.git;a=blob;f=ui/qt/about_dialog.cpp
>
> 
> /* Extcap */
> appendRow(QStringList() << tr("Personal Extcap path") <<
> QString(get_persconffile_path("extcap", FALSE)).trimmed() << tr("Extcap
> Plugins search path"));
> appendRow(QStringList() << tr("Global Extcap path") <<
> QString(get_extcap_dir()).trimmed() << tr("Extcap Plugins search path"));
>
> Do the help files for Personal Extcap programs go in the "Program"
> directory (C:\Program Files\Wireshark) along with the official release
> Extcap html files?
>
> In the real world all the pieces just get stuffed in the extcap folder:
>
> https://infocenter.nordicsemi.com/index.jsp?topic=%2Fug_sniffer_ble%2FUG%2Fsniffer_ble%2Finstalling_sniffer_plugin.html
>
>
> Currently when clicking the Help button in the Extcap GUI, it looks in the
> Extcap folder for the help file.
>
>
> https://code.wireshark.org/review/gitweb?p=wireshark.git;a=blob;f=extcap/sshdump.c
>
> --
> help_url = data_file_url("sshdump.html");   <--
> extcap_base_set_util_info(extcap_conf, argv[0], SSHDUMP_VERSION_MAJOR,
> SSHDUMP_VERSION_MINOR, SSHDUMP_VERSION_RELEASE, help_url);
> g_free(help_url);
>
>
>
> https://code.wireshark.org/review/gitweb?p=wireshark.git;a=blob;f=wsutil/filesystem.c
>
> -
> data_file_url(const gchar *filename)
> {
> gchar *file_path;
> gchar *uri;
>
> /* Absolute path? */
> if(g_path_is_absolute(filename)) {
> file_path = g_strdup(filename);
> } else {
> file_path = g_strdup_printf("%s/%s", get_datafile_dir(),
> filename);  <--
> }
> 
>
>
> /*
>  * On Windows, we use the directory in which the executable for this
>  * process resides.
>  */
>
> const char *
> get_datafile_dir(void)
> {
> if (datafile_dir != NULL)
> return datafile_dir;
>
> #ifdef _WIN32
> /*
>  * Do we have the pathname of the program?  If so, assume we're
>  * running an installed version of the program.  If we fail,
>  * we don't change "datafile_dir", and thus end up using the
>  * default.
>  *
>  * XXX - does NSIS put the installation directory into
>  * "\HKEY_LOCAL_MACHINE\SOFTWARE\Wireshark\InstallDir"?
>  * If so, perhaps we should read that from the registry,
>  * instead.
>  */
> if (progfile_dir != NULL) {
> /*
>  * Yes, we do; use that.
>  */
> datafile_dir = g_strdup(progfile_dir);  <--
> } else {
> /*
>  * No, we don't.
>  * Fall back on the default installation directory.
>  */
> datafile_dir = g_strdup("C:\\Program Files\\Wireshark\\");
> }
> #else
> 
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] git clone does not include latest commits

[Dario Lombardo]

On Sat, Jun 6, 2020 at 12:40 PM Pascal Quantin  wrote:

>
> The patch you are referring to is still under review and not merged yet.
> If you want to test it you need to apply it by yourself.
>
>
To do that, gerrit gives you some useful commands for copy Click on
the "download" item in the upper right corner. You will find: checkout,
cherry pick, format patch, pull and more.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] First patch submission (extcap install flags for silent mode)

[Dario Lombardo]

On Tue, May 12, 2020 at 10:10 AM Graham Bloice 
wrote:

> 3. The extcap help files on Windows are not found:
>> https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15592
>> Moving them to the same directory as the binaries would fix this.
>> Do in this patch or since it's a different bug make a different patch?
>>
>>
In a separate patch. But I don't think that moving the file is the right
way to fix it. Instead I'd see why the generated link and the actual
position don't match.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] macOS build broken

[Dario Lombardo]

n=32768 -Wno-nullability-completeness -Wc++-compat
>> -Wunused-const-variable -Wshadow -Wold-style-definition -Wstrict-prototypes
>> -Werror=implicit -Wno-pointer-sign -std=gnu99  -O2 -g -DNDEBUG -isysroot
>> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk
>> -mmacosx-version-min=10.14 -fPIC   -Werror -MD -MT
>> epan/dissectors/CMakeFiles/dissectors.dir/packet-kerberos.c.o -MF
>> epan/dissectors/CMakeFiles/dissectors.dir/packet-kerberos.c.o.d -o
>> epan/dissectors/CMakeFiles/dissectors.dir/packet-kerberos.c.o   -c
>> /Users/lojakab/src/wireshark-lisp/wireshark/epan/dissectors/packet-kerberos.c
>> > In file included from
>> ./asn1/kerberos/packet-kerberos-template.c:321:
>> >
>>  
>> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/Kerberos.framework/Headers/krb5.h:318:174:
>> error: expected ','
>> > krb5_boolean KRB5_CALLCONV krb5_is_referral_realm(const
>> krb5_data *) KERBEROS_APPLE_DEPRECATED("use GSS.framework")
>> __API_DEPRECATED("Use GSS.framework", macos(10.0, 10.8))
>> __API_UNAVAILABLE(macCatalyst);
>> >
>>
>>  ^
>> >
>>  
>> /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/Availability.h:479:171:
>> note: expanded from macro '__API_UNAVAILABLE'
>> > #define __API_UNAVAILABLE(...)
>> __API_UNAVAILABLE_GET_MACRO(__VA_ARGS__,__API_UNAVAILABLE6,__API_UNAVAILABLE5,__API_UNAVAILABLE4,__API_UNAVAILABLE3,__API_UNAVAILABLE2,__API_UNAVAILABLE1,
>> 0)(__VA_ARGS__)
>> >
>> > On Fri, Apr 24, 2020 at 4:33 PM Dario Lombardo <
>> lom...@gmail.com <mailto:lom...@gmail.com>> wrote:
>> >
>> > Hi,
>> > I was aware of such a problem. The travis macOS builder
>> got that while ago.
>> >
>> > https://travis-ci.org/github/crondaemon/wireshark
>> >
>> > I didn't bisect, but going back in build history, I
>> looks something between 2acbaf584984828855a36105258033020f338c5c
>> and d30a0a2ce7c17f5d695e9ee7647e92d3cc1156bb.
>> >
>> > On Fri, Apr 24, 2020 at 3:29 PM Lori Jakab <
>> lorand.ja...@gmail.com <mailto:lorand.ja...@gmail.com>> wrote:
>> >
>> > Hi,
>> >
>> > I'm have been building on macOS Mojave for a while
>> without issues, but for the last few days the build has been broken. I
>> didn't try a git dissect yet to see which commit broke it, but the issue
>> seems to be caused by the usage of the _Nonnull, _Nullable, or
>> _Null_unspecified type specifiers in the 6lowpan dissector.
>> >
>> > My compiler is:
>> >
>> > > gcc --version
>> > Configured with:
>> --prefix=/Applications/Xcode.app/Contents/Developer/usr
>> --with-gxx-include-dir=/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/4.2.1
>> > Apple clang version 11.0.0 (clang-1100.0.33.17)
>> > Target: x86_64-apple-darwin18.7.0
>> > Thread model: posix
>> > InstalledDir:
>> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
>> >
>> > This is the error:
>> >
>> > In file included from
>> /Users/lojakab/src/wireshark-lisp/wireshark/epan/dissectors/packet-6lowpan.c:19:
>> > In file included from
>> /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/stdio.h:64:
>> >
>>  
>> /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/_stdio.h:93:16:
>> error: pointer is missing a nullability type specifier
>> >   (_Nonnull, _Nullable, or _Null_unspecified)
>> [-Werror,-Wnullability-completeness]
>> > unsigned char   *_base;
>> > ^
>> >
>>  
>> /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/_stdio.h:93:16:
>> note: insert '_Nullable' if the pointer may be null
>> > unsigned char   *_base;
>> > ^
>> >   _Nullable
>> >
>> 

Re: [Wireshark-dev] macOS build broken

[Dario Lombardo]

Hi,
I was aware of such a problem. The travis macOS builder got that while ago.

https://travis-ci.org/github/crondaemon/wireshark

I didn't bisect, but going back in build history, I looks something
between 2acbaf584984828855a36105258033020f338c5c
and d30a0a2ce7c17f5d695e9ee7647e92d3cc1156bb.

On Fri, Apr 24, 2020 at 3:29 PM Lori Jakab  wrote:

> Hi,
>
> I'm have been building on macOS Mojave for a while without issues, but for
> the last few days the build has been broken. I didn't try a git dissect yet
> to see which commit broke it, but the issue seems to be caused by the usage
> of the _Nonnull, _Nullable, or _Null_unspecified type specifiers in
> the 6lowpan dissector.
>
> My compiler is:
>
> > gcc --version
> Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr
> --with-gxx-include-dir=/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/4.2.1
> Apple clang version 11.0.0 (clang-1100.0.33.17)
> Target: x86_64-apple-darwin18.7.0
> Thread model: posix
> InstalledDir:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
>
> This is the error:
>
> In file included from
> /Users/lojakab/src/wireshark-lisp/wireshark/epan/dissectors/packet-6lowpan.c:19:
> In file included from
> /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/stdio.h:64:
> /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/_stdio.h:93:16:
> error: pointer is missing a nullability type specifier
>   (_Nonnull, _Nullable, or _Null_unspecified)
> [-Werror,-Wnullability-completeness]
> unsigned char   *_base;
> ^
> /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/_stdio.h:93:16:
> note: insert '_Nullable' if the pointer may be null
> unsigned char   *_base;
> ^
>   _Nullable
> /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/_stdio.h:93:16:
> note: insert '_Nonnull' if the pointer should never be null
> unsigned char   *_base;
> ^
>   _Nonnull
> /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/_stdio.h:138:32:
> error: pointer is missing a nullability type specifier
>   (_Nonnull, _Nullable, or _Null_unspecified)
> [-Werror,-Wnullability-completeness]
> int (* _Nullable _read) (void *, char *, int);
>   ^
> /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/_stdio.h:138:32:
> note: insert '_Nullable' if the pointer may be null
> int (* _Nullable _read) (void *, char *, int);
>   ^
>_Nullable
> /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/_stdio.h:138:32:
> note: insert '_Nonnull' if the pointer should never be null
> int (* _Nullable _read) (void *, char *, int);
>   ^
>_Nonnull
> /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/_stdio.h:138:40:
> error: pointer is missing a nullability type specifier
>   (_Nonnull, _Nullable, or _Null_unspecified)
> [-Werror,-Wnullability-completeness]
> int (* _Nullable _read) (void *, char *, int);
>   ^
> /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/_stdio.h:138:40:
> note: insert '_Nullable' if the pointer may be null
> int (* _Nullable _read) (void *, char *, int);
>   ^
>_Nullable
> /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/_stdio.h:138:40:
> note: insert '_Nonnull' if the pointer should never be null
> int (* _Nullable _read) (void *, char *, int);
>   ^
>_Nonnull
> /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/_stdio.h:139:35:
> error: pointer is missing a nullability type specifier
>   (_Nonnull, _Nullable, or _Null_unspecified)
> [-Werror,-Wnullability-completeness]
> fpos_t  (* _Nullable _seek) (void *, fpos_t, int);
>   ^
> /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/_stdio.h:139:35:
> note: insert '_Nullable' if the pointer may be null
> fpos_t  (* _Nullable _seek) (void *, fpos_t, int);
>   ^
>_Nullable
> /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/_stdio.h:139:35:
> note: insert '_Nonnull' if the pointer should never be null
> fpos_t  (* _Nullable _seek) (void *, fpos_t, int);
>   ^
>  

Re: [Wireshark-dev] tshark: -e field output limitation

[Dario Lombardo]

Hi Martin
Unless anyone objects, I'd go with --preserve-layers. I suggested you this
way because tshark has so many short options that we've almost run out of
alphabet letters. I'd be very careful and conservative when eating up more
letters. Moreover -k is an option used by wireshark to run capture
immediately. tshark and wireshark don't have the same option set, but I'd
avoid to make them even more different by using overlapping options for
different features.
A long option that improves the use of -e to fit your use-case seems more
suitable to me.
If you'll take this way:
1) don't forget to update ALL docs. You've just updated tshark-h.txt, but
there are man pages, READMEs, etc. Do a full review of which docs need to
be updated
2) add the new option to the release notes: we need to inform the users
that a new option is available
3) be sure this option works for all the json-related formats: ek, json but
also jsonraw
4) add regression tests to cover your new option in all the 3 formats I
mentioned above.
Thanks for contributing and happy locked-down Easter Monday.
Dario.

On Sun, Apr 12, 2020 at 5:44 PM kacer martin  wrote:

> Dear all,
>
> there seems to be a limitation in current tshark fields output (-e
> switch). Currently there are not preserved protocol layers/hierarchy and
> the output fields are generated as flat structure. For simple protocols
> this behavior is ok, however for complex protocols it could result into
> ambiguous interpretation. (Additionally the current -e switch is not
> working together with -x switch (hex dump))
>
> Here is proposed filtering method for -T ek|json output to preserve
> protocol layers and the related discussion with examples:
> https://code.wireshark.org/review/#/c/36774/.
> It sounds reasonable to extend -e switch with --preserve-layers option.
> Your opinion on this would be very useful.
>
> Thank you and best regards
>
> Martin Kacer
>
>
>
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] GitLab migration update

[Dario Lombardo]

On Sun, Apr 5, 2020 at 11:57 PM Peter Wu  wrote:

> On Sun, Apr 05, 2020 at 01:10:37AM +0200, Dario Lombardo wrote:
> > However, I logged in in via github and then connected my google account,
> > but no projects show up. Maybe the project has been set up as "private"
> > (explicit allowance) instead of "internal" (implicit for logged users).
>
> The project is public, you can access it even when not logged in:
> https://gitlab-test.wireshark.org/wireshark/wireshark


Yes, but I guess we should be added as internal developers to the project.
This way the project will show up in my projects list and I will be able to
merge the MR (I'm talking about the regular operations).


>
>
> GitLab CI is not enabled however because no runners are configured.
> This is one downside of self-hosted GitLab, see
>
> https://gitlab.com/wireshark/gitlab-migration/-/wikis/SaaS-or-Self-Managed%3F


If we want to test the whole stack, without using more machines, the
gitlab-runner can be installed on the same machine as gitlab itself. Not
optimal, but functional.


>
> --
> Kind regards,
> Peter Wu
> https://lekensteyn.nl
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] GitLab migration update

[Dario Lombardo]

I get

 Signing in using your Google account without a pre-existing GitLab account
is not allowed. Create a GitLab account first, and then connect it to your
Google account.

I guess this is how gitlab works. I've never tried that before.
However, I logged in in via github and then connected my google account,
but no projects show up. Maybe the project has been set up as "private"
(explicit allowance) instead of "internal" (implicit for logged users).

On Sun, Apr 5, 2020 at 12:43 AM Gerald Combs  wrote:

> On 4/4/20 9:16 AM, Dario Lombardo wrote:
> > Hi Gerald
> > The test server allows me to log in with github and gitlab.com <
> http://gitlab.com> account. Gerrit allowed google account sso and
> gitlab.com <http://gitlab.com> itself allows that.
> > Is that wanted? Can we allow google login as well?
>
> I didn't add Google initially because it's non-trivial compared to GitLab
> and GitHub. It should be working now.
>


-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] GitLab migration update

[Dario Lombardo]

On Sat, Apr 4, 2020, 01:47 Gerald Combs  wrote:

>
> We also have a self-hosted test server up and running at
> https://gitlab-test.wireshark.org. Feel free to create an account, create
> merge requests, etc. If you'd like to try out a feature that requires a
> configuration change, let me know.
>

Hi Gerald
The test server allows me to log in with github and gitlab.com account.
Gerrit allowed google account sso and gitlab.com itself allows that.
Is that wanted? Can we allow google login as well?

>
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Regenerating moc files

[Dario Lombardo]

Hi,
is there a cmake target to unconditionally regenerate Qt moc files?
If I change something in the cmake defines, the target qtui_autogen doesn't
actually regenerate the moc files, giving me a compilation error. Otherwise
if I manually remove the moc dir ui/qt/qtui_autogen/ and recompile, goes ok.
Thanks.
Dario.

-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Build without LUA fails

[Dario Lombardo]

It worked. I'm pushing the fix.
Thanks you made my day ;).

On Fri, Mar 27, 2020 at 6:16 PM Pascal Quantin  wrote:

> Hi Dario,
> Le ven. 27 mars 2020 à 18:10, Dario Lombardo  a écrit :
>
>> On Thu, Mar 19, 2020 at 9:09 AM Pascal Quantin 
>> wrote:
>>
>>>
>>> Note that the previous patch was incomplete. Lines 103 and 108 must be
>>> changed also. See https://code.wireshark.org/review/#/c/36494/
>>>
>>>
>> Should have it fixed the compilation when lua is installed but disabled
>> through ENABLE_LUA=0?
>> I am in this configuration and the compilation fails.
>>
>
> No and the file I changed does not care about ENABLE_LUA that is handled
> in CMakeLists.txt. I guess in this file, wherever you have if (LUA_FOUND)
> you should replace it by if (LUA_FOUND AND ENABLE_LUA) and retest.
>
> Best regards,
> Pascal.
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Build without LUA fails

[Dario Lombardo]

On Thu, Mar 19, 2020 at 9:09 AM Pascal Quantin  wrote:

>
> Note that the previous patch was incomplete. Lines 103 and 108 must be
> changed also. See https://code.wireshark.org/review/#/c/36494/
>
>
Should have it fixed the compilation when lua is installed but disabled
through ENABLE_LUA=0?
I am in this configuration and the compilation fails.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Build failure (kerberos)

[Dario Lombardo]

Ok, this seems to work. I'm pushing the fix.

On Mon, Mar 23, 2020 at 9:29 AM Pascal Quantin  wrote:

>
>
> Le lun. 23 mars 2020 à 09:17, Dario Lombardo  a écrit :
>
>>
>>
>> On Sun, Mar 22, 2020 at 6:15 PM Dario Lombardo  wrote:
>>
>>> Ok, thanks.
>>>
>>> On Sun, Mar 22, 2020 at 9:48 AM Martin Mathieson <
>>> martin.r.mathie...@googlemail.com> wrote:
>>>
>>>>
>>>>>> ./asn1/kerberos/packet-kerberos-template.c: In function
>>>>>> ‘dissect_krb5_PAC_CREDENTIAL_INFO’:
>>>>>> ./asn1/kerberos/packet-kerberos-template.c:2187:2: error: implicit
>>>>>> declaration of function ‘decrypt_krb5_data’
>>>>>> [-Werror=implicit-function-declaration]
>>>>>> ./asn1/kerberos/packet-kerberos-template.c:2187:11: error: assignment
>>>>>> makes pointer from integer without a cast [-Werror]
>>>>>> ./asn1/kerberos/packet-kerberos-template.c: At top level:
>>>>>> ./asn1/kerberos/kerberos.cnf:360:1: error:
>>>>>> ‘dissect_kerberos_PA_ENC_TS_ENC’ defined but not used
>>>>>> [-Werror=unused-function]
>>>>>>
>>>>>>
>>> I don't know which part of the asn1/cnf/template generates this
>>> function. Can anyone guide me through the asn1 dissector generation
>>> process?
>>>
>>
>> I've found how to remove the definition of the function conditionally.
>> However the definition of
>>
>> static const ber_sequence_t PA_ENC_TS_ENC_sequence[]
>>
>> still remains unused, giving an error. Which part of the cnf generates
>> this definition?
>>
>
> Hi Dario,
>
> this is generated automatically unless you put PA-ENC-TS-ENC in the
> OMIT_ASSIGNMENT section.
> As asn2wrs.py does not support conditional generation AFAIK, better move
> it in the template file (together with its dependencies) and add it to the
> OMIT_ASSIGNMENT.
>
> Best regards,
> Pascal.
>
> --
>>
>> Naima is online.
>>
>>
>> ___
>> Sent via:Wireshark-dev mailing list 
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>  mailto:wireshark-dev-requ...@wireshark.org
>> ?subject=unsubscribe
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Build failure (kerberos)

[Dario Lombardo]

On Sun, Mar 22, 2020 at 6:15 PM Dario Lombardo  wrote:

> Ok, thanks.
>
> On Sun, Mar 22, 2020 at 9:48 AM Martin Mathieson <
> martin.r.mathie...@googlemail.com> wrote:
>
>>
>>>> ./asn1/kerberos/packet-kerberos-template.c: In function
>>>> ‘dissect_krb5_PAC_CREDENTIAL_INFO’:
>>>> ./asn1/kerberos/packet-kerberos-template.c:2187:2: error: implicit
>>>> declaration of function ‘decrypt_krb5_data’
>>>> [-Werror=implicit-function-declaration]
>>>> ./asn1/kerberos/packet-kerberos-template.c:2187:11: error: assignment
>>>> makes pointer from integer without a cast [-Werror]
>>>> ./asn1/kerberos/packet-kerberos-template.c: At top level:
>>>> ./asn1/kerberos/kerberos.cnf:360:1: error:
>>>> ‘dissect_kerberos_PA_ENC_TS_ENC’ defined but not used
>>>> [-Werror=unused-function]
>>>>
>>>>
> I don't know which part of the asn1/cnf/template generates this function.
> Can anyone guide me through the asn1 dissector generation process?
>

I've found how to remove the definition of the function conditionally.
However the definition of

static const ber_sequence_t PA_ENC_TS_ENC_sequence[]

still remains unused, giving an error. Which part of the cnf generates this
definition?
-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Build failure (kerberos)

[Dario Lombardo]

Ok, thanks.

On Sun, Mar 22, 2020 at 9:48 AM Martin Mathieson <
martin.r.mathie...@googlemail.com> wrote:

>
>>> ./asn1/kerberos/packet-kerberos-template.c: In function
>>> ‘dissect_krb5_PAC_CREDENTIAL_INFO’:
>>> ./asn1/kerberos/packet-kerberos-template.c:2187:2: error: implicit
>>> declaration of function ‘decrypt_krb5_data’
>>> [-Werror=implicit-function-declaration]
>>> ./asn1/kerberos/packet-kerberos-template.c:2187:11: error: assignment
>>> makes pointer from integer without a cast [-Werror]
>>> ./asn1/kerberos/packet-kerberos-template.c: At top level:
>>> ./asn1/kerberos/kerberos.cnf:360:1: error:
>>> ‘dissect_kerberos_PA_ENC_TS_ENC’ defined but not used
>>> [-Werror=unused-function]
>>>
>>>
I don't know which part of the asn1/cnf/template generates this function.
Can anyone guide me through the asn1 dissector generation process?
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Build failure (kerberos)

[Dario Lombardo]

Hi, Martin
There are indeed some issues with conditional compilation with kerberos.
However I cannot reproduce this exact problem. Which  is your build
environment?

On Sat, Mar 21, 2020 at 9:41 PM Martin Mathieson via Wireshark-dev <
wireshark-dev@wireshark.org> wrote:

> I am seeing this:
>
> ./asn1/kerberos/packet-kerberos-template.c: In function
> ‘dissect_krb5_PAC_CREDENTIAL_INFO’:
> ./asn1/kerberos/packet-kerberos-template.c:2187:2: error: implicit
> declaration of function ‘decrypt_krb5_data’
> [-Werror=implicit-function-declaration]
> ./asn1/kerberos/packet-kerberos-template.c:2187:11: error: assignment
> makes pointer from integer without a cast [-Werror]
> ./asn1/kerberos/packet-kerberos-template.c: At top level:
> ./asn1/kerberos/kerberos.cnf:360:1: error:
> ‘dissect_kerberos_PA_ENC_TS_ENC’ defined but not used
> [-Werror=unused-function]
> cc1: all warnings being treated as errors
> epan/dissectors/CMakeFiles/dissectors.dir/build.make:35002: recipe for
> target 'epan/dissectors/CMakeFiles/dissectors.dir/packet-kerberos.c.o'
> failed
>
> The declaration/definition of decrypt_krb5_data() depends upon
> HAVE_MIT_KERBEROS being defined, but there is no guard around calling it at
> packet-kerberos-template.c:2187.
>
> Best regards,
> Martin
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Clarifications regarding building wireshark

[Dario Lombardo]

On Mon, Mar 16, 2020 at 7:37 AM Ankish Shah 
wrote:

> I've downloaded and built wireshark on Ubuntu machine and I was going
> through the documentation of building new dissectors.
> I have a couple of doubts.
> 1. When I write code for a new dissector, do I have to build the entire
> wireshark once again (it takes around 10-12 mins on my system), or is there
> any option to compile only the new files and see the results?
>

The build system just compiles what changed on disk. You can skip the
linking phase, if you want to just compile your dissector, by issuing
make/ninja epan/dissectors/CMakeFiles/dissectors.dir/packet-dns.c.o (to
compile packet-dns.c, for instance). But this won't give you a fully
functional wireshark, just serves to see if your dissector compiles.


> 2. Once I code new dissectors, how do I test it using wireshark? For
> example, if you create a dissector to capture packets on port '12345' and
> the packet includes a flag bit and an ipv4 address, how do you actually
> create the packet, send it on port 12345 and see the results on wireshark?
>

You have bunch of options here. From writing a pcap file manually yourself,
to write your payload manually and send it through the network with netcat,
to use high level software such as scapy. It really depends on your
knowledge of the protocol and on your confidence with the raw hex writing.
Wireshark doesn't give support for writing sample captures. My suggestion
is: start from an existing capture (in pcap format, that is easier), modify
it with hex editors such as ghex2 on ubuntu, and open it from disk with
wireshark, without involving the network. After all you're working on a
dissector that works both on captured or saved traffic.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[Dario Lombardo]

Looks like I made it.

https://github.com/crondaemon/wireshark/runs/490547471?check_suite_focus=true

The artifact can be found in the upper right area of the screen.

On Fri, Mar 6, 2020 at 3:29 PM Dario Lombardo  wrote:

>
>
> On Fri, Mar 6, 2020 at 3:21 PM João Valverde <
> joao.valve...@tecnico.ulisboa.pt> wrote:
>
>> If you want to spare some CPU cycles I believe only the user_guide_chm
>> target is mandatory for NSIS.
>>
>> Seems you are missing some dependencies too, asciidoctor and maybe others
>> as well.
>>
>>
> Yes to both. I'm working on it.
>


-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[Dario Lombardo]

On Fri, Mar 6, 2020 at 3:21 PM João Valverde <
joao.valve...@tecnico.ulisboa.pt> wrote:

> If you want to spare some CPU cycles I believe only the user_guide_chm
> target is mandatory for NSIS.
>
> Seems you are missing some dependencies too, asciidoctor and maybe others
> as well.
>
>
Yes to both. I'm working on it.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[Dario Lombardo]

>
> Si it seems like it is not running the MSVC 2019 command prompt that takes
> care of setting the various environment variables.
>

Well... this is a point. I added the proper action and it made it a bit
further.

https://github.com/crondaemon/wireshark/runs/490228280?check_suite_focus=true

However it failed because of:
File: "D:\a\wireshark\wireshark\build\docbook\user-guide.chm" -> no files
found.

Then I guess I need to build the "all_guides" target.
-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[Dario Lombardo]

On Fri, Mar 6, 2020 at 12:44 PM Pascal Quantin  wrote:

>
>
> Le ven. 6 mars 2020 à 12:28, Dario Lombardo  a écrit :
>
>> I am sorry, I still don't understand, I beg your pardon.
>> You said
>>
>> > your machine does not have the MSVC redistributable copied in the
>> wireshark-libs folder (as explained in the developer guide) while it is
>> required for the NSIS installer.
>>
>> But I cannot find any point in the developer guide where it is explained
>> that the MSVC redistributable has to be copied somewhere, nor I know how to
>> do it myself without a more detailed explanation.
>>
>
> This is why I said it used to be more visible in the documentation .
> We used to have to download vcredist_x86.exe or vcredist_x64.exe from
> Microsoft website and copy it in the Wireshark-win32-libs or
> Wireshark-win64-libs folder. It is no more required because the
> redistributables are bundled in the MSVC 2019 community edition (for
> example mine is located by CMake in C:/Program Files (x86)/Microsoft Visual
> Studio/2019/Community/VC/Redist/MSVC/14.24.28127).
>
> I now realize that you have 2 errors: one about the VCINSTALLDIR (root
> cause of your NSIS issue) and one about MERGE_MODULE_DIR (for WiX). Sorry
> for not seeing this earlier.
>
> As found in our CMakeLists.txt file:
>
> # Try to find the Redist folder in VCINSTALLDIR which is set by
> vcvarsall.bat.
> # If it is not set, query it within the registry. VS2015 looks for the
> "VC7" key
> # in two locations (four if you count HKCU instead of HKLM). However,
> VS2017
> # does not use "VC7" (it sets a directory relative to vsdevcmd_start.bat).
> As
> # both versions do set "VS7", use that instead.
> find_path(VCINSTALLDIR Redist PATHS
> "$ENV{VCINSTALLDIR}"
>
> "[HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\VisualStudio\\SxS\\VS7;${_msvs_version}]\\VC"
>
> "[HKEY_LOCAL_MACHINE\\SOFTWARE\\WOW6432Node\\Microsoft\\VisualStudio\\SxS\\VS7;${_msvs_version}]\\VC"
> NO_DEFAULT_PATH
> )
> file(TO_NATIVE_PATH "${VCINSTALLDIR}" VCINSTALLDIR_NATIVE)
> message(STATUS "Using VCINSTALLDIR: ${VCINSTALLDIR_NATIVE}")
>
> That's what Gerald indicated in his message.
>
> When I open the MSVC 2019 command prompt, and type 'set VCINSTALLDIR', I
> get as expected:
> VCINSTALLDIR=C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Community\VC\
>
> What do you get?
>
>
Unfortunately the builder doesn't print anything with that command

https://github.com/crondaemon/wireshark/runs/490180639?check_suite_focus=true

see the "set" step.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[Dario Lombardo]

I am sorry, I still don't understand, I beg your pardon.
You said

> your machine does not have the MSVC redistributable copied in the
wireshark-libs folder (as explained in the developer guide) while it is
required for the NSIS installer.

But I cannot find any point in the developer guide where it is explained
that the MSVC redistributable has to be copied somewhere, nor I know how to
do it myself without a more detailed explanation.

On Fri, Mar 6, 2020 at 12:20 PM Pascal Quantin  wrote:

> Hi Dario,
>
> Le ven. 6 mars 2020 à 12:16, Dario Lombardo  a écrit :
>
>> Hi Pascal
>> I'm not sure I got the point. I try to explain what I understand. I have
>> one single build, that may have multiple problems, some trivial, some not.
>> The error I see in cmake could be ignored, while the one that counts is the
>> fact I need the MSVC redistributable in the wireshark-lib folder.
>> Am I correct?
>>
>
> Yes if you do not have a step building the WiX installer (which seems to
> be the case).
>
>
>>
>>>> Joao is correct: on one side you have a non fatal error in CMake that
>>> only impacts the WiX installer, and in the other side your machine does not
>>> have the MSVC redistributable copied in the wireshark-libs folder (as
>>> explained in the developer guide) while it is required for the NSIS
>>> installer.
>>>
>>> Can you link the devel guide where it's explained? I just found
>>
>>
>> https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcBinary.html#ChSrcNSIS
>>
>
> https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html
>
> In the past it used to be more visible if I remember correctly.
>
> BR,
> Pascal.
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[Dario Lombardo]

Hi Pascal
I'm not sure I got the point. I try to explain what I understand. I have
one single build, that may have multiple problems, some trivial, some not.
The error I see in cmake could be ignored, while the one that counts is the
fact I need the MSVC redistributable in the wireshark-lib folder.
Am I correct?


>> Joao is correct: on one side you have a non fatal error in CMake that
> only impacts the WiX installer, and in the other side your machine does not
> have the MSVC redistributable copied in the wireshark-libs folder (as
> explained in the developer guide) while it is required for the NSIS
> installer.
>
> Can you link the devel guide where it's explained? I just found

https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcBinary.html#ChSrcNSIS

Thanks.
Dario.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[Dario Lombardo]

No, it's the same. Have a look at the cmake section and you will see the
error messages below.

On Fri, Mar 6, 2020 at 10:54 AM João Valverde <
joao.valve...@tecnico.ulisboa.pt> wrote:

>
>
> On 06/03/20 08:23, Dario Lombardo wrote:
>
> Example of failing build
>
>
> https://github.com/crondaemon/wireshark/runs/489648430?check_suite_focus=true
>
>
> A quick look suggests this is a different build than you indicated before,
> for an NSIS package, and the problem seems to be that the VC_REDIST exe is
> missing.
>
>
> On Fri, Mar 6, 2020 at 9:07 AM Dario Lombardo  wrote:
>
>> Are you saying "set v"? It doesn't print anything.
>> The installation of VS is pre-made by the github builder itself, not by
>> me, hence I don't have any control over the installation options. However I
>> guess every component is in place, and maybe I just need to add the proper
>> dir to the PATH. What do you think?
>>
>> On Thu, Mar 5, 2020 at 9:36 PM Gerald Combs  wrote:
>>
>>> On 3/5/20 7:27 AM, Dario Lombardo wrote:
>>> > Hi,
>>> > I'm getting this output from a windows build
>>> >
>>> > -- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND
>>> > -- Using MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm for the
>>> WiX installer
>>> > -- Configuring done
>>> > -- Generating done
>>> > -- Build files have been written to: D:/a/wireshark/wireshark/build
>>> >
>>> > What's going wrong? The rest of the output looks good.
>>>
>>> VCINSTALLDIR should have been set by Visual Studio, e.g. by
>>> vcvarsall.bat. What does `set v` show?
>>>
>>> ___
>>> Sent via:Wireshark-dev mailing list 
>>> Archives:https://www.wireshark.org/lists/wireshark-dev
>>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>>  mailto:wireshark-dev-requ...@wireshark.org
>>> ?subject=unsubscribe
>>
>>
>>
>> --
>>
>> Naima is online.
>>
>>
>
> --
>
> Naima is online.
>
>
> ___
> Sent via:Wireshark-dev mailing list  
> 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe 
> 
>
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[Dario Lombardo]

Example of failing build

https://github.com/crondaemon/wireshark/runs/489648430?check_suite_focus=true

On Fri, Mar 6, 2020 at 9:07 AM Dario Lombardo  wrote:

> Are you saying "set v"? It doesn't print anything.
> The installation of VS is pre-made by the github builder itself, not by
> me, hence I don't have any control over the installation options. However I
> guess every component is in place, and maybe I just need to add the proper
> dir to the PATH. What do you think?
>
> On Thu, Mar 5, 2020 at 9:36 PM Gerald Combs  wrote:
>
>> On 3/5/20 7:27 AM, Dario Lombardo wrote:
>> > Hi,
>> > I'm getting this output from a windows build
>> >
>> > -- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND
>> > -- Using MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm for the
>> WiX installer
>> > -- Configuring done
>> > -- Generating done
>> > -- Build files have been written to: D:/a/wireshark/wireshark/build
>> >
>> > What's going wrong? The rest of the output looks good.
>>
>> VCINSTALLDIR should have been set by Visual Studio, e.g. by
>> vcvarsall.bat. What does `set v` show?
>>
>> ___
>> Sent via:Wireshark-dev mailing list 
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>  mailto:wireshark-dev-requ...@wireshark.org
>> ?subject=unsubscribe
>
>
>
> --
>
> Naima is online.
>
>

-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

[Dario Lombardo]

Are you saying "set v"? It doesn't print anything.
The installation of VS is pre-made by the github builder itself, not by me,
hence I don't have any control over the installation options. However I
guess every component is in place, and maybe I just need to add the proper
dir to the PATH. What do you think?

On Thu, Mar 5, 2020 at 9:36 PM Gerald Combs  wrote:

> On 3/5/20 7:27 AM, Dario Lombardo wrote:
> > Hi,
> > I'm getting this output from a windows build
> >
> > -- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND
> > -- Using MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm for the
> WiX installer
> > -- Configuring done
> > -- Generating done
> > -- Build files have been written to: D:/a/wireshark/wireshark/build
> >
> > What's going wrong? The rest of the output looks good.
>
> VCINSTALLDIR should have been set by Visual Studio, e.g. by vcvarsall.bat.
> What does `set v` show?
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Cmake on windows

[Dario Lombardo]

Hi,
I'm getting this output from a windows build

-- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND
-- Using MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm for the WiX
installer
-- Configuring done
-- Generating done
-- Build files have been written to: D:/a/wireshark/wireshark/build

What's going wrong? The rest of the output looks good.

-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Build mac binaries

[Dario Lombardo]

It looks it was the point.
Now my builder succeeds in building a dmg.

On Tue, Mar 3, 2020 at 8:17 AM Dario Lombardo  wrote:

> I do, but I have installed it after cmake (it's a builder actually that's
> making the binary). Is the target conditionally created?
>
> On Mon, Mar 2, 2020, 17:54 Gerald Combs  wrote:
>
>> Do you have dmgbuild (https://github.com/al45tair/dmgbuild) installed?
>> The dmg_package target runs osx-dmg.sh, which in turn creates the .dmg
>> using dmgbuild.
>>
>> On 3/2/20 7:54 AM, Dario Lombardo wrote:
>> > Hi
>> > I'm trying to build a mac binary package. The instructions I found here
>> >
>> > https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcBinary.html
>> >
>> > look a bit incomplete. If understand what the instructions say, I
>> should run make (ninja) dmg_package, but this isn't enough. Am I doing
>> something wrong?
>> > If not which are the complete steps to create a mac dmg?
>> >
>> > --
>> >
>> > Naima is online.
>> >
>> >
>> >
>> ___
>> > Sent via:Wireshark-dev mailing list 
>> > Archives:https://www.wireshark.org/lists/wireshark-dev
>> > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>> >  mailto:wireshark-dev-requ...@wireshark.org
>> ?subject=unsubscribe
>> >
>>
>>
>> ___
>> Sent via:Wireshark-dev mailing list 
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>  mailto:wireshark-dev-requ...@wireshark.org
>> ?subject=unsubscribe
>
>

-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Build mac binaries

[Dario Lombardo]

I do, but I have installed it after cmake (it's a builder actually that's
making the binary). Is the target conditionally created?

On Mon, Mar 2, 2020, 17:54 Gerald Combs  wrote:

> Do you have dmgbuild (https://github.com/al45tair/dmgbuild) installed?
> The dmg_package target runs osx-dmg.sh, which in turn creates the .dmg
> using dmgbuild.
>
> On 3/2/20 7:54 AM, Dario Lombardo wrote:
> > Hi
> > I'm trying to build a mac binary package. The instructions I found here
> >
> > https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcBinary.html
> >
> > look a bit incomplete. If understand what the instructions say, I should
> run make (ninja) dmg_package, but this isn't enough. Am I doing something
> wrong?
> > If not which are the complete steps to create a mac dmg?
> >
> > --
> >
> > Naima is online.
> >
> >
> >
> ___
> > Sent via:Wireshark-dev mailing list 
> > Archives:https://www.wireshark.org/lists/wireshark-dev
> > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> >  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
> >
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Build mac binaries

[Dario Lombardo]

Hi
I'm trying to build a mac binary package. The instructions I found here

https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcBinary.html

look a bit incomplete. If understand what the instructions say, I should
run make (ninja) dmg_package, but this isn't enough. Am I doing something
wrong?
If not which are the complete steps to create a mac dmg?

-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] LUA on freebsd

[Dario Lombardo]

I can confirm it works properly on my builders (11.3, 12.0 and 13.0).
Thanks.

On Sat, Feb 1, 2020 at 2:20 AM Guy Harris  wrote:

> On Jan 31, 2020, at 3:56 PM, Guy Harris  wrote:
>
> > Or perhaps we're looking for "lua5.2" but not for "lua-5.2" as well.
> >
> > Which we are.
> >
> > I'll fix that.
>
> Done, and backported to the 3.2, 3.0, and 2.6 branches.
>
> That seems to have fixed the problem on my FreeBSD 11.2 VM.
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] LUA on freebsd

[Dario Lombardo]

On Thu, Jan 30, 2020 at 12:44 PM Peter Wu  wrote:

>
> a lua-5.2 pkg-config file is installed and headers are available under
> include/lua52, so it should work.
>
>
I installed lua52, and got this: https://cirrus-ci.com/task/4716205919436800

The library is not properly detected, but then tried to be linked (and
failed).
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] LUA on freebsd

[Dario Lombardo]

Hi,
I tried to install all the dependencies on freebsd, but LUA is missing.
Does anyone knows which packages are to be installed to be found by cmake?
-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Bug in extcap?

[Dario Lombardo]

There is at least one bug open for that. Can you push a change on gerrit so
we can start the review/discussion?

On Sat, Jan 25, 2020, 22:54 Anders Esbensen 
wrote:

> 
>
> Hi,
>
>
>
> I’m seeing some issues with extcap on linux and osx. If I run udpdump and
> stop it again the udp process is not terminated. If I start udpdump once
> again I will have two udpdump processes running on my system. I’ve tested
> this on v2.4.5 and v3.2.1.
>
>
>
> Looking though the code I cannot find any places in extcap.c where the
> dumper is terminated, but for Windows it seems that the dumper process is
> terminated in extcap.c:1142.
>
>
>
> I’ve attached a patch which seems to solve the issue, but I’m not quite
> sure it’s the right thing to do.
>
>
>
> Best regards
>
> Anders
>
>
>
>
>
> *Anders Lynge Esbensen*
>
> Staff Software Engineer, IoT Software
>
>
>
> Emdrupvej 28B, 2100 København Ø, Denmark
>
>
>
> 
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] retrigger petri dish buildbot

[Dario Lombardo]

It's something only the core-developers can do, as Pascal did.

On Sat, Jan 25, 2020, 10:45 Erwin Rol  wrote:

> Hey all,
>
> one of my patches failed to be verified (due to some build problem that
> did not have anything to do with my patch) now I rebased it but that
> doesn't seem to trigger a new perti dish build.
>
> What do I have to do to get the buildbot to rebuild my patch and to get
> an OK for merging ?
>
> It is this patch;
>
> https://code.wireshark.org/review/c/35915/
>
> TIA,
>
> Erwin
>
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Bypassing the first layer

[Dario Lombardo]

I don't think this is what Anders was talking about. This is about extcap,
while I was referring to export_pdu.
If you or Anders can reference the right one, that would be great.
If you want to have a look at something using export_pdu creating a pcap
file, have a loot at the udpdump.c code.

On Wed, Jan 15, 2020 at 2:37 PM Juanjo Martin Carrascosa 
wrote:

> https://sharkfestus.wireshark.org/assets/presentations18/17.pptx
>
> On Wed, Jan 15, 2020 at 2:36 PM Dario Lombardo  wrote:
>
>> Can you share the link, for future reference?
>>
>> On Wed, Jan 15, 2020 at 2:15 PM Juanjo Martin Carrascosa 
>> wrote:
>>
>>> Found the presentation, this is fantastic.
>>>
>>> Thanks!
>>>
>>> On Wed, Jan 15, 2020 at 12:58 PM Anders Broman via Wireshark-dev <
>>> wireshark-dev@wireshark.org> wrote:
>>>
>>>> Hi,
>>>>
>>>> In the frame layer there is the “Encapsulation type” the way the pcap
>>>> format works this indicates how the data following should be interpreted.
>>>>
>>>> Linktype/encapsulation type is defined at
>>>> https://www.tcpdump.org/linktypes.html so one thing you could do is to
>>>> design your own DLT
>>>>
>>>> Add whatever meta data you want and then add the RTPS data at some
>>>> position in that structure. You can try this out by using the USER DLTs in
>>>> Wireshark
>>>>
>>>> Or if you do not want to request a DLT from tcpdump ( DO NOT USE ONE
>>>> WITHOUT ALLOCATING IT) you could use the Exported PDU DLT defined by
>>>> Wireshark
>>>>
>>>> Epan/exported_pdu.h contains some information. If you would require new
>>>> elements for meta information that could be discussed. Adding RTSP data in
>>>>
>>>> An exported_pdu DLT frame should be simple as an initial test. I think
>>>> there is a sharkfest presentation on how to add any protocol data in an
>>>> exported pdu frame with text2pcap.
>>>>
>>>> Regards
>>>>
>>>> Anders
>>>>
>>>>
>>>>
>>>> *From:* Wireshark-dev  *On Behalf
>>>> Of *Juanjo Martin Carrascosa
>>>> *Sent:* den 15 januari 2020 12:24
>>>> *To:* Developer support list for Wireshark >>> >
>>>> *Subject:* Re: [Wireshark-dev] Bypassing the first layer
>>>>
>>>>
>>>>
>>>> Hi Dario,
>>>>
>>>>
>>>>
>>>> Could you elaborate on this? I get the idea but my knowledge about the
>>>> how is very basic.
>>>>
>>>>
>>>>
>>>> How can this help me achieve what I need?
>>>>
>>>>
>>>>
>>>> Thanks for the help.
>>>>
>>>> Juanjo Martin
>>>>
>>>>
>>>>
>>>> On Tue, Jan 14, 2020 at 4:48 PM Dario Lombardo 
>>>> wrote:
>>>>
>>>> You can use export_pdu. This is a layer with multiple attributes (see
>>>> epan/exported_pdu.h), but the only really needed is the proto_name, that
>>>> allows you to directly call a dissector by its name.
>>>>
>>>> You will have frames with this stack: FRAME/EXPORT PDU/RTPS, that is
>>>> properly dissected by wireshark.
>>>>
>>>>
>>>>
>>>> On Tue, Jan 14, 2020 at 4:33 PM Juanjo Martin Carrascosa <
>>>> jua...@rti.com> wrote:
>>>>
>>>> Hi everyone,
>>>>
>>>>
>>>>
>>>> RTPS is a protocol already supported by Wireshark. I have been helping
>>>> maintain that protocol these past years. It sits on top of TCP and UDP, as
>>>> well as some other transports that are not network ones (Shared Memory
>>>> typically with a proprietary implementation).
>>>>
>>>>
>>>>
>>>> We are currently working on implementing a new logging mechanism for
>>>> our product, mainly to address the Shared Memory scenario but it can also
>>>> be really useful when RTPS is used on top of network protocols.
>>>>
>>>>
>>>>
>>>> Problem: We can log the RTPS layer but we don't have some information
>>>> in our middleware like the Frame or Ethernet information, so we need to
>>>> make it up. This is ugly, so I am trying to avoid that:
>>>>
>>>>
>>>>
>>>> How can I regi

Re: [Wireshark-dev] Bypassing the first layer

[Dario Lombardo]

Can you share the link, for future reference?

On Wed, Jan 15, 2020 at 2:15 PM Juanjo Martin Carrascosa 
wrote:

> Found the presentation, this is fantastic.
>
> Thanks!
>
> On Wed, Jan 15, 2020 at 12:58 PM Anders Broman via Wireshark-dev <
> wireshark-dev@wireshark.org> wrote:
>
>> Hi,
>>
>> In the frame layer there is the “Encapsulation type” the way the pcap
>> format works this indicates how the data following should be interpreted.
>>
>> Linktype/encapsulation type is defined at
>> https://www.tcpdump.org/linktypes.html so one thing you could do is to
>> design your own DLT
>>
>> Add whatever meta data you want and then add the RTPS data at some
>> position in that structure. You can try this out by using the USER DLTs in
>> Wireshark
>>
>> Or if you do not want to request a DLT from tcpdump ( DO NOT USE ONE
>> WITHOUT ALLOCATING IT) you could use the Exported PDU DLT defined by
>> Wireshark
>>
>> Epan/exported_pdu.h contains some information. If you would require new
>> elements for meta information that could be discussed. Adding RTSP data in
>>
>> An exported_pdu DLT frame should be simple as an initial test. I think
>> there is a sharkfest presentation on how to add any protocol data in an
>> exported pdu frame with text2pcap.
>>
>> Regards
>>
>> Anders
>>
>>
>>
>> *From:* Wireshark-dev  *On Behalf
>> Of *Juanjo Martin Carrascosa
>> *Sent:* den 15 januari 2020 12:24
>> *To:* Developer support list for Wireshark 
>> *Subject:* Re: [Wireshark-dev] Bypassing the first layer
>>
>>
>>
>> Hi Dario,
>>
>>
>>
>> Could you elaborate on this? I get the idea but my knowledge about the
>> how is very basic.
>>
>>
>>
>> How can this help me achieve what I need?
>>
>>
>>
>> Thanks for the help.
>>
>> Juanjo Martin
>>
>>
>>
>> On Tue, Jan 14, 2020 at 4:48 PM Dario Lombardo  wrote:
>>
>> You can use export_pdu. This is a layer with multiple attributes (see
>> epan/exported_pdu.h), but the only really needed is the proto_name, that
>> allows you to directly call a dissector by its name.
>>
>> You will have frames with this stack: FRAME/EXPORT PDU/RTPS, that is
>> properly dissected by wireshark.
>>
>>
>>
>> On Tue, Jan 14, 2020 at 4:33 PM Juanjo Martin Carrascosa 
>> wrote:
>>
>> Hi everyone,
>>
>>
>>
>> RTPS is a protocol already supported by Wireshark. I have been helping
>> maintain that protocol these past years. It sits on top of TCP and UDP, as
>> well as some other transports that are not network ones (Shared Memory
>> typically with a proprietary implementation).
>>
>>
>>
>> We are currently working on implementing a new logging mechanism for our
>> product, mainly to address the Shared Memory scenario but it can also be
>> really useful when RTPS is used on top of network protocols.
>>
>>
>>
>> Problem: We can log the RTPS layer but we don't have some information in
>> our middleware like the Frame or Ethernet information, so we need to make
>> it up. This is ugly, so I am trying to avoid that:
>>
>>
>>
>> How can I register a protocol so it is picked up instead of the Frame
>> layer? This is, I want to create a new protocol that detects that the
>> information we generate is for that protocol and the Frame protocol is not
>> called, but the new protocol I am creating. This new protocol will then
>> call the RTPS protocol to dissect the payload I want to display. We are
>> planning to also add some information to this custom protocol, that's why I
>> want it to be called first.
>>
>>
>>
>> Note: I just came up with this solution, but if you have a different
>> solution for this, please let me know.
>>
>>
>>
>> Thanks,
>>
>> Juanjo Martin
>>
>>
>> ___
>> Sent via:Wireshark-dev mailing list 
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>  mailto:wireshark-dev-requ...@wireshark.org
>> ?subject=unsubscribe
>>
>>
>>
>>
>> --
>>
>> Naima is online.
>>
>>
>> ___
>> Sent via:Wireshark-dev mailing list 
>> Archives:https://www.wireshar

Re: [Wireshark-dev] Bypassing the first layer

[Dario Lombardo]

You can use export_pdu. This is a layer with multiple attributes (see
epan/exported_pdu.h), but the only really needed is the proto_name, that
allows you to directly call a dissector by its name.
You will have frames with this stack: FRAME/EXPORT PDU/RTPS, that is
properly dissected by wireshark.

On Tue, Jan 14, 2020 at 4:33 PM Juanjo Martin Carrascosa 
wrote:

> Hi everyone,
>
> RTPS is a protocol already supported by Wireshark. I have been helping
> maintain that protocol these past years. It sits on top of TCP and UDP, as
> well as some other transports that are not network ones (Shared Memory
> typically with a proprietary implementation).
>
> We are currently working on implementing a new logging mechanism for our
> product, mainly to address the Shared Memory scenario but it can also be
> really useful when RTPS is used on top of network protocols.
>
> Problem: We can log the RTPS layer but we don't have some information in
> our middleware like the Frame or Ethernet information, so we need to make
> it up. This is ugly, so I am trying to avoid that:
>
> How can I register a protocol so it is picked up instead of the Frame
> layer? This is, I want to create a new protocol that detects that the
> information we generate is for that protocol and the Frame protocol is not
> called, but the new protocol I am creating. This new protocol will then
> call the RTPS protocol to dissect the payload I want to display. We are
> planning to also add some information to this custom protocol, that's why I
> want it to be called first.
>
> Note: I just came up with this solution, but if you have a different
> solution for this, please let me know.
>
> Thanks,
> Juanjo Martin
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Standard defined field names in Wireshark dissectors

[Dario Lombardo]

I agree that scripts should not rely on such an output. However sometimes
there isn't another option or people just do it anyway. We must consider
that as well.
Talking about Tomasz proposal, I agree that we should follow the standards
as closely as possible. But if that breaks backward compatibility, I'd
suggest to keep it for wirershark 4.0.
Major version changes break backward compatibility, and that looks to be
the case.

On Sun, Jan 5, 2020 at 7:17 PM Guy Harris  wrote:

> On Jan 5, 2020, at 8:06 AM, Tomasz Moń  wrote:
>
> > In case of the USB Audio descriptor dissection, I would like to change
> > the header_field_info name, leaving abbrev as is. Would that still
> > cause problems?
>
> It would cause problems for programs that parse TShark -T text (default
> text) output (or "export the packet dissections as plain text" Wireshark
> output), but programs should avoid doing that if possible - they should use
> other -T formats, in which the abbrev is used.
>
> It shouldn't cause problem for any other software; filters, for example,
> use the abbrev.  ("abbrev" should be thought of as the field name, and
> "name" should be thought of as the field *description*.)
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

[Dario Lombardo]

Hi
For Ubuntu there is tools/debian-setup.sh that installs optional packages
(as this).
I suggest you to test your change at least on this platform since it's the
most common.
Did you make your change compilable without that library? You need some
preprocessor ifdefs for that.
If you push your change as WIP you can add me as reviewer: I have a bunch
of builders for many platforms. I can help you at least to compile it on as
many as possible.


On Sat, Dec 28, 2019, 21:52 Jiří Novák  wrote:

> Hello,
>
>   I finished iLBC codec support and it works fine for decoding and audio
> saving. The only issue is that I'm able to build and test it on Linux only.
>   It depends on iLBC lib from https://github.com/TimothyGu/libilbc. It
> is package ilbc/ilbc-devel on Fedora
> (ilbc-1.1.1-16.fc30.x86_64/ilbc-devel-1.1.1-16.fc30.x86_64)
>
>   I modified/created CMakeLists.txt, CMakeOptions.txt,
> cmake/modules/FindILBC.cmake and tools/rpm-setup.sh.
>   I didn't touched files for Windows/MAC.
>
>   Can I ask anyone to help me to update/test scripts for other platforms
> and petri-dish?
>
> Best regards,
>
> Jirka Novak
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Extcap binaries on OSX

[Dario Lombardo]

Ok, thanks. And what does the python command "sys.platform" return?

On Fri, Dec 20, 2019 at 11:46 AM Roland Knall  wrote:

> run/Wireshark.app/Contents/MacOS/extcap
>
> cheers
> Roland
>
> Am Fr., 20. Dez. 2019 um 10:31 Uhr schrieb Dario Lombardo <
> lom...@gmail.com>:
>
>> Hi,
>> I'm trying to debug some CI jobs on OSX but I don't have a OSX machine.
>> I'm trying to find where the extcap binaries are put on OSX using cmake.
>>
>> Linux: run\extcap
>> Windows: run\RelWithDebInfo\extcap
>> OSX: ?
>>
>> Any help?
>> Thanks.
>> Dario.
>>
>> --
>>
>> Naima is online.
>>
>>
>> ___
>> Sent via:Wireshark-dev mailing list 
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>  mailto:wireshark-dev-requ...@wireshark.org
>> ?subject=unsubscribe
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Extcap binaries on OSX

[Dario Lombardo]

Hi,
I'm trying to debug some CI jobs on OSX but I don't have a OSX machine. I'm
trying to find where the extcap binaries are put on OSX using cmake.

Linux: run\extcap
Windows: run\RelWithDebInfo\extcap
OSX: ?

Any help?
Thanks.
Dario.

-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Adding a new packet to Wireshark

[Dario Lombardo]

On Fri, Dec 6, 2019 at 9:58 PM Richard Sharpe 
wrote:

>
> As Dario has already said, there should not be any problems. You will
> have to release the changes under the GPL, though.


Or any compatible licence. We have BSD licensed dissectors as well as GPL.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Adding a new packet to Wireshark

[Dario Lombardo]

I can't see any blocker in what you're proposing. Feel free to push your
proposals and follow the review process.
Thanks for the contribution.

On Fri, Dec 6, 2019 at 9:50 PM Bruni, Michelle 
wrote:

> Hello,
>
> I am Michelle and I work at Spirent Communications. We have been building
> Wireshark for many years because we had a proprietary signature field that
> we needed to decode and give to our customers. We are looking to open
> source our signature field and would like to put our packet dissectors into
> the Wireshark codebase. Before we get started on going through the process
> of committing and reviewing the changes into Wireshark I wanted to find out
> if this is something that is allowed and would get approved (after
> following the process of course).
>
>
>
> Also we have some changes we have made to other packet dissectors that we
> will be pushing upstream and as we make new changes putting them back into
> the community.
>
>
>
> Looking forward from hearing from you and working with the Wireshark
> community.
>
>
>
> Michelle Bruni
>
> Spirent Communications
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Missing dumpcap when building 3.1.1

[Dario Lombardo]

Have a look at cmake's output. It will say something about libpcap (whether
is found or not). If it's found, you can compile dumpcap with ninja/make
dumpcap, just to be sure it's compiled. However a straight compilation
command should do its job.

On Fri, Nov 29, 2019 at 3:04 PM Tom Bentley  wrote:

> Hi,
>
> I downloaded and built wireshark 3.1.1 from the website. When I
> run/wireshark the gui appears, but there in the "Capture" pane it says "No
> interfaces found". Furthermore (maybe related, maybe not) I had expected
> `dumpcap` to be in the run directory, but it's missing). So I'm wondering
> how I managed to mess up the build and what I need to do to fix it.
>
> Many thanks,
>
> Tom
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Visual studio 2019 from choco

[Dario Lombardo]

On Tue, Nov 26, 2019 at 5:49 PM Graham Bloice 
wrote:

> Oh.  A very old and unsupported (by MS) version of Win 10. See here for
> lifecycle info:
> https://support.microsoft.com/en-gb/help/13853/windows-lifecycle-fact-sheet
>
> And 1511 came with .Net 4.6.1, hence the issue with installing VS 2019.
>
>
I can confirm it's working now. I've updated the documentation accordingly
(it's already online).
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Visual studio 2019 from choco

[Dario Lombardo]

Agreed. I didn't think about it. I just took the first ISO I found. I don't
install windows very often.

On Tue, Nov 26, 2019 at 6:34 PM Jasper Bongertz 
wrote:

>
>
>
>
>
>
> Oh.  A very old and unsupported (by MS) version of Win 10. See here for
> lifecycle info:
> https://support.microsoft.com/en-gb/help/13853/windows-lifecycle-fact-sheet
> Indeed. It was a fresh install with no updates (due to network issues).
> I'm updating the system now: let's see if it suffices.
> I'd add something in the docbook about using a supported version of
> windows, referencing your link.
> In my experience it is significantly faster to download & install from
> scratch again from a recent ISO instead of going through all the update
> cycles to reach 1909... Those often take hours per cycle, and starting from
> 1511 probably means 1 or 2 days of patching to get there :-)
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Visual studio 2019 from choco

[Dario Lombardo]

>
>
> Oh.  A very old and unsupported (by MS) version of Win 10. See here for
> lifecycle info:
> https://support.microsoft.com/en-gb/help/13853/windows-lifecycle-fact-sheet
>
> Indeed. It was a fresh install with no updates (due to network issues).
I'm updating the system now: let's see if it suffices.
I'd add something in the docbook about using a supported version of
windows, referencing your link.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Visual studio 2019 from choco

[Dario Lombardo]

On Tue, Nov 26, 2019 at 3:50 PM Graham Bloice 
wrote:

>
>
> On Tue, 26 Nov 2019 at 14:29, Dario Lombardo  wrote:
>
>> I'm chatting with choco maintainers right now. They say it sounds like a
>> fresh win10 install will fail with dotnetfx because M$ now requires
>> anniversary edition to install dotnet. They say:
>>
>>
> I don't quite follow you here, the link below states that the .Net
> framework is pre-installed with Windows 10 and list the versions.  It seems
> that 1703 was the first to come with 4.7 pre-installed.
>
> What Win 10 version are you using?
>
> I just pasted what they told me. I'm still working on it.
I have Windows 10 enterprise N
Version 1511
OS Build 10586.0
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Visual studio 2019 from choco

[Dario Lombardo]

I'm chatting with choco maintainers right now. They say it sounds like a
fresh win10 install will fail with dotnetfx because M$ now requires
anniversary edition to install dotnet. They say:

"
https://docs.microsoft.com/en-us/dotnet/framework/get-started/system-requirements
THis is kind of also mentioned in the package description

Supported Windows Client versions: Windows 10 version 1903, Windows 10
version 1809, Windows 10 version 1803, Windows 10 version 1709, Windows 10
version 1703, Windows 10 version 1607, Windows 8.1, Windows 7 SP1

1607 being the anniversary edition
"

I'm trying to make my system up2date and then install dotnet. if I succeed,
I'll drop a line in the documentation about installing on an updated
windows version, or a more detailed description of the issue.

On Tue, Nov 26, 2019 at 3:20 PM Graham Bloice 
wrote:

>
> On Tue, 26 Nov 2019 at 11:55, Dario Lombardo  wrote:
>
>> Hi
>> I'm following the win32/64 guide from the very beginning on a fresh win10
>> VM. I'm basically at the top, but I hit an error. In chap 2.2.2 I'm issuing
>> the choco command to install visualstudio. The installation fails because
>> dotnetfx fails. I've found this error message:
>>
>> The .NET Framework 4.8 is not supported on this operating system.
>>
>> The documentation doesn't say anything about incompatibilities with .NET.
>> How can I fix it (I guess installing .NET by myself?)?
>> Should we document something since this is a generalized problem, or it's
>> just mine?
>> --
>>
>> Naima is online.
>>
>> It seems that MS no longer install the .Net framework by default, it's an
> additional option.  See the MS page on this issue here:
> https://docs.microsoft.com/en-us/dotnet/framework/install/on-windows-10
>
> The choco package "dotnetfx"  will install this:
> https://chocolatey.org/packages/dotnetfx
>
> Arguably it should be a dependency for the VS choco packages, and it is
> listed for the VS 2019 community package.  Not sure what's gone wrong for
> you here.
>
> --
> Graham Bloice
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Visual studio 2019 from choco

[Dario Lombardo]

Hi
I'm following the win32/64 guide from the very beginning on a fresh win10
VM. I'm basically at the top, but I hit an error. In chap 2.2.2 I'm issuing
the choco command to install visualstudio. The installation fails because
dotnetfx fails. I've found this error message:

The .NET Framework 4.8 is not supported on this operating system.

The documentation doesn't say anything about incompatibilities with .NET.
How can I fix it (I guess installing .NET by myself?)?
Should we document something since this is a generalized problem, or it's
just mine?
-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Wireshark Developer's Guide bad URL

[Dario Lombardo]

Thanks.

On Wed, Nov 20, 2019 at 2:27 AM Moshe Kaplan  wrote:

> Thanks for reporting; I submitted
> https://code.wireshark.org/review/#/c/35146/ to fix this issue.
>
> Moshe
>
> On Tue, Nov 19, 2019 at 7:21 PM Gavin Higham 
> wrote:
>
>> I noticed on this page of the Wireshark Developer's Guide something that
>> looks like it should have become a URL after a text replacement:
>>
>> https://www.wireshark.org/docs/wsdg_html_chunked/PreDownload.html
>>
>> - Gavin
>>
>> ___
>> Sent via:Wireshark-dev mailing list 
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>  mailto:wireshark-dev-requ...@wireshark.org
>> ?subject=unsubscribe
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe