Re: [Wireshark-dev] Wireshark Developer's Guide feedback

2024-03-31 Thread Guy Harris
On Mar 29, 2024, at 11:23 AM, Krefta, Oliver O. - US via Wireshark-dev wrote: > Section 11.6.2.5 > My understanding is that tvb:reported_length_remaining() takes an optional > parameter specifying an offset. My own testing seems to confirm this. However > the function is documented as taking

Re: [Wireshark-dev] SocketCAN Support is broken in latest Wireshark-v4.3.0rc0-1430-g600de02805d0

2024-02-15 Thread Guy Harris
On Feb 15, 2024, at 12:01 AM, Oliver Hartkopp wrote: > Marc created a pull-request for Linux mainline upstream (net-next) and the > CAN XL VCID support will now show up in Linux 6.9: > >

Re: [Wireshark-dev] SocketCAN Support is broken in latest Wireshark-v4.3.0rc0-1430-g600de02805d0

2024-02-14 Thread Guy Harris
Wireshark 4.2.3, which includes the SocketCAN changes, has just been released. Presumably, various packagers of Wireshark 4.2.x will pick it up at some point. ___ Sent via:Wireshark-dev mailing list Archives:

Re: [Wireshark-dev] SocketCAN Support is broken in latest Wireshark-v4.3.0rc0-1430-g600de02805d0

2024-02-12 Thread Guy Harris
On Feb 12, 2024, at 1:15 PM, Oliver Hartkopp wrote: > Excellent! That seems to be the right approach. OK, so: fix libpcap to put the priority/VCID field in big-endian order in CAN XL frames:

Re: [Wireshark-dev] SocketCAN Support is broken in latest Wireshark-v4.3.0rc0-1430-g600de02805d0

2024-02-12 Thread Guy Harris
On Feb 12, 2024, at 11:09 AM, Oliver Hartkopp wrote: > On 2024-02-12 18:54, Guy Harris wrote: > >> Thus, I specified that all multi-byte fields in the CAN XL header, in >> LINKTYPE_CAN_SOCKETCAN packets, are little-endian (unlike the header for CAN >> classic and CAN

Re: [Wireshark-dev] SocketCAN Support is broken in latest Wireshark-v4.3.0rc0-1430-g600de02805d0

2024-02-12 Thread Guy Harris
On Feb 12, 2024, at 4:04 AM, Oliver Hartkopp wrote: > I assume only ARM(64), X64 and Risc-V architectures will get in contact with > CAN XL. And all these archs are little-endian. And the version of your Lua dissector at

Re: [Wireshark-dev] SocketCAN Support is broken in latest Wireshark-v4.3.0rc0-1430-g600de02805d0

2024-02-12 Thread Guy Harris
On Feb 12, 2024, at 1:21 AM, Guy Harris wrote: > How many processors - as in "number of CPUs", not "number of instruction set > architectures" - capturing CANbus traffic and producing SocketCAN headers are > big-endian, and how many are little-endian? To be more

Re: [Wireshark-dev] SocketCAN Support is broken in latest Wireshark-v4.3.0rc0-1430-g600de02805d0

2024-02-12 Thread Guy Harris
On Feb 12, 2024, at 12:07 AM, Oliver Hartkopp wrote: > I'm sorry but the fix went into the wrong direction and removed the formerly > correct values in the grey'ed line. > > In the attached screenshot you can see from the plain data > > 00 cd 02 42 81 00 0a 00 af af af af 00 00 00 00 >

Re: [Wireshark-dev] SocketCAN Support is broken in latest Wireshark-v4.3.0rc0-1430-g600de02805d0

2024-02-11 Thread Guy Harris
On Feb 11, 2024, at 1:19 PM, Oliver Hartkopp wrote: > Although the Priority 0x242 and the VCID 0xCD are correctly displayed in the > grey line the values below that line seem to be wrong (Priority 52480, VCID > 2). Fixed in Wireshark change fdf4ecdb4aea61f6e557d75172d27ca0ffea79d7. (All

Re: [Wireshark-dev] SocketCAN Support is broken in latest Wireshark-v4.3.0rc0-1430-g600de02805d0

2024-02-11 Thread Guy Harris
On Feb 11, 2024, at 1:19 PM, Oliver Hartkopp wrote: > Shouldn't LINUX_SLL_P_CANXL be set to 0x000E like in > include/uapi/linux/if_ether.h for ETH_P_CANXL instead of 0x000F here? Fixed in libpcap commit 6735956299c5fbc803255a14fa493886e3cf81c6.

Re: [Wireshark-dev] SocketCAN Support is broken in latest Wireshark-v4.3.0rc0-1430-g600de02805d0

2024-02-11 Thread Guy Harris
On Feb 11, 2024, at 1:53 PM, Oliver Hartkopp wrote: > This issue seems to be fixed in libpcap in commit e50355893cd073c0 > ("socketcan: *really* fix CAN FD support.") > > > - canhdr->fd_flags &= > ~(CANFD_FDF|CANFD_ESI|CANFD_BRS); > +

Re: [Wireshark-dev] Input plugin for PEAK Systems CAN interfaces

2024-02-09 Thread Guy Harris
On Jan 4, 2024, at 7:53 AM, Miklós Márton wrote: > The PEAK-CAN to Wireshark question came up again, and I started to work on it > based on this wonderful piece of code: > https://github.com/theXappy/ExtcapNet > > I also reached the point to figure out how to handle over the CAN messages >

Re: [Wireshark-dev] SocketCAN Support is broken in latest Wireshark-v4.3.0rc0-1430-g600de02805d0

2024-02-09 Thread Guy Harris
So the libpcap main and 1.10 branches include changes to not clear the CANFD_FDF flag for FD frames; put the multi-byte fields in the CAN XL header into little-endian byte order; and the Wireshark main and 4.2 branches include changes to treat CAN frames without the

Re: [Wireshark-dev] SocketCAN Support is broken in latest Wireshark-v4.3.0rc0-1430-g600de02805d0

2024-02-08 Thread Guy Harris
On Feb 6, 2024, at 1:24 PM, Guy Harris wrote: > 1) Provide a capture file that contains CAN FD frames but that isn't > correctly dissected, so we can see *why* the FD frames aren't being detected OK, I managed to create the virtual CAN device on Ubuntu 22.04, recently updated, with a 6.

Re: [Wireshark-dev] SocketCAN Support is broken in latest Wireshark-v4.3.0rc0-1430-g600de02805d0

2024-02-06 Thread Guy Harris
On Feb 6, 2024, at 10:42 AM, Oliver Hartkopp wrote: > I'm currently working on CAN XL support which is the latest CAN protocol > after Classical CAN and CAN FD. > > With Wireshark 3.6 I was able to add this dissector for CAN XL >

Re: [Wireshark-dev] Future of Wireshark's Debian packaging scripts in the main repository

2023-12-21 Thread Guy Harris
On Dec 21, 2023, at 6:51 AM, Bálint Réczey wrote: > I'm not sure why libvirt dissector users should be "their users". In my eyes > they are very much our users as well since they use Wireshark extended with > the plugin and I'm happy that they get the best service. It appears that the

Re: [Wireshark-dev] Tracking branches, GitHub and Launchpad

2023-12-17 Thread Guy Harris
On Dec 17, 2023, at 10:08 AM, Jaap Keuter wrote: > 1. The GitHub mirror is picking up all our cherry-pick branches, which now > run in the hundreds. 1.5. Are cherry-pick branches deleted once the changes on those branches are merged into the version branch and, if not, why not? Do they serve

Re: [Wireshark-dev] Changes to the plugin registration API

2023-12-04 Thread Guy Harris
On Dec 3, 2023, at 10:30 PM, Anders Broman wrote: > Does this mean that we are no longer allowing private closed source plug-ins > not distributed outside of companies? To quote the GPL v2 FAQ's question+answer "When is a program and its plug-ins considered a single combined program?":

Re: [Wireshark-dev] The If_fcslen option unit mismatch

2023-11-09 Thread Guy Harris
On Nov 1, 2023, at 2:49 AM, Jaap Keuter wrote: > There’s a recent issue raised on a mismatch between the pcapng spec and > Wireshark interpretation of it. The issue revolves around the unit used for > the If_fcslen option in the pcapng file format. > The Wireshark issue is here: >

Re: [Wireshark-dev] question on validation of a dissected string from a BASE_CUSTOM hf item

2023-09-17 Thread Guy Harris
On Sep 7, 2023, at 9:15 AM, John Dill wrote: > I have a question whether I can get the dissected string of the BASE_CUSTOM > header field so that I can do analysis on it and convert it to floating point > to do range analysis so I can issue an expert info if the value is valid but > out of

Re: [Wireshark-dev] Option to disable Expert Info for issue with frame length

2023-07-24 Thread Guy Harris
On Jul 24, 2023, at 1:47 AM, CheeHow WEE wrote: > Thanks for explaining a detailed "possible" implementation of the packet > alignment in previous mails. > It's actually performed within the given PCIe based FPGA capture card, hence > the packets are stored in the card's memory (presumably a

Re: [Wireshark-dev] Option to disable Expert Info for issue with frame length

2023-07-21 Thread Guy Harris
On Jul 18, 2023, at 8:10 PM, CheeHow WEE via Wireshark-dev wrote: > There's a "padding" added for a 4-bytes aligned PCAP writing API. > - I understood that the latest Wireshark app dev logic such that length > should not be lesser than captured length. > - In highspeed performance (scale of >

Re: [Wireshark-dev] Option to disable Expert Info for issue with frame length

2023-07-21 Thread Guy Harris
On Jul 18, 2023, at 8:10 PM, CheeHow WEE via Wireshark-dev wrote: > There's a "padding" added for a 4-bytes aligned PCAP writing API. > - I understood that the latest Wireshark app dev logic such that length > should not be lesser than captured length. > - In highspeed performance (scale of >

Re: [Wireshark-dev] Handling larger than 2 GB packets in dissectors

2023-07-10 Thread Guy Harris
On Jul 10, 2023, at 12:18 PM, Markku Leiniö wrote: > Anyway, to the point. In Zabbix protocol header > (https://www.zabbix.com/documentation/current/en/manual/appendix/protocols/header_datalen) > the normal data length is 4-byte unsigned integer ("uint32"). However, there > is a flag for

Re: [Wireshark-dev] Wireshark 4.0.1 clone and build fails with test failures and complaints about paths prefixed in the source directory

2023-05-04 Thread Guy Harris
On May 4, 2023, at 10:16 AM, wrote: > Succeeded by -- creating C:\Project\wireshark, cloning in to > C:\Project\wireshark\wireshark, making C:\Project\wireshark\build, and > running CMake from within C:\Project\wireshark\build > > My build directory was also a peer, but not named ‘build’,

Re: [Wireshark-dev] Option to disable Expert Info for issue with frame length

2023-03-29 Thread Guy Harris
On Mar 29, 2023, at 10:10 AM, Duy Khanh Pham wrote: > From your article, I understand that the Captured Packet Length is the Frame > Length/Length on wire/real length and Original Packet Length is the "Capture > Length/captured length" in the attached picture. > > My issue is that the capture

Re: [Wireshark-dev] Option to disable Expert Info for issue with frame length

2023-03-22 Thread Guy Harris
On Mar 22, 2023, at 11:40 AM, Duy Khanh Pham via Wireshark-dev wrote: > My case for this request is when doing network data capturing with a capture > card. The capture card always sets the capture length to a multiple of 4 due > to performance requirement. > > As a result, the real length

Re: [Wireshark-dev] macOS Xcode build failure on multiple commands producing same directory

2023-03-01 Thread Guy Harris
On Mar 1, 2023, at 7:18 AM, Alexander Kapshuk wrote: > Pointers on how to proceed with this would be much appreciated. Short-term? Build with make - or Ninja - instead (that's how the Wireshark buildbots operate). Attempting to figure out why this is an issue with Xcode will probably take

Re: [Wireshark-dev] Dissecting pcapng local block types

2023-02-02 Thread Guy Harris
On Feb 1, 2023, at 12:58 AM, Joakim wrote: > if you manage to add a dissector table that would be great! I believe my > company too will implement non-standard blocks so it would be very convenient > to have it available. Note that what's being discussed here would *only* handle dissecting

Re: [Wireshark-dev] Dissecting pcapng local block types

2023-02-02 Thread Guy Harris
On Jan 28, 2023, at 3:19 PM, Martin Mathieson via Wireshark-dev wrote: > I have 5 non-standardised/local block types that are in-use within my > company, that are in the 'local' range 0x8000-0x. > > My first thought was to add a dissector table (pcapng.block-types ?) by > 'Block

Re: [Wireshark-dev] What is the best way to locate [GLib CRITICAL] -- g_string_free: assertion 'string != NULL' failed

2022-12-23 Thread Guy Harris
On Dec 23, 2022, at 4:17 PM, wrote: > I run Wireshark 4.1.0 with my plugin dissector. It runs well, dissects > packets, reports issues, and behaves as expected. I can load a capture file, > that has packets of my protocol, exit Wireshark, and get no output to the > command line. I can load

Re: [Wireshark-dev] can't compile wireshark version 4.0

2022-10-21 Thread Guy Harris
On Oct 20, 2022, at 10:08 PM, Guy Harris wrote: > Nope, do > > if (!g_ascii_isprint(ba[i]) && !g_ascii_iscntlr(ba[i])) { Done in https://gitlab.com/wireshark/wireshark/-/merge_requests/8606 with a backport to the 4.0 branch in https://gitlab.com/wi

Re: [Wireshark-dev] can't compile wireshark version 4.0

2022-10-20 Thread Guy Harris
On Oct 20, 2022, at 5:15 PM, Guy Harris wrote: > Or just > if (!g_ascii_isprint(ba[i])) { > > as g_ascii_isprint() 1) is a macro, so no subroutine call overhead and 2) > already correctly handles both signed and unsigned char. Nope, do if (!g_asc

Re: [Wireshark-dev] can't compile wireshark version 4.0

2022-10-20 Thread Guy Harris
On Oct 20, 2022, at 4:31 PM, Guy Harris wrote: > #if CHAR_MIN == 0 > #define CHAR_VALUE_IS_NEGATIVE(c) (0) > #else > #define CHAR_VALUE_IS_NEGATIVE(c) ((c) < 0) > #endif > > if ((CHAR_VALUE_IS_NEGAIVE(ba[i]

Re: [Wireshark-dev] can't compile wireshark version 4.0

2022-10-20 Thread Guy Harris
On Oct 20, 2022, at 4:02 PM, Guy Harris wrote: > Definitely signed, unless I'm missing something. Please hand me the Sad Old Man With Fading Memory prize of the year. *Nothing guarantees that a char is signed*. This is still true as of C18: An object declared as type char is la

Re: [Wireshark-dev] can't compile wireshark version 4.0

2022-10-20 Thread Guy Harris
On Oct 20, 2022, at 9:54 AM, Fulko Hew wrote: > My guess as to what could be wrong according to the error is that > ba[i] < '\0' is 'always false' because ba (although declared as a > QByteArray) is probably > an unsigned byte array, Qt 5.12.12 qbytearray.h: inline char *data();

Re: [Wireshark-dev] wireshark extension for a Kernel Module (like Usbmon)

2022-03-06 Thread Guy Harris
On Mar 6, 2022, at 3:52 PM, Christian wrote: > Hello out there, I created a kernel probe module and I want to watch the > outputs of this module with pcap/Wireshark. Just like usbmon. So I > defined a char device in the dev-directory /dev/kpnode from which the > pcap interface can read the

Re: [Wireshark-dev] Build breakage on master?

2022-02-28 Thread Guy Harris
> On Mon, Feb 28, 2022 at 10:58 AM Martin Mathieson via Wireshark-dev > wrote: > >> I am seeing this error on master. Don't have time to look into it just now, >> but I have just made a new VM for building Wireshark. Which object file is >> supposed to implement these? >> >> /usr/bin/ld:

Re: [Wireshark-dev] PCAP-over-IP in Wireshark?

2022-01-31 Thread Guy Harris
On Jan 31, 2022, at 4:56 AM, Erik Hjelmvik wrote: > Is there some way to read PCAP-over-IP in Wireshark? I.e. read a PCAP stream > over a TCP socket. > > Currently, the best solution to read PCAP-over-IP in Wireshark is by using > netcat to read the PCAP stream and forward it to Wireshark's

Re: [Wireshark-dev] Reassembly of split fragments

2022-01-27 Thread Guy Harris
On Jan 26, 2022, at 1:54 PM, Jaap Keuter wrote: > Few remarks. The mix-27010 dissector is made to dissect frames of type > WTAP_ENCAP_MUX27010, or PCAP link layer header type, as defined at > https://tcpdump.org/linktypes/LINKTYPE_MUX27010.html There it states what the > layout in the PCAP

Re: [Wireshark-dev] Future of Wireshark's shared library ABI stability

2022-01-20 Thread Guy Harris
On Jan 20, 2022, at 1:12 PM, Roland Knall wrote: > But it was implemented by utilizing heavily a wireshark installation > including libwireshark and libwsutil So why, *other than "because it uses Wireshark libraries intended to provide directly useful services such as reading capture files or

Re: [Wireshark-dev] Future of Wireshark's shared library ABI stability

2022-01-20 Thread Guy Harris
On Jan 20, 2022, at 12:34 PM, Gerald Combs wrote: > Q: Should *wsutil* be part of that stable ABI? > > Debian, Ubuntu and (according to rpmfind.net) OpenSuSE and Mageia treat it as > such. It would be helpful to know what non-Wireshark packages depend on > wsutil in those distributions and

Re: [Wireshark-dev] Issues with cross-compiling

2022-01-17 Thread Guy Harris
On Jan 16, 2022, at 6:01 PM, Glen Huang wrote: > I’m trying to create an OpenWrt package for Wireshark. > > I think I’m pretty close. However, I got stuck at lemon, which if I’m not > wrong, should be compiled by my build machine’s compiler. From the source > code, I found out it supports the

Re: [Wireshark-dev] Visual Studio 2022

2022-01-15 Thread Guy Harris
On Jan 15, 2022, at 3:09 AM, Gisle Vanem wrote: > Anders Broman wrote: > >> Hi, >> Yes sounds like a good idea. Have been contemplating testing it too. > > I just installed the "Build Tools for Visual Studio 2022" > >

Re: [Wireshark-dev] How do I create a merge request for changes to get into the next 3.6.x release

2021-12-15 Thread Guy Harris
On Dec 15, 2021, at 10:30 PM, Guy Harris wrote: > If the cherry-pick cannot be done automatically, you'll have to do it by > hand, in a tree checked out with the release-3.6 branch. Do the cherry pick > - if you're doing it from the command line, do it with "git cherry-pick -x&

Re: [Wireshark-dev] How do I create a merge request for changes to get into the next 3.6.x release

2021-12-15 Thread Guy Harris
On Dec 15, 2021, at 9:05 PM, Richard Sharpe wrote: > I have submitted merge requests to fix some problems with the S1G > radiotap changes and would like to ensure they get into the next 3.6.x > release because there are now chipsets and adapters shipping with S1G > (Halow) support. > > So, what

Re: [Wireshark-dev] Errors building 3.7 plugins.

2021-12-14 Thread Guy Harris
On Dec 14, 2021, at 5:49 AM, João Valverde wrote: > On 14/12/21 13:39, Gisle Vanem wrote: >> João Valverde wrote: >> >>> you can (and probably should) include "config.h", just like other Wireshark >>> bundled plugins do. >> >> Why does this project not use '-FI./config.h'? > > The header

Re: [Wireshark-dev] Are Capture Filters Implemented in Software or the Network Card?

2021-11-21 Thread Guy Harris
On Nov 21, 2021, at 6:36 PM, Gene Cumm wrote: > FPGA-based network acquisition cards do implement filters in "hardware" (not > in the system CPU). Napatech, Accolade, Silicom and Chelsio have products. So change my statement to ...adapter that do the filtering itself have been

Re: [Wireshark-dev] Are Capture Filters Implemented in Software or the Network Card?

2021-11-21 Thread Guy Harris
On Nov 21, 2021, at 11:06 AM, Guy Harris wrote: > In the capture mechanisms in most UN*Xes (*BSD, macOS, Linux, Solaris, AIX, > and Tru64 UNIX), and in the capture mechanism provided by the WinPcap and > Npcap drivers, all packets received by an interface on which capturing is >

Re: [Wireshark-dev] Are Capture Filters Implemented in Software or the Network Card?

2021-11-21 Thread Guy Harris
On Nov 18, 2021, at 10:53 AM, X Q wrote: > This is a question fairly deep in the guts of Wireshark that I could not find > an answer to. It's so deep in the guts of Wireshark that it's not even in Wireshark! > When a capture filter is implemented are ALL packets sent to >

Re: [Wireshark-dev] USB Attached SCSI dissector

2021-10-25 Thread Guy Harris
On Oct 25, 2021, at 12:03 PM, Tomasz Moń wrote: > The heuristic should not be the main USB traffic detection method > IMHO. The main thing is that people don't necessarily understand that > capturing full enumeration sequence (aka starting capture before > plugging in the device) will give you

Re: [Wireshark-dev] USB Attached SCSI dissector

2021-10-22 Thread Guy Harris
On Oct 22, 2021, at 6:06 PM, Aidan MacDonald via Wireshark-dev wrote: > Second, the hooks provided by the generic USB dissector seemingly aren't a > good fit. Basically, it seems to use only the interface class to decide what > sub-dissector to call, but UASP uses the mass storage class like

Re: [Wireshark-dev] Siemens S7Comm-Plus protocol support

2021-08-19 Thread Guy Harris
On Aug 18, 2021, at 11:16 PM, Brett D. Rasmussen via Wireshark-dev wrote: > I have a question regarding support for the Siemens "s7comm-plus" protocol. > > I'm currently running Wireshark 3.4.7 on a Mac system. (3.4.7 is the latest > version on the Mac) It's the latest version everywhere,

Re: [Wireshark-dev] Ericsson ppcap sample capture

2021-07-05 Thread Guy Harris
On Jul 5, 2021, at 7:38 PM, chuck c wrote: > packet-ppcap.c needs the same change that was done for vss in > https://gitlab.com/wireshark/wireshark/-/merge_requests/3526 > > It's a minor change but I would like to test before and after if possible. > > Can anyone point me to a sample capture

Re: [Wireshark-dev] ASN.1-based dissector decoding by port number vs switch/case using 1st octet

2021-06-27 Thread Guy Harris
On Jun 27, 2021, at 6:36 AM, Vincent Randal wrote: > On Sat, Jun 26, 2021 at 9:41 PM Guy Harris wrote: > >> So this isn't really a Wireshark dissector question, it's a protocol design >> and encoding question. > > I'd like it not to be an encoding question beyond thi

Re: [Wireshark-dev] ASN.1-based dissector decoding by port number vs switch/case using 1st octet

2021-06-26 Thread Guy Harris
So this isn't really a Wireshark dissector question, it's a protocol design and encoding question. The issue isn't "how do I get a Wireshark dissector to distinguish between different message types without giving each message type its own UDP port", it's "how do I get *the recipient of the

Re: [Wireshark-dev] ASN.1-based dissector decoding by port number vs switch/case using 1st octet

2021-06-22 Thread Guy Harris
On Jun 22, 2021, at 6:33 PM, Vincent Randal wrote: > We are using PER per the foo example (Simple ASN.1-based dissector). Wow, I > never about all these different encodings. > > Maybe we should be using something other than PER? We think we like PER > because the dissected values agree with

Re: [Wireshark-dev] ASN.1-based dissector decoding by port number vs switch/case using 1st octet

2021-06-22 Thread Guy Harris
On Jun 21, 2021, at 11:54 PM, Vincent Randal wrote: > The primary question in this email (but I think it requires some explanation > below): How does one write an ASN.1-based dissector such that the generated > code (per "make asn1") does indeed decode the first octet as the message type >

Re: [Wireshark-dev] Getting captured interface name inside plugin

2021-06-07 Thread Guy Harris
On Jun 7, 2021, at 4:15 AM, Jan Mall wrote: > After continuing searching I found this snippet in the UI part: > "epan_get_interface_name(pinfo->epan, > pinfo->rec->rec_header.packet_header.interface_id);" Note that it is permitted to return NULL. Note also that there is no guarantee that

Re: [Wireshark-dev] Getting captured interface name inside plugin

2021-06-06 Thread Guy Harris
On Jun 6, 2021, at 5:41 PM, Jan Mall wrote: > The ultimate goal is an automotive dissector, which takes abstract network > descriptions for automotive buses and dissects the messages on the bus > accordingly. But as every bus has a different set of message definitions, So is there a single

Re: [Wireshark-dev] Getting captured interface name inside plugin

2021-06-06 Thread Guy Harris
On Jun 6, 2021, at 5:13 PM, Jan Mall wrote: > I'm currently developing a plugin/dissector (C API), which should have a > different dissection behavior depending on the interface Wireshark is > currently listening on. Why? What is the *ultimate* goal of this?

Re: [Wireshark-dev] Windows HTML Help

2021-06-01 Thread Guy Harris
On Jun 1, 2021, at 4:14 PM, Gerald Combs wrote: > I just discovered that the HTML Help Workshop download link at > > https://docs.microsoft.com/en-us/previous-versions/windows/desktop/htmlhelp/microsoft-html-help-downloads > > no longer works, and the Chocolatey package now downloads from

Re: [Wireshark-dev] Calling a dissector: Type for data parameter

2021-05-29 Thread Guy Harris
On May 29, 2021, at 12:12 AM, Anders Broman wrote: > Shouldn't the caller be calling with the right data type or NULL? So a bug in > the MQTT disector? How can the MQTT dissector determine what the right data type *is* - especially given that the dissectors aren't wired in, there's a UAT

Re: [Wireshark-dev] Where do release branches come from?

2021-05-23 Thread Guy Harris
On May 23, 2021, at 2:43 PM, chuck c wrote: > There are currently three active branches: > (https://gitlab.com/wireshark/wireshark/-/branches/active) > master, master-3.2 and release-3.4 > > My merge requests are to "master". > If appropriate, it also gets backported >

Re: [Wireshark-dev] Ethernet dissector

2021-05-23 Thread Guy Harris
On May 23, 2021, at 8:58 AM, Antonello Tartamo wrote: > The problem is that I don't have a predefined ether type as the ether type > field is used as length field. So the frames start with: a 6-octet Ethernet destination address; a 6-octet Ethernet source address; a

Re: [Wireshark-dev] my purpose [for building with support for Lua in Linux (Ubuntu 20.04)]

2021-05-22 Thread Guy Harris
On May 22, 2021, at 1:46 PM, Vincent Randal wrote: > On Sat, May 22, 2021 at 3:51 AM Guy Harris wrote: >> On May 21, 2021, at 8:03 PM, Vincent Randal wrote: >> >>> 1. Before running cmake how can I tell the appropriate "with-lua" sort of >>&g

Re: [Wireshark-dev] my purpose [for building with support for Lua in Linux (Ubuntu 20.04)]

2021-05-22 Thread Guy Harris
On May 21, 2021, at 8:03 PM, Vincent Randal wrote: > I've plans to use Lua to control tshark behavior in scripts, IF ... I can get > Wireshark to build with support for Lua in Ubuntu 20.4, ... But so far I am > not having any luck. I found this piece of documentation that says ... > "Wireshark

Re: [Wireshark-dev] Status label for issues

2021-04-27 Thread Guy Harris
On Apr 23, 2021, at 5:29 AM, Uli Heilmeier wrote: > Therefore I would like to create these scoped labels [1]: > > ws-status::unconfirmed => This bug has recently been added to the issue > tracker. Nobody has confirmed that this bug is > valid. > ws-status::confirmed => This bug is valid. >

Re: [Wireshark-dev] Status label for issues

2021-04-27 Thread Guy Harris
On Apr 26, 2021, at 11:43 PM, Uli Heilmeier wrote: > I have no strong feelings about the os::* labels. We can reduce them to > os::mac, os::windows, os::linux, os::unix. So does "unix" mean: 1) has some possibly very-remote code base connection to some UNIX that AT put out;

[Wireshark-dev] Rough consensus and quiet humming

2021-04-22 Thread Guy Harris
https://twitter.com/MeghanEMorris/status/1382109954224521216/photo/1 ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe:

Re: [Wireshark-dev] Writing a wtap module for CommView WLAN Analyzer and Decoder NCFX format files

2021-04-19 Thread Guy Harris
On Apr 19, 2021, at 10:02 AM, Richard Sharpe wrote: > On Sun, Apr 18, 2021 at 9:30 PM Guy Harris wrote: > >> We may want to change the 802.11 pseudo-header to have data rates in units >> of 100 Kb/s rather than 500 Kb/s, to handle NCFX and possibly other files. >

Re: [Wireshark-dev] Clearly, someone thought no one should be using CommView after 2038

2021-04-18 Thread Guy Harris
On Apr 18, 2021, at 10:18 PM, Eugène Adell wrote: > probably the guy writing this considered the "Epochalypse" problem. Or wanted *some* test to help rule out files that are probably not ConnView NCF files (there is no file header, so there's no file magic number, and there's no packet magic

Re: [Wireshark-dev] Writing a wtap module for CommView WLAN Analyzer and Decoder NCFX format files

2021-04-18 Thread Guy Harris
On Apr 18, 2021, at 2:33 PM, Richard Sharpe wrote: > I am thinking of writing a wtap module to read ComView WLAN Analyzer > and Decoder NCFS format files. > > They are a little like PCAP files with a radiotap header, ...and a bit more like CommView NCF files, which we already support. > One

Re: [Wireshark-dev] (1) building Wireshark in build.wireshark fails, (2) how to get dissector details without packet

2021-04-15 Thread Guy Harris
On Apr 15, 2021, at 3:46 PM, Vincent Randal wrote: > I managed to save my terminal window contents. It's over 1MB compressed. $ mkdir build.wireshark $ cd build.wireshark $ cmake .. >cmake.out 2>&1 $ make -j 16 >errs 2>&1 $ ls -lh cmake.out errs

Re: [Wireshark-dev] (1) building Wireshark in build.wireshark fails, (2) how to get dissector details without packet

2021-04-15 Thread Guy Harris
On Apr 15, 2021, at 2:03 AM, Graham Bloice wrote: > Wireshark is a complicated project to build. You can follow the tested way, > as shown in the Developers Guide, which is essentially what our Continuous > Integration (CI) systems use and most other developers, or you can forge your > own

Re: [Wireshark-dev] (1) building Wireshark in build.wireshark fails, (2) how to get dissector details without packet

2021-04-15 Thread Guy Harris
On Apr 15, 2021, at 8:10 AM, Vincent Randal wrote: > Where is the build log? In the file to which you redirected the standard output and error of the make command - or the file created by tee, if piped the standard output and error of the make command to "tee errs" so that the errors are

Re: [Wireshark-dev] (1) building Wireshark in build.wireshark fails, (2) how to get dissector details without packet

2021-04-15 Thread Guy Harris
On Apr 15, 2021, at 12:55 AM, Vincent Randal wrote: > (1) building Wireshark in build.wireshark fails > The solution here is to use "build" as the name of the build directory and > then make succeeds. Otherwise, if the build directory has some other name > like build.wireshark then make fails

Re: [Wireshark-dev] How to build the simple ASN.1 UDP-based dissector example (foo)

2021-04-13 Thread Guy Harris
On Apr 13, 2021, at 5:36 PM, Vincent Randal wrote: > If it’s important not to break wireshark-2.6.20 It's not. All I'm saying there is that there are different levels of support: for Windows and macOS, we do CI builds, so we know Wireshark builds and runs, and supply binaries;

Re: [Wireshark-dev] How to build the simple ASN.1 UDP-based dissector example (foo)

2021-04-13 Thread Guy Harris
On Apr 13, 2021, at 9:21 AM, Pascal Quantin wrote: > 13 avr. 2021 17:36:20 John Thacker : > > > Depending on your build system, the other ASN.1 dissectors can be > > regenerated with either > > > > ninja asn1 > > Or > > make asn1 > > > > without starting the full build process. > >

Re: [Wireshark-dev] How to build the simple ASN.1 UDP-based dissector example (foo)

2021-04-13 Thread Guy Harris
On Apr 13, 2021, at 6:03 AM, Vincent Randal wrote: > I'm building Wireshark on Linux. Wireshark documentation refers to it as UNIX > or UNIX-like. Linux is one of the UNIX-like systems we support, yes. We also officially support macOS, and the build process may also work on FreeBSD, NetBSD,

Re: [Wireshark-dev] ASN.1 dissector Wireshark

2021-04-12 Thread Guy Harris
On Apr 12, 2021, at 10:08 PM, Vincent Randal wrote: > Thank you (John) for delving into a nice description of the overall process. > I do have a couple more questions for you and the group: > 1. What is the meaning of "work is in progress to at least read all ASN1 > specifications" ??? > I'm

Re: [Wireshark-dev] Bugzilla -> Gitlab failed migration

2021-04-06 Thread Guy Harris
On Apr 6, 2021, at 12:11 PM, Uli Heilmeier wrote: > Just discovered that Bugzilla bugs 5379 [1] and 8161 [2] haven't been > migrated successfully to Gitlab issues. > > Both issues have state "opened" and Bugzilla status is "RESOLVED FIXED". > Furthermore Bugzilla comments are missing in > the

Re: [Wireshark-dev] Adding GPS data from Kismet as Expert Info?

2021-03-30 Thread Guy Harris
On Mar 29, 2021, at 2:13 AM, Erik Hjelmvik wrote: > I have discovered that Kismet can generate pcap-ng files that contain GPS > coordinates stored in custom option fields. I've started thinking about how > this GPS data can be represented in Wireshark or tshark. The GPS options are > attached

Re: [Wireshark-dev] Issue about tvb_reported_length_remaining() and tvb_captured_length_remaining() of tvb passed from Lua

2021-03-27 Thread Guy Harris
On Mar 27, 2021, at 3:47 AM, qiangxiong.huang wrote: > Where is the bug? If it a bug belongs to packet-protobuf.c, I can submit a > merge for it. But If it belongs to wslua_tvb.c, who familiar with the code > wslua_tvb.c may help fix. It's a bug in wslua_tvb.c, and it's now fixed (I've

Re: [Wireshark-dev] Automated builds failing for macOS since MR 2136 was applied

2021-03-27 Thread Guy Harris
On Mar 27, 2021, at 5:49 AM, Jim Young wrote: > We've had failing macOS builds since the commit set from > https://gitlab.com/wireshark/wireshark/-/merge_requests/2136 was > applied. Fixed. ___ Sent via:Wireshark-dev

Re: [Wireshark-dev] 16 byte integer decoding

2021-03-22 Thread Guy Harris
On Mar 22, 2021, at 11:35 AM, Constantine Gavrilov wrote: > There are two repeated patterns for this: > > 1. For capacity (bytes, blocks, etc.). > 2. For units (how many times). > > So, I am thinking about two formats: > 1. For bytes. > 2. For units. > > The implementation would get high and

Re: [Wireshark-dev] Is there a way to easily go to the next packet that satisfies a filter string without filtering the packets

2021-03-20 Thread Guy Harris
On Mar 20, 2021, at 2:23 PM, ronnie sahlberg wrote: > Doesn't wireshark already have this? > > CTRL-F and then type in the filter string > then click "Find" and it will cycle through the packets that are matching. Yes, "Find" (Ctrl-F on Windows and UN*Xes not named "macOS", Command+F on

Re: [Wireshark-dev] Is gitlab having problems?

2021-03-14 Thread Guy Harris
On Mar 14, 2021, at 8:18 PM, Richard Sharpe wrote: > Seems to be a browser issue. I tried a different browser and it worked > but the original browser refused to work. Butbutbut... I thought the Web was a platform? You mean it's multiple incompatible platforms? :-) File a GitLab issue on

[Wireshark-dev] ASAN - now for Windows

2021-03-14 Thread Guy Harris
https://devblogs.microsoft.com/cppblog/address-sanitizer-for-msvc-now-generally-available/ ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe:

Re: [Wireshark-dev] Issue cleanup (admin privs needed)

2021-03-12 Thread Guy Harris
On Mar 12, 2021, at 10:06 AM, chuck c wrote: > https://gitlab.com/wireshark/wireshark/-/issues/16587 > Typing after Display Filter Macro crashes gui > > https://gitlab.com/wireshark/wireshark/-/issues/16778 > Display Filter Macros Crash Wireshark Fixed (with some liberties taken to add

Re: [Wireshark-dev] Issue cleanup (admin privs needed)

2021-03-12 Thread Guy Harris
On Mar 12, 2021, at 10:21 AM, Pascal Quantin wrote: > Hi Chuck, > > Le ven. 12 mars 2021 à 19:07, chuck c a écrit : >> https://gitlab.com/wireshark/wireshark/-/issues/16587 >> Typing after Display Filter Macro crashes gui >> >> https://gitlab.com/wireshark/wireshark/-/issues/16778 >> Display

[Wireshark-dev] Time to update to Npcap 1.20

2021-03-11 Thread Guy Harris
It looks as if it fixes some annoying bugs: https://github.com/nmap/npcap/blob/master/CHANGELOG.md so if we haven't already updated the Wireshark Windows builds to include the 1.20 installer, we should do so. Anybody who's been having problems - especially if they're the ones noted:

Re: [Wireshark-dev] Struggling to rebase

2021-03-05 Thread Guy Harris
On Mar 5, 2021, at 3:07 PM, Maynard, Christopher via Wireshark-dev wrote: >> From: Wireshark-dev On Behalf Of chuck >> c >> Sent: Friday, March 5, 2021 5:26 PM >> To: Developer support list for Wireshark >> Subject: Re: [Wireshark-dev] Struggling to rebase >> >> But sometimes I'm this guy:

Re: [Wireshark-dev] File rename impacts Gitlab history

2021-02-26 Thread Guy Harris
On Feb 26, 2021, at 8:48 AM, chuck c wrote: > https://gitlab.com/wireshark/wireshark/-/commit/50dbe4df7fd7a5e4e1a27fd5046981486d350994 > Rename packet-ssl* to packet-tls* > > Looking through history of > https://gitlab.com/wireshark/wireshark/-/commits/master/epan/dissectors/packet-tls.c > >

Re: [Wireshark-dev] pcapng decoding error when preamble is shortened

2021-02-19 Thread Guy Harris
On Feb 19, 2021, at 9:50 PM, Jaap Keuter wrote: > It’s not a matter of *what* the program is reading, but *where* it's reading > in the buffer. This makes it usable for *all* programs reading this file > format, not just Wireshark. Prefixing it with zero padding (even a nibble) > would

Re: [Wireshark-dev] pcapng decoding error when preamble is shortened

2021-02-18 Thread Guy Harris
On Feb 16, 2021, at 4:03 AM, Timmy Brolin wrote: > In practice, this is what I would propose: > * Wireshark dissector made capable of accepting any whole-byte preamble > length mPackets. > * mPacket capture devices are made responsible for detecting any frames with > non-integer preamble, and

Re: [Wireshark-dev] Help finding the link layer dissector call (netmon_802_11)

2021-02-16 Thread Guy Harris
On Feb 16, 2021, at 2:41 AM, Shai Shapira via Wireshark-dev wrote: > I'm researching Microsoft's Network Monitor captures format (.cap files) Unfortunately, you probably can't download NetMon from Microsoft any more, so you probably can't get the help file that documents the capture file

Re: [Wireshark-dev] pcapng decoding error when preamble is shortened

2021-02-16 Thread Guy Harris
At various points in February 2021, Timmy Brolin wrote: > Would anyone mind if I submit a merge request which makes Wireshark capable > of dissecting all valid Ethernet mPackets according to IEEE 802.3br? I.e. according to the spec that says, on page 39: * 99.3.2 Preamble The

Re: [Wireshark-dev] Gerrit commit missing in Gitlab

2021-02-09 Thread Guy Harris
On Feb 9, 2021, at 4:57 PM, Guy Harris wrote: > "Doesn't exist" as in "immediately tells you no such commit" or as in "takes > a long time and eventually gives you a 500 error"? I get the latter; > presumably that's "500 Internal Server Error".

Re: [Wireshark-dev] Gerrit commit missing in Gitlab

2021-02-09 Thread Guy Harris
On Feb 9, 2021, at 3:26 PM, chuck c wrote: > 2eb7b05b - Convert most UDP dissectors to use "auto" preferences. > > Exists in Gerrit: > https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2eb7b05b8c9c6408268f0d1e81f0a18a02610f1c > > Links to it in Gitlab on these pages: >

  1   2   3   4   5   6   7   8   9   10   >