Re: [Wireshark-dev] RTP player on Windows/Qt 6.x do not play any sound

of multimedia objects and sends events different way. It triggered race condition on Win32 which randomly caused observed misbehaving. Best regards, Jirka Novak

[Wireshark-dev] RTP player on Windows/Qt 6.x do not play any sound

developing on Linux. 6) All other and audio related functions works fine so it looks that the wireshark code is correct. Any ideas or advices are welcomed. Best regards, Jirka Novak

Re: [Wireshark-dev] Future of extcap "API"

Hi, I drawn attached diagram. It can became part of developers doc when finished. Please, comment it. Wireshark is the one who creates command line for extcap - name of binary and its parameters. This information should be passed to helper and it will run command line. How to pass this

Re: [Wireshark-dev] Future of extcap "API"

Hi, On Tue, Aug 23, 2022 at 6:24 PM Jirka Novak wrote: The problem with GenerateConsoleCtrlEvent() is that the caller has to be attached to the target process console. While we could technically do so, it requires freeing any already open console because process can be attached to at most one

Re: [Wireshark-dev] Missing text2pcap-scanner.l in repository

Hi,    By chance I noticed that there is text2pcap-scanner.c which is based on text2pcap-scanner.l, but the file is not in repository.    It was there, but was removed.    Was removal intended? Yes, ui/text_import_scanner.l now handles processing both for text2pcap

[Wireshark-dev] Missing text2pcap-scanner.l in repository

Hi, By chance I noticed that there is text2pcap-scanner.c which is based on text2pcap-scanner.l, but the file is not in repository. It was there, but was removed. Was removal intended? Best regards,

Re: [Wireshark-dev] Future of extcap "API"

Hi, Adding another helper may be helpful, as it would probably gives us greater control, and maybe also solve the "helper-script" issue in the future by putting that stuff inside Wireshark? I am just wondering if it is worth the effort. We can obviously strive for a perfect - no user

Re: [Wireshark-dev] Future of extcap "API"

l shutdown. When timer expires, kill/terminate extcap. 2) If pipe is not supported, kill/terminate extcap immediately. Best regards, J

Re: [Wireshark-dev] Future of extcap "API"

Hi, 3) It makes sense to me even I didn't tried it yet. My understanding of documentation is that 3) is more preferred in Win32 world. I see important that name of event must be agreed between wireshark and extcap. E.g. if generic "Wireshark_shutdown" is used, it shutdowns every extcap

Re: [Wireshark-dev] Future of extcap "API"

regards, Jirka Novak ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman

Re: [Wireshark-dev] Future of extcap "API"

Hi, On Sat, Aug 6, 2022 at 1:09 PM Jirka Novak wrote: Extcap API: i) When extcap is started, dumpcap pass name of pipe to it and where it expects captured data. ii) STDOUT/STDERR is used to report messages/errors of extcap to wireshark, but it is shown/evaluated at the end of capture

Re: [Wireshark-dev] How UDP dissector finds RTP protocol

lse positives. When ii) is unchecked, no heuristics is made for RTP. So RTP is then recognized only when signaling is seen in advance (step 1) or 'Decode as' is used (step 2). Best regards,

Re: [Wireshark-dev] Parameters for extcap

for review/acceptance. Best regards, Jirka Novak ___ Sent via:Wireshark-dev mailing list Archives:https://www.wir

Re: [Wireshark-dev] wslog, windows, pytest, and heap corruption

, logging and windows so it might be related. Best regards, Jirka Novak ___ Sent via:Wireshark-dev mailing list Archives

Re: [Wireshark-dev] wslog, windows, pytest, and heap corruption

touched this part. João Valverde, can you check our findings? Best regards, Jirka Novak ___ Sent via:Wireshark-dev

Re: [Wireshark-dev] pre-commit error: extcap.c: error: found these preference variables used in more than one prefs_register_*_preference:

ion will pass... done as part of updated !5519. I expect it will be compiled with no issues now. Best regards, Jirka No

Re: [Wireshark-dev] pre-commit error: extcap.c: error: found these preference variables used in more than one prefs_register_*_preference:

fine to move your MR forward. No one should be expected to fix the limitations of checkAPIs.pl IMO. I will add exception to checkAPIs.pl in separate MR and then compilation will pass... Best regards,

Re: [Wireshark-dev] pre-commit error: extcap.c: error: found these preference variables used in more than one prefs_register_*_preference:

hecks so it can be extended to e.g. ignore arg->pref_valptr in this case. Best regards, Jirka Novak ___ Sent via:Wireshark

[Wireshark-dev] pre-commit error: extcap.c: error: found these preference variables used in more than one prefs_register_*_preference:

Can I ask for help? Best regards, Jirka Novak ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lis

[Wireshark-dev] Wireshark do not stop extcap on exit if no packets received yet

Hi, I noticed issue #17781. I think that something like: if (capture_in_progress) captureStop(); should be used. I spend several hours with finding correct place where to fix it, but with no success. I'm not able to track as signals are passed in the code in this case (no data

[Wireshark-dev] How to allow Wireshark to stop extcap on Windows?

when pipe read happened - if no API used, no read from pipe will be started so it is "legacy" procedure for simple extcaps Any comments and ideas welcomed. Best regards, J

Re: [Wireshark-dev] How to troubleshoot extcap applications?

Hi Roland, > Could we additionally add a note to README.extcap? Just in case, some > external extcap tools sumble across this as well? I think there is no README.extcap. There is just extcap.adoc, but it is about application, not about code/API. BTW I'm missing it. Or do you think any other

[Wireshark-dev] How to troubleshoot extcap applications?

Hi, I noticed issue below and I propose a solution for it. Can I ask for comments? Every extcap tool has --debug and --debug-file options, but when they are used, it do "nothing". File is created, but it is empty. Later I found that it must be used with --log-level=debug to really log

Re: [Wireshark-dev] Parameters for extcap

Dear Roland, > Both issues where done so by design. I expect so, but it makes issues during use :-( > For the password, there was a reasonable concern, that passwords may be > read-out. Now, you could argue, that monitoring the cumpcap call gives > you the password anyway, which is correct. The

[Wireshark-dev] Parameters for extcap

? Best regards, Jirka Novak ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https

Re: [Wireshark-dev] How to stop extcap gracefully

Hi Roland, > Due to the nature of extcaps, they are not explicitly closed. Instead, > you should monitor the created pipes. Dumpcap closes those pipes when > the capture has finished. We do send them a kill signal, but due to the > nature of the signal handling, this signal may be missed. > >

[Wireshark-dev] How to stop extcap gracefully

Hi, I'm working on ciscodump extcap. The the application creates settings on Cisco device and when it ends, it clears settings. The issue is that when capture is stopped during capture, the application is stopped and settings stays on Cisco device. I added signal handling to ciscodump so

Re: [Wireshark-dev] How to generate epan/dissectors/packet-skinny.c?

Hi ALexis, > from packet-skinny.c.in > # Dependencies: > # - python2.x > # - cog.py: (pip install cogapp / http://nedbatchelder.com/code/cog/ > ) > # - python.xml > # - python.xml.sax > # > > Tested on Ubuntu 18.04 (TLS) (with

[Wireshark-dev] How to generate epan/dissectors/packet-skinny.c?

Hi, based on notice of Jörg Mayer (thank you), I tried to generate epan/dissectors/packet-skinny.c from epan/dissectors/packet-skinny.c.in. The command line should be: cog.py -D xmlfile=tools/SkinnyProtocolOptimized.xml -d -c -o epan/dissectors/packet-skinny.c

Re: [Wireshark-dev] Sample of IAX2 with RTP

itter. So in some cases it calculates obvious nonsense. Please, check https://gitlab.com/wireshark/wireshark/-/issues/17600 if I'm correct. Nevertheless I'm still missing IAX2 with RTP sample... Best regards,

[Wireshark-dev] Sample of IAX2 with RTP

ark. Best regards, Jirka Novak ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/li

Re: [Wireshark-dev] How to disable QT_MULTIMEDIA_LIB during cmake

Hi Roland, I see your merge request. So my task is to review it and make it running with QT_MULTIMEDIA_LIB undefined, right? BTW it was my original idea to do. Best regards, Jirka Novak

[Wireshark-dev] How to disable QT_MULTIMEDIA_LIB during cmake

Hi, I would like to test whether #ifdef QT_MULTIMEDIA_LIB are correct in source code so I need to disable it during cmake detection. Is there something like there was --nofeature in autoconfigure? Best regards,

Re: [Wireshark-dev] Status label for issues

Hi Uli, > For issues (especially bugs) I really miss the status field which was > available with Bugzilla. > > Therefore I would like to create these scoped labels [1]: > ... > > Any objections? Comments are very welcome. I agree with you. I'm missing this information about created issues

[Wireshark-dev] How to recognize that live capture is running?

? Best regards, Jirka Novak ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev

Re: [Wireshark-dev] Fwd: Tshark feature request

ke to use for 'Mean' and 'Avg'. For example provide formulas, short sample and expected results for formula - you can probably use RTP Analysis to get inputs for calculation. Best regards, Ji

Re: [Wireshark-dev] Proposal: New set of help pages for VoIP dialogs

Hi Jaap, > You could instead think about adding to the user guide, where this stuff > should be in the first place. I updated user guide, but even it was merged, old pages are shown on: https://www.wireshark.org/docs//wsug_html_chunked/ChTelRTPAnalysis.html Do you know correct procedure to

[Wireshark-dev] Proposal: New set of help pages for VoIP dialogs

ki to make it clear? Any comment welcomed. Best regards, Jirka Novak ___ Sent via:Wireshark-dev mailing list Archives

[Wireshark-dev] File extension is missing on Linux when WiresharkFileDialog::getSaveFileName/QFileDialog::getSaveFileName is used

of Wireshark code are aware of it and fix it and some do not. Should I try to modify WiresharkFileDialog to handle it for all cases? Best regards, Jirka Novak

[Wireshark-dev] How to decode specific packet with custom Decode as from dialog?

de as rule temporary? Decode as dialog saves it to preferences, but I hope there is simpler way. Can I ask for help and guidance? Best regards, J

[Wireshark-dev] Missing ChTelRtpPlayer page in Wireshark documentation

was there in past and was removed or it didn't existed ever? Best regards, Jirka Novak ___ Sent via:Wireshark-dev mailing list

[Wireshark-dev] Counterpart shortcut for Select All

welcomed. Jirka Novak ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman

Re: [Wireshark-dev] Procedure to solve/close issues in Gitlab

Hi Pascal, > Le mar. 9 févr. 2021 à 12:51, Jirka Novak <mailto:j.no...@netsystem.cz>> a écrit : > > Hi, > >   what is proposed procedure to solve and close issues in Gitlab? > >   During conversion to gitlab all bugzilla issues were created as >

[Wireshark-dev] Procedure to solve/close issues in Gitlab

. Can I or someone else close them? Best regards, Jirka Novak ___ Sent via:Wireshark-dev mailing list Archives

Re: [Wireshark-dev] What mean "Error: Found prohibited APIs in ..." error during build?

s methods. E.g. open() to QIODevice::open(). This is already checked in checkAPIs.pl and it solved the issue. Thank you all for help. Best regards, Jirka Novak ___

Re: [Wireshark-dev] What mean "Error: Found prohibited APIs in ..." error during build?

        if ($cnt > 0) { >                         push @{$foundAPIsRef}, $api; >                         $groupHashRef->{function_counts}->{$api} += 1; >                 } > > This probably needs to be improved for your use case. OK, I will try it.

Re: [Wireshark-dev] What mean "Error: Found prohibited APIs in ..." error during build?

check in this case? Best regards, Jirka Novak ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/w

[Wireshark-dev] What mean "Error: Found prohibited APIs in ..." error during build?

. Compilation and code works fine, just this check failed. See https://gitlab.com/j.novak/wireshark/-/jobs/1016432967 What to check or change? Best regards, Jirka Novak

Re: [Wireshark-dev] Dissector functions and variables that could be static

um_names) > is not referred to so could be static? That two functions are not used at all. Can we remove them? Best regards, Jirka Novak __

Re: [Wireshark-dev] Revive the happy-shark repository?

ght be optional. We can record/track which commit broken which samples. For every build we can create "statistics" e.g. how many samples are decoded correct way (mean same way as stored in happy-shark repository). Best regar

Re: [Wireshark-dev] How to disable controls in dialog when capture file is closing

rds, Jirka Novak ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-

[Wireshark-dev] How to disable controls in dialog when capture file is closing

emembers why framework was changed to current state? Best regards, Jirka Novak ___ Sent via:Wireshark-dev mailing list Archiv

Re: [Wireshark-dev] Fwd: bug 11723

> Yes, I will definitely try to fix it and submit a patch. OK. Jirka Novak ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubs

Re: [Wireshark-dev] Fwd: bug 11723

rm that I see increasing counter of packets and extending Comments after every press of Play Streams. It happens with any pcap with VoIP calls I tested. On the other hand, I see correctly decoded audio. Your observation is clearly bug. Do you plan to fix it yourselves?

Re: [Wireshark-dev] Fwd: bug 11723

. :-) It looks like issue I fixed some time ago in master branch. Try latest developer build for master if you still see it. BTW I hope I fixed the issue with "Warn remove_tap_listener(): no listener found with that tap data" mentioned in the bug too.

Re: [Wireshark-dev] How to transfer change in dissector from master to current branch?

h is minor feature adding :-) OK, I will wait. Thank you for clarification. Best regards, Jirka Novak ___ Sent via:Wireshar

[Wireshark-dev] How to transfer change in dissector from master to current branch?

branch. How to do so? Should I commit it as one big patch again? Best regards, Jirka Novak ___ Sent via:Wireshark-dev mailing list

Re: [Wireshark-dev] How code recognizes that processing of all packets with tap was finished?

ented), each place using tapping with "finish" must check whether it is running on live capture or not. I'm afraid that such API will be difficult to use. Jirka Novak __

Re: [Wireshark-dev] How code recognizes that processing of all packets with tap was finished?

apture must say it can't play or there must be a button "play now" which will probably remove listeners and detach from tapping live stream. Note: The reason why I'm thinking about mixing is that I found no reliable way how to play synchronized multiple audio streams with Qt. Therefore the only way I

Re: [Wireshark-dev] How code recognizes that processing of all packets with tap was finished?

that live capture is running and file is not complete in point 3/4) c) dialog must call remove_tap_listener() before close and remove_tap_listener() must call "finish" Probably c) makes sense and can be implemented.

Re: [Wireshark-dev] How code recognizes that processing of all packets with tap was finished?

Hello, I responding with delay... > On Jun 21, 2018, at 12:26 PM, Jirka Novak wrote: > >>>> What is correct way to recognize that capture processing with tap was >>>> finished? >>> >>> There isn't one, unfortunately. We'd have to change t

[Wireshark-dev] Where to store temporary data during processing RTP data?

of storing data. Any comments are welcomed. Best regards, Jirka Novak ___ Sent via:Wireshark-dev mailing list Archives

Re: [Wireshark-dev] How code recognizes that processing of all packets with tap was finished?

o do so? I found at least two places where it should be useful: 1) my case, of course :-) 2) sharkd (see sharkd_session.c, taps_free) Therefore I think it would be useful. Best regards,

[Wireshark-dev] How code recognizes that processing of all packets with tap was finished?

, Jirka Novak ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ

Re: [Wireshark-dev] How to test sharkd?

t I don't know purpose (understand client side) of sharkd. Therefore I'm afraid to changing it... Best regards, Jirka No

[Wireshark-dev] How to test sharkd?

? Best regards, Jirka Novak ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev

[Wireshark-dev] Proposal: Multiline display filter input field

characters I think it make sense to implement it in Qt only. I can work on it. What do you think about it? Best regards, Jirka Novak __

Re: [Wireshark-dev] Packet sample repository/library?

Hello, is there any feedback to pull request about happy-shark? Sincerely yours, Jirka Novak ___ Sent via:Wireshark-dev mailing

Re: [Wireshark-dev] RTP player - a suggestion

is an silence, but I need to analyse it "as it is" before I find "interesting" place in the call. When you imagine that you need to process multiple RTP streams with week duration and then create additional mixed stream for playing and then something more for downsampling... I have a

Re: [Wireshark-dev] RTP player - a suggestion

changes for Qt will induce changes for GTK. The option could be copy all related ui/ files and split them for GTK and Qt. But I'm not sure whether it is good approach. Sincerely yours, Jirka Novak ___

Re: [Wireshark-dev] RTP player - a suggestion

sing before any library/mixer should be made. Based on this, code should be cleared. Sincerely yours, Jirka Novak

[Wireshark-dev] Multiple rtp_stream_info structures for RtpAudioStream?

situation when it can happen. It will help me when anyone will provide capture, when it can happen. I'm looking forward to test new code with it... Sincerely yours, Jirka Novak

Re: [Wireshark-dev] Packet sample repository/library?

l request. Sincerely yours, Jirka Novak ___ Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives:https://www.wireshark.org/lists/wireshark-

Re: [Wireshark-dev] Packet sample repository/library?

Hello, did anyone reviewed my proposed changes in happy-shark? Sincerely yours, Jirka Novak ___ Sent via:Wireshark-dev mailing

Re: [Wireshark-dev] What is different in compilation/linking of tshark and wireshark?

-common.h. BTW, "common" word do not express real purpose of this file - I will try to find better name for it... Thank you for your help. Sincerely yours, Jirka Novak ___

[Wireshark-dev] What is different in compilation/linking of tshark and wireshark?

have advice to do/to check? Sincerely yours, Jirka Novak Making all in . make[2]: Entering directory 'wireshark-git' PERL version.h version.h unchanged. CXXLDwireshark CCLD

Re: [Wireshark-dev] How to modify existing RTP conversation?

ted as full/bidirectional, I checked it with enabled > DEBUG_CONVERSATION. Sincerely yours, Jirka Novak ___ Sent via:

Re: [Wireshark-dev] Packet sample repository/library?

Sincerely yours, Jirka Novak ___ Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives:https://www.wireshark.org/lists/wireshark-dev Unsu

Re: [Wireshark-dev] Packet sample repository/library?

and I found no way how to made it different way. Therefore I cloned repository on my account :-( I'm looking forward to learn how to do make pull request from main repo. Sincerely yours,

Re: [Wireshark-dev] Packet sample repository/library?

welcomed. Sincerely yours, Jirka Novak ___ Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives:https://www.wireshark.org/list

Re: [Wireshark-dev] Packet sample repository/library?

it makes sense to store/compare 1-pass and 2-pass outputs separated? If so, should it be stored for each output type (text and pdml)? Sincerely yours, Jirka Novak ___

Re: [Wireshark-dev] Packet sample repository/library?

ollaborator list? Sincerely yours, Jirka Novak ___ Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives:https://www.wireshark.org/lists/wir

Re: [Wireshark-dev] How to modify existing RTP conversation?

Sincerely yours, Jirka Novak ___ Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives:https://www.wireshark.org/lists/wireshark-dev Uns

[Wireshark-dev] How to modify existing RTP conversation?

rom which is conversation valid. But it do not work in this case, because "full" conversation does exists. Sincerely yours, Jirk

Re: [Wireshark-dev] Packet sample repository/library?

in frame X" link) and these > would show in the tshark -2 output as well. how can I submit my work to happy shark? BTW I prefer commit it to branch and merge when it will be reviewed... Sincerely yours,

Re: [Wireshark-dev] RTP player redesign in 2.x makes it worse than the legacy one

e input. Therefore it will take a time before I will change features you mentioned. Sincerely yours, Jirka Novak ___ Sent

Re: [Wireshark-dev] Packet sample repository/library?

37a/ed137a-1/ed137a-1.pcapng.gz ./tests/rtp.ed137a/ed137a-1/filter.xsl ./scripts/sample_test.sh ./scripts/sample_make_output.sh ./scripts/sample_verify.sh Sincerely yours, Jirka Novak happy-shark

Re: [Wireshark-dev] Packet sample repository/library?

w sample contains expected information. Something like git review procedure for wireshark source/gerrit. Sincerely yours, Jirka Novak _

Re: [Wireshark-dev] RTP sample with wrap around timestamp?

Hello Erik, > This one is a little longer, hope it is sufficient for you. Otherwise > you'll have to wait a bit until I'm home from work. this one is OK. Thank you very much. Jirka

Re: [Wireshark-dev] RTP sample with wrap around timestamp?

Hi Erik, > Is something like this useful for you? yes, thank you. Do you have a sample a little longer - e.g. 20-30 packets before and after counter wrap? Sincerely yours, Jirka No

[Wireshark-dev] Packet sample repository/library?

, Jirka Novak ___ Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/o

[Wireshark-dev] RTP sample with wrap around timestamp?

:-) Do anyone have such sample? Sincerely yours, Jirka Novak ___ Sent via:Wireshark-dev mailing list <wireshark-