Re: [Wireshark-dev] pinfo->fd->flags.visited for wireshark c dissector

2016-01-06 Thread Jaap Keuter
On 06-01-16 19:12, Jeff Morriss wrote: > > > On Wed, Jan 6, 2016 at 12:48 PM, Pascal Quantin > wrote: > > > > 2016-01-06 8:30 GMT+01:00 Ran Bao >: > > Hi > > I am currently implementing a dissector plug

[Wireshark-dev] Req for modification coverity build command line

2016-02-16 Thread Jaap Keuter
Hi, For whomever handles the Coverity builds this is a request to add the '-P' command line option for the compilation of the ASN.1 dissectors at least. Little background for the uninitiated: Coverity has what's called a build wrapper which 'intercepts' compilation commands as they are executed b

Re: [Wireshark-dev] Shift to Github?

2016-03-04 Thread Jaap Keuter
On 04-03-16 20:49, Sahil Shekhawat wrote: > Hi everyone! > > I am new here and considering developing a plugin for gRPC protocol. Since, I > am > just getting started, I am wondering why haven't we shifted to Github if we > are > already using a web based code review system? > > I know that the

[Wireshark-dev] Anyone willing to solve this ancient MAPI bug?

2016-03-10 Thread Jaap Keuter
Hi all, There's a bug (with a long grey beard by now) in packet-dcerpc-mapi.c:mapi_dissect_bitmap_ulEventType() where it reads flags (16 bits) and then goes on to add bits to the tree, including bits 30 and 31 (called fnevReserverForMapi and fnevExtended). I've got no idea what these should be, so

Re: [Wireshark-dev] Anyone willing to solve this ancient MAPI bug?

2016-03-12 Thread Jaap Keuter
On 11-03-16 17:25, Alexis La Goutte wrote: > > > On Thu, Mar 10, 2016 at 11:58 PM, Jaap Keuter <mailto:jaap.keu...@xs4all.nl>> wrote: > > Hi all, > > There's a bug (with a long grey beard by now) in > packet-dcerpc-mapi.c:mapi_dissect_bitmap

Re: [Wireshark-dev] How do I log into gerrit these days?

2016-03-12 Thread Jaap Keuter
On 10-03-16 05:55, Richard Sharpe wrote: > On Wed, Mar 9, 2016 at 10:43 AM, Graham Bloice > wrote: >> >> >> On 9 March 2016 at 18:06, Richard Sharpe >> wrote: >>> >>> Hi folks, >>> >>> Need to review some stuff. Where/what are the instructions? >>> >> >> https://wiki.wireshark.org/Development/Sub

Re: [Wireshark-dev] How do I log into gerrit these days?

2016-03-13 Thread Jaap Keuter
On 12-03-16 18:32, Richard Sharpe wrote: > On Sat, Mar 12, 2016 at 4:47 AM, Jaap Keuter wrote: >> On 10-03-16 05:55, Richard Sharpe wrote: >>> On Wed, Mar 9, 2016 at 10:43 AM, Graham Bloice >>> wrote: >>>> >>>> >>>> On 9 March

Re: [Wireshark-dev] How do I log into gerrit these days?

2016-03-13 Thread Jaap Keuter
On 13-03-16 17:23, Richard Sharpe wrote: > On Sun, Mar 13, 2016 at 4:53 AM, Jaap Keuter wrote: >> On 12-03-16 18:32, Richard Sharpe wrote: >>> On Sat, Mar 12, 2016 at 4:47 AM, Jaap Keuter wrote: >>>> On 10-03-16 05:55, Richard Sharpe wrote: >>>>> O

Re: [Wireshark-dev] #ifdef mess

2016-04-02 Thread Jaap Keuter
On 30-03-16 00:48, Joerg Mayer wrote: > On Tue, Mar 29, 2016 at 03:34:38PM +0100, João Valverde wrote: >> On 28-03-2016 23:30, Joerg Mayer wrote: >>> I've been meaning to write this mail for some years now but finally got >>> around to it. >>> >>> Earlier today I committed 30900b443b85a7e760d703ca

[Wireshark-dev] New Coverity issues from new scanner/parser

2016-04-08 Thread Jaap Keuter
Hi list, After the merge of change 14719 (https://code.wireshark.org/review/#/c/14719/) a new series of 50 Coverity issues (CID-1358125 .. CID-1358175) has been recorded. They all indicate the same issue in every instantiation of the scanner, a "Dereference after null check" issue, eg. C

Re: [Wireshark-dev] New Coverity issues from new scanner/parser

2016-04-08 Thread Jaap Keuter
On 08-04-16 19:32, Guy Harris wrote: > On Apr 8, 2016, at 1:28 AM, Jaap Keuter wrote: > >> While this work is fresh, could this be addressed? > > That would presumably be done by arranging that the version of Flex > generating those files have this bug: > >

Re: [Wireshark-dev] formatted time in dissector

2016-05-05 Thread Jaap Keuter
Hi, You've done this the right ways, for a single instance representation. If this is a representation that would be needed more often (as in, is commonly used in various dissectors) it can be added to the ftypes system (see epan/ftypes), in this case ftype-time.c. I could image it being handled v

[Wireshark-dev] Why does Telephony|ANSI have a Lua submenu?

2016-06-11 Thread Jaap Keuter
See Subject. True for both Qt and GTK build. Thanks, Jaap ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-de

[Wireshark-dev] Why does the SCTP submenu appeat twice?

2016-06-11 Thread Jaap Keuter
See subject. Only in the Qt version, in both Analyze and Telephony menu. Also where's the Chunk count gone? Thanks, Jaap ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev

Re: [Wireshark-dev] Why does Telephony|ANSI have a Lua submenu?

2016-06-11 Thread Jaap Keuter
27;/Wiki' to action group 'MenuActionGroup' Thanks, Jaap On 12-06-16 01:29, Pascal Quantin wrote: > Hi Jaap, > > 2016-06-11 16:12 GMT-07:00 Jaap Keuter <mailto:jaap.keu...@xs4all.nl>>: > > See Subject. > > True for both Qt and GTK buil

Re: [Wireshark-dev] Why does the SCTP submenu appeat twice?

2016-06-11 Thread Jaap Keuter
Well it does, it's the main protocol of SIGTRAN. On 12-06-16 01:43, Pascal Quantin wrote: > > > 2016-06-11 16:18 GMT-07:00 Jaap Keuter <mailto:jaap.keu...@xs4all.nl>>: > > See subject. > > Only in the Qt version, in both Analyze and Telephony menu

Re: [Wireshark-dev] Why does the SCTP submenu appeat twice?

2016-06-11 Thread Jaap Keuter
wrote: > > > 2016-06-11 16:55 GMT-07:00 Jaap Keuter <mailto:jaap.keu...@xs4all.nl>>: > > Well it does, it's the main protocol of SIGTRAN. > > > Good to know. Then I guess that's why, even if it is a bit surprising. >

[Wireshark-dev] My build broke, very unusual

2016-06-16 Thread Jaap Keuter
Hi, Hasn't happened in a while, but my build broke. Probably after https://code.wireshark.org/review/15985 Build is being done on Debian Testing. Am I missing something? Thanks, Jaap ... Making all in ui/qt make[2]: Entering directory '/home/jaap/src/wireshark/master/ui/qt' CXX voip_calls

Re: [Wireshark-dev] My build broke, very unusual

2016-06-17 Thread Jaap Keuter
And solved again :) https://code.wireshark.org/review/15995 Thanks, Jaap On 17-06-16 08:49, Jaap Keuter wrote: > Hi, > > Hasn't happened in a while, but my build broke. > Probably after https://code.wireshark.org/review/15985 > Build is being done on Debian Testing. Am

Re: [Wireshark-dev] Adding dynamic fields to tree from dissector

2016-06-18 Thread Jaap Keuter
Hi, Yes indeed, we try to make sure that the most important feature (the filtering) works as well as possible, which is undermined by using the add_text() API. What you are saying is that there is no way to know how the message looks like until you’ve received it. That’s not unusual. But are y

Re: [Wireshark-dev] Console output from dissectors

2016-06-29 Thread Jaap Keuter
Hi, No, the console output is strictly for debug purposes only, either via printf of g_log. These printf() statements are all wrapped in DEBUG for conditional compilation, so should not result in code when compiled for production. Thanks, Jaap > On 29 Jun 2016, at 09:47, Dario Lombardo wrot

[Wireshark-dev] AsciiDoc level 5 title

2016-07-07 Thread Jaap Keuter
Hi list, AsciiDoc itself only goes as far as level 4 titles, using = level 4 AsciiDoctor adds a level 5 to it, through the config file. This file is fead to A2X when generating the documentation, but the HTML output of the toolchain shows == level 5 instead of the expected 11.4.1

[Wireshark-dev] Considering ignoring Coverity 'tainted' checks

2016-07-11 Thread Jaap Keuter
Hi List, Since (not so) recently the Coverity code analysis has added a checker for so called tainted data. This data is considered coming from an external source (eg. the network) hence suspicious until validated. Using these tainted values is considered a risk. In general this is true, Wiresh

Re: [Wireshark-dev] Schedule for master-2.2 and upcoming releases

2016-07-21 Thread Jaap Keuter
Hi List, It happened! branch master-2.2 was created in the repository. Start backporting your changes to master-2.0 *and* master-2.2 now, when appropriate. Thanks, Jaap On 20-07-16 01:36, Gerald Combs wrote: > Unless anyone has any objections I'd like to create the Wireshark > master-2.2 branc

Re: [Wireshark-dev] Schedule for master-2.2 and upcoming releases

2016-07-22 Thread Jaap Keuter
> > On 22 Jul 2016, at 08:11, Alexis La Goutte wrote: > > Hi, > > > On Fri, Jul 22, 2016 at 7:56 AM, Jaap Keuter wrote: > Hi List, > > It happened! branch master-2.2 was created in the repository. > Start backporting your changes to master-2.0 *and* master-2

Re: [Wireshark-dev] Small bug in Modbus dissector exception information

2016-08-01 Thread Jaap Keuter
Hi, It's solved, but does that 'exception bit' get dissected? Thanks, Jaap On 30-07-16 16:20, Dennis Luehring wrote: > Done: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12693 > > Am 30.07.2016 um 08:40 schrieb Roland Knall: >> Hi >> >> Please report this in a bug-report on https://bugs

Re: [Wireshark-dev] question about tshark output

2016-08-03 Thread Jaap Keuter
Hi, The absence of the value simply means the value is not there, which, given the field you requested, isn’t a surprise. Try reshuffling the order of fields requested and see what happens. Thanks, Jaap > On 03 Aug 2016, at 11:14, Martin Sehnoutka wrote: > > Hi, > > I have a question about

Re: [Wireshark-dev] Cannot open include file: ‘moduleinfo.h’: No such file or directory

2016-08-05 Thread Jaap Keuter
This is were we write documentation for, in this case doc/README.plugins. You should have a look. > On 05 Aug 2016, at 14:08, Paul Offord wrote: > > Hi Pascal, > > Ha – I feel a bit stupid for not noticing that. > > Thanks and regards…Paul > > From: wireshark-dev-boun...@wireshark.org >

Re: [Wireshark-dev] Documentation error in README.dissector?

2016-08-08 Thread Jaap Keuter
Hi, Yes, you could raise a bug. Or try to submit a change rewording this text. Thanks, Jaap On 06-08-16 12:16, Paul Offord wrote: > Hi, > > > > README.dissector describes two accessor functions that access null terminated > strings and return the string length. The document says: > > >

Re: [Wireshark-dev] Downgrading my dev environment

2016-08-09 Thread Jaap Keuter
On 09-08-16 19:06, Paul Offord wrote: > Hi, > > > > I’ve develop two dissectors as a prelude to tacking the conversion of the > TRANSUM LUA to a C version. In my enthusiasm (and laziness) I just did a git > pull of the latest code from the repository. I’d like to build the TRANSUM > code > a

[Wireshark-dev] My master-2.2 build broke

2016-08-09 Thread Jaap Keuter
Hi list My build breaks in two ways $ configure The Wireshark package has been configured with the following options: GLib version : v2.48.1 Build wireshark : yes (with Qt4 v4.8.7) Build wireshark-gtk : yes (with GTK+ v3.20.6)

Re: [Wireshark-dev] Test decryption ESP and ISAKMP on wireshark

2016-08-11 Thread Jaap Keuter
Hi, Tshark uses the same dissection engine as Wireshark does and uses the same files. So if you work out which files contains the relevant data you can set these up, do a Tshark run with required parameters and check the (text) output. Thanks, Jaap > On 11 Aug 2016, at 11:51, Codrut Grosu

Re: [Wireshark-dev] My master-2.2 build broke

2016-08-11 Thread Jaap Keuter
:35, Jaap Keuter wrote: > > Hi list > > My build breaks in two ways > > $ configure > > The Wireshark package has been configured with the following options: > > > GLib version : v2.48.1 > > >

Re: [Wireshark-dev] Cmake and RPM

2016-08-17 Thread Jaap Keuter
Congratulations with the successful build of the RPMs. If anything, you could file a bug with your main considerations, but with Jeff on the case this might be in good hands already. Thanks, Jaap > On 17 Aug 2016, at 11:39, Jonne Zutt wrote: > > The "File listed twice" is a known issue I've r

Re: [Wireshark-dev] Has anyone created an XDR to Dissector tool?

2016-09-01 Thread Jaap Keuter
Hi, Libvirt seems to have some Google SoC source code related to Wireshark dissection of RPC data (that’s XDR based). http://libvirt.org/git/?p=libvirt.git;a=tree;f=tools/wireshark;hb=HEAD Maybe it’s a start? Thanks, Jaap > On 01 Sep 2016, at 00:19, Richard Sharpe wrote: > > Hi folks, > >

Re: [Wireshark-dev] Remove of GTK interface

2016-09-05 Thread Jaap Keuter
Hi, Even though this is an expected course of events, there is no timeline as of yet. So even though the GTK UI may be lacking features it could still be part of 2.4. So for now it has to remain, and relevant changes should be made not to break it. Thanks, Jaap > On 05 Sep 2016, at 15:06,

Re: [Wireshark-dev] Has anyone created an XDR to Dissector tool?

2016-09-05 Thread Jaap Keuter
Hi, Having zero knowledge of the original code here’s some remarks anyway. @@ -364,7 +370,7 @@ open_input (const char *infile, const char *define) if (infile) - addarg (infile); + addarg (infilename); addarg ((char *) NULL); This must be a general thing then? infile vs.

Re: [Wireshark-dev] Wireshark-dev Digest, Vol 124, Issue 20

2016-09-06 Thread Jaap Keuter
Hi, Try to read and understand this article about how to join an open source project. https://opensource.com/life/15/2/developers-guide-getting-involved-open-source If you choose the Wireshark project there are a lot of on line resources to consult: https://www.wireshark.org/develop.html https

Re: [Wireshark-dev] Docker image for WS Build

2016-10-06 Thread Jaap Keuter
> On 06 Oct 2016, at 09:53, Roland Knall wrote: > > Hello > > I've created a docker image, to build Wireshark for a Linux build. You can > find it on > > https://hub.docker.com/r/rknall/wsbuilder/ > > It contains Qt5, Lua and libssh, and can be used for building docker in a > Jenkins envi

Re: [Wireshark-dev] Linking on OSX Sierra

2016-10-21 Thread Jaap Keuter
Hi Francisco, That looks to me that the Wireshark splash image isn’t properly packed. There are two version of it, one standard (called wssplash.png) which is used in the released versions, and one development (called wssplash_dev.png) which is used in the development versions. Somehow the appl

Re: [Wireshark-dev] VoIP Calls dialog enhancements

2016-10-21 Thread Jaap Keuter
Hi Erik, Glad you liked Sharkfest Europe, we enjoyed it too. As for your ideas, you should have a peek at the other diagrams being used in Wireshark to see how these handle timestamp related items. Usually these kept generic, so (design) could be reused). A checkbox would probably be the way to

Re: [Wireshark-dev] Problem with val_to_str inside BASE_CUSTOM callback function

2016-10-21 Thread Jaap Keuter
On 21-10-16 19:47, Guy Harris wrote: > On Oct 21, 2016, at 9:57 AM, Thomas Wiens wrote: > >> This happens only when calling val_to_str inside the callback function. >> When outside, then all is Ok (getting formatted result string on failure). >> When I'm calling try_val_to_str_idx with a non exis

Re: [Wireshark-dev] value_string from file

2016-11-07 Thread Jaap Keuter
Hi, While not ideal, it can be done. Have a look at packset-tpncp.c and the wimaxasncp plugin Thanks, Jaap > On 07 Nov 2016, at 12:25, Jeroen Sack wrote: > > Hi, > > I am developing a dissector for ISO11783 (ISObus) which is using object IDs > which are constant per application. I have a

Re: [Wireshark-dev] Actualize kafka dissector

2016-11-13 Thread Jaap Keuter
On 11-11-16 22:13, Dmitry Lazurkin wrote: > Hello. > > I try to investigate kafka. For now kafka dissector supports only main > requests/responses and does not support it actual versions. I want to > actualize > dissector. May i do this task? > Sure you may. I would suggest first creating a bu

Re: [Wireshark-dev] Actualize kafka dissector

2016-11-14 Thread Jaap Keuter
On 14-11-16 21:50, Dmitry Lazurkin wrote: >> Sure you may. > Thanks. > > Ok, i have some questions. > > First questions about supported and unsupported packet versions. > Kafka packets have "API Version" field. I will try to show problem with > example. > Latest version of kafka server supports

Re: [Wireshark-dev] Actualize kafka dissector

2016-11-15 Thread Jaap Keuter
> On 15 Nov 2016, at 18:05, Dmitry Lazurkin wrote: > > > How to test kafka dissector? Catch real kafka session? Randpkt? Unit-tests? > Test by collecting real kafka sessions and work with fuzz-test.sh Thanks, Jaap ___ Se

Re: [Wireshark-dev] Difference between proto_item_set_len and proto_item_set_end

2016-11-19 Thread Jaap Keuter
On 19-11-16 16:41, Dmitry Lazurkin wrote: > Hello. > > Function proto_item_set_len modifies fi->value.value.bytes->len, but > proto_item_set_end doesn't make same thing. Is it bug? > An omission maybe. Guy, Stig, Martin, care to comment? Thank, Jaap

Re: [Wireshark-dev] Work with Kafka wiki page and can not overwrite attachments

2016-11-25 Thread Jaap Keuter
Hi, I’m not sure this is the most convenient way to show sample captures, for the following reasons: - This requires extra work to get at the captures - Captures attached to SampleCaptures are easier to find - These then can also be used in the menagerie, for automatic regression testing of futu

Re: [Wireshark-dev] Wiki editing privileges

2016-12-20 Thread Jaap Keuter
Hi Dario, Done. Thanks, Jaap > On 20 Dec 2016, at 09:35, Dario Lombardo wrote: > > Can I be added as well (crondaemon)? > > On Tue, Dec 20, 2016 at 9:09 AM, Alexis La Goutte > wrote: > > > On Mon, Dec 19, 2016 at 10:54 PM, John Thacker wrote: > Hi, > > I would like for my user account

Re: [Wireshark-dev] (no subject)

2016-12-27 Thread Jaap Keuter
Well, you are… It’s a community thing, where lots of input is collected and made available to the public. So go browse through the resources and find a place where you feel you can contribute. Enjoy. > On 26 Dec 2016, at 14:53, Jonathan Mator wrote: > > I want to be part of this organizatio

Re: [Wireshark-dev] Correct way to add bytes to tree

2016-12-28 Thread Jaap Keuter
Hi, Sharing part of the relevant code would help answer your question, eg. the proto_add_ calls tested. Thanks, Jaap > On 28 Dec 2016, at 19:09, Juan Jose Martin Carrascosa wrote: > > Hi all, > > I have what I need to add bytes to a tree using proto_tree_add_item or > proto_tree_add_bytes.

Re: [Wireshark-dev] How to modify existing RTP conversation?

2017-01-02 Thread Jaap Keuter
Hi, I would like to know where this is done: I analysed the code and found that for #1 is created "full" conversation (full = SRC_IP:SRC_PORT <-> DST_IP:DST_PORT) with UDP as protocol. because that sounds questionable. Thank, Jaap > On 1 Jan 2017, at 21:21, Jirka Novak wrote: > > Hello, >

[Wireshark-dev] Overview of MPLS PW bugs

2017-01-07 Thread Jaap Keuter
Introduction There has been a steady stream of MPLS PW related comments and bugs over time, and things haven't improved enough, apparently. This text tries to give some insight in the issues so that possible solutions cover all cases involved. Background Multi Protocol Label Switching (MPLS) is

Re: [Wireshark-dev] git-review fails with an SSL error

2017-01-17 Thread Jaap Keuter
Hi Paul, Just a note. You didn’t 'clone master this morning'. What happened is that you cloned the whole repository, and then checked out the master branch into a work area. I’m noting that, because it’s imperative that you build the right mental model when working with git. Tricky at first, b

[Wireshark-dev] display filter background color - GTK interface

2017-02-01 Thread Jaap Keuter
Hi, Is it just me, or is the background color for the display filter entry no longer working in the GTK interface? Thanks, Jaap ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wiresha

[Wireshark-dev] Preferences dialog width - GTK interface

2017-02-05 Thread Jaap Keuter
Hi, Does anyone else get ridiculous wide (as in over 2000 px wide) preference dialog on GTK development build? It seems that the new 'title only' preferences, of RDP, DAP, SAP, etc, are long lines, which are wrapped in the Qt interface, but not in the GTK interface. Thanks, Jaap _

Re: [Wireshark-dev] Preferences dialog width - GTK interface

2017-02-05 Thread Jaap Keuter
On 05-02-17 21:28, Alexis La Goutte wrote: > > > On Sun, Feb 5, 2017 at 7:52 PM, Jaap Keuter <mailto:jaap.keu...@xs4all.nl>> wrote: > > Hi, > > Does anyone else get ridiculous wide (as in over 2000 px wide) preference > dialog > on GTK develo

Re: [Wireshark-dev] Preferences dialog width - GTK interface

2017-02-05 Thread Jaap Keuter
> On 6 Feb 2017, at 00:08, Peter Wu wrote: > > On Sun, Feb 05, 2017 at 10:42:32PM +0100, Jaap Keuter wrote: >> On 05-02-17 21:28, Alexis La Goutte wrote: >>> >>> >>> On Sun, Feb 5, 2017 at 7:52 PM, Jaap Keuter >> <mailto:jaap.keu...@xs4all.

Re: [Wireshark-dev] Preferences dialog width - GTK interface

2017-02-06 Thread Jaap Keuter
> On 6 Feb 2017, at 07:43, Jaap Keuter wrote: > >> >> On 6 Feb 2017, at 00:08, Peter Wu wrote: >> >> On Sun, Feb 05, 2017 at 10:42:32PM +0100, Jaap Keuter wrote: >>> On 05-02-17 21:28, Alexis La Goutte wrote: >>>> >>>> >&g

Re: [Wireshark-dev] Submitting a fix to 2.2.4

2017-02-11 Thread Jaap Keuter
> On 10 Feb 2017, at 21:29, Guy Harris wrote: > > On Feb 10, 2017, at 11:58 AM, Michael Mann wrote: > >> (git review may work, but I've never tried it outside of master branch) > > I have, and it works, at least for me. > Me 2 ___

Re: [Wireshark-dev] Release package for Mac

2017-02-12 Thread Jaap Keuter
> On 10 Feb 2017, at 21:07, Simon Barber wrote: > > How do I build an installer for Mac? > > make package generates something weird, and make dmg_package requires > PackageMaker > > What is used for official builds? > You can always have a look at the buildbot to see how it’s done: https://

Re: [Wireshark-dev] Wireshark no longer builds on SuSE 11.3

2017-02-15 Thread Jaap Keuter
Hi, As this seems simple enough, and saves us from raising the bar on GLIB_MINIMUM_VERSION I’ll see to it that the offending code is replaced by the implementation listed. Just give me a second or two, okay? ;) Thanks, Jaap > On 14 Feb 2017, at 13:57, Anders Broman wrote: > > Hi, > The code

Re: [Wireshark-dev] Loading value_string from file?

2017-02-15 Thread Jaap Keuter
Hi, Main reason would be startup time. It takes time to load and parse these (Big!) files every time you start up. Yes, they do change/get amended, therefore we update them for the releases as long as they are maintained. That should be good enough. It’s a best effort compromise, IMHO. Thanks,

[Wireshark-dev] DBAR revisited

2017-02-15 Thread Jaap Keuter
Hi all, Yet again we are confronted by Dell Backup And Restore, through https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13414 I can imagine Gerald (and users) getting sick and tired of marking duplicate bugs, in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12036 Does this warrant to r

Re: [Wireshark-dev] Search for binary symbols across Wireshark releases with the help of ABI Navigator

2017-02-22 Thread Jaap Keuter
I like it. > On 22 Feb 2017, at 09:35, Andrey Ponomarenko > wrote: > > Hello, > > I'd like to present a new project called "ABI Navigator" for searching binary > symbols (functions, global data, etc.) in Wireshark and other open-source > libraries: https://abi-laboratory.pro/index.php?view

Re: [Wireshark-dev] How to see where exception occurs in Malformed packets

2017-03-03 Thread Jaap Keuter
Hi, Glib logging won't help you much, as in, malformed packet dissection isn't a problem in the underlying infrastructure of the program (which would cause said log messages to be generated), but a exception caught by the dissection engine itself. The common way to get forward is to retrieve the s

Re: [Wireshark-dev] MPEG2-TS, DVB-SI, and DVB-GSE Dissectors

2017-03-18 Thread Jaap Keuter
On 18-03-17 21:11, Alexander Adolf wrote: > Hello Martin, > > On 2017-03-17, at 16:22 , Martin Kaiser wrote: > >> [...] >> good to see you again. We worked together in the DVC-CI+ group back in >> 2014. > > Good seeing you again! I believe to remember it was the meeting in Munich? > >> I hope

Re: [Wireshark-dev] attribution/copyright

2017-04-07 Thread Jaap Keuter
Hi, Look at doc/packet-PROTOABBREV.c in the source code repository. There you’ll find the boilerplate for files to be included in Wireshark. Use that and you should be fine. Thanks, Jaap > On 7 Apr 2017, at 00:12, Simon Barber wrote: > > Are there rules for the copyright message at the top of

[Wireshark-dev] The build broke on the recent X11 changes

2017-04-18 Thread Jaap Keuter
Hi, I get this building Wireshark: make[6]: Entering directory '/home/jaap/src/wireshark/master/epan/dissectors' CC packet-x11.lo packet-x11.c: In function ‘dissect_x11_request’: packet-x11.c:3753:13: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]

Re: [Wireshark-dev] The build broke on the recent X11 changes

2017-04-18 Thread Jaap Keuter
e, Apr 18, 2017 at 6:34 PM, Jaap Keuter <mailto:jaap.keu...@xs4all.nl>> wrote: > > Hi, > > I get this building Wireshark: > > make[6]: Entering directory > '/home/jaap/src/wireshark/master/epan/dissectors' > CC packet-x

Re: [Wireshark-dev] Fwd: Malformed packet 802.11 A-MSDU subframe length

2017-04-26 Thread Jaap Keuter
Hi,Since we’re are 2.0.12 at the moment it would be interesting to see if that has been addressed already.If not, then a bug report would be most welcome, once bugzilla is up-and-running again.Thanks,JaapOn 26 Apr 2017, at 15:50, Levente Mészáros wrote:Dear Members,I'm

Re: [Wireshark-dev] So why does building stuff in the docbook directory use DocBook URLs *and* disable fetching stuff over the net?

2017-04-29 Thread Jaap Keuter
Hi, This fails when there’s no catalog to map the URL to a local resource. I remember from the 1.10 days this was somewhat tricky to get right. We used to have a catalog.xml in the repository, but it’s no more. So it has to come from the system itself now. Thanks, Jaap > On 29 Apr 2017, at 05:

Re: [Wireshark-dev] So why does building stuff in the docbook directory use DocBook URLs *and* disable fetching stuff over the net?

2017-04-29 Thread Jaap Keuter
t; On Apr 29, 2017, at 1:56 AM, Jaap Keuter wrote: > >> This fails when there’s no catalog to map the URL to a local resource. > > What is a "local resource" in this context? Why is there a need to map it to > a local resource, rather than just reading it from the U

[Wireshark-dev] wiretap plugin

2017-05-09 Thread Jaap Keuter
Hi list, Does anyone currently have a wiretap plugin setup for building in current master? It seems that the plugin Makefile abstractions (plugins/Makefile.am.inc) are geared to dissector plugins, while tools/make-dissector-reg is still capable of making a plugin_wtap as well. And I haven’t eve

Re: [Wireshark-dev] wiretap plugin

2017-05-09 Thread Jaap Keuter
lugins. Top level CMakeListCustom.txt > etc > Regards > Anders > > -Original Message- > From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of > Jaap Keuter > Sent: den 9 maj 2017 11:12 > To: Developer support list for Wireshark > Subje

Re: [Wireshark-dev] wiretap plugin

2017-05-09 Thread Jaap Keuter
c > plugin_wtap > ${DISSECTOR_SRC} > ) > > > Regards > Anders > > > > -Original Message- > From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of > Jaap Keuter > Sent: den 9 maj 2017 13:48 > To: Developer s

Re: [Wireshark-dev] wiretap plugin

2017-05-10 Thread Jaap Keuter
ule(void) > { > > It looks like, it works with cmake...(at least on Wimdows) > Regards > Anders > > > -Original Message- > From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of > Jaap Keuter > Sent: den 9 maj 2017 17:14 > To: Develo

Re: [Wireshark-dev] wiretap plugin

2017-05-11 Thread Jaap Keuter
les/usbdump.dir/all' failed make[1]: *** [plugins/usbdump/CMakeFiles/usbdump.dir/all] Error 2 Makefile:149: recipe for target 'all' failed make: *** [all] Error 2 While my plugin code has this registration function: void wtap_register_usbdump(void) { ... } Thanks, Jaap

Re: [Wireshark-dev] wiretap plugin

2017-05-12 Thread Jaap Keuter
d consider breaking out make-plugin-reg.py, which deals explicitly with plugins, unless there's strong opposition against it. Oh, and this only works with CMake so far. Autotool build is broken as well. Thanks, Jaap On 12-05-17 08:00, Jaap Keuter wrote: > Hi Anders, > > What symbol

Re: [Wireshark-dev] Get name resolution for IEEE 802.15.4 MAC address

2017-05-17 Thread Jaap Keuter
Hi, If all is well I could see the Ethers file of use here? https://www.wireshark.org/docs/wsug_html_chunked/ChAppFilesConfigurationSection.html Thanks, Jaap On 17-05-17 13:53, Remy Leone wrote: > Hello, > > I would like to know if it's possible for Wireshark to have IEEE 802.15.4 MAC > addres

[Wireshark-dev] About wtap_pkthdr pack_flags

2017-05-18 Thread Jaap Keuter
Hi list, Why has wrap.h the following entry: struct wtap_pkthdr { ... guint32 pack_flags; /* XXX - 0 for now (any value for "we don't have it"?) */ ... }; while packet-frame.c defines numerous masks, e.g.: #define PACKET_WORD_DIRECTION_MASK0x0003 #define

[Wireshark-dev] Troubles with ASN generated code

2017-05-18 Thread Jaap Keuter
Hi list, There's a conflict in the use of external data in the Q932 dissector. Either it doesn't work on Windows or breaks the GCC6 build on UN*X. See https://code.wireshark.org/review/#/c/21690/ Thomas is asking for your input to help resolve this conflict. Me personally had to revert the rele

Re: [Wireshark-dev] Troubles with ASN generated code

2017-05-19 Thread Jaap Keuter
On 19-05-17 00:14, Jaap Keuter wrote: > Hi list, > > There's a conflict in the use of external data in the Q932 dissector. > Either it doesn't work on Windows or breaks the GCC6 build on UN*X. > > See https://code.wireshark.org/review/#/c/21690/ > > Thoma

Re: [Wireshark-dev] Troubles with ASN generated code

2017-05-20 Thread Jaap Keuter
On 19-05-17 18:38, Jaap Keuter wrote: > On 19-05-17 00:14, Jaap Keuter wrote: >> Hi list, >> >> There's a conflict in the use of external data in the Q932 dissector. >> Either it doesn't work on Windows or breaks the GCC6 build on UN*X. >> >>

Re: [Wireshark-dev] Troubles with ASN generated code

2017-05-20 Thread Jaap Keuter
On 19-05-17 19:44, Guy Harris wrote: > For example, if libwireshark exports a value_string table, I'm not sure all > the platforms we support would allow a plugin dissector to point to that > value_string from one of its header fields. I think we're seeing that with TFS (true/false strings). We

Re: [Wireshark-dev] master branch of Wireshark/tshark hangs

2017-05-23 Thread Jaap Keuter
Hi, You could inspect the bug database, but as far as I know this is not a known issue. Your setup seems rather normal, so that should not be cause for any problems. If you could investigate further into tun / named pipe capture behaviour that could be interesting. Thanks, Jaap > On 23 May 2

Re: [Wireshark-dev] Fixing #12958 (Duplicated keys in -T json output)

2017-06-14 Thread Jaap Keuter
On 13-06-17 12:10, Daan De Meyer wrote: > Is creating the change on the code review site all I need to do or is some > other > step required before the patch can get reviewed? Hi, That is enough for the change to reviewed. Whenever that will be depend on interest and spare time availability of t

Re: [Wireshark-dev] Adding support to Wireshark for CSV, TSV and SSV data types

2017-06-19 Thread Jaap Keuter
Hi, So is this an attempt to make Wireshark into a glorified log file viewer? Kinda like Maslow's hammer? Thanks, Jaap > On 19 Jun 2017, at 12:06, Paul Offord wrote: > >> Do you mean "deal with arbitrary CSV and TSV files" or "deal with IIS Web >> logs that are in CSV and TSV format"? > >

Re: [Wireshark-dev] hf_http_response_code in packet-http.c

2017-07-15 Thread Jaap Keuter
Hi all, I remember a similar discussion around the Contents-Length header some years ago. Can’t we make a similar solution here? Then everyone will be happy and we have a backwards compatible solution. Thanks, Jaap > On 13 Jul 2017, at 22:41, Sultan, Hassan via Wireshark-dev > wrote: > >

Re: [Wireshark-dev] Setting to disable all expert info

2017-08-02 Thread Jaap Keuter
Are we going to be picking off features one by one to get the memory footprint down? Then I see a long list of preference settings growing from this. Not something I look forward to. On 02-08-17 20:43, Sultan, Hassan via Wireshark-dev wrote: > Hi, > > > > Am I right in my understanding that t

Re: [Wireshark-dev] G729

2017-08-06 Thread Jaap Keuter
Hi Dario, I’ve already posted a note to Debian Bug 785480 ITP: bcg729 -- ITU G.729 Annex A compatible audio codec (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=785480 ) to make them aware of the recent Wireshark developments in th

[Wireshark-dev] Bugs no longer autoclose?

2017-08-25 Thread Jaap Keuter
Hi, Could it be that Gerrit-Bugzilla interaction is partially broken wrt. bug status? e.g. bug 14004 has a change uploaded and merged (as noted in the comments) but its status is still stuck at ‘UNCONFIRMED’. Even though it should have been moved to “IN_PROGRESS”, now that the change is merged

Re: [Wireshark-dev] Bugs no longer autoclose?

2017-08-26 Thread Jaap Keuter
he +2 and submitting) because I'm not a script writer, but > until the issue is addressed, it would be appreciated if developers would > close their bugs once patches with Bug: tagline are submitted. > > > > -Original Message- > From: Jaap Keuter > To:

Re: [Wireshark-dev] Some updates to the Profinet plugin

2017-08-31 Thread Jaap Keuter
Hi, The location seems okay to me. But did you push it to Gerrit? I can’t find it at https://code.wireshark.org/review/#/q/status:open This is the best reference on this subject I have: https://wiki.wireshark.org/Development/SubmittingPatches

Re: [Wireshark-dev] How to use Wireshark dissectors and header fields? (looking for "WORKING" examples for windows)

2017-09-09 Thread Jaap Keuter
HI, Take it in small steps Padawan, gaining experience takes time. Q1: See the reply from Pascal earlier. Q2: C and Lua are fundamentally different programming languages. - C is used for the main program and all build in dissectors. These are the most capable. - Lua is used as an

Re: [Wireshark-dev] Enrich tshark data

2017-09-09 Thread Jaap Keuter
Hi Conall, You’re quite in the right place here to put forward these questions. I’ll have a go and try to answer them. What you spotted is the HTTP dissector adding the HTTP status field to the protocol tree (https://code.wireshark.org/review/gitweb?p=wireshark.git;a=blob;f=epan/dissectors/pac

Re: [Wireshark-dev] causes for losing COL_PROTOCOL or COL_INFO data

2017-09-18 Thread Jaap Keuter
Hi John, Rule of thumb: don’t use ‘if (tree)...’ constructs. They have little if any use, don’t really save processing time (all wireshark functions are capable of handling tree==NULL), and cause more trouble than it’s worth (as you’re in right now). Some of the finer details are that Wireshar

Re: [Wireshark-dev] Newbie

2017-10-09 Thread Jaap Keuter
Hello Peter, Welcome to the club :) You’ve made the first important step, building Wireshark itself. Now you can start by going through the menu’s and see what’s happening there, and relate that to the source code. Then you may find bits you would like to change/improve. Another source of inspi

Re: [Wireshark-dev] Building Wireshark on SuSE 11.4 fails, configure does not find pcap functions.

2017-10-13 Thread Jaap Keuter
> On 13 Oct 2017, at 09:26, Anders Broman wrote: > -Original Message- > From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org > ] On Behalf Of Guy Harris > Sent: den 12 oktober 2017 19:22 > To: Developer support list for Wireshark

Re: [Wireshark-dev] Wireshark configure issue

2017-10-26 Thread Jaap Keuter
Fix this problem, look at the packages which are held to their installed version and find out why. > On 26 Oct 2017, at 14:17, Manik Khandelwal > wrote: > > E: Unable to correct problems, you have held broken packages. __

  1   2   3   4   5   6   7   8   9   10   >