[Wireshark-dev] [PATCH] Fix build on OSX, packet-isakmp

2006-12-07 Thread Stig Bjørlykke
, packet-tcap.c, packet-tcap.c, packet-tcap.c, packet-tipc.c, packet-wfleet-hdlc.c, packet-winsrepl.c -- Stig Bjørlykke eap_handle.patch Description: Binary data ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org

[Wireshark-dev] Question about the CCITT/ITU/CRC-16 routine (crc16.c)

2006-12-11 Thread Stig Bjørlykke
used has the correct poly (which is 1021 in both cases). When I read the article found in [1] I find several implementations which is not equivalent, so I am a bit confused here :) -- Stig Bjørlykke [1] http://www.joegeluso.com/software/articles/ccitt.htm

Re: [Wireshark-dev] Question about the CCITT/ITU/CRC-16 routine (crc16.c)

2006-12-11 Thread Stig Bjørlykke
will implement crc16_x25_unreflected() and crc16_x25_ccitt(), as my table is used a bit different than in crc16_unreflected(): while (len--) crc16 = table[((crc16 8) ^ *buf++) 0xff] ^ (crc16 8); -- Stig Bjørlykke ___ Wireshark-dev mailing list

Re: [Wireshark-dev] [PATCH] New dissector: DMP (STANAG 4406 Direct Message Profile)

2006-12-13 Thread Stig Bjørlykke
acknowledgement environments :) All these protocols are described in STANAG 4406 Annex E (DMP is a new one recently added). -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark

[Wireshark-dev] [PATCH] Add X.411 Message to list of Decode As... for BER-encoded files

2007-02-05 Thread Stig Bjørlykke
Hi. Is it any reason not to add X.411 Message to the list of Decode As... for BER-encoded files? This patch adds support for decoding BER-encoded files as X.411 Message. -- Stig Bjørlykke packet-x411.patch.gz Description: GNU Zip compressed data

[Wireshark-dev] [PATCH] Add expert info in CDT

2007-02-05 Thread Stig Bjørlykke
Hi. This patch adds some expert info in CDT when: - Unable to get compressed content - Unable to uncompress content -- Stig Bjørlykke packet-cdt.patch.gz Description: GNU Zip compressed data ___ Wireshark-dev mailing list Wireshark-dev

[Wireshark-dev] [PATCH] Add export info in P_Mul

2007-02-05 Thread Stig Bjørlykke
Hi. This patch adds some expert info in P_Mul when: - Checksum failure - Missing sequence numbers -- Stig Bjørlykke packet-p_mul.patch.gz Description: GNU Zip compressed data ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http

[Wireshark-dev] [PATCH] Add expert info in DMP

2007-02-05 Thread Stig Bjørlykke
Hi. This patch adds some expert info in DMP when: - Checksum failure - Decoding of SIC failure - Negative ACK response - Unsupported DMP version - Error uncompressing content -- Stig Bjørlykke packet-dmp.patch.gz Description: GNU Zip compressed data

[Wireshark-dev] Decode Selected Bytes As

2007-02-05 Thread Stig Bjørlykke
file and then have to open this file. Any ideas how this could be implemented? Is it possible to add another entry to the Packet List after such a dissection? Attached an example ASN.1 file. -- Stig Bjørlykke multi-example.asn1 Description: Binary data

[Wireshark-dev] [PATCH] Indicate Empty bitstrings in BER dissector

2007-02-17 Thread Stig Bjørlykke
Hi. From X.690: 8.6.2.3 If the bitstring is empty, there shall be no subsequent octets, and the initial octet shall be zero. The BER dissector marks empty bitstrings as Padding, but I think it's better to mark this as Empty. -- Stig Bjørlykke packet-ber.patch.gz Description: GNU Zip

[Wireshark-dev] [PATCH] packet-ber: dissect_unknown_ber fix

2007-03-06 Thread Stig Bjørlykke
Hi. When dumping elements in a constructor in dissect_unknown_ber the last element is not put in the correct subtree, because the while- loop does not include the header length when checking for the end. Attached a patch to fix this bug. -- Stig Bjørlykke packet-ber.patch.gz

[Wireshark-dev] Questions about IEEE 802.11 dissector

2007-04-02 Thread Stig Bjørlykke
dissector: The SSI-type seems to have wrong endian, and the SSI-signal has a negative value. Should this be handled by the dissector? I do not know anything about the 802.11 protocol (yet), but I am willing to make a fix if I understand how to handle this :) -- Stig Bjørlykke

Re: [Wireshark-dev] Questions about IEEE 802.11 dissector

2007-04-09 Thread Stig Bjørlykke
. There might be a driver bug wherein the SSI type isn't big-endian, although with older adapters that'd arguably be somewhat stoopid, given that Which driver is used to capture wireless traffic? Builtin in OSX, or pcap? I really don't know where to start looking for this... -- Stig

[Wireshark-dev] [PATCH] Adding option to IEEE 802.11 to ignore wep bit with IV

2007-04-09 Thread Stig Bjørlykke
dissecting with and without tree). Try toggling Colorize Packet List with my previous posted ieee80211-wep.pcap without this patch to see the bug. The patch is tested on OSX. -- Stig Bjørlykke packet-ieee80211.patch.gz Description: GNU Zip compressed data

[Wireshark-dev] [PATCH] FTBP: ContentsTypeParameter and Relationship are OPTIONAL

2007-05-16 Thread Stig Bjørlykke
Hi. ContentsTypeParameter and Relationship are OPTIONAL as they are defined with a DEFAULT. -- Stig Bjørlykke ftbp.patch.gz Description: GNU Zip compressed data ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org

[Wireshark-dev] Fwd: [PATCH] FTBP: ContentsTypeParameter and Relationship are OPTIONAL

2007-06-14 Thread Stig Bjørlykke
Hi. Resending this patch as nobody had a look at it before. -- Forwarded message -- From: Stig Bjørlykke [EMAIL PROTECTED] Date: 16.mai.2007 10:10 Subject: [PATCH] FTBP: ContentsTypeParameter and Relationship are OPTIONAL To: wireshark-dev@wireshark.org Hi

Re: [Wireshark-dev] Fwd: [PATCH] FTBP: ContentsTypeParameter andRelationship are OPTIONAL

2007-06-21 Thread Stig Bjørlykke
2007/6/14, Anders Broman [EMAIL PROTECTED]: I there a reason why this is a separate dissector and not included in X.420 as it seems to belong in the same set of asn1 files? I don't know. This dissectors where made by Graeme Lunt, maybe he had a reason? -- Stig Bjørlykke

[Wireshark-dev] [PATCH] COTP reassembly improvements

2007-06-22 Thread Stig Bjørlykke
Hi. This patch fix reassembly when receiving a SES MINOR SYNC POINT and a COTP DT Data (class 1) fragment in the same frame. Also added the generated dst_ref and a reference to the COTP segment data to the tree. The patch has been fuzzy tested on OSX. -- Stig Bjørlykke packet-clnp.patch.gz

[Wireshark-dev] [PATCH] Adding RTSE reassembly

2007-06-22 Thread Stig Bjørlykke
with your captures? -- Stig Bjørlykke packet-ses-pres-rtse.patch.gz Description: GNU Zip compressed data p772-message-minorsync.pcap.gz Description: GNU Zip compressed data ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org

[Wireshark-dev] [PATCH] Show s4406 type in COL_INFO, as for X420.

2007-06-22 Thread Stig Bjørlykke
Hi. This patch adds s4406 type to COL_INFO, as for X420. Have a look at the previous posted p772-message-minorsync.pcap -- Stig Bjørlykke packet-x420.patch.gz Description: GNU Zip compressed data ___ Wireshark-dev mailing list Wireshark-dev

Re: [Wireshark-dev] [PATCH] Adding RTSE reassembly

2007-06-25 Thread Stig Bjørlykke
2007/6/24, Graeme Lunt [EMAIL PROTECTED]: I made a slight change so that the RTSE preferences are grouped under OSI. What happened with the plans moving all OSI dissector preferences to this group? -- Stig Bjørlykke ___ Wireshark-dev mailing list

[Wireshark-dev] [PATCH] X.420/FTBP Makefile fix

2007-06-25 Thread Stig Bjørlykke
Hi. This patch fixes building x420 with ftbp on Unix platform and adds ftbp.asn to the tarball. -- Stig Bjørlykke packet-x420-makefile.patch.gz Description: GNU Zip compressed data ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org

[Wireshark-dev] [PATCH] Make PRES context identifiers conversation aware

2007-06-26 Thread Stig Bjørlykke
Hi. This patch makes PRES context identifiers conversion aware. -- Stig Bjørlykke packet-pres-conversion.patch.gz Description: GNU Zip compressed data ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman

[Wireshark-dev] [PATCH] Get correct ExtensionAttributeType + correct CAP values in oraddress in X411

2007-06-26 Thread Stig Bjørlykke
Hi. This patch will set correct extension_id for ExtensionAttributeType (error introduced in r22043), and fix printing of CAP values in oraddress (error introduced in r22054). This patch should also be included in 0.99.6. -- Stig Bjørlykke packet-x411-extension-oraddress.patch.gz

Re: [Wireshark-dev] [PATCH] Get correct ExtensionAttributeType + correct CAP values in oraddress in X411

2007-06-26 Thread Stig Bjørlykke
2007/6/26, Stig Bjørlykke [EMAIL PROTECTED]: This patch will set correct extension_id for ExtensionAttributeType (error introduced in r22043), and fix printing of CAP values in oraddress (error introduced in r22054). This patch should also be included in 0.99.6. Argh, forgot to add

[Wireshark-dev] [PATCH] S4406 ExemptedAddressSeq fix

2007-06-27 Thread Stig Bjørlykke
Hi. This patch changes ExemptedAddressSeq to a SEQUENCE OF. -- Stig Bjørlykke packet-s4406-exempted.patch.gz Description: GNU Zip compressed data ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo

[Wireshark-dev] [PATCH] Add option to show unexpected BER data

2007-06-28 Thread Stig Bjørlykke
data the dissector does not like. -- Stig Bjørlykke packet-ber-decode-unexpected.patch.gz Description: GNU Zip compressed data ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

[Wireshark-dev] [PATCH] ExtendedBodyPart parameters is optional in x420

2007-07-13 Thread Stig Bjørlykke
Hi. ExtendedBodyPart parameters is OPTIONAL. -- Stig Bjørlykke packet-x420-extended-bodypart.patch.gz Description: GNU Zip compressed data ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo

Re: [Wireshark-dev] New dissector: TNEF

2007-07-23 Thread Stig Bjørlykke
obviously will fail. Should this decoding also be turned off? -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

[Wireshark-dev] RFC3030 for SMTP

2007-08-09 Thread Stig Bjørlykke
Hi. Has anyone been looking at RFC3030 to handle BDAT in SMTP? http://tools.ietf.org/html/rfc3030 -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

[Wireshark-dev] Missing files in svn:ignore?

2007-08-13 Thread Stig Bjørlykke
-scanner_lex.h ? wiretap/k12text_lex.h -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] FAQ addition? Wireless drops on Intel MacOS X

2007-08-13 Thread Stig Bjørlykke
. And I can't remember doing any special on the iMac. -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

[Wireshark-dev] [PATCH] Adding etsie2e4.xml to Makefile.am

2007-08-13 Thread Stig Bjørlykke
Hi. The etsie2e4.xml is missing from Makefile.am. Should bugzilla be used for such small patches? -- Stig Bjørlykke Makefile.am-etsie2e4.patch.gz Description: GNU Zip compressed data ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org

Re: [Wireshark-dev] [PATCH] DMP - Fix for long SICs

2007-08-15 Thread Stig Bjørlykke
Den 24. jul. 2007 kl. 07.01 skrev BRUMBY, Ian: Problem: The DMP dissector fails to correctly decode 4 character and longer SICs. Checked in as r22512. -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http

[Wireshark-dev] TCP Retransmission and protocol reassembly

2007-08-16 Thread Stig Bjørlykke
? Should this be fixed in the dissectors or the reassembly routines? -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

[Wireshark-dev] NetXRay 2.2 fileformat

2007-08-17 Thread Stig Bjørlykke
Hi. I have a NetXRay 2.2 capture with some LAPB/X.25 traffic. The data is shown correct, but all frames have 4 bytes extra which wireshark tries to dissect without any luck. Can this 4 bytes belong to the capture format? -- Stig Bjørlykke

Re: [Wireshark-dev] NetXRay 2.2 fileformat

2007-08-17 Thread Stig Bjørlykke
they are only zero's, so it may be junk. Attached the first 220 bytes of a capture showing this. This frames contains LAPB with a Supervisory frame, which shall not contain any data. -- Stig Bjørlykke msg.cap.gz Description: GNU Zip compressed data

[Wireshark-dev] First frame not in IO Graphs?

2007-08-21 Thread Stig Bjørlykke
Hi. I observe that the first frame in a capture is not showing in the IO Graphs. Is this a design feature or a bug? -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark

Re: [Wireshark-dev] [Wireshark-commits] rev 22586: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ip.c

2007-08-22 Thread Stig Bjørlykke
IP_OFFSET)*8); +field_tree = proto_item_add_subtree(tf, ett_ip_frag_offset); +proto_tree_add_item(field_tree, hf_ip_frag_offset, tvb, offset + 6, 2, FALSE); Any opinions before I submit my patch? -- Stig Bjørlykke ___ Wireshark-dev mailing

Re: [Wireshark-dev] [Wireshark-commits] rev 22586: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ip.c

2007-08-22 Thread Stig Bjørlykke
opinion, but mostly I do not care about the bits. -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

[Wireshark-dev] New style in IO Graph: Dot

2007-08-26 Thread Stig Bjørlykke
Hi. I have added a new style in IO Graph called Dot (r22666). This is like the top of FBar, and I find this usefull together with Impulse. Any comments are welcome :) -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org

Re: [Wireshark-dev] New style in IO Graph: Dot

2007-08-26 Thread Stig Bjørlykke
, except the IO Graphs. Could someone make a new capture with my patch (r22644) for displaying the first segment and the zero marker? Or is it OK to have screen captures from different systems? -- Stig Bjørlykke ___ Wireshark-dev mailing list

Re: [Wireshark-dev] Expert Infos are a bit more official now!

2007-08-26 Thread Stig Bjørlykke
Den 17. aug. 2007 kl. 00.30 skrev Ulf Lamping: P.S: Any suggestions about the User Guide and Wiki page text or the EI feature itself is welcome ... What about adding an abbreviated name, like frame.severity, to be able to make a filter or an IO Graph based on this information? -- Stig

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 1800] New: Missing 802.11 WMM TSPEC dissector fixes

2007-08-27 Thread Stig Bjørlykke
a capture with this data? -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] SNMP/MIBs TO DO

2007-08-29 Thread Stig Bjørlykke
to get it fixed). I'm working on a fix for x411 to handle the extension values as portnumbers, as done in some other dissectors. I will have a look at the others when I'm done with this one. -- Stig Bjørlykke ___ Wireshark-dev mailing list

Re: [Wireshark-dev] Capture-Interface shows incorrect statistics

2007-08-30 Thread Stig Bjørlykke
? -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Capture-Interface shows incorrect statistics

2007-08-30 Thread Stig Bjørlykke
Fedora Core 7 and my OSX has the same problem. But it seems to be working correctly on win32 with winpcap 4.0.1, which makes me believe the correct fix would be to use the same calculations for both winpcap and libpcap. Any comments? -- Stig Bjørlykke

Re: [Wireshark-dev] Capture-Interface shows incorrect statistics

2007-08-30 Thread Stig Bjørlykke
. Committed revision 22755. -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Capture-Interface shows incorrect statistics

2007-08-30 Thread Stig Bjørlykke
is libpcap 0.9.5. A bit confusing... I suppose my patch in revision 22755 will work in most cases. -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Broken windows build

2007-08-30 Thread Stig Bjørlykke
Den 30. aug. 2007 kl. 21.06 skrev L. Mark Pilant: After updating to 22755, the wireshark.exe build fails on Windows. Hard to figure out without a working buildbot :) Thanx. Committed revision 22756. -- Stig Bjørlykke ___ Wireshark-dev mailing

[Wireshark-dev] Ethernet header with FCS

2007-09-07 Thread Stig Bjørlykke
Hi. When selecting the Ethernet entry in the Packet Details window the corresponding bytes are highlighted in the Packet Bytes window. But when using FCS the FCS bytes are not highlighted. Would it be easy to add this? -- Stig Bjørlykke

Re: [Wireshark-dev] Ethernet header with FCS

2007-09-07 Thread Stig Bjørlykke
?id=1831 -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] [PATCH] TIPC - added reassembling of fragmented messages and calling of heuristic subdissectors

2007-09-17 Thread Stig Bjørlykke
message type in the second TIPC in the reassembled message. Please also notice we are using bugzilla to propose patches :) -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo

Re: [Wireshark-dev] [Wireshark-commits] rev 22905: /trunk/asn1/ /trunk/asn1/: Makefile.am

2007-09-18 Thread Stig Bjørlykke
this dissectors? -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] [Wireshark-commits] rev 22994: /trunk/ /trunk/asn1/: Makefile.am /trunk/epan/dissectors/: packet-t38.c packet-t38.h /trunk/asn1/rrc/: Makefile Makefile.nmake /trunk/asn1/rrlp/: Mak

2007-09-27 Thread Stig Bjørlykke
Hi. The t38 dissector does not compile on UN*X because the T38(2002).asn file contains un-escaped parentheses in Makefile.common. I suppose the simplest solution is to rename the file? -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark

Re: [Wireshark-dev] [Wireshark-commits] rev 23038: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-dcerpc-fldb.c packet-fcct.c packet-fcdns.c packet-fcels.c packet-fcip.c packet-fr.c packet-ft

2007-10-02 Thread Stig Bjørlykke
a make install_files in asn1/ ftam/ -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Use of EXTERNALt

2007-11-06 Thread Stig Bjørlykke
node? Graeme: what do you think? -- Stig Bjørlykke packet-ber.patch Description: Binary data ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Use of EXTERNALt

2007-11-06 Thread Stig Bjørlykke
On 7. nov.. 2007, at 00.27, Stig Bjørlykke wrote: The attached patch will dump a correct TNEF in a X.420 FileTransferData (like before), but I don't have time to dig deeper into this to determine if this is an appropriate solution. Maybe the X.420 dissector should decode the actx

Re: [Wireshark-dev] [Wireshark-commits] rev 23421: /trunk/ /trunk/gtk/: color_dlg.c color_edit_dlg.c colors.c colors.h compat_macros.h toolbar.c /trunk/: color_filters.c color_filters.h

2007-11-10 Thread Stig Bjørlykke
in the Enabled Protocols? Much easier to turn on and off without having to select the rule before hitting enable or disable. And we get a more uniform way to enable/ disable elements in lists :) -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark

[Wireshark-dev] Starting a capture with a file loaded

2007-11-10 Thread Stig Bjørlykke
Hi. I'm having a problem with the current svn on my ubuntu; when I start a capture with a file already loaded wireshark just freeze and nothing happens. Anyone else having this problem? -- Stig Bjørlykke ___ Wireshark-dev mailing list

Re: [Wireshark-dev] [Wireshark-commits] rev 23446: /trunk/gtk/ /trunk/gtk/: summary_dlg.c

2007-11-14 Thread Stig Bjørlykke
is really doing ... Yup. Will fix :) -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Dissector for OID:2.6.0.2.5 not implemented. Contact Etheral developers if you want this supported

2007-11-19 Thread Stig Bjørlykke
2007/11/19, Graeme Lunt [EMAIL PROTECTED]: There is basic P7 support in Wireshark in SVN 23479. I will try this dissector on our P7 traffic. But should we be more consistent on the naming policy? E.g. rename asn1/p7 to asn1/x413 and packet-p7 to packet-x413? -- Stig Bjørlykke

Re: [Wireshark-dev] Dissector for OID:2.6.0.2.5 not implemented. Contact Etheral developers if you want this supported

2007-11-19 Thread Stig Bjørlykke
(to me) for protocol filtering etc, and aligns with the disp/dap/dop/dsp naming. Yup. I'll vote for p1, p22 and p772. -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

[Wireshark-dev] Problems when changing a dissector preference

2007-11-19 Thread Stig Bjørlykke
an unknown port to the port used in the packages, the init routine for the dissector is called and all packages are reloaded with pinfo-fd- flags.visited=TRUE. This will not create my hash_table as expected, and the analysis values are not calculated. Any idea how I should fix this? -- Stig

[Wireshark-dev] Wish: Mark/Find the element matching the display filter

2007-11-19 Thread Stig Bjørlykke
with a deeper knowledge about the display filter engine who can point in a direction how to implement such a feature? -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Problems when changing a dissector preference

2007-11-19 Thread Stig Bjørlykke
always TRUE I don't know if this is a display this packet or a reload because of a preference change. -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Wish: Mark/Find the element matching the display filter

2007-11-19 Thread Stig Bjørlykke
in packet bytes. It does not work with string search in packet details. Should we add filter search matches too? I'll vote for yes :) I think they should work as equal as possible. And maybe an easy way to search for the currently used display filter? -- Stig Bjørlykke

Re: [Wireshark-dev] Wish: Mark/Find the element matching the display filter

2007-11-19 Thread Stig Bjørlykke
in each packet, with many matching the search criteria. I would really like to find each of them when performing a search. -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo

Re: [Wireshark-dev] Problems when changing a dissector preference

2007-11-20 Thread Stig Bjørlykke
visited is set to false. A comment in prefs_main_apply_all() indicates that gui_prefs_apply() could cause redissection. Is it correct to pass a packet to a dissector the very first time with visited set to true? -- Stig Bjørlykke ___ Wireshark-dev

Re: [Wireshark-dev] Problems when changing a dissector preference

2007-11-21 Thread Stig Bjørlykke
. Thanx. -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Use of EXTERNALt

2007-11-21 Thread Stig Bjørlykke
-external.octet_aligned after calling dissect_ber_external_type(). I choose to implement number 2 this time, so more dissectors can benefit from this change. I also implement support for calling the callback function, while I'm changing the code :) -- Stig Bjørlykke

[Wireshark-dev] A routine to handle TLVs

2007-11-22 Thread Stig Bjørlykke
Hi. After looking at a dissector with TLV handling I really think we should implement the wishlist element to handle this in proto.c Has anyone been looking at this lately? We should really have a uniform way to present this... -- Stig Bjørlykke

Re: [Wireshark-dev] A routine to handle TLVs

2007-11-22 Thread Stig Bjørlykke
dissect_ip_tcp_options() or did you implement from scratch? -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] [Wireshark-commits] rev 23560: /trunk/ /trunk/doc/: wireshark.pod /trunk/epan/: prefs.c prefs.h /trunk/gtk/: color_dlg.c compat_macros.h main.c main.h menu.c toolbar.c /trunk/help/

2007-11-24 Thread Stig Bjørlykke
combinations, but on OSX 10.5 ctrl-digit is used to switch between Spaces. -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] [Wireshark-commits] rev 23560: /trunk/ /trunk/doc/: wireshark.pod /trunk/epan/: prefs.c prefs.h /trunk/gtk/: color_dlg.c compat_macros.h main.c main.h menu.c toolbar.c /trunk/help/

2007-11-24 Thread Stig Bjørlykke
at this tomorrow. It works correct on my Ubuntu. But on OSX I get a crash in packet- frame when trying to print the color filter name in the packet list. It seems like pinfo-fd-color_filter has some illegal pointers. If you can't reproduce it I can have a closer look. -- Stig Bjørlykke

Re: [Wireshark-dev] [Wireshark-commits] rev 23581: /trunk/ /trunk/epan/dissectors/: packet-fcoe.c /trunk/gtk/: main.c

2007-11-25 Thread Stig Bjørlykke
I'll leave it in :) -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] [Wireshark-commits] rev 23560: /trunk/ /trunk/doc/: wireshark.pod /trunk/epan/: prefs.c prefs.h /trunk/gtk/: color_dlg.c compat_macros.h main.c main.h menu.c toolbar.c /trunk/help/

2007-11-25 Thread Stig Bjørlykke
to downgrade the color for a conversation (from 10 to 1), but not upgrade. -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] [Wireshark-commits] rev 23560: /trunk/ /trunk/doc/: wireshark.pod /trunk/epan/: prefs.c prefs.h /trunk/gtk/: color_dlg.c compat_macros.h main.c main.h menu.c toolbar.c /trunk/help/

2007-11-25 Thread Stig Bjørlykke
On 25. nov.. 2007, at 03.39, Stig Bjørlykke wrote: It works correct on my Ubuntu. Well, not exactly correct. I also get the crash on Ubuntu. Load a capture with two conversations. Select one conversation and pless ctrl-5 ctrl-6 ctrl-7 ctrl-8. Only the color for ctrl-5 is used. Select

Re: [Wireshark-dev] [Wireshark-commits] rev 23560: /trunk/ /trunk/doc/: wireshark.pod /trunk/epan/: prefs.c prefs.h /trunk/gtk/: color_dlg.c compat_macros.h main.c main.h menu.c toolbar.c /trunk/help/

2007-11-25 Thread Stig Bjørlykke
this, and not the old one if this has precedence. And I don't see any reason a conversation should have two different colorings? I'll vote for a move feature, just to make it easier to use. But that's my personal opinion, of course. Your last fix (svn 23583) works perfekt! -- Stig Bjørlykke

Re: [Wireshark-dev] [Wireshark-commits] rev 23560: /trunk/ /trunk/doc/: wireshark.pod /trunk/epan/: prefs.c prefs.h /trunk/gtk/: color_dlg.c compat_macros.h main.c main.h menu.c toolbar.c /trunk/help/

2007-11-25 Thread Stig Bjørlykke
On 25. nov.. 2007, at 16.57, Sake Blok wrote: OK, you have my vote too, check out SVN 23585 ;-) Works exactly the way I think it should. Thanx :) -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org

[Wireshark-dev] Statistics-Summary enhancements

2007-11-27 Thread Stig Bjørlykke
Hi. I have just added some enhancements to the statistics summary window: - Added traffic statistics for marked packages. - Do not show Displayed column unless using it. Comments are welcome :) -- Stig Bjørlykke ___ Wireshark-dev mailing list

Re: [Wireshark-dev] [Wireshark-commits] rev 23643: /trunk/ /trunk/epan/dissectors/: packet-tpncp.c /trunk/epan/: Makefile.am Makefile.nmake asm_utils.c asm_utils.h asm_utils_win32_x86.asm proto.c /tru

2007-11-28 Thread Stig Bjørlykke
2007/11/28, [EMAIL PROTECTED] [EMAIL PROTECTED]: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=23643 dyld: Symbol not found: _wrs_strcmp_with_data Referenced from: /sw/lib/libwireshark.0.dylib Expected in: flat namespace Trace/BPT trap -- Stig Bjørlykke

Re: [Wireshark-dev] Filtering using DHCP and SSDP throws error

2007-11-30 Thread Stig Bjørlykke
2007/11/29, Didier [EMAIL PROTECTED]: The filter value somewhere in the Protocol hierarchy stat would be nice too. You should try svn r23686 or later :) -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http

Re: [Wireshark-dev] Statistics-Summary enhancements

2007-11-30 Thread Stig Bjørlykke
display filter the column for displayed packages is empty, which is a bit odd I think, because I do have displayed packages. Should this column have the same values as the captured column, as this values are equal, instead of just be empty? -- Stig Bjørlykke

Re: [Wireshark-dev] Filtering using DHCP and SSDP throws error

2007-12-03 Thread Stig Bjørlykke
2007/12/3, Didier [EMAIL PROTECTED]: [UTF-8?]On Sun, 2 Dec 2007 22:48:12 +0100, Stig Bjørlykke wrote I suppose you want to use this to create a filter based on the information you find in this window? Then I will propose adding a Apply as Filter / Prepare a Filter menu like we have

[Wireshark-dev] Problems in IO Graphs with time values greater than ~429 seconds

2007-12-03 Thread Stig Bjørlykke
rewrite gtk/io_stat.c to handle time differently? -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Problems in IO Graphs with time values greater than ~429 seconds

2007-12-03 Thread Stig Bjørlykke
, GUINT_TO_POINTER(yscale_max[i])); -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 1366] Support for RPCAP features in GUI

2007-12-04 Thread Stig Bjørlykke
Does anyone know any status on remote capturing on other than windows? I suppose libpcap has to support rpcap to make this working... -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman

Re: [Wireshark-dev] Help fetching values from a GtkTreeView

2007-12-06 Thread Stig Bjørlykke
On 6. des.. 2007, at 03.14, Stephen Fisher wrote: I haven't used GtkTreeView as a tree before, but when using it as a list, you make the final field a G_TYPE_POINTER. Ah, thank you. Now it works :) -- Stig Bjørlykke ___ Wireshark-dev mailing

[Wireshark-dev] Apply/Prepare filter in Protocol Hierarchy

2007-12-06 Thread Stig Bjørlykke
Hi. I have just added Apply as / Prepare a filter in the Protocol Hierarchy window. Didier: you should try svn 23786. -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo

Re: [Wireshark-dev] packet-dlm compilation errors

2007-12-10 Thread Stig Bjørlykke
packet-dlm3.c(558) : error C2065: 'uint32_t' : undeclared identifier Fixed in r23835. -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Building wireshark-0.99.8-SVN-23860 fails due to uncreated directory

2007-12-14 Thread Stig Bjørlykke
to the correct Makefiles. You should try r23864 when the buildbot is finished. -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] [Wireshark-commits] rev 23873: /trunk/gtk/ /trunk/gtk/: menu.c proto_dlg.c proto_dlg.h

2007-12-16 Thread Stig Bjørlykke
can be -1 in other cases. I suppose all elements created with proto_tree_add_text, which uses the static hf entry in proto.c, will crash wireshark when selected in the Protocol Details. -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark

Re: [Wireshark-dev] code coverage measurement for a dissector?

2008-01-02 Thread Stig Bjørlykke
On 2. jan.. 2008, at 21.20, Németh Márton wrote: Bad news: the make process was not able to finish, here is the error: Did you make clean? It seems to work on my Ubuntu 7.10. -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev

Re: [Wireshark-dev] code coverage measurement for a dissector?

2008-01-02 Thread Stig Bjørlykke
... -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Missing plugin in install-deps target in top level Makefile.nmake

2008-01-14 Thread Stig Bjørlykke
2008/1/14, Peter Johansson [EMAIL PROTECTED]: Would somebody please update Makefile.nmake with the following line: xcopy .\plugins\ethercat\ethercat.dll $(INSTALL_DIR)\plugins\$(VERSION) /d Committed revision 24088. -- Stig Bjørlykke ___ Wireshark

[Wireshark-dev] New functionality: Configuration Profiles

2008-01-14 Thread Stig Bjørlykke
active and accept return as OK - save users Decode as in the profile - make new, clone and deletion of profiles more secure - make some of the recent values available in the profile Please try it out, and give me feedback what you think :) -- Stig Bjørlykke

[Wireshark-dev] Unable to set data link type (EN10MB is not one of the DLTs supported by this device).

2008-01-15 Thread Stig Bjørlykke
0.9.5. Built using gcc 4.0.1 (Apple Computer, Inc. build 5341). -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

[Wireshark-dev] Disable MATE dissector will always add a Data entry in the packet details pane

2008-01-15 Thread Stig Bjørlykke
will get two data entries. -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Disable MATE dissector will always add a Data entry in the packet details pane

2008-01-15 Thread Stig Bjørlykke
2008/1/15, Luis EG Ontanon [EMAIL PROTECTED]: can you try if this fixes it. Yes, this patch fixes the problem. -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

  1   2   3   4   5   6   >