Re: [WiX-devs] appsyn feed: documentation

2014-07-20 Thread Phill Hogland
Well that did not work. -- View this message in context: http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/appsyn-feed-documentation-tp7595938p7596003.html Sent from the wix-devs mailing list archive at Nabble.com. ---

Re: [WiX-devs] appsyn feed: documentation

2014-07-20 Thread Phill Hogland
The issue is with 'Add overrides' which should be 'Add <UI> overrides' -- View this message in context: http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/appsyn-feed-documentation-tp7595938p7596002.html Sent from the wix-devs mailing list archive at Nabble.com. -

Re: [WiX-devs] appsyn feed: documentation

2014-07-20 Thread Nicolás Alvarez
:55 PM > To: wix-devs@lists.sourceforge.net > Subject: Re: [WiX-devs] appsyn feed: documentation > > Thanks for posting it, (http://wixtoolset.org/releases/feed/v3.9). I will > use it as a model to adjust my feed generator. I originally used wix3.7 the > model but made changes

Re: [WiX-devs] appsyn feed: documentation

2014-07-20 Thread Hoover, Jacob
The content is properly escaped: <li>BobArnson: WIXBUG:4134 - Add <UI> overrides to WixUI localization for pt-BR.</li> -Original Message- From: Phill Hogland [mailto:phogl...@rimage.com] Sent: Sunday, July 20, 2014 2:55 PM To: wix-devs@lists.sourceforge.net Subj

Re: [WiX-devs] appsyn feed: documentation

2014-07-20 Thread Phill Hogland
Thanks for posting it, (http://wixtoolset.org/releases/feed/v3.9). I will use it as a model to adjust my feed generator. I originally used wix3.7 the model but made changes based on what I could find for specifications and experimenting with the code. One very minor detail is that there is an un

Re: [WiX-devs] appsyn feed: documentation

2014-07-20 Thread Hoover, Jacob
121 depends on 120 (which is what it's based off of). Have you reviewed 120? From: Bob Arnson [mailto:b...@joyofsetup.com] Sent: Sunday, July 20, 2014 2:28 PM To: wix-devs@lists.sourceforge.net Subject: Re: [WiX-devs] appsyn feed: documentation Are we clear on PR 121? On 20-Jul-14 15:17, H

Re: [WiX-devs] appsyn feed: documentation

2014-07-20 Thread Bob Arnson
:51 PM *To:* WiX toolset developer mailing list *Subject:* Re: [WiX-devs] appsyn feed: documentation FYI, I believe I've fixed the feed. ___ FireGiant | Dedicated support for the WiX toolset | http://www.firegiant.com/ *From

Re: [WiX-devs] appsyn feed: documentation

2014-07-20 Thread Hoover, Jacob
PM To: wix-devs@lists.sourceforge.net<mailto:wix-devs@lists.sourceforge.net> Subject: Re: [WiX-devs] appsyn feed: documentation On 19-Jul-14 14:54, Hoover, Jacob wrote: Yeah, but I have a branch out there for our discussed changes so WixBA uses the engine atom feed parsing. Unfortunately

Re: [WiX-devs] appsyn feed: documentation

2014-07-20 Thread Rob Mensching
-devs@lists.sourceforge.net Subject: Re: [WiX-devs] appsyn feed: documentation On 19-Jul-14 14:54, Hoover, Jacob wrote: Yeah, but I have a branch out there for our discussed changes so WixBA uses the engine atom feed parsing. Unfortunately, there are outstanding issues with the existing WiX feed so the engine

Re: [WiX-devs] appsyn feed: documentation

2014-07-19 Thread Bob Arnson
On 19-Jul-14 15:50, Hoover, Jacob wrote: Ahh, was meant to be v 3.9 leaks, not indicating the number of leaks. I figured it out. Eventually. :) No, all remaining leaks look like they are CRT. Those might be intentional, in that they don't explicitly clean up stuff that goes away at process

Re: [WiX-devs] appsyn feed: documentation

2014-07-19 Thread Hoover, Jacob
, July 19, 2014 2:44 PM To: wix-devs@lists.sourceforge.net Subject: Re: [WiX-devs] appsyn feed: documentation I was concerned when I saw that your branch had "39 memory leaks..." Do the 63 leaks start in WiX/Burn? Maybe I'll put the RC2 build through AppVerifier... On 19-Jul-14 15:33

Re: [WiX-devs] appsyn feed: documentation

2014-07-19 Thread Bob Arnson
rnson [mailto:b...@joyofsetup.com] *Sent:* Saturday, July 19, 2014 2:27 PM *To:* wix-devs@lists.sourceforge.net *Subject:* Re: [WiX-devs] appsyn feed: documentation Merged. Thanks! On 19-Jul-14 15:19, Hoover, Jacob wrote: Leaks put into their own PR, https://github.com/wixtoolset/wix3/pull

Re: [WiX-devs] appsyn feed: documentation

2014-07-19 Thread Hoover, Jacob
Now if only I could cleanup the 63 CRT heap leaks... From: Bob Arnson [mailto:b...@joyofsetup.com] Sent: Saturday, July 19, 2014 2:27 PM To: wix-devs@lists.sourceforge.net Subject: Re: [WiX-devs] appsyn feed: documentation Merged. Thanks! On 19-Jul-14 15:19, Hoover, Jacob wrote: Leaks put into

Re: [WiX-devs] appsyn feed: documentation

2014-07-19 Thread Bob Arnson
x-devs@lists.sourceforge.net *Subject:* Re: [WiX-devs] appsyn feed: documentation On 19-Jul-14 14:54, Hoover, Jacob wrote: Yeah, but I have a branch out there for our discussed changes so WixBA uses the engine atom feed parsing. Unfortunately, there are outstanding issues with the existing WiX feed so the

Re: [WiX-devs] appsyn feed: documentation

2014-07-19 Thread Hoover, Jacob
Leaks put into their own PR, https://github.com/wixtoolset/wix3/pull/118 From: Bob Arnson [mailto:b...@joyofsetup.com] Sent: Saturday, July 19, 2014 2:03 PM To: wix-devs@lists.sourceforge.net Subject: Re: [WiX-devs] appsyn feed: documentation On 19-Jul-14 14:54, Hoover, Jacob wrote: Yeah, but

Re: [WiX-devs] appsyn feed: documentation

2014-07-19 Thread Bob Arnson
On 19-Jul-14 14:54, Hoover, Jacob wrote: Yeah, but I have a branch out there for our discussed changes so WixBA uses the engine atom feed parsing. Unfortunately, there are outstanding issues with the existing WiX feed so the engine as is won't accept it (lacking the app id throws out all the

Re: [WiX-devs] appsyn feed: documentation

2014-07-19 Thread Hoover, Jacob
hy we have a CoreInitialize but not a CoreUninitialize. From: Bob Arnson [mailto:b...@joyofsetup.com] Sent: Saturday, July 19, 2014 1:49 PM To: wix-devs@lists.sourceforge.net Subject: Re: [WiX-devs] appsyn feed: documentation On 19-Jul-14 12:31, Hoover, Jacob wrote: In the mean time I did some prof

Re: [WiX-devs] appsyn feed: documentation

2014-07-19 Thread Bob Arnson
On 19-Jul-14 12:31, Hoover, Jacob wrote: In the mean time I did some profiling and found some memory leaks. Shall I submit a PR based off the WixBAUpdates branch, or should I rebase off of develop? You can probably just merge; there hasn't been that much churn. -- sig://boB http://joyofsetup.

Re: [WiX-devs] appsyn feed: documentation

2014-07-19 Thread Hoover, Jacob
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com] Sent: Friday, July 18, 2014 3:12 PM To: WiX toolset developer mailing list Subject: Re: [WiX-devs] appsyn feed: documentation Rob, In case you want to test your feed changes... https://github.com/jchoover/wix3/compare/WixBAUpdates?exp

Re: [WiX-devs] appsyn feed: documentation

2014-07-18 Thread Hoover, Jacob
to be ignored. From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com] Sent: Thursday, July 17, 2014 4:13 PM To: WiX toolset developer mailing list Subject: Re: [WiX-devs] appsyn feed: documentation Even after fixing this, the new feed doesn't have an application identity which causes the apu

Re: [WiX-devs] appsyn feed: documentation

2014-07-18 Thread Phill Hogland
I am not sure that I follow the conversation, and I don't confuse the conversation.. The wix 3.7 feed had the following: 3618724B-2523-44F9-A908-866AA619504D which is the upgrade code. And it had this. http://appsyndication.org/2006/appsyn"; type="application/exe">975AEB44-64A0-4D52-9BBA-63C9C0342

Re: [WiX-devs] appsyn feed: documentation

2014-07-18 Thread Hoover, Jacob
to be ignored. From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com] Sent: Thursday, July 17, 2014 4:13 PM To: WiX toolset developer mailing list Subject: Re: [WiX-devs] appsyn feed: documentation Even after fixing this, the new feed doesn't have an application identity which causes the apuput

Re: [WiX-devs] appsyn feed: documentation

2014-07-18 Thread Rob Mensching
Jacob [mailto:jacob.hoo...@greenheck.com] Sent: Thursday, July 17, 2014 4:13 PM To: WiX toolset developer mailing list Subject: Re: [WiX-devs] appsyn feed: documentation Even after fixing this, the new feed doesn't have an application identity which causes the apuputil ProcessEntry parser to

Re: [WiX-devs] appsyn feed: documentation

2014-07-18 Thread Hoover, Jacob
Jacob [mailto:jacob.hoo...@greenheck.com] Sent: Thursday, July 17, 2014 4:13 PM To: WiX toolset developer mailing list Subject: Re: [WiX-devs] appsyn feed: documentation Even after fixing this, the new feed doesn't have an application identity which causes the apuputil ProcessEntry parser to ignore it.

Re: [WiX-devs] appsyn feed: documentation

2014-07-17 Thread Hoover, Jacob
I have a simple fix for this as well to just ReAlloc at the end to free the unused memory. From: Rob Mensching [mailto:r...@firegiant.com] Sent: Thursday, July 17, 2014 2:20 PM To: WiX toolset developer mailing list Subject: Re: [WiX-devs] appsyn feed: documentation As Burn came along we rea

Re: [WiX-devs] appsyn feed: documentation

2014-07-17 Thread Phill Hogland
Actually it did not answer my confusion. The wix37 (which is what I used to model my update design) and wix36 feed files have guid(s) that the wix38 atom does not have. One guid is the update code but I am not clear on what the other one is for. I am not saying that there is any problem, just th

Re: [WiX-devs] appsyn feed: documentation

2014-07-17 Thread Rob Mensching
w.firegiant.com/ -Original Message- From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com] Sent: Thursday, July 17, 2014 12:02 PM To: WiX toolset developer mailing list Subject: Re: [WiX-devs] appsyn feed: documentation Good catch, though I challenge if as:version= release.title is the r

Re: [WiX-devs] appsyn feed: documentation

2014-07-17 Thread Rob Mensching
As Burn came along we realized we need to differentiate versions from numbers. That's why in Burn you put a "v" in front of numbers that are to be compared as versions (instead of numbers). That concept kinda' spread. I think it would be great if FireVersionFromString respected the "v" concept.

Re: [WiX-devs] appsyn feed: documentation

2014-07-17 Thread Hoover, Jacob
t: Re: [WiX-devs] appsyn feed: documentation I think I just found the answer to my question by snooping in wixtoolset/site/common/layouts/appsyn.feed.jade Did not mean to side-track this thread. -- View this message in context: http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/appsyn

Re: [WiX-devs] appsyn feed: documentation

2014-07-17 Thread Phill Hogland
I think I just found the answer to my question by snooping in wixtoolset/site/common/layouts/appsyn.feed.jade Did not mean to side-track this thread. -- View this message in context: http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/appsyn-feed-documentation-tp7595938p7595940.html

Re: [WiX-devs] appsyn feed: documentation

2014-07-17 Thread Phill Hogland
And I have also been trying to understand the meaning of GUIDs, such as this from the wix37 feed (maybe it is obsolete). http://appsyndication.org/2006/appsyn"; type="application/exe">975AEB44-64A0-4D52-9BBA-63C9C0342462 -- View this message in context: http://windows-installer-xml-wix-toolset.