[Xen-devel] [linux-linus test] 132451: tolerable FAIL - PUSHED

2019-01-24 Thread osstest service owner
flight 132451 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/132451/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stopfail like 132413 test-amd64-i386-xl-qemut-win7-amd64

[Xen-devel] [PATCH v2.1 2/2] x86emul: fix test harness and fuzzer build dependencies

2019-01-24 Thread Jan Beulich
Commit fd35f32b4b ("tools/x86emul: Use struct cpuid_policy in the userspace test harnesses") didn't account for the dependencies of cpuid-autogen.h to potentially change between incremental builds. In particular the harness has a "run" goal which is supposed to be usable independently of the rest

[Xen-devel] [PATCH v2.1 1/2] tools: fix build dependency upon generated header(s)

2019-01-24 Thread Jan Beulich
Commit fd35f32b4b ("tools/x86emul: Use struct cpuid_policy in the userspace test harnesses") didn't account for the dependencies of cpuid-autogen.h to potentially change between incremental builds. Putting the make invocation to produce the header together with the directory tree creation

[Xen-devel] [PATCH v2.1 0/2] tools: fix build dependencies upon generated header(s)

2019-01-24 Thread Jan Beulich
1: tools: fix build dependency upon generated header(s) 2: x86emul: fix test harness and fuzzer build dependencies I've decided to split the original patch, in the hope that at least the main bug fix (patch 1) can go in. Andrew, I've dropped your ack, for you to reconsider whether you're still

Re: [Xen-devel] [PATCH for-4.12] gic-vgic: fix assert condition

2019-01-24 Thread Andrii Anisov
Dear Julien, чт, 24 січ. 2019, 21:27 Julien Grall користувач julien.gr...@gmail.com пише: > (sorry for the formatting) > > On Thu, 24 Jan 2019, 18:35 Andrii Anisov, wrote: > >> From: Andrii Anisov >> > > Empty commit message should only happen when the title provide enough > information. > >

Re: [Xen-devel] [PATCH for-4.12] gic-vgic: fix assert condition

2019-01-24 Thread Andrii Anisov
Hello Stefan, You are absolutely correct. Sent from my Android. чт, 24 січ. 2019, 20:47 Nuernberger, Stefan користувач s...@amazon.de пише: > -ASSERT(connect && desc); > +ASSERT(connect || desc); I assume it should be ASSERT(!connect || desc); - Stefan

Re: [Xen-devel] [PATCH for-4.12] x86/p2m: Drop erroneous #VE-enabled check in ept_set_entry()

2019-01-24 Thread Juergen Gross
On 24/01/2019 19:28, Andrew Cooper wrote: > Code clearing the "Suppress VE" bit in an EPT entry isn't nececsserily running > in current context. In ALTP2M_external mode, it definitely is not, and in PV > context, vcpu_altp2m(current) acts upon the HVM union. > > Even if we could sensibly resolve

Re: [Xen-devel] [PATCH-for-4.12] docs: Fix dm_restrict documentation

2019-01-24 Thread Juergen Gross
On 24/01/2019 18:48, George Dunlap wrote: > Remove "chatty" and redundant information from the xl man page; > restrict it to functional descriptions only, and point instead to > qemu-depriv.pandoc and SUPPORT.md as locations for "canonical" > information. > > Add a man page entry for

[Xen-devel] [libvirt test] 132453: tolerable all pass - PUSHED

2019-01-24 Thread osstest service owner
flight 132453 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/132453/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 saverestore-support-checkfail like 132411 test-armhf-armhf-libvirt-raw 13

[Xen-devel] [linux-4.19 test] 132446: regressions - FAIL

2019-01-24 Thread osstest service owner
flight 132446 linux-4.19 real [real] http://logs.test-lab.xenproject.org/osstest/logs/132446/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-shadow7 xen-boot fail REGR. vs. 129313

[Xen-devel] [ovmf test] 132452: regressions - FAIL

2019-01-24 Thread osstest service owner
flight 132452 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/132452/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 10 debian-hvm-install fail REGR. vs. 129475

Re: [Xen-devel] [PATCH for-4.12] amd/iommu: fix present bit checking when clearing PTE

2019-01-24 Thread Woods, Brian
On 1/23/19 3:47 AM, Roger Pau Monne wrote: > The current check for the present bit is wrong, since the present bit > is located in the low part of the entry. > > Fixes: e8afe1124cc1 ("iommu: elide flushing for higher order map/unmap > operations") > Signed-off-by: Roger Pau Monné Reviewed-by:

Re: [Xen-devel] [PATCH SpectreV1+L1TF v4 07/11] nospec: enable lfence on Intel

2019-01-24 Thread Andrew Cooper
On 23/01/2019 11:57, Norbert Manthey wrote: > While the lfence instruction was added for all x86 platform in the > beginning, it's useful to not block platforms that are not affected > by the L1TF vulnerability. Therefore, the lfence instruction should > only be introduced, in case the current CPU

[Xen-devel] [xen-unstable-smoke test] 132463: tolerable all pass - PUSHED

2019-01-24 Thread osstest service owner
flight 132463 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/132463/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-armhf-armhf-xl

Re: [Xen-devel] [PATCH] x86/pv: Clean up cr3 handling in arch_set_info_guest()

2019-01-24 Thread Andrew Cooper
On 24/01/2019 21:42, Julien Grall wrote: > Hi Andrew, > > On 12/21/18 1:46 PM, Andrew Cooper wrote: >> All of this code lives inside CONFIG_PV which means gfn == mfn, and the >> fill_ro_mpt() calls clearly show that the value is used untranslated. >> >> Change cr3_gfn to a suitably typed cr3_mfn,

Re: [Xen-devel] [PATCH] x86/pv: Clean up cr3 handling in arch_set_info_guest()

2019-01-24 Thread Julien Grall
Hi Andrew, On 12/21/18 1:46 PM, Andrew Cooper wrote: All of this code lives inside CONFIG_PV which means gfn == mfn, and the fill_ro_mpt() calls clearly show that the value is used untranslated. Change cr3_gfn to a suitably typed cr3_mfn, and replace get_page_from_gfn() with a straight

[Xen-devel] [qemu-mainline test] 132443: regressions - FAIL

2019-01-24 Thread osstest service owner
flight 132443 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/132443/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 guest-start/debianhvm.repeat fail

Re: [Xen-devel] [PATCH SpectreV1+L1TF v4 03/11] config: introduce L1TF_LFENCE option

2019-01-24 Thread Andrew Cooper
On 23/01/2019 11:51, Norbert Manthey wrote: > This commit introduces the configuration option L1TF_LFENCE that allows > to control the implementation of the protection of privilege checks via > lfence instructions. The following four alternatives are provided: > > - not injecting lfence

Re: [Xen-devel] SpectreV1+L1TF Patch Series

2019-01-24 Thread Andrew Cooper
On 23/01/2019 11:51, Norbert Manthey wrote: > Dear all, > > This patch series attempts to mitigate the issue that have been raised in the > XSA-289 (https://xenbits.xen.org/xsa/advisory-289.html). To block speculative > execution on Intel hardware, an lfence instruction is required to make sure >

Re: [Xen-devel] [RFC] virtio_ring: check dma_mem for xen_domain

2019-01-24 Thread Michael S. Tsirkin
On Thu, Jan 24, 2019 at 11:14:53AM -0800, Stefano Stabellini wrote: > On Thu, 24 Jan 2019, Peng Fan wrote: > > Hi stefano, > > > > > -Original Message- > > > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > > > Sent: 2019年1月24日 7:44 > > > To: h...@infradead.org > > > Cc: Stefano

Re: [Xen-devel] [PATCH SpectreV1+L1TF v4 01/11] is_control_domain: block speculation

2019-01-24 Thread Andrew Cooper
On 24/01/2019 12:07, Norbert Manthey wrote: > On 1/23/19 14:20, Jan Beulich wrote: > On 23.01.19 at 12:51, wrote: >>> --- a/xen/include/xen/nospec.h >>> +++ b/xen/include/xen/nospec.h >>> @@ -58,6 +58,21 @@ static inline unsigned long >>> array_index_mask_nospec(unsigned long index, >>>

Re: [Xen-devel] [PATCH for-4.12] gic-vgic: fix assert condition

2019-01-24 Thread André Przywara
On 24/01/2019 18:47, Nuernberger, Stefan wrote: > On Thu, 2019-01-24 at 20:33 +0200, Andrii Anisov wrote: >> From: Andrii Anisov >> >> Signed-off-by: Andrii Anisov >> --- >>  xen/arch/arm/gic-vgic.c | 2 +- >>  1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git

[Xen-devel] [linux-next test] 132425: regressions - FAIL

2019-01-24 Thread osstest service owner
flight 132425 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/132425/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-shadow 10 debian-install fail REGR. vs. 132374

Re: [Xen-devel] [PATCH SpectreV1+L1TF v4 08/11] xen/evtchn: block speculative out-of-bound accesses

2019-01-24 Thread Norbert Manthey
On 1/24/19 17:56, Jan Beulich wrote: On 23.01.19 at 12:57, wrote: >> --- a/xen/common/event_channel.c >> +++ b/xen/common/event_channel.c >> @@ -368,8 +368,14 @@ int evtchn_bind_virq(evtchn_bind_virq_t *bind, >> evtchn_port_t port) >> if ( virq_is_global(virq) && (vcpu != 0) ) >>

Re: [Xen-devel] [PATCH for-4.12] gic-vgic: fix assert condition

2019-01-24 Thread Julien Grall
(sorry for the formatting) On Thu, 24 Jan 2019, 18:35 Andrii Anisov, wrote: > From: Andrii Anisov > Empty commit message should only happen when the title provide enough information. In that case, you should explain how you hit the assert so the reviewers can understand the change.

Re: [Xen-devel] [RFC] virtio_ring: check dma_mem for xen_domain

2019-01-24 Thread Stefano Stabellini
On Thu, 24 Jan 2019, Peng Fan wrote: > Hi stefano, > > > -Original Message- > > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > > Sent: 2019年1月24日 7:44 > > To: h...@infradead.org > > Cc: Stefano Stabellini ; Peng Fan > > ; m...@redhat.com; jasow...@redhat.com; > >

[Xen-devel] [OSSTEST PATCH 24/26] sg-report-host-history: Move SET LOCAL into transaction

2019-01-24 Thread Ian Jackson
Gets rid of this warning: WARNING: SET LOCAL can only be used in transaction blocks This suggests that this code was previously not effective... Signed-off-by: Ian Jackson --- sg-report-host-history | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

Re: [Xen-devel] [PATCH for-4.12] gic-vgic: fix assert condition

2019-01-24 Thread Nuernberger, Stefan
On Thu, 2019-01-24 at 20:33 +0200, Andrii Anisov wrote: > From: Andrii Anisov > > Signed-off-by: Andrii Anisov > --- >  xen/arch/arm/gic-vgic.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/arm/gic-vgic.c b/xen/arch/arm/gic-vgic.c > index 48922f5..684f2d1

[Xen-devel] [OSSTEST PATCH 01/26] power: Osstest::PDU::*: drop Exporter blocks

2019-01-24 Thread Ian Jackson
This is all very obsolete. These that we are removing are all empty, and nowadays perl has `use parent'. These changes are all textually identical. We will do ipmi_try in a moment: that one is special as it actually has a parent module. Signed-off-by: Ian Jackson --- Osstest/PDU/eth008.pm

[Xen-devel] [OSSTEST PATCH 07/26] power: PowerApproaches replaces $ho->{PowerMethobjs}

2019-01-24 Thread Ian Jackson
This new variable contains a list of different approaches to try. * Move the meat of power_state into power_approach_invoke. * power_state now looks for a single approach to try. * The default for power_state is to pick the last approach in the list, which by definition is supposed to be the

[Xen-devel] [OSSTEST PATCH 10/26] power: New ILOM/PDU arrangements - try just IPMI

2019-01-24 Thread Ian Jackson
We honour two new host properties PowerPDU and PowerILOM, in preference to PowerMethod. The semantics are going to be properly documented in a later patch, but, briefly: If only one of these is supplied, it works like PowerMethod, except that `nest' is applied by default. If both are supplied,

[Xen-devel] [OSSTEST PATCH 11/26] power: Do not sleep between power off and power on if not needed

2019-01-24 Thread Ian Jackson
This is controlled by a new query method on power method objects. If every power method says it is instananeous then we do not sleep. This is going to be most useful when we introduce the new SSH approach, which should not sleep for the power off time. But we do it for guests (ie, L1 nested

[Xen-devel] [OSSTEST PATCH 12/26] power: Provide `ssh' power method

2019-01-24 Thread Ian Jackson
This is not really a power method but it can pretend to be one. On power off, it does nothing. On power on it logs into the host to ask it to do a hard reboot. This is rather best effort, but it is eminently suitable for our new approach/attempts arrangements because those will try another

[Xen-devel] [OSSTEST PATCH 21/26] power: Record approach used for power cycles in runvars

2019-01-24 Thread Ian Jackson
Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 17 + ts-host-install| 2 +- ts-logs-capture| 2 +- 3 files changed, 15 insertions(+), 6 deletions(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index fb14c4b3..334cc2cb 100644 ---

[Xen-devel] [OSSTEST PATCH 14/26] power: Document Power* host properties and power methods

2019-01-24 Thread Ian Jackson
Signed-off-by: Ian Jackson --- README | 77 ++ README.dev | 4 ++-- 2 files changed, 79 insertions(+), 2 deletions(-) diff --git a/README b/README index bb9dc18e..91793795 100644 --- a/README +++ b/README @@ -631,6 +631,83 @@

[Xen-devel] [OSSTEST PATCH 06/26] power handling: Introduce power_reboot_attempts

2019-01-24 Thread Ian Jackson
This is going to be the new preferred interface for rebooting a host. Introduce the first two call sites in ts-host-install and ts-freebsd-host-install. power_cycle_sleep is an internal function now. No overall functional change, since currently power_reboot_attempts only ever tries one method.

[Xen-devel] [OSSTEST PATCH 03/26] power: ipmi_try: Use `use parent' instead of Exporter

2019-01-24 Thread Ian Jackson
This module already has a superclass, `ipmi'. Import it with `use parent' instead of Exporter. Signed-off-by: Ian Jackson --- Osstest/PDU/ipmi_try.pm | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/Osstest/PDU/ipmi_try.pm b/Osstest/PDU/ipmi_try.pm index

[Xen-devel] [OSSTEST PATCH 02/26] power: Osstest::PDU::*: use parent ::unsupported

2019-01-24 Thread Ian Jackson
This will allow us to introduce default methods, which everyone inherits unless overridden. These changes are all textually identical. We will do ipmi_try in a moment: that one is special as it actually has a parent module. Signed-off-by: Ian Jackson --- Osstest/PDU/eth008.pm| 2 ++

[Xen-devel] [OSSTEST PATCH 17/26] power: Rename target_reboot_force from target_reboot_hard

2019-01-24 Thread Ian Jackson
We are going to make this try softer methods first. No functional change. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 4 ++-- ts-logs-capture| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index

[Xen-devel] [OSSTEST PATCH 19/26] ts-logs-capture: power: try ILOM first

2019-01-24 Thread Ian Jackson
If ILOM is provided, and the host is not responding when we try logs capture, try the ILOM before hard power cycling the host. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Osstest/TestSupport.pm

[Xen-devel] [OSSTEST PATCH 22/26] Executive: Break out span_colour

2019-01-24 Thread Ian Jackson
No functional change. Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm index 0be27b64..1b1cdc36 100644 --- a/Osstest/Executive.pm +++ b/Osstest/Executive.pm @@ -59,7

[Xen-devel] [OSSTEST PATCH 00/26] Reduce hard power cycles

2019-01-24 Thread Ian Jackson
We have been having trouble with PDU port relays sticking. We vaguely suspect that this is happening in Massachusetts due to the lower-voltage (120V, and therefore higher-current) electricity (compared to Cambridge, 240V, where the PDUs remain reliable). To mitigate this issue (and generally

[Xen-devel] [OSSTEST PATCH 04/26] power: Osstest::PDU::*: reuse default new method where applicable

2019-01-24 Thread Ian Jackson
These two modules both had the same `new' as `unsupported'. Now that we have `use parent' they can be removed. Signed-off-by: Ian Jackson --- Osstest/PDU/manual.pm | 5 - Osstest/PDU/xenuse.pm | 5 - 2 files changed, 10 deletions(-) diff --git a/Osstest/PDU/manual.pm

[Xen-devel] [OSSTEST PATCH 20/26] power: Use `Combined' as Name for PDU+ILOM approach

2019-01-24 Thread Ian Jackson
Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 11 +++ mg-hosts | 2 +- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index 886e95d4..fb14c4b3 100644 --- a/Osstest/TestSupport.pm +++

[Xen-devel] [OSSTEST PATCH 18/26] power: power_reboot_attempts: Honour an $approach_re

2019-01-24 Thread Ian Jackson
The semantics are slightly different here: not specifying it means to try everything rather than only the hardest. But the effect is similar: not specifying $approach_re means we must succeed. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 5 +++-- 1 file changed, 3 insertions(+), 2

[Xen-devel] [OSSTEST PATCH 08/26] power: power_reboot_attempts: Try multiple approaches

2019-01-24 Thread Ian Jackson
Actually iterate over PowerApproaches, rather than calling power_state with no approach selector regexp. No overall functional change right now because nothing puts more than one entry in PowerApproaches. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 21 - 1 file

[Xen-devel] [OSSTEST PATCH 26/26] DO NOT APPLY power: ts-freebsd-host-install: Use power_reboot_attempts

2019-01-24 Thread Ian Jackson
RFC. Needs input on how to | check that this is the installer environment as requested by the comment | in particular $await must only succeed if the host really did | reboot into the boot environment that $await expects. near the top of power_reboot_attempts CC: Roger Pau Monné

[Xen-devel] [OSSTEST PATCH 25/26] sg-report-host-history: Show used power approach(es)

2019-01-24 Thread Ian Jackson
Signed-off-by: Ian Jackson --- sg-report-host-history | 56 ++ 1 file changed, 56 insertions(+) diff --git a/sg-report-host-history b/sg-report-host-history index 51814534..18b538e9 100755 --- a/sg-report-host-history +++ b/sg-report-host-history

[Xen-devel] [OSSTEST PATCH 13/26] power: Try rebooting hosts with ssh first

2019-01-24 Thread Ian Jackson
Before we try anything with IPMI (if provided) or the PDU, try rebooting with ssh. I think this will dramatically reduce the rate at which we power cycle our test hosts. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff

[Xen-devel] [OSSTEST PATCH 23/26] Executive: Export $grey_* with :colours

2019-01-24 Thread Ian Jackson
No functional change with existing callers. Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm index 1b1cdc36..0d8502b5 100644 --- a/Osstest/Executive.pm +++ b/Osstest/Executive.pm @@ -60,6 +60,7 @@

[Xen-devel] [OSSTEST PATCH 15/26] power: Honour approach_re in power_cycle and mg-hosts power

2019-01-24 Thread Ian Jackson
Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 8 mg-hosts | 14 +- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index 8101b739..e45f54b2 100644 --- a/Osstest/TestSupport.pm +++

[Xen-devel] [OSSTEST PATCH 09/26] power: Provide `try_off' pdu method; deprecate ipmi_try

2019-01-24 Thread Ian Jackson
We are going to want to use this magically, in our new approach. Make a general version, and deprecate ipmi_try (which will be obsoleted by the new approach and which has probably not been used very much). Signed-off-by: Ian Jackson --- Osstest/PDU/ipmi_try.pm | 2 ++ Osstest/PDU/try_off.pm

[Xen-devel] [OSSTEST PATCH 05/26] power handling: Break out power_cycle_parse_method

2019-01-24 Thread Ian Jackson
Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index 29108423..68b51728 100644 --- a/Osstest/TestSupport.pm +++ b/Osstest/TestSupport.pm @@ -917,10 +917,10

[Xen-devel] [OSSTEST PATCH 16/26] ts-host-powercycle: Use a lighter-weight method if available

2019-01-24 Thread Ian Jackson
Signed-off-by: Ian Jackson --- ts-host-powercycle | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ts-host-powercycle b/ts-host-powercycle index 5c1698c7..79a3b711 100755 --- a/ts-host-powercycle +++ b/ts-host-powercycle @@ -33,8 +33,10 @@ our ($whhost) = @ARGV; $whhost

Re: [Xen-devel] [PATCH for-4.12] x86/p2m: Drop erroneous #VE-enabled check in ept_set_entry()

2019-01-24 Thread Razvan Cojocaru
On 1/24/19 8:28 PM, Andrew Cooper wrote: > Code clearing the "Suppress VE" bit in an EPT entry isn't nececsserily running > in current context. In ALTP2M_external mode, it definitely is not, and in PV > context, vcpu_altp2m(current) acts upon the HVM union. > > Even if we could sensibly resolve

[Xen-devel] [PATCH for-4.12] gic-vgic: fix assert condition

2019-01-24 Thread Andrii Anisov
From: Andrii Anisov Signed-off-by: Andrii Anisov --- xen/arch/arm/gic-vgic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/gic-vgic.c b/xen/arch/arm/gic-vgic.c index 48922f5..684f2d1 100644 --- a/xen/arch/arm/gic-vgic.c +++ b/xen/arch/arm/gic-vgic.c @@ -443,7

Re: [Xen-devel] [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS

2019-01-24 Thread Peter Maydell
On Thu, 24 Jan 2019 at 17:40, Eric Blake wrote: > > On 1/24/19 2:45 AM, Markus Armbruster wrote: > > >> Signed-off-by: Michael Tokarev > >> Revieved-by: Michael Tokarev > > > > Typo in Reviewed-by. > > Should we tighten checkpatch.pl to flag suspicious-looking 'xxx-by:' > tags, to catch

[Xen-devel] [PATCH for-4.12] x86/p2m: Drop erroneous #VE-enabled check in ept_set_entry()

2019-01-24 Thread Andrew Cooper
Code clearing the "Suppress VE" bit in an EPT entry isn't nececsserily running in current context. In ALTP2M_external mode, it definitely is not, and in PV context, vcpu_altp2m(current) acts upon the HVM union. Even if we could sensibly resolve the target vCPU, it may legitimately not be fully

[Xen-devel] [PATCH-for-4.12] docs: Fix dm_restrict documentation

2019-01-24 Thread George Dunlap
Remove "chatty" and redundant information from the xl man page; restrict it to functional descriptions only, and point instead to qemu-depriv.pandoc and SUPPORT.md as locations for "canonical" information. Add a man page entry for device_model_user. Update qemu-deprivilege.pandoc: Changes in

Re: [Xen-devel] [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS

2019-01-24 Thread Eric Blake
On 1/24/19 2:45 AM, Markus Armbruster wrote: >> Signed-off-by: Michael Tokarev >> Revieved-by: Michael Tokarev > > Typo in Reviewed-by. Should we tighten checkpatch.pl to flag suspicious-looking 'xxx-by:' tags, to catch instances of typos? -- Eric Blake, Principal Software Engineer Red Hat,

Re: [Xen-devel] [PATCH SpectreV1+L1TF v4 08/11] xen/evtchn: block speculative out-of-bound accesses

2019-01-24 Thread Jan Beulich
>>> On 23.01.19 at 12:57, wrote: > --- a/xen/common/event_channel.c > +++ b/xen/common/event_channel.c > @@ -368,8 +368,14 @@ int evtchn_bind_virq(evtchn_bind_virq_t *bind, > evtchn_port_t port) > if ( virq_is_global(virq) && (vcpu != 0) ) > return -EINVAL; > > + /* > +*

Re: [Xen-devel] [PATCH] xen/sched: Introduce domain_vcpu() helper

2019-01-24 Thread Andrew Cooper
On 24/01/2019 16:31, Wei Liu wrote: > On Wed, Jan 23, 2019 at 02:59:29PM +, Andrew Cooper wrote: >> The progression of multi-vcpu support in Xen (originally a single pointer, >> then an embedded d->vcpu[] array, then a dynamically allocated array) has >> resulted in a large quantity of ad-hoc

Re: [Xen-devel] [PATCH] xen/sched: Introduce domain_vcpu() helper

2019-01-24 Thread Wei Liu
On Wed, Jan 23, 2019 at 02:59:29PM +, Andrew Cooper wrote: > The progression of multi-vcpu support in Xen (originally a single pointer, > then an embedded d->vcpu[] array, then a dynamically allocated array) has > resulted in a large quantity of ad-hoc code for looking a vcpu up by id, and a >

Re: [Xen-devel] Problem with IOMEM and domain reboot

2019-01-24 Thread Wei Liu
On Wed, Jan 23, 2019 at 06:28:46PM +0200, Andrii Anisov wrote: > Hello Wei, > > On 13.02.18 14:24, Wei Liu wrote: > > On Mon, Feb 12, 2018 at 07:22:27PM +0200, Oleksandr Grytsov wrote: > > > Is it done by design or there is an issue with parse_json? > > > If it is done by design then the solution

Re: [Xen-devel] Reducing or removing direct map from xen (was Re: Ongoing/future speculative mitigation work)

2019-01-24 Thread George Dunlap
On 1/24/19 11:44 AM, Wei Liu wrote: > Below is a summary for a discussion on this topic between Jan and me. I've skimmed this over and it looks reasonable. Thanks for doing this. -George ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] [PATCH for-4.12] automation: introduce a QEMU smoke test for PVH Dom0

2019-01-24 Thread Wei Liu
On Thu, Jan 24, 2019 at 03:24:11PM +, Wei Liu wrote: > Make qemu-smoke-x86-64.sh take a variant argument. Make two new tests > in test.yaml. > > Signed-off-by: Wei Liu > --- > Since the new option is going to be release in 4.12, I think it would be > beneficial to have this patch in 4.12 as

[Xen-devel] [PATCH for-4.12] automation: introduce a QEMU smoke test for PVH Dom0

2019-01-24 Thread Wei Liu
Make qemu-smoke-x86-64.sh take a variant argument. Make two new tests in test.yaml. Signed-off-by: Wei Liu --- Since the new option is going to be release in 4.12, I think it would be beneficial to have this patch in 4.12 as well. The risk is zero to end users. ---

Re: [Xen-devel] [PATCH v2] drm/xen-front: Make shmem backed display buffer coherent

2019-01-24 Thread Julien Grall
On 24/01/2019 14:34, Oleksandr Andrushchenko wrote: Hello, Julien! Hi, On 1/22/19 1:44 PM, Julien Grall wrote: On 1/22/19 10:28 AM, Oleksandr Andrushchenko wrote: Hello, Julien! Hi, On 1/21/19 7:09 PM, Julien Grall wrote: Well, I didn't get the attributes of pages at the backend

[Xen-devel] [xen-unstable test] 132422: tolerable FAIL

2019-01-24 Thread osstest service owner
flight 132422 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/132422/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stopfail like 132380

Re: [Xen-devel] [PATCH] xen/sched: Introduce domain_vcpu() helper

2019-01-24 Thread Jan Beulich
>>> On 24.01.19 at 13:33, wrote: > On 24/01/2019 08:35, Jan Beulich wrote: > On 23.01.19 at 18:44, wrote: >>> On 23/01/2019 17:01, Jan Beulich wrote: >>> On 23.01.19 at 15:59, wrote: > +static inline struct vcpu *domain_vcpu(const struct domain *d, > +

Re: [Xen-devel] [PATCH v2] drm/xen-front: Make shmem backed display buffer coherent

2019-01-24 Thread Oleksandr Andrushchenko
Hello, Julien! Sorry for the late reply - it took quite some time to collect the data requested. On 1/22/19 1:44 PM, Julien Grall wrote: > > > On 1/22/19 10:28 AM, Oleksandr Andrushchenko wrote: >> Hello, Julien! > > Hi, > >> On 1/21/19 7:09 PM, Julien Grall wrote: >> Well, I didn't get the

Re: [Xen-devel] [PATCH for-4.12 6/8] xen/arm: Implement workaround for Cortex-A76 erratum 1165522

2019-01-24 Thread Julien Grall
(+ James) Hi Stefano, @James, please correct me if I am wrong below :). On 24/01/2019 00:52, Stefano Stabellini wrote: On Wed, 28 Nov 2018, Julien Grall wrote: void p2m_restore_state(struct vcpu *n) @@ -111,10 +130,17 @@ void p2m_restore_state(struct vcpu *n) if ( is_idle_vcpu(n) )

Re: [Xen-devel] [PATCH 1/3] treewide: Lift switch variables out of switches

2019-01-24 Thread Edwin Zimmerman
On Wednesday, January 23, 2019 6:04 AM, Kees Cook wrote > > Variables declared in a switch statement before any case statements > cannot be initialized, so move all instances out of the switches. > After this, future always-initialized stack variables will work > and not throw warnings like this:

[Xen-devel] [PATCH for-4.12] arm: gic: deactivate sgi immediately after eoi

2019-01-24 Thread Peng Fan
On i.MX8, we implemented partition reboot which means Cortex-A reboot will not impact M4 cores and System control Unit core. However GICv3 is not reset because we also need to support A72 Cluster reboot without affecting A53 Cluster. The gic-v3 controller is configured with EOImode to 1, so

Re: [Xen-devel] [PATCH] drm: Split out drm_probe_helper.h

2019-01-24 Thread Daniel Vetter
On Thu, Jan 24, 2019 at 10:46:47AM +0100, Daniel Vetter wrote: > On Wed, Jan 23, 2019 at 06:00:15PM +0100, Sam Ravnborg wrote: > > Hi Daniel. > > > > On Thu, Jan 17, 2019 at 10:03:34PM +0100, Daniel Vetter wrote: > > > Having the probe helper stuff (which pretty much everyone needs) in > > > the

[Xen-devel] [PATCH for-4.12] libxl: When restricted, start QEMU paused

2019-01-24 Thread Anthony PERARD
Since libxl later during guest creation run the command "cont", it kind of expect that QEMU would not do any emulation, use the "-S" command option to make this effective. Unfortunately, when QEMU is started with "-S", it won't write QEMU's readiness into xenstore. So only activate this options

Re: [Xen-devel] [PATCH] xen/sched: Introduce domain_vcpu() helper

2019-01-24 Thread Andrew Cooper
On 24/01/2019 08:35, Jan Beulich wrote: On 23.01.19 at 18:44, wrote: >> On 23/01/2019 17:01, Jan Beulich wrote: >> On 23.01.19 at 15:59, wrote: +static inline struct vcpu *domain_vcpu(const struct domain *d, + unsigned int vcpu_id) +{

Re: [Xen-devel] [PATCH SpectreV1+L1TF v4 03/11] config: introduce L1TF_LFENCE option

2019-01-24 Thread Norbert Manthey
On 1/23/19 15:45, Jan Beulich wrote: On 23.01.19 at 14:44, wrote: >> On 23/01/2019 13:39, Jan Beulich wrote: >> On 23.01.19 at 14:24, wrote: On 23/01/2019 11:51, Norbert Manthey wrote: > --- a/xen/include/xen/nospec.h > +++ b/xen/include/xen/nospec.h > @@ -68,10 +68,18

Re: [Xen-devel] [PATCH SpectreV1+L1TF v4 03/11] config: introduce L1TF_LFENCE option

2019-01-24 Thread Norbert Manthey
On 1/23/19 14:18, Jan Beulich wrote: On 23.01.19 at 12:51, wrote: >> This commit introduces the configuration option L1TF_LFENCE that allows >> to control the implementation of the protection of privilege checks via >> lfence instructions. The following four alternatives are provided: >> >>

Re: [Xen-devel] [PATCH SpectreV1+L1TF v4 01/11] is_control_domain: block speculation

2019-01-24 Thread Norbert Manthey
On 1/23/19 14:20, Jan Beulich wrote: On 23.01.19 at 12:51, wrote: >> --- a/xen/include/xen/nospec.h >> +++ b/xen/include/xen/nospec.h >> @@ -58,6 +58,21 @@ static inline unsigned long >> array_index_mask_nospec(unsigned long index, >> (typeof(_i)) (_i & _mask);

Re: [Xen-devel] Xen-unstable PVHdom0: Assertion 'IS_ALIGNED(dfn_x(dfn), (1ul << page_order))' failed at iommu.c:324

2019-01-24 Thread Roger Pau Monné
On Thu, Jan 24, 2019 at 12:55:06PM +0100, Sander Eikelenboom wrote: > On 24/01/2019 11:11, Roger Pau Monné wrote: > > On Thu, Jan 24, 2019 at 10:25:33AM +0100, Sander Eikelenboom wrote: > >> On 24/01/2019 08:50, Roger Pau Monné wrote: > >>> On Wed, Jan 23, 2019 at 08:56:48PM +0100, Sander

Re: [Xen-devel] Xen-unstable PVHdom0: Assertion 'IS_ALIGNED(dfn_x(dfn), (1ul << page_order))' failed at iommu.c:324

2019-01-24 Thread Sander Eikelenboom
On 24/01/2019 11:11, Roger Pau Monné wrote: > On Thu, Jan 24, 2019 at 10:25:33AM +0100, Sander Eikelenboom wrote: >> On 24/01/2019 08:50, Roger Pau Monné wrote: >>> On Wed, Jan 23, 2019 at 08:56:48PM +0100, Sander Eikelenboom wrote: On 23/01/2019 19:25, Roger Pau Monné wrote: > On Wed,

[Xen-devel] Reducing or removing direct map from xen (was Re: Ongoing/future speculative mitigation work)

2019-01-24 Thread Wei Liu
Below is a summary for a discussion on this topic between Jan and me. End goal: reduce the size of direct map or remove it completely Constraints: 1. We want unified xenheap and domheap. 2. We want to preserve xenheap's semantics -- always globally mapped so that pointers can be stashed

Re: [Xen-devel] [PATCH for-4.12 5/8] xen/arm: p2m: Only use isb() when it is necessary

2019-01-24 Thread Julien Grall
Hi Stefano, On 23/01/2019 23:42, Stefano Stabellini wrote: On Wed, 28 Nov 2018, Julien Grall wrote: +/* * Flush local TLB for the domain to prevent wrong TLB translation * when running multiple vCPU of the same domain on a single pCPU. */ if ( *last_vcpu_ran !=

Re: [Xen-devel] [PATCH for-4.12 2/8] xen/arm: p2m: Provide an helper to generate the VTTBR

2019-01-24 Thread Julien Grall
Hi Stefano, On 23/01/2019 23:27, Stefano Stabellini wrote: On Wed, 28 Nov 2018, Julien Grall wrote: A follow-up patch will need to generate the VTTBR in a few places. Signed-off-by: Julien Grall --- xen/arch/arm/p2m.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[Xen-devel] Ping: Re: [PATCH] x86/cpuid: correct dependencies of post-SSE ISA extensions

2019-01-24 Thread Jan Beulich
>>> On 14.01.19 at 13:48, wrote: On 14.01.19 at 13:00, wrote: >> On 14/01/2019 11:39, Jan Beulich wrote: >>> First of all a PCLMULQDQ dependency was missing entirely. Add it as well >>> as AESNI and SHA to SSE2, as all of them act on vectors of integers, >>> whereas plain SSE supports

[Xen-devel] Ping: [PATCH] x86emul: correct AVX512BW write masking checks

2019-01-24 Thread Jan Beulich
>>> On 16.01.19 at 12:40, wrote: > On 14/01/2019 12:40, Jan Beulich wrote: >> For VPSADBW this likely was a result of bad copy-and-paste. >> >> For VPS{L,R}LDQ comment and code were not in line, but then again the >> comment also wasn't fully updated from the AVX2 original it got cloned >> from.

[Xen-devel] [linux-4.9 test] 132421: tolerable FAIL - PUSHED

2019-01-24 Thread osstest service owner
flight 132421 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/132421/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stopfail like 132063 test-amd64-i386-xl-qemut-win7-amd64 17

Re: [Xen-devel] [PATCH] arm: gic-v3: clear GICR active interrupts

2019-01-24 Thread Julien Grall
On 24/01/2019 07:22, Peng Fan wrote: Hi Julien Hi Peng, Are you ok with the following patch? This looks ok. Please resend it formally with the tag for-4.12 and the release manager (jgr...@suse.com) in CC. arm: gic: deactivate sgi immediately after eoi On i.MX8, we

Re: [Xen-devel] Xen-unstable PVHdom0: Assertion 'IS_ALIGNED(dfn_x(dfn), (1ul << page_order))' failed at iommu.c:324

2019-01-24 Thread Roger Pau Monné
On Thu, Jan 24, 2019 at 10:25:33AM +0100, Sander Eikelenboom wrote: > On 24/01/2019 08:50, Roger Pau Monné wrote: > > On Wed, Jan 23, 2019 at 08:56:48PM +0100, Sander Eikelenboom wrote: > >> On 23/01/2019 19:25, Roger Pau Monné wrote: > >>> On Wed, Jan 23, 2019 at 12:39:21AM +0100, Sander

Re: [Xen-devel] [PATCH v6 02/15] argo: introduce the argo_op hypercall boilerplate

2019-01-24 Thread Julien Grall
Hi, On 24/01/2019 02:04, Christopher Clark wrote: Presence is gated upon CONFIG_ARGO. Registers the hypercall previously reserved for this. Takes 5 arguments, does nothing and returns -ENOSYS. Will be avoiding a compat ABI by using fixed-size types in hypercall ops so HYPERCALL, rather than

Re: [Xen-devel] [PATCH for-4.12] iommu: fix order of arguments in iommu_map call at iommu_hwdom_init

2019-01-24 Thread Juergen Gross
On 24/01/2019 10:49, Jan Beulich wrote: On 23.01.19 at 19:08, wrote: >> The order of the page_order and the flags parameters are inverted in >> the call to iommu_map made in iommu_hwdom_init. >> >> Fixes: e8afe1124cc1 ("iommu: elide flushing for higher order map/unmap >> operations") >>

Re: [Xen-devel] [PATCH for-4.12] iommu: fix order of arguments in iommu_map call at iommu_hwdom_init

2019-01-24 Thread Jan Beulich
>>> On 24.01.19 at 10:43, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 24 January 2019 09:41 >> To: Roger Pau Monne >> Cc: Paul Durrant ; xen-devel > de...@lists.xenproject.org> >> Subject: Re: [PATCH for-4.12] iommu: fix order of arguments in

Re: [Xen-devel] [PATCH for-4.12] iommu: fix order of arguments in iommu_map call at iommu_hwdom_init

2019-01-24 Thread Jan Beulich
>>> On 23.01.19 at 19:08, wrote: > The order of the page_order and the flags parameters are inverted in > the call to iommu_map made in iommu_hwdom_init. > > Fixes: e8afe1124cc1 ("iommu: elide flushing for higher order map/unmap > operations") > Signed-off-by: Roger Pau Monné I notice you

Re: [Xen-devel] [PATCH] drm: Split out drm_probe_helper.h

2019-01-24 Thread Daniel Vetter
On Wed, Jan 23, 2019 at 06:00:15PM +0100, Sam Ravnborg wrote: > Hi Daniel. > > On Thu, Jan 17, 2019 at 10:03:34PM +0100, Daniel Vetter wrote: > > Having the probe helper stuff (which pretty much everyone needs) in > > the drm_crtc_helper.h file (which atomic drivers should never need) is > >

Re: [Xen-devel] [PATCH for-4.12] iommu: fix order of arguments in iommu_map call at iommu_hwdom_init

2019-01-24 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 24 January 2019 09:41 > To: Roger Pau Monne > Cc: Paul Durrant ; xen-devel de...@lists.xenproject.org> > Subject: Re: [PATCH for-4.12] iommu: fix order of arguments in iommu_map > call at iommu_hwdom_init > >

Re: [Xen-devel] [RFC PATCH v2 1/2] xen: credit2: rb-tree for runqueues

2019-01-24 Thread Dario Faggioli
On Wed, 2019-01-23 at 23:00 +0530, Praveen Kumar wrote: > Hi Dario, > Hi, > Thanks for your comments. > So, two things. Can you please not top post? :-) Also, trim the quotes, which means, when quoting while replying, which is the good thing to do, remove the stuff that are not necessary for

Re: [Xen-devel] [PATCH for-4.12] iommu: fix order of arguments in iommu_map call at iommu_hwdom_init

2019-01-24 Thread Jan Beulich
>>> On 23.01.19 at 19:08, wrote: > The order of the page_order and the flags parameters are inverted in > the call to iommu_map made in iommu_hwdom_init. > > Fixes: e8afe1124cc1 ("iommu: elide flushing for higher order map/unmap > operations") > Signed-off-by: Roger Pau Monné Reviewed-by: Jan

Re: [Xen-devel] [PATCH for-4.12] iommu: fix order of arguments in iommu_map call at iommu_hwdom_init

2019-01-24 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne [mailto:roger@citrix.com] > Sent: 23 January 2019 18:08 > To: xen-devel@lists.xenproject.org > Cc: Roger Pau Monne ; Jan Beulich > ; Paul Durrant > Subject: [PATCH for-4.12] iommu: fix order of arguments in iommu_map call > at

Re: [Xen-devel] Xen-unstable PVHdom0: Assertion 'IS_ALIGNED(dfn_x(dfn), (1ul << page_order))' failed at iommu.c:324

2019-01-24 Thread Sander Eikelenboom
On 24/01/2019 08:50, Roger Pau Monné wrote: > On Wed, Jan 23, 2019 at 08:56:48PM +0100, Sander Eikelenboom wrote: >> On 23/01/2019 19:25, Roger Pau Monné wrote: >>> On Wed, Jan 23, 2019 at 12:39:21AM +0100, Sander Eikelenboom wrote: On 22/01/2019 17:14, Roger Pau Monné wrote: > On Sun,

  1   2   >