[Xen-devel] [xen-4.11-testing test] 144753: tolerable FAIL - PUSHED

2019-12-12 Thread osstest service owner
flight 144753 xen-4.11-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/144753/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 10 debian-hvm-install fail never pass

Re: [Xen-devel] [PATCH v2 0/2] [PATCH-for-4.13] Work towards removing brctl

2019-12-12 Thread Jürgen Groß
On 13.12.19 05:08, Steven Haigh wrote: Start updating scripts for network functionality (Resending as the patch emails seem to have been eaten somewhere) The scripts for networking in Xen have a mixture of formatting, tab spacing, space spacing inconsistencies. We also have issues where

Re: [Xen-devel] [PATCH net-next] xen-netback: get rid of old udev related code

2019-12-12 Thread Jürgen Groß
On 12.12.19 20:05, David Miller wrote: From: Paul Durrant Date: Thu, 12 Dec 2019 13:54:06 + In the past it used to be the case that the Xen toolstack relied upon udev to execute backend hotplug scripts. However this has not been the case for many releases now and removal of the associated

[Xen-devel] [PATCH 1/2] Tidy up whitespace and formatting in file to be consistent.

2019-12-12 Thread Steven Haigh
Signed-off-by: Steven Haigh --- tools/hotplug/Linux/xen-network-common.sh | 144 +++--- 1 file changed, 70 insertions(+), 74 deletions(-) diff --git a/tools/hotplug/Linux/xen-network-common.sh b/tools/hotplug/Linux/xen-network-common.sh index 92ffa603f7..ab76827a64 100644 ---

[Xen-devel] [PATCH 2/2] Use ip for bridge related functions where brctl is not present

2019-12-12 Thread Steven Haigh
Signed-off-by: Steven Haigh --- tools/hotplug/Linux/colo-proxy-setup | 30 +-- tools/hotplug/Linux/vif-bridge| 19 -- tools/hotplug/Linux/vif2 | 12 +++-- tools/hotplug/Linux/xen-network-common.sh | 15 +--- 4 files

[Xen-devel] [PATCH v2 0/2] [PATCH-for-4.13] Work towards removing brctl

2019-12-12 Thread Steven Haigh
Start updating scripts for network functionality (Resending as the patch emails seem to have been eaten somewhere) The scripts for networking in Xen have a mixture of formatting, tab spacing, space spacing inconsistencies. We also have issues where CentOS 8 does not have brctl - being replaced

[Xen-devel] [xen-unstable test] 144747: regressions - FAIL

2019-12-12 Thread osstest service owner
flight 144747 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/144747/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-credit1 16 guest-start/debian.repeat fail REGR. vs. 144712 Tests which did

[Xen-devel] [PATCH v2 0/2] [PATCH-for-4.13] Work towards removing brctl

2019-12-12 Thread Steven Haigh
Start updating scripts for network functionality The scripts for networking in Xen have a mixture of formatting, tab spacing, space spacing inconsistencies. We also have issues where CentOS 8 does not have brctl - being replaced with ip / bridge commands. This series starts cleaning up

[Xen-devel] [PATCH 0/2] [PATCH-for-4.13] Work towards removing brctl

2019-12-12 Thread Steven Haigh
Start updating scripts for network functionality The scripts for networking in Xen have a mixture of formatting, tab spacing, space spacing inconsistencies. We also have issues where CentOS 8 does not have brctl - being replaced with ip / bridge commands. This series starts cleaning up

[Xen-devel] [PATCH 1/2] Tidy up whitespace and formatting in file to be consistent.

2019-12-12 Thread Steven Haigh
Signed-off-by: Steven Haigh --- tools/hotplug/Linux/xen-network-common.sh | 144 +++--- 1 file changed, 70 insertions(+), 74 deletions(-) diff --git a/tools/hotplug/Linux/xen-network-common.sh b/tools/hotplug/Linux/xen-network-common.sh index 92ffa603f7..ab76827a64 100644 ---

[Xen-devel] [PATCH 2/2] Use ip for bridge related functions where brctl is not present

2019-12-12 Thread Steven Haigh
Signed-off-by: Steven Haigh --- tools/hotplug/Linux/colo-proxy-setup | 30 +-- tools/hotplug/Linux/vif-bridge| 19 -- tools/hotplug/Linux/vif2 | 12 +++-- tools/hotplug/Linux/xen-network-common.sh | 15 +--- 4 files

[Xen-devel] [libvirt test] 144751: regressions - FAIL

2019-12-12 Thread osstest service owner
flight 144751 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/144751/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 144517 build-i386-libvirt

[Xen-devel] [xen-4.13-testing test] 144736: regressions - FAIL

2019-12-12 Thread osstest service owner
flight 144736 xen-4.13-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/144736/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-credit1 7 xen-boot fail REGR. vs. 144673

Re: [Xen-devel] [PATCH] x86/microcode: Support builtin CPU microcode

2019-12-12 Thread Eslam Elnikety
On 11.12.19 10:54, Jan Beulich wrote: On 11.12.2019 00:18, Eslam Elnikety wrote: On 10.12.19 10:37, Jan Beulich wrote: On 09.12.2019 09:41, Eslam Elnikety wrote: --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -2113,7 +2113,7 @@ logic applies: active

Re: [Xen-devel] [PATCH] x86/microcode: Support builtin CPU microcode

2019-12-12 Thread Eslam Elnikety
On 11.12.19 10:47, Jan Beulich wrote: On 10.12.2019 23:40, Eslam Elnikety wrote: On 10.12.19 10:21, Jan Beulich wrote: On 09.12.2019 22:49, Eslam Elnikety wrote: On 09.12.19 16:19, Andrew Cooper wrote: On 09/12/2019 08:41, Eslam Elnikety wrote: --- /dev/null +++

[Xen-devel] [PATCH v3 7/7] Added Resolving Disagreement

2019-12-12 Thread Lars Kurth
From: Lars Kurth This guide provides Best Practice on identifying and resolving common classes of disagreement Changes since v2 (added in v2) * Fix typos * Add section: "Issue: Multiple ways to solve a problem" * Changed line wrapping to 80 characters * Replaced inline style links with

[Xen-devel] [PATCH v3 6/7] Add guide on Communication Best Practice

2019-12-12 Thread Lars Kurth
From: Lars Kurth This guide covers the bulk on Best Practice related to code review It primarily focusses on code review interactions It also covers how to deal with Misunderstandings and Cultural Differences Changes since v2 (added in v2) * Fix typos * Extended "Verbose vs. terse" * Added

[Xen-devel] [PATCH v3 1/7] Import v1.4 of Contributor Covenant CoC

2019-12-12 Thread Lars Kurth
From: Lars Kurth Signed-off-by: Lars Kurth --- Cc: minios-de...@lists.xenproject.org Cc: xen-...@lists.xenproject.org Cc: win-pv-de...@lists.xenproject.org Cc: mirageos-de...@lists.xenproject.org Cc: committ...@xenproject.org --- code-of-conduct.md | 76

[Xen-devel] [PATCH v3 0/7] Code of Conduct + Extra Guides and Best Practices

2019-12-12 Thread Lars Kurth
From: Lars Kurth This series proposes a concrete version of the Xen Project CoC based on v1.4 of the Contributor Covenant. See [1] It tries to address all elements in the v2 review, which raised a number of hard questions. One of the main outstanding items were good examples for cover letters

[Xen-devel] [PATCH v3 2/7] Xen Project Code of Conduct

2019-12-12 Thread Lars Kurth
From: Lars Kurth Specific changes to the baseline: * Replace list of positive behaviors with link to separate process * Replace maintainers with project leadership (except in our pledge where maintainers is more appropriate) * Add 'of all sub-projects' to clarify scope of CoC * Rename

[Xen-devel] [PATCH v3 5/7] Add Code Review Guide

2019-12-12 Thread Lars Kurth
From: Lars Kurth This document highlights what reviewers such as maintainers and committers look for when reviewing code. It sets expectations for code authors and provides a framework for code reviewers. Changes since v2 (introduced in v2) * Extend introduction * Add "Code Review Workflow"

[Xen-devel] [PATCH v3 4/7] Add Communication Guide

2019-12-12 Thread Lars Kurth
From: Lars Kurth This document is a portal page that lays out our gold standard, best practices for some common situations and mechanisms to help resolve issues that can have a negative effect on our community. Detail is covered in subsequent documents Changes since v2 (introduced in v2) -

[Xen-devel] [PATCH v3 3/7] Reformat Xen Project CoC to fit into 80 character limit

2019-12-12 Thread Lars Kurth
From: Lars Kurth No content changes Signed-off-by: Lars Kurth --- Cc: minios-de...@lists.xenproject.org Cc: xen-...@lists.xenproject.org Cc: win-pv-de...@lists.xenproject.org Cc: mirageos-de...@lists.xenproject.org Cc: committ...@xenproject.org --- code-of-conduct.md | 56

[Xen-devel] [xtf test] 144743: all pass - PUSHED

2019-12-12 Thread osstest service owner
flight 144743 xtf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144743/ Perfect :-) All tests in this flight passed as required version targeted for testing: xtf 27c415ad6e4a48eb3aac6e9d0adc6d0ef04d40cf baseline version: xtf

Re: [Xen-devel] [PATCH 4/4] x86/mm: More discriptive names for page de/validation functions

2019-12-12 Thread Andrew Cooper
On 12/12/2019 17:32, George Dunlap wrote: > The functions alloc_page_type(), alloc_lN_table(), free_page_type() > and free_lN_table() are confusingly named: There is alloc_segdesc_page() which should be adjusted for consistency. > nothing is being allocated or freed. Well - strictly speaking

[Xen-devel] [xen-4.10-testing test] 144728: regressions - trouble: fail/pass/starved

2019-12-12 Thread osstest service owner
flight 144728 xen-4.10-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/144728/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-i386-xsm 13 guest-saverestore fail REGR. vs. 144324

Re: [Xen-devel] [PATCH 3/4] x86/mm: Use a more descriptive name for pagetable mfns

2019-12-12 Thread Andrew Cooper
On 12/12/2019 17:32, George Dunlap wrote: > In many places, a PTE being modified is accompanied by the pagetable > mfn which contains the PTE (primarily in order to be able to maintain > linear mapping counts). In many cases, this mfn is stored in the > non-descript variable (or argement) "pfn".

Re: [Xen-devel] [PATCH 2/4] x86/mm: Implement common put_data_pages for put_page_from_l[23]e

2019-12-12 Thread Andrew Cooper
On 12/12/2019 17:32, George Dunlap wrote: > Both put_page_from_l2e and put_page_from_l3e handle having superpage > entries by looping over each page and "put"-ing each one individually. > As with putting page table entries, this code is functionally > identical, but for some reason different.

Re: [Xen-devel] [PATCH 1/4] x86/mm: Refactor put_page_from_l*e to reduce code duplication

2019-12-12 Thread Andrew Cooper
On 12/12/2019 17:32, George Dunlap wrote: > put_page_from_l[234]e have identical functionality for devalidating an > N-1 entry which is a pagetable. But mystifyingly, they duplicate the > code in slightly different arrangements that make it hard to tell that > it's the same. ITYM "this code has

Re: [Xen-devel] [PATCH 4/4] x86/mm: More discriptive names for page de/validation functions

2019-12-12 Thread Andrew Cooper
On 12/12/2019 17:32, George Dunlap wrote: > @@ -3016,7 +3016,7 @@ static int _get_page_type(struct page_info *page, > unsigned long type, > page->partial_flags = 0; > } > page->linear_pt_count = 0; > -rc = alloc_page_type(page, type, preemptible); > +

Re: [Xen-devel] [PATCH net-next] xen-netback: get rid of old udev related code

2019-12-12 Thread David Miller
From: Paul Durrant Date: Thu, 12 Dec 2019 13:54:06 + > In the past it used to be the case that the Xen toolstack relied upon > udev to execute backend hotplug scripts. However this has not been the > case for many releases now and removal of the associated code in > xen-netback shortens the

Re: [Xen-devel] [XEN PATCH 8/8] xen: Move GCC_HAS_VISIBILITY_ATTRIBUTE to Kconfig and common

2019-12-12 Thread Andrew Cooper
On 12/12/2019 18:27, Anthony PERARD wrote: > diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h > index ff6c0f5cdd18..8c846261d241 100644 > --- a/xen/include/xen/compiler.h > +++ b/xen/include/xen/compiler.h > @@ -78,7 +78,7 @@ > #define __must_be_array(a) \ >

Re: [Xen-devel] [XEN PATCH 7/8] xen: Use $(CONFIG_CC_IS_CLANG) instead of $(clang) in Makefile

2019-12-12 Thread Andrew Cooper
On 12/12/2019 18:27, Anthony PERARD wrote: > Kconfig can check if $(CC) is clang or not, if it is > CONFIG_CC_IS_CLANG will be set. > > With that patch, the hypervisor can be built using clang by running > `make CC=clang CXX=clang++` without needed to provide an extra clang > parameter. > > `make

Re: [Xen-devel] [PATCH net] xen-netback: avoid race that can lead to NULL pointer dereference

2019-12-12 Thread David Miller
From: Paul Durrant Date: Thu, 12 Dec 2019 12:37:23 + > Commit 2ac061ce97f4 ("xen/netback: cleanup init and deinit code") > introduced a problem. In function xenvif_disconnect_queue(), the value of > queue->rx_irq is zeroed *before* queue->task is stopped. Unfortunately that > task may call

Re: [Xen-devel] [XEN PATCH 6/8] xen: Move CONFIG_INDIRECT_THUNK to Kconfig

2019-12-12 Thread Andrew Cooper
On 12/12/2019 18:27, Anthony PERARD wrote: > Now that Kconfig has the capability to run shell command when > generating CONFIG_* we can use it in some cases to test CFLAGS. > > CONFIG_INDIRECT_THUNK is a good example that wants to exist both in > Makefile and as a C macro, which Kconfig do. So use

Re: [Xen-devel] [XEN PATCH 5/8] xen: Import cc-ifversion from Kbuild

2019-12-12 Thread Andrew Cooper
On 12/12/2019 18:27, Anthony PERARD wrote: > This is in preparation of importing Kbuild to build Xen. We won't be > able to include Config.mk so we will need a replacement for the macro > `cc-ifversion'. > > This patch imports parts of "scripts/Kbuild.include" from Linux v5.4, > the macro

Re: [Xen-devel] [XEN PATCH 4/8] xen: Have Kconfig check $(CC)'s version

2019-12-12 Thread Andrew Cooper
On 12/12/2019 18:27, Anthony PERARD wrote: > diff --git a/xen/Makefile b/xen/Makefile > index efbe9605e52b..0cf4ded9d9d4 100644 > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -267,6 +267,7 @@ $(foreach base,arch/x86/mm/guest_walk_% \ > arch/x86/mm/shadow/guest_%, \ > $(foreach

Re: [Xen-devel] [XEN PATCH 3/8] xen: Update Kconfig to Linux v5.4

2019-12-12 Thread Andrew Cooper
On 12/12/2019 18:27, Anthony PERARD wrote: > This patch updates Kconfig to a more recent version of Kconfig, found > in Linux v5.4.0, 219d54332a09 ("Linux 5.4"). > > With the updated version of Kconfig, other changes are necessary to > avoid breaking the build. > > Kconfig files: > - fix Kconfig

[Xen-devel] [ovmf test] 144737: regressions - FAIL

2019-12-12 Thread osstest service owner
flight 144737 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144737/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 144637 build-i386-xsm

Re: [Xen-devel] [XEN PATCH 2/8] Config.mk: Remove stray comment

2019-12-12 Thread Andrew Cooper
On 12/12/2019 18:27, Anthony PERARD wrote: > This comment isn't about CONFIG_TESTS, but about SEABIOS_DIR that has > been removed. > > Originally, the comment was added by 5f82d0858de1 ("tools: support > SeaBIOS. Use by default when upstream qemu is configured."), then > later the SEABIOS_DIR was

Re: [Xen-devel] [PATCH] xen/balloon: fix ballooned page accounting without hotplug enabled

2019-12-12 Thread Boris Ostrovsky
On 12/12/19 9:17 AM, Juergen Gross wrote: When CONFIG_XEN_BALLOON_MEMORY_HOTPLUG is not defined reserve_additional_memory() will set balloon_stats.target_pages to a wrong value in case there are still some ballooned pages allocated via alloc_xenballooned_pages(). This will result in

Re: [Xen-devel] [XEN PATCH 1/8] Config.mk: Remove unused setvar_dir macro

2019-12-12 Thread Andrew Cooper
On 12/12/2019 18:27, Anthony PERARD wrote: > And remove all mention of it in docs. It hasn't been used since > 9ead9afcb935 ("Add configure --with-sysconfig-leaf-dir=SUBDIR to set > CONFIG_LEAF_DIR"). > > Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper > --- > Config.mk

[Xen-devel] [XEN PATCH 0/8] xen: Kconfig update with few extra

2019-12-12 Thread Anthony PERARD
Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.build-system-xen-kconfig-v1 Hi, This is a update of Kconfig as used to build the hypervisor. This is also in preparation of using Kbuild. The first version of the series, with a POC of

[Xen-devel] [XEN PATCH 6/8] xen: Move CONFIG_INDIRECT_THUNK to Kconfig

2019-12-12 Thread Anthony PERARD
Now that Kconfig has the capability to run shell command when generating CONFIG_* we can use it in some cases to test CFLAGS. CONFIG_INDIRECT_THUNK is a good example that wants to exist both in Makefile and as a C macro, which Kconfig do. So use Kconfig to generate CONFIG_INDIRECT_THUNK and have

[Xen-devel] [XEN PATCH 2/8] Config.mk: Remove stray comment

2019-12-12 Thread Anthony PERARD
This comment isn't about CONFIG_TESTS, but about SEABIOS_DIR that has been removed. Originally, the comment was added by 5f82d0858de1 ("tools: support SeaBIOS. Use by default when upstream qemu is configured."), then later the SEABIOS_DIR was removed by 14ee3c05f3ef ("Clone and build Seabios by

[Xen-devel] [XEN PATCH 4/8] xen: Have Kconfig check $(CC)'s version

2019-12-12 Thread Anthony PERARD
This import several files from Linux v5.3 - scripts/Kconfig.include - scripts/clang-version.sh - scripts/gcc-version.sh and several config values from from Linux's init/Kconfig file. Files are copied into scripts/ directory because that's were the files are found in Linux tree, and also

[Xen-devel] [XEN PATCH 7/8] xen: Use $(CONFIG_CC_IS_CLANG) instead of $(clang) in Makefile

2019-12-12 Thread Anthony PERARD
Kconfig can check if $(CC) is clang or not, if it is CONFIG_CC_IS_CLANG will be set. With that patch, the hypervisor can be built using clang by running `make CC=clang CXX=clang++` without needed to provide an extra clang parameter. `make clang=y` still works as Config.mk will set CC and CXX.

[Xen-devel] [XEN PATCH 8/8] xen: Move GCC_HAS_VISIBILITY_ATTRIBUTE to Kconfig and common

2019-12-12 Thread Anthony PERARD
The check for $(CC) -fvisibility=hidden is done by both arm and x86, so the patch also move the check to the common area. The check doesn't check if $(CC) is gcc, and clang can accept that option as well, so s/GCC/CC/ is done to the define name. Signed-off-by: Anthony PERARD --- xen/Kconfig

[Xen-devel] [XEN PATCH 1/8] Config.mk: Remove unused setvar_dir macro

2019-12-12 Thread Anthony PERARD
And remove all mention of it in docs. It hasn't been used since 9ead9afcb935 ("Add configure --with-sysconfig-leaf-dir=SUBDIR to set CONFIG_LEAF_DIR"). Signed-off-by: Anthony PERARD --- Config.mk| 11 --- docs/misc/distro_mapping.txt | 5 ++--- 2 files changed, 2

[Xen-devel] [XEN PATCH 5/8] xen: Import cc-ifversion from Kbuild

2019-12-12 Thread Anthony PERARD
This is in preparation of importing Kbuild to build Xen. We won't be able to include Config.mk so we will need a replacement for the macro `cc-ifversion'. This patch imports parts of "scripts/Kbuild.include" from Linux v5.4, the macro cc-ifversion. It makes use of CONFIG_GCC_VERSION that Kconfig

Re: [Xen-devel] [PATCH net] xen-netback: avoid race that can lead to NULL pointer dereference

2019-12-12 Thread Wei Liu
On Thu, Dec 12, 2019 at 12:37:23PM +, Paul Durrant wrote: > Commit 2ac061ce97f4 ("xen/netback: cleanup init and deinit code") > introduced a problem. In function xenvif_disconnect_queue(), the value of > queue->rx_irq is zeroed *before* queue->task is stopped. Unfortunately that > task may

[Xen-devel] [PATCH 4/4] x86/mm: More discriptive names for page de/validation functions

2019-12-12 Thread George Dunlap
The functions alloc_page_type(), alloc_lN_table(), free_page_type() and free_lN_table() are confusingly named: nothing is being allocated or freed. Rather, the page being passed in is being either validated or devalidated for use as the specific type. Rename these functions to "validate" and

[Xen-devel] [PATCH 0/4] Post-299 cleanups

2019-12-12 Thread George Dunlap
This series implements a number of cleanups to make the code simpler and easier to follow. No functional changes intended. George Dunlap (4): x86/mm: Refactor put_page_from_l*e to reduce code duplication x86/mm: Implement common put_data_pages for put_page_from_l[23]e x86/mm: Use a more

[Xen-devel] [PATCH 2/4] x86/mm: Implement common put_data_pages for put_page_from_l[23]e

2019-12-12 Thread George Dunlap
Both put_page_from_l2e and put_page_from_l3e handle having superpage entries by looping over each page and "put"-ing each one individually. As with putting page table entries, this code is functionally identical, but for some reason different. Moreover, there is already a common function,

[Xen-devel] [PATCH 1/4] x86/mm: Refactor put_page_from_l*e to reduce code duplication

2019-12-12 Thread George Dunlap
put_page_from_l[234]e have identical functionality for devalidating an N-1 entry which is a pagetable. But mystifyingly, they duplicate the code in slightly different arrangements that make it hard to tell that it's the same. Create a new function, put_pt_page(), which handles the common

[Xen-devel] [PATCH 3/4] x86/mm: Use a more descriptive name for pagetable mfns

2019-12-12 Thread George Dunlap
In many places, a PTE being modified is accompanied by the pagetable mfn which contains the PTE (primarily in order to be able to maintain linear mapping counts). In many cases, this mfn is stored in the non-descript variable (or argement) "pfn". Replace these names with lNmfn, to indicate that

[Xen-devel] [xen-4.8-testing test] 144761: trouble: pass/preparing/queued

2019-12-12 Thread osstest service owner
flight 144761 xen-4.8-testing running [real] http://logs.test-lab.xenproject.org/osstest/logs/144761/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 queued

Re: [Xen-devel] [xen-4.9-testing test] 144723: regressions - trouble: fail/pass/starved

2019-12-12 Thread Ian Jackson
osstest service owner writes ("[xen-4.9-testing test] 144723: regressions - trouble: fail/pass/starved"): > flight 144723 xen-4.9-testing real [real] > http://logs.test-lab.xenproject.org/osstest/logs/144723/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including

[Xen-devel] [xen-unstable-smoke test] 144766: tolerable all pass - PUSHED

2019-12-12 Thread osstest service owner
flight 144766 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/144766/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] [PATCH net-next] xen-netback: get rid of old udev related code

2019-12-12 Thread Durrant, Paul
> -Original Message- > From: jandr...@gmail.com > Sent: 12 December 2019 16:32 > To: Durrant, Paul > Cc: xen-devel ; net...@vger.kernel.org; > open list ; Wei Liu ; > David S. Miller > Subject: Re: [Xen-devel] [PATCH net-next] xen-netback: get rid of old udev > related code > > On Thu,

Re: [Xen-devel] [PATCH net-next] xen-netback: get rid of old udev related code

2019-12-12 Thread Jason Andryuk
On Thu, Dec 12, 2019 at 8:56 AM Paul Durrant wrote: > > In the past it used to be the case that the Xen toolstack relied upon > udev to execute backend hotplug scripts. However this has not been the > case for many releases now and removal of the associated code in > xen-netback shortens the

Re: [Xen-devel] [PATCH v7 2/3] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-12 Thread SeongJae Park
On Thu, 12 Dec 2019 16:23:17 +0100 "Roger Pau Monné" wrote: > > On Thu, 12 Dec 2019 12:42:47 +0100 "Roger Pau Monné" > > wrote: > > > > On the slow block device > > > > > > > > > > > > max_pgs Min Max Median AvgStddev > > > > 0

Re: [Xen-devel] [xen-4.8-testing test] 144726: regressions - trouble: fail/pass/starved [and 1 more messages]

2019-12-12 Thread Jan Beulich
On 12.12.2019 17:01, Ian Jackson wrote: > Jan Beulich writes ("Re: [xen-4.8-testing test] 144726: regressions - > trouble: fail/pass/starved"): >> On 12.12.2019 16:40, Ian Jackson wrote: >>> From Juergen I would like a release-ack for the osstest commit to >>> "allow" it for the future. >> >> Is

Re: [Xen-devel] [PATCH v7 2/3] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-12 Thread SeongJae Park
On Thu, 12 Dec 2019 16:27:57 +0100 "Roger Pau Monné" wrote: > > diff --git a/drivers/block/xen-blkback/blkback.c > > b/drivers/block/xen-blkback/blkback.c > > index fd1e19f1a49f..98823d150905 100644 > > --- a/drivers/block/xen-blkback/blkback.c > > +++ b/drivers/block/xen-blkback/blkback.c > >

Re: [Xen-devel] [xen-4.8-testing test] 144726: regressions - trouble: fail/pass/starved [and 1 more messages]

2019-12-12 Thread Ian Jackson
Jan Beulich writes ("Re: [xen-4.8-testing test] 144726: regressions - trouble: fail/pass/starved"): > On 12.12.2019 16:40, Ian Jackson wrote: > > If Jan approves will force push 4.8-testing. > > I do. Thanks. Done. > > From Juergen I would like a release-ack for the osstest commit to > >

Re: [Xen-devel] [xen-4.8-testing test] 144726: regressions - trouble: fail/pass/starved

2019-12-12 Thread Andrew Cooper
On 12/12/2019 15:54, Jürgen Groß wrote: > On 12.12.19 16:51, Jan Beulich wrote: >> On 12.12.2019 16:40, Ian Jackson wrote: >>> osstest service owner writes ("[xen-4.8-testing test] 144726: >>> regressions - trouble: fail/pass/starved"): flight 144726 xen-4.8-testing real [real]

Re: [Xen-devel] [PATCH] x86emul: correct LFS et al handling for 64-bit mode

2019-12-12 Thread Jan Beulich
On 12.12.2019 15:20, Andrew Cooper wrote: > On 12/12/2019 13:05, Jan Beulich wrote: >> On 12.12.2019 12:37, Andrew Cooper wrote: >>> On 12/12/2019 10:11, Jan Beulich wrote: On 11.12.2019 21:57, Andrew Cooper wrote: > On 11/12/2019 09:28, Jan Beulich wrote: >> AMD and friends

Re: [Xen-devel] [xen-4.8-testing test] 144726: regressions - trouble: fail/pass/starved

2019-12-12 Thread Jürgen Groß
On 12.12.19 16:51, Jan Beulich wrote: On 12.12.2019 16:40, Ian Jackson wrote: osstest service owner writes ("[xen-4.8-testing test] 144726: regressions - trouble: fail/pass/starved"): flight 144726 xen-4.8-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/144726/

Re: [Xen-devel] [xen-4.8-testing test] 144726: regressions - trouble: fail/pass/starved

2019-12-12 Thread Jan Beulich
On 12.12.2019 16:40, Ian Jackson wrote: > osstest service owner writes ("[xen-4.8-testing test] 144726: regressions - > trouble: fail/pass/starved"): >> flight 144726 xen-4.8-testing real [real] >> http://logs.test-lab.xenproject.org/osstest/logs/144726/ >> >> Regressions :-( >> >> Tests which

Re: [Xen-devel] [xen-4.8-testing test] 144726: regressions - trouble: fail/pass/starved

2019-12-12 Thread Ian Jackson
osstest service owner writes ("[xen-4.8-testing test] 144726: regressions - trouble: fail/pass/starved"): > flight 144726 xen-4.8-testing real [real] > http://logs.test-lab.xenproject.org/osstest/logs/144726/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including

Re: [Xen-devel] [PATCH v7 2/3] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-12 Thread Roger Pau Monné
On Wed, Dec 11, 2019 at 06:10:15PM +, SeongJae Park wrote: > diff --git a/drivers/block/xen-blkback/blkback.c > b/drivers/block/xen-blkback/blkback.c > index fd1e19f1a49f..98823d150905 100644 > --- a/drivers/block/xen-blkback/blkback.c > +++ b/drivers/block/xen-blkback/blkback.c > @@ -142,6

Re: [Xen-devel] [PATCH v7 2/3] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-12 Thread Roger Pau Monné
On Thu, Dec 12, 2019 at 02:39:05PM +0100, SeongJae Park wrote: > On Thu, 12 Dec 2019 12:42:47 +0100 "Roger Pau Monné" > wrote: > > > On the slow block device > > > > > > > > > max_pgs Min Max Median AvgStddev > > > 0 38.7 45.8

Re: [Xen-devel] [PATCH v4 4/9] x86/mm: introduce l{1, 2}t local variables to modify_xen_mappings

2019-12-12 Thread Julien Grall
Hi, On 04/12/2019 17:10, Hongyan Xia wrote: From: Wei Liu The pl2e and pl1e variables are heavily (ab)used in that function. It is fine at the moment because all page tables are always mapped so there is no need to track the life time of each variable. We will soon have the requirement to

Re: [Xen-devel] [BUG] Xen-ballooned memory never returned to domain after partial-free

2019-12-12 Thread Nicholas Tsirakis
>> Do you happen to know the answer to my second question? It's not as >> important, >> but it does confuse me as I wouldn't expect the total memory to be >> balloon-able at >> all with the hotplugging configs disabled. > Ballooning != hotplugging memory > > With memory hotplug you can add (or -

Re: [Xen-devel] [BUG] Xen-ballooned memory never returned to domain after partial-free

2019-12-12 Thread Jürgen Groß
On 12.12.19 15:10, Nicholas Tsirakis wrote: And I think this is the problem. We want here: balloon_stats.target_pages = balloon_stats.current_pages + balloon_stats.target_unpopulated; Ahh I knew I was missing something. Tested the patch, works great!

Re: [Xen-devel] [PATCH] x86emul: correct LFS et al handling for 64-bit mode

2019-12-12 Thread Andrew Cooper
On 12/12/2019 13:05, Jan Beulich wrote: > On 12.12.2019 12:37, Andrew Cooper wrote: >> On 12/12/2019 10:11, Jan Beulich wrote: >>> On 11.12.2019 21:57, Andrew Cooper wrote: On 11/12/2019 09:28, Jan Beulich wrote: > AMD and friends explicitly specify that 64-bit operands aren't possible

[Xen-devel] [PATCH] xen/balloon: fix ballooned page accounting without hotplug enabled

2019-12-12 Thread Juergen Gross
When CONFIG_XEN_BALLOON_MEMORY_HOTPLUG is not defined reserve_additional_memory() will set balloon_stats.target_pages to a wrong value in case there are still some ballooned pages allocated via alloc_xenballooned_pages(). This will result in balloon_process() no longer be triggered when ballooned

Re: [Xen-devel] [PATCH-for-4.13] build: fix tools/configure in case only python3 exists

2019-12-12 Thread Wei Liu
On Thu, Dec 12, 2019 at 02:11:32PM +, Ian Jackson wrote: > Thanks for tidying this up. > > Juergen Gross writes ("[PATCH-for-4.13] build: fix tools/configure in case > only python3 exists"): > > -AS_IF([test -z "$PYTHON"], [PYTHON="python"]) > > -AS_IF([echo "$PYTHON" | grep -q "^/"], [],

Re: [Xen-devel] [PATCH-for-4.13] build: fix tools/configure in case only python3 exists

2019-12-12 Thread Ian Jackson
Thanks for tidying this up. Juergen Gross writes ("[PATCH-for-4.13] build: fix tools/configure in case only python3 exists"): > -AS_IF([test -z "$PYTHON"], [PYTHON="python"]) > -AS_IF([echo "$PYTHON" | grep -q "^/"], [], [PYTHON=`type -p "$PYTHON"`]) > +AS_IF([test -z "$PYTHON"],

Re: [Xen-devel] [BUG] Xen-ballooned memory never returned to domain after partial-free

2019-12-12 Thread Nicholas Tsirakis
> And I think this is the problem. We want here: > > balloon_stats.target_pages = balloon_stats.current_pages + > balloon_stats.target_unpopulated; Ahh I knew I was missing something. Tested the patch, works great! "Reported by" is fine with me. Do you happen

Re: [Xen-devel] [PATCH] IOMMU: make DMA containment of quarantined devices optional

2019-12-12 Thread Jan Beulich
On 12.12.2019 14:15, Roger Pau Monné wrote: > On Thu, Dec 12, 2019 at 10:28:26AM +0100, Jan Beulich wrote: >> On 11.12.2019 16:54, Roger Pau Monné wrote: >>> On Wed, Dec 11, 2019 at 01:53:00PM +0100, Jan Beulich wrote: --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c +++

[Xen-devel] [xen-4.8-testing test] 144726: regressions - trouble: fail/pass/starved

2019-12-12 Thread osstest service owner
flight 144726 xen-4.8-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/144726/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-xtf-amd64-amd64-5 50 xtf/test-hvm64-lbr-tsx-vmentry fail REGR. vs. 144558 Tests which

[Xen-devel] [PATCH net-next] xen-netback: get rid of old udev related code

2019-12-12 Thread Paul Durrant
In the past it used to be the case that the Xen toolstack relied upon udev to execute backend hotplug scripts. However this has not been the case for many releases now and removal of the associated code in xen-netback shortens the source by more than 100 lines, and removes much complexity in the

Re: [Xen-devel] [PATCH v7 2/3] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-12 Thread SeongJae Park
On Thu, 12 Dec 2019 12:42:47 +0100 "Roger Pau Monné" wrote: > > Please make sure you Cc me in blkback related patches. Sorry for forgotting you! I will never forget again. > > On Wed, Dec 11, 2019 at 06:10:15PM +, SeongJae Park wrote: > > Each `blkif` has a free pages pool for the

Re: [Xen-devel] [PATCH v4 0/2] Refactor super page shattering

2019-12-12 Thread Jan Beulich
On 12.12.2019 13:46, Hongyan Xia wrote: > map_pages_to_xen and modify_xen_mappings use almost exactly the same > page shattering logic, and the code is mingled with other PTE > manipulations so it is less obvious that the intention is page > shattering. Factor out the functions to make them

Re: [Xen-devel] [PATCH] IOMMU: make DMA containment of quarantined devices optional

2019-12-12 Thread Roger Pau Monné
On Thu, Dec 12, 2019 at 10:28:26AM +0100, Jan Beulich wrote: > On 11.12.2019 16:54, Roger Pau Monné wrote: > > On Wed, Dec 11, 2019 at 01:53:00PM +0100, Jan Beulich wrote: > >> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c > >> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c > >> @@ -85,18

Re: [Xen-devel] [PATCH] x86emul: correct LFS et al handling for 64-bit mode

2019-12-12 Thread Jan Beulich
On 12.12.2019 12:37, Andrew Cooper wrote: > On 12/12/2019 10:11, Jan Beulich wrote: >> On 11.12.2019 21:57, Andrew Cooper wrote: >>> On 11/12/2019 09:28, Jan Beulich wrote: AMD and friends explicitly specify that 64-bit operands aren't possible for these insns. Nevertheless REX.W isn't

Re: [Xen-devel] [PATCH V3 1/2] x86/altp2m: Add hypercall to set a range of sve bits

2019-12-12 Thread Alexandru Stefan ISAILA
On 12.12.2019 13:26, George Dunlap wrote: > On 12/12/19 9:37 AM, Alexandru Stefan ISAILA wrote: >> >> >> On 06.12.2019 17:29, George Dunlap wrote: >>> On 11/21/19 3:02 PM, Alexandru Stefan ISAILA wrote: By default the sve bits are not set. This patch adds a new hypercall,

[Xen-devel] [PATCH v4 0/2] Refactor super page shattering

2019-12-12 Thread Hongyan Xia
map_pages_to_xen and modify_xen_mappings use almost exactly the same page shattering logic, and the code is mingled with other PTE manipulations so it is less obvious that the intention is page shattering. Factor out the functions to make them reusable and to make the intention more obvious. Of

[Xen-devel] [PATCH v4 1/2] x86/mm: factor out the code for shattering an l3 PTE

2019-12-12 Thread Hongyan Xia
map_pages_to_xen and modify_xen_mappings are performing almost exactly the same operations when shattering an l3 PTE, the only difference being whether we want to flush. Signed-off-by: Hongyan Xia --- Changes in v4: - use false/true instead of -1/0 to indicate failure/success. - remove

[Xen-devel] [PATCH v4 2/2] x86/mm: factor out the code for shattering an l2 PTE

2019-12-12 Thread Hongyan Xia
map_pages_to_xen and modify_xen_mappings are performing almost exactly the same operations when shattering an l2 PTE, the only difference being whether we want to flush. Signed-off-by: Hongyan Xia --- Changes in v4: - use false/true instead of -1/0 to indicate failure/success. - remove

[Xen-devel] [PATCH net] xen-netback: avoid race that can lead to NULL pointer dereference

2019-12-12 Thread Paul Durrant
Commit 2ac061ce97f4 ("xen/netback: cleanup init and deinit code") introduced a problem. In function xenvif_disconnect_queue(), the value of queue->rx_irq is zeroed *before* queue->task is stopped. Unfortunately that task may call notify_remote_via_irq(queue->rx_irq) and calling that function with

Re: [Xen-devel] [PATCH] x86: store cr4 during suspend/resume

2019-12-12 Thread Andrew Cooper
On 12/12/2019 09:52, Jan Beulich wrote: > On 11.12.2019 20:36, Andrew Cooper wrote: >> On 10/12/2019 10:07, Jan Beulich wrote: >>> On 10.12.2019 10:59, Andrew Cooper wrote: On 09/12/2019 18:06, Roger Pau Monne wrote: > Currently cr4 is not cached before suspension, and mmu_cr4_features is

Re: [Xen-devel] [PATCH] x86emul: correct segment override decode for 64-bit mode

2019-12-12 Thread Andrew Cooper
On 12/12/2019 10:04, Jan Beulich wrote: > On 11.12.2019 21:51, Andrew Cooper wrote: >> On 11/12/2019 09:27, Jan Beulich wrote: >>> The legacy / compatibility mode ES, CS, SS, and DS overrides are null >>> prefixes in 64-bit mode, i.e. they in particular don't cancel an >>> earlier FS or GS one.

Re: [Xen-devel] [PATCH v2] xen/arm: remove physical timer offset

2019-12-12 Thread Julien Grall
Hi, On 11/12/2019 20:00, Jeff Kubascik wrote: On 12/5/2019 3:28 PM, Julien Grall wrote: However, set_timer expects a signed 64 bit value in ns. The conversion of cval (unsigned 64 bit) from ticks to ns is going to overflow this. I'm not sure what would be the best way to work around this

Re: [Xen-devel] [PATCH-for-4.13] build: fix tools/configure in case only python3 exists

2019-12-12 Thread Wei Liu
On Wed, Dec 11, 2019 at 05:56:59PM +0100, Juergen Gross wrote: > Calling ./configure with python3 being there but no python, > tools/configure will fail. Fix that by defaulting to python and > falling back to python3 or python2. > > While at it fix the use of non portable "type -p" by replacing

Re: [Xen-devel] [PATCH v3 4/4] xen-blkback: support dynamic unbind/bind

2019-12-12 Thread Jürgen Groß
On 12.12.19 12:46, Roger Pau Monné wrote: On Wed, Dec 11, 2019 at 03:29:56PM +, Paul Durrant wrote: By simply re-attaching to shared rings during connect_ring() rather than assuming they are freshly allocated (i.e assuming the counters are zero) it is possible for vbd instances to be

Re: [Xen-devel] [PATCH v3 4/4] xen-blkback: support dynamic unbind/bind

2019-12-12 Thread Roger Pau Monné
On Wed, Dec 11, 2019 at 03:29:56PM +, Paul Durrant wrote: > By simply re-attaching to shared rings during connect_ring() rather than > assuming they are freshly allocated (i.e assuming the counters are zero) > it is possible for vbd instances to be unbound and re-bound from and to >

Re: [Xen-devel] [PATCH v7 2/3] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-12 Thread Roger Pau Monné
Hello, Please make sure you Cc me in blkback related patches. On Wed, Dec 11, 2019 at 06:10:15PM +, SeongJae Park wrote: > Each `blkif` has a free pages pool for the grant mapping. The size of > the pool starts from zero and be increased on demand while processing

Re: [Xen-devel] [PATCH] x86emul: correct LFS et al handling for 64-bit mode

2019-12-12 Thread Andrew Cooper
On 12/12/2019 10:11, Jan Beulich wrote: > On 11.12.2019 21:57, Andrew Cooper wrote: >> On 11/12/2019 09:28, Jan Beulich wrote: >>> AMD and friends explicitly specify that 64-bit operands aren't possible >>> for these insns. Nevertheless REX.W isn't fully ignored: It still >>> cancels a possible

  1   2   >