Re: [PATCH v11 2/9] xen: introduce generic non-atomic test_*bit()

2024-05-29 Thread Oleksii K.
On Wed, 2024-05-29 at 18:29 +0200, Oleksii K. wrote: > On Wed, 2024-05-29 at 17:22 +0200, Jan Beulich wrote: > > On 29.05.2024 16:58, Oleksii K. wrote: > > > static always_inline bool test_bit(int nr, const volatile void > > > *addr)On > > > Wed, 2024-05-

Re: [PATCH v11 2/9] xen: introduce generic non-atomic test_*bit()

2024-05-29 Thread Oleksii K.
On Wed, 2024-05-29 at 17:22 +0200, Jan Beulich wrote: > On 29.05.2024 16:58, Oleksii K. wrote: > > static always_inline bool test_bit(int nr, const volatile void > > *addr)On > > Wed, 2024-05-29 at 12:06 +0200, Jan Beulich wrote: > > > On 29.05.2024 11:59, Julien

Re: [PATCH v11 2/9] xen: introduce generic non-atomic test_*bit()

2024-05-29 Thread Oleksii K.
static always_inline bool test_bit(int nr, const volatile void *addr)On Wed, 2024-05-29 at 12:06 +0200, Jan Beulich wrote: > On 29.05.2024 11:59, Julien Grall wrote: > > Hi, > > > > On 29/05/2024 09:36, Jan Beulich wrote: > > > On 29.05.2024 09:50, Oleksii K. wro

Re: [PATCH] Partial revert of "x86/MCE: optional build of AMD/Intel MCE code"

2024-05-29 Thread Oleksii K.
ixes: 19b6e9f9149f ("x86/MCE: optional build of AMD/Intel MCE code") > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Sergiy Kibrik > CC: Stefano Stabellini > CC: Oleksii Kurochko > > We're past feature freeze and this was

Re: Updated Xen 4.19 schedule

2024-05-29 Thread Oleksii K.
On Wed, 2024-05-29 at 10:19 +0200, Jan Beulich wrote: > On 29.05.2024 10:03, Oleksii K. wrote: > > Hello everyone, > > > > I would like to announce that I have decided to update the Xen 4.19 > > schedule due to the extended feature freeze period and the upcoming &

Re: [PATCH for-4.19 0/9] x86/irq: fixes for CPU hot{,un}plug

2024-05-29 Thread Oleksii K.
ng has some > unexpected corner cases that are hard to diagnose and reason about. Despite of the fact that it can be considered as bugfixes, it seems to me that this patch series can be risky. Let's wait for maintainers opinion... ~ Oleksii > > I'm currently also doing some extra testing

Updated Xen 4.19 schedule

2024-05-29 Thread Oleksii K.
Final commits: from July 5 to July 12 Release: July 17 The release date is shifted, but it still remains in July, which seems acceptable to me. One more thing: No release ack is needed before Rc1. Please commit bug fixes at will. Have a nice day. Best regards, Oleksii

Re: [PATCH v11 2/9] xen: introduce generic non-atomic test_*bit()

2024-05-29 Thread Oleksii K.
useful? " * If two examples of this operation race, one can appear to succeed * but actually fail. You must protect multiple accesses with a lock." It seems to me that it can dropped as basically "non-atomic and can be reordered." means that. ~ Oleksii

Re: [PATCH for-4.19 v3 0/3] xen/x86: support foreign mappings for HVM/PVH

2024-05-29 Thread Oleksii K.
le altp2m at create domain domctl > >   xen/x86: remove foreign mappings from the p2m on teardown > > Here, too, I'd like to ask whether to keep this as a candidate for > 4.19, or > whether to postpone. Afaict what's still missing are Arm and tool > chain acks > on

Re: [PATCH v2 for-4.19 0.5/13] xen: Introduce CONFIG_SELF_TESTS

2024-05-29 Thread Oleksii K.
s. > > Signed-off-by: Andrew Cooper Looks good to me. We can consider it to be merged to 4.19: Release-Acked-by: Oleksii Kurochko ~ Oleksii > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > CC: Stefano Stabellini > CC: Julien Grall > CC: Volodymyr Babchuk >

Re: [PATCH for-4.19 0/3] xen: Misc MISRA changes

2024-05-29 Thread Oleksii K.
On Tue, 2024-05-21 at 18:15 +0100, Andrew Cooper wrote: > Misc fixes collected during today's call. Release-Acked-by: Oleksii Kurochko > > Andrew Cooper (3): >   xen/lzo: Implement COPY{4,8} using memcpy() >   xen/x86: Drop useless non-Kconfig CONFIG_* variables >   xen/x86

Re: [XEN PATCH v4 0/3] x86: make Intel/AMD vPMU & MCE support configurable

2024-05-29 Thread Oleksii K.
On Mon, 2024-05-27 at 17:47 +0200, Jan Beulich wrote: > Oleksii, > > On 22.05.2024 10:37, Sergiy Kibrik wrote: > > Three remaining patches to separate support of Intel & AMD CPUs in > > Xen build. > > Most of related patches from previous series had already been &

Re: [PATCH] x86/svm: Rework VMCB_ACCESSORS() to use a plain type name

2024-05-28 Thread Oleksii K.
On Tue, 2024-05-28 at 17:37 +0200, Jan Beulich wrote: > On 28.05.2024 17:32, Andrew Cooper wrote: > > This avoids having a function call in a typeof() expression. > > > > No functional change. > > > > Signed-off-by: Andrew Cooper > > Acked-by: Jan Beulich

Re: [PATCH v11 2/9] xen: introduce generic non-atomic test_*bit()

2024-05-28 Thread Oleksii K.
On Tue, 2024-05-28 at 08:20 +0200, Jan Beulich wrote: > On 24.05.2024 13:08, Oleksii Kurochko wrote: > > The following generic functions were introduced: > > * test_bit > > * generic__test_and_set_bit > > * generic__test_and_clear_bit > > * generic__test_and_ch

Re: Code freeze date for Xen 4.19 is 31.05.2024

2024-05-27 Thread Oleksii K.
On Mon, 2024-05-27 at 17:55 +0200, Jan Beulich wrote: > On 27.05.2024 17:52, Oleksii K. wrote: > > On Mon, 2024-05-27 at 17:12 +0200, Jan Beulich wrote: > > > On 27.05.2024 15:58, Oleksii K. wrote: > > > > I would like to remind you that the code fr

Re: [PATCH v2 3/3] CHANGELOG: Mention libxl blktap/tapback support

2024-05-27 Thread Oleksii K.
; capability. > + - libxl support for backendtype=tap with tapback. >   >  ### Removed >  - caml-stubdom.  It hasn't built since 2014, was pinned to Ocaml > 4.02, and has Acked-by: Oleksii Kurochko ~ Oleksii

Re: Code freeze date for Xen 4.19 is 31.05.2024

2024-05-27 Thread Oleksii K.
On Mon, 2024-05-27 at 17:12 +0200, Jan Beulich wrote: > On 27.05.2024 15:58, Oleksii K. wrote: > > I would like to remind you that the code freeze date for Xen 4.19 > > is > > May 31, 2024. > > I may be confused: With feature freeze having been last Friday aiui, > i

Re: [PATCH v4 2/4] xen/arm: Alloc XenStore page for Dom0less DomUs from hypervisor

2024-05-27 Thread Oleksii K.
ink it is a big problem if this is not merged for the code > freeze as this is technically a bug fix. Agree, this is not a problem as it is still looks to me as a bug fix. ~ Oleksii > > Cheers, > > On 24/05/2024 23:55, Stefano Stabellini wrote: > > From: Henry Wang > >

Code freeze date for Xen 4.19 is 31.05.2024

2024-05-27 Thread Oleksii K.
Hi all, I would like to remind you that the code freeze date for Xen 4.19 is May 31, 2024. I'm okay with bug fixes being committed without my release ack (just CC me), except in cases where a one of maintainers gives a strong NACK. Have a nice week! Best regards, Oleksii

Re: [PATCH v2 for-4.19 00/13] xen/bitops: Untangle ffs()/fls() infrastructure

2024-05-27 Thread Oleksii K.
I think we can consider to have this patch series in Xen 4.19 release: Release-acked-by: Oleksii Kurochko ~ Oleksii On Fri, 2024-05-24 at 21:03 +0100, Andrew Cooper wrote: > bitops.h is a mess.  It has grown organtically over many years, and > forces > unreasonable repsonsibil

[PATCH v11 6/9] xen/riscv: add minimal stuff to mm.h to build full Xen

2024-05-24 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V8-V11: - Nothing changed only rebase. --- Changes in V7: - update argument type of maddr_to_virt() function: unsigned long -> paddr_t - rename argument of PFN_ORDER(): pfn -> pg. - add Acked-by: Jan Beulich --- C

[PATCH v11 7/9] xen/riscv: add minimal amount of stubs to build full Xen

2024-05-24 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V7-V11: - Only rebase was done. --- Changes in V6: - update the commit in stubs.c around /* ... common/irq.c ... */ - add Acked-by: Jan Beulich --- Changes in V5: - drop unrelated changes - assert_failed("unimplm

[PATCH v11 2/9] xen: introduce generic non-atomic test_*bit()

2024-05-24 Thread Oleksii Kurochko
* __test_and_set_bit() will be defined using arch__test_and_set_bit() and generic__test_and_set_bit(). Signed-off-by: Oleksii Kurochko --- Reviewed-by: Jan Beulich jbeul...@suse.com? Jan gave his R-by for the previous version of the patch, but some changes were done, so I wasn't sure if I could use th

[PATCH v11 3/9] xen/bitops: implement fls{l}() in common logic

2024-05-24 Thread Oleksii Kurochko
rototype of the per-architecture fls{l}() functions was changed to return 'unsigned int' to align with the generic implementation of these functions and avoid introducing signed/unsigned mismatches. Signed-off-by: Oleksii Kurochko --- The current one patch can be merged w/o waiting of Andrew's patc

[PATCH v11 0/9] Enable build of full Xen for RISC-V

2024-05-24 Thread Oleksii Kurochko
- update some definition from spinlock.h. - code style changes. --- Oleksii Kurochko (9): xen/riscv: disable unnecessary configs xen: introduce generic non-atomic test_*bit() xen/bitops: implement fls{l}() in common logic xen/riscv: introduce bitops.h xen/riscv: add definition of __read_m

[PATCH v11 5/9] xen/riscv: add definition of __read_mostly

2024-05-24 Thread Oleksii Kurochko
The definition of __read_mostly should be removed in: https://lore.kernel.org/xen-devel/f25eb5c9-7c14-6e23-8535-2c66772b3...@suse.com/ The patch introduces it in arch-specific header to not block enabling of full Xen build for RISC-V. Signed-off-by: Oleksii Kurochko --- - [PATCH] move

[PATCH v11 9/9] xen/README: add compiler and binutils versions for RISC-V64

2024-05-24 Thread Oleksii Kurochko
to utilize Clang, it's important to note that, currently, there is no Xen RISC-V CI job in place to verify the seamless functioning of the build with Clang. Signed-off-by: Oleksii Kurochko -- Changes in V5-V11: - Nothing changed. Only rebase. --- Changes in V6: - update the message in README

[PATCH v11 1/9] xen/riscv: disable unnecessary configs

2024-05-24 Thread Oleksii Kurochko
requires asm/perf.h and asm/perfc-defn.h, so it is also disabled for now, as RISC-V hasn't introduced this headers yet. LIVEPATCH isn't ready for RISC-V too and it can be overriden by randconfig, so to avoid compilation errors for randconfig it is disabled for now. Signed-off-by: Oleksii Kurochko

[PATCH v11 8/9] xen/riscv: enable full Xen build

2024-05-24 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Reviewed-by: Jan Beulich --- At least this patch cann't be merged w/o Andrew's patch series is merged as ffs related functions are used from that patch series: https://lore.kernel.org/xen-devel/20240313172716.2325427-1-andrew.coop...@citrix.com/T/#t

[PATCH v11 4/9] xen/riscv: introduce bitops.h

2024-05-24 Thread Oleksii Kurochko
* __test_and_set_bit Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V11: - Nothing changed. Only rebase was done. --- Changes in V10: - update the error message BITS_PER_LONG -> BITOP_BITS_PER_WORD --- Changes in V9: - add Acked-by: Jan Beulich - d

Re: [PATCH v10 02/14] xen: introduce generic non-atomic test_*bit()

2024-05-24 Thread Oleksii K.
for all the > > > other arch. > > It makes sense to add this comment on top of test_bit(), but I am > > curious if it is needed to mention that for x86 arch_test_bit() "is > > atomic and may not be reordered": > > I would say no because any developper modifying common code can't > relying it. But won't then be confusion that if not generic implementation of test_bit() is chosen then test_bit() can be " atomic and cannot be reordered " ( as it is in case of x86 )? ~ Oleksii

Re: [PATCH v10 02/14] xen: introduce generic non-atomic test_*bit()

2024-05-24 Thread Oleksii K.
On Fri, 2024-05-24 at 09:35 +0200, Jan Beulich wrote: > On 24.05.2024 09:25, Oleksii K. wrote: > > On Fri, 2024-05-24 at 08:48 +0200, Jan Beulich wrote: > > > On 23.05.2024 18:40, Oleksii K. wrote: > > > > On Thu, 2024-05-23 at 15:33 +0100, Julien Grall wrote:

Re: [PATCH v10 02/14] xen: introduce generic non-atomic test_*bit()

2024-05-24 Thread Oleksii K.
On Fri, 2024-05-24 at 08:48 +0200, Jan Beulich wrote: > On 23.05.2024 18:40, Oleksii K. wrote: > > On Thu, 2024-05-23 at 15:33 +0100, Julien Grall wrote: > > > On 23/05/2024 15:11, Oleksii K. wrote: > > > > On Thu, 2024-05-23 at 14:00 +0100, Julien Grall wrote:

Re: [PATCH v10 02/14] xen: introduce generic non-atomic test_*bit()

2024-05-23 Thread Oleksii K.
On Thu, 2024-05-23 at 15:33 +0100, Julien Grall wrote: > > > On 23/05/2024 15:11, Oleksii K. wrote: > > On Thu, 2024-05-23 at 14:00 +0100, Julien Grall wrote: > > > Hi Oleksii, > > Hi Julien, > > > > > > > > On 17/05/2024 14:54, Oleksii K

Re: [PATCH v10 02/14] xen: introduce generic non-atomic test_*bit()

2024-05-23 Thread Oleksii K.
On Thu, 2024-05-23 at 14:00 +0100, Julien Grall wrote: > Hi Oleksii, Hi Julien, > > On 17/05/2024 14:54, Oleksii Kurochko wrote: > > diff --git a/xen/arch/arm/arm64/livepatch.c > > b/xen/arch/arm/arm64/livepatch.c > > index df2cebedde..4bc8ed9be5 100644 > > ---

Re: [PATCH] x86/shadow: don't leave trace record field uninitialized

2024-05-23 Thread Oleksii K.
While there also drop the "event" local variable, thus eliminating an > instance of the being phased out u32 type. > > Coverity ID: 1598430 > Fixes: 9a86ac1aa3d2 ("xentrace 5/7: Additional tracing for the shadow > code") > Signed-off-by: Jan Beulich Release-ack

Re: [for-4.19] Re: [XEN PATCH v3] arm/mem_access: add conditional build of mem_access.c

2024-05-23 Thread Oleksii K.
Hi Julien, On Wed, 2024-05-22 at 21:50 +0100, Julien Grall wrote: > Hi, > > Adding Oleksii as the release manager. > > On 22/05/2024 19:27, Tamas K Lengyel wrote: > > On Fri, May 10, 2024 at 8:32 AM Alessandro Zucchelli > > wrote: > > > > > >

Re: [PATCH v10 03/14] xen/bitops: implement fls{l}() in common logic

2024-05-22 Thread Oleksii K.
On Tue, 2024-05-21 at 13:18 +0200, Jan Beulich wrote: > On 17.05.2024 15:54, Oleksii Kurochko wrote: > > To avoid the compilation error below, it is needed to update to > > places > > in common/page_alloc.c where flsl() is used as now flsl() returns > > unsigned

Re: [PATCH for-4.19 0/3] xen: Misc MISRA changes

2024-05-22 Thread Oleksii K.
Hi Andrew, We can consider this patch series to be in Xen 4.19: Release-acked-by: Oleksii Kurochko ~ Oleksii On Tue, 2024-05-21 at 18:15 +0100, Andrew Cooper wrote: > Misc fixes collected during today's call. > > Andrew Cooper (3): >   xen/lzo: Implement COPY{4,8} using memcpy()

Re: [PATCH for-4.19] x86/msi: prevent watchdog triggering when dumping MSI state

2024-05-20 Thread Oleksii K.
dump_msi(unsigned char > key) > unsigned long flags; > const char *type = "???"; >   > +    if ( !(irq & 0x1f) ) > +    process_pending_softirqs(); > + >      if ( !irq_desc_initialized(desc) ) > continue; >   Release-acked-by: Oleksii Kurochko ~ Oleksii

[PATCH v10 13/14] xen/riscv: enable full Xen build

2024-05-17 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Reviewed-by: Jan Beulich --- Changes in V5-V10: - Nothing changed. Only rebase. --- Changes in V4: - drop stubs for irq_actor_none() and irq_actor_none() as common/irq.c is compiled now. - drop defintion of max_page in stubs.c as common/page_alloc.c

[PATCH v10 10/14] xen/riscv: add minimal stuff to mm.h to build full Xen

2024-05-17 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V8-V10: - Nothing changed only rebase. --- Changes in V7: - update argument type of maddr_to_virt() function: unsigned long -> paddr_t - rename argument of PFN_ORDER(): pfn -> pg. - add Acked-by: Jan Beulich --- C

[PATCH v10 11/14] xen/riscv: introduce vm_event_*() functions

2024-05-17 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko --- Changes in V5-V10: - Only rebase was done. --- Changes in V4: - New patch. --- xen/arch/riscv/Makefile | 1 + xen/arch/riscv/vm_event.c | 19 +++ 2 files changed, 20 insertions(+) create mode 100644 xen/arch/riscv/vm_event.c diff --git

[PATCH v10 06/14] xen/riscv: introduce atomic.h

2024-05-17 Thread Oleksii Kurochko
kernel/patch/1391516953-14541-1-git-send-email-will.dea...@arm.com/ [2] https://lore.kernel.org/linux-riscv/41e01514-74ca-84f2-f5cc-2645c444f...@nvidia.com/ Signed-off-by: Bobby Eshleman Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V10: - drop unnessary parentheses around p i

[PATCH v10 12/14] xen/riscv: add minimal amount of stubs to build full Xen

2024-05-17 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V7-V10: - Only rebase was done. --- Changes in V6: - update the commit in stubs.c around /* ... common/irq.c ... */ - add Acked-by: Jan Beulich --- Changes in V5: - drop unrelated changes - assert_failed("unimplm

[PATCH v10 05/14] xen/riscv: introduce cmpxchg.h

2024-05-17 Thread Oleksii Kurochko
".aqrl" was approved by (the author of the RVWMO spec) [2] [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/1391516953-14541-1-git-send-email-will.dea...@arm.com/ [2] https://lore.kernel.org/linux-riscv/41e01514-74ca-84f2-f5cc-2645c444f...@nvidia.com/ Signed-off-by: Oleksii K

[PATCH v10 09/14] xen/riscv: add required things to current.h

2024-05-17 Thread Oleksii Kurochko
Add minimal requied things to be able to build full Xen. Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V5-V10: - Nothing changed. Only rebase. --- Changes in V4: - BUG() was changed to BUG_ON("unimplemented"); - Change "xen/bug.h" to "xen/li

[PATCH v10 03/14] xen/bitops: implement fls{l}() in common logic

2024-05-17 Thread Oleksii Kurochko
rototype of the per-architecture fls{l}() functions was changed to return 'unsigned int' to align with the generic implementation of these functions and avoid introducing signed/unsigned mismatches. Signed-off-by: Oleksii Kurochko --- The patch is almost independent from Andrew's patch series

[PATCH v10 14/14] xen/README: add compiler and binutils versions for RISC-V64

2024-05-17 Thread Oleksii Kurochko
to utilize Clang, it's important to note that, currently, there is no Xen RISC-V CI job in place to verify the seamless functioning of the build with Clang. Signed-off-by: Oleksii Kurochko --- Changes in V5-V10: - Nothing changed. Only rebase. --- Changes in V6: - update the message in README

[PATCH v10 01/14] xen/riscv: disable unnecessary configs

2024-05-17 Thread Oleksii Kurochko
requires asm/perf.h and asm/perfc-defn.h, so it is also disabled for now, as RISC-V hasn't introduced this headers yet. LIVEPATCH isn't ready for RISC-V too and it can be overriden by randconfig, so to avoid compilation errors for randconfig it is disabled for now. Signed-off-by: Oleksii Kurochko

[PATCH v10 07/14] xen/riscv: introduce monitor.h

2024-05-17 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko --- Changes in V4-V10: - Nothing changed. Only rebase. --- Changes in V3: - new patch. --- xen/arch/riscv/include/asm/monitor.h | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 xen/arch/riscv/include/asm/monitor.h diff --git

[PATCH v10 04/14] xen/riscv: introduce bitops.h

2024-05-17 Thread Oleksii Kurochko
* __test_and_set_bit Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V10: - update the error message BITS_PER_LONG -> BITOP_BITS_PER_WORD --- Changes in V9: - add Acked-by: Jan Beulich - drop redefinition of bitop_uint_t in asm/types.h as some operation in

[PATCH v10 08/14] xen/riscv: add definition of __read_mostly

2024-05-17 Thread Oleksii Kurochko
The definition of __read_mostly should be removed in: https://lore.kernel.org/xen-devel/f25eb5c9-7c14-6e23-8535-2c66772b3...@suse.com/ The patch introduces it in arch-specific header to not block enabling of full Xen build for RISC-V. Signed-off-by: Oleksii Kurochko --- - [PATCH] move

[PATCH v10 00/14] Enable build of full Xen for RISC-V

2024-05-17 Thread Oleksii Kurochko
s used. - align arch-riscv.h with Arm's version of it. - change the Author of commit with introduction of asm/atomic.h. - update some definition from spinlock.h. - code style changes. --- Oleksii Kurochko (14): xen/riscv: disable unnecessary configs xen: introduce generic non-atomic test_*bit

[PATCH v10 02/14] xen: introduce generic non-atomic test_*bit()

2024-05-17 Thread Oleksii Kurochko
t_bit(). Signed-off-by: Oleksii Kurochko --- The context ("* Find First Set bit. Bits are labelled from 1." in xen/bitops.h ) suggests there's a dependency on an uncommitted patch. It happens becuase the current patch series is based on Andrew's patch series ( htt

Re: [PATCH v9 03/15] xen/bitops: implement fls{l}() in common logic

2024-05-17 Thread Oleksii K.
$-1,%0\n" "1:" : "=r" (r) : "rm" (x)); return r + 1; } #define arch_fls arch_fls Any specific reason why 'long' and 'int' types for r are used? ~ Oleksii

Re: [PATCH v9 02/15] xen: introduce generic non-atomic test_*bit()

2024-05-17 Thread Oleksii K.
st_bit(). Thereby according to provided by me naming for test_bit() should be defined using {generic, arch}_test_bit(). ~ Oleksii

Re: [XEN PATCH 0/4] address violations of MISRA C Rule 20.7

2024-05-16 Thread Oleksii K.
his one rather want/need delaying until after branching. > > Lets follow the same approach for 4.19. > > Well, okay. But if you don't say now until when this is okay, you'll > need to announce the "stop" very prominently later on, so no-one > misses it. For me it is okay until we don't have Hard Code Release deadline. ~ Oleksii

Re: [PATCH] Revert "evtchn: refuse EVTCHNOP_status for Xen-bound event channels"

2024-05-16 Thread Oleksii K.
On Tue, 2024-05-14 at 12:13 +0100, Julien Grall wrote: > Hi, > > (+ Oleksii as the release manager) > > Chiming into the discussion as there seems there is disagreement. > > On 14/05/2024 11:03, Jan Beulich wrote: > > On 14.05.2024 11:51, Andrew Cooper wrote: > &

Re: [PATCH for-4.19] tools/xentop: fix cpu% sort order

2024-05-16 Thread Oleksii K.
6.3 > >   Domain-0 -r   1060    1.5    1048576    1.6    > > 1048576   1.6 > >   neon --b---    827    1.1    2097216    3.1    > > 2098176   3.1 > >     cheese --b---    225    0.7    1048384    1.6    > > 1049600   1.6 > > pizza --b---    359    0.5 524352    0.8 > > 525312   0.8 > >    cassini --b---    490    0.4    3145792    4.7    > > 3146752   4.7 > >    fusilli --b---    159    0.2 524352    0.8 > > 525312   0.8 > >    bob --b---    502    0.2   16777284   25.0   > > 16778240  25.0 > >    blender --b---    121    0.2    1048640    1.6    > > 1049600   1.6 > > bread --b--- 69    0.1 524352    0.8 > > 525312   0.8 > >   chickpea --b--- 67    0.1 524352    0.8 > > 525312   0.8 > >     lentil --b--- 67    0.1 262208    0.4 > > 263168   0.4 > > > Ah, so it's the rounding, and a straight cast discards the fractional > part. > > I think your patch is fine, although it could do with a mention of > why > this goes wrong in the commit message.  I'm happy to adjust on > commit. Feel free to merge it as I am considering it as bugfix: Release-acked-by: Oleksii Kurochko ~ Oleksii > > ~Andrew

Re: [XEN PATCH v7 1/5] xen/vpci: Clear all vpci status of device

2024-05-16 Thread Oleksii K.
n linux-next [0]. > > [0] > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20240515=b272722511d5e8ae580f01830687b8a6b2717f01 Sure! Fixes should be merged. Release-acked-by: Oleksii Kurochko ~ Oleksii

Re: [PATCH for-4.19?] xen/x86: pretty print interrupt CPU affinity masks

2024-05-16 Thread Oleksii K.
s going to write exactly the same patch, but you beat me to > it. > > Acked-by: Andrew Cooper Looks good to me for having in Xen 4.19 release. Release-acked-by: Oleksii Kurochko ~ Oleksii

Re: [XEN PATCH 0/4] address violations of MISRA C Rule 20.7

2024-05-16 Thread Oleksii K.
On Wed, 2024-05-15 at 09:48 +0200, Jan Beulich wrote: > Oleksii, > > On 15.05.2024 09:34, Nicola Vetrini wrote: > > Hi all, > > > > this series aims to refactor some macros that cause violations of > > MISRA C Rule > > 20.7 ("Expressions resulting from

Feature Freeze Deadline Extended to May 24

2024-05-16 Thread Oleksii K.
regards, Oleksii

Re: [PATCH v9 02/15] xen: introduce generic non-atomic test_*bit()

2024-05-16 Thread Oleksii K.
On Thu, 2024-05-16 at 09:04 +0200, Jan Beulich wrote: > On 15.05.2024 19:03, Oleksii K. wrote: > > On Wed, 2024-05-15 at 17:41 +0200, Jan Beulich wrote: > > > On 15.05.2024 17:29, Oleksii K. wrote: > > > > On Wed, 2024-05-15 at 10:52 +0200, Jan Beulich wrote: > >

Re: [PATCH v9 02/15] xen: introduce generic non-atomic test_*bit()

2024-05-15 Thread Oleksii K.
On Wed, 2024-05-15 at 17:41 +0200, Jan Beulich wrote: > On 15.05.2024 17:29, Oleksii K. wrote: > > On Wed, 2024-05-15 at 10:52 +0200, Jan Beulich wrote: > > > On 06.05.2024 12:15, Oleksii Kurochko wrote: > > > > The following generic functions were

Re: [PATCH v9 03/15] xen/bitops: implement fls{l}() in common logic

2024-05-15 Thread Oleksii K.
On Wed, 2024-05-15 at 16:07 +0200, Jan Beulich wrote: > On 15.05.2024 15:55, Oleksii K. wrote: > > On Wed, 2024-05-15 at 11:09 +0200, Jan Beulich wrote: > > > On 06.05.2024 12:15, Oleksii Kurochko wrote: > > > > Changes in V9: > > > >  - update ret

Re: [PATCH v9 02/15] xen: introduce generic non-atomic test_*bit()

2024-05-15 Thread Oleksii K.
On Wed, 2024-05-15 at 10:52 +0200, Jan Beulich wrote: > On 06.05.2024 12:15, Oleksii Kurochko wrote: > > The following generic functions were introduced: > > * test_bit > > * generic__test_and_set_bit > > * generic__test_and_clear_bit > > * generic__test_and_ch

Re: [PATCH v9 07/15] xen/riscv: introduce atomic.h

2024-05-15 Thread Oleksii K.
On Wed, 2024-05-15 at 11:49 +0200, Jan Beulich wrote: > On 06.05.2024 12:15, Oleksii Kurochko wrote: > > Changes in V9: > >  - update the defintion of write_atomic macros: > >    drop the return value as this macros isn't expeceted to return > > something > >    dr

Re: [PATCH v9 03/15] xen/bitops: implement fls{l}() in common logic

2024-05-15 Thread Oleksii K.
On Wed, 2024-05-15 at 11:09 +0200, Jan Beulich wrote: > On 06.05.2024 12:15, Oleksii Kurochko wrote: > > Changes in V9: > >  - update return type of fls and flsl() to unsigned int to be > > aligned with other > >    bit ops. > > But this then needs carrying thr

Re: Proposal to Extend Feature Freeze Deadline

2024-05-15 Thread Oleksii K.
Hi Kelly, On Wed, 2024-05-15 at 14:27 +0100, Kelly Choi wrote: > Hi Oleksii, > > If there are no objections by tomorrow, let's assume by lazy > consensus that we will extend the timeline by a week.  > If anyone objects to this, please reply to this email. I will send a separate

Proposal to Extend Feature Freeze Deadline

2024-05-14 Thread Oleksii K.
Hello everyone, We're observing fewer merged patches/series across several architectures for the current 4.19 release in comparison to previous release. For example: 1. For Arm, significant features like Cache Coloring and PCI Passthrough won't be fully merged. Thus, it would be beneficial to

Re: [PATCH for-4.19 v2] tools/xen-cpuid: switch to use cpu-policy defined names

2024-05-14 Thread Oleksii K.
ound. > > > > > > Note that leaf names need to be kept, as the current auto- > > > generated data > > > doesn't contain the leaf names. > > > > > > Signed-off-by: Roger Pau Monné > > > > Reviewed-by: Jan Beulich > > Oleksii, now that Jan has provided a Reviewed-by, can you provide a > release-ack for this to go in? Based that it is reviewed, I will be happy to have this in 4.19: Release-acked-by: Oleksii Kurochko ~ Oleksii

Re: [PATCH for-4.19] x86/mtrr: avoid system wide rendezvous when setting AP MTRRs

2024-05-14 Thread Oleksii K.
's also a good performance improvement when > performing > cpu-online. > > Hopefully runtime changes to MTRR will affect a single MSR at a time, > lowering > the chance of the watchdog triggering due to the system-wide > resetting of the > range. Considering it as a bugfi

Re: [PATCH for-4.19] libxl: fix population of the online vCPU bitmap for PVH

2024-05-14 Thread Oleksii K.
ease it's safer to just adjust the PVH > > path. > > > > Also note the checksum is not provided when hvm_info_table is built > > for PVH. > > This is fine so far because such checksum is only consumed by > > hvmloader and not > > libacpi itself. > > &g

Re: [RFC PATCH v2 0/5] Add bridge VLAN support

2024-05-14 Thread Oleksii K.
>  tools/examples/linux-bridge-vlan/br0.network  |   8 ++ > >  .../examples/linux-bridge-vlan/enp0s0.network |  16 +++ > >  tools/hotplug/Linux/xen-network-common.sh | 111 > > ++ > >  tools/libs/light/libxl_nic.c      |  10 ++ > &

Feature freeze date for Xen 4.19 is 17.05.2024

2024-05-10 Thread Oleksii K.
Hi all, I would like to remind that the feature freeze date for Xen 4.19 is May 17, 2024. If you want your features to be included for the release, please make sure they are committed by May 17, 2024. Have a nice day! Best regards, Oleksii

[PATCH v9 14/15] xen/riscv: enable full Xen build

2024-05-06 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Reviewed-by: Jan Beulich --- Changes in V5-V9: - Nothing changed. Only rebase. --- Changes in V4: - drop stubs for irq_actor_none() and irq_actor_none() as common/irq.c is compiled now. - drop defintion of max_page in stubs.c as common/page_alloc.c is compiled

[PATCH v9 13/15] xen/riscv: add minimal amount of stubs to build full Xen

2024-05-06 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V7-V9: - Only rebase was done. --- Changes in V6: - update the commit in stubs.c around /* ... common/irq.c ... */ - add Acked-by: Jan Beulich --- Changes in V5: - drop unrelated changes - assert_failed("unimplm

[PATCH v9 09/15] xen/riscv: add definition of __read_mostly

2024-05-06 Thread Oleksii Kurochko
The definition of __read_mostly should be removed in: https://lore.kernel.org/xen-devel/f25eb5c9-7c14-6e23-8535-2c66772b3...@suse.com/ The patch introduces it in arch-specific header to not block enabling of full Xen build for RISC-V. Signed-off-by: Oleksii Kurochko --- - [PATCH] move

[PATCH v9 11/15] xen/riscv: add minimal stuff to mm.h to build full Xen

2024-05-06 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V8-V9: - Nothing changed only rebase. --- Changes in V7: - update argument type of maddr_to_virt() function: unsigned long -> paddr_t - rename argument of PFN_ORDER(): pfn -> pg. - add Acked-by: Jan Beulich --- C

[PATCH v9 03/15] xen/bitops: implement fls{l}() in common logic

2024-05-06 Thread Oleksii Kurochko
gned-off-by: Oleksii Kurochko --- The patch is almost independent from Andrew's patch series ( https://lore.kernel.org/xen-devel/20240313172716.2325427-1-andrew.coop...@citrix.com/T/#t) except test_fls() function which IMO can be merged as a separate patch after Andrew's patch will be ful

[PATCH v9 12/15] xen/riscv: introduce vm_event_*() functions

2024-05-06 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko --- Changes in V5-V9: - Only rebase was done. --- Changes in V4: - New patch. --- xen/arch/riscv/Makefile | 1 + xen/arch/riscv/vm_event.c | 19 +++ 2 files changed, 20 insertions(+) create mode 100644 xen/arch/riscv/vm_event.c diff --git

[PATCH v9 07/15] xen/riscv: introduce atomic.h

2024-05-06 Thread Oleksii Kurochko
kernel/patch/1391516953-14541-1-git-send-email-will.dea...@arm.com/ [2] https://lore.kernel.org/linux-riscv/41e01514-74ca-84f2-f5cc-2645c444f...@nvidia.com/ Signed-off-by: Bobby Eshleman Signed-off-by: Oleksii Kurochko --- Changes in V9: - update the defintion of write_atomic macros: drop th

[PATCH v9 15/15] xen/README: add compiler and binutils versions for RISC-V64

2024-05-06 Thread Oleksii Kurochko
to utilize Clang, it's important to note that, currently, there is no Xen RISC-V CI job in place to verify the seamless functioning of the build with Clang. Signed-off-by: Oleksii Kurochko --- Changes in V5-V9: - Nothing changed. Only rebase. --- Changes in V6: - update the message in README

[PATCH v9 01/15] xen/riscv: disable unnecessary configs

2024-05-06 Thread Oleksii Kurochko
requires asm/perf.h and asm/perfc-defn.h, so it is also disabled for now, as RISC-V hasn't introduced this headers yet. LIVEPATCH isn't ready for RISC-V too and it can be overriden by randconfig, so to avoid compilation errors for randconfig it is disabled for now. Signed-off-by: Oleksii Kurochko

[PATCH v9 05/15] xen/riscv: introduce bitops.h

2024-05-06 Thread Oleksii Kurochko
* __test_and_set_bit Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V9: - add Acked-by: Jan Beulich - drop redefinition of bitop_uint_t in asm/types.h as some operation in Xen common code expects to work with 32-bit quantities. - s/BITS_PER_LONG

[PATCH v9 08/15] xen/riscv: introduce monitor.h

2024-05-06 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko --- Changes in V4-V9: - Nothing changed. Only rebase. --- Changes in V3: - new patch. --- xen/arch/riscv/include/asm/monitor.h | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 xen/arch/riscv/include/asm/monitor.h diff --git

[PATCH v9 10/15] xen/riscv: add required things to current.h

2024-05-06 Thread Oleksii Kurochko
Add minimal requied things to be able to build full Xen. Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V5-V9: - Nothing changed. Only rebase. --- Changes in V4: - BUG() was changed to BUG_ON("unimplemented"); - Change "xen/bug.h" to "xen/li

[PATCH v9 06/15] xen/riscv: introduce cmpxchg.h

2024-05-06 Thread Oleksii Kurochko
".aqrl" was approved by (the author of the RVWMO spec) [2] [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/1391516953-14541-1-git-send-email-will.dea...@arm.com/ [2] https://lore.kernel.org/linux-riscv/41e01514-74ca-84f2-f5cc-2645c444f...@nvidia.com/ Signed-off-by: Oleksii Kurochko

[PATCH v9 04/15] xen/bitops: put __ffs() into linux compatible header

2024-05-06 Thread Oleksii Kurochko
in this file, but to keep smmu-v3.c looks close to linux it was deciced just to define __ffs() in xen/linux-compat.h and include it in smmu-v3.c Signed-off-by: Oleksii Kurochko Acked-by: Shawn Anastasio Reviewed-by: Jan Beulich --- Changes in V9: - update the defintion of __ffs in xen/linux-compat.h

[PATCH v9 00/15] Enable build of full Xen for RISC-V

2024-05-06 Thread Oleksii Kurochko
ases were changed to xen/bug.h as mostly functionilty of bug.h is used. - align arch-riscv.h with Arm's version of it. - change the Author of commit with introduction of asm/atomic.h. - update some definition from spinlock.h. - code style changes. --- Oleksii Kurochko (15): xen/risc

[PATCH v9 02/15] xen: introduce generic non-atomic test_*bit()

2024-05-06 Thread Oleksii Kurochko
) ) __bitop_bad_size(); It was necessary to make bitop bad size check generic too, so arch_check_bitop_size() was introduced. Signed-off-by: Oleksii Kurochko --- The context ("* Find First Set bit. Bits are labelled from 1." in xen/bitops.h ) suggests there's a dependency on an u

Re: Xen 4.19 release status tracking list [ May ]

2024-05-06 Thread Oleksii
On Mon, 2024-05-06 at 09:11 +0200, Jan Beulich wrote: > On 03.05.2024 18:54, Oleksii wrote: > > *** x86 ***: > >   * [PATCH 0/4] iommu/x86: fixes/improvements for unity range > > checks [ > > https://lore.kernel.org/xen-devel/20240201170159.66330-1-roger@citrix.c

Re: [PATCH v8 02/17] xen: introduce generic non-atomic test_*bit()

2024-05-06 Thread Oleksii
On Mon, 2024-05-06 at 08:33 +0200, Jan Beulich wrote: > On 03.05.2024 19:15, Oleksii wrote: > > On Thu, 2024-04-25 at 17:35 +0200, Jan Beulich wrote: > > > >   #include > > > >   > > > > +#ifndef arch_check_bitop_size > > > > +#define ar

Re: [PATCH v8 02/17] xen: introduce generic non-atomic test_*bit()

2024-05-03 Thread Oleksii
linux-gnu-ld: ./.xen-syms.0: hidden symbol `__bitop_bad_size' isn't defined riscv64-linux-gnu-ld: final link failed: bad value make[2]: *** [arch/riscv/Makefile:15: xen-syms] Error 1 ~ Oleksii

Xen 4.19 release status tracking list [ May ]

2024-05-03 Thread Oleksii
ovide a description and use cases of the feature you're working on. Have a nice week! Best regards, Oleksii

Re: [PATCH] xen/Kconfig: Drop the final remnants of ---help---

2024-05-03 Thread Oleksii
unlap > CC: Jan Beulich > CC: Stefano Stabellini > CC: Julien Grall > CC: Oleksii Kurochko > > For 4.19.  This cleans up a legacy we've been wanting to get rid of > for a > while, and will be least disruptive on people if it gets in ahead of > most > people

Re: [PATCH v1] xen/riscv: improve check-extension() macro

2024-05-02 Thread Oleksii
On Mon, 2024-04-29 at 15:30 +0200, Jan Beulich wrote: > On 26.04.2024 17:23, Oleksii Kurochko wrote: > > Now, the check-extension() macro has 1 argument instead of 2. > > This change helps to reduce redundancy around usage of extensions > > name (in the case of the zbb extensi

Re: [PATCH for-4.19] tools/xen-cpuid: switch to use cpu-policy defined names

2024-05-02 Thread Oleksii
leanup and reduces the burden of adding new > > > feature bits into > > > the policy. > > > > I agree, but it's Oleksii's call (now Cc-ed). This cleanup looks good to me and IMO we can consider it for 4.19 release. ~ Oleksii > > > > > --- a/tools

  1   2   3   4   5   6   7   8   9   10   >