On Thu, Aug 8, 2019 at 9:45 AM Lars Kurth wrote:
> On the one hand, the testing relates to patches
> submission (mean patches should be tested before submission anyway),
> but on the other hand, testing details are not about the patches
> submission process. In any case, we do
On Wed, Aug 7, 2019 at 9:04 PM Lars Kurth wrote:
>
>
> On 05/08/2019, 18:49, "Lars Kurth" wrote:
>
> On 02/08/2019, 14:36, "Lars Kurth" wrote:
>
> On 02/08/2019, 14:03, "Julien Grall" wrote:
>
>
>
> On 02/08/2019 14:02, Julien Grall wrote:
> > Hi Jan,
>
Hi Julien,
On Wed, Aug 7, 2019 at 4:05 PM Julien Grall wrote:
>
>
> Hi,
> On 07/08/2019 11:10, Viktor Mitin wrote:
> > Functions make_timer_node and make_timer_domU_node are quite similar.
> > So it is better to consolidate them to avoid discrepancy.
> > The main di
and make_timer_domU_node into one function:
Viktor Mitin (2):
xen/arm: extend fdt_property_interrupts to support DomU
xen/arm: consolidate make_timer_node and make_timer_domU_node
xen/arch/arm/domain_build.c | 118 ++--
1 file changed, 44 insertions(+), 74 deletions
' property into hwdom device tree,
instead set either arm,armv7-timer or arm,armv8-timer,
depending on the platform type.
Keep the hw version for the clock as it is relevant for the both cases.
Suggested-by: Julien Grall
Signed-off-by: Viktor Mitin
---
v4 updates:
updated "Keep the domU ve
Grall
Signed-off-by: Viktor Mitin
Reviewed-by: Volodymyr Babchuk
---
v7: removed extra space after sizeof in fdt_property_interrupts()
v8: updated commit message
---
xen/arch/arm/domain_build.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/xen/arch/arm
and make_timer_domU_node into one function:
Viktor Mitin (2):
xen/arm: extend fdt_property_interrupts to support DomU
xen/arm: consolidate make_timer_node and make_timer_domU_node
xen/arch/arm/domain_build.c | 118 ++--
1 file changed, 44 insertions(+), 74 deletions
ginal goal is to consolidate make_timer functions.
Suggested-by: Julien Grall
Signed-off-by: Viktor Mitin
Reviewed-by: Volodymyr Babchuk
---
v7: removed extra space after sizeof in fdt_property_interrupts()
---
xen/arch/arm/domain_build.c | 20
1 file changed, 12 insertions(
' property into hwdom device tree,
instead set either arm,armv7-timer or arm,armv8-timer,
depending on the platform type.
Keep the hw version for the clock as it is relevant for the both cases.
Suggested-by: Julien Grall
Signed-off-by: Viktor Mitin
---
v4 updates:
updated "Keep the domU ve
ginal goal is to consolidate make_timer functions.
Suggested-by: Julien Grall
Signed-off-by: Viktor Mitin
---
xen/arch/arm/domain_build.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 4c840
' property into hwdom device tree,
instead set either arm,armv7-timer or arm,armv8-timer,
depending on the platform type.
Keep the hw version for the clock as it is relevant for the both cases.
Suggested-by: Julien Grall
Signed-off-by: Viktor Mitin
---
v4 updates:
updated "Keep the domU ve
and make_timer_domU_node into one function:
make_timer_node(const struct kernel_info *kinfo)
Viktor Mitin (2):
xen/arm: extend fdt_property_interrupts to support DomU
xen/arm: consolidate make_timer_node and make_timer_domU_node
xen/arch/arm/domain_build.c | 122 ++--
1
On Fri, Aug 2, 2019 at 12:23 PM Juergen Gross wrote:
> >> A snipplet from commit 57f8b13c724023c78fa15a80452d1de3e51a1418:
> >>
> >> @@ -4096,14 +4097,12 @@ retry_transaction:
> >>goto out;
> >>
> >>if (target == NULL) {
> >> -libxl__xs_printf(gc, t, target_path,
On Fri, Aug 2, 2019 at 12:41 PM Julien Grall wrote:
> >
> > Well, I address each of the comments or write about it explicitly in
> > other cases.
> > In this particular case, I'd added '-1', but later did not merge it
> > due to mistake.
> > So it supposed to be the next:
> > +unsigned int
On Thu, Aug 1, 2019 at 3:50 PM Juergen Gross wrote:
>
> On 01.08.19 14:16, Viktor Mitin wrote:
> > On Thu, Aug 1, 2019 at 10:40 AM Jan Beulich wrote:
> >>
> >> On 31.07.2019 18:20, Viktor Mitin wrote:
> >>> How all those projects live without this issu
On Thu, Aug 1, 2019 at 5:50 PM Volodymyr Babchuk
wrote:
> >> In this case we also can declare and use intrs[] in the same way.
> >
> > There is no guarantee the index in irq will match intrs[...]. So you
> > need to keep them hardcoded in the latter case.
> Oh, right.
I don't like the idea of
On Thu, Aug 1, 2019 at 4:58 PM Julien Grall wrote:
>
>
>
> On 01/08/2019 14:57, Julien Grall wrote:
> >>> +unsigned int irq[MAX_TIMER_PPI];
> >> As I said in the previous version, you are wasting stack space
> >> there. Also, this is misleading. When I see array of 4 items, I expect
> >>
Hi Tamas,
On Thu, Aug 1, 2019 at 6:58 PM Tamas K Lengyel
wrote:
>
> On Thu, Aug 1, 2019 at 4:06 AM Viktor Mitin wrote:
> >
> > On Wed, Jul 31, 2019 at 8:05 PM Viktor Mitin
> > wrote:
> > >
> > > On Wed, Jul 31, 2019 at 7:27 PM Lars Kurth
&g
> > It is not explicitly written in the wiki page. But it is implied in a few
> > places such as in the section "Providing a git branch", "Using git
> > send-email alone".
>
> You are right. That should be made explicit. I think you are the only person
> in years that sent a series without
Hi Julien and Volodymyr,
On Wed, Jul 31, 2019 at 3:52 PM Julien Grall wrote:
>
> Hi,
>
> >> It is recommended (and probably required, but I can't find exact place
> >> in the rules) to include cover letter if you are sending more that one
> >> patch in series. This will ease up review process,
On Thu, Aug 1, 2019 at 10:40 AM Jan Beulich wrote:
>
> On 31.07.2019 18:20, Viktor Mitin wrote:
> > How all those projects live without this issue?
>
> Perhaps they don't care? I do.
>
> > What is the reason not to fix 'diff -p'? Is it not possible at all?
>
> I
kernel_info *kinfo)
Suggested-by: Julien Grall
Signed-off-by: Viktor Mitin
---
v4 updates:
updated "Keep the domU version for the compatible as it is simpler"
v5 updates:
- changed 'kept' to 'keep', etc.
- removed empty line
- updated indentation of parameters in funct
and make_timer_domU_node into one function:
make_timer_node(const struct kernel_info *kinfo)
Viktor Mitin (2):
xen/arm: extend fdt_property_interrupts to support DomU
xen/arm: consolidate make_timer_node and make_timer_domU_node
xen/arch/arm/domain_build.c | 128 +++-
1
which uses kinfo:
make_timer_node(const struct kernel_info *kinfo)
This is a preparatory for the next patch which consolidates
make_timer_node and make_timer_domU_node".
Original goal is to consolidate make_timer functions.
Suggested-by: Julien Grall
Signed-off-by: Viktor Mitin
---
xen/arc
On Wed, Jul 31, 2019 at 8:05 PM Viktor Mitin wrote:
>
> On Wed, Jul 31, 2019 at 7:27 PM Lars Kurth wrote:
>
> > Viktor: thank you for spending time on this
> >
> > I added an item to community call tomorrow and CC'ed you in the invite. So
> > I think what
On Wed, Jul 31, 2019 at 7:27 PM Lars Kurth wrote:
> Viktor: thank you for spending time on this
>
> I added an item to community call tomorrow and CC'ed you in the invite. So I
> think what we need to do is figure out a way on how to make the coding
> standard enforceable by a coding standard
Hi All,
On Wed, Jul 31, 2019 at 7:45 PM Andrew Cooper wrote:
>
> On 31/07/2019 17:24, Volodymyr Babchuk wrote:
> > There are coding style rules that are widely accepted by community,
> > but newer were formalized in the document. Notable example is the
> > question on how function arguments and
Hi Jan,
On Mon, Jul 29, 2019 at 4:21 PM Jan Beulich wrote:
> - Line 67: I believe Jan request the space before label
> >>> Seems agreed not to add the spaces before label. Right?
> >>
> >> Certainly not, afaia. I will object to any written down rule disallowing
> >> leading blank(s)
On Wed, Jul 31, 2019 at 3:33 PM Volodymyr Babchuk
wrote:
>
>
>
> Viktor Mitin writes:
>
> > Merged make_timer_node and make_timer_domU_node into one function
> > make_timer_node.
> It is widely accepted to write commit messages in imperative mood,
> e.g. "
view process, because reviewer will
> know what to expect in the series.
There is no such requirement, only recommendation.
I did not put it since this is simple short patch series and both
patches in this series have been discussed previously, so it is known
what it is about.
> Viktor
On Wed, Jul 31, 2019 at 2:25 PM Julien Grall wrote:
>
>
>
> On 31/07/2019 12:16, Viktor Mitin wrote:
> > On Mon, Jul 29, 2019 at 3:35 PM Julien Grall wrote:
> >> On 7/29/19 1:21 PM, Viktor Mitin wrote:
> >>> On Mon, Jul 29, 2019 at 1:49 PM Julien Grall wr
Hi Julien,
On Mon, Jul 29, 2019 at 3:35 PM Julien Grall wrote:
>
> Hi Viktor,
>
> On 7/29/19 1:21 PM, Viktor Mitin wrote:
> > On Mon, Jul 29, 2019 at 1:49 PM Julien Grall wrote:
> >> On 7/29/19 10:13 AM, Viktor Mitin wrote:
> >>> On Fri, Jul
ginal goal is to merge make_timer_node and
make_timer_domU_node functions. See discussion in e-mail, the Message-ID is:
<20190620103805.927-1-viktor.mitin...@gmail.com>
Note: there is no functional changes introduced by this patch.
Suggested-by: Julien Grall
Signed-off-by: Viktor Mitin
-
Merged make_timer_node and make_timer_domU_node into one function
make_timer_node.
Kept the domU version for the compatible as it is simpler.
Kept the hw version for the clock as it is relevant for the both cases.
Suggested-by: Julien Grall
Signed-off-by: Viktor Mitin
---
v4 updates
as it is relevant for the both cases.
It has been merged into one function - make_timer_node.
Suggested-by: Julien Grall
Signed-off-by: Viktor Mitin
---
Tested dom0 and dom0less domU boot and
that clock frequency property set in both device trees.
xen/arch/arm/domain_build.c | 97
ginal goal is to merge make_timer_node and
make_timer_domU_node functions. See discussion in e-mail, the Message-ID is:
<20190620103805.927-1-viktor.mitin...@gmail.com>
Note: there is no functional changes introduced by this patch.
Suggested-by: Julien Grall
Signed-off-by: Viktor Mitin
-
On Wed, Jul 31, 2019 at 11:40 AM Julien Grall wrote:
>
> Hi,
>
Hi Julien,
> On 7/31/19 9:10 AM, Viktor Mitin wrote:
> > - Changed unprintable characters with %s/\%xA0/ /g
> >So all the spaces are 0x20 now.
> >
> > - Added address-cells and
- Changed unprintable characters with %s/\%xA0/ /g
So all the spaces are 0x20 now.
- Added address-cells and size-cells to configuration example.
This resolves the dom0less boot issue in case of arm64.
- Added some notes about xl tools usage in case of dom0less.
Signed-off-by: Viktor Mitin
Hi Julien,
On Mon, Jul 29, 2019 at 1:49 PM Julien Grall wrote:
>
> Hi,
>
> On 7/29/19 10:13 AM, Viktor Mitin wrote:
> > On Fri, Jul 26, 2019 at 3:50 PM Julien Grall wrote:
> >>
> >> I have already done some testings a couple of weeks ago with the patch
>
Hi Julien,
On Fri, Jul 26, 2019 at 3:50 PM Julien Grall wrote:
>
> I have already done some testings a couple of weeks ago with the patch [1]. I
> have sent some comments regarding the change made by the tools that require
> some
> attention. It would be good if someone go through them and try
On Fri, Jul 26, 2019 at 6:54 PM Julien Grall wrote:
>
>
>
> On 26/07/2019 16:48, Viktor Mitin wrote:
> > Hi All,
> >
> > On Thu, Jul 18, 2019 at 5:45 PM Tamas K Lengyel wrote:
> >
> >> Checking the comment styles are not included in the automation.
Hi All,
On Thu, Jul 18, 2019 at 5:45 PM Tamas K Lengyel wrote:
> Checking the comment styles are not included in the automation.
The same about clang-format. Checking the comment styles is not supported.
It seems this is not code format checker task to parse and modify the
code comments...
On Fri, Jul 19, 2019 at 11:37 AM Julien Grall wrote:
>
> Hi Tamas,
>
> On 18/07/2019 18:22, Tamas K Lengyel wrote:
> >> - Line 139: The { are commonly on the same line as struct or
> >> definition.
> >
> > According to CODING_STYLE that's not how it should be.
>
> I guess you refer to the
Please be aware that such for_each_* cases are covered by clang-format.
Thanks
On Thu, Jul 18, 2019 at 8:50 PM Tamas K Lengyel wrote:
>
> >- Line 1025: The tools needs to be able to deal for_each_vcpu(...) & co.
>
> These can be made OK by adding braces. Other than that the only way I
>
Hi All,
On Thu, Jul 18, 2019 at 8:24 PM Tamas K Lengyel wrote:
>
> >- Line 139: The { are commonly on the same line as struct or definition.
>
> According to CODING_STYLE that's not how it should be.
All such cases should be explicitly stated in the CODING_STYLE document.
Thanks
> Tamas
>
Hi Julien, All,
On Thu, Jul 18, 2019 at 6:44 PM Julien Grall wrote:
>
> Hi Tamas,
>
> On 7/18/19 4:14 PM, Tamas K Lengyel wrote:
> > On Thu, Jul 18, 2019 at 9:02 AM Julien Grall wrote:
> >>
> >> Hi Tamas,
> >>
> >> Adding Lars, Artem and Iurii. Iurii has been working on a version for
> >>
Hi All,
On Thu, Jul 18, 2019 at 6:16 PM Jan Beulich wrote:
>
> On 18.07.2019 16:43, Tamas K Lengyel wrote:
> > --- a/CODING_STYLE
> > +++ b/CODING_STYLE
> > @@ -60,8 +60,8 @@ Bracing
> > ---
> >
> > Braces ('{' and '}') are usually placed on a line of their own, except
> > -for the
mat binary can be used as-is to check given file or many files.
> > For example, the next command formats all xen *.c files with it.
> > find ~/w/xen/xen -name '*.c' -print0 | xargs -0 -n 1 -P 12
> > ~/w/llvm-project/bin/clang-format -i -style=xen
> >
> > See output example in:
&
Hi Jan, All,
On Thu, Jul 18, 2019 at 4:38 PM Jan Beulich wrote:
> >> But you're actively breaking Xen style here (and below).
> >
> > I don't see any mention of style restrictions regarding this in
> > CODING_STYLE. If there is, I would prefer changing that so we can
> > automate style checks
Hi Julien,
> I have already done some testings a couple of weeks ago with the patch [1]. I
> have sent some comments regarding the change made by the tools that require
> some
> attention. It would be good if someone go through them and try to address one
> by
> one. For convenience I have
clang-format -i -style=xen
See output example in:
https://raw.githubusercontent.com/viktor-mitin/xen-clang-format-example/master/0001-clang-format-checkpatch-output-example.patch
- another use-case is to run it with clang-format diff checker,
For example, the next command line checks the latest commit
Hi Volodymyr,
On Fri, Jul 26, 2019 at 2:57 PM Volodymyr Babchuk
wrote:
>
>
> Hello Vikor,
>
> Viktor Mitin writes:
>
> > xen/arm: extend fdt_property_interrupts to deal with other
> > domain than the hwdom
>
> It is unclear what problem you are facing. Could y
Clang-format/blob/devel/clang-format.patch
[2]
https://raw.githubusercontent.com/viktor-mitin/xen-clang-format-example/master/0001-clang-format-checkpatch-output-example.patch
[3] https://developer.blender.org/T53211
[4]
http://clang-developers.42468.n3.nabble.com/clang-format-add-around-statement-
xen/arm: extend fdt_property_interrupts to deal with other
domain than the hwdom
Tested with aarch64 qemu dom0 and dom0less boot.
Suggested-by: Julien Grall
Signed-off-by: Viktor Mitin
---
See discussion in mail:
[PATCH] xen/arm: merge make_timer_node and make_timer_domU_node
xen/arch/arm
Hi Julien,
I've checked latest Xen staging, the patch has not been integrated yet.
Please integrate the patch if no objections.
Thanks
On Mon, Jul 8, 2019 at 3:12 PM Julien Grall wrote:
>
> Hi Viktor,
>
> On 6/18/19 9:58 AM, Viktor Mitin wrote:
> > Some of the function gen
Hi Julien,
On Mon, Jul 15, 2019 at 9:01 PM Julien Grall wrote:
>
> Hi Viktor,
>
> On 20/06/2019 11:38, Viktor Mitin wrote:
> > Functions make_timer_node and make_timer_domU_node are quite similar.
> > The only difference between Dom0 and DomU timer DT node
> > is t
property in configuration example.
This matches the binding docs/misc/arm/device-tree/booting.txt
which requires a 64-bit value.
Signed-off-by: Viktor Mitin
---
v3:
- Added extra 0x0 to memory property in configuration example.
This matches the binding docs/misc/arm/device-tree/booting.txt
Update ARM code coverage warning about testing gcov on arm
Signed-off-by: Viktor Mitin
---
v2:
updated only part of the warning related to testing on ARM
---
docs/hypervisor-guide/code-coverage.rst | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/docs/hypervisor
Hi Julien,
On Tue, Jul 9, 2019 at 3:29 PM Julien Grall wrote:
>
> Hi Viktor,
>
> On 7/9/19 8:49 AM, Viktor Mitin wrote:
> > While checking xen dom0less documentation it has been found
> > that domU memory property requires extra 0x0 in case of arm64.
>
> And this
Hi,
On Tue, Jul 9, 2019 at 3:15 PM Julien Grall wrote:
>
> Hi,
>
> On 7/9/19 8:23 AM, Viktor Mitin wrote:
> > On Mon, Jul 8, 2019 at 6:45 PM Julien Grall wrote:
> >>
> >> Hello,
> > Hello Julien,
> >
> >>
> >> On 7/8/19 1:35 PM,
On Tue, Jul 9, 2019 at 3:11 PM Julien Grall wrote:
>
> Hi,
>
Hi Julien,
> On 7/9/19 11:56 AM, Viktor Mitin wrote:
> > Remove obsolete warning about testing gcov on arm.
> > gcov has been fixed and tested with arm hw previously
> >
> > See commit 6ac66c9
>
Remove obsolete warning about testing gcov on arm.
gcov has been fixed and tested with arm hw previously
See commit 6ac66c9
Signed-off-by: Viktor Mitin
---
docs/hypervisor-guide/code-coverage.rst | 7 ---
1 file changed, 7 deletions(-)
diff --git a/docs/hypervisor-guide/code-coverage.rst
- Changed unprintable characters with %s/\%xA0/ /g
So all the spaces are 0x20 now.
- Added address-cells and size-cells to configuration example.
This resolves the dom0less boot issue in case of arm64.
- Added some notes about xl tools usage in case of dom0less.
Signed-off-by: Viktor Mitin
property with this patch.
Signed-off-by: Viktor Mitin
---
xen/arch/arm/domain_build.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index d9836779d1..2c1a8c243e 100644
--- a/xen/arch/arm/domain_build.c
+++ b
On Mon, Jul 8, 2019 at 6:45 PM Julien Grall wrote:
>
> Hello,
Hello Julien,
>
> On 7/8/19 1:35 PM, Viktor Mitin wrote:
> > Updated configuration example according to arm64
> > and added more cases about known xl limitations.
>
> dom0less is not an arm64 specific f
Updated configuration example according to arm64
and added more cases about known xl limitations.
Signed-off-by: Viktor Mitin
---
docs/features/dom0less.pandoc | 29 +
1 file changed, 21 insertions(+), 8 deletions(-)
diff --git a/docs/features/dom0less.pandoc b/docs
Hi All,
Please be aware that I can confirm the issue.
Current dom0less domU code needs to be fixed.
The issue has been reproduced with several kernel images 4.14.75.
Linux kernel 4.15 image works well without this fix.
Kernel images 4.14.75 and 4.15 works fine with this fix.
Thanks
On Sun, Jul
ime.
Thanks,
Viktor Mitin
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Hi Julien,
Thank you for information provided.
Per the binding, domU1 node should contain the properties
#address-cells and #size-cells.
Adding xen-devel to CC.
Thanks
On Wed, Jun 26, 2019 at 6:42 PM Julien Grall wrote:
>
>
>
> On 26/06/2019 16:21, Viktor Mitin wrote:
> &
-by: Julien Grall
Signed-off-by: Viktor Mitin
---
xen/arch/arm/domain_build.c | 66 -
1 file changed, 21 insertions(+), 45 deletions(-)
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 7fb828cae2..610dd3e8e7 100644
--- a/xen/arch
Some of the function generating nodes (e.g make_timer_node)
take in a dt_device_node parameter, but never used it.
It is actually misused when creating DT for DomU.
So it is the best to remove the parameter.
Suggested-by: Julien Grall
Signed-off-by: Viktor Mitin
---
xen/arch/arm/domain_build.c
> > Thank you for detailed description provided.
> > Will take into consideration all the notes.
>
> Does it mean you are happy with the commit message I suggested?
Yes, I'm happy with the commit message you suggested.
Please let me know if I should resend the updated patch.
Thanks
Hi Julien,
Added by mistake, sorry about that.
Thanks
On Mon, May 20, 2019 at 12:49 PM Julien Grall wrote:
>
> Hi Viktor,
>
> Is there any specific reason I ended up to be CCed in a middle of an x86
> thread?
>
> Cheers,
>
> On 20/05/2019 10:17, Viktor Mitin wr
> > For this reason it is better to avoid implementation-defined code.
> Well, ideally we'd like to get away without using implementation
> defined behavior. But I'm afraid we're quite far from that, and
> we'd not always be willing to accept the worse source and/or
>
On Mon, May 20, 2019 at 12:22 PM Andrew Cooper
wrote:
>
> On 20/05/2019 10:17, Viktor Mitin wrote:
> >>> Mean that result of "(int64_t)vaddr >> 63" can be 0 or 1.
> >>> So the next code may not work properly in case of another
> >>> 'impl
> > Mean that result of "(int64_t)vaddr >> 63" can be 0 or 1.
> > So the next code may not work properly in case of another 'implementations'.
> > With another compiler (i.e. clang, etc) this code may introduce bugs
> > which are hard to find.
> >
> > ((int64_t)vaddr >> 47) == ((int64_t)vaddr >>
Hi Jan and Andrew, All
From standard:
The result of E1 >> E2 is E1 right-shifted E2 bit positions.
If E1 has an unsigned type or if E1 has a signed type and a nonnegative value,
the value of the result is the integral part of the quotient of E1 / 2E2.
If E1 has a signed type and a negative value,
There is no memory leak in case when handle_hvm_context function is
called next time.
So the code seems ok, please ignore the mail, sorry for confusion.
Thanks
On Fri, May 17, 2019 at 2:49 PM Viktor Mitin wrote:
>
> Hi All,
>
> It seems there is a memory leak in li
Hi All,
It seems there is a memory leak in libxc function handle_hvm_context
(in file tools/libxc/xc_sr_restore_x86_hvm.c.). There is a malloc of
variable p without free.
Please take a look.
+/*
+ * Process an HVM_CONTEXT record from the stream.
+ */
+static int handle_hvm_context(struct
Hi All,
While looking at code in tools/libxc/xc_sr_save_x86_pv.c,
we see that there is casting of xen virtual address type xen_vaddr_t
to signed int64 type.
In commit: 7bf74582b343603cb0826d808cd7da43326452a5
+/* Check a 64 bit virtual address for being canonical. */
+static inline bool
On Thu, May 16, 2019 at 06:40:14PM +0100, Julien Grall wrote:
>
> No need to resend the patch, I can do the modification when I will commit the
> patch.
>
Hi Julien,
Thank you for detailed description provided.
Will take into consideration all the notes.
Thanks
.
The entire library is moved to .init using:
$(OBJCOPY) $(foreach s,$(SECTIONS),--rename-section .$(s)=.init.$(s)) $< $@
So we need to tell the top Makefile to filter out libfdt and libelf.
Reported-by: Viktor Mitin
Suggested-by: Julien Grall
Signed-off-by: Viktor Mitin
Acked-by: Andrew Coo
>
> > On 16/05/2019 12:26, Wei Liu wrote:
> > > On Thu, May 16, 2019 at 02:13:54PM +0300, Viktor Mitin wrote:
> > >> The patch resolves 'xencov' crashes in case of Aarch64.
> > >>
> > >> All the .init.* sections are stripped after boot,
&
library is moved to .init using:
$(OBJCOPY) $(foreach s,$(SECTIONS),--rename-section .$(s)=.init.$(s)) $< $@
So we need to tell the top Makefile to filter out libfdt.
Reported-by: Viktor Mitin
Signed-off-by: Julien Grall
Tested-by: Viktor Mitin
---
xen/common/libfdt/Makefile | 1 +
1 file changed
: f4ea2c93ff09225beed05f629a3813b4e31c420d
(XEN) alternatives: Patching with alt table 00343d58 -> 00344418
---
Julien, are you going to integrate the patch?
Thanks
On Mon, May 13, 2019 at 1:43 PM Wei Liu wrote:
>
> On Mon, May 13, 2019 at 01:29:12PM +0300, Viktor Mitin wrote:
> &
> > aarch64-poky-linux-gcc -DBUILD_ID -fno-strict-aliasing -std=gnu99
> > -Wall -Wstrict-prototypes -Wdeclaration-after-statement
> > -Wno-unused-but-set-variable -Wno-unused-local-typedefs -O2
> > -fomit-frame-pointer
> > -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -MMD -MF
>
Hi Julien,
Please be aware that the patch you proposed (+nocov-y += libfdt.o)
failed to build with the next error (xen 4.12):
aarch64-poky-linux-gcc -DBUILD_ID -fno-strict-aliasing -std=gnu99
-Wall -Wstrict-prototypes -Wdeclaration-after-statement
-Wno-unused-but-set-variable
:
(XEN) PSCI cpu off failed for CPU0 err=-3
(XEN)
(XEN)
(XEN) Reboot in five seconds...
Thanks
On Thu, May 2, 2019 at 6:17 PM Julien Grall wrote:
>
> Hi,
>
> On 5/2/19 3:50 PM, Viktor Mitin wrote:
> > Adding Xen maintainers to this email CC.
Adding Xen maintainers to this email CC.
Thanks
On Thu, May 2, 2019 at 5:08 PM Viktor Mitin wrote:
>
> Hi All,
>
> Please be aware that we have tried Xen ARM64 build with
> CONFIG_COVERAGE feature enabled. The build environment is next:
> Xen Versions tested: xen-4.12-stable
e run-time exception details (rcarh3_config_coverage_trap.log);
- xen package build log file with compilation options (compilation.log);
- xen hypervisor .config file used for the build (xen_dot_config.log);
Please share any comments or ideas about the issue.
Thanks,
Vi
90 matches
Mail list logo
