Re: [Xen-devel] [PATCH v1] docs: substitute XEN_CONFIG_DIR in xl.conf.5

2019-08-19 Thread Olaf Hering
Am Sun, 18 Aug 2019 18:20:26 +0100 schrieb Wei Liu : > This doesn't apply. There is no such file. My changes need to be applied in this order, some of them may apply in any order: 20190619120633.27466-1-o...@aepfle.de 20190619121715.28532-1-o...@aepfle.de 20190619123818.30747-1-o...@aepfle.de

Re: [Xen-devel] [PATCH v1] docs: substitute XEN_CONFIG_DIR in xl.conf.5

2019-08-19 Thread Wei Liu
On Sun, Aug 18, 2019 at 06:27:26PM +0100, Andrew Cooper wrote: > On 18/08/2019 18:20, Wei Liu wrote: > > On Fri, Jun 21, 2019 at 11:30:05AM +0200, Olaf Hering wrote: > >> xl(1) opens xl.conf in XEN_CONFIG_DIR. > >> Substitute this variable also in the man page. > >> > >> Signed-off-by: Olaf Hering

Re: [Xen-devel] [PATCH v1] docs: substitute XEN_CONFIG_DIR in xl.conf.5

2019-08-19 Thread Wei Liu
On Mon, Aug 19, 2019 at 09:57:17AM +0200, Olaf Hering wrote: > Am Sun, 18 Aug 2019 18:20:26 +0100 > schrieb Wei Liu : > > > This doesn't apply. There is no such file. > > My changes need to be applied in this order, some of them may apply in any > order: > >

Re: [Xen-devel] [PATCH 11/11] arm64: use asm-generic/dma-mapping.h

2019-08-19 Thread Will Deacon
On Fri, Aug 16, 2019 at 03:00:13PM +0200, Christoph Hellwig wrote: > Now that the Xen special cases are gone nothing worth mentioning is > left in the arm64 file, so switch to use the > asm-generic version instead. > > Signed-off-by: Christoph Hellwig > --- > arch/arm64/include/asm/Kbuild

[Xen-devel] [linux-4.4 test] 140301: regressions - FAIL

2019-08-19 Thread osstest service owner
flight 140301 linux-4.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/140301/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvshim 20 guest-start/debian.repeat fail in 140072 REGR. vs. 139698 Tests

Re: [Xen-devel] [BUG] After upgrade to Xen 4.12.0 iommu=no-igfx

2019-08-19 Thread Roger Pau Monné
On Sun, Aug 18, 2019 at 10:00:17PM -0700, Roman Shaposhnik wrote: > Hi Roger! > > Some good news, some bad news ;-) > > Good news is that on the newer BIOS, your original patch seems to work fine. > > IOW, with newer BIOS: > 1. without your original patch I see garbled screen > 2. with

[Xen-devel] [PATCH v4 0/2] More typesafe conversion of common interface

2019-08-19 Thread Julien Grall
Hi all, The first patch was originally send as part of the series "xen/arm: Add xentrace support" [1]. As all the work but this patch was merged the series is now renamed. There are an additional patch for switching map_vcpu_info to use typesafe gfn. Cheers, [1]

Re: [Xen-devel] [PATCH v9 13/15] x86/microcode: Synchronize late microcode loading

2019-08-19 Thread Chao Gao
On Mon, Aug 19, 2019 at 11:27:36AM +0100, Sergey Dyasli wrote: >> +static int master_thread_fn(const struct microcode_patch *patch) >> +{ >> +unsigned int cpu = smp_processor_id(); >> +int ret = 0; >> + >> +while ( loading_state != LOADING_CALLIN ) >> +cpu_relax(); >> + >> +

[Xen-devel] [ovmf test] 140332: regressions - FAIL

2019-08-19 Thread osstest service owner
flight 140332 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/140332/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 18 guest-start/debianhvm.repeat fail REGR. vs. 140200 version

Re: [Xen-devel] [qemu-s390x] [Qemu-devel] [PATCH v7 33/42] exec: Replace device_endian with MemOp

2019-08-19 Thread Paolo Bonzini
On 16/08/19 12:12, Thomas Huth wrote: > This patch is *huge*, more than 800kB. It keeps being stuck in the the > filter of the qemu-s390x list each time you send it. Please: > > 1) Try to break it up in more digestible pieces, e.g. change only one > subsystem at a time (this is also better

[Xen-devel] [linux-linus test] 140321: regressions - trouble: blocked/broken/fail/pass

2019-08-19 Thread osstest service owner
flight 140321 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/140321/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemuu-rhel6hvm-intel broken

Re: [Xen-devel] [PATCH v6 04/10] domain: remove the 'is_xenstore' flag

2019-08-19 Thread Daniel De Graaf
On 8/16/19 1:19 PM, Paul Durrant wrote: This patch introduces a convenience macro, is_xenstore_domain(), which tests the domain 'options' directly and then uses that in place of the 'is_xenstore' flag. Signed-off-by: Paul Durrant Reviewed-by: "Roger Pau Monné" Acked-by: George Dunlap

Re: [Xen-devel] [Qemu-devel] [PATCH v7 25/42] hw/misc: Declare device little or big endian

2019-08-19 Thread Paolo Bonzini
On 16/08/19 12:04, Philippe Mathieu-Daudé wrote: >> diff --git a/hw/misc/a9scu.c b/hw/misc/a9scu.c >> index 4307f00..3de8cd3 100644 >> --- a/hw/misc/a9scu.c >> +++ b/hw/misc/a9scu.c >> @@ -94,7 +94,7 @@ static void a9_scu_write(void *opaque, hwaddr offset, >>  static const MemoryRegionOps

[Xen-devel] [PATCH 2/2] x86/AMD: Fix handling of x87 exception pointers on Fam17h hardware

2019-08-19 Thread Andrew Cooper
AMD Pre-Fam17h CPUs "optimise" {F,}X{SAVE,RSTOR} by not saving/restoring FOP/FIP/FDP if an x87 exception isn't pending. This causes an information leak, CVE-2006-1056, and worked around by several OSes, including Xen. AMD Fam17h CPUs no longer have this leak, and advertise so in a CPUID bit.

[Xen-devel] [PATCH 1/2] x86/feature: Generalise synth and introduce a bug word

2019-08-19 Thread Andrew Cooper
Future changes are going to want to use cpu_bug_* in a mannor similar to Linux. Introduce one bug word, and generalise the calculation of NCAPINTS. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné v2: * Rebase --- xen/include/asm-x86/cpufeatures.h | 67

Re: [Xen-devel] [PATCH] xen/console: Fix build when CONFIG_DEBUG_TRACE=y

2019-08-19 Thread Julien Grall
Hi Andrew, On 8/19/19 7:04 PM, Andrew Cooper wrote: On 19/08/2019 19:01, Julien Grall wrote: Commit b5e6e1ee8da "xen/console: Don't treat NUL character as the end of the buffer" extended sercon_puts to take the number of character to print in argument. Sadly, a couple of couple of the callers

[Xen-devel] [linux-4.14 test] 140333: regressions - FAIL

2019-08-19 Thread osstest service owner
flight 140333 linux-4.14 real [real] http://logs.test-lab.xenproject.org/osstest/logs/140333/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 139910 build-amd64-xsm

[Xen-devel] [freebsd-master test] 140355: all pass - PUSHED

2019-08-19 Thread osstest service owner
flight 140355 freebsd-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/140355/ Perfect :-) All tests in this flight passed as required version targeted for testing: freebsd 41a4c010326cd697d92141076bab53c424edb56f baseline version: freebsd

Re: [Xen-devel] [Qemu-devel] [qemu-s390x] [PATCH v7 33/42] exec: Replace device_endian with MemOp

2019-08-19 Thread Richard Henderson
On 8/19/19 11:29 AM, Paolo Bonzini wrote: > On 19/08/19 20:28, Paolo Bonzini wrote: >> On 16/08/19 12:12, Thomas Huth wrote: >>> This patch is *huge*, more than 800kB. It keeps being stuck in the the >>> filter of the qemu-s390x list each time you send it. Please: >>> >>> 1) Try to break it up in

[Xen-devel] [PATCH 0/2] x86/AMD: Fix handling of x87 exception pointers on Fam17h hardware

2019-08-19 Thread Andrew Cooper
This is a subset of a previously posted series, because support for this workaround has been outstanding for far too long. Andrew Cooper (2): x86/feature: Generalise synth and introduce a bug word x86/AMD: Fix handling of x87 exception pointers on Fam17h hardware tools/libxl/libxl_cpuid.c

Re: [Xen-devel] [qemu-s390x] [Qemu-devel] [PATCH v7 33/42] exec: Replace device_endian with MemOp

2019-08-19 Thread Paolo Bonzini
On 19/08/19 20:28, Paolo Bonzini wrote: > On 16/08/19 12:12, Thomas Huth wrote: >> This patch is *huge*, more than 800kB. It keeps being stuck in the the >> filter of the qemu-s390x list each time you send it. Please: >> >> 1) Try to break it up in more digestible pieces, e.g. change only one >>

Re: [Xen-devel] [PATCH v7 7/8] xen/arm: don't iomem_permit_access for reserved-memory regions

2019-08-19 Thread Julien Grall
Hi Stefano, On 8/19/19 6:43 PM, Stefano Stabellini wrote: Don't allow reserved-memory regions to be remapped into any unprivileged guests, until reserved-memory regions are properly supported in Xen. For now, do not call iomem_permit_access on them, because giving iomem_permit_access to dom0

Re: [Xen-devel] [livepatch: independ. modules 3/3] python: Add XC binding for Xen build ID

2019-08-19 Thread Marek Marczykowski-Górecki
On Thu, Aug 15, 2019 at 09:44:00AM +, Pawel Wieczorkiewicz wrote: > Extend the list of xc() object methods with additional one to display > Xen's buildid. The implementation follows the libxl implementation > (e.g. max buildid size assumption being XC_PAGE_SIZE). > > Signed-off-by: Pawel

[Xen-devel] [PATCH] tools/oxenstored: port XS_INTRODUCE evtchn rebind function from cxenstored

2019-08-19 Thread Igor Druzhinin
C version of xenstored had this ability since 61aaed0d5 ("Allow XS_INTRODUCE to be used for rebinding the xenstore evtchn.") from 2007. Copy it as is to Ocaml version. Signed-off-by: Igor Druzhinin --- tools/ocaml/xenstored/domain.ml | 6 +- tools/ocaml/xenstored/process.ml | 8 +++- 2

[Xen-devel] [xen-unstable-smoke test] 140371: tolerable all pass - PUSHED

2019-08-19 Thread osstest service owner
flight 140371 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/140371/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] [PATCH v6 1/8] xen/arm: pass node to device_tree_for_each_node

2019-08-19 Thread Stefano Stabellini
On Mon, 19 Aug 2019, Julien Grall wrote: > On 8/17/19 1:29 AM, Stefano Stabellini wrote: > > On Fri, 16 Aug 2019, Julien Grall wrote: > > > Hi, > > > > > > On 16/08/2019 00:36, Stefano Stabellini wrote: > > > > Add a new parameter to device_tree_for_each_node: node, the node to > > > > start the

Re: [Xen-devel] [PATCH v1] x86: Restore IA32_MISC_ENABLE on wakeup

2019-08-19 Thread Michał Kowalczyk
On 8/19/19 7:28 PM, Andrew Cooper wrote: > On 19/08/2019 14:56, Michał Kowalczyk wrote: >> On 8/19/19 3:52 PM, Andrew Cooper wrote: >>> On 19/08/2019 14:50, Michał Kowalczyk wrote: On 8/19/19 11:04 AM, Andrew Cooper wrote: > On 19/08/2019 03:23, Michał Kowalczyk wrote: >> diff --git

[Xen-devel] [PATCH] xen/console: Fix build when CONFIG_DEBUG_TRACE=y

2019-08-19 Thread Julien Grall
Commit b5e6e1ee8da "xen/console: Don't treat NUL character as the end of the buffer" extended sercon_puts to take the number of character to print in argument. Sadly, a couple of couple of the callers in debugtrace_dump_worker() were not converted. This result to a build failure when enabling

Re: [Xen-devel] [livepatch-hooks-1 PATCH 2/3] livepatch: Export payload structure via livepatch_payload.h

2019-08-19 Thread Ross Lagerwall
On 8/14/19 8:57 AM, Pawel Wieczorkiewicz wrote: The payload structure will be used by the new hooks implementation and therefore its definition has to be exported via the livepatch_payload header. The new hooks will make use of the payload structure fields and the hooks' pointers will also be

Re: [Xen-devel] [livepatch-hooks-1 PATCH 1/3] create-diff-object: Handle extra pre-|post- hooks

2019-08-19 Thread Ross Lagerwall
On 8/14/19 8:55 AM, Pawel Wieczorkiewicz wrote: Include new sections containing optional pre-, post- action hooks. The following new section names are supported: - .livepatch.hooks.preapply - .livepatch.hooks.postapply - .livepatch.hooks.prerevert - .livepatch.hooks.postrevert

Re: [Xen-devel] [PATCH livepatch-hooks-4 1/1] livepatch: always print XENLOG_ERR information

2019-08-19 Thread Ross Lagerwall
On 8/14/19 1:23 PM, Pawel Wieczorkiewicz wrote: A lot of legitimate error messages were hidden behind debug printk only. Most of these messages can be triggered by loading a malformed hotpatch payload and are priceless for understanding issues with such payloads. Thus, always display all

[Xen-devel] [PATCH v7 5/8] xen/arm: early_print_info print reserved_mem

2019-08-19 Thread Stefano Stabellini
Improve early_print_info to also print the banks saved in bootinfo.reserved_mem. Print them right after RESVD, increasing the same index. Since we are at it, also switch the existing RESVD print to use unsigned int. Signed-off-by: Stefano Stabellini Reviewed-by: Volodymyr Babchuk Acked-by:

[Xen-devel] [PATCH v7 3/8] xen/arm: keep track of reserved-memory regions

2019-08-19 Thread Stefano Stabellini
As we parse the device tree in Xen, keep track of the reserved-memory regions as they need special treatment (follow-up patches will make use of the stored information.) Reuse process_memory_node to add reserved-memory regions to the bootinfo.reserved_mem array. Refuse to continue once we reach

[Xen-devel] [PATCH v7 8/8] xen/arm: add reserved-memory regions to the dom0 memory node

2019-08-19 Thread Stefano Stabellini
Reserved memory regions are automatically remapped to dom0. Their device tree nodes are also added to dom0 device tree. However, the dom0 memory node is not currently extended to cover the reserved memory regions ranges as required by the spec. This commit fixes it. Change make_memory_node to

[Xen-devel] [PATCH v7 2/8] xen/arm: make process_memory_node a device_tree_node_func

2019-08-19 Thread Stefano Stabellini
Change the signature of process_memory_node to match device_tree_node_func. Thanks to this change, the next patch will be able to use device_tree_for_each_node to call process_memory_node on all the children of a provided node. Return error if there is no reg property or if nr_banks is reached.

[Xen-devel] [PATCH v7 6/8] xen/arm: handle reserved-memory in consider_modules and dt_unreserved_regions

2019-08-19 Thread Stefano Stabellini
reserved-memory regions overlap with memory nodes. The overlapping memory is reserved-memory and should be handled accordingly: consider_modules and dt_unreserved_regions should skip these regions the same way they are already skipping mem-reserve regions. Signed-off-by: Stefano Stabellini

[Xen-devel] [PATCH v7 7/8] xen/arm: don't iomem_permit_access for reserved-memory regions

2019-08-19 Thread Stefano Stabellini
Don't allow reserved-memory regions to be remapped into any unprivileged guests, until reserved-memory regions are properly supported in Xen. For now, do not call iomem_permit_access on them, because giving iomem_permit_access to dom0 means that the toolstack will be able to assign the region to a

[Xen-devel] [PATCH v7 0/8] reserved-memory in dom0

2019-08-19 Thread Stefano Stabellini
Hi all, This patch series introduces partial reserved-memory support for dom0 only (no domU support for reserved-memory yet.) The following changes since commit 762b9a2d990bba1f3aefe660cff0c37ad2e375bc: xen/page_alloc: Keep away MFN 0 from the buddy allocator (2019-08-09 11:12:55 -0700)

[Xen-devel] [PATCH v7 4/8] xen/arm: fix indentation in early_print_info

2019-08-19 Thread Stefano Stabellini
No functional changes. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall --- xen/arch/arm/bootfdt.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 0a01963b0e..eb3dc13b06 100644 ---

[Xen-devel] [PATCH v7 1/8] xen/arm: pass node to device_tree_for_each_node

2019-08-19 Thread Stefano Stabellini
Add a new parameter to device_tree_for_each_node: node, the node to start the search from. To avoid scanning device tree, and given that we only care about relative increments of depth compared to the depth of the initial node, we set the initial depth to 0. Then, we call func() for every node

Re: [Xen-devel] [PATCH v7 1/8] xen/arm: pass node to device_tree_for_each_node

2019-08-19 Thread Julien Grall
On 8/19/19 6:43 PM, Stefano Stabellini wrote: @@ -85,20 +86,22 @@ static u32 __init device_tree_get_u32(const void *fdt, int node, * Returns 0 if all nodes were iterated over successfully. If @func * returns a value different from 0, that value is returned immediately. */ -int

Re: [Xen-devel] [PATCH v7 2/8] xen/arm: make process_memory_node a device_tree_node_func

2019-08-19 Thread Julien Grall
Hi Stefano, On 8/19/19 6:43 PM, Stefano Stabellini wrote: Change the signature of process_memory_node to match device_tree_node_func. Thanks to this change, the next patch will be able to use device_tree_for_each_node to call process_memory_node on all the children of a provided node. Return

Re: [Xen-devel] [PATCH] x86/boot: Reposition trampoline data

2019-08-19 Thread David Woodhouse
On Mon, 2019-08-19 at 14:42 +0100, Andrew Cooper wrote: > ... to separate code from data. In particular, > trampoline_realmode_entry's > write to trampoline_cpu_started clobbers the I-cache line containing > trampoline_protmode_entry, which won't be great for AP startup. > > Reformat the

Re: [Xen-devel] [PATCH v2 4/6] x86/boot: Rename trampoline_{start, end} to boot_trampoline_{start, end}

2019-08-19 Thread David Woodhouse
On Mon, 2019-08-12 at 11:55 +0200, Jan Beulich wrote: > On 09.08.2019 17:02, David Woodhouse wrote: > > From: David Woodhouse > > > > In preparation for splitting the boot and permanent trampolines from > > each other. Some of these will change back, but most are boot so do the > > plain

Re: [Xen-devel] [PATCH livepatch-hooks-4 1/1] livepatch: always print XENLOG_ERR information

2019-08-19 Thread Andrew Cooper
On 19/08/2019 15:42, Ross Lagerwall wrote: > On 8/14/19 1:23 PM, Pawel Wieczorkiewicz wrote: >> A lot of legitimate error messages were hidden behind debug printk >> only. Most of these messages can be triggered by loading a malformed >> hotpatch payload and are priceless for understanding issues

Re: [Xen-devel] [PATCH v1] x86: Restore IA32_MISC_ENABLE on wakeup

2019-08-19 Thread Andrew Cooper
On 19/08/2019 14:56, Michał Kowalczyk wrote: > On 8/19/19 3:52 PM, Andrew Cooper wrote: >> On 19/08/2019 14:50, Michał Kowalczyk wrote: >>> On 8/19/19 11:04 AM, Andrew Cooper wrote: On 19/08/2019 03:23, Michał Kowalczyk wrote: > diff --git a/xen/arch/x86/boot/trampoline.S >

Re: [Xen-devel] [PATCH] xen/console: Fix build when CONFIG_DEBUG_TRACE=y

2019-08-19 Thread Andrew Cooper
On 19/08/2019 19:01, Julien Grall wrote: > Commit b5e6e1ee8da "xen/console: Don't treat NUL character as the end > of the buffer" extended sercon_puts to take the number of character > to print in argument. > > Sadly, a couple of couple of the callers in debugtrace_dump_worker() > were not

[Xen-devel] [PATCH v4 1/2] xen: Switch parameter in get_page_from_gfn to use typesafe gfn

2019-08-19 Thread Julien Grall
No functional change intended. Only reasonable clean-ups are done in this patch. The rest will use _gfn for the time being. The code in get_page_from_gfn is slightly reworked to also handle a bad behavior because it is not safe to use mfn_to_page(...) because mfn_valid(...) succeeds.

[Xen-devel] [PATCH v4 2/2] xen/domain: Use typesafe gfn in map_vcpu_info

2019-08-19 Thread Julien Grall
At the same time, modify the documentation of the hypercall to reflect the real meaning of the field mfn. Signed-off-by: Julien Grall --- Changes in v4: - Patch added --- xen/common/domain.c | 6 +++--- xen/include/public/vcpu.h | 2 +- xen/include/xen/domain.h | 2 +- 3

Re: [Xen-devel] [PATCH v2 3/6] x86/boot: Split bootsym() into four types of relocations

2019-08-19 Thread David Woodhouse
Apologies for delayed response; I was away last week and was frowned at every time I so much as looked towards the laptop. On Mon, 2019-08-12 at 11:41 +0200, Jan Beulich wrote: > On 09.08.2019 17:01, David Woodhouse wrote: > > --- a/xen/arch/x86/boot/trampoline.S > > +++

Re: [Xen-devel] [PATCH v2 5/6] x86/boot: Copy 16-bit boot variables back up to Xen image

2019-08-19 Thread David Woodhouse
On Mon, 2019-08-12 at 12:24 +0200, Jan Beulich wrote: > On 09.08.2019 17:02, David Woodhouse wrote: > > --- a/xen/arch/x86/boot/head.S > > +++ b/xen/arch/x86/boot/head.S > > @@ -733,6 +733,17 @@ trampoline_setup: > > cmp $sym_offs(__bootsym_seg_stop),%edi > > jb 1b > >

Re: [Xen-devel] [PATCH v2 6/6] x86/boot: Do not use trampoline for no-real-mode boot paths

2019-08-19 Thread David Woodhouse
On Mon, 2019-08-12 at 12:55 +0200, Jan Beulich wrote: > On 09.08.2019 17:02, David Woodhouse wrote: > > From: David Woodhouse > > > > Where booted from EFI or with no-real-mode, there is no need to stomp > > on low memory with the 16-boot code. Instead, just go straight to > >

Re: [Xen-devel] [PATCH v6 07/10] use is_iommu_enabled() where appropriate...

2019-08-19 Thread Daniel De Graaf
On 8/16/19 1:19 PM, Paul Durrant wrote: ...rather than testing the global iommu_enabled flag and ops pointer. Now that there is a per-domain flag indicating whether the domain is permitted to use the IOMMU (which determines whether the ops pointer will be set), many tests of the global

Re: [Xen-devel] [PATCH v3 1/6] xen/arm: introduce handle_interrupts

2019-08-19 Thread Stefano Stabellini
On Fri, 9 Aug 2019, Julien Grall wrote: > Hi Stefano, > > On 09/08/2019 00:12, Stefano Stabellini wrote: > > Move the interrupt handling code out of handle_device to a new function > > so that it can be reused for dom0less VMs later. > > > > Signed-off-by: Stefano Stabellini > > --- > > Changes

[Xen-devel] [xen-unstable-smoke test] 140380: tolerable all pass - PUSHED

2019-08-19 Thread osstest service owner
flight 140380 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/140380/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[Xen-devel] [xen-unstable test] 140331: regressions - trouble: broken/fail/pass

2019-08-19 Thread osstest service owner
flight 140331 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/140331/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-pair broken test-amd64-amd64-xl-pvshim 20

[Xen-devel] [linux-linus bisection] complete test-amd64-i386-xl

2019-08-19 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-xl testid xen-boot Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu

Re: [Xen-devel] [PATCH livepatch-python 1/1] livepatch: Add python bindings for livepatch operations

2019-08-19 Thread Marek Marczykowski-Górecki
On Thu, Aug 15, 2019 at 11:36:46AM +, Pawel Wieczorkiewicz wrote: > Extend the XC python bindings library to support also all common > livepatch operations and actions. > > Add the python bindings for the following operations: > - status (pyxc_livepatch_status): > Requires a payload name as

Re: [Xen-devel] [PATCH v3 6/6] xen/arm: add dom0less device assignment info to docs

2019-08-19 Thread Stefano Stabellini
On Fri, 9 Aug 2019, Julien Grall wrote: > Hi Stefano, > > I figured out I may want to read the docs before looking at the code :). > > On 09/08/2019 00:12, Stefano Stabellini wrote: > > Signed-off-by: Stefano Stabellini > > > > --- > > Changes in v3: > > - add nr_spis > > - change description

Re: [Xen-devel] [PATCH v3 5/6] xen/arm: introduce nr_spis

2019-08-19 Thread Stefano Stabellini
On Fri, 9 Aug 2019, Julien Grall wrote: > Hi Stefano, > > On 8/9/19 12:12 AM, Stefano Stabellini wrote: > > We don't have a clear way to know how many virtual SPIs we need for the > > boot domains. Introduce a new option under xen,domain to specify the > > number of SPIs to allocate for the

[Xen-devel] [libvirt test] 140340: regressions - FAIL

2019-08-19 Thread osstest service owner
flight 140340 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/140340/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-qcow2 15 guest-start/debian.repeat fail REGR. vs. 139829 Tests which are

Re: [Xen-devel] [PATCH v3 2/6] xen/arm: copy dtb fragment to guest dtb

2019-08-19 Thread Stefano Stabellini
On Fri, 9 Aug 2019, Julien Grall wrote: > On 8/9/19 12:12 AM, Stefano Stabellini wrote: > > Read the dtb fragment corresponding to a passthrough device from memory > > at the location referred to by the "multiboot,dtb" compatible node. > > > > Copy the fragment to the guest dtb. > > > > Add a

Re: [Xen-devel] [PATCH v3 4/6] xen/arm: handle "multiboot, device-tree" compatible nodes

2019-08-19 Thread Stefano Stabellini
On Fri, 9 Aug 2019, Volodymyr Babchuk wrote: > Stefano Stabellini writes: > > > Detect "multiboot,device-tree" compatible nodes. Add them to the bootmod > > array as BOOTMOD_GUEST_DTB. In kernel_probe, find the right > > BOOTMOD_GUEST_DTB and store a pointer to it in dtb_bootmodule. > > > >

Re: [Xen-devel] [PATCH v3 2/6] xen/arm: copy dtb fragment to guest dtb

2019-08-19 Thread Stefano Stabellini
On Fri, 9 Aug 2019, Volodymyr Babchuk wrote: > Stefano Stabellini writes: > > > Read the dtb fragment corresponding to a passthrough device from memory > > at the location referred to by the "multiboot,dtb" compatible node. > > > > Copy the fragment to the guest dtb. > > > > Add a dtb_bootmodule

Re: [Xen-devel] [PATCH v3 3/6] xen/arm: assign devices to boot domains

2019-08-19 Thread Stefano Stabellini
On Fri, 9 Aug 2019, Julien Grall wrote: > Hi Stefano, > > On 8/9/19 12:12 AM, Stefano Stabellini wrote: > > Scan the user provided dtb fragment at boot. For each device node, map > > memory to guests, and route interrupts and setup the iommu. > > > > The iommu is setup by passing the node of the

Re: [Xen-devel] [PATCH v3 4/6] xen/arm: handle "multiboot, device-tree" compatible nodes

2019-08-19 Thread Stefano Stabellini
On Fri, 9 Aug 2019, Julien Grall wrote: > Hi Stefano, > > On 8/9/19 12:12 AM, Stefano Stabellini wrote: > > Detect "multiboot,device-tree" compatible nodes. Add them to the bootmod > > array as BOOTMOD_GUEST_DTB. In kernel_probe, find the right > > BOOTMOD_GUEST_DTB and store a pointer to it in

Re: [Xen-devel] [Qemu-devel] [qemu-s390x] [PATCH v7 33/42] exec: Replace device_endian with MemOp

2019-08-19 Thread Edgar E. Iglesias
On Mon, 19 Aug. 2019, 23:01 Richard Henderson, wrote: > On 8/19/19 11:29 AM, Paolo Bonzini wrote: > > On 19/08/19 20:28, Paolo Bonzini wrote: > >> On 16/08/19 12:12, Thomas Huth wrote: > >>> This patch is *huge*, more than 800kB. It keeps being stuck in the the > >>> filter of the qemu-s390x

[Xen-devel] [PATCH] python: do not report handled EAGAIN error

2019-08-19 Thread Marek Marczykowski-Górecki
match_watch_by_token() when returns an error, sets also exception within python. This is generally the right thing to do, but when xspy_read_watch() handle EAGAIN error internally, the exception needs to be cleared. Otherwise it will fail like this: xen.lowlevel.xs.Error: (11, 'Resource

[Xen-devel] [linux-4.4 test] 140351: regressions - FAIL

2019-08-19 Thread osstest service owner
flight 140351 linux-4.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/140351/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvshim 20 guest-start/debian.repeat fail in 140072 REGR. vs. 139698 Tests

Re: [Xen-devel] [PATCH] x86/p2m: fix non-translated handling of iommu mappings

2019-08-19 Thread Roman Shaposhnik
On Mon, Jul 22, 2019 at 8:33 AM Roger Pau Monne wrote: > > The current usage of need_iommu_pt_sync in p2m for non-translated > guests is wrong because it doesn't correctly handle a relaxed PV > hardware domain, that has need_sync set to false, but still need > entries to be added from calls to

Re: [Xen-devel] [BUG] After upgrade to Xen 4.12.0 iommu=no-igfx

2019-08-19 Thread Roman Shaposhnik
On Mon, Aug 19, 2019 at 1:16 AM Roger Pau Monné wrote: > > On Sun, Aug 18, 2019 at 10:00:17PM -0700, Roman Shaposhnik wrote: > > Hi Roger! > > > > Some good news, some bad news ;-) > > > > Good news is that on the newer BIOS, your original patch seems to work fine. > > > > IOW, with newer BIOS: >

[Xen-devel] [linux-next test] 140354: regressions - FAIL

2019-08-19 Thread osstest service owner
flight 140354 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/140354/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine11 examine-serial/bootloader fail REGR. vs. 140251 Tests which did not

Re: [Xen-devel] [PATCH 02/11] xen/arm: use dev_is_dma_coherent

2019-08-19 Thread Julien Grall
Hi Christoph, On 8/16/19 2:00 PM, Christoph Hellwig wrote: Use the dma-noncoherent dev_is_dma_coherent helper instead of the home grown variant. It took me a bit of time to understand that dev->archdata.dma_coherent and dev->dma_coherent will always contain the same value. Would you mind

[Xen-devel] [linux-4.19 test] 140307: regressions - FAIL

2019-08-19 Thread osstest service owner
flight 140307 linux-4.19 real [real] http://logs.test-lab.xenproject.org/osstest/logs/140307/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine11 examine-serial/bootloader fail REGR. vs. 129313 build-armhf-pvops

Re: [Xen-devel] [PATCH 04/11] xen/arm: remove xen_dma_ops

2019-08-19 Thread Julien Grall
Hi Christoph, On 8/16/19 2:00 PM, Christoph Hellwig wrote: arm and arm64 can just use xen_swiotlb_dma_ops directly like x86, no need for a pointer indirection. Signed-off-by: Christoph Hellwig Reviewed-by: Julien Grall Cheers, -- Julien Grall

Re: [Xen-devel] [PATCH v6 1/8] xen/arm: pass node to device_tree_for_each_node

2019-08-19 Thread Julien Grall
Hi, On 8/17/19 1:29 AM, Stefano Stabellini wrote: On Fri, 16 Aug 2019, Julien Grall wrote: Hi, On 16/08/2019 00:36, Stefano Stabellini wrote: Add a new parameter to device_tree_for_each_node: node, the node to start the search from. Passing 0 triggers the old behavior. Here you say 0

Re: [Xen-devel] [RFC PATCH 0/2] XEN booting on i.MX8M platform

2019-08-19 Thread Julien Grall
On 8/6/19 10:14 PM, Amit Tomer wrote: Hi Hi, What are the consequences to change the interrupt parent? I am not entirely sure about it at the moment but looks like it controllers power domain for various devices like GPU, VPU and OTG etc. So, we may not be able to support these devices

Re: [Xen-devel] [PATCH 01/11] xen/arm: use dma-noncoherent.h calls for xen-swiotlb cache maintainance

2019-08-19 Thread Julien Grall
Hi Christoph, On 8/16/19 2:00 PM, Christoph Hellwig wrote: +static inline void xen_dma_map_page(struct device *hwdev, struct page *page, +dma_addr_t dev_addr, unsigned long offset, size_t size, +enum dma_data_direction dir, unsigned long attrs) +{ + unsigned long

Re: [Xen-devel] [PATCH] evtchn: make support for different ABIs tunable

2019-08-19 Thread Eslam Elnikety
On 14.08.19 15:02, Andrew Cooper wrote: On 14/08/2019 13:51, George Dunlap wrote: On 8/7/19 5:03 PM, Jan Beulich wrote: Whatever we do in Xen, it'll only allow to work around that issue. An actual fix belongs in the kernel(s). For this reason I suppose what we're talking about here is a

Re: [Xen-devel] [PATCH 08/11] swiotlb-xen: use the same foreign page check everywhere

2019-08-19 Thread Julien Grall
Hi Christoph, On 8/16/19 2:00 PM, Christoph Hellwig wrote: xen_dma_map_page uses a different and more complicated check for foreign pages than the other three cache maintainance helpers. Switch it to the simpler pfn_vali method a well. NIT: s/pfn_vali/pfn_valid/ Signed-off-by: Christoph

Re: [Xen-devel] [PATCH v6 2/8] xen/arm: make process_memory_node a device_tree_node_func

2019-08-19 Thread Julien Grall
On 8/17/19 1:48 AM, Stefano Stabellini wrote: On Fri, 16 Aug 2019, Julien Grall wrote: I think you are right, and honestly I was thinking about it while I updated this patch. If I use -EINVAL, it would be the same return error as the "invalid #address-cells or #size-cells". I just wanted to

[Xen-devel] [PATCH v3] evtchn: Introduce a per-guest knob to control FIFO ABI

2019-08-19 Thread Eslam Elnikety
Support for FIFO event channel ABI was first introduced in Xen 4.4 (see 88910061ec6). Make this support tunable, since the choice of which event channel ABI has implications for hibernation. Consider resuming a pre Xen 4.4 hibernated Linux guest. During resume from hibernation, there are two

Re: [Xen-devel] [PATCH] x86/pv: Clean up cr3 handling in arch_set_info_guest()

2019-08-19 Thread Julien Grall
Hi Andrew, On 8/13/19 7:04 PM, Andrew Cooper wrote: On 24/01/2019 22:10, Andrew Cooper wrote: On 24/01/2019 21:42, Julien Grall wrote: Hi Andrew, On 12/21/18 1:46 PM, Andrew Cooper wrote: All of this code lives inside CONFIG_PV which means gfn == mfn, and the fill_ro_mpt() calls clearly

Re: [Xen-devel] [PATCH v1] x86: Restore IA32_MISC_ENABLE on wakeup

2019-08-19 Thread Andrew Cooper
On 19/08/2019 03:23, Michał Kowalczyk wrote: > diff --git a/xen/arch/x86/boot/trampoline.S b/xen/arch/x86/boot/trampoline.S > index 7c6a2328d2..fcaa3eeaf1 100644 > --- a/xen/arch/x86/boot/trampoline.S > +++ b/xen/arch/x86/boot/trampoline.S > @@ -85,7 +85,7 @@ trampoline_gdt: > .long

Re: [Xen-devel] [PATCH v9 13/15] x86/microcode: Synchronize late microcode loading

2019-08-19 Thread Sergey Dyasli
On 19/08/2019 02:25, Chao Gao wrote: > This patch ports microcode improvement patches from linux kernel. > > Before you read any further: the early loading method is still the > preferred one and you should always do that. The following patch is > improving the late loading mechanism for long

Re: [Xen-devel] [livepatch-build-tools part3 v2 3/3] create-diff-object: Strip all undefined entires of known size

2019-08-19 Thread Wieczorkiewicz, Pawel
On 16. Aug 2019, at 17:02, Ross Lagerwall mailto:ross.lagerw...@citrix.com>> wrote: On 8/8/19 1:51 PM, Pawel Wieczorkiewicz wrote: The patched ELF object file contains all sections and symbols as resulted from the compilation. However, certain symbols may not be copied over to the resulting

Re: [Xen-devel] [PATCH v1] x86: Restore IA32_MISC_ENABLE on wakeup

2019-08-19 Thread Michał Kowalczyk
On 8/19/19 11:04 AM, Andrew Cooper wrote: > On 19/08/2019 03:23, Michał Kowalczyk wrote: >> diff --git a/xen/arch/x86/boot/trampoline.S b/xen/arch/x86/boot/trampoline.S >> index 7c6a2328d2..fcaa3eeaf1 100644 >> --- a/xen/arch/x86/boot/trampoline.S >> +++ b/xen/arch/x86/boot/trampoline.S >> @@

Re: [Xen-devel] [PATCH v1] x86: Restore IA32_MISC_ENABLE on wakeup

2019-08-19 Thread Michał Kowalczyk
On 8/19/19 3:52 PM, Andrew Cooper wrote: > On 19/08/2019 14:50, Michał Kowalczyk wrote: >> On 8/19/19 11:04 AM, Andrew Cooper wrote: >>> On 19/08/2019 03:23, Michał Kowalczyk wrote: diff --git a/xen/arch/x86/boot/trampoline.S b/xen/arch/x86/boot/trampoline.S index

Re: [Xen-devel] [PATCH] x86/pv: Clean up cr3 handling in arch_set_info_guest()

2019-08-19 Thread Andrew Cooper
On 19/08/2019 11:08, Julien Grall wrote: > Hi Andrew, > > On 8/13/19 7:04 PM, Andrew Cooper wrote: >> On 24/01/2019 22:10, Andrew Cooper wrote: >>> On 24/01/2019 21:42, Julien Grall wrote: Hi Andrew, On 12/21/18 1:46 PM, Andrew Cooper wrote: > All of this code lives inside

[Xen-devel] [PATCH] x86/boot: Various bits of trampoline cleanup

2019-08-19 Thread Andrew Cooper
Andrew Cooper (3): x86/boot: Further minor GDT corrections x86/boot: Reposition trampoline data x86/boot: Drop all use of lmsw xen/arch/x86/boot/head.S | 2 +- xen/arch/x86/boot/trampoline.S| 78 +-- xen/arch/x86/boot/wakeup.S| 5

[Xen-devel] [PATCH] x86/boot: Drop all use of lmsw

2019-08-19 Thread Andrew Cooper
lmsw is an obsolete relic of the 286 processor - so much so that it even lacks intercept assistance on AMD processors. Use a plain mov to %cr0 which is easier to follow, certainly faster to virtualise on AMD hardware, and almost certainly a faster microcode path in real hardware. Signed-off-by:

[Xen-devel] [PATCH] x86/boot: Reposition trampoline data

2019-08-19 Thread Andrew Cooper
... to separate code from data. In particular, trampoline_realmode_entry's write to trampoline_cpu_started clobbers the I-cache line containing trampoline_protmode_entry, which won't be great for AP startup. Reformat the comments for trampoline_gdt to reduce their volume. No functional change.

[Xen-devel] [PATCH] x86/boot: Further minor GDT corrections

2019-08-19 Thread Andrew Cooper
gdt_boot_descr and gdt_48 disagree on how long trampoline_gdt is. Introduce an end label and have the linker calculate the size, rather than hard coding it. Also, just as with c/s af292b41e9, there is no point forcing the CPU to set Access bits. Fix all remaining GDTs in Xen. Signed-off-by:

Re: [Xen-devel] [PATCH v3 01/14] xen/x86: Make mfn_to_gfn typesafe

2019-08-19 Thread George Dunlap
> On Jul 29, 2019, at 1:13 PM, Julien Grall wrote: > > Hi, > > @George can I get an ack for this patch? > > Cheers, > > On 6/3/19 5:03 PM, Julien Grall wrote: >> No functional changes intended. >> Signed-off-by: Julien Grall Acked-by: George Dunlap Sorry for the delay.

Re: [Xen-devel] [PATCH v1] x86: Restore IA32_MISC_ENABLE on wakeup

2019-08-19 Thread Andrew Cooper
On 19/08/2019 14:50, Michał Kowalczyk wrote: > On 8/19/19 11:04 AM, Andrew Cooper wrote: >> On 19/08/2019 03:23, Michał Kowalczyk wrote: >>> diff --git a/xen/arch/x86/boot/trampoline.S b/xen/arch/x86/boot/trampoline.S >>> index 7c6a2328d2..fcaa3eeaf1 100644 >>> --- a/xen/arch/x86/boot/trampoline.S