Re: [PATCH v13 6/9] gfxstream + rutabaga: add initial support for gfxstream

2023-09-21 Thread Gurchetan Singh
On Wed, Sep 20, 2023 at 5:05 AM Mark Cave-Ayland < mark.cave-ayl...@ilande.co.uk> wrote: > On 20/09/2023 12:42, Akihiko Odaki wrote: > > > On 2023/08/29 9:36, Gurchetan Singh wrote: > >> This adds initial support for gfxstream and cross-domain. Both > >> features rely on virtio-gpu blob

qemu-system-i386 crashes on i9 coffee lake

2023-09-21 Thread Stefan Kadow
Hello, since commit b9ade05c https://xenbits.xenproject.org/gitweb/?p=xen.git;a=commit;h=b9ade05cbba977673d5a08bc7a5940c5fd8add0e qemu-system-i386 crashes on my Intel i9 Coffee Lake System. This does not happen when the system is booted with the latest microcode update. So I do not know if

[xen-4.15-testing test] 183108: regressions - trouble: fail/pass/starved

2023-09-21 Thread osstest service owner
flight 183108 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/183108/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 182658 Tests which

Re: [PATCH v13 6/9] gfxstream + rutabaga: add initial support for gfxstream

2023-09-21 Thread Akihiko Odaki
On 2023/09/22 9:03, Gurchetan Singh wrote: On Wed, Sep 20, 2023 at 5:05 AM Mark Cave-Ayland mailto:mark.cave-ayl...@ilande.co.uk>> wrote: On 20/09/2023 12:42, Akihiko Odaki wrote: > On 2023/08/29 9:36, Gurchetan Singh wrote: >> This adds initial support for gfxstream and

Re: [PATCH] x86/paging: Delete update_cr3()'s do_locking parameter

2023-09-21 Thread Henry Wang
Hi, > On Sep 21, 2023, at 20:38, Jan Beulich wrote: > On 20.09.2023 21:21, Andrew Cooper wrote: >> Nicola reports that the XSA-438 fix introduced new MISRA violations because >> of >> some incidental tidying it tried to do. The parameter is useless, so resolve >> the MISRA regression by

Re: [PATCH v2 1/2] credit: Limit load balancing to once per millisecond

2023-09-21 Thread Henry Wang
Hi George, > On Sep 21, 2023, at 20:23, George Dunlap wrote: > > The credit scheduler tries as hard as it can to ensure that it always > runs scheduling units with positive credit (PRI_TS_UNDER) before > running those with negative credit (PRI_TS_OVER). If the next > runnable scheduling unit

Re: [PATCH v2 2/2] credit: Don't steal vcpus which have yielded

2023-09-21 Thread Henry Wang
Hi George, > On Sep 21, 2023, at 20:23, George Dunlap wrote: > > On large systems with many vcpus yielding due to spinlock priority > inversion, it's not uncommon for a vcpu to yield its timeslice, only > to be immediately stolen by another pcpu looking for higher-priority > work. > > To

Re: [PATCH] xen/arm64: head.S: Fix wrong enable_boot_cpu_mm() code movement

2023-09-21 Thread Henry Wang
Hi Julien, > On Sep 22, 2023, at 01:16, Julien Grall wrote: > > Hi Henry, > > On 16/09/2023 05:06, Henry Wang wrote: >> Some addressed comments on enable_boot_cpu_mm() were reintroduced >> back during the code movement from arm64/head.S to arm64/mmu/head.S. >> We should drop the unreachable

[libvirt test] 183097: tolerable all pass - PUSHED

2023-09-21 Thread osstest service owner
flight 183097 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/183097/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 183075 test-armhf-armhf-libvirt-qcow2 15

Re: [PATCH v1 2/3] ARM: GICv3 ITS: do not invalidate memory while sending a command

2023-09-21 Thread Volodymyr Babchuk
Hi Mark, I am writing to you, because you are GICv3 maintainer in Linux. We are updating ITS driver in Xen and we have a question about cache maintenance WRT memory shared with ITS. As I can see, the Linux ITS driver uses gic_flush_dcache_to_poc() all over the code. This boils down to "dc

Re: [XEN PATCH v3] xen/hypercalls: address violations of MISRA C:2012 Rule 8.3

2023-09-21 Thread Stefano Stabellini
On Thu, 21 Sep 2023, Federico Serafini wrote: > Make function declarations and definitions consistent. > No functional change. > > Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini

Re: [XEN PATCH] xen/numa: address a violation of MISRA C:2012 Rule 8.3

2023-09-21 Thread Stefano Stabellini
On Thu, 21 Sep 2023, Federico Serafini wrote: > Make object declarations consistent. No functional change. > > Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini > --- > xen/include/xen/numa.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] Revert "EDAC/mce_amd: Do not load edac_mce_amd module on guests"

2023-09-21 Thread Elliott Mitchell
On Fri, Sep 15, 2023 at 01:56:31PM +0200, Borislav Petkov wrote: > On Thu, Sep 14, 2023 at 10:02:05AM -0700, Elliott Mitchell wrote: > > Indeed. At what point is the lack of information and response long > > enough to simply commit a revert due to those lacks? > > At no point. > > > Even with

[linux-linus test] 183089: regressions - FAIL

2023-09-21 Thread osstest service owner
flight 183089 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/183089/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 182531

[PATCH WIP] xen/public: move incomplete type definitions to xen.h

2023-09-21 Thread Elliott Mitchell
Hypercall wrappers need the incomplete type definitions. Only when the actual structure needed. As such these incomplete definitions should be in xen.h next to their hypercalls, rather than spread all over. trap_info_t is particularly notable since even though the hypercall is x86-only, the

RE: [PATCH v10 28/38] x86/fred: FRED entry/exit and dispatch code

2023-09-21 Thread Li, Xin3
> > Since future kernels will support boottime toggling of whether 32bit > > syscall interface should be enabled or not as per: > > https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h= > > x86/entry=1da5c9bc119d3a749b519596b93f9b2667e93c4a > > > > It will make more sense to

Re: [PATCH] xen/arm64: head.S: Fix wrong enable_boot_cpu_mm() code movement

2023-09-21 Thread Julien Grall
Hi Henry, On 16/09/2023 05:06, Henry Wang wrote: Some addressed comments on enable_boot_cpu_mm() were reintroduced back during the code movement from arm64/head.S to arm64/mmu/head.S. We should drop the unreachable code, move the 'mov lr, x5' closer to 'b remove_identity_mapping' so it is

[xen-4.17-testing test] 183102: tolerable trouble: fail/pass/starved - PUSHED

2023-09-21 Thread osstest service owner
flight 183102 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/183102/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182639

Re: [GIT PULL] xen: branch for v6.6-rc3

2023-09-21 Thread pr-tracker-bot
The pull request you sent on Thu, 21 Sep 2023 10:41:10 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git > for-linus-6.6a-rc3-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/88a174a906fe9679a26c0f69fcc022743d2c8e05 Thank you! -- Deet-doot-dot,

Re: [PATCH v9 12/16] vpci: add initial support for virtual PCI bus topology

2023-09-21 Thread Roger Pau Monné
On Tue, Aug 29, 2023 at 11:19:46PM +, Volodymyr Babchuk wrote: > From: Oleksandr Andrushchenko > > Assign SBDF to the PCI devices being passed through with bus 0. > The resulting topology is where PCIe devices reside on the bus 0 of the > root complex itself (embedded endpoints). > This

[XEN PATCH] xen/emul-i8254: address a violation of MISRA C:2012 Rule 8.3

2023-09-21 Thread Federico Serafini
Make function declaration and definition consistent. No fuctional change. Signed-off-by: Federico Serafini --- xen/arch/x86/emul-i8254.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/emul-i8254.c b/xen/arch/x86/emul-i8254.c index 41ec4a1ef1..c48a3606a2 100644

[xen-unstable-smoke test] 183104: tolerable all pass - PUSHED

2023-09-21 Thread osstest service owner
flight 183104 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183104/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH v2 2/2] credit: Don't steal vcpus which have yielded

2023-09-21 Thread George Dunlap
On Thu, Sep 21, 2023 at 1:23 PM George Dunlap wrote: > > On large systems with many vcpus yielding due to spinlock priority > inversion, it's not uncommon for a vcpu to yield its timeslice, only > to be immediately stolen by another pcpu looking for higher-priority > work. > > To prevent this: >

[XEN PATCH] xen/numa: address a violation of MISRA C:2012 Rule 8.3

2023-09-21 Thread Federico Serafini
Make object declarations consistent. No functional change. Signed-off-by: Federico Serafini --- xen/include/xen/numa.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index 29b8c2df89..287e81ff66 100644 ---

[xen-4.15-testing test] 183095: regressions - trouble: fail/pass/starved

2023-09-21 Thread osstest service owner
flight 183095 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/183095/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 182658 Tests which

Re: [PATCH] xen/arm64: head.S: Fix wrong enable_boot_cpu_mm() code movement

2023-09-21 Thread Ayan Kumar Halder
On 16/09/2023 05:06, Henry Wang wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. Some addressed comments on enable_boot_cpu_mm() were reintroduced back during

Re: [PATCH v9 11/16] vpci/header: reset the command register when adding devices

2023-09-21 Thread Roger Pau Monné
On Tue, Aug 29, 2023 at 11:19:45PM +, Volodymyr Babchuk wrote: > From: Oleksandr Andrushchenko > > Reset the command register when assigning a PCI device to a guest: > according to the PCI spec the PCI_COMMAND register is typically all 0's > after reset, but this might not be true for the

Re: [PATCH] x86/paging: Delete update_cr3()'s do_locking parameter

2023-09-21 Thread Andrew Cooper
On 21/09/2023 1:38 pm, Jan Beulich wrote: > On 20.09.2023 21:21, Andrew Cooper wrote: >> Nicola reports that the XSA-438 fix introduced new MISRA violations because >> of >> some incidental tidying it tried to do. The parameter is useless, so resolve >> the MISRA regression by removing it. >> >>

Re: [PATCH v9 10/16] vpci/header: emulate PCI_COMMAND register for guests

2023-09-21 Thread Roger Pau Monné
On Tue, Aug 29, 2023 at 11:19:44PM +, Volodymyr Babchuk wrote: > From: Oleksandr Andrushchenko > > Xen and/or Dom0 may have put values in PCI_COMMAND which they expect > to remain unaltered. PCI_COMMAND_SERR bit is a good example: while the > guest's view of this will want to be zero

Re: [PATCH v2 1/2] credit: Limit load balancing to once per millisecond

2023-09-21 Thread Juergen Gross
On 21.09.23 14:23, George Dunlap wrote: The credit scheduler tries as hard as it can to ensure that it always runs scheduling units with positive credit (PRI_TS_UNDER) before running those with negative credit (PRI_TS_OVER). If the next runnable scheduling unit is of priority OVER, it will

Re: [PATCH v2 1/2] credit: Limit load balancing to once per millisecond

2023-09-21 Thread Juergen Gross
On 21.09.23 14:23, George Dunlap wrote: The credit scheduler tries as hard as it can to ensure that it always runs scheduling units with positive credit (PRI_TS_UNDER) before running those with negative credit (PRI_TS_OVER). If the next runnable scheduling unit is of priority OVER, it will

Re: [PATCH v3 7/7] qobject atomics osdep: Make a few macros more hygienic

2023-09-21 Thread Philippe Mathieu-Daudé
On 21/9/23 14:13, Markus Armbruster wrote: Variables declared in macros can shadow other variables. Much of the time, this is harmless, e.g.: #define _FDT(exp) \ do { \

Re: [PATCH] x86/paging: Delete update_cr3()'s do_locking parameter

2023-09-21 Thread Jan Beulich
On 20.09.2023 21:21, Andrew Cooper wrote: > Nicola reports that the XSA-438 fix introduced new MISRA violations because of > some incidental tidying it tried to do. The parameter is useless, so resolve > the MISRA regression by removing it. > > hap_update_cr3() discards the parameter entirely,

Re: [PATCH v10 33/38] x86/entry: Add fred_entry_from_kvm() for VMX to handle IRQ/NMI

2023-09-21 Thread Paolo Bonzini
On 9/21/23 14:11, Nikolay Borisov wrote: +SYM_FUNC_START(asm_fred_entry_from_kvm) +    push %rbp +    mov %rsp, %rbp use FRAME_BEGIN/FRAME_END macros to ommit this code if CONFIG_FRAME_POINTER is disabled. No, the previous stack pointer is used below, so the code might as well use %rbp

[PATCH v2 1/2] credit: Limit load balancing to once per millisecond

2023-09-21 Thread George Dunlap
The credit scheduler tries as hard as it can to ensure that it always runs scheduling units with positive credit (PRI_TS_UNDER) before running those with negative credit (PRI_TS_OVER). If the next runnable scheduling unit is of priority OVER, it will always run the load balancer, which will scour

[PATCH v2 2/2] credit: Don't steal vcpus which have yielded

2023-09-21 Thread George Dunlap
On large systems with many vcpus yielding due to spinlock priority inversion, it's not uncommon for a vcpu to yield its timeslice, only to be immediately stolen by another pcpu looking for higher-priority work. To prevent this: * Keep the YIELD flag until a vcpu is removed from a runqueue *

[PATCH v3 4/7] block/dirty-bitmap: Clean up local variable shadowing

2023-09-21 Thread Markus Armbruster
Local variables shadowing other local variables or parameters make the code needlessly hard to understand. Tracked down with -Wshadow=local. Clean up: rename both the pair of parameters and the pair of local variables. While there, move the local variables to function scope. Suggested-by: Kevin

[PATCH v3 7/7] qobject atomics osdep: Make a few macros more hygienic

2023-09-21 Thread Markus Armbruster
Variables declared in macros can shadow other variables. Much of the time, this is harmless, e.g.: #define _FDT(exp) \ do { \ int ret = (exp);

[PATCH v3 0/7] Steps towards enabling -Wshadow=local

2023-09-21 Thread Markus Armbruster
Local variables shadowing other local variables or parameters make the code needlessly hard to understand. Bugs love to hide in such code. Evidence: PATCH 1. Enabling -Wshadow would prevent bugs like this one. But we'd have to clean up all the offenders first. We got a lot of them. Enabling

[PATCH v3 1/7] migration/rdma: Fix save_page method to fail on polling error

2023-09-21 Thread Markus Armbruster
qemu_rdma_save_page() reports polling error with error_report(), then succeeds anyway. This is because the variable holding the polling status *shadows* the variable the function returns. The latter remains zero. Broken since day one, and duplicated more recently. Fixes: 2da776db4846 (rdma:

[PATCH v3 2/7] migration: Clean up local variable shadowing

2023-09-21 Thread Markus Armbruster
Local variables shadowing other local variables or parameters make the code needlessly hard to understand. Tracked down with -Wshadow=local. Clean up: delete inner declarations when they are actually redundant, else rename variables. Signed-off-by: Markus Armbruster Reviewed-by: Peter Xu

[PATCH v3 3/7] ui: Clean up local variable shadowing

2023-09-21 Thread Markus Armbruster
Local variables shadowing other local variables or parameters make the code needlessly hard to understand. Tracked down with -Wshadow=local. Clean up: delete inner declarations when they are actually redundant, else rename variables. Signed-off-by: Markus Armbruster Reviewed-by: Peter Maydell

[PATCH v3 6/7] block: Clean up local variable shadowing

2023-09-21 Thread Markus Armbruster
Local variables shadowing other local variables or parameters make the code needlessly hard to understand. Tracked down with -Wshadow=local. Clean up: delete inner declarations when they are actually redundant, else rename variables. Signed-off-by: Markus Armbruster Reviewed-by: Stefan Hajnoczi

[PATCH v3 5/7] block/vdi: Clean up local variable shadowing

2023-09-21 Thread Markus Armbruster
Local variables shadowing other local variables or parameters make the code needlessly hard to understand. Tracked down with -Wshadow=local. Clean up: delete inner declarations when they are actually redundant, else rename variables. Signed-off-by: Markus Armbruster Reviewed-by: Stefan Hajnoczi

[XEN PATCH v3] xen/hypercalls: address violations of MISRA C:2012 Rule 8.3

2023-09-21 Thread Federico Serafini
Make function declarations and definitions consistent. No functional change. Signed-off-by: Federico Serafini --- Changes in v3: - removed changes involving types with fixed/unfixed width; - uniformed parameter names of compat_memory_op() with {do,hvm}_memory_op(). --- Changes in v2: - change

Re: [PATCH v10 33/38] x86/entry: Add fred_entry_from_kvm() for VMX to handle IRQ/NMI

2023-09-21 Thread Nikolay Borisov
On 14.09.23 г. 7:48 ч., Xin Li wrote: In IRQ/NMI induced VM exits, KVM VMX needs to execute the respective handlers, which requires the software to create a FRED stack frame, and use it to invoke the handlers. Add fred_irq_entry_from_kvm() for this job. Export fred_entry_from_kvm() because

Re: [PATCH v2 7/7] qobject atomics osdep: Make a few macros more hygienic

2023-09-21 Thread Markus Armbruster
Kevin Wolf writes: > Am 20.09.2023 um 20:31 hat Markus Armbruster geschrieben: [...] >> diff --git a/include/qapi/qmp/qobject.h b/include/qapi/qmp/qobject.h >> index 9003b71fd3..d36cc97805 100644 >> --- a/include/qapi/qmp/qobject.h >> +++ b/include/qapi/qmp/qobject.h >> @@ -45,10 +45,17 @@

Re: xen | Failed pipeline for staging-4.15 | 3a9a2901

2023-09-21 Thread Jan Beulich
On 21.09.2023 10:30, Andrew Cooper wrote: > On 21/09/2023 8:08 am, Jan Beulich wrote: >> On 20.09.2023 12:50, GitLab wrote: >>> Job #5127621916 ( https://gitlab.com/xen-project/xen/-/jobs/5127621916/raw ) >>> >>> Stage: build >>> Name: debian-stretch-gcc >> This one failed with >> >> In file

[xen-unstable test] 183085: tolerable FAIL - PUSHED

2023-09-21 Thread osstest service owner
flight 183085 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/183085/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail like 183032

Re: [PATCH v9 09/16] vpci/header: program p2m with guest BAR view

2023-09-21 Thread Roger Pau Monné
On Tue, Aug 29, 2023 at 11:19:44PM +, Volodymyr Babchuk wrote: > From: Oleksandr Andrushchenko > > Take into account guest's BAR view and program its p2m accordingly: > gfn is guest's view of the BAR and mfn is the physical BAR value. > This way hardware domain sees physical BAR values and

Re: [XEN PATCH v3 4/4] README: remove old note about the build system's python expectation

2023-09-21 Thread Andrew Cooper
On 21/09/2023 6:59 am, Jan Beulich wrote: > On 20.09.2023 21:40, Andrew Cooper wrote: >> On 19/09/2023 7:50 am, Jan Beulich wrote: >>> On 19.09.2023 08:30, Javi Merino wrote: 5852ca485263 (build: fix tools/configure in case only python3 exists, 2019-12-11) changed the configure script to

Re: [PATCH v10 28/38] x86/fred: FRED entry/exit and dispatch code

2023-09-21 Thread Thomas Gleixner
On Thu, Sep 21 2023 at 12:48, Nikolay Borisov wrote: > On 14.09.23 г. 7:47 ч., Xin Li wrote: >> + >> +/* INT80 */ >> +case IA32_SYSCALL_VECTOR: >> +if (likely(IS_ENABLED(CONFIG_IA32_EMULATION))) { > > Since future kernels will support boottime toggling of whether 32bit >

Re: [PATCH for-4.18 v2] tools/light: Revoke permissions when a PCI detach for HVM domain

2023-09-21 Thread Julien Grall
Hi, On 16/09/2023 01:11, Henry Wang wrote: On Sep 15, 2023, at 20:52, Julien Grall wrote: From: Julien Grall Currently, libxl will grant IOMEM, I/O port and IRQ permissions when a PCI is attached (see pci_add_dm_done()) for all domain types. However, the permissions are only revoked for

Re: [PATCH v10 28/38] x86/fred: FRED entry/exit and dispatch code

2023-09-21 Thread Nikolay Borisov
On 14.09.23 г. 7:47 ч., Xin Li wrote: From: "H. Peter Anvin (Intel)" The code to actually handle kernel and event entry/exit using FRED. It is split up into two files thus: - entry_64_fred.S contains the actual entrypoints and exit code, and saves and restores registers. - entry_fred.c

Re: [PATCH v9 02/16] vpci: use per-domain PCI lock to protect vpci structure

2023-09-21 Thread Roger Pau Monné
On Wed, Sep 20, 2023 at 03:16:00PM -0400, Stewart Hildebrand wrote: > On 9/19/23 11:39, Roger Pau Monné wrote: > > On Tue, Aug 29, 2023 at 11:19:42PM +, Volodymyr Babchuk wrote: > >> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c > >> index 1edc7f1e91..545a27796e 100644 >

Re: [PATCH v9 02/16] vpci: use per-domain PCI lock to protect vpci structure

2023-09-21 Thread Roger Pau Monné
On Thu, Sep 21, 2023 at 09:42:08AM +0200, Jan Beulich wrote: > On 20.09.2023 15:56, Stewart Hildebrand wrote: > > On 9/20/23 04:09, Roger Pau Monné wrote: > >> On Tue, Sep 19, 2023 at 12:20:39PM -0400, Stewart Hildebrand wrote: > >>> On 9/19/23 11:39, Roger Pau Monné wrote: > On Tue, Aug 29,

Re: xen | Failed pipeline for staging | ea36ac0d

2023-09-21 Thread Michal Orzel
On 19/09/2023 12:21, Jan Beulich wrote: > > > On 19.09.2023 11:53, GitLab wrote: >> >> >> Pipeline #1009404353 has failed! >> >> Project: xen ( https://gitlab.com/xen-project/xen ) >> Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) >> >> Commit: ea36ac0d ( >>

[ovmf test] 183099: all pass - PUSHED

2023-09-21 Thread osstest service owner
flight 183099 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/183099/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf ea628f28e59849ee7b91e6660c0ecd1a5c6e0884 baseline version: ovmf

Re: [PATCH v2 7/7] qobject atomics osdep: Make a few macros more hygienic

2023-09-21 Thread Kevin Wolf
Am 20.09.2023 um 20:31 hat Markus Armbruster geschrieben: > Variables declared in macros can shadow other variables. Much of the > time, this is harmless, e.g.: > > #define _FDT(exp) \ > do {

[GIT PULL] xen: branch for v6.6-rc3

2023-09-21 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.6a-rc3-tag xen: branch for v6.6-rc3 It contains: - a cleanup patch removing some unused functions in the Xen event channel handling - a 3 patch series fixing a regression

Re: [PATCH v2 4/7] block/dirty-bitmap: Clean up local variable shadowing

2023-09-21 Thread Kevin Wolf
Am 20.09.2023 um 20:31 hat Markus Armbruster geschrieben: > Local variables shadowing other local variables or parameters make the > code needlessly hard to understand. Tracked down with -Wshadow=local. > Clean up: rename both the pair of parameters and the pair of local > variables. While

Re: [PATCH v2 6/7] block: Clean up local variable shadowing

2023-09-21 Thread Kevin Wolf
Am 20.09.2023 um 20:31 hat Markus Armbruster geschrieben: > Local variables shadowing other local variables or parameters make the > code needlessly hard to understand. Tracked down with -Wshadow=local. > Clean up: delete inner declarations when they are actually redundant, > else rename

Re: xen | Failed pipeline for staging-4.15 | 3a9a2901

2023-09-21 Thread Andrew Cooper
On 21/09/2023 8:08 am, Jan Beulich wrote: > On 20.09.2023 12:50, GitLab wrote: >> >> Pipeline #1010772231 has failed! >> >> Project: xen ( https://gitlab.com/xen-project/xen ) >> Branch: staging-4.15 ( >> https://gitlab.com/xen-project/xen/-/commits/staging-4.15 ) >> >> Commit: 3a9a2901 ( >>

Re: [PATCH v2 5/7] block/vdi: Clean up local variable shadowing

2023-09-21 Thread Kevin Wolf
Am 20.09.2023 um 20:31 hat Markus Armbruster geschrieben: > Local variables shadowing other local variables or parameters make the > code needlessly hard to understand. Tracked down with -Wshadow=local. > Clean up: delete inner declarations when they are actually redundant, > else rename

[xen-4.17-testing test] 183083: regressions - FAIL

2023-09-21 Thread osstest service owner
flight 183083 xen-4.17-testing real [real] flight 183100 xen-4.17-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/183083/ http://logs.test-lab.xenproject.org/osstest/logs/183100/ Regressions :-( Tests which did not succeed and are blocking, including tests which could

Re: [PATCH v9 02/16] vpci: use per-domain PCI lock to protect vpci structure

2023-09-21 Thread Jan Beulich
On 20.09.2023 15:56, Stewart Hildebrand wrote: > On 9/20/23 04:09, Roger Pau Monné wrote: >> On Tue, Sep 19, 2023 at 12:20:39PM -0400, Stewart Hildebrand wrote: >>> On 9/19/23 11:39, Roger Pau Monné wrote: On Tue, Aug 29, 2023 at 11:19:42PM +, Volodymyr Babchuk wrote: > diff --git

Re: [PATCH v6 0/4] ppc: Enable full Xen build

2023-09-21 Thread Jan Beulich
On 20.09.2023 13:04, George Dunlap wrote: > On Wed, Sep 20, 2023 at 11:59 AM George Dunlap > wrote: >> >> On Mon, Sep 18, 2023 at 6:27 PM Shawn Anastasio >> wrote: >>> >>> On 9/18/23 8:19 AM, Jan Beulich wrote: On 14.09.2023 21:03, Shawn Anastasio wrote: > Shawn Anastasio (4): >

Re: [PATCH v2 0/2] net: Update MemReentrancyGuard for NIC

2023-09-21 Thread Akihiko Odaki
On 2023/06/01 12:18, Akihiko Odaki wrote: Recently MemReentrancyGuard was added to DeviceState to record that the device is engaging in I/O. The network device backend needs to update it when delivering a packet to a device. This implementation follows what bottom half does, but it does not add

Re: xen | Failed pipeline for staging-4.15 | 3a9a2901

2023-09-21 Thread Jan Beulich
On 20.09.2023 12:50, GitLab wrote: > > > Pipeline #1010772231 has failed! > > Project: xen ( https://gitlab.com/xen-project/xen ) > Branch: staging-4.15 ( > https://gitlab.com/xen-project/xen/-/commits/staging-4.15 ) > > Commit: 3a9a2901 ( >

RE: [PATCH v10 16/38] x86/ptrace: Add FRED additional information to the pt_regs structure

2023-09-21 Thread Li, Xin3
> > I guess you have FRED 3.0 spec, no? > Doh you are right, I was looking at the wrong version of the document > sorry for > the noise. Actually I appreciate your review so much!

Re: [PATCH v10 16/38] x86/ptrace: Add FRED additional information to the pt_regs structure

2023-09-21 Thread Nikolay Borisov
On 20.09.23 г. 20:23 ч., Li, Xin3 wrote: +struct fred_ss { + u64 ss : 16, // SS selector Is this structure conformant to the return state as described in FRED 5.0? — The stack segment of the interrupted context, 64 bits formatted as follows: • Bits 15:0 contain the SS

Re: [PATCH v2 2/7] migration: Clean up local variable shadowing

2023-09-21 Thread Zhijian Li (Fujitsu)
On 21/09/2023 02:31, Markus Armbruster wrote: > Local variables shadowing other local variables or parameters make the > code needlessly hard to understand. Tracked down with -Wshadow=local. > Clean up: delete inner declarations when they are actually redundant, > else rename variables. > >

Re: [XEN PATCH v3 4/4] README: remove old note about the build system's python expectation

2023-09-21 Thread Jan Beulich
On 20.09.2023 21:40, Andrew Cooper wrote: > On 19/09/2023 7:50 am, Jan Beulich wrote: >> On 19.09.2023 08:30, Javi Merino wrote: >>> 5852ca485263 (build: fix tools/configure in case only python3 exists, >>> 2019-12-11) changed the configure script to test for the availability >>> of python3,