On 01.02.2024 22:12, Andrew Cooper wrote:
> On 16/01/2024 4:53 pm, Jan Beulich wrote:
>> While altcall is already used for them, the functions want announcing in
>> .init.rodata.cf_clobber, even if the resulting static variables aren't
>> otherwise used.
>>
>> While doing this also move
On 17.01.2024 10:31, Jan Beulich wrote:
> While .setup() and .e820_fixup() don't need fiddling with for being run
> only very early, both .ap_setup() and .resume() want converting too:
> This way both pre-filled struct hypervisor_ops instances can become
> __initconst_cf_clobber, thus allowing to
On 02.02.2024 01:39, Andrew Cooper wrote:
> Wherever possible, it is a good idea to NULL out the visible reference to an
> object prior to freeing it. The FREE*() macros already collect together both
> parts, making it easy to adjust.
>
> This has a marginal code generation improvement, as some
"Old" tested version had not actually been tested; therefore in this
flight we test it, rather than a new candidate. The baseline, if
any, is the most recent actually tested revision.
flight 184549 linux-6.1 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/184549/
Failures :-/ but
flight 184561 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/184561/
Perfect :-)
All tests in this flight passed as required
version targeted for testing:
ovmf 927ea1364d047d54cb67e0f231644f295c032944
baseline version:
ovmf
On 1/25/24 11:00, Jan Beulich wrote:
> On 09.01.2024 22:51, Stewart Hildebrand wrote:
>> --- a/xen/drivers/Kconfig
>> +++ b/xen/drivers/Kconfig
>> @@ -15,4 +15,8 @@ source "drivers/video/Kconfig"
>> config HAS_VPCI
>> bool
>>
>> +config HAS_VPCI_GUEST_SUPPORT
>> +bool
>> +depends
flight 184558 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/184558/
Perfect :-)
All tests in this flight passed as required
version targeted for testing:
ovmf 3656352675bf66c06b65bf85632996d3471073ae
baseline version:
ovmf
flight 184560 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/184560/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm
Wherever possible, it is a good idea to NULL out the visible reference to an
object prior to freeing it. The FREE*() macros already collect together both
parts, making it easy to adjust.
This has a marginal code generation improvement, as some of the calls to the
free() function can be tailcall
flight 184555 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/184555/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm
flight 184556 xtf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/184556/
Perfect :-)
All tests in this flight passed as required
version targeted for testing:
xtf d1de27cf787e9c86610b11f6fe13d90f5ca91e27
baseline version:
xtf
flight 184547 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/184547/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 184535
A Linux HVM domain ignores PV block devices with type cdrom. The
Windows PV drivers also ignore device-type != "disk". Therefore QEMU's
emulated CD-ROM support is used. This allows ejection and other CD-ROM
features to work.
With a stubdom, QEMU is running in the stubdom. A PV disk is still
These patches enable cd-rom media changing for an HVM with a linux
stubdom.
v1 didn't support these empty drives. The code came out of OpenXT which
has a hack - null.iso. null.iso is an ISO with no contents. OpenXT
doesn't actually eject the cd-rom, it just inserts null.iso. This patch
set
To change the cd-rom medium, libxl will:
- QMP eject the medium from QEMU
- block-detach the old PV disk
- block-attach the new PV disk
- QMP change the medium to the new PV disk by fdset-id
The QMP code is reused, and remove and attach are implemented here.
The stubdom must internally
With a device model stubdom, dom0 exports a PV disk to the stubdom.
Inside the stubdom, QEMU emulates a cdrom to the guest with a
host_device pointing at the PV frontend (/dev/xvdc)
An empty cdrom drive causes problems booting the stubdom. The PV disk
protocol isn't designed to support no media.
On 16/01/2024 4:53 pm, Jan Beulich wrote:
> While altcall is already used for them, the functions want announcing in
> .init.rodata.cf_clobber, even if the resulting static variables aren't
> otherwise used.
>
> While doing this also move ctxt_switch_masking to .data.ro_after_init.
>
>
On 01/02/2024 10:35 am, Andrew Cooper wrote:
> Nothing in bitmap.h uses lib.h, and there's no point including types.h when we
> need to include bitops.h anyway.
>
> Signed-off-by: Andrew Cooper
> ---
> CC: George Dunlap
> CC: Jan Beulich
> CC: Stefano Stabellini
> CC: Wei Liu
> CC: Julien
On 01/02/2024 3:07 pm, Andrew Cooper wrote:
> On 01/02/2024 2:59 pm, Frediano Ziglio wrote:
>> Signed-off-by: Frediano Ziglio
>> ---
>> arch/x86/include/arch/processor.h | 2 +-
>> include/xen/hvm/params.h | 2 +-
>> include/xtf/console.h | 2 +-
>> include/xtf/extable.h
On 01/02/2024 6:30 pm, Jason Andryuk wrote:
> Jason Andryuk (4):
> block-common: Fix same_vm for no targets
> libxl: Add support for blktap vbd3
> hotplug: Update block-tap
> libxl: Support blktap with HVM device model
If libxl is learning how to drive tapdisk, then it's time for:
On Thursday, February 1st, 2024 at 9:18 AM, David Woodhouse
wrote:
> (Thanks Andy for the explicit cc)
>
> On Thu, 2024-02-01 at 00:05 +, John L. Poole wrote:
>
> > cause Gentoo's build to error out. See line 24790:
> >
> > 5 | #error In Xen native files, include xen_native.h before
Implement a sharing check like the regular block script.
Checking tapback inside block-tap is too late since it needs to be
running to transition the backend to InitWait before block-tap is run.
tap-ctl check will be removed when the requirement for the blktap kernel
driver is removed. Remove
same_vm is broken when the two main domains do not have targets. otvm
and targetvm are both missing, which means they get set to -1 and then
converted to empty strings:
++10697+ local targetvm=-1
++10697+ local otvm=-1
++10697+ otvm=
++10697+ othervm=/vm/cc97bc2f-3a91-43f7-8fbc-4cb92f90b4e4
blktap exposes disks over UNIX socket Network Block Device (NBD).
Modify libxl__device_disk_find_local_path() to provide back the
QEMU-formatted NBD path. This allows tapdisk to be used for booting an
HVM.
Use the nbd+unix:/// format specified by the protocol at
This patch re-introduces blktap support to libxl. Unlike earlier
versions, it does not link against any blktap library. libxl changes
are needed to write to the vbd3 backend XenStore nodes.
blktap has three components. tapdisk is a daemon implementing the disk
IO, NBD (Network Block Device),
This patch re-introduces blktap support to libxl. Unlike earlier
versions, it does not link against any blktap library. libxl changes
are needed to write to the vbd3 backend XenStore nodes.
blktap has three components. tapdisk is a daemon implementing the disk
IO, NBD (Network Block Device),
flight 184552 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/184552/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm
Hi,
On 31/01/2024 07:57, Bertrand Marquis wrote:
On 30 Jan 2024, at 18:29, Julien Grall wrote:
From: Julien Grall
Recent rework to the secondary boot code modified how init_ttbr and
smp_up_cpu are accessed. Rather than directly accessing them, we
are using a pointer to them.
The helper
(Thanks Andy for the explicit cc)
On Thu, 2024-02-01 at 00:05 +, John L. Poole wrote:
>
> cause Gentoo's build to error out. See line 24790:
>
> 5 | #error In Xen native files, include xen_native.h before other Xen
> headers
>
> at
>
On Thu, Feb 01, 2024 at 01:09:11PM +0100, Jan Beulich wrote:
> On 01.02.2024 12:50, Roger Pau Monné wrote:
> > On Thu, Jan 11, 2024 at 10:00:10AM +0100, Jan Beulich wrote:
> >> @@ -503,6 +538,9 @@ static int vmx_init_vmcs_config(bool bsp
> >> "Secondary Exec Control",
> >>
Currently when a unity range overlaps with memory being used as RAM by the
hypervisor the result would be that the IOMMU gets disabled. However that's
not enough, as even with the IOMMU disabled the device will still access the
affected RAM areas.
Note that IVMD or RMRR ranges being placed over
IVMD and RMRR ranges are functionally equivalent, and as so could use the same
validity checker.
Move the IVMD to x86 common IOMMU code and adjust the function to take a pair
of [start, end) mfn parameters.
So far only the AMD-Vi side is adjusted to use the newly introduced helper, the
VT-d side
Use the newly introduced generic unity map checker.
Also drop the message recommending the usage of iommu_inclusive_mapping: the
ranges would end up being mapped anyway even if some of the checks above
failed, regardless of whether iommu_inclusive_mapping is set.
Signed-off-by: Roger Pau Monné
Hello,
Patch 1 is a bugfix for AMD-Vi IVMD range type checks.
Further patches unify the IVMD/RMRR checks into a common function, and
the last patch tightens up the condition to panic when attempting to
boot on a system that has RMRR or IVMD regions over memory that Xen uses
as RAM.
Thanks,
The current code that parses the IVMD blocks is relaxed with regard to the
restriction that such unity regions should always fall into memory ranges
marked as reserved in the memory map.
However the type checks for the IVMD addresses are inverted, and as a result
IVMD ranges falling into RAM
On Thu, Feb 1, 2024 at 4:57 PM Julien Grall wrote:
>
> Hi George,
>
> On 01/02/2024 16:55, George Dunlap wrote:
> > On Thu, Jan 11, 2024 at 12:27 PM Yann Dirson wrote:
> >>> - what should be the criteria to advertise it as official Xenproject
> >>> guest agent ?
> >>
> >> What do people think
Hi George,
On 01/02/2024 16:55, George Dunlap wrote:
On Thu, Jan 11, 2024 at 12:27 PM Yann Dirson wrote:
- what should be the criteria to advertise it as official Xenproject
guest agent ?
What do people think here?
As we discussed at the community call, I think that we should
basically
On Thu, Jan 11, 2024 at 12:27 PM Yann Dirson wrote:
> > - what should be the criteria to advertise it as official Xenproject
> > guest agent ?
>
> What do people think here?
As we discussed at the community call, I think that we should
basically set a date at which we consider this the official
Le jeu. 1 févr. 2024 à 13:30, Sébastien Chaumat a
écrit :
> I spotted the following warning for IRQ7 (along with IRQ6 and 10)
>
> [0.686073] fedora kernel: __irq_set_trigger: genirq: No set_type
> function for IRQ 7 (IR-IO-APIC)
>
> This comes from kernel/irq/manage.c
>
>
> int
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski :
On Mon, 29 Jan 2024 14:03:08 +0100 you wrote:
> Invoking the make_tx_response() / push_tx_responses() pair with no lock
> held would be acceptable only if all such invocations happened from the
> same context (NAPI
flight 184545 linux-linus real [real]
flight 184550 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/184545/
http://logs.test-lab.xenproject.org/osstest/logs/184550/
Failures :-/ but no regressions.
Tests which are failing intermittently (not blocking):
On 1/26/24 18:24, David Woodhouse wrote:
From: David Woodhouse
Signed-off-by: David Woodhouse
Acked-by: Cédric Le Goater
and
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
hw/arm/aspeed.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/hw/arm/aspeed.c
On 2/1/24 13:20, Julien Grall wrote:
>
>
> On 31/01/2024 15:32, John Ernberg wrote:
>> Hi Julien,
>
> Hi John,
>
>> On 1/31/24 13:22, Julien Grall wrote:
>>> Hi,
>>>
>>> On 31/01/2024 11:50, John Ernberg wrote:
When using Linux for dom0 there are a bunch of drivers that need to do
Hi Peng,
On 2/1/24 05:10, Peng Fan wrote:
>> Cc: Jonas Blixt ; xen-devel@lists.xenproject.org
>> Subject: Re: [PATCH 1/2] xen/arm: Add imx8q{m,x} platform glue
>>
>> Hi Julien,
>>
>> On 1/31/24 13:22, Julien Grall wrote:
>>> Hi,
>>>
>>> On 31/01/2024 11:50, John Ernberg wrote:
When using
On 29/01/2024 13:03, Jan Beulich wrote:
Invoking the make_tx_response() / push_tx_responses() pair with no lock
held would be acceptable only if all such invocations happened from the
same context (NAPI instance or dealloc thread). Since this isn't the
case, and since the interface "spec" also
On 29.01.2024 18:18, Carlo Nonato wrote:
> @@ -157,7 +158,11 @@
> #define PGC_static 0
> #endif
>
> -#define PGC_preserved (PGC_extra | PGC_static)
> +#ifndef PGC_colored
> +#define PGC_colored 0
> +#endif
> +
> +#define PGC_preserved (PGC_extra | PGC_static | PGC_colored)
>
> #ifndef
flight 184548 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/184548/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-arm64-libvirt 6 libvirt-buildfail REGR. vs. 184537
Tests which did not
On 01/02/2024 00:23, Jakub Kicinski wrote:
On Mon, 29 Jan 2024 14:03:08 +0100 Jan Beulich wrote:
Invoking the make_tx_response() / push_tx_responses() pair with no lock
held would be acceptable only if all such invocations happened from the
same context (NAPI instance or dealloc thread). Since
On 01.02.2024 15:49, Carlo Nonato wrote:
> On Thu, Feb 1, 2024 at 3:24 PM Jan Beulich wrote:
>> On 29.01.2024 18:18, Carlo Nonato wrote:
>>> PGC_static and PGC_extra are flags that needs to be preserved when assigning
>>> a page. Define a new macro that groups those flags and use it instead of
On 29.01.2024 18:18, Carlo Nonato wrote:
> --- a/xen/common/llc-coloring.c
> +++ b/xen/common/llc-coloring.c
> @@ -9,6 +9,9 @@
> #include
> #include
>
> +#define XEN_DEFAULT_COLOR 0
> +#define XEN_DEFAULT_NUM_COLORS 1
> +
> bool __ro_after_init llc_coloring_enabled;
>
I put it on the linux command line indeed, here is the log with iommu=debug.
I can install Xen with a debug build or test a fix if needed.
I just need some guides because all I did for know is apt or dnf install Xen.
Le jeudi 1 février 2024 à 11:57, Jan Beulich a écrit :
> On 01.02.2024
On 01/02/2024 2:59 pm, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> arch/x86/include/arch/processor.h | 2 +-
> include/xen/hvm/params.h | 2 +-
> include/xtf/console.h | 2 +-
> include/xtf/extable.h | 4 ++--
> 4 files changed, 5
Signed-off-by: Frediano Ziglio
---
arch/x86/include/arch/processor.h | 2 +-
include/xen/hvm/params.h | 2 +-
include/xtf/console.h | 2 +-
include/xtf/extable.h | 4 ++--
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git
Hi Jan,
On Thu, Feb 1, 2024 at 3:24 PM Jan Beulich wrote:
>
> On 29.01.2024 18:18, Carlo Nonato wrote:
> > PGC_static and PGC_extra are flags that needs to be preserved when assigning
> > a page. Define a new macro that groups those flags and use it instead of
> > or'ing every time.
>
> While
On 29.01.2024 18:18, Carlo Nonato wrote:
> PGC_static and PGC_extra are flags that needs to be preserved when assigning
> a page. Define a new macro that groups those flags and use it instead of
> or'ing every time.
While here you say where the "preserving" applies, ...
> ---
On 29.01.2024 18:18, Carlo Nonato wrote:
> Introduce a new helper to initialize fields that have different uses for
> free pages.
>
> Signed-off-by: Carlo Nonato
Acked-by: Jan Beulich
On 29.01.2024 18:18, Carlo Nonato wrote:
> @@ -950,6 +951,11 @@ void __init create_domUs(void)
> #endif
> }
>
> +dt_property_read_string(node, "llc-colors", _colors_str);
> +if ( !llc_coloring_enabled && llc_colors_str)
> +printk(XENLOG_WARNING
> +
On 01.02.2024 14:32, George Dunlap wrote:
> On Thu, Jun 23, 2022 at 12:54 PM Jan Beulich wrote:
>
>> By using | instead of || or (in the negated form) && chances increase
>> for the compiler to recognize that both predicates can actually be
>> folded into an expression requiring just a single
Hi Jens,
> On 17 Jan 2024, at 12:06, Jens Wiklander wrote:
>
> When an FF-A enabled guest is destroyed it may leave behind memory
> shared with SPs. This memory must be reclaimed before it's reused or an
> SP may make changes to memory used by a new unrelated guest. So when the
> domain is
Hi Jan,
On 01/02/2024 13:39, Jan Beulich wrote:
On 01.02.2024 14:35, Julien Grall wrote:
Hi Jan,
On 01/02/2024 13:30, Jan Beulich wrote:
On 29.01.2024 18:18, Carlo Nonato wrote:
Add a command line parameter to allow the user to set the coloring
configuration for Dom0.
A common configuration
On 29.01.2024 18:18, Carlo Nonato wrote:
> @@ -858,6 +859,16 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t)
> u_domctl)
> __HYPERVISOR_domctl, "h", u_domctl);
> break;
>
> +case XEN_DOMCTL_set_llc_colors:
> +if ( !llc_coloring_enabled )
> +
On Tue, Jan 4, 2022 at 9:48 AM Jan Beulich wrote:
> Avoid recurring MFN -> page or page -> MFN translations. Drop the pretty
> pointless local variable "p". Make sure the MFN logged in a debugging
> error message is actually the offending one. Return negative errno
> values rather than -1
On 01.02.2024 14:35, Julien Grall wrote:
> Hi Jan,
>
> On 01/02/2024 13:30, Jan Beulich wrote:
>> On 29.01.2024 18:18, Carlo Nonato wrote:
>>> Add a command line parameter to allow the user to set the coloring
>>> configuration for Dom0.
>>> A common configuration syntax for cache colors is
Hi Jan,
On 01/02/2024 13:30, Jan Beulich wrote:
On 29.01.2024 18:18, Carlo Nonato wrote:
Add a command line parameter to allow the user to set the coloring
configuration for Dom0.
A common configuration syntax for cache colors is introduced and
documented.
Take the opportunity to also add:
-
On Thu, Jun 23, 2022 at 12:54 PM Jan Beulich wrote:
> By using | instead of || or (in the negated form) && chances increase
> for the compiler to recognize that both predicates can actually be
> folded into an expression requiring just a single branch (via OR-ing
> together the respective
On 29.01.2024 18:17, Carlo Nonato wrote:
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -626,6 +626,11 @@ struct domain
>
> /* Holding CDF_* constant. Internal flags for domain creation. */
> unsigned int cdf;
> +
> +#ifdef CONFIG_LLC_COLORING
> +unsigned
On 29.01.2024 18:18, Carlo Nonato wrote:
> Add a command line parameter to allow the user to set the coloring
> configuration for Dom0.
> A common configuration syntax for cache colors is introduced and
> documented.
> Take the opportunity to also add:
> - default configuration notion.
> -
On 29.01.2024 18:17, Carlo Nonato wrote:
> --- a/xen/arch/Kconfig
> +++ b/xen/arch/Kconfig
> @@ -31,3 +31,20 @@ config NR_NUMA_NODES
> associated with multiple-nodes management. It is the upper bound of
> the number of NUMA nodes that the scheduler, memory allocation and
>
I spotted the following warning for IRQ7 (along with IRQ6 and 10)
[0.686073] fedora kernel: __irq_set_trigger: genirq: No set_type
function for IRQ 7 (IR-IO-APIC)
This comes from kernel/irq/manage.c
int __irq_set_trigger(struct irq_desc *desc, unsigned long flags)
{
struct irq_chip *chip =
On 31/01/2024 15:32, John Ernberg wrote:
Hi Julien,
Hi John,
On 1/31/24 13:22, Julien Grall wrote:
Hi,
On 31/01/2024 11:50, John Ernberg wrote:
When using Linux for dom0 there are a bunch of drivers that need to do
SMC
SIP calls into the PSCI provider to enable certain hardware bits
On 29.01.2024 18:17, Carlo Nonato wrote:
> --- /dev/null
> +++ b/docs/misc/cache-coloring.rst
> @@ -0,0 +1,87 @@
> +Xen cache coloring user guide
> +=
> +
> +The cache coloring support in Xen allows to reserve Last Level Cache (LLC)
> +partitions for Dom0, DomUs and Xen
On 31.01.2024 16:57, Jan Beulich wrote:
> On 29.01.2024 18:17, Carlo Nonato wrote:
>> +Command line parameters
>> +***
>> +
>> +More specific documentation is available at
>> `docs/misc/xen-command-line.pandoc`.
>> +
>> ++--+---+
> On 31 Jan 2024, at 10:55, Andrew Cooper wrote:
>
> On 31/01/2024 10:44 am, Christian Lindig wrote:
>>> On 31 Jan 2024, at 10:42, Edwin Török wrote:
>>>
>>> Fix building oxenstored with OCaml 5.x.
>>> OCaml 5.x has removed some functions that have been deprecated for many
>>> years,
>>>
On 01.02.2024 12:50, Roger Pau Monné wrote:
> On Thu, Jan 11, 2024 at 10:00:10AM +0100, Jan Beulich wrote:
>> @@ -503,6 +538,9 @@ static int vmx_init_vmcs_config(bool bsp
>> "Secondary Exec Control",
>> vmx_secondary_exec_control, _vmx_secondary_exec_control);
>>
On Thu, Jan 11, 2024 at 10:00:10AM +0100, Jan Beulich wrote:
> This is a prereq to enabling the MSRLIST feature.
>
> Note that the PROCBASED_CTLS3 MSR is different from other VMX feature
> reporting MSRs, in that all 64 bits report allowed 1-settings.
>
> vVMX code is left alone, though, for the
On 01.02.2024 09:16, o...@proton.me wrote:
> Following our interaction on matrix, I send you the boot log `xl dmesg`
> output of my computer, booting with `iommu=debug` options on linux
> 6.6.13-200.fc39.
There's no "iommu=debug" anywhere in sight:
(XEN) Command line: placeholder no-real-mode
On 01/02/2024 10:45 am, Jan Beulich wrote:
> On 01.02.2024 11:33, Andrew Cooper wrote:
>> Right now, most of the static inline helpers take an unsigned nbits quantity,
>> and most of the library functions take a signed quanity. Because
>> BITMAP_LAST_WORD_MASK() is expressed as a divide, the
Hi all,
I'm pleased to announce the location of our next social event!
Join and chat with the Xen community, there will also be free food and
drinks.
*Date:* Wednesday 21st February 2024
*Time:* 5:30pm - 9pm (you are welcome to stay later if you wish)
*Location:*
The Portland Arms
129
On 01.02.2024 11:35, Andrew Cooper wrote:
> Nothing in bitmap.h uses lib.h, and there's no point including types.h when we
> need to include bitops.h anyway.
>
> Signed-off-by: Andrew Cooper
Acked-by: Jan Beulich
On 01.02.2024 11:33, Andrew Cooper wrote:
> Right now, most of the static inline helpers take an unsigned nbits quantity,
> and most of the library functions take a signed quanity. Because
> BITMAP_LAST_WORD_MASK() is expressed as a divide, the compiler is forced to
> emit two different paths to
Nothing in bitmap.h uses lib.h, and there's no point including types.h when we
need to include bitops.h anyway.
Signed-off-by: Andrew Cooper
---
CC: George Dunlap
CC: Jan Beulich
CC: Stefano Stabellini
CC: Wei Liu
CC: Julien Grall
---
xen/include/xen/bitmap.h | 2 --
1 file changed, 2
Right now, most of the static inline helpers take an unsigned nbits quantity,
and most of the library functions take a signed quanity. Because
BITMAP_LAST_WORD_MASK() is expressed as a divide, the compiler is forced to
emit two different paths to get the correct semantics for signed division.
On 26/01/2024 18.25, David Woodhouse wrote:
From: David Woodhouse
When converting to the shiny build-system-du-jour, a typo prevented the
last_i82596 driver from being built. Correct the config option name to
re-enable the build. And include "sysemu/sysemu.h" so it actually builds.
Fixes:
On Wed, Jan 31, 2024 at 01:00:14PM -0600, Bjorn Helgaas wrote:
> On Wed, Jan 31, 2024 at 09:58:19AM +0100, Roger Pau Monné wrote:
> > On Tue, Jan 30, 2024 at 02:44:03PM -0600, Bjorn Helgaas wrote:
> > > On Tue, Jan 30, 2024 at 10:07:36AM +0100, Roger Pau Monné wrote:
> > > > On Mon, Jan 29, 2024
Hi,
Following our interaction on matrix, I send you the boot log `xl dmesg` output
of my computer, booting with `iommu=debug` options on linux 6.6.13-200.fc39.
My issue is everything works on qubes on my thinkpad L15 gen 4 with AMD Ryzen 7
Pro 7730U, except iommu/amd-vi.
I can boot and use a
On Thu, Feb 01, 2024 at 08:39:31AM +0100, Jan Beulich wrote:
> There's no use for IOMMU code in the shim. Disable at least the vendor-
> specific code, until eventually IOMMU code can be disabled altogether.
>
> Signed-off-by: Jan Beulich
Acked-by: Roger Pau Monné
That was easier than I
On 01.02.2024 05:50, Stewart Hildebrand wrote:
> On 1/25/24 10:43, Jan Beulich wrote:
>> On 09.01.2024 22:51, Stewart Hildebrand wrote:
>>> --- a/xen/drivers/vpci/header.c
>>> +++ b/xen/drivers/vpci/header.c
>>> @@ -168,6 +168,9 @@ static void modify_decoding(const struct pci_dev *pdev,
>>>
87 matches
Mail list logo
