Re: [PATCH v8 02/17] xen: introduce generic non-atomic test_*bit()

On 06.05.2024 10:16, Oleksii wrote: > On Mon, 2024-05-06 at 08:33 +0200, Jan Beulich wrote: >> On 03.05.2024 19:15, Oleksii wrote: >>> On Thu, 2024-04-25 at 17:35 +0200, Jan Beulich wrote: >   #include >   > +#ifndef arch_check_bitop_size > +#define arch_check_bitop_size(addr)

Re: [PATCH v8 02/17] xen: introduce generic non-atomic test_*bit()

On Mon, 2024-05-06 at 08:33 +0200, Jan Beulich wrote: > On 03.05.2024 19:15, Oleksii wrote: > > On Thu, 2024-04-25 at 17:35 +0200, Jan Beulich wrote: > > > >   #include > > > >   > > > > +#ifndef arch_check_bitop_size > > > > +#define arch_check_bitop_size(addr) > > > > > > Can this really do

Re: [PATCH v8 02/17] xen: introduce generic non-atomic test_*bit()

On 03.05.2024 19:15, Oleksii wrote: > On Thu, 2024-04-25 at 17:35 +0200, Jan Beulich wrote: >>>   #include >>>   >>> +#ifndef arch_check_bitop_size >>> +#define arch_check_bitop_size(addr) >> >> Can this really do nothing? Passing the address of an object smaller >> than >> bitop_uint_t will

Re: [PATCH v8 02/17] xen: introduce generic non-atomic test_*bit()

On Thu, 2024-04-25 at 17:35 +0200, Jan Beulich wrote: > >   #include > >   > > +#ifndef arch_check_bitop_size > > +#define arch_check_bitop_size(addr) > > Can this really do nothing? Passing the address of an object smaller > than > bitop_uint_t will read past the object in the generic__*_bit()

Re: [PATCH v8 02/17] xen: introduce generic non-atomic test_*bit()

On 26.04.2024 10:14, Oleksii wrote: > On Thu, 2024-04-25 at 17:35 +0200, Jan Beulich wrote: >>>   /* - Please tidy above here - >>> */ >>>   >>>   #include >>>   >>> +#ifndef arch_check_bitop_size >>> +#define arch_check_bitop_size(addr) >> >> Can this

Re: [PATCH v8 02/17] xen: introduce generic non-atomic test_*bit()

On Thu, 2024-04-25 at 17:35 +0200, Jan Beulich wrote: > >   /* - Please tidy above here - > > */ > >   > >   #include > >   > > +#ifndef arch_check_bitop_size > > +#define arch_check_bitop_size(addr) > > Can this really do nothing? Passing the address

Re: [PATCH v8 02/17] xen: introduce generic non-atomic test_*bit()

On 17.04.2024 12:04, Oleksii Kurochko wrote: > --- a/xen/arch/ppc/include/asm/page.h > +++ b/xen/arch/ppc/include/asm/page.h > @@ -4,7 +4,7 @@ > > #include > > -#include > +#include > #include This wants to move up into the xen/*.h group then, like you have done ... > ---

[PATCH v8 02/17] xen: introduce generic non-atomic test_*bit()

The following generic functions were introduced: * test_bit * generic__test_and_set_bit * generic__test_and_clear_bit * generic__test_and_change_bit Also, the patch introduces the following generics which are used by the functions mentioned above: * BITOP_BITS_PER_WORD * BITOP_MASK * BITOP_WORD *