Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-10 Thread Jan Beulich
>>> On 10.07.18 at 13:00, wrote: > On Mon, Jul 09, 2018 at 06:45:16PM +0200, Roger Pau Monné wrote: >> On Fri, Jul 06, 2018 at 03:48:39PM +0200, Daniel Kiper wrote: >> > On Thu, Jul 05, 2018 at 09:47:57AM +0200, Roger Pau Monné wrote: >> > > On Wed, Jul 04, 2018 at 12:49:00PM +0200, Daniel Kiper

Re: [Xen-devel] [PATCH] hvm/altp2m: Clarify the proper way to extend the altp2m interface

2018-07-10 Thread Jan Beulich
>>> On 10.07.18 at 12:30, wrote: > On 07/10/2018 11:01 AM, Jan Beulich wrote: > On 10.07.18 at 11:33, wrote: >>> As far as I can tell there are three possible solutions to this >>> controversy: >>> >>> A. Remove the 'internal' functionality as a target by converting the >>> current HVMOP

[Xen-devel] [distros-debian-snapshot test] 74950: tolerable FAIL

2018-07-10 Thread Platform Team regression test user
flight 74950 distros-debian-snapshot real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/74950/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-i386-weekly-netinst-pygrub 10 debian-di-install fail like 74931

Re: [Xen-devel] [PATCH v2 8/8] efi: drop original xen.efi code and build mechanism

2018-07-10 Thread Daniel Kiper
On Fri, Jul 06, 2018 at 09:16:38AM -0600, Jan Beulich wrote: > >>> On 06.07.18 at 16:46, wrote: > > On Thu, Jul 05, 2018 at 02:35:32AM -0600, Jan Beulich wrote: > >> >>> On 04.07.18 at 18:48, wrote: > >> > On Wed, Jul 04, 2018 at 09:34:09AM -0600, Jan Beulich wrote: > >> >> >>> On 04.07.18 at

Re: [Xen-devel] Deprecating HVM_PARAM_PAE_ENABLED

2018-07-10 Thread Andrew Cooper
On 10/07/18 09:04, Wei Liu wrote: > On Mon, Jul 09, 2018 at 05:54:44PM +0100, Andrew Cooper wrote: >> Hello, >> >> (I feel as if I've sent this email before, but I can't find any record >> of it). >> >> The parameter was introduced in e661d66f51 (2006) and used in Xen, but >> removed from the

Re: [Xen-devel] Deprecating HVM_PARAM_PAE_ENABLED

2018-07-10 Thread Andrew Cooper
On 10/07/18 09:51, Jan Beulich wrote: On 09.07.18 at 18:54, wrote: >> The parameter was introduced in e661d66f51 (2006) and used in Xen, but >> removed from the hypervisor in c/s 5f14a87ce (2008) when CPUID >> calculations where moved from the hypervisor into libxc. >> >> However, the field

Re: [Xen-devel] [PATCH] hvm/altp2m: Clarify the proper way to extend the altp2m interface

2018-07-10 Thread Wei Liu
On Tue, Jul 10, 2018 at 10:33:22AM +0100, George Dunlap wrote: > The altp2m functionality was originally envisioned to be used in > several different configurations, one of which was a single in-guest > agent that had full operational control of altp2m. This required the > single hypercall to be

Re: [Xen-devel] [PATCH] hvm/altp2m: Clarify the proper way to extend the altp2m interface

2018-07-10 Thread George Dunlap
On 07/10/2018 10:43 AM, Roger Pau Monné wrote: > On Tue, Jul 10, 2018 at 10:33:22AM +0100, George Dunlap wrote: >> The altp2m functionality was originally envisioned to be used in >> several different configurations, one of which was a single in-guest >> agent that had full operational control of

[Xen-devel] [PATCH] x86: use VMLOAD for PV context switch

2018-07-10 Thread Jan Beulich
Having noticed that VMLOAD alone is about as fast as a single of the involved WRMSRs, I thought it might be a reasonable idea to also use it for PV. Measurements, however, have shown that an actual improvement can be achieved only with an early prefetch of the VMCB (thanks to Andrew for suggesting

[Xen-devel] [PATCH] x86: make arch_set_info_guest() match comments in load_segments()

2018-07-10 Thread Jan Beulich
For both fs_base and gs_base_user, there are comments saying "This can only be non-zero if selector is NULL." While save_segments() ensures this, so far arch_set_info_guest() didn't. Make behavior consistent (attaching comments identical to those in save_segments()). Signed-off-by: Jan Beulich

Re: [Xen-devel] [PATCH 2/2] MAINTAINERS: use https for git trees

2018-07-10 Thread Wei Liu
On Tue, Jul 10, 2018 at 11:28:34AM +0100, George Dunlap wrote: > On 07/10/2018 11:23 AM, Ian Jackson wrote: > > Wei Liu writes ("Re: [PATCH 2/2] MAINTAINERS: use https for git trees"): > >> On Tue, Jul 10, 2018 at 02:36:49AM -0600, Jan Beulich wrote: > >>> On 10.07.18 at 10:15, wrote: >

Re: [Xen-devel] [PATCH] hvm/altp2m: Clarify the proper way to extend the altp2m interface

2018-07-10 Thread George Dunlap
On 07/10/2018 11:01 AM, Jan Beulich wrote: On 10.07.18 at 11:33, wrote: >> As far as I can tell there are three possible solutions to this >> controversy: >> >> A. Remove the 'internal' functionality as a target by converting the >> current HVMOP into a DOMCTL. >> >> B. Have two hypercalls

Re: [Xen-devel] [PATCH] hvm/altp2m: Clarify the proper way to extend the altp2m interface

2018-07-10 Thread Wei Liu
On Tue, Jul 10, 2018 at 11:26:45AM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH] hvm/altp2m: Clarify the proper way to extend the > altp2m interface"): > > On Tue, Jul 10, 2018 at 10:33:22AM +0100, George Dunlap wrote: > > > + * Normally hypercalls made by a program in domain 0 in

Re: [Xen-devel] [PATCH 2/2] MAINTAINERS: use https for git trees

2018-07-10 Thread George Dunlap
On 07/10/2018 11:30 AM, Wei Liu wrote: > On Tue, Jul 10, 2018 at 11:28:34AM +0100, George Dunlap wrote: >> On 07/10/2018 11:23 AM, Ian Jackson wrote: >>> Wei Liu writes ("Re: [PATCH 2/2] MAINTAINERS: use https for git trees"): On Tue, Jul 10, 2018 at 02:36:49AM -0600, Jan Beulich wrote: >

Re: [Xen-devel] [PATCH v2 3/8] xen/x86: manually build xen.mb.efi binary

2018-07-10 Thread Daniel Kiper
On Fri, Jul 06, 2018 at 09:08:29AM -0600, Jan Beulich wrote: > >>> On 06.07.18 at 16:02, wrote: > > On Thu, Jul 05, 2018 at 02:18:03AM -0600, Jan Beulich wrote: > >> >>> On 04.07.18 at 18:35, wrote: > >> > On Wed, Jul 04, 2018 at 09:27:43AM -0600, Jan Beulich wrote: > >> >> >>> On 04.07.18 at

Re: [Xen-devel] [PATCH] hvm/altp2m: Clarify the proper way to extend the altp2m interface

2018-07-10 Thread George Dunlap
On 07/10/2018 11:59 AM, Ian Jackson wrote: > George Dunlap writes ("Re: [PATCH] hvm/altp2m: Clarify the proper way to > extend the altp2m interface"): >> On 07/10/2018 11:32 AM, Ian Jackson wrote: >>> We should have a way of remembering the design intent, even if it >>> hasn't been audited. >>>

Re: [Xen-devel] [PATCH] xen: correct DEFCONFIG_LIST Kconfig item

2018-07-10 Thread Jan Beulich
>>> On 10.07.18 at 10:31, wrote: > The default value of DEFCONFIG_LIST is wrong: it should be the value of > the configured ARCH_DEFCONFIG item, not the string "$ARCH_DEFCONFIG". Makse sense and matches Linux, but I'd still prefer to have Doug's consent here. Jan

Re: [Xen-devel] [PATCH 2/2] MAINTAINERS: use https for git trees

2018-07-10 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH 2/2] MAINTAINERS: use https for git trees"): > On Tue, Jul 10, 2018 at 02:36:49AM -0600, Jan Beulich wrote: > > On 10.07.18 at 10:15, wrote: > > > Signed-off-by: Wei Liu > > > > What's wrong with git:// ? I think the commit message should be non- > > empty here. > >

Re: [Xen-devel] [PATCH] hvm/altp2m: Clarify the proper way to extend the altp2m interface

2018-07-10 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH] hvm/altp2m: Clarify the proper way to extend the altp2m interface"): > On Tue, Jul 10, 2018 at 10:33:22AM +0100, George Dunlap wrote: > > + * Normally hypercalls made by a program in domain 0 in order to > > + * control a guest would be DOMCTLs rather than HVMOPs.

Re: [Xen-devel] [PATCH 2/2] MAINTAINERS: use https for git trees

2018-07-10 Thread George Dunlap
On 07/10/2018 11:23 AM, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH 2/2] MAINTAINERS: use https for git trees"): >> On Tue, Jul 10, 2018 at 02:36:49AM -0600, Jan Beulich wrote: >>> On 10.07.18 at 10:15, wrote: Signed-off-by: Wei Liu >>> >>> What's wrong with git:// ? I think the commit

Re: [Xen-devel] [PATCH] hvm/altp2m: Clarify the proper way to extend the altp2m interface

2018-07-10 Thread Ian Jackson
George Dunlap writes ("Re: [PATCH] hvm/altp2m: Clarify the proper way to extend the altp2m interface"): > On 07/10/2018 11:01 AM, Jan Beulich wrote: > Or 2a: Include a comment saying the 'internal' interface hasn't been > evaluated for safety, and don't bother blacklisting new ops until such > an

Re: [Xen-devel] [PATCH 2/2] MAINTAINERS: use https for git trees

2018-07-10 Thread Wei Liu
On Tue, Jul 10, 2018 at 11:36:33AM +0100, George Dunlap wrote: > On 07/10/2018 11:30 AM, Wei Liu wrote: > > On Tue, Jul 10, 2018 at 11:28:34AM +0100, George Dunlap wrote: > >> On 07/10/2018 11:23 AM, Ian Jackson wrote: > >>> Wei Liu writes ("Re: [PATCH 2/2] MAINTAINERS: use https for git trees"):

Re: [Xen-devel] [PATCH] hvm/altp2m: Clarify the proper way to extend the altp2m interface

2018-07-10 Thread George Dunlap
On 07/10/2018 11:32 AM, Ian Jackson wrote: > George Dunlap writes ("Re: [PATCH] hvm/altp2m: Clarify the proper way to > extend the altp2m interface"): >> On 07/10/2018 11:01 AM, Jan Beulich wrote: >> Or 2a: Include a comment saying the 'internal' interface hasn't been >> evaluated for safety, and

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-10 Thread Daniel Kiper
On Mon, Jul 09, 2018 at 06:45:16PM +0200, Roger Pau Monné wrote: > On Fri, Jul 06, 2018 at 03:48:39PM +0200, Daniel Kiper wrote: > > On Thu, Jul 05, 2018 at 09:47:57AM +0200, Roger Pau Monné wrote: > > > On Wed, Jul 04, 2018 at 12:49:00PM +0200, Daniel Kiper wrote: > > > > On Wed, Jul 04, 2018 at

Re: [Xen-devel] [PATCH] hvm/altp2m: Clarify the proper way to extend the altp2m interface

2018-07-10 Thread Ian Jackson
George Dunlap writes ("Re: [PATCH] hvm/altp2m: Clarify the proper way to extend the altp2m interface"): > On 07/10/2018 11:32 AM, Ian Jackson wrote: > > We should have a way of remembering the design intent, even if it > > hasn't been audited. > > > > SUPPORT.md can deal with the possible

Re: [Xen-devel] [PATCH V2] x86/p2m: fixed p2m_change_type_range() start / end check

2018-07-10 Thread George Dunlap
On 07/09/2018 09:31 AM, Razvan Cojocaru wrote: > On 04/23/2018 05:33 PM, Razvan Cojocaru wrote: >> On 04/23/2018 05:28 PM, George Dunlap wrote: >>> On 04/23/2018 12:56 PM, Razvan Cojocaru wrote: On 04/23/2018 02:47 PM, George Dunlap wrote: > On 04/18/2018 02:12 PM, Razvan Cojocaru wrote:

[Xen-devel] [xen-unstable-smoke test] 125074: tolerable all pass - PUSHED

2018-07-10 Thread osstest service owner
flight 125074 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/125074/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[Xen-devel] [xen-4.9-testing test] 125044: regressions - FAIL

2018-07-10 Thread osstest service owner
flight 125044 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/125044/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-xsm broken in 125005 test-amd64-amd64-xl-xsm

[Xen-devel] [ANNOUNCEMENT] Xen 4.11 is released

2018-07-10 Thread Juergen Gross
Dear community members, I'm pleased to announce that Xen 4.11.0 is released. Please find the tarball and its signature at: https://xenproject.org/downloads/xen-archives/xen-project-411-series/xen-project-4110.html You can also check out the tag in xen.git:

Re: [Xen-devel] Deprecating HVM_PARAM_PAE_ENABLED

2018-07-10 Thread Wei Liu
On Tue, Jul 10, 2018 at 12:45:39PM +0100, Andrew Cooper wrote: > On 10/07/18 09:04, Wei Liu wrote: > > On Mon, Jul 09, 2018 at 05:54:44PM +0100, Andrew Cooper wrote: > >> Hello, > >> > >> (I feel as if I've sent this email before, but I can't find any record > >> of it). > >> > >> The parameter

Re: [Xen-devel] [PATCH] hvm/altp2m: Clarify the proper way to extend the altp2m interface

2018-07-10 Thread George Dunlap
On 07/10/2018 12:58 PM, Jan Beulich wrote: On 10.07.18 at 12:30, wrote: >> On 07/10/2018 11:01 AM, Jan Beulich wrote: >> On 10.07.18 at 11:33, wrote: As far as I can tell there are three possible solutions to this controversy: A. Remove the 'internal' functionality

Re: [Xen-devel] [PATCH v2 01/13] grant_table: use term 'mfn' for machine frame numbers...

2018-07-10 Thread George Dunlap
On 07/07/2018 12:05 PM, Paul Durrant wrote: > ...rather than more ambiguous term 'frame'. > > There are many places in the grant table code that use a variable or > field name '.*frame' to refer to a quantity that is strictly an MFN, and > even has type mfn_t. > This patch is a purely cosmetic

Re: [Xen-devel] [PATCH] docs: adjust release management doc

2018-07-10 Thread Juergen Gross
On 26/04/18 12:52, Wei Liu wrote: > On Thu, Apr 26, 2018 at 12:48:44PM +0200, Juergen Gross wrote: >> Signed-off-by: Juergen Gross > > Acked-by: Wei Liu Ping? Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

[Xen-devel] [PATCH] tools: bump library version numbers to 4.12

2018-07-10 Thread Wei Liu
Signed-off-by: Wei Liu --- tools/libvchan/Makefile | 2 +- tools/libxc/Makefile| 2 +- tools/libxl/Makefile| 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/libvchan/Makefile b/tools/libvchan/Makefile index 8d45fc2411..de9b44978f 100644 ---

Re: [Xen-devel] [PATCH v3 2/2] doc: correct intel_psr_cat_cdp.pandoc syntax

2018-07-10 Thread Juergen Gross
On 08/05/18 15:06, Juergen Gross wrote: > On 08/05/18 14:56, George Dunlap wrote: >> On 05/08/2018 07:47 AM, Juergen Gross wrote: >>> "make -C docs all" fails due to incorrect markdown syntax in >>> intel_psr_cat_cdp.pandoc. Correct it. >>> >>> Signed-off-by: Juergen Gross >>> --- >>>

Re: [Xen-devel] [PATCH] tools/libxencall: enforce proper alignment of hypercall buffers

2018-07-10 Thread Juergen Gross
On 08/06/18 12:25, Juergen Gross wrote: > On 08/06/18 12:09, Andrew Cooper wrote: >> On 08/06/18 10:51, Juergen Gross wrote: >>> xencall_alloc_buffer() is used throughout Xen tools for allocating >>> hypercall buffers. Allocation is done at page granularity. For simple >>> administration each

Re: [Xen-devel] [PATCH] docs: adjust release management doc

2018-07-10 Thread Wei Liu
On Tue, Jul 10, 2018 at 03:23:46PM +0200, Juergen Gross wrote: > On 26/04/18 12:52, Wei Liu wrote: > > On Thu, Apr 26, 2018 at 12:48:44PM +0200, Juergen Gross wrote: > >> Signed-off-by: Juergen Gross > > > > Acked-by: Wei Liu > > Ping? Oops, this fell through the crack. I tried to apply it,

Re: [Xen-devel] [PATCH] docs: adjust release management doc

2018-07-10 Thread Juergen Gross
On 10/07/18 15:26, Wei Liu wrote: > On Tue, Jul 10, 2018 at 03:23:46PM +0200, Juergen Gross wrote: >> On 26/04/18 12:52, Wei Liu wrote: >>> On Thu, Apr 26, 2018 at 12:48:44PM +0200, Juergen Gross wrote: Signed-off-by: Juergen Gross >>> >>> Acked-by: Wei Liu >> >> Ping? > > Oops, this fell

[Xen-devel] [PATCH 0/2] MAINTAINERS cleanup

2018-07-10 Thread Wei Liu
Based on discussions in Lars' series. Wei Liu (2): MAINTAINERS: drop USB PV DRIVERS entry MAINTAINERS: use https for git trees MAINTAINERS | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) -- 2.11.0 ___ Xen-devel mailing

[Xen-devel] [PATCH 1/2] MAINTAINERS: drop USB PV DRIVERS entry

2018-07-10 Thread Wei Liu
Suggested-by: Jan Beulich Signed-off-by: Wei Liu --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Konrad Rzeszutek Wilk Cc: Stefano Stabellini Cc: Tim Deegan Cc: Wei Liu --- MAINTAINERS | 6 -- 1 file changed, 6 deletions(-) diff --git a/MAINTAINERS

Re: [Xen-devel] Deprecating HVM_PARAM_PAE_ENABLED

2018-07-10 Thread Roger Pau Monné
On Mon, Jul 09, 2018 at 05:54:44PM +0100, Andrew Cooper wrote: > Hello, > > (I feel as if I've sent this email before, but I can't find any record > of it). > > The parameter was introduced in e661d66f51 (2006) and used in Xen, but > removed from the hypervisor in c/s 5f14a87ce (2008) when CPUID

[Xen-devel] [PATCH] xen: correct DEFCONFIG_LIST Kconfig item

2018-07-10 Thread Juergen Gross
The default value of DEFCONFIG_LIST is wrong: it should be the value of the configured ARCH_DEFCONFIG item, not the string "$ARCH_DEFCONFIG". Signed-off-by: Juergen Gross --- xen/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/Kconfig b/xen/Kconfig index

Re: [Xen-devel] [PATCH 1/2] MAINTAINERS: drop USB PV DRIVERS entry

2018-07-10 Thread Jan Beulich
>>> On 10.07.18 at 10:15, wrote: > Suggested-by: Jan Beulich > Signed-off-by: Wei Liu Acked-by: Jan Beulich Thanks for remembering this - I had long forgotten. Jan ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] [PATCH 2/2] x86/msr: Rename the msr policy objects

2018-07-10 Thread Roger Pau Monné
On Mon, Jul 09, 2018 at 11:29:48AM +0100, Andrew Cooper wrote: > After attempting to develop the infrastructure, it turns out that the choice > of naming is suboptimal. > > Rename msr_domain_policy to just msr_policy to mirror the CPUID side of > things, and alter the 'dp' variable name

Re: [Xen-devel] [PATCH v2 1/4] automation: install texinfo

2018-07-10 Thread Wei Liu
On Mon, Jul 09, 2018 at 12:14:23PM -0500, Doug Goldstein wrote: > On Mon, Jul 09, 2018 at 04:32:13PM +0100, Wei Liu wrote: > > Stubdom's dependency newlib needs it. > > > > Signed-off-by: Wei Liu > > Could we consider <20180709170546.4102-1-car...@cardoe.com> instead? > >

Re: [Xen-devel] [PATCH v2 2/4] automation: install some packages for CentOS from EPEL

2018-07-10 Thread Wei Liu
On Mon, Jul 09, 2018 at 11:46:59AM -0500, Doug Goldstein wrote: > On Mon, Jul 09, 2018 at 04:32:14PM +0100, Wei Liu wrote: > > They are needed to build tools. > > > > Signed-off-by: Wei Liu > > --- > > automation/build/centos/7.2.dockerfile | 6 ++ > > 1 file changed, 6 insertions(+) > > >

[Xen-devel] [PATCH] x86/pvh: clarify Dom0 PVH build error message

2018-07-10 Thread Roger Pau Monne
Avoid having error messages with the same text. No functional change. Signed-off-by: Roger Pau Monné --- Cc: Jan Beulich Cc: Andrew Cooper --- xen/arch/x86/hvm/dom0_build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/dom0_build.c

Re: [Xen-devel] [PATCH 1/2] xen: Introduce an xmemdup() helper

2018-07-10 Thread Roger Pau Monné
On Mon, Jul 09, 2018 at 11:29:47AM +0100, Andrew Cooper wrote: > ... and use it in place of the opencoded instances. > > For consistency, restructure init_domain_cpuid_policy() to be like > init_{domain,vcpu}_msr_policy() by operating on the local pointer where > possible. > > No change in

Re: [Xen-devel] [PATCH 2/2] MAINTAINERS: use https for git trees

2018-07-10 Thread George Dunlap
> On Jul 10, 2018, at 9:15 AM, Wei Liu wrote: > > Signed-off-by: Wei Liu Why? -George > --- > Cc: Andrew Cooper > Cc: George Dunlap > Cc: Ian Jackson > Cc: Jan Beulich > Cc: Konrad Rzeszutek Wilk > Cc: Stefano Stabellini > Cc: Tim Deegan > Cc: Wei Liu > --- > MAINTAINERS | 10

Re: [Xen-devel] [PATCH 2/2] MAINTAINERS: use https for git trees

2018-07-10 Thread Jan Beulich
>>> On 10.07.18 at 10:15, wrote: > Signed-off-by: Wei Liu What's wrong with git:// ? I think the commit message should be non- empty here. Jan ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] [PATCH 2/2] MAINTAINERS: use https for git trees

2018-07-10 Thread Wei Liu
On Tue, Jul 10, 2018 at 02:36:49AM -0600, Jan Beulich wrote: > >>> On 10.07.18 at 10:15, wrote: > > Signed-off-by: Wei Liu > > What's wrong with git:// ? I think the commit message should be non- > empty here. git: is not encrypted, while https: is. At this time of age, it is better to use

Re: [Xen-devel] [PATCH 1/2] xen: Introduce an xmemdup() helper

2018-07-10 Thread Jan Beulich
>>> On 10.07.18 at 10:32, wrote: > On Mon, Jul 09, 2018 at 11:29:47AM +0100, Andrew Cooper wrote: >> --- a/xen/include/xen/xmalloc.h >> +++ b/xen/include/xen/xmalloc.h >> @@ -13,6 +13,16 @@ >> #define xmalloc(_type) ((_type *)_xmalloc(sizeof(_type), > __alignof__(_type))) >> #define

Re: [Xen-devel] [PATCH] x86/pvh: clarify Dom0 PVH build error message

2018-07-10 Thread Jan Beulich
>>> On 10.07.18 at 10:04, wrote: > Avoid having error messages with the same text. No functional change. > > Signed-off-by: Roger Pau Monné Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] [PATCH 1/2] xen: Introduce an xmemdup() helper

2018-07-10 Thread Andrew Cooper
On 10/07/2018 09:38, Jan Beulich wrote: On 10.07.18 at 10:32, wrote: >> On Mon, Jul 09, 2018 at 11:29:47AM +0100, Andrew Cooper wrote: >>> --- a/xen/include/xen/xmalloc.h >>> +++ b/xen/include/xen/xmalloc.h >>> @@ -13,6 +13,16 @@ >>> #define xmalloc(_type) ((_type *)_xmalloc(sizeof(_type),

Re: [Xen-devel] [PATCH 2/2] MAINTAINERS: use https for git trees

2018-07-10 Thread Wei Liu
On Tue, Jul 10, 2018 at 09:47:01AM +0100, Andrew Cooper wrote: > On 10/07/2018 09:39, Wei Liu wrote: > > On Tue, Jul 10, 2018 at 02:36:49AM -0600, Jan Beulich wrote: > > On 10.07.18 at 10:15, wrote: > >>> Signed-off-by: Wei Liu > >> What's wrong with git:// ? I think the commit message

Re: [Xen-devel] Deprecating HVM_PARAM_PAE_ENABLED

2018-07-10 Thread Jan Beulich
>>> On 09.07.18 at 18:54, wrote: > The parameter was introduced in e661d66f51 (2006) and used in Xen, but > removed from the hypervisor in c/s 5f14a87ce (2008) when CPUID > calculations where moved from the hypervisor into libxc. > > However, the field has always been propagated in the migration

Re: [Xen-devel] [PATCH 1/2] xen: Introduce an xmemdup() helper

2018-07-10 Thread Jan Beulich
>>> On 10.07.18 at 10:44, wrote: > On 10/07/2018 09:38, Jan Beulich wrote: > On 10.07.18 at 10:32, wrote: >>> On Mon, Jul 09, 2018 at 11:29:47AM +0100, Andrew Cooper wrote: --- a/xen/include/xen/xmalloc.h +++ b/xen/include/xen/xmalloc.h @@ -13,6 +13,16 @@ #define

[Xen-devel] [PATCH] hvm/altp2m: Clarify the proper way to extend the altp2m interface

2018-07-10 Thread George Dunlap
The altp2m functionality was originally envisioned to be used in several different configurations, one of which was a single in-guest agent that had full operational control of altp2m. This required the single hypercall to be an HVMOP, which is the only type of hypercall an HVM guest is allowed

Re: [Xen-devel] [PATCH] hvm/altp2m: Clarify the proper way to extend the altp2m interface

2018-07-10 Thread Roger Pau Monné
On Tue, Jul 10, 2018 at 10:33:22AM +0100, George Dunlap wrote: > The altp2m functionality was originally envisioned to be used in > several different configurations, one of which was a single in-guest > agent that had full operational control of altp2m. This required the > single hypercall to be

[Xen-devel] [PATCH 0/3] xl/libxl: fixes for vsnd

2018-07-10 Thread Wei Liu
Wei Liu (3): libxl/vsnd: add missing error checks xl/vsnd: use xcalloc to allocate memory for parser xl/vsnd: initialise rc in dryrun path tools/libxl/libxl_vsnd.c | 2 ++ tools/xl/xl_parse.c | 12 ++-- tools/xl/xl_vsnd.c | 1 + 3 files changed, 9 insertions(+), 6

[Xen-devel] [PATCH 1/3] libxl/vsnd: add missing error checks

2018-07-10 Thread Wei Liu
Reported-by: Coverity Signed-off-by: Wei Liu --- tools/libxl/libxl_vsnd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/libxl/libxl_vsnd.c b/tools/libxl/libxl_vsnd.c index cf46e3ddb1..9570a4cf0e 100644 --- a/tools/libxl/libxl_vsnd.c +++ b/tools/libxl/libxl_vsnd.c @@ -192,6 +192,7

[Xen-devel] [PATCH 2/3] xl/vsnd: use xcalloc to allocate memory for parser

2018-07-10 Thread Wei Liu
... because it handles errors for us. Reported-by: Coverity Signed-off-by: Wei Liu --- tools/xl/xl_parse.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 3ebf6d9023..f9147f6a5c 100644 --- a/tools/xl/xl_parse.c +++

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-10 Thread Roger Pau Monné
On Tue, Jul 10, 2018 at 05:47:19AM -0600, Jan Beulich wrote: > >>> On 10.07.18 at 13:00, wrote: > > On Mon, Jul 09, 2018 at 06:45:16PM +0200, Roger Pau Monné wrote: > >> Sorry for asking so many questions, but I would like to try to avoid > >> the DEFINED conditional in the linker script if

Re: [Xen-devel] [PATCH 0/3] xl/libxl: fixes for vsnd

2018-07-10 Thread Ian Jackson
Wei Liu writes ("[PATCH 0/3] xl/libxl: fixes for vsnd "): > Wei Liu (3): > libxl/vsnd: add missing error checks > xl/vsnd: use xcalloc to allocate memory for parser > xl/vsnd: initialise rc in dryrun path All three, Acked-by: Ian Jackson ___

Re: [Xen-devel] [PATCH v2 3/8] xen/x86: manually build xen.mb.efi binary

2018-07-10 Thread Jan Beulich
>>> On 10.07.18 at 12:48, wrote: > On Fri, Jul 06, 2018 at 09:08:29AM -0600, Jan Beulich wrote: >> >>> On 06.07.18 at 16:02, wrote: >> > On Thu, Jul 05, 2018 at 02:18:03AM -0600, Jan Beulich wrote: >> >> >>> On 04.07.18 at 18:35, wrote: >> >> > On Wed, Jul 04, 2018 at 09:27:43AM -0600, Jan

Re: [Xen-devel] [PATCH v2 8/8] efi: drop original xen.efi code and build mechanism

2018-07-10 Thread Jan Beulich
>>> On 10.07.18 at 13:35, wrote: > On Fri, Jul 06, 2018 at 09:16:38AM -0600, Jan Beulich wrote: >> >>> On 06.07.18 at 16:46, wrote: >> > OK, xen.mb.efi does not need relocs because: >> > - we generate PE file from xen-syms file like we do with ELF output; >> > so, the code in the PE file

Re: [Xen-devel] [PATCH v3 2/2] doc: correct intel_psr_cat_cdp.pandoc syntax

2018-07-10 Thread Wei Liu
On Tue, Jul 10, 2018 at 03:24:33PM +0200, Juergen Gross wrote: > On 08/05/18 15:06, Juergen Gross wrote: > > On 08/05/18 14:56, George Dunlap wrote: > >> On 05/08/2018 07:47 AM, Juergen Gross wrote: > >>> "make -C docs all" fails due to incorrect markdown syntax in > >>> intel_psr_cat_cdp.pandoc.

Re: [Xen-devel] [PATCH v2 02/13] iommu: introduce the concept of BFN...

2018-07-10 Thread Jan Beulich
>>> On 10.07.18 at 16:08, wrote: >> -Original Message- >> From: dunl...@gmail.com [mailto:dunl...@gmail.com] On Behalf Of >> George Dunlap >> Sent: 10 July 2018 14:47 >> To: Paul Durrant >> Cc: xen-devel ; Kevin Tian >> ; Stefano Stabellini ; >> Suravee Suthikulpanit ; Julien Grall >> ;

Re: [Xen-devel] [PATCH 2/7] iommu: make use of type-safe BFN and MFN in exported functions

2018-07-10 Thread Jan Beulich
>>> On 10.07.18 at 16:29, wrote: > On Thu, Mar 15, 2018 at 3:44 PM, Jan Beulich wrote: >>> --- a/xen/arch/x86/mm.c >>> +++ b/xen/arch/x86/mm.c >>> @@ -2676,13 +2676,12 @@ static int _get_page_type(struct page_info *page, > unsigned long type, >>> struct domain *d =

Re: [Xen-devel] [PATCH v2 03/13] iommu: make use of type-safe BFN and MFN in exported functions

2018-07-10 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 10 July 2018 15:29 > To: Paul Durrant > Cc: Julien Grall ; Andrew Cooper > ; George Dunlap > ; Ian Jackson ; Wei Liu > ; Jun Nakajima ; Kevin Tian > ; Stefano Stabellini ; xen- > devel ; Konrad Rzeszutek Wilk > ;

Re: [Xen-devel] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-10 Thread Leon Romanovsky
On Mon, Jul 09, 2018 at 02:29:08PM +0200, Michal Hocko wrote: > On Wed 27-06-18 09:44:21, Michal Hocko wrote: > > This is the v2 of RFC based on the feedback I've received so far. The > > code even compiles as a bonus ;) I haven't runtime tested it yet, mostly > > because I have no idea how. > > >

[Xen-devel] [PATCH 3/3] xl/vsnd: initialise rc in dryrun path

2018-07-10 Thread Wei Liu
Reported-by: Coverity Signed-off-by: Wei Liu --- tools/xl/xl_vsnd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/xl/xl_vsnd.c b/tools/xl/xl_vsnd.c index 6dd3a901b2..3306b93139 100644 --- a/tools/xl/xl_vsnd.c +++ b/tools/xl/xl_vsnd.c @@ -46,6 +46,7 @@ int main_vsndattach(int argc,

Re: [Xen-devel] [PATCH v2 02/13] iommu: introduce the concept of BFN...

2018-07-10 Thread George Dunlap
On Sat, Jul 7, 2018 at 12:05 PM, Paul Durrant wrote: > @@ -651,34 +651,34 @@ int amd_iommu_map_page(struct domain *d, unsigned long > gfn, unsigned long mfn, > if ( rc ) > { > spin_unlock(>arch.mapping_lock); > -AMD_IOMMU_DEBUG("Root table alloc failed, gfn = %lx\n",

Re: [Xen-devel] [PATCH v2 03/13] iommu: make use of type-safe BFN and MFN in exported functions

2018-07-10 Thread George Dunlap
On 07/07/2018 12:05 PM, Paul Durrant wrote: > This patch modifies the declaration of the entry points to the IOMMU > sub-system to use bfn_t and mfn_t in place of unsigned long. A subsequent > patch will similarly modify the methods in the iommu_ops structure. > > Signed-off-by: Paul Durrant >

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-10 Thread Jan Beulich
>>> On 10.07.18 at 15:49, wrote: > On Tue, Jul 10, 2018 at 05:47:19AM -0600, Jan Beulich wrote: >> >>> On 10.07.18 at 13:00, wrote: >> > On Mon, Jul 09, 2018 at 06:45:16PM +0200, Roger Pau Monné wrote: >> >> Sorry for asking so many questions, but I would like to try to avoid >> >> the DEFINED

Re: [Xen-devel] [PATCH v2 02/13] iommu: introduce the concept of BFN...

2018-07-10 Thread Paul Durrant
> -Original Message- > From: dunl...@gmail.com [mailto:dunl...@gmail.com] On Behalf Of > George Dunlap > Sent: 10 July 2018 14:47 > To: Paul Durrant > Cc: xen-devel ; Kevin Tian > ; Stefano Stabellini ; > Suravee Suthikulpanit ; Julien Grall > ; Jan Beulich > Subject: Re: [Xen-devel]

Re: [Xen-devel] [PATCH v2 03/13] iommu: make use of type-safe BFN and MFN in exported functions

2018-07-10 Thread Paul Durrant
> -Original Message- > From: George Dunlap [mailto:george.dun...@citrix.com] > Sent: 10 July 2018 15:01 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Jan Beulich ; Andrew Cooper > ; George Dunlap > ; Ian Jackson ; Konrad > Rzeszutek Wilk ; Stefano Stabellini > ; Julien Grall ;

Re: [Xen-devel] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-10 Thread Michal Hocko
On Tue 10-07-18 16:40:40, Leon Romanovsky wrote: > On Mon, Jul 09, 2018 at 02:29:08PM +0200, Michal Hocko wrote: > > On Wed 27-06-18 09:44:21, Michal Hocko wrote: > > > This is the v2 of RFC based on the feedback I've received so far. The > > > code even compiles as a bonus ;) I haven't runtime

[Xen-devel] [ovmf test] 125073: all pass - PUSHED

2018-07-10 Thread osstest service owner
flight 125073 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/125073/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 9edba51f93d8e81e09f905afc994efe02dbe524e baseline version: ovmf

Re: [Xen-devel] [PATCH 2/7] iommu: make use of type-safe BFN and MFN in exported functions

2018-07-10 Thread George Dunlap
On Thu, Mar 15, 2018 at 3:44 PM, Jan Beulich wrote: >> --- a/xen/arch/x86/mm.c >> +++ b/xen/arch/x86/mm.c >> @@ -2676,13 +2676,12 @@ static int _get_page_type(struct page_info *page, >> unsigned long type, >> struct domain *d = page_get_owner(page); >> if ( d && is_pv_domain(d)

Re: [Xen-devel] [PATCH v2 03/13] iommu: make use of type-safe BFN and MFN in exported functions

2018-07-10 Thread Jan Beulich
>>> On 10.07.18 at 16:10, wrote: >> -Original Message- >> From: George Dunlap [mailto:george.dun...@citrix.com] >> Sent: 10 July 2018 15:01 >> To: Paul Durrant ; xen-devel@lists.xenproject.org >> Cc: Jan Beulich ; Andrew Cooper >> ; George Dunlap >> ; Ian Jackson ; Konrad >> Rzeszutek

[Xen-devel] [xen-unstable-smoke test] 125076: tolerable all pass - PUSHED

2018-07-10 Thread osstest service owner
flight 125076 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/125076/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] [PATCH 2/7] iommu: make use of type-safe BFN and MFN in exported functions

2018-07-10 Thread Andrew Cooper
On 10/07/18 15:34, Jan Beulich wrote: On 10.07.18 at 16:29, wrote: >> On Thu, Mar 15, 2018 at 3:44 PM, Jan Beulich wrote: --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -2676,13 +2676,12 @@ static int _get_page_type(struct page_info *page, >> unsigned long type,

[Xen-devel] [PATCH] mm/page_alloc: correct first_dirty calculations during block merging

2018-07-10 Thread Sergey Dyasli
Currently it's possible to hit an assertion in alloc_heap_pages(): Assertion 'first_dirty != INVALID_DIRTY_IDX || !(pg[i].count_info & PGC_need_scrub)' failed at page_alloc.c:988 This can happen because a piece of logic to calculate first_dirty during block merging in free_heap_pages() is

Re: [Xen-devel] [PATCH 2/7] iommu: make use of type-safe BFN and MFN in exported functions

2018-07-10 Thread George Dunlap
On Tue, Jul 10, 2018 at 3:34 PM, Jan Beulich wrote: On 10.07.18 at 16:29, wrote: >> On Thu, Mar 15, 2018 at 3:44 PM, Jan Beulich wrote: --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -2676,13 +2676,12 @@ static int _get_page_type(struct page_info *page, >> unsigned long

Re: [Xen-devel] [PATCH] tools/libxencall: enforce proper alignment of hypercall buffers

2018-07-10 Thread Wei Liu
On Tue, Jul 10, 2018 at 03:25:07PM +0200, Juergen Gross wrote: > On 08/06/18 12:25, Juergen Gross wrote: > > On 08/06/18 12:09, Andrew Cooper wrote: > >> On 08/06/18 10:51, Juergen Gross wrote: > >>> xencall_alloc_buffer() is used throughout Xen tools for allocating > >>> hypercall buffers.

Re: [Xen-devel] x86 Community Call - Wed July 11, 14:00 - 15:00 UTC - Call details and agenda

2018-07-10 Thread Lars Kurth
Hi all, you can find the proposed agenda at https://docs.google.com/document/d/1fWQMuiblTmiNkWGGNbz20AQtbbnvtohxnUjhX2pA2jU/edit?usp=sharing covering essentially * Release Cadence for Xen 4.12 * Project Management stuff to keep the Momentum going There could be other items which we could add,

Re: [Xen-devel] [PATCH 2/7] iommu: make use of type-safe BFN and MFN in exported functions

2018-07-10 Thread Jan Beulich
>>> On 10.07.18 at 16:58, wrote: > On Tue, Jul 10, 2018 at 3:34 PM, Jan Beulich wrote: > On 10.07.18 at 16:29, wrote: >>> On Thu, Mar 15, 2018 at 3:44 PM, Jan Beulich wrote: > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -2676,13 +2676,12 @@ static int

Re: [Xen-devel] [PATCH] mm/page_alloc: correct first_dirty calculations during block merging

2018-07-10 Thread Boris Ostrovsky
On 07/10/2018 11:15 AM, Jan Beulich wrote: On 10.07.18 at 16:49, wrote: >> Currently it's possible to hit an assertion in alloc_heap_pages(): >> >> Assertion 'first_dirty != INVALID_DIRTY_IDX || !(pg[i].count_info & >> PGC_need_scrub)' failed at page_alloc.c:988 >> >> This can happen

Re: [Xen-devel] [PATCH v2 04/13] iommu: push use of type-safe BFN and MFN into iommu_ops

2018-07-10 Thread George Dunlap
On Sat, Jul 7, 2018 at 12:05 PM, Paul Durrant wrote: > @@ -787,7 +793,9 @@ int amd_iommu_reserve_domain_unity_map(struct domain > *domain, > gfn = phys_addr >> PAGE_SHIFT; > for ( i = 0; i < npages; i++ ) > { > -rt = amd_iommu_map_page(domain, gfn +i, gfn +i, flags); > +

Re: [Xen-devel] [PATCH v2 02/21] xen/arm: make allocate_memory work for non 1:1 mapped guests

2018-07-10 Thread Julien Grall
Hi Stefano, On 10/07/18 00:02, Stefano Stabellini wrote: On Mon, 9 Jul 2018, Julien Grall wrote: On 07/07/18 00:11, Stefano Stabellini wrote: mfn_t smfn; paddr_t start, size; +struct membank *bank; smfn = page_to_mfn(pg); start = mfn_to_maddr(smfn); The new

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-10 Thread Roger Pau Monné
On Tue, Jul 10, 2018 at 08:09:06AM -0600, Jan Beulich wrote: > >>> On 10.07.18 at 15:49, wrote: > > On Tue, Jul 10, 2018 at 05:47:19AM -0600, Jan Beulich wrote: > >> >>> On 10.07.18 at 13:00, wrote: > >> > On Mon, Jul 09, 2018 at 06:45:16PM +0200, Roger Pau Monné wrote: > >> >> Sorry for asking

Re: [Xen-devel] [PATCH v2 03/13] iommu: make use of type-safe BFN and MFN in exported functions

2018-07-10 Thread George Dunlap
On 07/07/2018 12:05 PM, Paul Durrant wrote: > This patch modifies the declaration of the entry points to the IOMMU > sub-system to use bfn_t and mfn_t in place of unsigned long. A subsequent > patch will similarly modify the methods in the iommu_ops structure. > > Signed-off-by: Paul Durrant >

Re: [Xen-devel] [PATCH v2 03/13] iommu: make use of type-safe BFN and MFN in exported functions

2018-07-10 Thread George Dunlap
On 07/10/2018 05:18 PM, Paul Durrant wrote: >> -Original Message- >> From: George Dunlap [mailto:george.dun...@citrix.com] >> Sent: 10 July 2018 17:13 >> To: Paul Durrant ; xen-devel@lists.xenproject.org >> Cc: Jan Beulich ; Andrew Cooper >> ; George Dunlap >> ; Ian Jackson ; Konrad >>

Re: [Xen-devel] [PATCH v2 05/13] iommu: don't domain_crash() inside iommu_map/unmap_page()

2018-07-10 Thread George Dunlap
On 07/07/2018 12:05 PM, Paul Durrant wrote: > Turn iommu_map/unmap_page() into straightforward wrappers that check the > existence of the relevant iommu_op and call through to it. This makes them > usable by PV IOMMU code to be delivered in future patches. > Leave the decision on whether to invoke

Re: [Xen-devel] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-10 Thread Leon Romanovsky
On Tue, Jul 10, 2018 at 04:14:10PM +0200, Michal Hocko wrote: > On Tue 10-07-18 16:40:40, Leon Romanovsky wrote: > > On Mon, Jul 09, 2018 at 02:29:08PM +0200, Michal Hocko wrote: > > > On Wed 27-06-18 09:44:21, Michal Hocko wrote: > > > > This is the v2 of RFC based on the feedback I've received

Re: [Xen-devel] [PATCH v2 06/21] xen/arm: do not pass dt_host to make_memory_node and make_hypervisor_node

2018-07-10 Thread Julien Grall
Hi, On 09/07/18 22:51, Stefano Stabellini wrote: I would replace this with a BUG_ON(evtchn != 0). I agree with the principle, but I think you meant BUG_ON(d->arch.evtchn_irq <= 0) ? The IRQ is an unsigned number. So why <= 0? Cheers, -- Julien Grall

[Xen-devel] [PATCH 4.9 17/52] x86/xen: Add call of speculative_store_bypass_ht_init() to PV paths

2018-07-10 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Juergen Gross commit 74899d92e3dc7671a8017b3146dcd4735f3b upstream. Commit: 1f50ddb4f418 ("x86/speculation: Handle HT correctly on AMD") ... added speculative_store_bypass_ht_init() to

Re: [Xen-devel] [PATCH v2 03/13] iommu: make use of type-safe BFN and MFN in exported functions

2018-07-10 Thread Paul Durrant
> -Original Message- > From: George Dunlap [mailto:george.dun...@citrix.com] > Sent: 10 July 2018 17:13 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Jan Beulich ; Andrew Cooper > ; George Dunlap > ; Ian Jackson ; Konrad > Rzeszutek Wilk ; Stefano Stabellini > ; Julien Grall ;

[Xen-devel] [linux-4.14 test] 125049: regressions - FAIL

2018-07-10 Thread osstest service owner
flight 125049 linux-4.14 real [real] http://logs.test-lab.xenproject.org/osstest/logs/125049/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-build fail in 125009 REGR. vs. 124389 Tests which are

  1   2   >