[XenPPC] Re: [Xen-devel] [PATCH 0/3] [RFC] User-space grant table device

2007-03-23 Thread Mark Williamson
> I really like the early cleanup hook in your patches to cleanly unmap > any outstanding granted pages before zapping the range on vm area > destruction. It's something that I've been wanting to do for a while > -- very stability-adding. ;) Yep; as far as we could tell, this should clean up the

[XenPPC] Re: [Xen-devel] [PATCH 0/3] [RFC] User-space grant table device

2007-03-23 Thread Derek Murray
On 22 Mar 2007, at 02:28, Isaku Yamahata wrote: When auto translate physmap mode, grant table works based on pseudo physical address space. not virtual address space. Please see gnttab_set_map/unmap_op() using __pa(). It is up to the guest kernel to map the pseudo physical address to kernel/user

[XenPPC] Re: [Xen-devel] [PATCH 0/3] [RFC] User-space grant table device

2007-03-21 Thread Isaku Yamahata
On Wed, Mar 21, 2007 at 11:29:29AM +, Derek Murray wrote: > blktap appears to map each grant into kernel space and, when not > using auto-translated mode, into user space as well. If it is using > auto-translated mode, then the grant is only mapped into the kernel. When auto translate phys

[XenPPC] Re: [Xen-devel] [PATCH 0/3] [RFC] User-space grant table device

2007-03-21 Thread Andrew Warfield
Am I correct in thinking that the use of the VM_FOREIGN flag, plus the use of vm_private_data to store an array of struct page pointers, enables the pages to be mapped into user space using get_user_pages() (which is called by make_pages_present(), which is called by do_mmap_pgoff())? Or is it the

[XenPPC] Re: [Xen-devel] [PATCH 0/3] [RFC] User-space grant table device

2007-03-21 Thread Derek Murray
On 21 Mar 2007, at 04:32, Isaku Yamahata wrote: This patch doesn't work on ia64 and ppc because they doesn't support GNTMAP_application_map which is x86 speicific. The flag doesn't make sense for ia64 and ppc. (When auto_translated_physmap_mode is enabled, GNTMAP_application_map isn't necessary.)

[XenPPC] Re: [Xen-devel] [PATCH 0/3] [RFC] User-space grant table device

2007-03-20 Thread Isaku Yamahata
On Mon, Mar 19, 2007 at 10:40:18AM +, Derek Murray wrote: > 1. gntdev.patch: This is the main driver, and associated header file. This patch doesn't work on ia64 and ppc because they doesn't support GNTMAP_application_map which is x86 speicific. The flag doesn't make sense for ia64 and ppc. (