Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-09 Thread Philippe Gerum
Jan Kiszka wrote: Philippe Gerum wrote: Anders Blomdell wrote: My distinct feeling is that the return value should be a scalar and not a set! To sum up, the valid return values are HANDLED, HANDLED | ENABLE (*), HANDLED | CHAINED and CHAINED. It's currently a set because I once thought th

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-09 Thread Dmitry Adamushko
On 09/02/06, Jan Kiszka <[EMAIL PROTECTED]> wrote: Philippe Gerum wrote:> Anders Blomdell wrote:>>> My distinct feeling is that the return value should be a scalar and>> not a set! To sum up, the valid return values are HANDLED, HANDLED | ENABLE (*), > HANDLED | CHAINED and CHAINED. It's curren

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-09 Thread Anders Blomdell
Philippe Gerum wrote: Anders Blomdell wrote: Philippe Gerum wrote: Jan Kiszka wrote: Wolfgang Grandegger wrote: Hello, Dmitry Adamushko wrote: Hi, this is the final set of patches against the SVN trunk of 2006-02-03. It addresses mostly remarks concerning naming (XN_ISR_ISA -> XN_ISR

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-09 Thread Jan Kiszka
Philippe Gerum wrote: > Anders Blomdell wrote: > >> My distinct feeling is that the return value should be a scalar and >> not a set! >> > > To sum up, the valid return values are HANDLED, HANDLED | ENABLE (*), > HANDLED | CHAINED and CHAINED. It's currently a set because I once > thought that th

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-09 Thread Philippe Gerum
Jan Kiszka wrote: Anders Blomdell wrote: Philippe Gerum wrote: Jan Kiszka wrote: Wolfgang Grandegger wrote: Hello, Dmitry Adamushko wrote: Hi, this is the final set of patches against the SVN trunk of 2006-02-03. It addresses mostly remarks concerning naming (XN_ISR_ISA -> XN_ISR_

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-09 Thread Philippe Gerum
Anders Blomdell wrote: Philippe Gerum wrote: Jan Kiszka wrote: Wolfgang Grandegger wrote: Hello, Dmitry Adamushko wrote: Hi, this is the final set of patches against the SVN trunk of 2006-02-03. It addresses mostly remarks concerning naming (XN_ISR_ISA -> XN_ISR_EDGE), a few cleanups a

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-09 Thread Jan Kiszka
Anders Blomdell wrote: > Philippe Gerum wrote: >> Jan Kiszka wrote: >> >>> Wolfgang Grandegger wrote: >>> Hello, Dmitry Adamushko wrote: > Hi, > > this is the final set of patches against the SVN trunk of 2006-02-03. > > It addresses mostly remarks concerning

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-09 Thread Anders Blomdell
Philippe Gerum wrote: Jan Kiszka wrote: Wolfgang Grandegger wrote: Hello, Dmitry Adamushko wrote: Hi, this is the final set of patches against the SVN trunk of 2006-02-03. It addresses mostly remarks concerning naming (XN_ISR_ISA -> XN_ISR_EDGE), a few cleanups and updated comments. Fun

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-09 Thread Philippe Gerum
Jan Kiszka wrote: Philippe Gerum wrote: Anders Blomdell wrote: My distinct feeling is that the return value should be a scalar and not a set! To sum up, the valid return values are HANDLED, HANDLED | ENABLE (*), HANDLED | CHAINED and CHAINED. It's currently a set because I once thought th

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-09 Thread Dmitry Adamushko
On 09/02/06, Jan Kiszka <[EMAIL PROTECTED]> wrote: Philippe Gerum wrote:> Anders Blomdell wrote:>>> My distinct feeling is that the return value should be a scalar and>> not a set! To sum up, the valid return values are HANDLED, HANDLED | ENABLE (*), > HANDLED | CHAINED and CHAINED. It's curren

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-09 Thread Anders Blomdell
Philippe Gerum wrote: Anders Blomdell wrote: Philippe Gerum wrote: Jan Kiszka wrote: Wolfgang Grandegger wrote: Hello, Dmitry Adamushko wrote: Hi, this is the final set of patches against the SVN trunk of 2006-02-03. It addresses mostly remarks concerning naming (XN_ISR_ISA -> XN_ISR

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-09 Thread Jan Kiszka
Philippe Gerum wrote: > Anders Blomdell wrote: > >> My distinct feeling is that the return value should be a scalar and >> not a set! >> > > To sum up, the valid return values are HANDLED, HANDLED | ENABLE (*), > HANDLED | CHAINED and CHAINED. It's currently a set because I once > thought that th

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-09 Thread Philippe Gerum
Jan Kiszka wrote: Anders Blomdell wrote: Philippe Gerum wrote: Jan Kiszka wrote: Wolfgang Grandegger wrote: Hello, Dmitry Adamushko wrote: Hi, this is the final set of patches against the SVN trunk of 2006-02-03. It addresses mostly remarks concerning naming (XN_ISR_ISA -> XN_ISR_

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-09 Thread Philippe Gerum
Anders Blomdell wrote: Philippe Gerum wrote: Jan Kiszka wrote: Wolfgang Grandegger wrote: Hello, Dmitry Adamushko wrote: Hi, this is the final set of patches against the SVN trunk of 2006-02-03. It addresses mostly remarks concerning naming (XN_ISR_ISA -> XN_ISR_EDGE), a few cleanups a

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-09 Thread Jan Kiszka
Anders Blomdell wrote: > Philippe Gerum wrote: >> Jan Kiszka wrote: >> >>> Wolfgang Grandegger wrote: >>> Hello, Dmitry Adamushko wrote: > Hi, > > this is the final set of patches against the SVN trunk of 2006-02-03. > > It addresses mostly remarks concerning

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-09 Thread Anders Blomdell
Philippe Gerum wrote: Jan Kiszka wrote: Wolfgang Grandegger wrote: Hello, Dmitry Adamushko wrote: Hi, this is the final set of patches against the SVN trunk of 2006-02-03. It addresses mostly remarks concerning naming (XN_ISR_ISA -> XN_ISR_EDGE), a few cleanups and updated comments. Fun

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-08 Thread Philippe Gerum
Jan Kiszka wrote: Wolfgang Grandegger wrote: Hello, Dmitry Adamushko wrote: Hi, this is the final set of patches against the SVN trunk of 2006-02-03. It addresses mostly remarks concerning naming (XN_ISR_ISA -> XN_ISR_EDGE), a few cleanups and updated comments. Functionally, the support f

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-08 Thread Dmitry Adamushko
On 08/02/06, Jan Kiszka <[EMAIL PROTECTED]> wrote: > I still prefer configuration options as they also allow to reduce the> overall code size (less cache refills and TLB misses). And shared > interrupts are for x86 only (approximately), I think. Unfortunately, IOk, that's a good argument. Then ma

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-08 Thread Jan Kiszka
Wolfgang Grandegger wrote: > Jan Kiszka wrote: >> Wolfgang Grandegger wrote: >>> Hello, >>> >>> Dmitry Adamushko wrote: Hi, this is the final set of patches against the SVN trunk of 2006-02-03. It addresses mostly remarks concerning naming (XN_ISR_ISA -> XN_ISR_EDGE),

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-08 Thread Wolfgang Grandegger
Jan Kiszka wrote: Wolfgang Grandegger wrote: Hello, Dmitry Adamushko wrote: Hi, this is the final set of patches against the SVN trunk of 2006-02-03. It addresses mostly remarks concerning naming (XN_ISR_ISA -> XN_ISR_EDGE), a few cleanups and updated comments. Functionally, the support for

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-08 Thread Philippe Gerum
Jan Kiszka wrote: Wolfgang Grandegger wrote: Hello, Dmitry Adamushko wrote: Hi, this is the final set of patches against the SVN trunk of 2006-02-03. It addresses mostly remarks concerning naming (XN_ISR_ISA -> XN_ISR_EDGE), a few cleanups and updated comments. Functionally, the support f

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-08 Thread Dmitry Adamushko
On 08/02/06, Jan Kiszka <[EMAIL PROTECTED]> wrote: > I still prefer configuration options as they also allow to reduce the> overall code size (less cache refills and TLB misses). And shared > interrupts are for x86 only (approximately), I think. Unfortunately, IOk, that's a good argument. Then ma

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-08 Thread Jan Kiszka
Wolfgang Grandegger wrote: > Jan Kiszka wrote: >> Wolfgang Grandegger wrote: >>> Hello, >>> >>> Dmitry Adamushko wrote: Hi, this is the final set of patches against the SVN trunk of 2006-02-03. It addresses mostly remarks concerning naming (XN_ISR_ISA -> XN_ISR_EDGE),

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-07 Thread Wolfgang Grandegger
Jan Kiszka wrote: Wolfgang Grandegger wrote: Hello, Dmitry Adamushko wrote: Hi, this is the final set of patches against the SVN trunk of 2006-02-03. It addresses mostly remarks concerning naming (XN_ISR_ISA -> XN_ISR_EDGE), a few cleanups and updated comments. Functionally, the support for

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-07 Thread Dmitry Adamushko
On 07/02/06, Wolfgang Grandegger <[EMAIL PROTECTED]> wrote: Hello,> [skip-skip-skip]> Happy testing ! :)My concern is code size. I see that the patches add substantial amountof code to the ISR. What about make this feature configurable? Yes, I though about making the new stuff optionally configura

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-07 Thread Jan Kiszka
Wolfgang Grandegger wrote: > Hello, > > Dmitry Adamushko wrote: >> >> Hi, >> >> this is the final set of patches against the SVN trunk of 2006-02-03. >> >> It addresses mostly remarks concerning naming (XN_ISR_ISA -> >> XN_ISR_EDGE), a few cleanups and updated comments. >> >> Functionally, the sup

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-07 Thread Dmitry Adamushko
On 07/02/06, Wolfgang Grandegger <[EMAIL PROTECTED]> wrote: Hello,> [skip-skip-skip]> Happy testing ! :)My concern is code size. I see that the patches add substantial amountof code to the ISR. What about make this feature configurable? Yes, I though about making the new stuff optionally configura

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-07 Thread Wolfgang Grandegger
Hello, Dmitry Adamushko wrote: Hi, this is the final set of patches against the SVN trunk of 2006-02-03. It addresses mostly remarks concerning naming (XN_ISR_ISA -> XN_ISR_EDGE), a few cleanups and updated comments. Functionally, the support for shared interrupts (a few flags) to the rtd

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-07 Thread Jan Kiszka
Wolfgang Grandegger wrote: > Hello, > > Dmitry Adamushko wrote: >> >> Hi, >> >> this is the final set of patches against the SVN trunk of 2006-02-03. >> >> It addresses mostly remarks concerning naming (XN_ISR_ISA -> >> XN_ISR_EDGE), a few cleanups and updated comments. >> >> Functionally, the sup

[Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-07 Thread Dmitry Adamushko
Hi, this is the final set of patches against the SVN trunk of 2006-02-03. It addresses mostly remarks concerning naming (XN_ISR_ISA -> XN_ISR_EDGE), a few cleanups and updated comments. Functionally, the support for shared interrupts (a few flags) to the rtdm (Jan's patch) and native skin. In th

Re: [Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-07 Thread Wolfgang Grandegger
Hello, Dmitry Adamushko wrote: Hi, this is the final set of patches against the SVN trunk of 2006-02-03. It addresses mostly remarks concerning naming (XN_ISR_ISA -> XN_ISR_EDGE), a few cleanups and updated comments. Functionally, the support for shared interrupts (a few flags) to the rtd

[Xenomai-core] [Combo-PATCH] Shared interrupts (final)

2006-02-07 Thread Dmitry Adamushko
Hi, this is the final set of patches against the SVN trunk of 2006-02-03. It addresses mostly remarks concerning naming (XN_ISR_ISA -> XN_ISR_EDGE), a few cleanups and updated comments. Functionally, the support for shared interrupts (a few flags) to the rtdm (Jan's patch) and native skin. In th